Re: [PATCH 3/6] [DCCP]: Bug-Fix - AWL was never updated

2008-01-28 Thread Ian McDonald
Renker [EMAIL PROTECTED] Yes I had seen this and had worked out that variables weren't being updated as they should be but hadn't got as far as a fix before I stopped my coding days so much :-( Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp

Re: CCID2 TCP Friendliness Test ?

2008-01-16 Thread Ian McDonald
On Jan 17, 2008 5:17 PM, maillist ifiaas [EMAIL PROTECTED] wrote: Hi friends,, Where can we find CCID2 (latest Linux release) test against TCP ? There seems no measurement study to validate the TCP friendliness on any existing implementation yet, including BSD. Emmanuel Lochin has did some

Re: dccp send

2008-01-03 Thread Ian McDonald
On Jan 4, 2008 11:19 AM, Tomasz Grobelny [EMAIL PROTECTED] wrote: I think I almost got it. Thanks a lot for the detailed explanation. But I've got two more questions: 1. How can I control the amount of memory allowed to be allocated for the socket send buffer? It it somehow connected with

Re: mirror?

2007-12-24 Thread Ian McDonald
On 12/25/07, Tomasz Grobelny [EMAIL PROTECTED] wrote: As http://www.erg.abdn.ac.uk/ seems to be down at least since yesterday I'd like to ask whether any mirror of dccp git tree and/or dccp patches to mainline kernel is available. TIA, -- Regards, Tomasz Grobelny Here is the announcement of

Re: [PATCH 1/8] Remove unnecessary comments to ccids code

2007-12-20 Thread Ian McDonald
the misspelling of copyright in ccid-4 code, reported by Ian. Note that this patches just apply to ccids code, not for the hole DCCP code. Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: DCCP source code

2007-12-14 Thread Ian McDonald
On 12/15/07, Gerrit Renker [EMAIL PROTECTED] wrote: Ian McDonald has written an implementation of Faster Restart (contact Ian for further information); this was also in form of a subtree. It is not currently online, but if there is interest, I am happy to put up the patches as Faster

Re: [RFC][PATCHES 0/7]: Reorganization of RX history patches

2007-12-03 Thread Ian McDonald
On 12/3/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: WARNING: After reading some messages from Ingo Molnar on lkml I think we should really trim the number of lists we use for kernel development. And since I moved back to using mutt for reading e-mails, something

Re: [PATCH 6/9] [CCID2]: Redundant debugging output

2007-11-07 Thread Ian McDonald
tx_packet_sent() prints pipe/cwnd already, the second printk for pipe is redundant. * In tx_packet_sent() the check_sanity function is called twice (at the begin and at the end). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list

Re: [PATCH 5/9] [CCID2]: Replace pipe assignment-function with assignment

2007-11-07 Thread Ian McDonald
). As a result, a BUG_ON test for negative values now becomes obsolete (for safety not removed, but replaced with a less annoying `DCCP_BUG'). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 8/9] [CCID2]: Remove redundant ack-counting variable

2007-11-07 Thread Ian McDonald
PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 23/25] Include ccid-4 to be visible for the DCCP feature negotiation mechanism

2007-11-06 Thread Ian McDonald
Sales [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/25] Share TFRC sender states via tfrc_ccids

2007-11-04 Thread Ian McDonald
On 11/2/07, Tommi Saviranta [EMAIL PROTECTED] wrote: On Wed, Oct 31, 2007 at 21:31:02 -0300, Leandro wrote: [CCID-3/4] Share TFRC sender states via tfrc_ccids Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Acked-by: Tommi Saviranta [EMAIL PROTECTED] - To unsubscribe from this

Re: [PATCH 1/9] [CCID2]: Disable broken Ack Ratio adaptation algorithm

2007-11-03 Thread Ian McDonald
algorithm is necessary, which will not necessarily use the same variables as used by the unfinished one; hence the old variables have been removed. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp

Re: [PATCH 4/25] Set packet size to 1460 as per ccid-4 draft

2007-11-02 Thread Ian McDonald
On 11/1/07, Leandro [EMAIL PROTECTED] wrote: [CCID-4] Set packet size to 1460 as per ccid-4 draft Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Signed-off-by: Tommi Saviranta [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: [PATCH 7/25] Initial lib for sharing common code between ccid-3/ccid-4

2007-11-02 Thread Ian McDonald
On 11/1/07, Leandro [EMAIL PROTECTED] wrote: [CCID-3/4 lib] Initial lib for sharing common code between ccid-3/ccid-4 The lib is called tfrc_ccids.o Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [PATCH 1/6]: Don't process Ack twice in Respond state

2007-10-27 Thread Ian McDonald
the connection is closing anyway??? Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/6]: Fix sequence number arithmetic/comparisons

2007-10-27 Thread Ian McDonald
On 10/28/07, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID2]: Fix sequence number arithmetic/comparisons This replaces use of normal subtraction with modulo-48 subtraction. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list

Re: [PATCH 4/6]: Don't assign negative values to Ack Ratio

2007-10-27 Thread Ian McDonald
, this patch disallows this possibility. As a consequence, a Bug test for negative Ack Ratio values becomes obsolete. Furthermore, a check against overflow (as Ack Ratio may not exceed 2 bytes, due to RFC 4340, 11.3) has been added. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian

Re: [PATCH 5/6]: Deadlock and spurious timeouts when Ack Ratio cwnd

2007-10-27 Thread Ian McDonald
. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6]: Larger initial windows also for CCID2

2007-10-27 Thread Ian McDonald
-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More

Re: Gstreamer e DCCP: issues related to ccid-3

2007-10-25 Thread Ian McDonald
On 10/25/07, Gerrit Renker [EMAIL PROTECTED] wrote: /* something like (but do have a look at the paraslash sources) do { wrote = send (socket, (const char *) buf + bytes_written, count - bytes_written, MSG_NOSIGNAL); } while (wrote 0 errno ==

Re: [PATCH][DCCP 1/1] Implement SIOCINQ/FIONREAD

2007-10-23 Thread Ian McDonald
On 10/24/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: Just like UDP. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Signed-off-by: Leandro Melo de Sales [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [PATCH 7/8]: Remove unused inline function

2007-10-20 Thread Ian McDonald
On 7/9/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Remove unused inline function The function follows48(), which is a special-case of dccp_delta_seqno(), is nowhere used in the DCCP code, thus removed by this patch. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian

Re: [PATCH 8/8]: Initialisation assignments of 0 are redundant

2007-10-20 Thread Ian McDonald
the redundant assignments. Thanks to Arnaldo for the inspiration. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 2/3]: One more exemption from full sequence number checks

2007-10-20 Thread Ian McDonald
Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/10]: Dedicated auxiliary states to support passive-close

2007-10-20 Thread Ian McDonald
and CLOSING states (this is done by the subsequent patches). Further documentation is on http://www.erg.abdn.ac.uk/users/gerrit/dccp/docs/closing_states/ Signed-off-by: Gerrit Renker [EMAIL PROTECTED] This was signed off by me on Sep 6th but seems to have got lost so: Signed-off-by: Ian

Re: [PATCH 2/6]: Provide fallback RTT value when none is available

2007-10-20 Thread Ian McDonald
but this seems to have got lost so: Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/14]: Implement both feature-local and feature-remote Sequence Window feature

2007-10-20 Thread Ian McDonald
Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5]: Documentation for CCID operations

2007-10-13 Thread Ian McDonald
On 10/12/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Documentation for CCID operations This adds documentation for the ccid_operations structure. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [PATCH 3/5]: Introducing CCMPS

2007-10-13 Thread Ian McDonald
direct TCP counterparts. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/14]: No more CCID control blocks in LISTEN state

2007-10-11 Thread Ian McDonald
become redundant. Thanks to Ian McDonald for discussion on this. As a further byproduct of enabling the CCIDs only after the connection has been fully established, several typecast-initialisations of ccid3_hc_{rx,tx}_sock can now be eliminated: * the CCID is loaded, so

Re: [PATCH 1/1]: Test tree update (was Re: [PATCH 3/10]: Dedicated auxiliary states to support passive-close)

2007-10-09 Thread Ian McDonald
/DCCP_ACTIVE_CLOSEREQ/g; /* server sending a CloseReq */ However, for pretty-printing and system logs, the name of the last state remains at `CLOSEREQ', for consistency. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list

Re: [PATCH 12/14]: Implement both feature-local and feature-remote Sequence Window feature

2007-10-05 Thread Ian McDonald
On 10/5/07, Gerrit Renker [EMAIL PROTECTED] wrote: Ian - | Hmmm I had multiple problems when the default window was 100 when | testing in the past - from memory particularly with long RTT, low loss | links. Try putting 100 ms delay on a 100 Mbits/link and see what | happens... | |

Re: [PATCH 2/5]: Support for the exchange of NN options in established state

2007-10-05 Thread Ian McDonald
for any NN option, this fact has been the reason for limiting the current use to Ack Ratio. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 4/5]: Minisock unemployed

2007-10-05 Thread Ian McDonald
completes). The sysctls now seed the initial feature values and can optionally be overridden on a per-connection basis using sockopts (as for example in the CCID-sockopt patches). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from

Re: [PATCH v3 4/9]: Resolve dependencies of features on choice of CCID

2007-10-03 Thread Ian McDonald
On 10/3/07, Gerrit Renker [EMAIL PROTECTED] wrote: Reworked patch, updated as requested: * removed `typedef const' * made all initialisation explicit, using field initialisers This increases the space somewhat, but indeed much better readability. * Ian I have added your Acked-by as

Re: [PATCH 3/14]: Integration of dynamic feature activation - part 2 (server side)

2007-10-03 Thread Ian McDonald
, however). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/14]: No more CCID control blocks in LISTEN state

2007-10-03 Thread Ian McDonald
, the only states visible to CCIDs now are OPEN/PARTOPEN, and the closing states. This allows to remove tests which were previously necessary to protect against referencing a socket in the listening state (in CCID3), but which now have become redundant. Thanks to Ian McDonald for discussion

Re: [PATCH 9/14]: Phase out the use of boolean flag for Ack Vectors

2007-10-03 Thread Ian McDonald
dccp_feat_activate_values() (which takes care of all the feature activation). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] --- a/include/linux/dccp.h +++ b/include/linux/dccp.h @@ -372,7 +372,6 @@ static inline unsigned int dccp_hdr_len( #define

Re: [PATCH 10/14]: Initialisation framework for feature negotiation

2007-10-03 Thread Ian McDonald
are not supported) are advertised for robustness. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 8/14]: Remove manual influence on NDP Count feature

2007-10-03 Thread Ian McDonald
of CCID or feature negotiation enables NDP count, this will then be updated via the NDP activation handler. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL

Re: [PATCH 14/14]: Debugging Feature Negotiation

2007-10-03 Thread Ian McDonald
, and options are provided. A new macro was defined to not always have the function name in the output line. I have refrained from naming it dccp_pr_debug_dog ... Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: [PATCH 11/14]: Auto-load (when supported) CCID plugins for negotiation

2007-10-03 Thread Ian McDonald
[EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/14]: Implement both feature-local and feature-remote Sequence Window feature

2007-10-03 Thread Ian McDonald
On 10/4/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Implement both feature-local and feature-remote Sequence Window feature This adds full support for both local/remote Sequence Window feature, from which the * sequence-number-validity (W) and * acknowledgment-number-validity

Re: [PATCH v2 3/3]: Convert Reset code into socket error number

2007-10-02 Thread Ian McDonald
Cookie, maps into Invalid request descriptor (EBADR); * Code 11, Aggression Penalty, maps into Quota exceeded (EDQUOT) which makes sense in terms of using more than the `fair share' of bandwidth. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1

Re: [PATCH 6/11]: Insert feature-negotiation options into skb

2007-10-02 Thread Ian McDonald
] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH v2 4/9]: Resolve dependencies of features on choice of CCID

2007-10-02 Thread Ian McDonald
-by: Ian McDonald [EMAIL PROTECTED] (I have seen Arnaldo's/your later correspondence and happy enough that you'll resolve that) -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body

Re: [PATCH 1/9]: Registration routines for changing feature values

2007-10-01 Thread Ian McDonald
PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/9]: Query supported CCIDs

2007-10-01 Thread Ian McDonald
of CCID2. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/9]: Resolve feature dependencies resulting from choice of CCID

2007-10-01 Thread Ian McDonald
#ccid_dependencies Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/9]: Resolve dependencies of features on choice of CCID

2007-10-01 Thread Ian McDonald
to explain the rationale behind this as I'm probably missing something. Acked-by: Ian McDonald [EMAIL PROTECTED] (Sending acked bys these days as much less time so giving quick reviews. I'm working through all the new group of patches from oldest first. I've lost track of any old ones I haven't

Re: [PATCH 5/9]: Glue function to support sockopt code

2007-10-01 Thread Ian McDonald
-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/9]: Provide feature negotiation for minimum-checksum-coverage

2007-10-01 Thread Ian McDonald
for this connection. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Nice to see reduction in data size of a structure and also simplifying logic because of it. Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL

Re: [PATCH 7/9]: Tidy up setsockopt calls

2007-10-01 Thread Ian McDonald
in some cases. Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 9/9]: API to query the current TX/RX CCID

2007-10-01 Thread Ian McDonald
-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 8/9]: Set per-connection CCIDs via socket options

2007-10-01 Thread Ian McDonald
of this facility, the remaining patches of this patch set are needed, which track dependencies and activate negotiated feature values. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] But see one comment below. + BUILD_BUG_ON(sizeof(u8) != 1); The whole point

Re: [PATCH 3/3]: Convert Reset code into socket error number

2007-10-01 Thread Ian McDonald
On 9/30/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Convert Reset code into socket error number This adds support for converting the 11 currently defined Reset codes into system error numbers, which are stored in sk_err for further interpretation. This makes the externally visible

Re: [PATCH 3/3]: Convert Reset code into socket error number

2007-10-01 Thread Ian McDonald
On 10/2/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: He used a designated initializer, i.e. he said at which index in the array it the value is to be set. So it really doesn't matter the order. And when checking if the code was within the valid range he tested against the last entry

Re: [PATCH 2/11]: Increase the scope of variable-length htonl/ntohl functions

2007-10-01 Thread Ian McDonald
to be used both by general option processing and feature negotiation code, hence declarations have been put into feat.h. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http

Re: [PATCH 5/11]: Update insertion routine for feature-negotiation options

2007-10-01 Thread Ian McDonald
-Value options whose length is determined by an u8 field provide Value space for at most 255 - 2 = 253 bytes due to the Type/Length fields. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] (once one change is put in) --- net/dccp/ackvec.c |8

Re: [PATCH 6/11]: Insert feature-negotiation options into skb

2007-10-01 Thread Ian McDonald
. This replaces the earlier insertion routine from options.c Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Once a couple of things commented on/fixed. Acked-by: Ian McDonald [EMAIL PROTECTED] --- net/dccp/dccp.h|2 + net/dccp/feat.c| 57

Re: [PATCH 7/11]: Integrate feature-negotiation insertion code

2007-10-01 Thread Ian McDonald
on DataAck packets (5.8). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/11]: Preference list reconciliation

2007-10-01 Thread Ian McDonald
also removes the old code for processing SP/NN Change options, since new code to process these is mostly there already; related references have been commented out. The code for processing Change options follows in the next patch. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian

Re: [PATCH 9/11]: Fill in the Data1..3 fields when option processing encounters option errors

2007-10-01 Thread Ian McDonald
, this patch extends the capabilities by adding Reset information when processing erroneous options. This support will be made use of by the next two patches which process Change/ Confirm feature-negotiation options. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL

Re: [PATCH 4/11]: Basic data structure for feature negotiation

2007-09-30 Thread Ian McDonald
Window feature has 48 bit). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body

Re: [PATCH 5/11]: Implement lookup table for feature-negotiation information

2007-09-30 Thread Ian McDonald
with their feature location, their default value, and type. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line

Re: [PATCH 6/11]: List management for new feature negotiation

2007-09-30 Thread Ian McDonald
set. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL

Re: [PATCH 9/11]: Provide documentation for undocumented sockopt struct

2007-09-30 Thread Ian McDonald
, but it would be better to phase it out and replace it by proper socket options (setsockopt code for the CCID follows in a later patch). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http

Re: [PATCH 7/11]: Socket support for feature negotiation and its initialisation

2007-09-30 Thread Ian McDonald
a FIXME regarding the congestion control initialisation. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line

Re: [PATCH 10/11]: Limit feature negotiation to connection setup phase

2007-09-30 Thread Ian McDonald
] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 11/11]: Disable setting timers for feature negotiation

2007-09-30 Thread Ian McDonald
Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 3/11]: Ignore feature negotiation on Data packets

2007-09-28 Thread Ian McDonald
) classifies empty Confirm options as invalid - this needs to be resolved in a separate patch. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz

Re: Towards the ccid-3 and ccid-4 integration

2007-09-27 Thread Ian McDonald
On 9/27/07, Gerrit Renker [EMAIL PROTECTED] wrote: * but there is already dccp_tfrc_lib which hosts a major number of functions used by CCID3/4 * hence I think that you could proceed by - add a CCID-3 specific object file to dccp_tfrc_lib-y in net/dccp/ccids/lib/Makefile

Re: Towards the ccid-3 and ccid-4 integration

2007-09-26 Thread Ian McDonald
On 9/27/07, Tommi Saviranta [EMAIL PROTECTED] wrote: On Mon, Sep 24, 2007 at 15:15:57 -0300, ツ Leandro Sales wrote: - Identify and provide common code between ccid-4 and ccid-3. I'm probably little too much of a need-get-my-hands-dirty kind of guy, but I think this part usually works out the

Re: [PATCH 1/5] CCID 4: Adds Kconfig, Makefile, and new CCID to include/linux/dccp.h

2007-09-25 Thread Ian McDonald
On 9/25/07, Gerrit Renker [EMAIL PROTECTED] wrote: Ian McDonald wrote: | + * 16-20ms to match the typical multimedia inter-frame interval | + * 100ms as a reasonable compromise [default] | + * 1000ms corresponds to the lower TCP RTO bound (RFC 2988, 2.4) | + | | But Linux actually

Re: [PATCH v2 1/1][UPDATE]: [CCID2]: Remove redundant BUG_ON

2007-09-25 Thread Ian McDonald
from cwnd and appears in assignments and comparisons, the type of ssthresh was changed to matched that of cwnd. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http

Re: [PATCH 1/8]: Add FIXME for send_delayed_ack

2007-09-25 Thread Ian McDonald
On 9/26/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Add FIXME for send_delayed_ack This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere used in the entire DCCP/CCID code. Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also rather

Re: [PATCH 2/8]: Add Support for Data 1 .. 3 fields of Reset packets

2007-09-25 Thread Ian McDonald
in these fields follows in subsequent patches, it is primarily used for reporting option-processing and feature-negotiation errors. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http

Re: [PATCH 3/8]: Remove duplicate code for Reset from connected socket

2007-09-25 Thread Ian McDonald
served, so I left it in. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Haven't studied in great depth but looks right. Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list

Re: [PATCH 4/8]: Factor out common code for generating Resets

2007-09-25 Thread Ian McDonald
codes would be used in dccp_send_reset() instead, since they all relate to an established DCCP connection: * Code 1, Closed; * Code 2, Aborted; * Code 11, Aggression Penalty (12.3). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http

Re: [PATCH 5/8]: Allow to parse options on Request Sockets

2007-09-25 Thread Ian McDonald
setup, make use of this facility. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp

Re: [PATCH 6/8]: Add (missing) option parsing to request_sock processing

2007-09-25 Thread Ian McDonald
. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL PROTECTED

Re: [PATCH 8/8]: Support inserting options during the 3-way handshake

2007-09-25 Thread Ian McDonald
. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Once the tse pointer issue is shifted - I noticed this in this patch, but not original. I must only be half as smart as Arnaldo ;-) -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog

Re: Ack Vectors, feature negotiation and preview of new patches

2007-09-23 Thread Ian McDonald
On 9/21/07, Gerrit Renker [EMAIL PROTECTED] wrote: I am happy to announce that feature negotiation now works, which resolves the above problem. Below is a log dump which shows the successful negotiation of CCID and dependent features during the handshake. Exchanging NN features during an

Re: [PATCH 1/5] CCID 4: Adds Kconfig, Makefile, and new CCID to include/linux/dccp.h

2007-09-22 Thread Ian McDonald
On 9/20/07, Tommi Saviranta [EMAIL PROTECTED] wrote: Adds Kconfig-entries, modified Makefile, and adds DCCP_CCID enum for for CCID 4. Kconfig-entries are derived from CCID 3, and are probably invalid. Signed-off-by: Tommi Saviranta [EMAIL PROTECTED] +config IP_DCCP_CCID4 + tristate

Re: [PATCH 1/4] CCID4: Provides improvements/organization to the initial entries for CCID 4 and net/dccp/ccids/Kconfig

2007-09-22 Thread Ian McDonald
On 9/21/07, ツ Leandro Sales [EMAIL PROTECTED] wrote: Signed-off-by: Leandro Sales [EMAIL PROTECTED] Organize the help for ccid-4 menu with a more apropriate description, the correct URL for CCID-4 draft and remove the code duplication for TFRC by using depends on CCID3 || CCID4 in the

Re: [PATCH 2/5] CCID 4: Clone existing implementation of CCID 3 into ccid4.[ch]

2007-09-22 Thread Ian McDonald
On 9/20/07, Tommi Saviranta [EMAIL PROTECTED] wrote: (Yup, it is less than 40 KiB.) As discussed previously the CCID4 should share CCID3 code rather than copy it. This is fine for experimental purposes though - it can't be merged into mainline kernel as is though. You will need to track

Re: [PATCH 4/4] CCID4: Replaces the hard-coded 1460 nominal packet size by a #define

2007-09-22 Thread Ian McDonald
[EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] (although I think there should be just one merged patch for this) -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp

Re: [PATCH 3/5] CCID 4: Enforce a minimum sending rate of 10 ms

2007-09-22 Thread Ian McDonald
On 9/20/07, Tommi Saviranta [EMAIL PROTECTED] wrote: + /* TFRC-SP enforces a minimum interval of 10 milliseconds */ + hctx-ccid4hctx_t_ipi = + max_t(u32, scaled_div32(((u64)hctx-ccid4hctx_s) 6, + hctx-ccid4hctx_x), +

Re: [PATCH 5/5] CCID 4: Use 1460 bytes as segment size in TCP throughput calculation

2007-09-22 Thread Ian McDonald
On 9/20/07, Tommi Saviranta [EMAIL PROTECTED] wrote: +/** ccid4_first_li - Implements [RFC 3448, 6.3.1], with s = 1460 [TFRC-SP] Put RFC4828 here instead of TFRC-SP. Otherwise looks fine. -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To

Re: [PATCH 5/5]: Fix Request/Response RTT sampling

2007-09-18 Thread Ian McDonald
On 9/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: Quoting Ian McDonald: | On 9/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: | [DCCP]: Fix Request/Response RTT sampling | Thanks for looking at this, but I won't/can't use the sign-off, since I merged this patch with the one which had

Re: [PATCH 1/5]: Sequence number wrap-around when sending reset

2007-09-12 Thread Ian McDonald
On 9/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Sequence number wrap-around when sending reset This replaces normal addition with mod-48 addition so that sequence number wraparound is respected. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL

Re: [PATCH 3/5]: Ignore Ack Vectors / Elapsed Time on DCCP-Request also

2007-09-12 Thread Ian McDonald
simplified. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line unsubscribe dccp in the body of a message to [EMAIL

Re: [PATCH 4/5]: DCCP's passive close needs to match TCP's half-close

2007-09-12 Thread Ian McDonald
On 9/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: DCCP's passive close needs to match TCP's half-close Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http

Re: [PATCH 5/5]: Fix Request/Response RTT sampling

2007-09-12 Thread Ian McDonald
On 9/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Fix Request/Response RTT sampling Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz

[RESEND] [PATCH 6/6] DCCP: Implement faster restart

2007-09-11 Thread Ian McDonald
.ietf.org/proceedings/07jul/slides/dccp-6.pdf Most notably we don't do pings. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index ea9e1f9..1abe365 100644 --- a/net/dccp/ccids/ccid3.c +++ b/net/dccp/ccids/ccid3.c @@ -121,8 +121,32

[PATCH 2/6] DCCP: Add setsocketopts for CCIDs

2007-09-05 Thread Ian McDonald
For faster restart and TFRCbis we need to pass socket options down to CCIDs. Add framework in for this. Shift check for LISTEN as part of this, as suggested by Gerrit Renker. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccid.h b/net/dccp/ccid.h index c65cb24..0067526

[PATCH 3/6] DCCP: Introduce CCID3 extensions

2007-09-05 Thread Ian McDonald
In this patch we introduce the extension TFRC faster restart. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.h b/net/dccp/ccids/ccid3.h index 5a23b62..6de73f7 100644 --- a/net/dccp/ccids/ccid3.h +++ b/net/dccp/ccids/ccid3.h @@ -116,6 +116,7 @@ struct

[PATCH 5/6] DCCP: Check if faster restart is on

2007-09-05 Thread Ian McDonald
This adds new helper functions to check if faster restart is turned on. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.h b/net/dccp/ccids/ccid3.h index c77c8fb..7edbf70 100644 --- a/net/dccp/ccids/ccid3.h +++ b/net/dccp/ccids/ccid3.h @@ -182,4 +182,11

[PATCH 4/6] DCCP: Add framework for faster restart

2007-09-05 Thread Ian McDonald
Set up options for enabling TFRC options. Also add variables for faster restart. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/include/linux/dccp.h b/include/linux/dccp.h index 1f696f9..17a8016 100644 --- a/include/linux/dccp.h +++ b/include/linux/dccp.h @@ -209,7 +209,9

  1   2   3   4   5   >