Bug#720456: [vim-scripts] Please include the solarized colorscheme
Nicholas, Thanks for the feedback, please see my replies below. BTW, James, copying you here to notify there is a new version of the package at the git repository, and that I am converting this bug into an ITP. On Sun, 20 Dec 2020 11:11:43 +0300 Nicholas wrote: > Hello! > > On Fri, 2020-12-11 at 16:09 -0500, Marco Villegas wrote: > > I have just added a new repository at > > https://salsa.debian.org/vim-team/vim-solarized which contains some > > extra changes to reflect the owner change. I also added a new signed > > tag with the first version. > > Thank you, Marco Villegas, for packaging original Solarized > color-scheme for Vim, my favorite color-scheme. > > Once you prepared a new package, I think it makes sense to convert > this bug to an ITP report[1] against the wnpp pseudo-package. Right, I will do that now. > And I noticed also your current variant of the package activates the > color-scheme instead of default one and so a description of the > package contradicts a little bit. A colorscheme in vim is used only when vimrc is configured to get it used. In dh-vim-addon, there is an way to define if an vim addon will be available by default or not, which is independent of the usage of it for the case of a colorscheme. I understand the confusion here, mainly on the description, which I have just changed. BTW I originally started it as an options addon, and changed it later, see description at the commit[1] for details > > > Description: Solarized Colorscheme for Vim > > Solarized is a sixteen color palette with eight monotones, and > > eight accent colors; designed for use with terminal and gui > > applications. . > > This plugin contains a vim colorscheme plugin using the Solarized > > palette. . > > It is installed as "optional" Vim package, which can be enabled by > > adding "packadd! solarized" to vimrc. > > You use the debian/*.vim-addon file, not debian/*.vim-opt-addon, and > so packadd! command is not needed. Is it intentional? > > [1]: https://wiki.debian.org/ITP Hence yes, it is intentional, and thanks for pointing it out. 1: https://salsa.debian.org/vim-team/vim-solarized/-/commit/36f394c7029ad3a1835aac27ffbf66e9226822e7 Best, -Marco pgpQEzd8GoTkJ.pgp Description: Firma digital OpenPGP
Bug#720456: [vim-scripts] Please include the solarized colorscheme
Hello! On Fri, 2020-12-11 at 16:09 -0500, Marco Villegas wrote: > I have just added a new repository at > https://salsa.debian.org/vim-team/vim-solarized which contains some > extra changes to reflect the owner change. I also added a new signed > tag with the first version. Thank you, Marco Villegas, for packaging original Solarized color-scheme for Vim, my favorite color-scheme. Once you prepared a new package, I think it makes sense to convert this bug to an ITP report[1] against the wnpp pseudo-package. And I noticed also your current variant of the package activates the color-scheme instead of default one and so a description of the package contradicts a little bit. > Description: Solarized Colorscheme for Vim > Solarized is a sixteen color palette with eight monotones, and eight accent > colors; designed for use with terminal and gui applications. > . > This plugin contains a vim colorscheme plugin using the Solarized palette. > . > It is installed as "optional" Vim package, which can be enabled by adding > "packadd! solarized" to vimrc. You use the debian/*.vim-addon file, not debian/*.vim-opt-addon, and so packadd! command is not needed. Is it intentional? [1]: https://wiki.debian.org/ITP signature.asc Description: This is a digitally signed message part
Bug#720456: [vim-scripts] Please include the solarized colorscheme
Thanks for granting me access to the vim team James! I have just added a new repository at https://salsa.debian.org/vim-team/vim-solarized which contains some extra changes to reflect the owner change. I also added a new signed tag with the first version. Let me know if the package looks good, and next steps. Best, -Marco
Bug#720456: [vim-scripts] Please include the solarized colorscheme
Hi James, As discussed on IRC, I have created a separate package for the solarized colorscheme, using dh-vim-addon as the base. The code can be found at https://salsa.debian.org/marvil07/vim-solarized BTW you probably have already received an invitation to the git repository. It would be great if it could be added under the salsa vim-team. I requested access there using gitlab UI, just in case. Do you think that would be a good idea? Let me know if the package looks good to you. Best, -Marco
Bug#720456: [vim-scripts] Please include the solarized colorscheme
James, thanks for making the changes for the conversion to dh-vim-addon on the package git repository! I see them in place now and even released as 20201113, which means I could re-try this with the new approach. While looking at the code changes, I noticed that color_sampler_pack was updated less than two weeks ago on the debian repository[1] to the version from 2012.10.28. It now includes a solarized color scheme, but sadly, it is including a old version; which based on the upstream repository, corresponds to upstream commit 646c69542e4759a7dd7e2b22b86287027614[2] from March 2011. It is also important to mention that color_sampler_pack is only adding the color scheme, without any documentation. Based on that, I think it is a good idea to add it independently. As stated at debian/vim-scripts.status, I am adding version from latest available commit on upstream, 528a59f26d12278698bb946f8fb82a63711eec21[3]. I have also updated html documentation on a separate commits, for easier review. The new code is now available at https://salsa.debian.org/vim-team/vim-scripts/-/merge_requests/2 1: https://salsa.debian.org/vim-team/vim-scripts/-/commit/2919ffd8093b8d30ba10629c9b63ea188cc2841a 2: https://github.com/altercation/vim-colors-solarized/blob/646c69542e4759a7dd7e2b22b86287027614/colors/solarized.vim 3: https://github.com/altercation/vim-colors-solarized/blob/528a59f26d12278698bb946f8fb82a63711eec21/colors/solarized.vim Best, -Marco
Bug#720456: [vim-scripts] Please include the solarized colorscheme
Thanks for the feedback! I will be happy to re-attempt this after the restructuring. I will try to git fetch periodically, but an announce here would be great too. Best, -Marco On Sun, 3 Mar 2019 14:20:06 -0500 James wrote: > On Fri, Mar 01, 2019 at 10:26:45PM -0500, Marco Villegas wrote: > > I have used https://github.com/altercation/solarized repository as > > the base to add the solarized color scheme to the package. > > Thanks for working on this. > > > I am not entirely sure of the urls on metadata at > > debian/vim-scripts.status, but I guess that they are OK. It is > > important to notice that there is a vim.org page, i.e. > > https://www.vim.org/scripts/script.php?script_id=3520, for the color > > scheme, but sadly the code there contains an older version of what I > > find at the repository, and that is why I decided to use the version > > from the repository. > > > > I was a bit worried on how debian/vim-scripts.pl will handle the > > github url, but both doc and update actions seems to finish OK, > > naturally suggesting a false positive on the case of the new > > solarized addon. > > All of this is going to be reworked as I'm in the process of changing > this package from using vim-addon-manager to dh-vim-addon. > vim-addon-manager had various problems that were holding me back from > updating vim-scripts. I haven't been actively working on this since > it will have to wait until after Buster is released anyway. > > > Another detail I am not sure about is the value of disabledby at > > debian/vim-scripts.status for this new addon, so I have just > > skipped it. > > For a colorscheme, it's not needed. The user has to explicitly use > the colorscheme anyway. > > > Also, I have started by updating the html documentation for all > > addons, since I could not figure out a way to only do it for the > > new addon. It is in a separate commit, just in case that change is > > not a good idea. > > Agreed, that's not necessary right now. > > I would suggest holding off until the package gets restructured. I'll > try to make some time for that again so at the very least there's an > experimental branch this could be merged into. > > Cheers,
Bug#720456: [vim-scripts] Please include the solarized colorscheme
On Fri, Mar 01, 2019 at 10:26:45PM -0500, Marco Villegas wrote: > I have used https://github.com/altercation/solarized repository as the > base to add the solarized color scheme to the package. Thanks for working on this. > I am not entirely sure of the urls on metadata at > debian/vim-scripts.status, but I guess that they are OK. It is > important to notice that there is a vim.org page, i.e. > https://www.vim.org/scripts/script.php?script_id=3520, for the color > scheme, but sadly the code there contains an older version of what I > find at the repository, and that is why I decided to use the version > from the repository. > > I was a bit worried on how debian/vim-scripts.pl will handle the github > url, but both doc and update actions seems to finish OK, naturally > suggesting a false positive on the case of the new solarized addon. All of this is going to be reworked as I'm in the process of changing this package from using vim-addon-manager to dh-vim-addon. vim-addon-manager had various problems that were holding me back from updating vim-scripts. I haven't been actively working on this since it will have to wait until after Buster is released anyway. > Another detail I am not sure about is the value of disabledby at > debian/vim-scripts.status for this new addon, so I have just skipped it. For a colorscheme, it's not needed. The user has to explicitly use the colorscheme anyway. > Also, I have started by updating the html documentation for all addons, > since I could not figure out a way to only do it for the new addon. It > is in a separate commit, just in case that change is not a good idea. Agreed, that's not necessary right now. I would suggest holding off until the package gets restructured. I'll try to make some time for that again so at the very least there's an experimental branch this could be merged into. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
Bug#720456: [vim-scripts] Please include the solarized colorscheme
Dear maintainer, Thanks for providing the package, I find it really useful. I have used https://github.com/altercation/solarized repository as the base to add the solarized color scheme to the package. Based on the note at the README file, I concluded the license of the provided code is https://opensource.org/licenses/MIT. I am not entirely sure of the urls on metadata at debian/vim-scripts.status, but I guess that they are OK. It is important to notice that there is a vim.org page, i.e. https://www.vim.org/scripts/script.php?script_id=3520, for the color scheme, but sadly the code there contains an older version of what I find at the repository, and that is why I decided to use the version from the repository. I was a bit worried on how debian/vim-scripts.pl will handle the github url, but both doc and update actions seems to finish OK, naturally suggesting a false positive on the case of the new solarized addon. Another detail I am not sure about is the value of disabledby at debian/vim-scripts.status for this new addon, so I have just skipped it. Also, I have started by updating the html documentation for all addons, since I could not figure out a way to only do it for the new addon. It is in a separate commit, just in case that change is not a good idea. The code can be found at https://salsa.debian.org/vim-team/vim-scripts/merge_requests/1 Let me know if I can do something else to help this change get into the package. Best, -Marco
Bug#720456: [vim-scripts] Please include the solarized colorscheme
Package: vim-scripts Version: 20130814 Severity: wishlist Dear vim-scripts maintainer, Please include the solarized colorscheme in vim-scripts. http://ethanschoonover.com/solarized Solarized is a *very* popular colorscheme. And it is available for many editors, including vim: https://github.com/altercation/vim-colors-solarized It would be nice to have it packaged. Thanks and cheers, Bastian --- System information. --- Architecture: amd64 Kernel: Linux 3.10-2-amd64 Debian Release: jessie/sid 500 unstableftp.de.debian.org 500 stable repository.spotify.com 500 stable dl.google.com 1 experimentalftp.de.debian.org --- Package information. --- Package's Depends field is empty. Recommends (Version) | Installed -+-=== vim | vim-addon-manager| 0.5.2 Suggests (Version) | Installed ===-+-=== perlsgml| libtemplate-perl| -- Bastian Venthur http://venthur.de Debian Developer venthur at debian org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
