Bug#921128: [Pkg-mailman-hackers] Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Pierre-Elliott Bécue: > Le lundi 11 février 2019 à 23:40:51+0100, Jonas Meurer a écrit : >> Hi PEB, hi anarcat, >> >> Pierre-Elliott Bécue: >>> Le lundi 11 février 2019 à 16:27:21-0500, Antoine Beaupré a écrit : On 2019-02-11 21:52:32, Pierre-Elliott Bécue wrote: > Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : >> Right, the only way this could be properly implemented would be if >> debconf would attempt to connect with the configured DB credentials to >> check the remote server version (or, better, to test the actuall code >> bugginess). >> >> That's probably overkill though. > > ISTM that it is. > > But if you wish to go to such extents I'd be glad to include a patch! > (no time to dev it though) Alright, let good win in the face of non-existing perfect threats. ;) >>> >>> I'll leave ourselves 24h of thinking and then I'll upload. >>> >>> If you get attacked by insomnia, you know what to do. :P >> >> Sorry for not responding earlier, I was to busy with other things. >> Still, I should have reacted earlier ... >> >> As you might have seen, mariadb-10.1 10.1.37-0+deb9u1 is in stable-new >> queue[1]. I don't know the details why it didn't proceed to stable yet, >> but there's hope that this issue will be sorted out in Stretch soon. The >> 10.1.37 contains both the upstream backport of >> `innodb_default_row_format`[2] and the patch to the config[3] that sets >> the default row format to `dynamic`, so the `max key length is 767 >> bytes` error is definitely fixed in this release. >> >> Therefore I don't think it's still *needed* to upload the patch that PEB >> poposed in this bugreport. I don't *object* to uploading it either. So >> if you want to, go ahead, PEB. But we should track the mariadb 10.1 >> version in Stretch and remove the Debconf question again once mariadb >> 10.1.37 got accepted into Stretch. >> >> Cheers > > This mariadb release seems to be already in security for stretch. > > I changed a little the warning but I think we should keep it (at least > until the point release of stretch is really done): > https://salsa.debian.org/mailman-team/mailman-suite/commits/stretch-backports > > Tell me what you think about it. Thanks for taking care, PEB! As written, I don't have strong feelings on that, given that a compatible MariaDB should propagate to Stretch soon (hopefully). Feel free to upload as is, I reviewed the commits and think they're fine. I agree with you though that we should remove the debconf notification again once the compatible MariaDB packages went into Stretch. Cheers jonas > signature.asc Description: OpenPGP digital signature
Bug#921128: [Pkg-mailman-hackers] Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Le lundi 11 février 2019 à 23:40:51+0100, Jonas Meurer a écrit : > Hi PEB, hi anarcat, > > Pierre-Elliott Bécue: > > Le lundi 11 février 2019 à 16:27:21-0500, Antoine Beaupré a écrit : > >> On 2019-02-11 21:52:32, Pierre-Elliott Bécue wrote: > >>> Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : > Right, the only way this could be properly implemented would be if > debconf would attempt to connect with the configured DB credentials to > check the remote server version (or, better, to test the actuall code > bugginess). > > That's probably overkill though. > >>> > >>> ISTM that it is. > >>> > >>> But if you wish to go to such extents I'd be glad to include a patch! > >>> (no time to dev it though) > >> > >> Alright, let good win in the face of non-existing perfect threats. ;) > > > > I'll leave ourselves 24h of thinking and then I'll upload. > > > > If you get attacked by insomnia, you know what to do. :P > > Sorry for not responding earlier, I was to busy with other things. > Still, I should have reacted earlier ... > > As you might have seen, mariadb-10.1 10.1.37-0+deb9u1 is in stable-new > queue[1]. I don't know the details why it didn't proceed to stable yet, > but there's hope that this issue will be sorted out in Stretch soon. The > 10.1.37 contains both the upstream backport of > `innodb_default_row_format`[2] and the patch to the config[3] that sets > the default row format to `dynamic`, so the `max key length is 767 > bytes` error is definitely fixed in this release. > > Therefore I don't think it's still *needed* to upload the patch that PEB > poposed in this bugreport. I don't *object* to uploading it either. So > if you want to, go ahead, PEB. But we should track the mariadb 10.1 > version in Stretch and remove the Debconf question again once mariadb > 10.1.37 got accepted into Stretch. > > Cheers This mariadb release seems to be already in security for stretch. I changed a little the warning but I think we should keep it (at least until the point release of stretch is really done): https://salsa.debian.org/mailman-team/mailman-suite/commits/stretch-backports Tell me what you think about it. -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#921128: [Pkg-mailman-hackers] Bug#921128: Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Le lundi 11 février 2019 à 23:40:51+0100, Jonas Meurer a écrit : > Hi PEB, hi anarcat, > > Pierre-Elliott Bécue: > > Le lundi 11 février 2019 à 16:27:21-0500, Antoine Beaupré a écrit : > >> On 2019-02-11 21:52:32, Pierre-Elliott Bécue wrote: > >>> Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : > Right, the only way this could be properly implemented would be if > debconf would attempt to connect with the configured DB credentials to > check the remote server version (or, better, to test the actuall code > bugginess). > > That's probably overkill though. > >>> > >>> ISTM that it is. > >>> > >>> But if you wish to go to such extents I'd be glad to include a patch! > >>> (no time to dev it though) > >> > >> Alright, let good win in the face of non-existing perfect threats. ;) > > > > I'll leave ourselves 24h of thinking and then I'll upload. > > > > If you get attacked by insomnia, you know what to do. :P > > Sorry for not responding earlier, I was to busy with other things. > Still, I should have reacted earlier ... > > As you might have seen, mariadb-10.1 10.1.37-0+deb9u1 is in stable-new > queue[1]. I don't know the details why it didn't proceed to stable yet, Because any release in stable is done manually by the stable managers. I think it won't get included before a minor release at least, and we can't be sure as they're free to pick (or not) packages from the stable proposed updates. > but there's hope that this issue will be sorted out in Stretch soon. The > 10.1.37 contains both the upstream backport of > `innodb_default_row_format`[2] and the patch to the config[3] that sets > the default row format to `dynamic`, so the `max key length is 767 > bytes` error is definitely fixed in this release. > > Therefore I don't think it's still *needed* to upload the patch that PEB > poposed in this bugreport. I don't *object* to uploading it either. So > if you want to, go ahead, PEB. But we should track the mariadb 10.1 > version in Stretch and remove the Debconf question again once mariadb > 10.1.37 got accepted into Stretch. I'll let the warning for now and remove it as soon as we know the package is included. -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them.
Bug#921128: [Pkg-mailman-hackers] Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Hi PEB, hi anarcat, Pierre-Elliott Bécue: > Le lundi 11 février 2019 à 16:27:21-0500, Antoine Beaupré a écrit : >> On 2019-02-11 21:52:32, Pierre-Elliott Bécue wrote: >>> Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : Right, the only way this could be properly implemented would be if debconf would attempt to connect with the configured DB credentials to check the remote server version (or, better, to test the actuall code bugginess). That's probably overkill though. >>> >>> ISTM that it is. >>> >>> But if you wish to go to such extents I'd be glad to include a patch! >>> (no time to dev it though) >> >> Alright, let good win in the face of non-existing perfect threats. ;) > > I'll leave ourselves 24h of thinking and then I'll upload. > > If you get attacked by insomnia, you know what to do. :P Sorry for not responding earlier, I was to busy with other things. Still, I should have reacted earlier ... As you might have seen, mariadb-10.1 10.1.37-0+deb9u1 is in stable-new queue[1]. I don't know the details why it didn't proceed to stable yet, but there's hope that this issue will be sorted out in Stretch soon. The 10.1.37 contains both the upstream backport of `innodb_default_row_format`[2] and the patch to the config[3] that sets the default row format to `dynamic`, so the `max key length is 767 bytes` error is definitely fixed in this release. Therefore I don't think it's still *needed* to upload the patch that PEB poposed in this bugreport. I don't *object* to uploading it either. So if you want to, go ahead, PEB. But we should track the mariadb 10.1 version in Stretch and remove the Debconf question again once mariadb 10.1.37 got accepted into Stretch. Cheers jonas [1] https://tracker.debian.org/news/1004285/accepted-mariadb-101-10137-0deb9u1-source-into-stable-embargoed-stable/ [2] https://jira.mariadb.org/browse/MDEV-14904 [3] https://salsa.debian.org/mariadb-team/mariadb-10.1/commit/89ae638d1d3b5a7157d086a9be2468cae764aae7 signature.asc Description: OpenPGP digital signature
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Le lundi 11 février 2019 à 16:27:21-0500, Antoine Beaupré a écrit : > On 2019-02-11 21:52:32, Pierre-Elliott Bécue wrote: > > Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : > >> Right, the only way this could be properly implemented would be if > >> debconf would attempt to connect with the configured DB credentials to > >> check the remote server version (or, better, to test the actuall code > >> bugginess). > >> > >> That's probably overkill though. > > > > ISTM that it is. > > > > But if you wish to go to such extents I'd be glad to include a patch! > > (no time to dev it though) > > Alright, let good win in the face of non-existing perfect threats. ;) I'll leave ourselves 24h of thinking and then I'll upload. If you get attacked by insomnia, you know what to do. :P -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
On 2019-02-11 21:52:32, Pierre-Elliott Bécue wrote: > Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : >> On 2019-02-11 09:01:22, Pierre-Elliott Bécue wrote: >> > Le 11 février 2019 00:10:55 GMT+01:00, "Antoine Beaupré" >> > a écrit : >> >>On 2019-02-10 01:11:35, Pierre-Elliott Bécue wrote: >> >>> Le vendredi 01 février 2019 à 21:05:38-0500, Antoine Beaupré a >> >>écrit : >> I just read the README.Debian file and it says the mariadb version >> >>in >> stretch might conflict with the mailman3-web version. >> >> If that's really the case, might I suggest the backport be fixed to >> >>warn >> explicitely about this somehow? maybe conflict with that mariadb >> version? >> >>> >> >>> Please review and comment >> >>> >> >>https://salsa.debian.org/mailman-team/mailman-suite/commit/1dc0dcf43e763b4b78e808877d65a8dbb6119170 >> >>> >> >>> I'll upload in a couple of days. :) >> >> >> >>That's a great start! >> >> >> >>Couldn't we check if mariadb is actually installed or configured >> >>somehow >> >>instead of just always prompting? >> >> >> >>But if that's too much work, it's better than nothing for sure. >> >> >> >>THanks! :) >> >> >> >>A. >> > >> > The risk is that if the user plans to use an external DB you won't warn >> > him. >> >> Right, the only way this could be properly implemented would be if >> debconf would attempt to connect with the configured DB credentials to >> check the remote server version (or, better, to test the actuall code >> bugginess). >> >> That's probably overkill though. > > ISTM that it is. > > But if you wish to go to such extents I'd be glad to include a patch! > (no time to dev it though) Alright, let good win in the face of non-existing perfect threats. ;) A. -- During the initial stage of the struggle, the oppressed, instead of striving for liberation, tend themselves to become oppressors The very structure of their thought has been conditioned by the contradictions of the concrete, existential situation by which they were shaped. Their ideal is to be men; but for them, to be men is to be oppressors. This is their model of humanity. - Paulo Freire, Pedagogy of the Oppressed
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Le lundi 11 février 2019 à 09:14:55-0500, Antoine Beaupré a écrit : > On 2019-02-11 09:01:22, Pierre-Elliott Bécue wrote: > > Le 11 février 2019 00:10:55 GMT+01:00, "Antoine Beaupré" > > a écrit : > >>On 2019-02-10 01:11:35, Pierre-Elliott Bécue wrote: > >>> Le vendredi 01 février 2019 à 21:05:38-0500, Antoine Beaupré a > >>écrit : > I just read the README.Debian file and it says the mariadb version > >>in > stretch might conflict with the mailman3-web version. > > If that's really the case, might I suggest the backport be fixed to > >>warn > explicitely about this somehow? maybe conflict with that mariadb > version? > >>> > >>> Please review and comment > >>> > >>https://salsa.debian.org/mailman-team/mailman-suite/commit/1dc0dcf43e763b4b78e808877d65a8dbb6119170 > >>> > >>> I'll upload in a couple of days. :) > >> > >>That's a great start! > >> > >>Couldn't we check if mariadb is actually installed or configured > >>somehow > >>instead of just always prompting? > >> > >>But if that's too much work, it's better than nothing for sure. > >> > >>THanks! :) > >> > >>A. > > > > The risk is that if the user plans to use an external DB you won't warn him. > > Right, the only way this could be properly implemented would be if > debconf would attempt to connect with the configured DB credentials to > check the remote server version (or, better, to test the actuall code > bugginess). > > That's probably overkill though. ISTM that it is. But if you wish to go to such extents I'd be glad to include a patch! (no time to dev it though) Chaars, -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
On 2019-02-11 09:01:22, Pierre-Elliott Bécue wrote: > Le 11 février 2019 00:10:55 GMT+01:00, "Antoine Beaupré" > a écrit : >>On 2019-02-10 01:11:35, Pierre-Elliott Bécue wrote: >>> Le vendredi 01 février 2019 à 21:05:38-0500, Antoine Beaupré a >>écrit : I just read the README.Debian file and it says the mariadb version >>in stretch might conflict with the mailman3-web version. If that's really the case, might I suggest the backport be fixed to >>warn explicitely about this somehow? maybe conflict with that mariadb version? >>> >>> Please review and comment >>> >>https://salsa.debian.org/mailman-team/mailman-suite/commit/1dc0dcf43e763b4b78e808877d65a8dbb6119170 >>> >>> I'll upload in a couple of days. :) >> >>That's a great start! >> >>Couldn't we check if mariadb is actually installed or configured >>somehow >>instead of just always prompting? >> >>But if that's too much work, it's better than nothing for sure. >> >>THanks! :) >> >>A. > > The risk is that if the user plans to use an external DB you won't warn him. Right, the only way this could be properly implemented would be if debconf would attempt to connect with the configured DB credentials to check the remote server version (or, better, to test the actuall code bugginess). That's probably overkill though. A. -- The future is already here – it's just not very evenly distributed. - William Gibson
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Le 11 février 2019 00:10:55 GMT+01:00, "Antoine Beaupré" a écrit : >On 2019-02-10 01:11:35, Pierre-Elliott Bécue wrote: >> Le vendredi 01 février 2019 à 21:05:38-0500, Antoine Beaupré a >écrit : >>> I just read the README.Debian file and it says the mariadb version >in >>> stretch might conflict with the mailman3-web version. >>> >>> If that's really the case, might I suggest the backport be fixed to >warn >>> explicitely about this somehow? maybe conflict with that mariadb >>> version? >> >> Please review and comment >> >https://salsa.debian.org/mailman-team/mailman-suite/commit/1dc0dcf43e763b4b78e808877d65a8dbb6119170 >> >> I'll upload in a couple of days. :) > >That's a great start! > >Couldn't we check if mariadb is actually installed or configured >somehow >instead of just always prompting? > >But if that's too much work, it's better than nothing for sure. > >THanks! :) > >A. The risk is that if the user plans to use an external DB you won't warn him. Cheers ! -- PEB from my phone.
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
On 2019-02-10 01:11:35, Pierre-Elliott Bécue wrote: > Le vendredi 01 février 2019 à 21:05:38-0500, Antoine Beaupré a écrit : >> I just read the README.Debian file and it says the mariadb version in >> stretch might conflict with the mailman3-web version. >> >> If that's really the case, might I suggest the backport be fixed to warn >> explicitely about this somehow? maybe conflict with that mariadb >> version? > > Please review and comment > https://salsa.debian.org/mailman-team/mailman-suite/commit/1dc0dcf43e763b4b78e808877d65a8dbb6119170 > > I'll upload in a couple of days. :) That's a great start! Couldn't we check if mariadb is actually installed or configured somehow instead of just always prompting? But if that's too much work, it's better than nothing for sure. THanks! :) A. -- On ne résout pas un problème avec les modes de pensée qui l'ont engendré. - Albert Einstein
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
Le vendredi 01 février 2019 à 21:05:38-0500, Antoine Beaupré a écrit : > I just read the README.Debian file and it says the mariadb version in > stretch might conflict with the mailman3-web version. > > If that's really the case, might I suggest the backport be fixed to warn > explicitely about this somehow? maybe conflict with that mariadb > version? Please review and comment https://salsa.debian.org/mailman-team/mailman-suite/commit/1dc0dcf43e763b4b78e808877d65a8dbb6119170 I'll upload in a couple of days. :) -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#921128: Info received (mailman3-web fails to initialize mysql: Specified key was too long)
I just read the README.Debian file and it says the mariadb version in stretch might conflict with the mailman3-web version. If that's really the case, might I suggest the backport be fixed to warn explicitely about this somehow? maybe conflict with that mariadb version? A. -- Software gets slower faster than hardware gets faster. - Wirth's law
