Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Pirate Praveen
On Tuesday 18 October 2016 10:03 PM, Christian Seiler wrote: > If the package so clearly fails to achieve its _only_ goal as in > this case, I think it's a good idea to delay accepting it into the > archive until it's fixed. > > That said, I don't want to discourage you, and to provide something >

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Philipp Kern
On 10/18/2016 06:28 PM, Jakub Wilk wrote: > * Lars Wirzenius , 2016-10-18, 19:14: >>> The WTFness of this code is certainly way above what we're normally >>> used to, but (AIUI) it's only used as a fallback for nodejs < 4. >>> Debian currently has 4.6.0. >> In that case, perhaps this package isn't

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Christian Seiler
On 10/18/2016 05:29 PM, Pirate Praveen wrote: > On Tuesday 18 October 2016 08:27 PM, Lars Wirzenius wrote: >> This is so wrong, I would like to ask that this package not be allowed >> into Debian until it's fixed. > > I agree this could be marked RC and stopped from going to a stable > release. Bu

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread W. Martin Borgert
Quoting Lars Wirzenius : Even though I object to this one package (until it's fixed upstream), I don't want to discourage you from working on this. It's important work (because diaspora and gitlab are important pieces of free software). It's unfortunate you get to be the focal point of a lot of n

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Jakub Wilk
* Lars Wirzenius , 2016-10-18, 19:14: The WTFness of this code is certainly way above what we're normally used to, but (AIUI) it's only used as a fallback for nodejs < 4. Debian currently has 4.6.0. In that case, perhaps this package isn't needed in Debian at all? You would have to patch the

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Jonas Smedegaard
Quoting Lars Wirzenius (2016-10-18 17:44:50) > On Tue, Oct 18, 2016 at 08:59:20PM +0530, Pirate Praveen wrote: > > On Tuesday 18 October 2016 08:27 PM, Lars Wirzenius wrote: > > > This is so wrong, I would like to ask that this package not be allowed > > > into Debian until it's fixed. > > > > I a

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Lars Wirzenius
On Tue, Oct 18, 2016 at 06:03:28PM +0200, Jakub Wilk wrote: > The WTFness of this code is certainly way above what we're normally used to, > but (AIUI) it's only used as a fallback for nodejs < 4. Debian currently has > 4.6.0. In that case, perhaps this package isn't needed in Debian at all? > >

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Paul Wise
On Wed, Oct 19, 2016 at 12:03 AM, Jakub Wilk wrote: > it's only used as a fallback for nodejs < 4. Debian currently has 4.6.0. Does this mean the ITP can be closed? -- bye, pabs https://wiki.debian.org/PaulWise

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Steve McIntyre
Pirate Praveen wrote: >-=-=-=-=-=- > >On Tuesday 18 October 2016 08:45 PM, Steve McIntyre wrote: >> That doesn't fix (or excuse) poor packaging, though. > >Are you saying this is RC? We have different level for bugs, this would >be wishlist. I don't mind someone writing a better description. I'd b

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Jakub Wilk
* Lars Wirzenius , 2016-10-18, 17:57: if (process.platform === 'linux') { return home || (process.getuid() === 0 ? '/root' : (user ? '/home/' + user : null)); } Things are more complicated than that. What exactly is this code meant to be used for? This is so w

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Adrian Bunk
On Tue, Oct 18, 2016 at 04:15:50PM +0100, Steve McIntyre wrote: >... > Life's too short to go and fix all the crap in the world personally, > but we can keep certain minimum standards for what we as a group allow > into Debian. :-( What policies and processes should ensure these minimum standards?

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Lars Wirzenius
On Tue, Oct 18, 2016 at 08:40:49PM +0530, Pirate Praveen wrote: > I don't particularly enjoy doing this either. Please direct your anger > at the nodejs developers. I'm doing this only because the packages I > care (diaspora and gitlab won't be accepted in main, unless I build > libjs-handlebars an

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Lars Wirzenius
On Tue, Oct 18, 2016 at 08:59:20PM +0530, Pirate Praveen wrote: > On Tuesday 18 October 2016 08:27 PM, Lars Wirzenius wrote: > > This is so wrong, I would like to ask that this package not be allowed > > into Debian until it's fixed. > > I agree this could be marked RC and stopped from going to a

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Vincent Bernat
❦ 18 octobre 2016 17:57 +0300, Lars Wirzenius  : >> The code, well... >> >> if (process.platform === 'linux') { >> return home || (process.getuid() === 0 ? '/root' : (user ? >> '/home/' + user : null)); >> } >> >> Things are more complicated than that. What exactly is th

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Lars Wirzenius
On Tue, Oct 18, 2016 at 08:49:27PM +0530, Pirate Praveen wrote: > On Tuesday 18 October 2016 08:27 PM, Lars Wirzenius wrote: > > This is so wrong, I would like to ask that this package not be allowed > > into Debian until it's fixed. > > This is already reported upstream > https://github.com/sindr

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Pirate Praveen
On Tuesday 18 October 2016 08:27 PM, Lars Wirzenius wrote: > This is so wrong, I would like to ask that this package not be allowed > into Debian until it's fixed. I agree this could be marked RC and stopped from going to a stable release. But do we stop accepting new packages in unstable because

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Pirate Praveen
On Tuesday 18 October 2016 08:45 PM, Steve McIntyre wrote: > That doesn't fix (or excuse) poor packaging, though. Are you saying this is RC? We have different level for bugs, this would be wishlist. I don't mind someone writing a better description. > Life's too short to go and fix all the crap i

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Pirate Praveen
On Tuesday 18 October 2016 08:27 PM, Lars Wirzenius wrote: > On Tue, Oct 18, 2016 at 03:27:46PM +0100, Steve McIntyre wrote: >> The code, well... >> >> if (process.platform === 'linux') { >> return home || (process.getuid() === 0 ? '/root' : (user ? >> '/home/' + user : null)); >

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Steve McIntyre
On Tue, Oct 18, 2016 at 08:40:49PM +0530, Pirate Praveen wrote: >On Tuesday 18 October 2016 07:57 PM, Steve McIntyre wrote: >> /me args at YA tiny JS lump. It's tiny, and wrong. Probably. But it's >> difficult to tell with such a small "Description". Please add some >> useful text. > >This is packa

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Pirate Praveen
On Tuesday 18 October 2016 07:57 PM, Steve McIntyre wrote: > /me args at YA tiny JS lump. It's tiny, and wrong. Probably. But it's > difficult to tell with such a small "Description". Please add some > useful text. This is packaged because its a dependency for grunt. > The code, well... > >

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Lars Wirzenius
On Tue, Oct 18, 2016 at 03:27:46PM +0100, Steve McIntyre wrote: > The code, well... > > if (process.platform === 'linux') { > return home || (process.getuid() === 0 ? '/root' : (user ? > '/home/' + user : null)); > } > > Things are more complicated than that. What exact

Re: Bug#841196: ITP: node-os-homedir -- Node.js 4 `os.homedir()` ponyfill

2016-10-18 Thread Steve McIntyre
Pirate Praveen wrote: >-=-=-=-=-=- > >Package: wnpp >Severity: wishlist >Owner: Pirate Praveen >X-Debbugs-CC: debian-devel@lists.debian.org > >* Package name: node-os-homedir > Version : 1.0.2 > Upstream Author : Sindre Sorhus >(sindresorhus.com) >* URL : https://github.