Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-11-08 Thread Chris Lamb
Hi Andreas, > Simply *why* is this error added? I added this Lintian check after #838966 was filed against one of my packages. I did not add it as part of a plan to remove lsb-base, so alas I cannot comment on the rest of your email. Apologies if you spent some time crafting those portions. >

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-11-08 Thread Andreas Henriksson
Hello all! I've today looked at the newly appeared lintian error "init.d-script-needs-depends-on-lsb-base" which seems odd to me. First and foremost I've not found a rationale for what the overall plan is to accomplish here. Simply *why* is this error added? Secondly I think it seems like the

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-15 Thread Didier 'OdyX' Raboud
Le vendredi, 14 octobre 2016, 22.57:13 h CEST Jakub Wilk a écrit : > * Vincent Bernat , 2016-10-11, 08:44: > >We put 3.0-6, then we have to update to 3.2-14 for status_proc. Then we > >discover there may be people with backports so we update to 3.2-14~. This > >makes a lot of

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-14 Thread Jakub Wilk
* Vincent Bernat , 2016-10-11, 08:44: We put 3.0-6, then we have to update to 3.2-14 for status_proc. Then we discover there may be people with backports so we update to 3.2-14~. This makes a lot of people in Debian work for people that do not exist (those with distributions

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-13 Thread Michael Biebl
Am 13.10.2016 um 12:26 schrieb Michael Biebl: > I would prefer having the version requirement dropped as well. It seem > rather pointless when even oldstable has a newer version. > > Aside from this issue: Should we handle packages differently which ship > native systemd service files? > You

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-13 Thread Michael Biebl
On Tue, 11 Oct 2016 08:44:57 +0200 Vincent Bernat wrote: > ❦ 8 octobre 2016 13:05 CEST, Evgeni Golov  : > > >> > > But all-in-all, what matters is the dependency, as there were no > >> > > changes > >> > > since 2013 (4.1+Debian10), and Jessie has

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-11 Thread Vincent Bernat
❦ 8 octobre 2016 13:05 CEST, Evgeni Golov  : >> > > But all-in-all, what matters is the dependency, as there were no changes >> > > since 2013 (4.1+Debian10), and Jessie has 4.1+Debian13. >> > >> > Just to be clear, are you suggesting that the version part should be >> >

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-08 Thread Evgeni Golov
Ohai, On Wed, Oct 05, 2016 at 10:23:58PM +0200, Didier 'OdyX' Raboud wrote: > Le mercredi, 5 octobre 2016, 20.08:31 h CEST Chris Lamb a écrit : > > Didier 'OdyX' Raboud wrote: > > > But all-in-all, what matters is the dependency, as there were no changes > > > since 2013 (4.1+Debian10), and

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-05 Thread Didier 'OdyX' Raboud
Le mercredi, 5 octobre 2016, 20.08:31 h CEST Chris Lamb a écrit : > Didier 'OdyX' Raboud wrote: > > But all-in-all, what matters is the dependency, as there were no changes > > since 2013 (4.1+Debian10), and Jessie has 4.1+Debian13. > > Just to be clear, are you suggesting that the version part

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-05 Thread Chris Lamb
Didier 'OdyX' Raboud wrote: > There are more precise checks that could also be done; such as: > - any use of status_of_proc from /lib/lsb/init-functions needs lsb-base (>= > 3.2-14~) Filed as Bug#839861: lintian: init.d-script-needs-depends-on-lsb-base does not use strict enough lsb-base

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-05 Thread Chris Lamb
Didier 'OdyX' Raboud wrote: > But all-in-all, what matters is the dependency, as there were no changes > since > 2013 (4.1+Debian10), and Jessie has 4.1+Debian13. Just to be clear, are you suggesting that the version part should be dropped? I've seen other bits of Deban be really rather

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-05 Thread Didier 'OdyX' Raboud
Le mardi, 27 septembre 2016, 15.29:00 h CEST Chris Lamb a écrit : > Package: lintian > Severity: wishlist > Tags: patch > > Hi, > > Attached is the following: > > commit 288035a951de277d0248ce28c561fbf7f8646839 > Author: Chris Lamb > Date: Tue Sep 27 16:28:04 2016

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-01 Thread Chris Lamb
Hi Niels, Thanks again for the review. > Apologies, I had assumed you had run the test suite, so it turns out > there are a few more remarks. Mea culpa. As an "excuse" I had received your previous instructions on the the testsuite, perlcritic, etc. but after I had written this patch… but I

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-01 Thread Niels Thykier
Chris Lamb: > Dear Niels, > > Thanks for the review. > You are welcome :) Apologies, I had assumed you had run the test suite, so it turns out there are a few more remarks. * There are test failures with the patch (presumably the tests needs updating). - At least init.d-* and

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-10-01 Thread Chris Lamb
Dear Niels, Thanks for the review. > Please shorten the synopsis and move the more length part into the > description. Done… > Please create a non-legacy test case for new tags. A long term goal is > to remove all the t/tests/legacy-* tests. … and done. Good to know :) Updated patch

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-09-30 Thread Niels Thykier
On Tue, 27 Sep 2016 15:29:00 +0100 Chris Lamb wrote: > Package: lintian > Severity: wishlist > Tags: patch > > Hi, > > Attached is the following: > Hi, Thanks for the patch. It looks good and I only got two comments! :) > commit 288035a951de277d0248ce28c561fbf7f8646839

Bug#838997: lintian: checks/init.d: Check for initscripts that source /lib/lsb/init-functions without declaring the corresponding dependency on lsb-base (>= 3.0-6).

2016-09-27 Thread Chris Lamb
Package: lintian Severity: wishlist Tags: patch Hi, Attached is the following: commit 288035a951de277d0248ce28c561fbf7f8646839 Author: Chris Lamb Date: Tue Sep 27 16:28:04 2016 +0200 checks/init.d: Check for initscripts that source /lib/lsb/init-functions