Bug#542072: lintian: bogus warning (zero-byte file, skipping)

2009-08-17 Thread Jakub Wilk
none (no description available) ii man-db2.5.5-3on-line manual pager -- debconf-show failed -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#545078: lintian: warn if symbol file contains tag but no build-dep on dpkg-dev (= 1.15.3~)

2009-09-04 Thread Jakub Wilk
but the package does not build-depend on dpkg-dev (= 1.15.3~). -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#545078: lintian: warn if symbol file contains tag but no build-dep on dpkg-dev (= 1.15.3~)

2009-09-14 Thread Jakub Wilk
as a part of symbol name. That is, in many cases, a package would simply FTBFS due to missing symbols... If so, Lintian could detect that fairly easily and warn about that. Right, but that should be a separate check. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ

Bug#547670: lintian: typo (pth - path)

2009-09-21 Thread Jakub Wilk
Package: lintian Version: 2.2.15 Severity: minor $ grep -C 1 pth /usr/share/lintian/checks/scripts.desc Debian systems; env is instead installed as /usr/bin/env. Usually, the pth to env in the script should be changed. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ

Bug#551793: lintian: [new check] arch:all-only package with build-dep on python*-dev

2009-10-20 Thread Jakub Wilk
. Nonetheless, lots of arch:all-only packages build-depend on python*-dev. It would be nice if lintian warned in such cases and suggested to replace python$foo-dev with python$foo. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe

Bug#553274: lintian: bogus spelling-error-in-binary

2009-10-29 Thread Jakub Wilk
none (no description available) ii libtext-template-perl 1.45-1 Text::Template perl module ii man-db2.5.6-3on-line manual pager -- debconf-show failed -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject

Bug#554685: lintian: [new check] dh_testroot in targets that are not required to be run by root

2009-11-05 Thread Jakub Wilk
Package: lintian Version: 2.2.17 Severity: wishlist Please warn if dh_testroot is called in a debian/rules target, which is not required to be run with root privileges i.e. build, build-arch, build-indep, get-orig-source and patch. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint

Bug#554688: lintian: [new check] illegitimate use of uscan in get-orig-source

2009-11-05 Thread Jakub Wilk
in any directory. It would be nice if linitian detected some cases of such invalid use of uscan. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#554897: lintian: [new check] \' groff escape sequence incorrectly used to denote apostrophe

2009-11-07 Thread Jakub Wilk
], [t]he acute and grave accent characters [...] have no common use in European text. [1] http://www.cl.cam.ac.uk/~mgk25/ucs/apostrophe.html -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas

Bug#555617: lintian: ill-advised description for embedded-feedparser-library

2009-11-10 Thread Jakub Wilk
/bugreport.cgi?bug=525598#10 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#558649: lintian manpage: overrides location

2009-11-29 Thread Jakub Wilk
Package: lintian Version: 2.2.18 Severity: wishlist Please document in the FILES section of manpage where lintian looks for override files. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas

Bug#563185: lintian: typo (suble - subtle)

2009-12-31 Thread Jakub Wilk
Package: lintian Version: 2.3.0 Severity: minor $ lintian-info -t dfsg-version-with-period | grep suble N: form like 1.2.dfsg1. There is a suble sorting problem with this -- Jakub Wilk signature.asc Description: Digital signature

Bug#572260: lintian: duplicate entires in lib/Spelling.pm

2010-03-02 Thread Jakub Wilk
seperate separate seperated separated syncronize synchronize -- Jakub Wilk signature.asc Description: Digital signature

Bug#572456: lintian: new spelling correction: unecessary - unnecessary

2010-03-04 Thread Jakub Wilk
Package: lintian Version: 2.3.3 Severity: wishlist Please add unecessary unnecessary to the list of spelling corrections. -- Jakub Wilk signature.asc Description: Digital signature

Bug#572260: limit source to lintian, tagging 572260, tagging 572456, tagging 574048

2010-03-18 Thread Jakub Wilk
* Adam D. Barratt a...@adam-barratt.org.uk, 2010-03-18, 21:37: # * lib/Spelling.pm: #+ [ADB] Remove duplicate entires from the correction list. Thanks, # Jakub Wilk. (Closes: #572260) Please don't duplicate(!) typo from the bug title, thanks. :) s/entires/entries/ -- Jakub Wilk

Bug#496902: lintian: check if package is shipping *.pyc/*.pyo

2010-03-31 Thread Jakub Wilk
. -- Jakub Wilk signature.asc Description: Digital signature

Bug#576012: lintian: warn on files in /usr/lib/python2.6/site-packages/ et al.

2010-03-31 Thread Jakub Wilk
/ for X.Y = 2.6; - /usr/lib/debug/usr/lib/pythonX.Y/dist-packages/ for X.Y 2.6. -- Jakub Wilk signature.asc Description: Digital signature

Bug#576014: lintian: warn on files in /usr/lib/debug/usr/lib/pyshared/pythonX.Y

2010-03-31 Thread Jakub Wilk
into that directory; /usr/lib/debug/usr/lib/pymodules/pythonX.Y/ should be used instead. -- Jakub Wilk signature.asc Description: Digital signature

Bug#576804: lintian: typo in empty-binary-package description

2010-04-07 Thread Jakub Wilk
Package: lintian Version: 2.3.4 Severity: minor See the attached patch. -- Jakub Wilk diff --git a/checks/files.desc b/checks/files.desc --- a/checks/files.desc +++ b/checks/files.desc @@ -1142,7 +1142,7 @@ package renames or similar problems where installation rules don't put files

Bug#582408: lintian: changelog-is-symlink - internal error: cannot run nmu check

2010-05-20 Thread Jakub Wilk
man-db2.5.7-3on-line manual pager -- debconf-show failed -- Jakub Wilk signature.asc Description: Digital signature

Bug#582511: lintian: If dh_pysupport is used, require Depends package on python-support

2010-05-25 Thread Jakub Wilk
contains ${python:Depends} or ${python:Provides} or ${python:Versions}, but the package neither build-depends on python-support nor on python-central. -- Jakub Wilk signature.asc Description: Digital signature

Bug#585495: lintian: discourage use of $_

2010-06-10 Thread Jakub Wilk
-source target). These packages should use $(dir $(firstword $(MAKEFILE_LIST))) instead. -- Jakub Wilk signature.asc Description: Digital signature

Bug#592414: [new check] Warn about Python extension modules linked to libpythonX.Y

2010-08-09 Thread Jakub Wilk
where a module in a pythonX.Y directory is linked with libpythonZ.W for X.Y != Z.W. See e.g. bug #586937. -- Jakub Wilk signature.asc Description: Digital signature

Bug#592491: lintian: check for missing dependency on python-support

2010-08-10 Thread Jakub Wilk
that ${python:Depends} was omitted from Depends: in debian/control. -- Jakub Wilk signature.asc Description: Digital signature

Bug#592533: lintian: check for missing dependency on python-central

2010-08-10 Thread Jakub Wilk
Depends: in debian/control. -- Jakub Wilk signature.asc Description: Digital signature

Bug#595530: lintian: false-positve duplicate-font-file in tipa

2010-09-04 Thread Jakub Wilk
contained in tipa. -- Jakub Wilk signature.asc Description: Digital signature

Bug#451559: Check for insecure LD_LIBRARY_PATH in wrapper scripts

2010-11-22 Thread Jakub Wilk
$LD_LIBRARY_PATH ]; then export LD_LIBRARY_PATH=$WINELIB:$LD_LIBRARY_PATH else export LD_LIBRARY_PATH=$WINELIB fi Another class of false-positives with naïve regex approach is: export LD_LIBRARY_PATH=/path/to/something:$LD_LIBRARY_PATH cd /path/to/something/else -- Jakub Wilk

Re: Untrusted search path vulnerabilities

2010-11-22 Thread Jakub Wilk
if next stable release means squeeze or wheezy here. IMO it's too late for such changes for squeeze. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org

Bug#614876: [checks/rule] please remove python2.X and python2.X-dev from $PYTHON_DEPEND

2011-02-23 Thread Jakub Wilk
Package: lintian Version: 2.5.0~rc1 $PYTHON_DEPEND is supposed to contain lists of alternatives of packages that ensure /usr/bin/python will exist. However, the list contains e.g. python2.6, which doesn't (transitively) depend on python-minimal. -- Jakub Wilk -- To UNSUBSCRIBE, email

Bug#614879: [checks/rules] false positive missing-build-dependency-for-dh_-command for dh_python{2,3}

2011-02-23 Thread Jakub Wilk
of: python, python-all, python-dev, python-all-dev. For a package using dh_python3, it should be enough to build-depend(-indep) on one of: python3, python3-all, python3-dev, python3-all-dev. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject

Bug#615132: lintian: warn about substvars in source stanza of d/control

2011-02-25 Thread Jakub Wilk
a warning (or perhaps even an error) is such cases. [0] http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=655872184c55febb2299eb6a19aa4d0612d2da60 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas

Bug#614876: [checks/rule] please remove python2.X and python2.X-dev from $PYTHON_DEPEND

2011-02-26 Thread Jakub Wilk
. A python package will need to depend on one of: python | python-dev | python-all | python-all-dev That's right. Or will the python2.Y-dev packages still work? Nope. -- Jakub Wilk signature.asc Description: Digital signature

Bug#614876: [checks/rule] please remove python2.X and python2.X-dev from $PYTHON_DEPEND

2011-03-24 Thread Jakub Wilk
is more complicated that I thought, I need to think a bit about it; tagging the bug accordingly. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org

Bug#619487: lintian: dh_python2 dropped ${python:Breaks} and triggers old-versioned-python-dependency again

2011-03-25 Thread Jakub Wilk
-dependency was meant to detect packages that haven't yet been converted to so called current Python policy. This policy, however, is almost 5 years old. Currently all instances of this tag in the archive are false positives. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ

Bug#631513: lintian: check for embedded copies of Underscore.js

2011-06-24 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: wishlist Tags: patch Please see the attached patch. -- Jakub Wilk diff --git a/checks/files b/checks/files --- a/checks/files +++ b/checks/files @@ -68,6 +68,7 @@ [ qr,(?i)dojo\.js(\.uncompressed\.js)?(\.gz)?$, = qr'libjs-dojo-\w+' ], [ qr,(?i

Bug#631530: lintian: python-debug-in-wrong-location reports filenames with / prefix

2011-06-24 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: minor Tags: patch Please see the attached patch. -- Jakub Wilk diff --git a/checks/files b/checks/files --- a/checks/files +++ b/checks/files @@ -467,7 +467,7 @@ if ($index_info-{type} =~ m/^[-h]/o $file =~ m,^usr/lib/debug/usr/lib/pyshared

Bug#632115: lintian: internal error when checking two binaries with same name and version

2011-06-29 Thread Jakub Wilk
-1~exp1 XZ-format compression utilities -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110629172259.ga1...@jwilk.net

Bug#632550: lintian needs newer debhelper

2011-07-03 Thread Jakub Wilk
just two targets that are currently not used by any tool[0]. I can't see how it could possibly affect buildability of lintian. [0] Well, except dh in compat 9, but lintian certainly doesn't use it. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org

Bug#632883: [checks/debhelper] brace-expansion-in-debhelper-config-file false negatives

2011-07-06 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: normal Tags: patch brace-expansion-in-debhelper-config-file is never triggered for files such as packagename.install; please see the attached patch. -- Jakub Wilk diff --git a/checks/debhelper b/checks/debhelper --- a/checks/debhelper +++ b/checks

Bug#633057: lintian: a central place to list Python versions

2011-07-07 Thread Jakub Wilk
@ CCed.) -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110707231517.ga4...@jwilk.net

Bug#633044: [checks/fields] please add python3-dev to $PYTHON_DEV

2011-07-07 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: minor Tags: patch Please see the attached patch. -- Jakub Wilk diff --git a/checks/fields b/checks/fields --- a/checks/fields +++ b/checks/fields @@ -172,7 +172,7 @@ # Python development packages that are used almost always just for building

Bug#633507: lintian: duplicate missing-build-dependency{,-for-dh_-command} for dh_pysupport

2011-07-10 Thread Jakub Wilk
: missing-build-dependency python-support I guess one error would be enough. :) -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110710222415.ga2

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-07-13 Thread Jakub Wilk
at the problem would be quite effective. E.g., out of 111 DEP-5-ish debian/copyright files in Debian Python Modules Team, 19 is so broken cannot be even parsed by grep-dctrl. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble

Bug#633850: lintian: check for dh-make boilerplate in README.source

2011-07-14 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: wishlist Please warn if debian/README.source contains the following string: You WILL either need to modify or delete this file -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe

Bug#633853: [checks/shared-libraries] add information about #204975 to tag descriptions

2011-07-14 Thread Jakub Wilk
if descriptions of these tags could contain a pointer to the bug log. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110714124949.ga9...@jwilk.net

Bug#634191: [checks/lintian] CR(LF) line endings in copyright files

2011-07-17 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: wishlist Tags: patch Please see the attached patch. -- Jakub Wilk diff --git a/checks/copyright-file b/checks/copyright-file --- a/checks/copyright-file +++ b/checks/copyright-file @@ -130,6 +130,10 @@ $_ = slurp_entire_file('copyright'); study

Bug#634222: [data/spelling/corrections] please add specificatin

2011-07-17 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Severity: wishlist Please add specificatin||specification to data/spelling/corrections. (Typo seen in libreoffice debian/copyright.) -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-07-17 Thread Jakub Wilk
I attached a (preliminary?) patch adding support for very basic DEP-5 validation. Beware, tag descriptions could use some love. ;) -- Jakub Wilk diff --git a/checks/copyright-file b/checks/copyright-file --- a/checks/copyright-file +++ b/checks/copyright-file @@ -24,6 +24,7 @@ use Lintian

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-07-18 Thread Jakub Wilk
* Jakub Wilk jw...@debian.org, 2011-07-17, 23:38: + elsif ($uri =~ m,^http://www\.debian\.org/doc/(packaging-manuals/?)copyright-format/(\d+.\d+)$,) { The regex here should be of course: m,^http://www\.debian\.org/doc/(?:packaging-manuals/)?copyright-format/(\d+\.\d+)$, -- Jakub Wilk

Bug#635354: [checks/binaries] static libs should trigger binary-in-etc, arch-dependent-file-in-usr-share

2011-07-25 Thread Jakub Wilk
Package: lintian Version: 2.5.1 Tags: patch Currently only shared libraries and ELF executables can trigger binary-in-etc or arch-dependent-file-in-usr-share. The attached patch makes lintian issue these tags also for static libraries. -- Jakub Wilk diff --git a/checks/binaries b/checks

Bug#637259: [checks/binaries] binary-or-shlib-defines-rpath for /usr/lib/$(DEB_HOST_MULTIARCH)

2011-08-09 Thread Jakub Wilk
to any directory of the standard ldconfig search path. There's already some code to tell if a directory is such one in checks/shared-libs, so it'd have to be factored out. -- Jakub Wilk diff --git a/checks/binaries b/checks/binaries --- a/checks/binaries +++ b/checks/binaries @@ -315,7 +315,7

Bug#637590: [checks/conffiles] merge with checks/etcfiles

2011-08-12 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: wishlist Tags: patch checks/conffiles and checks/etcfiles are both very short and there's certain amount of code duplication between them. I propose to merge them in to a single check. -- Jakub Wilk diff --git a/checks/conffiles b/checks/conffiles

Bug#637595: lintian: please use LC_ALL instead of LANG

2011-08-12 Thread Jakub Wilk
://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html#tag_002_002 -- Jakub Wilk # HG changeset patch # Parent afd9713258f4a63cbd123dbbe544a4216f2cf28d diff --git a/checks/infofiles b/checks/infofiles --- a/checks/infofiles +++ b/checks/infofiles @@ -89,7 +89,7 @@ fail(cannot fork: $!); } elsif ($pid

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-08-12 Thread Jakub Wilk
checks only copyright files in binary packages, not in source packages. However, to properly validate a DEP-5 copyright file, you need access the source package. So perhaps it'd make sense to have a source-copyright-file check and move DEP-5 stuff there? -- Jakub Wilk -- To UNSUBSCRIBE

Bug#637649: lintian: copyright files in test debs with wrong permissions

2011-08-13 Thread Jakub Wilk
md5sums nobody/root != root/root E: control-files-bad: control-file-has-bad-permissions md5sums 0755 != 0644 +W: control-files-bad: non-standard-file-perm usr/share/doc/control-files-bad/copyright 0600 != 0644 make: *** [runtests] Error 1 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint

Bug#637741: [lib/Lintian/Collect/Package.pm] uses fail without importing it

2011-08-13 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: minor See the attached patch. -- Jakub Wilk diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm --- a/lib/Lintian/Collect/Package.pm +++ b/lib/Lintian/Collect/Package.pm @@ -24,7 +24,7 @@ use base 'Lintian::Collect'; use

Bug#637819: lintian.debian.org/lintian.log.gz

2011-08-14 Thread Jakub Wilk
Package: lintian Severity: wishlist lintian.log is quite big, but it can be compressed easily: even with gzip you can achieve 10-fold size reduction. It would be nice if a compressed version of lintian.log were available for download. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-08-14 Thread Jakub Wilk
* Niels Thykier ni...@thykier.net, 2011-08-13, 13:20: Feel free to add a new separate check if that results in more maintainable code. :) Okay, updated patch attached. -- Jakub Wilk diff --git a/checks/source-copyright-file b/checks/source-copyright-file new file mode 100644 --- /dev/null

Bug#582511: lintian: If dh_pysupport is used, require Depends package on python-support

2011-08-20 Thread Jakub Wilk
it, if a package maintainer forget to explicitly build-depend on it, it's less likely it'll be pulled in by other build-dependencies. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-08-21 Thread Jakub Wilk
* Jakub Wilk jw...@debian.org, 2011-08-15, 00:36: Feel free to add a new separate check if that results in more maintainable code. :) Okay, updated patch attached. I renamed the check to source-copyright (from source-copyright-file, which was too long :P), fixed a few minor bugs, added

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-08-22 Thread Jakub Wilk
tags that are not covered. Is a part of this patch missing? Ooops, good catch. I attach the missing bits. The patch carries 7 source-copyright tests (boilerplate-uri, missing, ood-uri [odd?], That's OOD as in Out Of Date. -- Jakub Wilk diff --git a/t/tests/source-copyright-dep5-general/debian

Bug#636086: [PATCH] Use C.UTF-8 from current libc-bin, rather than our own private en_US.UTF-8

2011-08-22 Thread Jakub Wilk
didn't test it yet!) -- Jakub Wilk diff --git a/debian/postinst b/debian/postinst --- a/debian/postinst +++ b/debian/postinst @@ -19,7 +19,8 @@ if [ $1 = configure ]; then if [ ! -f $locale_dir/en_US.UTF-8/LC_CTYPE ] - [ -f /usr/share/locale/locale.alias ]; then + [ -f /usr/share/locale

Bug#636086: [PATCH] Use C.UTF-8 from current libc-bin, rather than our own private en_US.UTF-8

2011-08-23 Thread Jakub Wilk
(if C.UTF-8 is not provided by libc-bin, then we generate en_US.UTF-8). Did you mean .../locale/en_US.UTF-8? +if [ ! -d '/usr/lib/locale/en_US.UTF-8' ] ; then /usr/lib/locale/en_US.UTF-8 doesn't exist. Did you mean /usr/lib/locale/C.UTF-8? -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint

Bug#639177: [checks/shared-libraries] typo in non-empty-dependency_libs-in-la-file description

2011-08-24 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: minor Tags: patch Please see the attached patch. -- Jakub Wilk diff --git a/checks/shared-libs.desc b/checks/shared-libs.desc --- a/checks/shared-libs.desc +++ b/checks/shared-libs.desc @@ -422,7 +422,7 @@ dependency_libs field from the rest of them

Bug#639367: [data/spelling/corrections] please add (un)conditionaly

2011-08-26 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: wishlist Please add conditionaly||conditionally unconditionaly||unconditionally to data/spelling/corrections. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact

Bug#639516: [lib/Util.pm] control file parsers silently ignores some invalid lines

2011-08-27 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: minor The control file parser silently ignores lines that don't start with whitespace and don't contain a colon either. The attached patch should fix this bug. -- Jakub Wilk diff --git a/lib/Util.pm b/lib/Util.pm --- a/lib/Util.pm +++ b/lib/Util.pm

Bug#633779: lintian: validate DEP-5 debian/copyright files

2011-08-28 Thread Jakub Wilk
The attached patch fixes a minor bug. Without it, a format like http://anonscm.debian.org/viewvc/dep/web/deps/dep5.mdwn?view=markuppathrev=174 would trigger unversioned-copyright-format-uri. -- Jakub Wilk diff --git a/checks/source-copyright b/checks/source-copyright --- a/checks/source

Bug#634112: debhelper deprecations

2011-08-28 Thread Jakub Wilk
to bother with that. I agree that it's not worth effort. (Well, at least my effort. :P) -- Jakub Wilk diff --git a/checks/debhelper b/checks/debhelper --- a/checks/debhelper +++ b/checks/debhelper @@ -103,6 +103,9 @@ if ($dhcommand eq 'dh_pycentral') { tag 'dh_pycentral-is-obsolete', line

Bug#607399: lintian: false-positive with shlib-calls-exit (triggered on application)

2011-08-30 Thread Jakub Wilk
-with-executable-bit. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110830155537.ga1...@jwilk.net

Bug#634191: [checks/copyright-file] CR(LF) line endings in copyright files

2011-08-31 Thread Jakub Wilk
* Niels Thykier ni...@thykier.net, 2011-08-31, 11:29: I have attached the test I used (merged with the original patch); hopefully you can spot the issue. :) You forgot --pedantic. :P -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject

Bug#639923: lintian: unresolvable Ref

2011-08-31 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Tags: patch The attached patch fixes a few unresolvable references. (The change in lib/Lintian/Tag/Info.pm is needed for hyphen-used-as-minus-sign.) -- Jakub Wilk diff --git a/checks/copyright-file.desc b/checks/copyright-file.desc --- a/checks/copyright

Bug#639928: [checks] please get rid of whitespace-only lines in *.desc

2011-08-31 Thread Jakub Wilk
use empty lines. At least grep-dctrl accept only empty lines as paragraph and I'd like to use it for *.desc processing. Patch: $ sed -i -e 's/^ *$//' checks/*.desc -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble

Bug#639946: lintian: let's get rid of (most) *-debmake-* tags

2011-08-31 Thread Jakub Wilk
in the archive. The attached patch gets rid of the remaining *-debmake-* tags. -- Jakub Wilk diff --git a/checks/changelog-file b/checks/changelog-file --- a/checks/changelog-file +++ b/checks/changelog-file @@ -270,9 +270,7 @@ my %versions; for my $entry (@entries) { if ($entry-Maintainer

Bug#574689: [SCM] Debian package checker branch, master, updated. 2.5.2-77-g5f42daa

2011-09-01 Thread Jakub Wilk
; \ + done set -e is missing here (as per Policy 4.6). -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110901170348.ga6...@jwilk.net

Bug#639946: lintian: let's get rid of (most) *-debmake-* tags

2011-09-02 Thread Jakub Wilk
it, for instance), and the warnings are still correct for such packages. I don't think keeping them adds much maintenance burden. Okay, I attached a more conservative patch. -- Jakub Wilk diff --git a/checks/changelog-file b/checks/changelog-file --- a/checks/changelog-file +++ b/checks/changelog-file

Bug#640149: [data/spelling/corrections-multiword] please add is not enable

2011-09-02 Thread Jakub Wilk
to add also correction for is enabled (which happens to be a fairly common typo) I'm afraid it could trigger false positives, e.g. All you have to do is enable booting from a CD-ROM. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject

Bug#640186: [checks/files] regression: W: python2.6: third-party-package-in-python-dir

2011-09-03 Thread Jakub Wilk
ii xz-utils 5.1.1alpha+20110809-3~exp1 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110903090117.ga3...@jwilk.net

Bug#640228: [private/refresh-manual-refs] needs libpkg-guide

2011-09-03 Thread Jakub Wilk
Package: lintian Version: 2.5.2 private/refresh-manual-refs requires libpkg-guide installed, but this package is not unstable anymore; see bug #611564. We have currently one tag referring to libpkg-guide: package-name-doesnt-match-sonames. -- Jakub Wilk -- To UNSUBSCRIBE, email

Bug#640238: [checks/changelog-file] uninitialized value in hash element

2011-09-03 Thread Jakub Wilk
first heading [snip - even more syntax-error-in-debian-changelog tags] O: perl: syntax-error-in-debian-changelog line 70 found eof where expected more change data or trailer Use of uninitialized value in hash element at /usr/share/lintian/checks/changelog-file line 279. -- Jakub Wilk

Bug#629308: [SCM] Debian package checker branch, master, updated. 2.5.2-91-g4a574d9

2011-09-03 Thread Jakub Wilk
think ftp and gopher should be also accepted as valid protocols: $ grep-aptavail -s Homepage '' | cut -d : -f2 | sort | uniq -c | sort -rn 26656 http 760 https 37 ftp 2 gopher -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject

Bug#640371: [checks/files] check for compliance with Packaging Policy for Vim 3.1

2011-09-04 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: wishlist Tags: patch Please see the attached patches. (The first two merely clean up a few things in private/refresh-manual-refs.) Vim maintainers cc-ed, so that they can comment. -- Jakub Wilk diff --git a/private/refresh-manual-refs b/private

Bug#640371: [checks/files] check for compliance with Packaging Policy for Vim 3.1

2011-09-04 Thread Jakub Wilk
And here goes some tests. -- Jakub Wilk diff --git a/t/COVERAGE b/t/COVERAGE --- a/t/COVERAGE +++ b/t/COVERAGE @@ -1,5 +1,5 @@ -Last generated 2011-09-02 -Coverage: 716/933 (76.74%), w. legacy tests: 838/933 (89.82%) +Last generated 2011-09-04 +Coverage: 719/934 (76.98%), w. legacy tests: 841

Bug#640694: lintian siletly ignores -L if used together with -C

2011-09-06 Thread Jakub Wilk
ii man-db 2.6.0.2-2 ii perl [libdigest-sha-perl] 5.12.4-4 ii unzip 6.0-5 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble

Bug#640705: lintian manpage: stray POD markup: Iarchivedir/dists/Idistdir/Irelease/Iarch

2011-09-06 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: minor Tags: patch $ man lintian | grep 'I' Iarchivedir/dists/Idistdir/Irelease/Iarch -- Jakub Wilk diff --git a/man/lintian.pod.in b/man/lintian.pod.in --- a/man/lintian.pod.in +++ b/man/lintian.pod.in @@ -505,7 +505,11 @@ path to the archive

Bug#640834: lintian: detect typoed Debian QA Group address

2011-09-07 Thread Jakub Wilk
...@qa.debian.org -- Jakub Wilk diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm --- a/lib/Lintian/Check.pm +++ b/lib/Lintian/Check.pm @@ -170,7 +170,8 @@ # Some additional checks that we only do for maintainer fields. if ($field eq 'maintainer') { -if ($mail eq 'debian

Bug#640853: [checks/descriptions] more Refs

2011-09-07 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: wishlist Tags: patch The attached patch adds Ref fields to the following tags: package-has-no-description, description-synopsis-is-empty, extended-description-is-empty. -- Jakub Wilk diff --git a/checks/description.desc b/checks/description.desc

Bug#640856: [checks/fields] bump severity of no-human-maintainers

2011-09-07 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: wishlist Tags: patch no-human-maintainers is now a must policy violation, so its severity should be bumped to serious. -- Jakub Wilk diff --git a/checks/fields.desc b/checks/fields.desc --- a/checks/fields.desc +++ b/checks/fields.desc @@ -245,12

Bug#640856: [checks/fields] bump severity of no-human-maintainers

2011-09-08 Thread Jakub Wilk
* Jakub Wilk jw...@debian.org, 2011-09-08, 01:16: no-human-maintainers is now a must policy violation, so its severity should be bumped to serious. I forgot to update tests. -- Jakub Wilk diff --git a/t/tests/fields-no-human-maintainer/tags b/t/tests/fields-no-human-maintainer/tags --- a/t

Bug#640947: [checks/fields] superfluous-clutter-in-homepage implies bad-homepage

2011-09-08 Thread Jakub Wilk
Package: lintian Version: 2.5.2 Severity: minor Whenever lintian emits superfluous-clutter-in-homepage, it also emits bad-homepage. I think we should either get rid of *-clutter-in-homepage entirely, or make it suppress bad-homepage. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint

Re: Fixing indentation in our source files

2011-09-09 Thread Jakub Wilk
contradictory vim: ts=4 declaration. :( Personally I'd prefer 4*space indentation everywhere. I could live with tabs, but tabs mixed with spaces make me cringe. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas

Bug#641468: lintian: update the lab layout (i.e. use pools)

2011-09-13 Thread Jakub Wilk
this limitation, so a work-around would be to convert the filesystem. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110913172135.ga4...@jwilk.net

Bug#641609: Lintian::Collect::Source::binary_relation broken

2011-09-14 Thread Jakub Wilk
Package: lintian Version: 2.5.3 Severity: minor Tags: patch Lintian::Collect::Source::binary_relation() doesn't work at all. The attached patch fixes it. BTW, once it's fixed, we could use it to simplify implementation of {debhelper-but-no,weak-dependency-on}-misc-depends tags. -- Jakub

Bug#641879: unused-license-paragraph-in-dep5-copyright generated for used license paragraphs

2011-09-17 Thread Jakub Wilk
understanding, MPL-1.1 and GPL-2+ license paragraphs are indeed unused here. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110917103748.ga4...@jwilk.net

Bug#641983: [checks/files] package-installs-packlist description suggests find ... | xargs ... pipeline

2011-09-18 Thread Jakub Wilk
Package: lintian Version: 2.5.3 Severity: wishlist Tags: patch package-installs-packlist suggests to use find ... | xargs rm -f pipe to delete files. However, find ... -delete should be both faster and more robust. -- Jakub Wilk diff --git a/checks/files.desc b/checks/files.desc --- a/checks

Bug#642027: [checks/source-copyright] false-positive unknown-copyright-format-uri

2011-09-18 Thread Jakub Wilk
/dep5.mdwn?revision=174 -- Jakub Wilk diff --git a/checks/source-copyright b/checks/source-copyright --- a/checks/source-copyright +++ b/checks/source-copyright @@ -105,9 +105,9 @@ $version = '0+svn'; $uri =~ m,^\?(?:\S+)?rev=(\d+)(?:\S+)?$, and $version = $version~$1; } - elsif ($uri

Bug#642038: [checks/files] setuid-binary for binaries linked with libvga

2011-09-18 Thread Jakub Wilk
Package: lintian Version: 2.5.3 Severity: minor Tags: patch lintian tries to avoid emitting setuid-binary for binaries that are linked with libvga, but it does't quite work: $ lintian --no-cfg -C files zgv_5.9-2+b1_i386.deb W: zgv: setuid-binary usr/bin/zgv 4755 root/root -- Jakub Wilk diff

Bug#642047: [private/generate-profiles.pl] doesn't work without LINTIAN_ROOT set

2011-09-18 Thread Jakub Wilk
-profiles.pl line 20. This is a bit annoying and also inconsistent with behavior of other private/ scripts (which either don't care about LINTIAN_ROOT at all or at least default to the current working directory if the variable is unset). -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-lint-maint

Bug#628678: lintian: please check that setup.py and debian/changelog have same version

2011-09-19 Thread Jakub Wilk
that there are almost no false-positives, yet number of true positives is surprisingly high (a few dozens IIRC). If someone (hint, hint) contributes a better tag description, and possibly a better name than egg-info-version-mismatch, I can port this code to lintian proper. -- Jakub Wilk

Bug#642092: [checks/binaries] please don't complain about /usr/lib/sourcepackage RPATH

2011-09-19 Thread Jakub Wilk
/jni/libjavasci.so.5.3.3 /usr/lib/scilab O: virtualbox-fuse: binary-or-shlib-defines-rpath usr/bin/vdfuse /usr/lib/virtualbox -- Jakub Wilk diff --git a/checks/binaries b/checks/binaries --- a/checks/binaries +++ b/checks/binaries @@ -140,6 +140,7 @@ my %SONAME; $arch = $info-field

Bug#592414: [new check] Warn about Python extension modules linked to libpythonX.Y

2011-09-19 Thread Jakub Wilk
tags 592414 + patch thanks * Jakub Wilk jw...@debian.org, 2010-08-09, 23:02: Public Python extension modules, i.e. *.so files in one of these directories: /usr/lib/pyshared/pythonX.Y/ /usr/lib/python-support/PACKAGENAME/pythonX.Y/ /usr/lib/pythonX.Y/site-packages/ /usr/lib/pythonX.Y

  1   2   3   4   5   6   7   8   9   10   >