Bug#463476: checkbashisms: fails to detect shell wrappers

2008-01-31 Thread Adam D. Barratt
Package: lintian Version: 1.23.42 Tags: patch X-Debbugs-Cc: [EMAIL PROTECTED] On Wed, 2008-01-30 at 10:30 -0800, Russ Allbery wrote: Raphael Geissert [EMAIL PROTECTED] writes: This sounds more like a report against checkbashisms. I guess it could try to detect these: See

Re: List of packages shipping shell scripts with bashisms + MBF proposal

2008-01-31 Thread Adam D. Barratt
Hi, On Wed, 2008-01-30 at 12:12 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: lintian's parsing code certainly sounds better (mainly because checkbashisms is based on an old version of the lintian code) but, from a quick look, checkbashisms flags more issues than

Re: List of packages shipping shell scripts with bashisms + MBF proposal

2008-02-01 Thread Adam D. Barratt
On Thu, 2008-01-31 at 20:46 +, I wrote: On Wed, 2008-01-30 at 12:12 -0800, Russ Allbery wrote: I'd definitely welcome any additional regexes or code to add to lintian. (And at some point we can figure out how to keep this in sync with less effort.) Having had chance to compare the

Bug#464026: notfound 464026 in 1.2.42, found 464026 in 1.3.42

2008-02-04 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.14 # Ugh... notfound 464026 1.2.42 found 464026 1.3.42 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#464026: [checks/scripts] Sync bashism tests with checkbashisms

2008-02-04 Thread Adam D. Barratt
Package: lintian Version: 1.2.42 Tags: patch X-Debbugs-Cc: [EMAIL PROTECTED] Hi, As discussed recently, please find attached a patch (against lintian and devscripts SVN) to checks/scripts that adds the bashism tests that devscripts's checkbashisms performs but lintian does not. The only test

Bug#464026: [checks/scripts] Sync bashism tests with checkbashisms

2008-02-04 Thread Adam D. Barratt
On Mon, 2008-02-04 at 14:50 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: As discussed recently, please find attached a patch (against lintian and devscripts SVN) to checks/scripts that adds the bashism tests that devscripts's checkbashisms performs but lintian does

Bug#464026: [checks/scripts] Sync bashism tests with checkbashisms

2008-02-04 Thread Adam D. Barratt
On Mon, 2008-02-04 at 16:06 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: The first two certainly should be prefixed by something to avoid them matching strings that happen to end in echo -e. I've updated checkbashisms to do so for all three. As far as I can see

checks/scripts / checkbashsims updates

2008-02-10 Thread Adam D. Barratt
Hi, Thanks for adding the set of bashism checks from checkbashisms to lintian recently. As a result of the recent bugs that people have been filing on other packages using checkbashsims output, a few issues have surfaced - one with a check that originated in the patch, and a couple that were

Re: checks/scripts / checkbashsims updates

2008-02-18 Thread Adam D. Barratt
On Mon, 2008-02-18 at 16:33 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: Please let me know how you'd prefer to handle these, and any such issues that arise in future. I'm more than happy to simply provide a list (as below), send patches to the list or file bugs

Re: checks/scripts / checkbashsims updates

2008-02-18 Thread Adam D. Barratt
On Mon, 2008-02-18 at 16:33 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: [...] The first issue is from the checkbashisms side: '(?!\$)\(\(', # '((' should be '$((' This will also match constructs such as if ((foo || bar) baz). I've tightened

Re: checks/scripts / checkbashsims updates

2008-02-19 Thread Adam D. Barratt
On Tue, 2008-02-19 at 09:07 -0800, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: Sorry to be a pain, but we've tightened this further in svn to '(?![\$\(])\(\(.*\)\)' so as not to match constructs such as progress_size=$(((100 - $PROGRESS_STATE) / 3

[checks/scripts] checkbashsims update

2008-02-24 Thread Adam D. Barratt
Hi, Please find attached a patch which updates checks/scripts in line with recent changes to checkbashisms. The changes are: - Fix the $( foo) test to not trigger on $( foo grep bar) and similar constructs. (i.e. there should only be a single word between and ) in order to trigger.) - Add a

Re: [checks/scripts] checkbashsims update

2008-02-28 Thread Adam D. Barratt
On Sun, 2008-02-24 at 14:41 +, Adam D. Barratt wrote: Hi, Please find attached a patch which updates checks/scripts in line with recent changes to checkbashisms. Oops. A couple of the changes were slightly broken; I've just released devscripts 2.10.18 to fix them. Please find attached

Re: [checks/scripts] checkbashsims update

2008-02-29 Thread Adam D. Barratt
Adam D. Barratt wrote: On Sun, 2008-02-24 at 14:41 +, Adam D. Barratt wrote: Hi, Please find attached a patch which updates checks/scripts in line with recent changes to checkbashisms. Oops. A couple of the changes were slightly broken; I've just released devscripts 2.10.18 to fix them

Re: lintian: r1264 - in trunk: debian lib

2008-03-14 Thread Adam D. Barratt
Hi, On Thu, 2008-03-13 at 00:01 +0100, [EMAIL PROTECTED] wrote: [...] Log: * lib/Spelling.pm: + [RA] Avoid Perl warnings when called with an uninitialized value. [...] Modified: trunk/lib/Spelling.pm === ---

Bug#471333: [checks/scripts] script_is_evil_and_wrong() regex error

2008-03-17 Thread Adam D. Barratt
Package: lintian Version: 1.23.47 Tags: patch Hi, script_is_evil_and_wrong fails to catch scripts using ${1:[EMAIL PROTECTED] as it expects the optional quote to appear immediately before $@ rather than before the optional ${1+. The attached patch fixes this. Regards, Adam

Bug#471333: notfound 471333 in 1.23.47, found 471333 in 1.23.46

2008-03-20 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.19 notfound 471333 1.23.47 # Let's use a version that's actually in the archive... :) found 471333 1.23.46 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

[checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-03-25 Thread Adam D. Barratt
Hi, I've attached a few patches against current lintian SVN which update checks/scripts to incorporate some changes that have been made to checkbashisms recently (there are a few changes I've not included such as ignoring multi-line quoted text and checking for invalid function names, as I'd like

Bug#473156: [checks/scripts] dash now supports $((cnt+1))

2008-03-28 Thread Adam D. Barratt
Package: lintian Version: 1.23.46 Severity: wishlist Tags: patch Hi, dash (finally) gained support for the shell arithmetic construct $((var +1)) with the upload of 0.5.4-3 in December 2007 (see #329025). As lenny contains a version of dash with the support, I've attached a patch removing the

Bug#473156: [checks/scripts] dash now supports $((cnt+1))

2008-03-28 Thread Adam D. Barratt
On Fri, 2008-03-28 at 11:31 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: [...] dash (finally) gained support for the shell arithmetic construct $((var +1)) with the upload of 0.5.4-3 in December 2007 (see #329025). As lenny contains a version of dash

Bug#473156: [checks/scripts] dash now supports $((cnt+1))

2008-03-28 Thread Adam D. Barratt
On Fri, 2008-03-28 at 11:59 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: As far as I can see, it *is* in POSIX, which is what persuaded Herbert to (albeit slowly) add it to dash. Oh! Then the comment now makes sense to me, and by all means we should remove

Bug#473156: [checks/scripts] dash now supports $((cnt+1))

2008-04-04 Thread Adam D. Barratt
On Fri, 2008-03-28 at 19:23 +, Adam D. Barratt wrote: On Fri, 2008-03-28 at 11:59 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: As far as I can see, it *is* in POSIX, which is what persuaded Herbert to (albeit slowly) add it to dash. Oh

Re: [checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-04-30 Thread Adam D. Barratt
Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: There have been several further changes to checkbashisms in the past month, most of which should be suitable for merging in to lintian. Please let me know whether you'd prefer incremental patches once those from my earlier message

Re: [checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-05-01 Thread Adam D. Barratt
On Wed, 2008-04-30 at 14:14 -0700, Russ Allbery wrote: Frank Lichtenheld [EMAIL PROTECTED] writes: On Tue, Apr 29, 2008 at 11:32:30PM -0700, Russ Allbery wrote: At the moment, I haven't had a chance to apply any of your patches, so if it's the same amount of work for you, a unified patch

Bug#479318: does not work with perl 5.10.x

2008-05-04 Thread Adam D. Barratt
tags 479318 + patch thanks Hi, On Sun, 2008-05-04 at 11:33 +0200, Stefano Zacchiroli wrote: Here is what I get today, after an upgrade to perl 5.10.x, running lintian on a *.changes file: $ lintian ocaml-res_2.2.5-1_i386.changes Can't use string (1) as an ARRAY ref while strict refs in

Re: [checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-05-06 Thread Adam D. Barratt
On Thu, 2008-05-01 at 20:19 +0100, Adam D. Barratt wrote: On Wed, 2008-04-30 at 14:14 -0700, Russ Allbery wrote: Frank Lichtenheld [EMAIL PROTECTED] writes: Easiest would probably be to just give Adam commit rights and let him do the whole work ;) That would also work. :) I'd

Re: [checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-05-17 Thread Adam D. Barratt
On Fri, May 16, 2008 23:58, Frank Lichtenheld wrote: On Wed, May 07, 2008 at 12:00:48AM +0100, Adam D. Barratt wrote: [...] I had time, but unfortunately not the magic commit bit :-/ I've been forming a list of patches in my head (which I should probably write down before I forget any

Re: [checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-05-19 Thread Adam D. Barratt
On Tue, 2008-05-20 at 03:15 +0200, Frank Lichtenheld wrote: On Sat, May 17, 2008 at 10:51:03AM +0100, Adam D. Barratt wrote: On Fri, May 16, 2008 23:58, Frank Lichtenheld wrote: [...] Have you generated an account at http://svn.wolffelaar.nl/ ? I've tried, a few times, but it appears

Re: [checks/scripts] script_is_evil_and_wrong() and bashisms update

2008-05-29 Thread Adam D. Barratt
On Wed, 2008-05-28 at 22:35 +0200, Frank Lichtenheld wrote: On Tue, May 20, 2008 at 06:32:42AM +0100, Adam D. Barratt wrote: On Tue, 2008-05-20 at 03:15 +0200, Frank Lichtenheld wrote: [...] Maybe that code should be moved to Alioth at some point... I did notice that there was an Alioth

Bug#484359: [frontend/lintian] Urgencies are case-sensitive

2008-06-03 Thread Adam D. Barratt
Package: lintian Version: 1.23.49 Hi, During a discussion on #debian-release, it was confirmed that britney treats urgencies as case-sensitive - i.e. high != HIGH. lintian's check for valid urgencies, conversely, is case-insensitive. The check should be modified to be case-sensitive. As HIGH is

Bug#484359: [frontend/lintian] Urgencies are case-sensitive

2008-06-03 Thread Adam D. Barratt
On Tue, 2008-06-03 at 14:30 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: During a discussion on #debian-release, it was confirmed that britney treats urgencies as case-sensitive - i.e. high != HIGH. lintian's check for valid urgencies, conversely, is case-insensitive

Broken test in testset/maintainer-scripts/debian/postinst ?

2008-06-12 Thread Adam D. Barratt
[Apologies if the following is overly verbose; I erred towards potentially including too much information rather than too little] Hi, One of the changes I've made in checkbashisms is to modify the check for heredoc delimiters to match against a copy of the input line which has had most

[checks/scripts] [PATCH 1/4] bashisms and quoted quotes

2008-06-13 Thread Adam D. Barratt
Hi, This is the first of a series of patches updating checks/scripts bashisms checks with some changes that have been made to checkbashisms over the past few months. Hopefully all the patches are self-explanatory, but please let me know if there are any questions or issues. Regards, Adam

[checks/scripts] [PATCH 2/4] heredoc detection

2008-06-13 Thread Adam D. Barratt
Hi, This is the second of a series of patches updating checks/scripts bashisms checks with some changes that have been made to checkbashisms over the past few months. This patch assumes (due to the context included in the diff) that the previous patch has already been applied. Hopefully all

[checks/scripts] [PATCH 4/4] bashisms update

2008-06-13 Thread Adam D. Barratt
Hi,  This is the fourth of a series of patches updating checks/scripts bashisms checks with some changes that have been made to checkbashisms over the past few months. It's possible that some hunks of this patch may fail to apply as-is due to conflicts with earlier patches; if this turns out to

Re: [checks/scripts] [PATCH 2/4] heredoc detection

2008-06-14 Thread Adam D. Barratt
On Sat, 2008-06-14 at 05:05 +0200, Frank Lichtenheld wrote: On Fri, Jun 13, 2008 at 03:08:41PM +0100, Adam D. Barratt wrote: @@ -615,6 +631,7 @@ # We've checked for all the things we still want to notice in # double-quoted strings, so now remove those strings

Re: [checks/scripts] [PATCH 1/4] bashisms and quoted quotes

2008-06-14 Thread Adam D. Barratt
On Sat, 2008-06-14 at 05:20 +0200, Frank Lichtenheld wrote: On Sat, Jun 14, 2008 at 04:58:02AM +0200, Frank Lichtenheld wrote: On Fri, Jun 13, 2008 at 03:08:01PM +0100, Adam D. Barratt wrote: This is the first of a series of patches updating checks/scripts bashisms checks with some

Re: [checks/scripts] [PATCH 3/4] shell script wrapper detection

2008-06-14 Thread Adam D. Barratt
On Sat, 2008-06-14 at 05:08 +0200, Frank Lichtenheld wrote: On Fri, Jun 13, 2008 at 03:09:00PM +0100, Adam D. Barratt wrote: + last if (++$i 55); + if (/(^\s*|\beval\s*[\'\]|(;|)\s*)exec\s*.+\s*.?\$$var.?\s*(--\s*)?.?(\${1:?\+.?)?(\$(\@|\*))?/) { I guess that regex could really

Bug#486145: lintian: Please downgrade depends-on-obsolete-package to warning for alternative OR'ed dependencies

2008-06-16 Thread Adam D. Barratt
tags 486145 + patch thanks Hi, On Sun, 2008-06-15 at 14:32 +0200, Raphael Hertzog wrote: On Fri, 13 Jun 2008, Kevin B. McCarty wrote: For instance, if bar is a known obsolete package, then the following in debian/control: (Build-)Depends: foo | bar will trigger a Lintian error.

Re: [checks/scripts] [PATCH 2/4] heredoc detection

2008-06-17 Thread Adam D. Barratt
On Tue, 2008-06-17 at 22:55 +0200, Frank Lichtenheld wrote: On Sat, Jun 14, 2008 at 10:47:31AM +0100, Adam D. Barratt wrote: On Sat, 2008-06-14 at 05:05 +0200, Frank Lichtenheld wrote: On Fri, Jun 13, 2008 at 03:08:41PM +0100, Adam D. Barratt wrote: @@ -615,6 +631,7

Re: [checks/scripts] [PATCH 2/4] heredoc detection

2008-06-17 Thread Adam D. Barratt
On Tue, 2008-06-17 at 22:08 +0100, Adam D. Barratt wrote: On Tue, 2008-06-17 at 22:55 +0200, Frank Lichtenheld wrote: [...] Applied with the fix above and the replacement of the duplicated regexes by variables. Thanks; fwiw, the regexes aren't (quite) duplicated. The $cat_line

Bug#486795: Bug#486797: qa.debian.org: email addresses are case-insensitive

2008-06-18 Thread Adam D. Barratt
Christoph Martin wrote: If a maintainer has some packages with his email address in different case in the maintainer field they end up on different pages on qa.debian.org. See for example: [...] Ony should get the same page independent of the case of the maintainer email. Probably this is

Re: Certainty and severity levels

2008-06-18 Thread Adam D. Barratt
On Wed, 2008-06-18 at 20:03 +0200, Jordà Polo wrote: [My comments may appear a little picky in places - because they are ;-) That's because I don't have any real issues with the content though] Severity represents how grave is the problem that can be detected using a particular check. s/is

Off-by-one in the tags report?

2008-06-18 Thread Adam D. Barratt
Hi, I was just having a quick look at the new web pages (which are very cool :-) and spotted what appears to be an off-by-one or similar issue in the tags report. Part of the report includes: derivations (binary) suggests: tetex-bin devscripts (binary) suggests:

Re: Off-by-one in the tags report?

2008-06-18 Thread Adam D. Barratt
On Wed, 2008-06-18 at 23:32 +0100, Adam D. Barratt wrote: Hi, I was just having a quick look at the new web pages (which are very cool :-) and spotted what appears to be an off-by-one or similar issue in the tags report. In case it wasn't obvious and as I forgot to include

Re: Off-by-one in the tags report?

2008-06-18 Thread Adam D. Barratt
On Thu, 2008-06-19 at 00:57 +0200, Frank Lichtenheld wrote: Please include an example URL in future reports, though. I realised my omission as soon as I'd sent the message :-( I did follow up with an example but presumably you were fixing it by that time. :) Adam -- To UNSUBSCRIBE, email to

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Adam D. Barratt
On Sat, 2008-06-14 at 05:20 +0200, Frank Lichtenheld wrote: On Fri, Jun 13, 2008 at 03:09:18PM +0100, Adam D. Barratt wrote: --- checks/scripts.orig 2008-06-13 14:51:32.0 +0100 +++ checks/scripts 2008-06-13 15:00:57.0 +0100 @@ -542,6 +542,11 @@ if ($cat_string

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Adam D. Barratt
On Fri, 2008-06-20 at 18:24 +0100, Adam D. Barratt wrote: As I suspected, the original patch didn't apply cleanly on top of the three earlier patches; I've attached an updated patch against lintian trunk which uses qr. and, predictably, immediately spotted a small typo I'd made when updating

[SCM] Debian package checker branch, master, updated. b75cbcef5c417b9a540ecf259f443eac9b272b58

2008-06-20 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit b75cbcef5c417b9a540ecf259f443eac9b272b58 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 20 20:19:54 2008 +0100 [ADB] Update bashism regexes to add new checks, improve performance and reduce false positives. diff

[SCM] Debian package checker branch, master, updated. 778fd4f6e143b0db00b6c1282b66c4e93db88cfe

2008-06-20 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 778fd4f6e143b0db00b6c1282b66c4e93db88cfe Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 20 20:22:59 2008 +0100 Merge the two checks/scripts stanzas diff --git a/debian/changelog b/debian/changelog index 53bec99

Re: [checks/scripts] [PATCH 4/4] bashisms update

2008-06-20 Thread Adam D. Barratt
On Fri, 2008-06-20 at 21:03 +0200, Frank Lichtenheld wrote: On Fri, Jun 20, 2008 at 06:45:46PM +0100, Adam D. Barratt wrote: On Fri, 2008-06-20 at 18:24 +0100, Adam D. Barratt wrote: As I suspected, the original patch didn't apply cleanly on top of the three earlier patches; I've attached

[SCM] Debian package checker branch, master, updated. bfd01f31b0e8a17c021f5720fb086bb9cd486cec

2008-06-20 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit bfd01f31b0e8a17c021f5720fb086bb9cd486cec Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 20 23:42:28 2008 +0100 Update repository information to point at the new git repository and update the online GPL2 link

[SCM] Debian package checker branch, master, updated. 8ff2a9eb06ac0b60a11e837e8633f186177771ac

2008-06-20 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 8ff2a9eb06ac0b60a11e837e8633f18611ac Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 20 23:51:40 2008 +0100 Ensure that menu-method files use !include menu.h (Closes: #184104) diff --git a/checks/menus b/checks

[SCM] Debian package checker branch, master, updated. 8a8b3a321e13fc12428578211209138a2b5304c3

2008-06-21 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 2af70f12d11bfa3ad6c673a4f8c9d113893d1775 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jun 21 12:41:48 2008 +0100 Fix reference to Menu System manual diff --git a/checks/menus.desc b/checks/menus.desc index 14eaec4

[SCM] Debian package checker branch, master, updated. 8a8b3a321e13fc12428578211209138a2b5304c3

2008-06-21 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 8a8b3a321e13fc12428578211209138a2b5304c3 Merge: 2af70f12d11bfa3ad6c673a4f8c9d113893d1775 be0eff50bb2c24471599bb77b0fc7d3a4883212f Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jun 21 12:42:18 2008 +0100 Merge branch

Bug#484359: Bug#484511: Urgencies should all be lower case

2008-06-21 Thread Adam D. Barratt
On Sat, 2008-06-07 at 22:40 -0700, Russ Allbery wrote: [...] With this patch applied, I think that these bugs are now moot, but I wanted to check before closing them. Is there any further work required in britney to treat urgencies as case-insensitive, or does the change in the log file

[SCM] Debian package checker branch, master, updated. 45af6c4acd2b862b4248675ab42ec4d0dcb35be8

2008-06-24 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 45af6c4acd2b862b4248675ab42ec4d0dcb35be8 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Tue Jun 24 22:41:05 2008 +0100 Check info files are removed and allow install-info --remove-exactly Allow install-info --remove

[SCM] Debian package checker branch, master, updated. fd2167940cf3988dd29bf038bea584acd8e8c8d9

2008-06-24 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit fd2167940cf3988dd29bf038bea584acd8e8c8d9 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Tue Jun 24 22:45:38 2008 +0100 Fix header for checks/menus{,.desc} block diff --git a/debian/changelog b/debian/changelog index 0a580be

Bug#299578: lintian: check that -dbg packages are using separate debugging info

2008-06-24 Thread Adam D. Barratt
Hi, On Mon, 2005-03-14 at 20:08 -0800, Matt Taggart wrote: binutils and gdb now have support for putting debugging info into a separate file. So you build things debugable and you get a separate file with all the debugging info and a normal binary that contains a pointer to this info. This

Re: [SCM] Debian package checker branch, master, updated. 9df55dfd32d5c2155cd0465f6d478ef8efaaaea0

2008-06-26 Thread Adam D. Barratt
On Thu, 2008-06-26 at 18:01 +, Russ Allbery wrote: The following commit has been merged in the master branch: commit d2bda16c93c7b619ee593ae3908ca579b8600c50 Author: Russ Allbery [EMAIL PROTECTED] Date: Thu Jun 26 10:53:48 2008 -0700 Lower info-documents-not-removed to warning

libbaz testset package broken?

2008-06-26 Thread Adam D. Barratt
Hi, Whilst looking at #452216 and #461575 (both related to dpkg symbols files), I tried to build the libbaz testset package; the build fails with: === gcc -o libbaz1.so.1.0.3b -shared baz.o extra.o -lc /usr/bin/ld: baz.o: relocation R_X86_64_32 against `a local symbol' can

Re: libbaz testset package broken?

2008-06-26 Thread Adam D. Barratt
On Thu, 2008-06-26 at 15:20 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: Whilst looking at #452216 and #461575 (both related to dpkg symbols files), I tried to build the libbaz testset package; the build fails with: [...] The Lintian test suite currently can't

Tags for symbols file checks

2008-06-27 Thread Adam D. Barratt
Hi, I've been working on implementing support for syntax checking of symbols files (as generated by dpkg-gensymbols). As part of that development I've introduced a number of new tags, a brief description of which is included below. Any comments / suggestions / objections to the naming, severity,

Re: Tags for symbols file checks

2008-06-27 Thread Adam D. Barratt
On Fri, 2008-06-27 at 09:22 -0700, Russ Allbery wrote: Adam D. Barratt [EMAIL PROTECTED] writes: E: pkg-has-symbols-control-file-but-no-actual-shared-libs Minor nit: dropping -actual will make the tag shorter and I don't think it changes the meaning. E: shlib-missing-in-symbols-control

[SCM] Debian package checker branch, master, updated. 7f71195c6cad53edbc36f98afc68484086f0c298

2008-06-27 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 7f71195c6cad53edbc36f98afc68484086f0c298 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 27 20:32:51 2008 +0100 Enhance symbol checking support + Implement syntax and sanity checking for symbols files

[SCM] Debian package checker branch, master, updated. f84e17b77e6f18a71f9edbfbe6c5eee93f251d8a

2008-06-27 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit f84e17b77e6f18a71f9edbfbe6c5eee93f251d8a Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 27 20:42:53 2008 +0100 Remove reference to moving to alioth and importing CVS history (both now done) diff --git a/private

Bug#461575: tagging 452216, tagging 461575

2008-06-27 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.30 # Fixed in commit 7f71195c6cad53edbc36f98afc68484086f0c298 tags 452216 pending tags 461575 pending -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Re: [SCM] Debian package checker branch, master, updated. f84e17b77e6f18a71f9edbfbe6c5eee93f251d8a

2008-06-27 Thread Adam D. Barratt
On Fri, 2008-06-27 at 19:45 +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit f84e17b77e6f18a71f9edbfbe6c5eee93f251d8a Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jun 27 20:42:53 2008 +0100 Remove reference to moving to alioth

[SCM] Debian package checker branch, master, updated. dca7991eb3d6e570d3b9ca763c856051e4fea401

2008-06-28 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit dca7991eb3d6e570d3b9ca763c856051e4fea401 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jun 28 17:38:18 2008 +0100 Add missing use Dep * checks/changelog-file: + [ADB] Add missing use Dep. Thanks

Bug#488397: tagging 488397

2008-06-28 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.30 # Fixed in commit dca7991eb3d6e570d3b9ca763c856051e4fea401 tags 488397 pending -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#481152: lintian: Promote the use of __Choices in debconf templates files

2008-06-30 Thread Adam D. Barratt
Hi, On Wed, 2008-05-14 at 08:09 +0200, Christian Perrier wrote: I think it would be good for lintian to promote the use of __Choices over _Choices in debconf templates. This feature is present since po-debconf exists so, indeed, no compatibility problems. The feature is well documented in

Bug#481152: lintian: Promote the use of __Choices in debconf templates files

2008-06-30 Thread Adam D. Barratt
On Mon, 2008-06-30 at 23:14 +0100, Adam D. Barratt wrote: One thing I wasn't entirely clear on from a quick look at Tags.pm - are experimental tags intended to be declared as Type: experimental or as a normal tag with an Experimental: yes field? The comments describing %tags appear to suggest

[SCM] Debian package checker branch, master, updated. 924aad805f027f92a0530e1e20478bb4a5120345

2008-07-01 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 924aad805f027f92a0530e1e20478bb4a5120345 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Tue Jul 1 19:12:20 2008 +0100 (Re-)Add support for experimental tags * doc/lintian.sgml + [ADB] Add reference to new

[SCM] Debian package checker branch, master, updated. 3cd9db4d8ec7b0c3d77b76950f31ee775a5ce6ce

2008-07-01 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 3cd9db4d8ec7b0c3d77b76950f31ee775a5ce6ce Author: Adam D. Barratt [EMAIL PROTECTED] Date: Tue Jul 1 19:27:51 2008 +0100 Suggest replacing _Choices in debconf templates files with __Choices * checks/debconf{,.desc

Bug#481152: tagging 481152

2008-07-01 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.30 # Fixed in commit 3cd9db4d8ec7b0c3d77b76950f31ee775a5ce6ce tags 481152 pending -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

[SCM] Debian package checker branch, master, updated. aa5102aebd9abb1c0aedface23e72ec9640f2c1e

2008-07-01 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit aa5102aebd9abb1c0aedface23e72ec9640f2c1e Author: Adam D. Barratt [EMAIL PROTECTED] Date: Tue Jul 1 20:00:32 2008 +0100 Ensure the last package's information is displayed even if there is no extra data associated

Re: [SCM] Debian package checker branch, master, updated. aa5102aebd9abb1c0aedface23e72ec9640f2c1e

2008-07-01 Thread Adam D. Barratt
On Tue, 2008-07-01 at 19:01 +, Adam D. Barratt wrote: The following commit has been merged in the master branch: commit aa5102aebd9abb1c0aedface23e72ec9640f2c1e Author: Adam D. Barratt [EMAIL PROTECTED] Date: Tue Jul 1 20:00:32 2008 +0100 Ensure the last package's information

Re: [SCM] Debian package checker branch, master, updated. 8e894c3c810691e0a4274616d4e251b5471fb758

2008-07-01 Thread Adam D. Barratt
On Wed, 2008-07-02 at 04:33 +, Russ Allbery wrote: The following commit has been merged in the master branch: commit 8e894c3c810691e0a4274616d4e251b5471fb758 Author: Russ Allbery [EMAIL PROTECTED] Date: Tue Jul 1 21:32:47 2008 -0700 Add test suite tag entries for new symbols tests

[SCM] Debian package checker branch, master, updated. f42e60ba5b14a2c690a478fd82728684bc40d626

2008-07-02 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit f42e60ba5b14a2c690a478fd82728684bc40d626 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Wed Jul 2 07:01:42 2008 +0100 Remove completed TODO entry for reintroducing experimental tags diff --git a/private/TODO b/private/TODO

[SCM] Debian package checker branch, master, updated. dbc67c6df98ec988a87a704fef0c00a6afa1817b

2008-07-02 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit dbc67c6df98ec988a87a704fef0c00a6afa1817b Author: Adam D. Barratt [EMAIL PROTECTED] Date: Wed Jul 2 07:08:24 2008 +0100 Don't ignore testset/runtests diff --git a/.gitignore b/.gitignore index 9ca4b75..1d3d3b9 100644

[SCM] Debian package checker branch, master, updated. 99b9e364614d773daee351cc96873508fdc087aa

2008-07-02 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 99b9e364614d773daee351cc96873508fdc087aa Author: Adam D. Barratt [EMAIL PROTECTED] Date: Wed Jul 2 07:09:14 2008 +0100 Add experimental tag support to testset/runtests diff --git a/debian/changelog b/debian/changelog index

[SCM] Debian package checker branch, master, updated. 951769accce10003b174855e6acad6c83d32f2a4

2008-07-02 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 951769accce10003b174855e6acad6c83d32f2a4 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Wed Jul 2 07:17:11 2008 +0100 Update debconf tags file to include the new experimental _Choices tag diff --git a/testset/tags.debconf b

[SCM] Debian package checker branch, master, updated. 7e9168b4cab2acc9b1bf1bc904231bbe7fc601a1

2008-07-02 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 7e9168b4cab2acc9b1bf1bc904231bbe7fc601a1 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Wed Jul 2 19:19:34 2008 +0100 Check copyright files for lines 80 characters * checks/copyright-file{,.desc}: + [ADB

Re: one more tag for watch-file

2008-07-03 Thread Adam D. Barratt
On Thu, 2008-07-03 at 13:09 -0700, Russ Allbery wrote: What's the correct way for a non-native Debian package to indicate that there's no useful upstream and watch file processing should not be done for that package? I'd been assuming that it was adding a watch file that contained only

[SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356

2008-07-03 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit ad09f133a313d2ba70328a6a5127edbea1d4b356 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Thu Jul 3 23:10:23 2008 +0100 Check for embedded copies of Javascript libraries which are already packaged. * checks/files

Bug#489191: tagging 489191

2008-07-03 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.33 # Fixed in commit ad09f133a313d2ba70328a6a5127edbea1d4b356 # # * checks/files{,.desc}: #+ [ADB] Warn if the package contains embedded copies of separately # packaged Javascript libraries. Patch by Chris Lamb. (Closes:

Bug#481787: lintian fails to detect BTS data directory

2008-07-03 Thread Adam D. Barratt
On Fri, 2008-07-04 at 14:53 +1000, Ben Finney wrote: On 04-Jul-2008, Ben Finney wrote: $ lintian -I hello_2.2-2.dsc I: hello source: debian-watch-file-is-missing W: hello source: debian-rules-ignores-make-clean-error line 31 W: hello source: ancient-standards-version 3.7.2 (current is

Bug#481787: lintian fails to detect BTS data directory

2008-07-04 Thread Adam D. Barratt
Ben Finney wrote, Friday, July 04, 2008: On 04-Jul-2008, Adam D. Barratt wrote: Did you intend the check to be performed against binary packages, source packages, or both? Primarily source packages, but both would also be good. In which case, as Russ mentioned, lintian has the capability

[SCM] Debian package checker branch, master, updated. c4b87525b17351ee215a0df5f731d7d1f5a1e388

2008-07-04 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit c4b87525b17351ee215a0df5f731d7d1f5a1e388 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jul 4 21:06:35 2008 +0100 Add then to the list of expressions which can precede a bashism diff --git a/checks/scripts b/checks

[SCM] Debian package checker branch, master, updated. 083946ba13e52aa74e7b4a43de503228a6648dab

2008-07-04 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 083946ba13e52aa74e7b4a43de503228a6648dab Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jul 4 21:40:05 2008 +0100 Add {diff,source}-contains-bts-control-dir * checks/cruft{,.desc}: + [ADB] Check

[SCM] Debian package checker branch, master, updated. be997b71bb1c30353d0e62694cc6f8e2cb5015de

2008-07-04 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit be997b71bb1c30353d0e62694cc6f8e2cb5015de Author: Adam D. Barratt [EMAIL PROTECTED] Date: Fri Jul 4 21:46:11 2008 +0100 Fix test-has-inconsistent-type for experimental tags diff --git a/testset/runtests b/testset/runtests

Bug#481787: tagging 481787

2008-07-04 Thread Adam D . Barratt
# Automatically generated email from bts, devscripts version 2.10.33 # Fixed in commit 083946ba13e52aa74e7b4a43de503228a6648dab # #* checks/cruft{,.desc}: # + [ADB] Check for BTS control directories in source packages and diffs #in addition to the existing binary package checks.

[SCM] Debian package checker branch, master, updated. a8d2233cbc940d0311a68aaf9d49ae0976003906

2008-07-05 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit a8d2233cbc940d0311a68aaf9d49ae0976003906 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jul 5 14:39:39 2008 +0100 Fix template-uses-unsplit-choices for single binary packages Add debfiles/templates to the list

[SCM] Debian package checker branch, master, updated. a01056f32e0ad99e9717e8f6dd20a8994b3a5327

2008-07-05 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit a01056f32e0ad99e9717e8f6dd20a8994b3a5327 Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jul 5 14:44:16 2008 +0100 Add a missing period to the description of template-uses-unsplit-choices diff --git a/checks/debconf.desc

[SCM] Debian package checker branch, master, updated. 59c84b7c6cdbf90588c2c1ca9c9aa73363444b1f

2008-07-05 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 59c84b7c6cdbf90588c2c1ca9c9aa73363444b1f Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jul 5 14:56:58 2008 +0100 Fix an off-by-one in the single binary source detection Also simplify building of the list

Re: Ideas wrt debconf templates checks

2008-07-05 Thread Adam D. Barratt
Hi, On Thu, 2008-07-03 at 07:03 +0200, Christian Perrier wrote: 1) Checking if a declared template is still used Sometimes, maintainers rewrite maintainer scripts and remove the use a a given debconf template but do not think about dropping it from debian/*templates. It therefore clutters

Re: Ideas wrt debconf templates checks

2008-07-05 Thread Adam D. Barratt
On Sat, 2008-07-05 at 16:05 +0100, Adam D. Barratt wrote: Hi, On Thu, 2008-07-03 at 07:03 +0200, Christian Perrier wrote: 1) Checking if a declared template is still used [...] As far as I can see, such a test does not currently exist. It would be fairly simple to add, assuming

Re: Ideas wrt debconf templates checks

2008-07-05 Thread Adam D. Barratt
On Sat, 2008-07-05 at 17:02 +0100, Adam D. Barratt wrote: On Sat, 2008-07-05 at 16:05 +0100, Adam D. Barratt wrote: Hi, On Thu, 2008-07-03 at 07:03 +0200, Christian Perrier wrote: 1) Checking if a declared template is still used [...] As far as I can see, such a test does

[SCM] Debian package checker branch, master, updated. 3cd1fed4e5c0f8e112975934c8b429bf727b537e

2008-07-05 Thread Adam D. Barratt
The following commit has been merged in the master branch: commit 3cd1fed4e5c0f8e112975934c8b429bf727b537e Author: Adam D. Barratt [EMAIL PROTECTED] Date: Sat Jul 5 20:19:14 2008 +0100 Fix maintainer script names in info-documents-not-removed diff --git a/checks/infofiles.desc b/checks

Re: Ideas wrt debconf templates checks

2008-07-05 Thread Adam D. Barratt
On Sat, 2008-07-05 at 15:07 -0400, Joey Hess wrote: Adam D. Barratt wrote: As far as I can see, such a test does not currently exist. It would be fairly simple to add, assuming that the following methodology would make sense (on a per-binary package basis): for each of config, preinst

  1   2   3   4   5   6   7   8   9   >