Bug#659083: RFS: xmoto -- 2D motocross platform game
Hi Mike, On Mon, 7 May 2012 01:01:37 +0200, Stephen Kitt st...@sk2.org wrote: On Sun, May 06, 2012 at 06:04:17PM -0400, Michael Gilbert wrote: I just reviewed this package. It looks good except for a couple issues: Thanks for taking a look at this. 1. bin/credits.rpl seems to be a binary file in the repacked upstream source (there may be others, but I stopped at that one) Apart from the various .ogg files and the .ttf files for DejaVu, that's the only binary left. It's a replay of a level in the game, so there is no appropriate form for modification - it was recorded using the game and is not generated... 2. I'm not sure that it's good practice to apply the patch directly within the upstream orig file. It would be better to do that via quilt. You probably did that to make sure that the orig would be buildable by itself, but that isn't necessary. That is indeed why I did it. I'll fix it once I get wine-gecko done! I've uploaded a fixed package to http://mentors.debian.net/package/xmoto and pushed the changes to the svn repository: * I've repacked the tarball, the only change now is the removal of glext.h; I left the added files in the bin folder out since they can be reconstructed byte-for-byte using xmoto --unpack (and I've added a README.source explaining this); * the patch required to build as a result of removing glext.h is now applied as a Debian patch; * I added DMUA as you suggested. Regards, Stephen signature.asc Description: PGP signature
Bug#659083: RFS: xmoto -- 2D motocross platform game
Hi, I just reviewed this package. It looks good except for a couple issues: 1. bin/credits.rpl seems to be a binary file in the repacked upstream source (there may be others, but I stopped at that one) 2. I'm not sure that it's good practice to apply the patch directly within the upstream orig file. It would be better to do that via quilt. You probably did that to make sure that the orig would be buildable by itself, but that isn't necessary. Best wishes, Mike -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CANTw=mmyhcbaghby4rvrvo8mxqdcqbmjahnscto6x-_sh6t...@mail.gmail.com
Bug#659083: RFS: xmoto -- 2D motocross platform game
Hi Mike, On Sun, May 06, 2012 at 06:04:17PM -0400, Michael Gilbert wrote: I just reviewed this package. It looks good except for a couple issues: Thanks for taking a look at this. 1. bin/credits.rpl seems to be a binary file in the repacked upstream source (there may be others, but I stopped at that one) Apart from the various .ogg files and the .ttf files for DejaVu, that's the only binary left. It's a replay of a level in the game, so there is no appropriate form for modification - it was recorded using the game and is not generated... 2. I'm not sure that it's good practice to apply the patch directly within the upstream orig file. It would be better to do that via quilt. You probably did that to make sure that the orig would be buildable by itself, but that isn't necessary. That is indeed why I did it. I'll fix it once I get wine-gecko done! Regards, Stephen -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120506230136.gc11...@sk2.org
Bug#659083: RFS: xmoto -- 2D motocross platform game
tag 659083 - moreinfo
thanks
Hi Ansgar,
It's been ages, but I've finally finished getting everything ready.
On Sun, 26 Feb 2012 15:52:56 +0100, Ansgar Burchardt ans...@debian.org
wrote:
Stephen Kitt st...@sk2.org writes:
dget -x
http://mentors.debian.net/debian/pool/main/x/xmoto/xmoto_0.5.9-1.dsc
You do not include the full license text for src/glext.h in the
copyright information.
I should have noticed that... It was actually not DFSG-free, but it's easy
enough to patch out so I've repacked the upstream tarball without it (and
with the small, necessary patch; I added a README.dfsg file to explain
everything). I filed a bug upstream too.
Have the patches been forwarded upstream?
They have now, see the updated patch headers for details.
You use debhelper compat level 9, so why don't you build-depend on
debhelper (= 9)?
When I initially switched to compat level 9, debhelper 9 wasn't available
yet. I changed the build-dependency to (= 9).
Please update at least config.{guess,sub}, see [1] for details, or just
use dh-autoreconf (my personal preference).
I like dh-autoreconf too, that's what I went for.
The source for bin/xmoto.bin seems to be missing, compare with
upstream's SVN repository[2]. I have filed a bug[3] as it is also
the case for the version currently inthe archive. Please ask upstream
to include the source and ideally built xmoto.bin instead of including
it, see also [4] for more details.
Indeed; I took the opportunity of repacking the upstream tarball to add the
missing files and remove xmoto.bin. (The resulting build still produces an
identical xmoto.bin.) I also forwarded your bug upstream.
All this (and more) is available in the subversion repository and at
http://mentors.debian.net/debian/pool/main/x/xmoto/xmoto_0.5.9+dfsg-1.dsc
The changelog is as follows:
xmoto (0.5.9+dfsg-1) unstable; urgency=low
* New upstream release (closes: #644234):
+ builds with libpng 1.5 (closes: #649797);
+ uses libxml2;
+ uses DejaVuSansMono (add link and make ttf-dejavu-core a dependency
of xmoto-data).
* Repacked to avoid licensing problems:
+ remove src/glext.h, licensed under SGI License B version 1.1;
+ add the missing contents in bin (closes: #661340).
(I'm hoping that both issues will be fixed upstream, so I haven't
added a get-orig-source target to debian/rules. README.dfsg in the
repacked source explains the changes.)
* Update debian/watch accordingly.
* Update patches:
+ fix_segfault.patch: refresh, add DEP-3 header, forward upstream;
+ desktop.patch: re-apply, add German translation (closes: #641822),
forward upstream;
+ spelling.patch: refresh, forward upstream;
+ manpage.patch: forward upstream;
+ gcc44-ftbfs.patch: no longer used, delete.
* Switch to dh 9 with simple rules.
* Use source format 3.0 (quilt).
* Add ${misc:Depends} where appropriate.
* Patch the manpage to fix hyphens and a few spelling mistakes.
* Add myself to uploaders.
* Update debian/copyright.
* Standards-Version 3.9.3 (no further change required).
* Fix spelling mistakes spotted by Lintian.
* Use dh-autoreconf to update config.{guess,sub} (thanks to Ansgar
Burchardt for the hint).
* wrap-and-sort control files.
* Build-depend on libpng-dev only, dropping the libpng12-dev alternative
(closes: #662565).
* Fix ftbfs with GCC-4.7 by including unistd.h where appropriate
(closes: #667422; thanks to Cyril Brulebois for his patch for another
gcc-4.7-related issue, which was already included upstream).
* Fix the Vcs-Browser URL.
-- Stephen Kitt st...@sk2.org Mon, 23 Apr 2012 00:19:42 +0200
Regards,
Stephen
signature.asc
Description: PGP signature
Processed: Re: Bug#659083: RFS: xmoto -- 2D motocross platform game
Processing commands for cont...@bugs.debian.org: tag 659083 - moreinfo Bug #659083 [sponsorship-requests] RFS: xmoto -- 2D motocross platform game Removed tag(s) moreinfo. thanks Stopping processing here. Please contact me if you need assistance. -- 659083: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659083 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.133513529820587.transcr...@bugs.debian.org
Bug#659083: RFS: xmoto -- 2D motocross platform game
Hi Ansgar,
On Sun, 26 Feb 2012 15:52:56 +0100, Ansgar Burchardt ans...@debian.org
wrote:
You do not include the full license text for src/glext.h in the
copyright information.
Have the patches been forwarded upstream?
You use debhelper compat level 9, so why don't you build-depend on
debhelper (= 9)?
Please update at least config.{guess,sub}, see [1] for details, or just
use dh-autoreconf (my personal preference).
The source for bin/xmoto.bin seems to be missing, compare with
upstream's SVN repository[2]. I have filed a bug[3] as it is also
the case for the version currently inthe archive. Please ask upstream
to include the source and ideally built xmoto.bin instead of including
it, see also [4] for more details.
Thanks for the review, I'll update the package as appropriate once I have a
little more time (in a couple of weeks).
Regards,
Stephen
signature.asc
Description: PGP signature
Bug#659083: RFS: xmoto -- 2D motocross platform game
tag 659083 + moreinfo
thanks
Hi,
Stephen Kitt st...@sk2.org writes:
dget -x http://mentors.debian.net/debian/pool/main/x/xmoto/xmoto_0.5.9-1.dsc
You do not include the full license text for src/glext.h in the
copyright information.
Have the patches been forwarded upstream?
You use debhelper compat level 9, so why don't you build-depend on
debhelper (= 9)?
Please update at least config.{guess,sub}, see [1] for details, or just
use dh-autoreconf (my personal preference).
The source for bin/xmoto.bin seems to be missing, compare with
upstream's SVN repository[2]. I have filed a bug[3] as it is also
the case for the version currently inthe archive. Please ask upstream
to include the source and ideally built xmoto.bin instead of including
it, see also [4] for more details.
Regards,
Ansgar
[1] file:///usr/share/doc/autotools-dev/README.Debian.gz
[2] http://svn.tuxfamily.org/viewvc.cgi/xmoto_xmoto/trunk/bin/
[3] http://bugs.debian.org/661340
[4] http://www.freedesktop.org/wiki/Games/Upstream#Source
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87ty2dprxz@deep-thought.43-1.org
Processed: Re: Bug#659083: RFS: xmoto -- 2D motocross platform game
Processing commands for cont...@bugs.debian.org: tag 659083 + moreinfo Bug #659083 [sponsorship-requests] RFS: xmoto -- 2D motocross platform game Added tag(s) moreinfo. thanks Stopping processing here. Please contact me if you need assistance. -- 659083: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659083 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.133026799224520.transcr...@bugs.debian.org
