Bug#889968: RFS: inotify-tools/3.14-4 -- summary of situation

[Sean Whitton]

Hello Dmitry, Gianfranco,

I did some research and testing into this bug...

On Sat, Apr 14 2018, kact...@gnu.org wrote:

> Hello. I am a bit lost about state of this RFS, but it seems I did
> stupid thing with format=1.0; complicating sponsoring.
>
> Let me settle things, provide sane package with format=3.0 (quilt), with
> pristine tar. I will ping once I am ready. Sorry for noise.

That is not the problem.  The orig.tar is already in the archive so
no-one should need pristine-tar.  I can obtain something that works like
this:

% git clone salsa.debian.org:iu-guest/inotify-tools
% cd inotify-tools
% origtargz
% sbuild# or similar

Gianfranco, please try that :)

Now as to the FTBFS I was seeing, I investigated further.
dh_auto_configure works fine, but dpkg-buildpackage does not:

configure:3383: ./conftest
==28639==ASan runtime does not come first in initial library list; you 
should either link runtime to your application or manually preload it with 
LD_PRELOAD.
configure:3387: $? = 1

I found a bug report[1] which says that this error is bogus when
triggered by cowbuilder or fakeroot.  dpkg-buildpackage doesn't use
fakeroot when it invokes dh_auto_configure, though ...

I would suggest just disabling address sanitising for now.  My sbuild
setup is v. similar to the buildds, so I suspect we are going to see an
FTBFS if this is left turned on.

[1]  https://github.com/google/sanitizers/issues/786

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello,

On Sat, Apr 14 2018, kact...@gnu.org wrote:

> Hello. I am a bit lost about state of this RFS, but it seems I did
> stupid thing with format=1.0; complicating sponsoring.
>
> Let me settle things, provide sane package with format=3.0 (quilt),
> with pristine tar. I will ping once I am ready. Sorry for noise.

The source package format is not the issue, afaict.  pristine-tar can
work with source format 1.0

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[KAction]

control: tag -1 moreinfo

[2018-04-13 16:37] Gianfranco Costamagna 
> Hello,
> 
> >The next thing you might try is `git deborig`.  But I understand just
> >asking Dmitry!

Hello. I am a bit lost about state of this RFS, but it seems I did
stupid thing with format=1.0; complicating sponsoring.

Let me settle things, provide sane package with format=3.0 (quilt), with
pristine tar. I will ping once I am ready. Sorry for noise.

Bug#889968: RFS: inotify-tools/3.14-4

[Gianfranco Costamagna]

Hello,

>The next thing you might try is `git deborig`.  But I understand just
>asking Dmitry!


git deborig -f upstream/3.14

same effect, as well
as 
git deborig -f v3.14...

G.

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello,

On Fri, Apr 13 2018, Gianfranco Costamagna wrote:

>>Please try typing `origtargz`.
>
>
> it downloads the current one in the archive, without the patches, and
> then it fails with:

Ah, sorry, I thought it would invoke uscan.

The next thing you might try is `git deborig`.  But I understand just
asking Dmitry!

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Gianfranco Costamagna]

Hello,


>Please try typing `origtargz`.


it downloads the current one in the archive, without the patches, and then it 
fails with:


dpkg-source: warning: the diff modifies the following upstream files: 
.git/HEAD
.git/config
.git/description
.git/hooks/applypatch-msg.sample
.git/hooks/commit-msg.sample
.git/hooks/post-update.sample
.git/hooks/pre-applypatch.sample
.git/hooks/pre-commit.sample
.git/hooks/pre-push.sample
.git/hooks/pre-rebase.sample
.git/hooks/pre-receive.sample
.git/hooks/prepare-commit-msg.sample
.git/hooks/update.sample
.git/info/exclude
.git/logs/HEAD
.git/logs/refs/heads/master
.git/logs/refs/remotes/origin/HEAD
.git/packed-refs
.git/refs/heads/master
.git/refs/remotes/origin/HEAD
libinotifytools/src/test.c
man/inotifywait.1
man/inotifywatch.1
src/common.c
src/inotifywait.c
dpkg-source: info: use the '3.0 (quilt)' format to have separate and documented 
changes to upstream files, see dpkg-source(1)


Dmitry, can you please upload the tarball somewhere?

I notice there is a 3.20.1 out there

G.

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello,

On Thu, Apr 12 2018, Gianfranco Costamagna wrote:

> I'm worried about the disappear of "debian-changes" patch, is it
> somewhere else? should I get a new orig tarball?  I don't want my
> upload to make something disappear from the patch queue, due to my
> lack of dgit procedures.

It's because the patch was merged upstream.

> Please tell me the commands to get the source in the right way(TM) and
> then I'll look/sponsor if the patch has to disappear for some ways.
> other things LGTM, the package builds in my pbuilder, and probably in
> ppas too.

Please try typing `origtargz`.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

Hello Dmitry
sorry for taking too long for this one.
I did:
grab inotify-tools from experimental
grab the debian directory from the git repo, and debdiffed the results.
I'm worried about the disappear of "debian-changes" patch, is it somewhere 
else? should I get a new orig tarball?
I don't want my upload to make something disappear from the patch queue, due to 
my lack of dgit procedures.

Please tell me the commands to get the source in the right way(TM)
and then I'll look/sponsor if the patch has to disappear for some ways.
other things LGTM, the package builds in my pbuilder, and probably in ppas too.

Not sure why Sean has issues, I can't really reproduce them!

Gianfranco

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello,

On Wed, Feb 14 2018, Sean Whitton wrote:

> If you do this, please upload using `dgit push-source` since Dmitry is
> using a dgit-based workflow.
>
> (you can just run `dgit push-source` and it should do everything for
> you)

Oh, plus --overwrite since the last upload to unstable was not made with
dgit.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello Gianfranco,

On Wed, Feb 14 2018, kact...@gnu.org wrote:

> Hello! Gianfranco, could you please consider building and, probably,
> sponsoring this package? We have issue, that it FTBFS on Sean's setup,
> but builds on mine and on debomatic. As debomatic admin notified,
> debomatic is not out-of-date {updated this sunday}.
>
>   https://salsa.debian.org/iu-guest/inotify-tools

If you do this, please upload using `dgit push-source` since Dmitry is
using a dgit-based workflow.

(you can just run `dgit push-source` and it should do everything for
you)

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[KAction]

> > [2018-02-12 13:07] Sean Whitton 
> >> > Last version is at bacef877c2f9293f9e1fd624b32d5306d7bc3c27 Maybe,
> >> > you could try again?
> >>
> >> Still FTBFSs.  Log attached.
> >>
> >> I suspect that the debomatic sid chroot is out-of-date.
> >
> > Stange. Just did 'sbuild-update -udcar', and still fails to reproduce.
> > I have same version of build-essential, by the way.
> >
> > Added debomatic admin into CC, maybe he has any opinion about
> > situation.  If not, I could remove sanitize support, although I am not
> > so happy with it. Or maybe you could tar.gz your chroot and upload
> > somewhere?
> 
> I tried deleting and rebuilding my chroot and disabling ccache and
> tmpfs, and I tried building on my i386 machine, again after rebuilding,
> disabling ccache and disabling tmpfs.
> 
> In all cases the package FTBFS.  I attach my i386 log..
> 
> I'm not sure how to proceed.  I can't upload this if I can't build it,
> and my configuration seems sufficiently standard that even if you are
> able to build it, we shouldn't upload.  Maybe we should try disabling
> sanitize support for now.

I understand your concerns, Sean. I invited Gianfranco into thread,
maybe he would sponspor instead.  Ah, another absurd idea. What about
your building package on debomatic? Maybe for some reason your source
package, generated from git repository, differs from mine? Also, could
you please try to run binaries, built by debomatic? Do they crash?

Hello! Gianfranco, could you please consider building and, probably,
sponsoring this package? We have issue, that it FTBFS on Sean's setup,
but builds on mine and on debomatic. As debomatic admin notified,
debomatic is not out-of-date {updated this sunday}.

https://salsa.debian.org/iu-guest/inotify-tools

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello,

On Tue, Feb 13 2018, Luca Falavigna wrote:

> 2018-02-13 4:18 GMT+01:00 :
>>> I suspect that the debomatic sid chroot is out-of-date.
>
> amd64 chroot was updated on Sunday, February 11, 2018 4:20:10 PM UTC
> (1518366010.2514317).

Thanks for the feedback!

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

Hello Dmitry,

On Tue, Feb 13 2018, kact...@gnu.org wrote:

> [2018-02-12 13:07] Sean Whitton 
>> > Last version is at bacef877c2f9293f9e1fd624b32d5306d7bc3c27 Maybe,
>> > you could try again?
>>
>> Still FTBFSs.  Log attached.
>>
>> I suspect that the debomatic sid chroot is out-of-date.
>
> Stange. Just did 'sbuild-update -udcar', and still fails to reproduce.
> I have same version of build-essential, by the way.
>
> Added debomatic admin into CC, maybe he has any opinion about
> situation.  If not, I could remove sanitize support, although I am not
> so happy with it. Or maybe you could tar.gz your chroot and upload
> somewhere?

I tried deleting and rebuilding my chroot and disabling ccache and
tmpfs, and I tried building on my i386 machine, again after rebuilding,
disabling ccache and disabling tmpfs.

In all cases the package FTBFS.  I attach my i386 log..

I'm not sure how to proceed.  I can't upload this if I can't build it,
and my configuration seems sufficiently standard that even if you are
able to build it, we shouldn't upload.  Maybe we should try disabling
sanitize support for now.

-- 
Sean Whitton


inotify-tools_3.14-4_i386-2018-02-13T19:12:26Z.build
Description: Binary data


signature.asc
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Luca Falavigna]

2018-02-13 4:18 GMT+01:00  :
>> I suspect that the debomatic sid chroot is out-of-date.

amd64 chroot was updated on Sunday, February 11, 2018 4:20:10 PM UTC
(1518366010.2514317).

-- 
Cheers,
Luca

Bug#889968: RFS: inotify-tools/3.14-4

[KAction]

[2018-02-12 13:07] Sean Whitton 
> > Last version is at bacef877c2f9293f9e1fd624b32d5306d7bc3c27 Maybe, you
> > could try again?
> 
> Still FTBFSs.  Log attached.
> 
> I suspect that the debomatic sid chroot is out-of-date.

Stange. Just did 'sbuild-update -udcar', and still fails to reproduce.
I have same version of build-essential, by the way.

Added debomatic admin into CC, maybe he has any opinion about situation.
If not, I could remove sanitize support, although I am not so happy with
it. Or maybe you could tar.gz your chroot and upload somewhere?

Bug#889968: RFS: inotify-tools/3.14-4

[KAction]

[2018-02-10 12:13] Sean Whitton 
> - It FTBFSs for me.  Log attached.

Look, debomatic build is succesful:

  
http://debomatic-amd64.debian.net/distribution#unstable/inotify-tools/3.14-4/buildlog

Last version is at bacef877c2f9293f9e1fd624b32d5306d7bc3c27
Maybe, you could try again?

Bug#889968: RFS: inotify-tools/3.14-4

[KAction]

[2018-02-10 12:13] Sean Whitton 
> Review of 3c46a878fd294e9af9f8e7c225d16e8aceb960cf:
> 
> - It looks like you added an entry to the changelog for 3.13-3 that
>   should have been in the changelog for 3.13-4.

Good catch. Will fix it.
 
> - I'm not sure that DPKG_EXPORT_BUILDFLAGS = 1 will have any effect
>   unless you export it?  Not sure; I have not used this feature.

This variable is checked not by external programs, but by make code in
/usr/share/dpkg/[...]. It is okay.

> - It FTBFSs for me.  Log attached.

Oh, I see, fails on ./configure. Unfortunately, I can't reproduce on my
own laptop. Maybe it is because it is i386. I am working on getting it
built on debomatic-amd64. 

I will ping you again, when I get results from debomatic.


pgpF6NB9Nt0mB.pgp
Description: PGP signature

Bug#889968: RFS: inotify-tools/3.14-4

[Sean Whitton]

control: tag -1 +moreinfo
control: owner -1 !

Hello Dmitry,

Review of 3c46a878fd294e9af9f8e7c225d16e8aceb960cf:

- It looks like you added an entry to the changelog for 3.13-3 that
  should have been in the changelog for 3.13-4.

- I'm not sure that DPKG_EXPORT_BUILDFLAGS = 1 will have any effect
  unless you export it?  Not sure; I have not used this feature.

- It FTBFSs for me.  Log attached.

-- 
Sean Whitton
sbuild (Debian sbuild) 0.73.0 (23 Dec 2016) on iris.silentflame.com

+==+
| inotify-tools 3.14-4 (amd64) Sat, 10 Feb 2018 19:10:16 + |
+==+

Package: inotify-tools
Version: 3.14-4
Source Version: 3.14-4
Distribution: unstable
Machine Architecture: amd64
Host Architecture: amd64
Build Architecture: amd64
Build Type: binary

I: NOTICE: Log filtering will replace 
'var/run/schroot/mount/unstable-amd64-sbuild-ea2ba2cd-ce02-480e-b119-6bc5bbd3eb48'
 with '<>'

+--+
| Update chroot|
+--+

Get:1 http://deb.debian.org/debian unstable InRelease [241 kB]
Get:2 http://deb.debian.org/debian unstable/contrib Sources.diff/Index [27.8 kB]
Get:3 http://deb.debian.org/debian unstable/main Sources.diff/Index [27.9 kB]
Get:4 http://deb.debian.org/debian unstable/non-free Sources.diff/Index [27.8 
kB]
Get:5 http://deb.debian.org/debian unstable/non-free amd64 Packages.diff/Index 
[27.8 kB]
Get:6 http://deb.debian.org/debian unstable/contrib amd64 Packages.diff/Index 
[27.8 kB]
Get:7 http://deb.debian.org/debian unstable/main amd64 Packages.diff/Index 
[27.9 kB]
Get:8 http://deb.debian.org/debian unstable/contrib Sources 
2018-02-08-0244.34.pdiff [725 B]
Get:9 http://deb.debian.org/debian unstable/contrib Sources 
2018-02-08-0919.59.pdiff [450 B]
Get:10 http://deb.debian.org/debian unstable/main Sources 
2018-02-06-2026.31.pdiff [12.6 kB]
Get:11 http://deb.debian.org/debian unstable/main Sources 
2018-02-07-0231.38.pdiff [12.0 kB]
Get:12 http://deb.debian.org/debian unstable/main Sources 
2018-02-07-0824.55.pdiff [2263 B]
Get:13 http://deb.debian.org/debian unstable/main Sources 
2018-02-07-1427.34.pdiff [9180 B]
Get:14 http://deb.debian.org/debian unstable/main Sources 
2018-02-07-2028.51.pdiff [13.8 kB]
Get:15 http://deb.debian.org/debian unstable/main Sources 
2018-02-08-0244.34.pdiff [9073 B]
Get:16 http://deb.debian.org/debian unstable/main Sources 
2018-02-08-0919.59.pdiff [2808 B]
Get:17 http://deb.debian.org/debian unstable/main Sources 
2018-02-08-1427.47.pdiff [23.5 kB]
Get:18 http://deb.debian.org/debian unstable/main Sources 
2018-02-08-2039.02.pdiff [15.9 kB]
Get:19 http://deb.debian.org/debian unstable/main Sources 
2018-02-09-0244.28.pdiff [9256 B]
Get:20 http://deb.debian.org/debian unstable/main Sources 
2018-02-09-1007.33.pdiff [7287 B]
Get:21 http://deb.debian.org/debian unstable/main Sources 
2018-02-09-1423.20.pdiff [28.7 kB]
Get:22 http://deb.debian.org/debian unstable/main Sources 
2018-02-09-2039.28.pdiff [21.4 kB]
Get:23 http://deb.debian.org/debian unstable/main Sources 
2018-02-10-0230.03.pdiff [9215 B]
Get:24 http://deb.debian.org/debian unstable/main Sources 
2018-02-10-0831.26.pdiff [7817 B]
Get:25 http://deb.debian.org/debian unstable/main Sources 
2018-02-10-1428.30.pdiff [43.7 kB]
Get:9 http://deb.debian.org/debian unstable/contrib Sources 
2018-02-08-0919.59.pdiff [450 B]
Get:26 http://deb.debian.org/debian unstable/non-free Sources 
2018-02-08-0244.34.pdiff [678 B]
Get:27 http://deb.debian.org/debian unstable/non-free Sources 
2018-02-08-1427.47.pdiff [243 B]
Get:28 http://deb.debian.org/debian unstable/non-free Sources 
2018-02-09-0244.28.pdiff [604 B]
Get:29 http://deb.debian.org/debian unstable/non-free Sources 
2018-02-10-0230.03.pdiff [634 B]
Get:30 http://deb.debian.org/debian unstable/non-free Sources 
2018-02-10-0831.26.pdiff [387 B]
Get:31 http://deb.debian.org/debian unstable/non-free amd64 Packages 
2018-02-08-1427.47.pdiff [227 B]
Get:32 http://deb.debian.org/debian unstable/non-free amd64 Packages 
2018-02-10-0831.26.pdiff [353 B]
Get:33 http://deb.debian.org/debian unstable/contrib amd64 Packages 
2018-02-07-1427.34.pdiff [377 B]
Get:34 http://deb.debian.org/debian unstable/contrib amd64 Packages 
2018-02-08-0244.34.pdiff [423 B]
Get:25 http://deb.debian.org/debian unstable/main Sources 
2018-02-10-1428.30.pdiff [43.7 kB]
Get:35 http://deb.debian.org/debian unstable/contrib amd64 Packages 
2018-02-08-0919.59.pdiff [305 B]
Get:36 http://deb.debian.org/debian unstable/contrib amd64 Packages 
2018-02-09-1423.20.pdiff [31 B]
Get:37 http://deb.debian.org/debian unstable/main amd64 Packages 
2018-02-06-2026.31.pdiff [22.4 kB]
Get:38 http://deb.debian.org/debian unstable/main amd64 Packages 

Bug#889968: RFS: inotify-tools/3.14-4

[Dmitry Bogatov]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "inotify-tools"

* Package name : inotify-tools
  Version  : 3.14-4
  Upstream Author  : Radu Voicilas 
* Url  : https://github.com/rvoicilas/inotify-tools/wiki/
* Licenses : GPL-2.1+,LGPL-2.1+
  Programming Lang : C
  Section  : misc

 Inotify is a Linux kernel feature enabling user space programs to
 monitor parts of the filesystem in a efficient way. libinotifytools
 is a thin layer on top of the kernel interface which makes it easy
 to set up watches on many files at once, read events without having
 to deal with low-level I/O, and several utility functions for inotify-
 related string formatting

It builds those binary packages:

  * libinotifytools0
  * libinotifytools0-dev
  * inotify-tools

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/inotify-tools

Alternatively, one can download the package with dget using this command:
dget -x 
https://mentors.debian.net/debian/pool/main/i/inotify-tools/inotify-tools_3.14-4.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://salsa.debian.org/iu-guest/inotify-tools.git

More information about inotify-tools can be obtained from
https://github.com/rvoicilas/inotify-tools/wiki/


Changes since last upload:

  * Upload to unstable
  * Enable all paranoid options of dpkg-buildflags(1)
  * Mark packages as multiarch-compatible (Closes: #875462)
  * Update Vcs-* fields in debian/control.
  * Update standards version to 4.1.3 (no changes needed)
  * Drop explicit dependency on autotools (implied by debhelper-10)
  * Use secure URL when referencing to copyright-format
  * Remove lintian-override about embedded javascript library.
Lintian now knows, that there is nothing can be done in case of
Doxygen.
  * Add sanity-check symbols into symbols file.

Regards,
  Dmitry Bogatov