Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Niels Thykier
Sean Whitton: > [...] Hi, Thanks for the updated version. :) My second also applies to the re-worded variant quoted below > Here is the complete new diff for seconding. Below that, I've included > the interdiff between the patch Niels seconded and the new one. > >> diff --git

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Paul Gevers
Seconded. On 15-06-18 19:02, Sean Whitton wrote: > On Fri, Jun 15 2018, Simon McVittie wrote: > >> This all seems valid to me, but it's relatively subtle. Perhaps you could >> clarify this sentence by saying "The gain root command must (blah blah) >> because it will not necessarily be used by a

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Simon McVittie
On Fri, 15 Jun 2018 at 18:02:39 +0100, Sean Whitton wrote: > Here is the complete new diff for seconding Seconded (as below). smcv > > diff --git a/debian/changelog b/debian/changelog > > index 2dea331..b89816e 100644 > > --- a/debian/changelog > > +++ b/debian/changelog > > @@ -1,5 +1,11 @@

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Sean Whitton
[CCing Niels whose second has become invalid -- see interdiff at bottom of mail] Hello, On Fri, Jun 15 2018, Simon McVittie wrote: > This all seems valid to me, but it's relatively subtle. Perhaps you could > clarify this sentence by saying "The gain root command must (blah blah) > because it

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Bill Allombert
On Fri, Jun 15, 2018 at 03:35:09PM +0100, Simon McVittie wrote: > On Fri, 15 Jun 2018 at 13:43:36 +0100, Sean Whitton wrote: > > On Thu, Jun 14 2018, Paul Gevers wrote: > > >> +This command > > >> +allows the ``debian/rules`` target to run particular subcommands under > > > > > >^^ lintian

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Simon McVittie
On Fri, 15 Jun 2018 at 13:43:36 +0100, Sean Whitton wrote: > On Thu, Jun 14 2018, Paul Gevers wrote: > >> +This command > >> +allows the ``debian/rules`` target to run particular subcommands under > > > >^^ lintian will tell you this should be "enables" > > As a native speaker I find

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Paul Gevers
Hi Sean, On 15-06-18 14:43, Sean Whitton wrote: > On Thu, Jun 14 2018, Paul Gevers wrote: > >>> + - A space separated list of keywords described below. These must insert "keywords" here? ^ >>> + always contain a forward slash, which sets them apart

Bug#880920: Document Rules-Requires-Root field

2018-06-15 Thread Sean Whitton
Hello Paul, On Thu, Jun 14 2018, Paul Gevers wrote: >> + - A space separated list of keywords described below. These must >> + always contain a forward slash, which sets them apart from the >> + other values. When this list is provided, the builder must provide > > ^^

Bug#880920: Document Rules-Requires-Root field

2018-06-14 Thread Paul Gevers
I want to second this text, but have some questions. > diff --git a/policy/ch-controlfields.rst b/policy/ch-controlfields.rst > index 0771346..3519d99 100644 > --- a/policy/ch-controlfields.rst > +++ b/policy/ch-controlfields.rst > @@ -1020,6 +1022,118 @@ This field is automatically added to

Bug#880920: Minor typo Re: Bug#880920: Document Rules-Requires-Root field

2018-05-19 Thread Jens Reyer
Hi, just a minor typo I guess, absolutely no review, sorry: "If the package builder supports the Rules-Requires-Root field and want to enable the feature" s/want/wants Greets jre

Bug#880920: Document Rules-Requires-Root field

2018-05-19 Thread Niels Thykier
Sean Whitton: > control: tag -1 +patch > > Hello, > > Seeking one further second (on top of those from Niels and I) to the > following diff: > As mentioned, I already seconded it. However, my mail was not signed and for avoidance of doubt, I am hereby seconding it with a signed message.

Bug#880920: Document Rules-Requires-Root field

2018-05-13 Thread Sean Whitton
control: tag -1 +patch Hello, Seeking one further second (on top of those from Niels and I) to the following diff: > diff --git a/debian/changelog b/debian/changelog > index 2dea331..b89816e 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,5 +1,11 @@ > -debian-policy (4.1.4.2)

Processed: Re: Bug#880920: Document Rules-Requires-Root field

2018-05-13 Thread Debian Bug Tracking System
Processing control commands: > tag -1 +patch Bug #880920 [debian-policy] Document Rules-Requires-Root field Added tag(s) patch. -- 880920: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880920 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems

Bug#880920: Document Rules-Requires-Root field

2018-05-13 Thread Niels Thykier
Sean Whitton: > Hello Niels, > > On Sun, Feb 25 2018, Niels Thykier wrote: > >> Attached is my updated draft along with a changes since the previous >> draft. > > Thank you for this! Let's get this into a release of the Policy Manual. > Hi, Thanks for cleaning up the text. :) > I've pushed

Bug#880920: Document Rules-Requires-Root field

2018-05-13 Thread Sean Whitton
Hello Niels, On Sun, Feb 25 2018, Niels Thykier wrote: > Attached is my updated draft along with a changes since the previous > draft. Thank you for this! Let's get this into a release of the Policy Manual. I've pushed a bug880920-spwhitton branch to the Policy repo for you to review. Aside

Bug#880920: Document Rules-Requires-Root field

2018-01-16 Thread Ian Jackson
Josh Triplett writes ("Bug#880920: Document Rules-Requires-Root field"): > On Fri, 29 Dec 2017 11:29:00 + Niels Thykier <ni...@thykier.net> wrote: > > + # Command "sudo", with arguments "-nE" and "--" > > + export DPKG_GAIN_ROOT_

Bug#880920: Document Rules-Requires-Root field

2018-01-01 Thread Josh Triplett
On Fri, 29 Dec 2017 11:29:00 + Niels Thykier wrote: > Here is an initial draft for how I think it could look. > > Review welcome. [...] > +The `gain root command` is passed to the build script via the > +``DPKG_GAIN_ROOT_CMD`` environment variable. It is space separated

Bug#880920: Document Rules-Requires-Root field

2017-12-29 Thread Niels Thykier
On Wed, 08 Nov 2017 18:20:59 -0700 Sean Whitton <spwhit...@spwhitton.name> wrote: > Hello Ian, > > On Wed, Nov 08 2017, Ian Jackson wrote: > > > Sean Whitton writes ("Bug#880920: Document Rules-Requires-Root > >field"): > >> I wonder if we

Bug#880920: Document Rules-Requires-Root field

2017-11-12 Thread Guillem Jover
On Sun, 2017-11-05 at 10:20:35 -0700, Sean Whitton wrote: > Package: debian-policy > Version 4.1.1.1 > Severity: normal > User: debian-pol...@packages.debian.org > Usertags: proposal > > On Sat, Nov 04 2017, Niels Thykier wrote: > > While there has not been any comments / feedback on devel-devel,

Bug#880920: Document Rules-Requires-Root field

2017-11-08 Thread Sean Whitton
Hello Ian, On Wed, Nov 08 2017, Ian Jackson wrote: > Sean Whitton writes ("Bug#880920: Document Rules-Requires-Root >field"): >> I wonder if we should just make Policy the new home of the spec that >> Niels and Guillem have already written? > > I certainly wo

Bug#880920: Document Rules-Requires-Root field

2017-11-08 Thread Russ Allbery
Ian Jackson <ijack...@chiark.greenend.org.uk> writes: > Sean Whitton writes ("Bug#880920: Document Rules-Requires-Root field"): >> I wonder if we should just make Policy the new home of the spec that >> Niels and Guillem have already written? > I certainly wo

Bug#880920: Document Rules-Requires-Root field

2017-11-08 Thread Ian Jackson
Sean Whitton writes ("Bug#880920: Document Rules-Requires-Root field"): > I wonder if we should just make Policy the new home of the spec that > Niels and Guillem have already written? I certainly would rather not block incorporation of this new spec into Debian's offic

Bug#880920: Document Rules-Requires-Root field

2017-11-05 Thread Sean Whitton
Package: debian-policy Version 4.1.1.1 Severity: normal User: debian-pol...@packages.debian.org Usertags: proposal On Sat, Nov 04 2017, Niels Thykier wrote: > While there has not been any comments / feedback on devel-devel, we > have seen about 35-40 packages adopting R³ since the proposal was >