[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773209#comment-13773209
]
ASF subversion and git services commented on DERBY-5955:
Commit
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570350#comment-13570350
]
Rick Hillegas commented on DERBY-5955:
--
Thanks, Dag. These changes look good to me.
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568737#comment-13568737
]
Rick Hillegas commented on DERBY-5955:
--
Thanks, Dag. These changes look good. One
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567796#comment-13567796
]
Rick Hillegas commented on DERBY-5955:
--
Thanks for checking in those changes, Dag.
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568547#comment-13568547
]
Dag H. Wanvik commented on DERBY-5955:
--
Committed the javadoc followup patch at svn
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565387#comment-13565387
]
Rick Hillegas commented on DERBY-5955:
--
Thanks for the patches, Dag. I resync'd my
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566131#comment-13566131
]
Dag H. Wanvik commented on DERBY-5955:
--
Thanks, Rick. I guess the patch application
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561621#comment-13561621
]
Dag H. Wanvik commented on DERBY-5955:
--
Committed patch derby-5955-add-cp2-to-jars at
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561669#comment-13561669
]
Dag H. Wanvik commented on DERBY-5955:
--
Committed patch make-tests-run-03 as svn
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561385#comment-13561385
]
Dag H. Wanvik commented on DERBY-5955:
--
Right, that's an easy fix, I'll do that.
Re:
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558625#comment-13558625
]
Knut Anders Hatlen commented on DERBY-5955:
---
Thanks, Dag. The changes in the
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559340#comment-13559340
]
Dag H. Wanvik commented on DERBY-5955:
--
Thanks, Knut. Re 1): Yes, but it would
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559461#comment-13559461
]
Knut Anders Hatlen commented on DERBY-5955:
---
Thanks, Dag. Re 1): I was referring
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555998#comment-13555998
]
Kristian Waagan commented on DERBY-5955:
Thanks, Dag.
I wasn't worried about you
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554836#comment-13554836
]
Kristian Waagan commented on DERBY-5955:
Hi Dag,
Thanks for working on this :)
I
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555810#comment-13555810
]
Dag H. Wanvik commented on DERBY-5955:
--
Nei, jeg tror ikke det. Disse
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553825#comment-13553825
]
Knut Anders Hatlen commented on DERBY-5955:
---
My comments to the
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554323#comment-13554323
]
Rick Hillegas commented on DERBY-5955:
--
Hi Dag,
Thanks for all of this great work. A
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553507#comment-13553507
]
Dag H. Wanvik commented on DERBY-5955:
--
Patch details:
A
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552291#comment-13552291
]
Knut Anders Hatlen commented on DERBY-5955:
---
Thanks Dag. I think a Basic prefix
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550993#comment-13550993
]
Knut Anders Hatlen commented on DERBY-5955:
---
The structure of the patch looks
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551796#comment-13551796
]
Dag H. Wanvik commented on DERBY-5955:
--
You are right it will fail on Java 5 due to
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551800#comment-13551800
]
Dag H. Wanvik commented on DERBY-5955:
--
Committed patch derby-5955-new-non-jndi-ds-02
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550777#comment-13550777
]
Dag H. Wanvik commented on DERBY-5955:
--
Regressions ran ok modulo DERBY-6038 which is
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546785#comment-13546785
]
Knut Anders Hatlen commented on DERBY-5955:
---
Thanks, Dag. Version 02 looks good
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13545904#comment-13545904
]
Knut Anders Hatlen commented on DERBY-5955:
---
The client patch changes
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546455#comment-13546455
]
Dag H. Wanvik commented on DERBY-5955:
--
Thanks, Knut. Yes, that's right, similar
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544542#comment-13544542
]
Dag H. Wanvik commented on DERBY-5955:
--
Regressions ran without error.
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541253#comment-13541253
]
Dag H. Wanvik commented on DERBY-5955:
--
Committed *-embed-restructure-04 as svn
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538125#comment-13538125
]
Rick Hillegas commented on DERBY-5955:
--
The revised published api looks good to me.
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538680#comment-13538680
]
Dag H. Wanvik commented on DERBY-5955:
--
Thanks, Knut and Rick for the reviews. I'll
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533877#comment-13533877
]
Knut Anders Hatlen commented on DERBY-5955:
---
The version 2 patch seems to
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532626#comment-13532626
]
Dag H. Wanvik commented on DERBY-5955:
--
Regressions ran cleanly.
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529926#comment-13529926
]
Dag H. Wanvik commented on DERBY-5955:
--
Note: on the point of putting
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526319#comment-13526319
]
Knut Anders Hatlen commented on DERBY-5955:
---
Sounds like the interfaces are
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526393#comment-13526393
]
Rick Hillegas commented on DERBY-5955:
--
Thanks for the responses, Dag and Knut. Some
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13512106#comment-13512106
]
Dag H. Wanvik commented on DERBY-5955:
--
Thanks, Rick. Here are some comments,
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510500#comment-13510500
]
Rick Hillegas commented on DERBY-5955:
--
Thanks, Dag. The javadoc is very helpful.
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510694#comment-13510694
]
Rick Hillegas commented on DERBY-5955:
--
Hi Dag,
Here are some further thoughts about
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506418#comment-13506418
]
Dag H. Wanvik commented on DERBY-5955:
--
Note that while ReferenceableDataSource is no
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506474#comment-13506474
]
Rick Hillegas commented on DERBY-5955:
--
Thanks, Dag. This looks very promising. The
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505858#comment-13505858
]
Mamta A. Satoor commented on DERBY-5955:
Hi Dag, thanks for taking on this big
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505995#comment-13505995
]
Dag H. Wanvik commented on DERBY-5955:
--
Good idea, Mamta! I'll make diagrams for the
[
https://issues.apache.org/jira/browse/DERBY-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495901#comment-13495901
]
Dag H. Wanvik commented on DERBY-5955:
--
I have run an initial set of tests using Java
44 matches
Mail list logo