[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12421542 ]
Kristian Waagan commented on DERBY-982:
---
Hi Andrew,
I reviewed the version 4 patch. Looks good to me, but I have one minor comment
on the JUnit test.
Althoug
[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12421041 ]
Kristian Waagan commented on DERBY-982:
---
Hi Andrew,
Your plan sounds like a very good approach.
I'll have a look at the new patch when it comes.
Are you planning on writ
[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12421028 ]
Andrew McIntyre commented on DERBY-982:
---
Hi Kristian,
Thanks for the review!
I think that the changes to sysinfo are correct, but the test needs to be
revised. The appr
[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12420855 ]
Kristian Waagan commented on DERBY-982:
---
I had a look at the patch, and also downloaded it and tried running the test.
The patch applies cleanly, but the test fails.
Is it
[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12419860 ]
Kathey Marsden commented on DERBY-982:
--
Sorry andrew I never got back to this patch after you added the tests. The
tests look fine to me too. Thanks for the fix.
> sy
[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12369504 ]
Andrew McIntyre commented on DERBY-982:
---
The client info properties file is dnc.properties. So "dnc" needs to be passed
to getProductVersionHolderFromMyEnv(genus). I call
[
http://issues.apache.org/jira/browse/DERBY-982?page=comments#action_12369455 ]
Kathey Marsden commented on DERBY-982:
--
The patch looks reasonable on a quick scan, but I did not try it.
I wonder though if "dnc" makes sense for CLIENT.
Yes!think
