[Desktop-packages] [Bug 225953]

2022-10-11 Thread Karlt
I guess fixing this would require support from LookAndFeel and a new length unit or value. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/225953 Title: pixelated icons in pop up

[Desktop-packages] [Bug 225953]

2022-10-11 Thread Karlt
This is essentially the cause of menu icon sizes changing with CSS pixel scaling. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/225953 Title: pixelated icons in pop up windows

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
ose prefs were never saved. > How? (In reply to Karl Tomlinson (ni?:karlt) from comment #85) > These are subsequently overridden by prefs if any have been saved from > a previous nsPrintSettingsGTK. This happens in nsPrintOptions from InitPrintSettingsFromPrefs(),

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
Created attachment 8621437 part 4: remove meaningless GetPrintMethod() v1.1 Also removed a now-unused nsresult and a repeated argument sanity check. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu.

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
Created attachment 8620685 part 5: remove ununsed plexName colorspace resolutionName and downloadFonts This was only used to write to and read from otherwise unused preferences. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
Created attachment 8620681 remove ununsed nsIPrintSettings::printCommand and print_command prefs These was used only to write to and read from each other. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu.

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
Created attachment 8620683 remove print(|.)(|.printer_).filename pref reading code There are no default pref values, and even if some have been set, the value is subsequently overridden by the print.print_to_filename pref, which exists if saved from a previous nsPrintSettingsGTK. -- You

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
Created attachment 8620684 remove meaningless GetPrintMethod() -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/10910 Title: Default page size for printing is letter Status in

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
Created attachment 8620682 use GTK default paper size and orientation In the nsPrintSettingsGTK constructor, gtk_paper_size_new(nullptr) gets the system default paper size from the locale and gtk_page_setup_new() sets default orientation to portrait. These are subsequently overridden by prefs if

[Desktop-packages] [Bug 10910]

2020-09-24 Thread Karlt
This bug is not half as bad now that the fix for bug 446041 provides that print.print_paper_* prefs (once they exist) will override print.postscript.paper_size. The print.print_paper_* prefs will record the previous setting, but this will only be different from print.postscript.paper_size if the

[Desktop-packages] [Bug 1893021]

2020-09-01 Thread Karlt
Comment on attachment 9172666 Bug 1661715 - Move GTK function stubs to the correct section. ### Beta/Release Uplift Approval Request * **User impact if declined**: Flash plugin fails to load. * **Is this code covered by automated tests?**: No * **Has the fix been verified in Nightly?**: No *

[Desktop-packages] [Bug 1893021]

2020-09-01 Thread Karlt
https://hg.mozilla.org/mozilla-central/rev/45e8dd195f71 actually landed in 80. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1893021 Title: Flash plugin symbol lookup error with

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
I suggest continuing to reduce the patch to find the minimal change that triggers the leak. Still, it might be helpful to know how PR_SetEnv() leaks are usually suppressed for the leak sanitizer. -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
Comment on attachment 8754796 (2/2) - Stop using libgnome and libgnomeui on Linux v4 Andrew might be able to look over this before I get a chance. Still there's quite a bit going on here, so it may take some time. Thanks, Andrew! -- You received this bug notification because you are a member

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
(In reply to Oliver Henshaw from comment #49) > https://treeherder.mozilla.org/#/jobs?repo=try=76ba509b5927 shows > the lsan annotation works. > > Is there any need to re-run the normal try tests from comment #34? No, those ASAN tests should be enough, thanks. -- You received this bug

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
nsAppRunner is compiled into libxul.so. If it leaves static strings in the environment then that can cause shutdown crashes after libxul.so is unloaded - bug 555894 and bug 473629. My best guess here is that something is or was changing the environment, in a way that changed whether lsan thought

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
As indicated in bug 557601, this is a regression with the port to GTK3, for those that still had the libgnome libraries installed. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu.

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
Comment on attachment 8754795 (1/2) - Change modelines to those recommended by coding style Thanks! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
Thank you for your thoroughness and persistence, Oliver! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
Comment on attachment 8763602 (2/4) - Annotate deliberate leak in SaveToEnv (In reply to Oliver Henshaw from comment #46) > glandium suggested using MOZ_LSAN_INTENTIONALLY_LEAK_OBJECT directly in > the code. Yes, that's much better than my suggestion, thanks. LGTM, but to comply with

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
(In reply to Oliver Henshaw from comment #43) > A fairly reduced change is > https://hg.mozilla.org/try/rev/def1122a86ba4a17de9da4ed6fa04323c819b753 Interesting, thanks. So either setenv or unsetenv changes something about the other environment variables. I think these leak reports should just

[Desktop-packages] [Bug 867424]

2020-05-08 Thread Karlt
(In reply to Oliver Henshaw from comment #18) > I managed to understand the shutdown sequence a little better by attaching > gdb and sprinkling some breakpoints around then doing a normal quit. https://wiki.mozilla.org/XPCOM_Shutdown may be useful, but it sounds like you've worked things out

[Desktop-packages] [Bug 73536]

2019-01-06 Thread Karlt
Comment on attachment 8959924 Bug 336193 - P1: Use SignalPipeWatcher to detect signals SIGTERM/SIGINT/SIGHUP and quit application gracefully. https://reviewboard.mozilla.org/r/228682/#review235956 r+ with or without the SIG_IGN case. -- You received this bug notification because you are a

[Desktop-packages] [Bug 73536]

2019-01-06 Thread Karlt
Comment on attachment 8959924 Bug 336193 - P1: Use SignalPipeWatcher to detect signals SIGTERM/SIGINT/SIGHUP and quit application gracefully. https://reviewboard.mozilla.org/r/228682/#review235302 > I based this off nsProfileLock's CATCH_SIGNAL() which does not register for signal handlers that

[Desktop-packages] [Bug 73536]

2019-01-06 Thread Karlt
Comment on attachment 8959924 Bug 336193 - P1: Use SignalPipeWatcher to detect signals SIGTERM/SIGINT/SIGHUP and quit application gracefully. https://reviewboard.mozilla.org/r/228682/#review235302 (I'm not an XPCOM peer and so I considered passing the nsDumpUtils part to Nathan, but the initial

[Desktop-packages] [Bug 73536]

2019-01-06 Thread Karlt
(In reply to James Graham [:jgraham] from comment #45) > Marionette has a method to invoke shutdown, > but sending the response races with closing the marionette connection, so it > isn't reliable. Signalling the process with SIGTERM would be the obvious > solution, except for this bug. So we

[Desktop-packages] [Bug 73536]

2019-01-06 Thread Karlt
Comment on attachment 8750107 Bug 336193 handle SIGTERM in SignalPipeWatcher then in the main thread to quit I think this approach will work well, thanks. SIGTERM will have no effect if Firefox gets stuck during shutdown, but I guess that's reasonable because SIGTERM is intended to effect normal

[Desktop-packages] [Bug 73536]

2019-01-06 Thread Karlt
Comment on attachment 8626516 bug336193.patch Unfortunately, the last paragraph of comment 23 is still relevant. (In reply to Kestrel from comment #39) > * nsAppStartup::Quit calls nsIAppShell::Exit asynchronously which does most > of the work so it doesn't block the signal handler. It is more

[Desktop-packages] [Bug 1160569]

2018-12-10 Thread Karlt
(In reply to Mike Hommey [:glandium] from comment #123) > (In reply to Karl Tomlinson (ni?:karlt) from comment #122) > > I'd also be happy to drop support for G_SLICE=always-malloc on versions > > prior > > to 2.32 if that makes the g_thread_init situation simpler. Howe

[Desktop-packages] [Bug 1160569]

2018-12-10 Thread Karlt
Comment on attachment 8631479 Replace g_slice_set_config() with G_SLICE environment variable >+ // glib version < 2.32 doesn't initialize g_thread in a static >+ // initializer. Ensure this happens before we unset G_SLICE. >+ XRE_GlibInit(); Can you note the need/reason for

[Desktop-packages] [Bug 1160569]

2018-12-10 Thread Karlt
Comment on attachment 8630422 Replace g_slice_set_config() with G_SLICE environment variable The g_type_init() call has been dropped. I don't know of a static constructor using GSlice in GLib 2.32. Is there something that causes G_SLICE to be read during XPCOMGlueStartup with GLib 2.32? It would

[Desktop-packages] [Bug 1160569]

2018-12-10 Thread Karlt
*** Bug 1075079 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: GLib-CRITICAL **: g_slice_set_config: assertion

[Desktop-packages] [Bug 1160569]

2018-12-10 Thread Karlt
Comment on attachment 8626818 0001-Bug-833117-Replace-g_slice_set_config-with-G_SLICE-e.patch >+// Keep the original value of the G_SLICE env variable to restore it once >+// we're done. >+mGSlice = getenv("G_SLICE"); I don't think we should assume it is safe to use mGSlice later.

[Desktop-packages] [Bug 1160569]

2018-12-10 Thread Karlt
(In reply to Mike Hommey [:glandium] from comment #113) > > I don't know why you are preferring setenv over putenv here. > > I had chosen putenv to avoid the leak. > > I chose setenv to avoid having both "G_SLICE" and "G_SLICE=always-malloc" as > .rodata. OK. Whatever you think is best. --

[Desktop-packages] [Bug 1160569]

2014-06-20 Thread Karlt
(In reply to MSN from comment #73) I have started the firefox in the terminal by disabling the GTK modules [GTK_IM_MODULE=xim /usr/bin/firefox]. But not happy with this work around too. That's interesting. Would you be able to file a new bug, cc me and report which module was causing the

[Desktop-packages] [Bug 434476]

2014-06-18 Thread Karlt
(In reply to Chris Pearce (:cpearce) from comment #58) We want to inhibit the screensaver when video is playing, I assume the screen wake lock is meant to take care of that. http://hg.mozilla.org/mozilla-central/annotate/37f08ddaea48/content/html/content/src/HTMLVideoElement.cpp#l312 -- You

[Desktop-packages] [Bug 434476]

2014-06-18 Thread Karlt
This can be simplified considerably given we need only listen for the screen lock. The hash table is not necessary, and classes can probably be merged. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 434476]

2014-06-18 Thread Karlt
Comment on attachment 8441363 patch v.4 The screen wake lock sounds good. I suspect we shouldn't need DOM_Fullscreen, but I'm happy to let that by because other platforms treat that similarly. However, we now know that the Screensaver is already inhibited assertion can fail, so that needs to be

[Desktop-packages] [Bug 434476]

2014-06-18 Thread Karlt
Comment on attachment 8442071 patch v.5 This could be much simpler, but let's not hold off this feature any longer. Tidying up can be a followup. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 1160569]

2014-06-17 Thread Karlt
(In reply to Wayne Mery (:wsmwk) from comment #68) So this is strictly a warning and does not prevent startup? Yes. What about comment 1, 3, ...? I don't see any crash stack traces linking the crashes to this assertion failure. Everyone on modern systems will be getting this assertion

[Desktop-packages] [Bug 1160569]

2014-06-16 Thread Karlt
Please file separate bugs, with stack traces for crashes. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **: g_slice_set_config: assertion

[Desktop-packages] [Bug 434476]

2014-05-28 Thread Karlt
The assertions are due to changes from bug 870480. I don't understand why they should have been necessary, but similarly with most of the WakeLock behavior, so I guess widget code can deal with duplicate notifications. -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 434476]

2014-05-28 Thread Karlt
Are they cpu and high-priority wake locks inhibiting the screensaver? That doesn't sound right. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/434476 Title: screensaver starts while

[Desktop-packages] [Bug 434476]

2014-05-19 Thread Karlt
Comment on attachment 8424521 Implement WakeLockListener on Linux to disable screensaver while video is playing +nsCOMPtrnsIDOMMozWakeLockListener WakeLockListener::sSingleton = nullptr; AFAIK compilers are not clever enough to avoid running a constructor for this at startup, and so this should

[Desktop-packages] [Bug 434476]

2014-05-12 Thread Karlt
Comment on attachment 8419908 Implement WakeLockListener on Linux to disable screensaver while video is playing +NS_IMPL_ISUPPORTS1(WakeLockListener, nsIDOMMozWakeLockListener) Will need to remove the '1' here now. + dbus_pending_call_set_notify(reply, ReceiveInhibitReply, this, NULL);

[Desktop-packages] [Bug 434476]

2014-05-07 Thread Karlt
Comment on attachment 8415668 Implement WakeLockListener on Linux to disable screensaver while video is playing All the DBus callbacks should be happening on the main thread unless someone calls dbus_connection_setup_with_g_main() with an off-main-thread context, which would be scary. This

[Desktop-packages] [Bug 401823]

2014-04-26 Thread Karlt
This has been fixed/avoided by out of process plugins. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/401823 Title: Gdk-WARNING **: XID collision, trouble ahead Status in Chromium

[Desktop-packages] [Bug 434476]

2014-04-23 Thread Karlt
Comment on attachment 8404230 Implement WakeLockListener on Linux to disable screensaver while video is playing The main thing missing here is appropriate handling of this situation: After a InhibitScreenSaver() call, WakeLockListener::Callback() is called with a non-locked-foreground state

[Desktop-packages] [Bug 434476]

2014-04-07 Thread Karlt
Comment on attachment 8401684 Implement WakeLockListener on Linux to disable screensaver while video is playing # User Edwin Flores eflo...@mozilla.com I assume you built on Martin's patch here. Please include him as an author. +LOCAL_INCLUDES += $(MOZ_DBUS_CFLAGS) +CFLAGS +=

[Desktop-packages] [Bug 1197559]

2014-02-27 Thread Karlt
Comment on attachment 8381157 protocol.patch Looks good, thanks. Can you adjust the spacing a bit to match the surrounding code, as noted below, please? + + Only one blank line, please. + if ( mClass == eProtocolInfo ) { No space after '(' or before ')'. Only one space after ==. +

[Desktop-packages] [Bug 263661]

2014-02-21 Thread Karlt
FWIW, attachment 351955 shows the background instead of black when using operator-over instead of overriding with operator-source here: http://hg.mozilla.org/mozilla- central/annotate/0df95f3a6de6/modules/libpr0n/src/imgFrame.cpp#l631 That may often be a little better though still not right, and

[Desktop-packages] [Bug 263661]

2014-02-21 Thread Karlt
http://hg.mozilla.org/mozilla-central/rev/9be577cafd7e http://hg.mozilla.org/mozilla-central/rev/57aeb0525615 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/263661 Title: Black Line

[Desktop-packages] [Bug 263661]

2014-02-21 Thread Karlt
Comment on attachment 497112 Use EXTEND_PAD on X Is there a reason for ignoring aDefaultFilter? (Comment 65) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/263661 Title: Black Line

[Desktop-packages] [Bug 263661]

2014-02-21 Thread Karlt
Comment on attachment 497112 Use EXTEND_PAD on X -if (fastExtendPad) { -aPattern-SetExtend(gfxPattern::EXTEND_PAD); -aPattern-SetFilter(aDefaultFilter); -} else -#endif -

[Desktop-packages] [Bug 263661]

2014-02-21 Thread Karlt
(In reply to comment #51) Tested http://hg.mozilla.org/mozilla-central/rev/5d9e1a56d922 on my current Linux box: X server vendor release code 10707000, Nouveau driver 0.0.16, NV94 video chipset. What pixman version was being used by the server here? (The patch produces the correct results

[Desktop-packages] [Bug 263661]

2014-02-21 Thread Karlt
Created attachment 532740 use RepeatPad on newer X servers even when downscaling This was based on Joe's attachment 497112, but restores the use of aDefaultFilter when we use EXTEND_PAD and adds aDefaultFilter for downscale with default extend. There is also some code simplification. We now

[Desktop-packages] [Bug 1234470]

2014-02-21 Thread Karlt
Yes, unclutter tries to be clever, but is not quite clever enough. *** This bug has been marked as a duplicate of bug 625149 *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1234470

[Desktop-packages] [Bug 1234468]

2014-02-21 Thread Karlt
Yes, unclutter tries to be clever, but is not quite clever enough. *** This bug has been marked as a duplicate of bug 625149 *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu.

[Desktop-packages] [Bug 1160569]

2014-01-29 Thread Karlt
On irc, glandium indicated that he would prefer to dlopen libglib (before anything depends on libgobject) and use the deprecated g_slice_set_config internal debugging api, than follow Matthias' suggestion to use GSLICE=always-malloc, because of the awkwardness of putenv/unsetenv. -- You received

[Desktop-packages] [Bug 1160569]

2014-01-29 Thread Karlt
Created attachment 8367119 replace g_slice_set_config with G_SLICE env var -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1160569 Title: [regression] GLib-CRITICAL **:

[Desktop-packages] [Bug 411358]

2013-11-20 Thread Karlt
Thunderbird 24 would use GIO, while 17 used only GConf, so I suspect the latest reports would be something in GIO or the libgsettingsgconfbackend not escaping the '+' correctly. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird

[Desktop-packages] [Bug 411358]

2013-11-07 Thread Karlt
This Gecko code should use gconf_escape_key() on aScheme: http://hg.mozilla.org/mozilla-central/annotate/545887140a1b/toolkit/system/gnome/nsGConfService.cpp#l239 If the error message is happening with GIO and the libgsettingsgconfbackend then something there must not be escaping the '+'

[Desktop-packages] [Bug 599846]

2013-11-05 Thread Karlt
Comment on attachment 826479 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Thanks. This is good. Just some minor things: + DBusGConnection* mDBusConnection = nullptr; + DBusConnection* dbusConnection = nullptr; + DBusGProxy* mDBusProxy = nullptr; + gboolean rv_dbus_call;

[Desktop-packages] [Bug 129219]

2013-11-05 Thread Karlt
Comment on attachment 826479 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Thanks. This is good. Just some minor things: + DBusGConnection* mDBusConnection = nullptr; + DBusConnection* dbusConnection = nullptr; + DBusGProxy* mDBusProxy = nullptr; + gboolean rv_dbus_call;

[Desktop-packages] [Bug 1160569]

2013-10-29 Thread Karlt
(In reply to jonasa from comment #34) This makes Firefox 24 on Debian Sid essentially useless because it crashes all the time, is there anything that can be done in the meantime to work around this bug? Any known workaround? See comment 27. What makes you think that this is causing the crash?

[Desktop-packages] [Bug 599846]

2013-10-18 Thread Karlt
Comment on attachment 813885 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Thank you for working out how to do this, Nelson. This looks like the right approach. Putting this in the nsGIOService is fine, even though the current implementation doesn't use GIO, because GIO's

[Desktop-packages] [Bug 129219]

2013-10-18 Thread Karlt
Comment on attachment 813885 0001-Bug-417952-Open-Containing-Folder-doesn-t-highlight-.patch Thank you for working out how to do this, Nelson. This looks like the right approach. Putting this in the nsGIOService is fine, even though the current implementation doesn't use GIO, because GIO's

[Desktop-packages] [Bug 599846]

2013-10-11 Thread Karlt
Sounds good, thanks very much. I'll see if I can have a more thorough look early next week. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/599846 Title: firefox right click open

[Desktop-packages] [Bug 129219]

2013-10-11 Thread Karlt
Sounds good, thanks very much. I'll see if I can have a more thorough look early next week. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/129219 Title: firefox download manager -

[Desktop-packages] [Bug 1160569]

2013-08-26 Thread Karlt
g_slice_set_config() is labelled internal debugging API (in 2.32.4 at least), and so Gecko should not be using this. But, unless GLib has been compiled with G_DISABLE_CHECKS, this call will be a no-op, and so will not prevent the app from starting. It seems unfortunate that different libraries

[Desktop-packages] [Bug 871325]

2013-05-29 Thread Karlt
This statement asserts that libunity is preferred over the DBus interface: While the libunity API is stable, the DBus protocol underneath is not. We strongly discourage anyone from relying on it. If libunity ends up changing, we can expect the soname to change, and so the worst that will happen

[Desktop-packages] [Bug 867424]

2013-03-15 Thread Karlt
(In reply to jhorak from comment #12) I think problem is that nsIAppStartup::Quit have some async calls and returns sooner than application is actually quit. The session manager is expecting that Firefox quit is finished when it returns from nsNativeAppSupportUnix::DieCB method. We need to

[Desktop-packages] [Bug 411358]

2012-11-15 Thread Karlt
Ah, yes. That explains a lot. http://git.gnome.org/browse/gconf/log/gconf/gconf-client.c?h=gnome-2-20 I also wonder whether gconf_escape_key() should be used here. http://developer.gnome.org/gconf/stable/gconf-gconf.html#gconf-escape-key -- You received this bug notification because you are a

[Desktop-packages] [Bug 411358]

2012-11-15 Thread Karlt
Comment on attachment 681454 workaround for old gconf + /* This check is to avoid bug #541130 when old version of gnomevfs (2.16 tested) + is installed then error window pops up if scheme is containing '+' character. + Let's pretend these kind of schemes are not supported by

[Desktop-packages] [Bug 304306]

2012-10-07 Thread Karlt
Patch in bug 797894. *** This bug has been marked as a duplicate of bug 797894 *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/304306 Title: Firefox auto scroll icon is not

[Desktop-packages] [Bug 411358]

2012-07-31 Thread Karlt
Thanks for all the investigation. I understood that dconf was now the preferred backend for GSettings. If GSettings is using GConf, shouldn't the app be built to use GConf rather than GIO? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 73536]

2012-07-13 Thread Karlt
(In reply to Nathan Froyd (:froydnj) from comment #31) I assume you mean re-raising once we've handled application shutdown? Yes. Oof, that's quite some complexity. Yes, it could well be too much trouble. It can be attacked separately if/when that turns out to be important for anything.

[Desktop-packages] [Bug 1009816]

2012-06-08 Thread Karlt
I'm going to reopen this because there is at least one bug: The timestamp from the PropertyNotify event is the timestamp when the server changed the property. This could be somewhat later than the time the user clicked on the link. I wonder whether we should only set the timestamp when we have

[Desktop-packages] [Bug 73536]

2012-05-11 Thread Karlt
Think also about what happens when a signal is received after the nsAppShell is deleted. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/73536 Title: MASTER Firefox crashes on instant

[Desktop-packages] [Bug 73536]

2012-05-10 Thread Karlt
Comment on attachment 618671 patch Communicating via pipe is the only reasonable async-signal-safe way that I know to signal the event loop. eForceQuit on SIGINT sounds sensible to me. I wouldn't implement this for SIGQUIT for the reasons you list in comment 26. It should be possible to share

[Desktop-packages] [Bug 18995]

2012-03-12 Thread Karlt
*** Bug 693318 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/18995 Title: [MASTER] Open With dialog not user-friendly Status in The

[Desktop-packages] [Bug 875266]

2012-02-22 Thread Karlt
We'll need bug 713802 to get support in nightlies. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/875266 Title: Firefox ignores GNOME 3 proxy settings Status in The Mozilla Firefox

[Desktop-packages] [Bug 857153]

2012-01-13 Thread Karlt
If distributions are no longer supporting the means by which applications determine whether accessibility is enabled, then that is not a reason to vent frustration at the application developers. Supporting the new methods for detecting settings is by definition new and therefore not thoroughly

[Desktop-packages] [Bug 732572]

2012-01-11 Thread Karlt
Comment on attachment 587271 Bug 635918 Part 1 - Make nsISound::Play use libcanberra on Linux rather than esound (v4) Thanks! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/732572

[Desktop-packages] [Bug 732572]

2012-01-11 Thread Karlt
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a6371bdb362 https://hg.mozilla.org/integration/mozilla-inbound/rev/912022fc0741 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu.

[Desktop-packages] [Bug 857153]

2012-01-05 Thread Karlt
(In reply to Karl Tomlinson (:karlt) from comment #44) If there is no session, then I assume there will be no org.a11y.Bus. Actually there probably can still be a org.a11y.Bus if registered in /usr/share/dbus-1/services/ http://www.freedesktop.org/wiki/IntroductionToDBus#Activation

[Desktop-packages] [Bug 857153]

2012-01-05 Thread Karlt
(In reply to Trevor Saunders (:tbsaunde) from comment #49) well, the firstthing that comes to mind is arranging for build machines and test machines to have GNOME_ACCESSIBILITY set, do we have an idea how hard this is? It would be good to ensure there is a session bus, because we'd like to

[Desktop-packages] [Bug 857153]

2012-01-04 Thread Karlt
That was really just guessing in comment 42, but would it make sense to skip the check if DBUS_SESSION_BUS_ADDRESS is unset anyway? If there is no session, then I assume there will be no org.a11y.Bus. -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 901838]

2011-12-13 Thread Karlt
Comment on attachment 580971 Try creating a named cursor before a bitmap cursor + { moz_none_bits, moz_none_mask_bits, 0, 0, NULL } newType = MOZ_CURSOR_NONE; break; +// If by now we don't have a xcursor, this means we have to make a custom +//

[Desktop-packages] [Bug 901838]

2011-12-13 Thread Karlt
Comment on attachment 580971 Try creating a named cursor before a bitmap cursor Thanks very much. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/901838 Title: Ugly busy cursor in

[Desktop-packages] [Bug 901838]

2011-12-12 Thread Karlt
Is gdk_cursor_new_from_name() an option? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/901838 Title: Ugly busy cursor in Thunderbird 9 Status in The Mozilla Firefox Browser:

[Desktop-packages] [Bug 901838]

2011-12-12 Thread Karlt
Looks like a left_ptr_watch lookup should be the same as a 08e8e1c95fe2fc01f976f1e063a24ccd. http://cgit.freedesktop.org/xorg/data/cursors/tree/handhelds/Makefile.cfg I guess we can't be certain the lookup will succeed, so we'd still have to fallback to the pixbuf. -- You received this bug

[Desktop-packages] [Bug 901838]

2011-12-12 Thread Karlt
Looks like this is the Xcursor code: http://cgit.freedesktop.org/xorg/lib/libXcursor/tree/src/xlib.c?id=e086eb1bf49f2a8c270eaebd5beb595c1dc2973e#n415 gdk_cursor_new_from_name() also uses XcursorLibraryLoadCursor(), so it should be possible to get the same behavior. If the cursor can also be

[Desktop-packages] [Bug 875266]

2011-12-05 Thread Karlt
Comment on attachment 578520 gsettings proxy patch v4 + items-AppendElement(obj, PR_FALSE); Can you update PR_FALSE with false, please? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu.

[Desktop-packages] [Bug 875266]

2011-12-01 Thread Karlt
Comment on attachment 577534 gsettings proxy patch v2 FUNC(g_variant_get_string, const char *, (GVariant* value, gsize* length)) \ FUNC(g_variant_is_of_type, gboolean, (GVariant* value, const GVariantType* type)) \ FUNC(g_variant_new_int32, GVariant *, (gint32 value)) \

[Desktop-packages] [Bug 875266]

2011-12-01 Thread Karlt
to Karl Tomlinson (:karlt) from comment #11) + if (mGConf IsProxyMode(auto)) { +return mGConf-GetString(NS_LITERAL_CSTRING(/system/proxy/autoconfig_url), + aResult); } + if (mGSettings) { + // Check if mode is auto I assume GSettings should override

[Desktop-packages] [Bug 875266]

2011-12-01 Thread Karlt
Comment on attachment 578249 gsettings proxy patch v3 + nsCOMPtrnsIGSettingsCollection proxy_settings; + + // Check if proxy is enabled, flag is only in schema org.gnome.system.proxy.http, + // there is no separate flag for each schema. + nsresult rv =

[Desktop-packages] [Bug 875266]

2011-11-29 Thread Karlt
(In reply to jhorak from comment #8) Isn't NewAdoptingUTF8StringEnumerator available only for internal API? Looks like you are right, based on bug 466622 comment 16 and 17. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in

[Desktop-packages] [Bug 875266]

2011-11-25 Thread Karlt
Comment on attachment 556542 gsettings proxy patch v 1 I looked at the GSettingsService changes. There is a new symbol that needs to be added to the GSETTINGS_FUNCTIONS at the top of the file for dynamic lookup, and some other things to touch up there so that this compiles against old versions

[Desktop-packages] [Bug 732572]

2011-11-23 Thread Karlt
Comment on attachment 575899 Bug 635918 Part 1 - Make nsISound::Play use libcanberra on Linux rather than esound (v3) I didn't know the nsLocalFile implementation was thread safe, but yay it is: http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsLocalFileUnix.cpp#287 +nsILocalFile*

  1   2   >