** Changed in: thunderbird (Ubuntu)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not
FYI: The issue is solved for me with TB 68.2.1. Works pretty well with
the new multilingual UI. Thank you!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail
** Changed in: thunderbird (Ubuntu)
Importance: Undecided => Low
** Changed in: thunderbird (Ubuntu)
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Created attachment 9104193
1575512-follow-up.patch
OK, this makes my TB 68.2.1 work.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not
TB 68.2.1 (follow-up):
https://hg.mozilla.org/releases/comm-esr68/rev/c540ca7f085dcc455cf0250bb7dc5a4d0d02eddd
I'll land the C-C part soon after review, yes, a little unorthodox ;-)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
(In reply to Jorg K (GMT+2) from comment #118)
> Yes, what I'm about to land on 68 is not required for 71+. We can deliberate
> whether we still want if for consistency.
Since TB71 is far from being published, I would give your patch a try.
Thx.
--
You received this bug notification because
Comment on attachment 9104194
1575512-follow-up-trunk.patch
I guess it's hard to review since it makes no difference on trunk. You
have have to trust me that is fixes TB 68 or do the experiment yourself
of getting a version from treeherder and patching the file.
--
You received this bug
Created attachment 9104180
1575512-follow-up-trunk.patch
Hold on, I assume that intl:app-locales-changed doesn't fire in a stock-
standard installation with no language packs. We still need to
initialisation to make sure the IMAP processing is unblocked.
--
You received this bug notification
(In reply to Jorg K (GMT+2) from comment #116)
> I've done a bit more debugging here.
>
> On trunk, at startup, the events fire in this order: intl:app-locales-changed
> en-US, final-ui-startup. So we get the folder names when the latter event
> fires, and we're cool. All working as observed on
(In reply to Jorg K (GMT+2) from comment #124)
> Eckard, if you're not bored yet, this version will do it:
> https://queue.taskcluster.net/v1/task/WQERYcM6Ty68YSs7ngJnNQ/runs/0/artifacts/public/build/target.dmg
Excellent!! I just tested this version for two hours. No more problem
with the folder
Pushed by mozi...@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3834c3b93900
Follow-up: Re-initialise folder names on intl:app-locales-changed. r=aceman
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
I'd recommend to keep watching the intl notification. I would totally
expect more changes to startup code paths as we extend more fluent and
intl stuff in m-c, and that's what we expect the app to respond to.
--
You received this bug notification because you are a member of Desktop
Packages,
Yes, what I'm about to land on 68 is not required for 71+. We can
deliberate whether we still want if for consistency.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
On the contrary, I'm eager to go on and will do some testing tonight
with your patched version!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names
TB 71 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/5da939a404338d73dd43e51cb5d360cdceabc8f6
(In reply to :aceman from comment #123)
> Thanks, I think this will be useful on trunk too.
I doubt it. If the language changes without a restart, we can re-
initialise the folder name cache all
Comment on attachment 9104194
1575512-follow-up-trunk.patch
Review of attachment 9104194:
-
Thanks, I think this will be useful on trunk too.
--
You received this bug notification because you are a member of Desktop
Packages,
Eckard, if you're not bored yet, this version will do it:
https://queue.taskcluster.net/v1/task/WQERYcM6Ty68YSs7ngJnNQ/runs/0/artifacts/public/build/target.dmg
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
> Since TB71 is far from being published, I would give your patch a try.
Thx.
Available as beta now from https://www.thunderbird.net/en-
US/thunderbird/beta/all/
@Axel: OK, we'll land the C-C part then as well.
--
You received this bug notification because you are a member of Desktop
Packages,
> I'd suggest to invalidate that caching on intl:app-locales-changed
Wow, that works, I've locally patched my TB 68.2.1 installation. That's
an easy fix on top of what we have already, thanks, Axel!!
--
You received this bug notification because you are a member of Desktop
Packages, which is
I've done a bit more debugging here.
On trunk, at startup, the events fire in this order: intl:app-locales-
changed en-US, final-ui-startup. So we get the folder names when the
latter event fires, and we're cool. All working as observed on beta.
On TB 68 I see: intl:app-locales-changed es-ES,
Created attachment 9104194
1575512-follow-up-trunk.patch
Sigh, `fs` was declared twice.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not
Please get them from here:
http://ftp.mozilla.org/pub/thunderbird/releases/71.0b1/linux-x86_64/xpi/
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder
Created attachment 9104178
1575512-follow-up.patch
This is the beta/ESR 68 version, trunk to follow.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder
I confirm the issue you describe in comment #101.
I installed TB 68.2.1 (en-US) from the above link, created a new profile and in
Preferences (Options) > Advanced > General > Languages > Set Alternatives added
French and German as alternatives, thus installing the French and the German
(In reply to Jorg K (GMT+2) from comment #106)
> Please get them from here:
> http://ftp.mozilla.org/pub/thunderbird/releases/71.0b1/linux-x86_64/xpi/
Thanks. I installed en-US English and German as supplementary UI
languages in my French TB 71.0b1 version, switched a dozen times from
one
No idea. There's two ways to get to a locale through the chrome reg:
- requested languages has that before en-US
- there's no en-US chrome package registered for `messenger`
How either of those two could happen for just a time-window on startup
. no idea.
I also don't think that anything
Created attachment 9104179
1575512-follow-up-trunk.patch
Easy tweak to finally get this working across the board.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
I've played with it a bit more. It works OK as long as the offending
language isn't listed in the "Alternatives". So removing Spanish from
the alternatives brings the English folder names back. So I guess
there's a bug in the Mozilla platform which we won't get fixed for TB
68.
--
You received
So what are we doing here then? I've spent an extra-ordinary about of
time on the niche feature which is clearly quite buggy in mozilla68. I'm
not inclined to dedicate more time to it. So either I remove the patch
again from TB 68 and you never get localised folder names, or we leave
it "as is"
(In reply to Jorg K (GMT+2) from comment #104)
> Could you check the new beta, TB 71. As far as I can see, it works there.
>
I cannot test this in TB 71.0b1 since there are no language packs available for
this version!
--
You received this bug notification because you are a member of Desktop
** Changed in: thunderbird
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not localized in
TB 68.2.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/b25e9210922d1efe596ea5a5b281c9cb2fff3cbb
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder
Yes, I'm thinking about when to ship this. I think it's too risky for
68.2.0, so it will likely be in 68.2.1 in more than a week. You can
always run the SQL given in the summary on your permissions.sqlite file.
--
You received this bug notification because you are a member of Desktop
Packages,
Thanks a lot for your efforts! Does this mean that TB 68.x will get the
fix soon?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not
Many many thanks for your relentless efforts to fix this issue, Jörg.
Being a regular locale switcher I highly appreciate your insistence!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Pushed by mozi...@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8c7735bd0dc3
Avoid IMAP folder operations until final-ui-startup is done. r=aceman DONTBUILD
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
OK, I'm running with 68.2.1 now and something terrible has happened. I have a
Spanish language pack installed, and although it's not active, the folders are
now all in Spanish. Eckard, can you please try this version. You're on Mac,
right?
Created attachment 9102698
1575512-glue.patch (v1b)
Here's the final patch with added comments and error checking as well as
added #ifdef since otherwise SeaMonkey won't compile since it doesn't
have mailGlue (but suiteGlue instead).
Try:
Comment on attachment 9102753
1575512-glue-mark2.patch (v1b)
Review of attachment 9102753:
-
I find it a bit excessive to add a whole new class for this, but it does work
so if you like it better...
Please again add the TODO
Created attachment 9102763
1575512-glue-mark2.patch (v1c).
Fixed typo and added more comments.
We've discussed improved error handling on IRC. initializeStrings()
shouldn't really fail, unless someone removes some of the eight folder
name strings or the system is so damaged that it can't find
Changing that event to profile-after-change doesn't help. In the IMAP
code `ready` is always false :-( - Setting it to true makes the test
pass as expected.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
You can see the simplification in the interdiff:
https://bugzilla.mozilla.org/attachment.cgi?oldid=9102584=interdiff=9102588=1
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Created attachment 9102751
1575512-glue-mark2.patch
Here's the whole thing reshuffled. We don't call into the glue any more
but the glue calls the folders.
This is the simpler solution although the patch is bigger due to all the
boilerplate.
--
You received this bug notification because you
Created attachment 9102753
1575512-glue-mark2.patch (v1b)
Slightly optimised, we only check the app name once, so if there are
thousands of URI in the permissions file, we don't get the app name
repeatedly. Debug patch doesn't apply any more.
--
You received this bug notification because you
> Can this be made 'attribute boolean finalUiStartupDone' ?
You mean "readonly". I don't think so. I don't have an instance of
nsIMailGlue. I just get the service and run one of its methods.
I'll worry about the other comments tomorrow.
--
You received this bug notification because you are a
Created attachment 9102588
1575512-glue.patch - Simplified
Here's a simplified version of the idea. The folder code doesn't check
any more whether the strings are ready, it just assumes that they are
ready when really needed. This works just as well as the other patch but
is less secure.
--
You
Created attachment 9102703
fix-tests.patch
OK, this makes the tests pass. I'll merge it onto the main patch if you
approve.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Comment on attachment 9102584
1575512-glue.patch
Review of attachment 9102584:
-
It's a pity we have to add these hacks for the current localization
infrastructure. But it is maybe also a bit unusual we cache strings in the
Created attachment 9102586
folder-debug-glue.patch
Here's the debug patch that goes with it.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names
Hmm, two Xpcshell test failures:
TEST-UNEXPECTED-TIMEOUT |
comm/mailnews/db/gloda/test/unit/test_index_messages_imap_offline.js | Test
timed out
TEST-UNEXPECTED-TIMEOUT |
comm/mailnews/db/gloda/test/unit/test_index_messages_imap_online_to_offline.js
| Test timed out
Most likely they fail
Created attachment 9102752
folder-debug-mark2.patch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not localized in thunderbird 68
Status
OK, with the patch we see the main window come up and the names of local
folders are already localised, the ones of IMAP folders aren't. They get
corrected a little later. Debugging shows that this happens during
nsImapIncomingServer::PossibleImapMailbox() which calls SetPrettyName().
Looks like
Comment on attachment 9101510
1575512-mail-startup-done.patch (v1b)
I guess that would add an observer to every folder created. That's not
so desirable. Perhaps we should remember whether the event already
happened and after that not create any observers any more. That's a
refinement I can make
Created attachment 9102074
folder-debug-jit.patch
OK, here's the debug patch. It shows:
=== NewURI start block
=== accessing string INBOX in SetPrettyName, blocked=1
=== accessing string Archives in SetPrettyName, blocked=1
=== accessing string Drafts in SetPrettyName, blocked=1
=== accessing
> The hard part is to create a folder API that MailGlue can call.
Or it could be the other way around: Folder code checks somewhere if
final-ui-startup has already run.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in
Created attachment 9102048
folder-debug.patch
This matches v2b.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail folder names are not localized in
Thinking about this, I had a better idea: We should not handle the
final-ui-startup in the folder code (where the observer is attached too
late), but elsewhere, like in MailGlue.
When the event arrives call into the folders code to re-read the
strings. Also, in IMAP's NewURI() suppress folder
Created attachment 9102073
1575512-jit-strings.patch (v3c)
Thinking about it, the JIT approach also has its merits. Aceman was
concerned that the SetPrettyName() would happen while we don't have the
strings, so I fixed this in this version. I'll attach a matching debug
patch in a minute.
--
You
Comment on attachment 9101990
1575512-mail-startup-done.patch (v3)
We can't use this, see comment #72.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
E-mail
Created attachment 9101999
folder-debug.patch
Here's a debug patch.
Aceman observed correctly, that without a faulty permissions.sqlite the
observer never fires. Looking at the debug, it is is attached after the
system has already fired the event. Whether it fires or not is
irrelevant, it will
Hi Ehsan, thanks for your continued interest and comments. I'll have the
final patch ready in the next hour according to my idea in comment #78.
I think the right solution is not to do the "damaging operations" in the
IMAP code why the system hasn't fully started up.
--
You received this bug
Created attachment 9101968
1575512-mail-startup-done.patch (v2b)
Even better, we attach the observer only to the very first folder.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Comment on attachment 9101968
1575512-mail-startup-done.patch (v2b)
OK, I think this works well enough. DiscoveryDone() will always run and
if there's a short delay, so be it. We'd have to try this on an opt
build.
--
You received this bug notification because you are a member of Desktop
Created attachment 9101990
1575512-mail-startup-done.patch (v3)
Aceman was worried that we might not run the code that fixes the folder
names. So here's a different approach. We don't do the "folder stuff" in
nsImapService::NewURI() which is mostly optional anyway. Surely we don't
need it when
(In reply to Jorg K (GMT+2) from comment #61)
> Hey Ehsan, thanks for your further comment. Let's face it: SeaMonkey is dead
> beyond the equivalent of mozilla60 (sixty, no typo), which they haven't even
> released yet. TB with about 10 staff has replaced all overlays, XBL bindings
> and are
Created attachment 9101930
1575512-mail-startup-done.patch (v2)
OK, we only add observers until our event fires.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1847772
Title:
Created attachment 9102584
1575512-glue.patch
OK, here comes the (hopefully) final solution. It features:
- Using the existing observer in mailGlue which is guaranteed to fire.
- Suppressing throw-away IMAP NewURI folder processing while strings aren't
ready
- No starting up with wrong folder
Created attachment 9101510
1575512-mail-startup-done.patch (v1b)
Listening to final-ui-startup works a bit better, still delays on the
IMAP folder names.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Created attachment 9101408
1575512-jit-strings.patch (v3)
This does the trick. I didn't add the observer, it seems more useful to
block the undesired string lookup during IMAP's creation of the URI
which also messes with folders. The visual effect is that folders first
show in English and get
Created attachment 9101508
1575512-mail-startup-done.patch
OK, here is the observer variation. Correct folder names lag behind just like
with the other patch. I think I prefer the other solution since we're not using
big observer guns and we're not affecting people who don't use IMAP.
EDIT: I
Created attachment 9101418
1575512-jit-strings.patch (v3b)
This is a bit better since it counts the enable/disable calls. The
effect is the same, for IMAP folders, the correct names show up a little
later. I'll try the observer solution tomorrow.
--
You received this bug notification because
Hey Ehsan, thanks for your further comment. Let's face it: SeaMonkey is
dead beyond the equivalent of mozilla60 (sixty, no typo), which they
haven't even released yet. TB with about 10 staff has replaced all
overlays, XBL bindings and are now working on the XUL to XHTML
transition. SM has done
(In reply to Jorg K (GMT+2) from comment #59)
> Thanks for your comments, Ehsan.
>
> If you want to deliberate about what the real/actual problem is, here's my
> view:
>
> The root issue is that storageAccessAPI permissions are stored for non-web
> origins, that is MailNews schemes like imap:
Launchpad has imported 60 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=1575512.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
** Also affects: thunderbird via
https://bugzilla.mozilla.org/show_bug.cgi?id=1575512
Importance: Unknown
Status: Unknown
** Summary changed:
- English in the localized version of Tb 68
+ E-mail folder names are not localized in thunderbird 68
--
You received this bug notification
This issue is also present in the Finnish UI. I dug around on the web a
bit and it seems that the developers are aware of this:
https://bugzilla.mozilla.org/show_bug.cgi?id=1575512
** Bug watch added: Mozilla Bugzilla #1575512
https://bugzilla.mozilla.org/show_bug.cgi?id=1575512
--
You
** Description changed:
After updating to Thunderbird 68.1.1 from the Ubuntu archive, folder
names Inbox, Drafts, Sent, Archives, Spam, Trash all appear in English
in the French UI. The rest of the UI is in French.
This issue is still present in Thunderbird 1:68.1.2+build1-0ubuntu1.
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: thunderbird (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Public bug reported:
After updating to Thunderbird 68.1.1 from the Ubuntu archive, folder
names Inbox, Drafts, Sent, Archives, Spam, Trash all appear in English
in the French UI. The rest of the UI is in French.
This issue is still present in Thunderbird 1:68.1.2+build1-0ubuntu1.
This problem
79 matches
Mail list logo
