Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145321323
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on the issue:
https://github.com/apache/activemq-artemis/pull/1592
@jbertram sure right. No other needs for SUBACK
---
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1592
What special handling does the UNSUBACK packet need? It should already be
logged with the packet-id by virtue of line 164. It has no payload to deal
with from what I can tell in the
+1
* Checked each archive to License and Notice files
* Validated signatures and checksums
* Ran the binary broker build on linux, checked web console and sent
some messages using Qpid JMS example
* Built from source and ran the sanity test profile tests
* Built Qpid JMS using the staged bits
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1592
I just added a commit and rebased. Changes include:
- Avoiding empty fields related to will in CONNECT messages
- Adding CONNACK details
---
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145238929
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235982
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235939
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235737
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235758
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235736
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145235145
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145234734
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145234463
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145232266
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145232049
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145231515
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145231002
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145231034
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145230929
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145230933
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@ -149,16
Github user ppatierno commented on the issue:
https://github.com/apache/activemq-artemis/pull/1592
Some comments :
- You can avoid to show will information if the isWillFlag is false so
there aren't empty fields to show
- avoid to show the will message payload as you are
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145227520
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1592#discussion_r145227400
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
---
@@
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1592
NO-JIRA improve MQTT protocol logging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis master_work
GitHub user dtaflin opened a pull request:
https://github.com/apache/activemq-nms-openwire/pull/3
Fix for NMS failover/TLS bug, AMQNET-572, by saving an Ssl context
Proposed fix for https://issues.apache.org/jira/browse/AMQNET-572
You can merge this pull request into a Git
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@mtaylor @clebertsuconic I've added a second commit that uses the
AbstractJDBCDriver and use one connection for everything (+ it caches the
prepared statements as the AbstractJDBCDriver
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1293
Can you do one last rebase ð
(git pull --rebase upstream master)
... resolve conflicts
git push origin -f
and I will work on the tests soon. (kind
Github user adagys commented on the issue:
https://github.com/apache/activemq-artemis/pull/1293
Yep, I remember seeing it work in an end-to-end scenario, but couldn't get
the test to work either.. Which is strange
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1293
@adagys did you at least try the feature alone? was it working? I couldn't
get it to work.
I was interested on the feature.. but I couldn't get the test to work.
---
Hi Everyone,
I have created the ActiveMQ 5.15.2 release and it's ready for a vote.
The list of resolved issues is here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12341669
You can get the release artifacts here:
Github user adagys commented on the issue:
https://github.com/apache/activemq-artemis/pull/1293
I couldn't get it to work in the end and don't have time to work on it
anymore.., can be closed
---
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@clebertsuconic @mtaylor I will provide soon a pool free commit too :+1:
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@mtaylor @franz1981 I know there are JDBCDriver whose responsibility is to
only manage connection pools. Wildfly provides one... I bet there are
JDBCDriver that will act like a
GitHub user fsgonz opened a pull request:
https://github.com/apache/activemq/pull/263
Race condition makes messages queued in the session be delivered before
messages queued in consumers. #256
Create new PR to trigger CI.
You can merge this pull request into a Git repository by
Github user fsgonz closed the pull request at:
https://github.com/apache/activemq/pull/256
---
Github user fsgonz closed the pull request at:
https://github.com/apache/activemq/pull/256
---
GitHub user fsgonz reopened a pull request:
https://github.com/apache/activemq/pull/256
AMQ-6775: Race condition makes messages queued in the session be delivered
before messages queued in consumers.
You can merge this pull request into a Git repository by running:
$ git
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1293
Test
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@franz1981 It was an example. You could instead do what the text is
suggesting and just catch the SQLException and re-establish it yourself. My
point is to do the basic thing for the
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@mtaylor Yes i understand but quoting it:
> The use of this feature is not recommended, because it has side effects
related to session state and data consistency when
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
@mtaylor @gemmellr thanks for the review comments.
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@franz1981 See the HA section here:
https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-configuration-properties.html
as an example of what I am thinking about. You could
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@franz1981 Yes, I meant using a generic connection pool implementations as
they reset the connection on release for isolation across components sharing
the same pool. I understand that
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@mtaylor
> Each time a connection is released back to the pool, the prepared
statements need to be reinitialized.
I haven't understood it: do you mean in a generic pool
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
Looks like you guys already have this resolved. FYI the corresponding core
to core test can be found here:
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
@gemmellr :)
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
..and looks like you changed it while I was commenting as such ;)
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
@gemmellr yeah, i reverted that specific change put back to "amqpvalue"
also just removing the additional core->core test combinations leaving just,
amqp->amqp, core->amqp,
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
The AMQP JMS mapping is in part around getting any different AMQP JMS
implementations behaving consistently with each other, it could as easily say
use amqp-value, or say use either. The
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1590#discussion_r145081692
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageTypesTest.java
---
@@ -158,11
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1505
@clebertsuconic @franz1981 I see a merge commit, but this PR is still open?
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1295
@clebertsuconic @franz1981 This has been open for some time now. Can you
work together to resolve this, either by merging or closing. If this need
significant refactory/impl work that
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1293
@clebertsuconic @adagys This has been open since May. What needs to
happen before we can merge/close?
---
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@franz1981 @clebertsuconic The reason we don';t use connection pools is to
increase performance on journal syncs. Each time a connection is released back
to the pool, the prepared
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1590#discussion_r145072050
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageTypesTest.java
---
@@
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1590#discussion_r145071633
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageTypesTest.java
---
@@ -158,11
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
@gemmellr fair enough this explains difference with QPID.
re Oasis spec doc i found can you comment? It seems to be specific on the
type.
---
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
Using an AmqpValue section with Binary content is perfectly valid, and is
what some other clients can prefer to do by default. The use of AmqpValue vs
Data section shouldn't influence
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1534
@stanlyDoge I'm happy with this version of the implementation. The only
concern I see is that by default the read timeout is switched off. This should
be some sensible value,
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1589
---
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1591
---
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
@mtaylor so this test is interesting, essentially it is stating that for
BytesMessage it should be 'AmqpValue' type, where as on testing with Qpid JMS
Producer a BytesMessage
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/1590
@michaelandrepearce Hey, looks like there are two test failures, could you
take a look.
```
Test Result (2 failures / +2)
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1591
ARTEMIS-1463 - add role based authentication to the JMX objects
some example fixes
https://issues.apache.org/jira/browse/ARTEMIS-1463
You can merge this pull request into a
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1590
ARTEMIS-1464 Fix Core to AMQP conversion BytesMessage corrupts bytes
Extend test cases in MessageTypesTest to cover Core to AMQP combinations
for all JMSTypeTests
Fix
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1576
@clebertsuconic AFAIK @mtaylor is not using any connection pool ie if the
connection drop, no reconnection will happen.
> Also: I see an issue with threads.. if an executor is
67 matches
Mail list logo
