[GitHub] activemq-artemis pull request #:

Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/63e0c0d310850fb59f800d2cc5cf9c5cfc0060ec#commitcomment-27458675 In artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java: In artemis

[GitHub] activemq-artemis pull request #:

Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/63e0c0d310850fb59f800d2cc5cf9c5cfc0060ec#commitcomment-27458655 In artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java: In artemis

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1852#discussion_r167332364 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java --- @@ -64,7 +64,7 @@

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1852 ---

[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1862#discussion_r167280403 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile --- @@ -21,14 +21,20 @@ ARTEMIS_INST

[GitHub] activemq-artemis pull request #1862: ARTEMIS-1676 Support overriding of JAVA...

GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1862 ARTEMIS-1676 Support overriding of JAVA_ARGS via env variable You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemi

[GitHub] activemq-artemis issue #1861: ARTEMIS-1675 Adding --safe option on print-dat...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1861 @michaelandrepearce I think you would like this one. I talked to you in person about it. ---

[GitHub] activemq-artemis pull request #1861: ARTEMIS-1675 Adding --safe option on pr...

GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/1861 ARTEMIS-1675 Adding --safe option on print-data This is good when you are a customer and an artemis engineer (e.g. me) asks your journal print-data but you can't do it because that

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1852#discussion_r167269720 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java --- @@ -64,7 +64,7 @@

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1852#discussion_r167261076 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java --- @@ -64,7 +64,7 @@

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1852#discussion_r167242748 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java --- @@ -64,7 +64,7 @@

[GitHub] activemq-artemis pull request #1860: [ARTEMIS-1670] NPE was found in when dr...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1860 ---

[GitHub] activemq-artemis pull request #1859: ARTEMIS-1659 - Only reload configuratio...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1859 ---

[GitHub] activemq-artemis pull request #:

Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27450542 There are ways. Suppressions can be provided, in multiple ways (special form commits in source, or what Coverity calls

[GitHub] activemq-artemis pull request #:

Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27449579 @jdanekrh its a good idea def good to catch it whilst code is still fresh in the authors head. FYI i flagged

[GitHub] activemq-artemis pull request #:

Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27446263 Issues created and linked onto https://issues.apache.org/jira/browse/ARTEMIS-1400. ---

[GitHub] activemq-artemis pull request #:

Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27446067 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-s

[GitHub] activemq-artemis pull request #:

Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27446032 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-s