Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/2215
@jbertram Could you please reopen
https://issues.apache.org/jira/browse/ARTEMIS-1947 as this patch ensures that
session's metadata can actually be inspected and processed by client
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/2215
[ARTEMIS-1947]Â Session metadata in session management operation
Fill the session's metadata in JSON properties instead of serializing it
as an opaque String.
JIRA: https
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/2035
The JSON is brittle because Artemis changed its content between 1.x and 2.x
and there was no way to know of this change...
I am now talking about Java serialization at all. In our
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/2035
@jbertram thanks for the suggestion.
In WildFly, we get all these information as a String blob from
https://github.com/apache/activemq-artemis/blob
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1866
FWIW, I copied the SQL statement from Artemis 2.4.0
https://github.com/apache/activemq-artemis/blob/ec63189a0a8235fc0436d9554bcdf323944e1bf6/artemis-jdbc-store/src/main/java/org/apache
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1795
Commit amended with a test
---
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1795
While testing Artemis master branch, I found an issue with my previous
commit.
---
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1795
[ARTEMIS-1609] Add distinct name/address for JMS destinations
Fix internalCreateTopic method: the topics are keyed by their core
addresses, not their JMS names.
You can merge
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1783
@clebertsuconic Martyn's is adding backwards compatibility by putting back
the exact types. That's the safest way to ensure backwards compatibility works.
---
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162103683
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/ServerMessageImpl.java
---
@@ -0,0 +1,192
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162028476
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1783#discussion_r162015472
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/transformer/Transformer.java
---
@@ -19,10 +19,18 @@
import
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1778
@jbertram Could you also cherry pick
https://github.com/jmesnil/activemq-artemis/commit/7769d43b610cf10dd5f2d82c1d0a3de3385109f0
That's built on top of what you are doing so
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161788189
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -244,22 +249,30 @@ public
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161788722
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -273,6 +286,14 @@ public void
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1778#discussion_r161789136
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java
---
@@ -309,7 +330,7 @@ public
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1756
@franz1981 done :)
---
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605068
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -188,13 +189,15
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605042
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -95,6 +95,7 @@ public
Github user jmesnil commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605094
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java
---
@@ -188,13 +189,15
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1756
The CI is reporting an error but the build has already disappeared from its
history.
Is there a way to trigger it again?
---
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1756
[ARTEMIS-1590] Properties-based SQLProvider
Replace GenericSQLProvider and other implementation by a single
PropertySQLProvider that uses properties to define SQL queries
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1604
[1.x] [ARTEMIS-1475] Fix NPE in ActiveMQMessageHandler#setup
* initialize ActiveMQActivationSpec#shareSubscriptions to false
* i18n of the exception thrown by ActiveMQMessageHandler
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1603
[ARTEMIS-1475] Fix NPE in ActiveMQMessageHandler#setup
* initialize ActiveMQActivationSpec#shareSubscriptions to false
* i18n of the exception thrown by ActiveMQMessageHandler
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/commit/4db8cd54ca2174357e36e4f0c231ad66f128d8b8#commitcomment-24878689
In
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/TransformerConfiguration.java:
In
artemis
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/commit/4db8cd54ca2174357e36e4f0c231ad66f128d8b8#commitcomment-24878586
In
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/commit/4db8cd54ca2174357e36e4f0c231ad66f128d8b8#commitcomment-24878562
In
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/TransformerConfiguration.java:
In
artemis
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1575
[ARTEMIS-1450] Support InitialMessagePacketSize on JMS
ConnectionFactoryConfiguration
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1450
You can merge this pull request into a Git
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1571
[ARTEMIS-1448] Fix Core to JMS conversion
priority is stored as a byte in the ICoreMessage's map.
It is stored then in a int when it is converted to JMS (as JMSPriority
header
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1547
[ARTMIS-1431] Adapt transport configuration in ClientProtocolManagerFactory
add the adaptTransportConfiguration() method to the
ClientProtocolManagerFactory so that transport
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1546
[ARTMIS-1431] Adapt transport configuration in ClientProtocolManagerFactory
add the adaptTransportConfiguration() method to the
ClientProtocolManagerFactory so that transport
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1341
[1.x] [ARTEMIS-1232] Configure deserialization lists on regular JMS CF
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1232
You can merge this pull request into a Git repository
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1340
[ARTEMIS-1232] Configure deserialization lists on regular JMS CF
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1232
You can merge this pull request into a Git repository by running
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1245
[1.x] [ARTEMIS-1043] Support IPv6 in NettyConnector
Wrap the host added to the HTTP request headers with
IPV6Util.encloseHost to ensure that load balancers that reads the header
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1245
Pending PR for master: https://github.com/apache/activemq-artemis/pull/1245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1244
[ARTEMIS-1043] Support IPv6 in NettyConnector
Wrap the host added to the HTTP request headers with IPV6Util.encloseHost
to ensure that load balancers that reads the header will have
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jmesnil reopened a pull request:
https://github.com/apache/activemq-artemis/pull/1178
(1.x) [ARTEMIS-1043] Support IPv6 in NettyConnector
Call IPV6Util.encloseHost when creating the uri used to send the HTTP
ugrade request to ensure that IPv6 address are properly
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1178
This 1.x PR corresponds to master PR
https://github.com/apache/activemq-artemis/pull/1177
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1178
(1.x) [ARTEMIS-1043] Support IPv6 in NettyConnector
Call IPV6Util.encloseHost when creating the uri used to send the HTTP
ugrade request to ensure that IPv6 address are properly
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1177
[ARTEMIS-1043] Support IPv6 in NettyConnector
Call IPV6Util.encloseHost when creating the uri used to send the HTTP
ugrade request to ensure that IPv6 address are properly enclosed
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/1116
Pending 1.x PR corresponding to master
https://github.com/apache/activemq-artemis/pull/1115
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1116
[ARTEMIS-1057] Log AMQ214023 at DEBUG level
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1057
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1115
[ARTEMIS-1057] Log AMQ214023 at DEBUG level
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1057
You can merge this pull request into a Git repository by running:
$ git pull
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1014
[ARTEMIS-963]Â Prevent ClassCastException in ActiveMQChannelHandler
When HTTP Upgrade is enabled, update Netty's pipeline only after the
HTTP Upgrade handshake is successful
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/1013
[ARTEMIS-963]Â Prevent ClassCastException in ActiveMQChannelHandler
When HTTP Upgrade is enabled, update Netty's pipeline only after the
HTTP Upgrade handshake is successful
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/992
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq-artemis/pull/992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/992
PR for master: https://github.com/apache/activemq-artemis/pull/991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/992
(1.x) [ARTEMIS-931] Fix HTTP Upgrade Connection
* Fix isEquivalent() method to take into account the activemqServerName
property when httpUpgradeEnabled is true. Two ActiveMQ server
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/991
There is no test in Artemis codebase dealing with HTTP upgrade as the
handler on the server side is part of the app server.
---
If your project is set up for it, you can reply
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/991
[ARTEMIS-931] Fix HTTP Upgrade Connection
* Fix isEquivalent() method to take into account the activemqServerName
property when httpUpgradeEnabled is true. Two ActiveMQ server hosted
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq-artemis/pull/976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/975
[ARTEMIS-931] Improve HTTP Upgrade connection
If the object received is not an expected HttpResponse, close the
ChannelHandlerContext and countdown the latch
JIRA: https
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/976
(1.x) [ARTEMIS-931] Improve HTTP Upgrade connection
If the object received is not an expected HttpResponse, close the
ChannelHandlerContext and countdown the latch
JIRA: https
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq-artemis/pull/969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/969
[1.x] ARTEMIS-962 Fix CME when parsing system properties
Add synchronized block against the properties before iterating on them.
JIRA: https://issues.apache.org/jira/browse
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/968
ARTEMIS-962 Fix CME when parsing system properties
Add synchronized block against the properties before iterating on them.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-926
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/847
@jbertram thanks, I checked that with that changes our tests with security
manager pass again.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/846
[ARTEMIS-803] Fix colocated backups with http-upgrade acceptor
* Do not offset ports for Netty connector/acceptor with http-upgrade
enabled.
* Pass the name of the ActiveMQ server
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/771
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/771
ARTEMIS-714 Improve JDBC Store
add DataSource and SQLProvider.Factory properties to
DataStorageConfiguration to externalize the configuration of the communication
with the JDBC data
Github user jmesnil commented on the issue:
https://github.com/apache/activemq-artemis/pull/765
The overrided injectMonitor method should still call
`monitor.addStore(largeMessagesFactory.getDirectory());` as large messages are
handled the same way than in
https://github.com/apache
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/pull/442#issuecomment-206777033
@mtaylor I amended the PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/442
[ARTEMIS-472] add cause to AMQ222137 warning
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-472
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/192
[ARTEMIS-236] Improve Legacy support on older migrating clients
set the client protocol manager factory on the server locator
JIRA: https://issues.apache.org/jira/browse/ARTEMIS
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/pull/175#issuecomment-143239217
fwiw, Eclipse has the best document about evolving Java API and they use
the `2` version:
https://wiki.eclipse.org/Evolving_Java-based_APIs_3
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/pull/31#issuecomment-112713726
this service registry is used by WildFly to pass instance of user-defined
classes (such as transformers, interceptors) to Artemis.
WildFly uses
Github user jmesnil commented on the pull request:
https://github.com/apache/activemq-artemis/pull/24#issuecomment-111031155
looking good, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq-artemis/pull/224
add getter method for channel and channelName fields
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis
Github user jmesnil closed the pull request at:
https://github.com/apache/activemq/pull/3
GitHub user jmesnil opened a pull request:
https://github.com/apache/activemq/pull/3
fix typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq patch-2
Alternatively you can review and apply these changes
75 matches
Mail list logo
