[GitHub] activemq-artemis pull request #2401: ARTEMIS-1710 Allow management msgs to p...

2018-10-29 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2401#discussion_r229013120 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java --- @@ -437,12 +449,27 @@ public

[GitHub] activemq-artemis pull request #2401: ARTEMIS-1710 Allow management msgs to p...

2018-10-29 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2401 ARTEMIS-1710 Allow management msgs to pass the global-max-size limit You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2392: ARTEMIS-2100 address routing-type overr...

2018-10-29 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2392#discussion_r228899407 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java

[GitHub] activemq-artemis pull request #2400: ARTEMIS-2151 JMS Selectors Broken in so...

2018-10-29 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2400 ARTEMIS-2151 JMS Selectors Broken in some cases Create Test Case Fix OpenWire so selectors are translated Fix GroupID to call groupId method You can merge this pull

[GitHub] activemq-artemis pull request #2399: ARTEMIS-2150 Counts the number of deliv...

2018-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2399 ---

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2388 ---

[GitHub] activemq-artemis pull request #2399: ARTEMIS-2150 Counts the number of deliv...

2018-10-26 Thread ArthurFritz
GitHub user ArthurFritz opened a pull request: https://github.com/apache/activemq-artemis/pull/2399 ARTEMIS-2150 Counts the number of delivering messages in this queue Create function this counts the number of delivering messages in this queue matching the specified filter.

[GitHub] activemq-artemis pull request #2398: ARTEMIS-2150 Counts the number of deliv...

2018-10-26 Thread ArthurFritz
Github user ArthurFritz closed the pull request at: https://github.com/apache/activemq-artemis/pull/2398 ---

[GitHub] activemq-artemis pull request #2398: [ARTEMIS-2150] Counts the number of del...

2018-10-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2398#discussion_r228623226 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -740,6 +733,56

[GitHub] activemq-artemis pull request #2398: [ARTEMIS-2150] Counts the number of del...

2018-10-26 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2398#discussion_r228619277 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java --- @@ -740,6 +733,56

[GitHub] activemq-artemis pull request #2398: [ARTEMIS-2150] Counts the number of del...

2018-10-26 Thread ArthurFritz
GitHub user ArthurFritz opened a pull request: https://github.com/apache/activemq-artemis/pull/2398 [ARTEMIS-2150] Counts the number of delivering messages in this queue Create function this counts the number of delivering messages in this queue matching the specified filter.

[GitHub] activemq-artemis pull request #2397: ARTEMIS-2116 Extend tests on producer C...

2018-10-26 Thread feuillemorte
GitHub user feuillemorte opened a pull request: https://github.com/apache/activemq-artemis/pull/2397 ARTEMIS-2116 Extend tests on producer CLI command with message body Added tests on producer cli command Cases: * Produce 10 messages with default message body *

[GitHub] activemq-artemis pull request #2396: ARTEMIS-2149 Protecting message.sendBuf...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2396 ---

[GitHub] activemq-artemis pull request #2396: ARTEMIS-2149 Protecting message.sendBuf...

2018-10-25 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2396 ARTEMIS-2149 Protecting message.sendBuffer from races encoding it You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2395: NO-JIRA Adding log.warn statements in c...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2395 ---

[GitHub] activemq-artemis pull request #2395: NO-JIRA Adding log.warn statements in c...

2018-10-25 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2395 NO-JIRA Adding log.warn statements in case properties decode fails You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2394: ARTEMIS-2148 Fixing typo where getDoubl...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2394 ---

[GitHub] activemq-artemis pull request #2394: ARTEMIS-2148 Fixing typo where getDoubl...

2018-10-25 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2394 ARTEMIS-2148 Fixing typo where getDoubleProperty marks body as changed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #1733: [DO NOT MERGE] ARTEMIS-1545 Support JMS...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/1733 ---

[GitHub] activemq-artemis pull request #2379: NO-JIRA Minor edit in HA doc

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2379 ---

[GitHub] activemq-artemis pull request #2393: ARTEMIS-2146 Avoiding NPE on AMQP Flow ...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2393 ---

[GitHub] activemq-artemis pull request #2393: ARTEMIS-2146 Avoiding NPE on AMQP Flow ...

2018-10-24 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2393#discussion_r227822843 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java --- @@ -349,7 +349,9 @@ public

[GitHub] activemq-artemis pull request #2393: ARTEMIS-2146 Avoiding NPE on AMQP Flow ...

2018-10-24 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2393 ARTEMIS-2146 Avoiding NPE on AMQP Flow Control AMQP Flow control will disable consumer flow control (setting credits to null) This will avoid a race checking flow control.

[GitHub] activemq-artemis pull request #2392: ARTEMIS-2100 address routing-type overr...

2018-10-24 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2392 ARTEMIS-2100 address routing-type overridden on attaching AMQP sender AMQPSender has to honor an already existing routingType of an address while attempting to create a fresh new

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-24 Thread shailendra14k
Github user shailendra14k closed the pull request at: https://github.com/apache/activemq-artemis/pull/2376 ---

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227665421 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -2953,6 +2961,15 @@

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-24 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227665143 --- Diff: artemis-server/src/main/resources/schema/artemis-configuration.xsd --- @@ -336,6 +336,14 @@

[GitHub] activemq-artemis pull request #2391: [ENTMQBR-2035][JBEAP-15599] add page de...

2018-10-23 Thread soul2zimate
GitHub user soul2zimate opened a pull request: https://github.com/apache/activemq-artemis/pull/2391 [ENTMQBR-2035][JBEAP-15599] add page decoding test for large message … …with no persistence (cherry picked from commit aba9384139956aaf37bde4fc881c7a0e27bbcf32) Test

[GitHub] activemq-artemis pull request #2389: NO-JIRA Remove dead jms code from broke...

2018-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2389 ---

[GitHub] activemq-artemis pull request #2390: NO-JIRA Move JMS_SESSION_CLIENT_ID_PROP...

2018-10-23 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2390 NO-JIRA Move JMS_SESSION_CLIENT_ID_PROPERTY to JMS module Remove JMS specifics from CORE, that are not used in broker (typically back compatibility only now) You can merge

[GitHub] activemq-artemis pull request #2389: NO-JIRA Remove dead jms code from broke...

2018-10-23 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2389 NO-JIRA Remove dead jms code from broker You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2376#discussion_r227610048 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ProducerView.java --- @@ -79,7 +79,7 @@

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2376#discussion_r227610014 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java --- @@ -82,7 +82,7 @@

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609704 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java --- @@ -91,7 +95,14

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609451 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java --- @@ -51,10 +51,14

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-23 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227609075 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -1540,6 +1561,75 @@ public

[GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2384#discussion_r227607588 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java --- @@ -89,6 +90,8 @@

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227604758 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -1540,6 +1561,75

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-23 Thread sebthom
Github user sebthom commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2388#discussion_r227494586 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -1540,6 +1561,75 @@ public

[GitHub] activemq-artemis pull request #2388: ARTEMIS-1856 support delays before dele...

2018-10-23 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2388 ARTEMIS-1856 support delays before deleting addresses & queues You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2383: ARTEMIS-2096 Adding a test

2018-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2383 ---

[GitHub] activemq-artemis pull request #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to ...

2018-10-23 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2387 ARTEMIS-2142 Support JMSXGroupSeq -1to close/reset group Add test cases Add GroupSequence to Message Interface Implement Support closing/reset group in queue impl

[GitHub] activemq-artemis pull request #2386: ARTEMIS-2135 Test multiple core consume...

2018-10-22 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2386 ARTEMIS-2135 Test multiple core consumers receiving amqp messages This test can verify an issue fixed by the commit: 48e0fc8f42346d96bc809593a150e05a586787ee (ARTEMIS-2135)

[GitHub] activemq-artemis pull request #2385: ARTEMIS-1929 race in STOMP identical du...

2018-10-22 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2385 ARTEMIS-1929 race in STOMP identical durable subs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #:

2018-10-22 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/292566e3906c510cfa055e5adaafec922af54ef7#commitcomment-30997805 In artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMapMessage.java: In

[GitHub] activemq-artemis pull request #:

2018-10-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/292566e3906c510cfa055e5adaafec922af54ef7#commitcomment-30997664 In artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMapMessage.java: In

[GitHub] activemq-artemis pull request #:

2018-10-22 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/292566e3906c510cfa055e5adaafec922af54ef7#commitcomment-30997542 In artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMapMessage.java: In

[GitHub] activemq-artemis pull request #:

2018-10-22 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/292566e3906c510cfa055e5adaafec922af54ef7#commitcomment-30996557 In artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMapMessage.java: In

[GitHub] activemq-artemis pull request #2250: ARTEMIS-1996 MappedSequentialFileFactor...

2018-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2250 ---

[GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...

2018-10-22 Thread sebthom
GitHub user sebthom opened a pull request: https://github.com/apache/activemq-artemis/pull/2384 ARTEMIS-2141 Add Filter column to Consumers View of AdminUI You can merge this pull request into a Git repository by running: $ git pull https://github.com/sebthom/activemq-artemis

[GitHub] activemq-artemis pull request #2250: ARTEMIS-1996 MappedSequentialFileFactor...

2018-10-22 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2250#discussion_r227024184 --- Diff: tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/fakes/FakeSequentialFileFactory.java ---

[GitHub] activemq-artemis pull request #2383: NO-JIRA Adding a test for ARTEMIS-2096

2018-10-19 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2383 NO-JIRA Adding a test for ARTEMIS-2096 This test can verify an issue fixed by the commit: 7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096) The issue was reported in:

[GitHub] activemq-artemis pull request #2382: [ARTEMIS-2137]Console retry message is ...

2018-10-18 Thread shailendra14k
GitHub user shailendra14k opened a pull request: https://github.com/apache/activemq-artemis/pull/2382 [ARTEMIS-2137]Console retry message is broken Jira:- https://issues.apache.org/jira/browse/ARTEMIS-2137 You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #2381: ARTEMIS-2136 synchronize copy construct...

2018-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2381 ---

[GitHub] activemq-artemis pull request #2381: ARTEMIS-2136 synchronize copy construct...

2018-10-18 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2381 ARTEMIS-2136 synchronize copy constructor A synchronization block was missed during the AMQP refactoring. This could impact use-cases involving diverts, cluster bridges, and

[GitHub] activemq-artemis pull request #2380: ARTEMIS-2136 Adding synchronization on ...

2018-10-18 Thread clebertsuconic
Github user clebertsuconic closed the pull request at: https://github.com/apache/activemq-artemis/pull/2380 ---

[GitHub] activemq-artemis pull request #2380: ARTEMIS-2136 Adding synchronization on ...

2018-10-18 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2380 ARTEMIS-2136 Adding synchronization on Copy Constructor I missed this synchronization block during the AMQP Refactoring This could have issues on Diverts Or Clustering bridges.

[GitHub] activemq-artemis pull request #2379: NO-JIRA Minor edit in HA doc

2018-10-18 Thread art-licis
GitHub user art-licis opened a pull request: https://github.com/apache/activemq-artemis/pull/2379 NO-JIRA Minor edit in HA doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/art-licis/activemq-artemis NO-JIRA-ha-doc

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2377#discussion_r226144345 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -362,7 +362,7 @@ var ARTEMIS = (function(ARTEMIS) {

[GitHub] activemq-artemis pull request #2362: ARTEMIS-2117 Add custom LVQ Key and Non...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2362 ---

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2377 ---

[GitHub] activemq-artemis pull request #2378: ARTEMIS-2131 Error compacting journal

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2378 ---

[GitHub] activemq-artemis pull request #:

2018-10-17 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/48d8a54135732b2b34251f571aa3a5cadc44d3a9#commitcomment-30947903 In

[GitHub] activemq-artemis pull request #:

2018-10-17 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/48d8a54135732b2b34251f571aa3a5cadc44d3a9#commitcomment-30947882 In

[GitHub] activemq-artemis pull request #:

2018-10-17 Thread michaelandrepearce
Github user michaelandrepearce commented on the pull request: https://github.com/apache/activemq-artemis/commit/48d8a54135732b2b34251f571aa3a5cadc44d3a9#commitcomment-30947762 In

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2377#discussion_r225992639 --- Diff: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/artemisPlugin.js --- @@ -362,7 +362,7 @@ var ARTEMIS =

[GitHub] activemq-artemis pull request #2378: ARTEMIS-2131 Error compacting journal

2018-10-17 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2378 ARTEMIS-2131 Error compacting journal Compaction cannot free a sliced view of a ByteBuffer on Java >=9: the fix is using the original ByteBuffer instead of the slice to perform

[GitHub] activemq-artemis pull request #2377: ARTEMIS-2133 Artemis tab not showing on...

2018-10-17 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2377 ARTEMIS-2133 Artemis tab not showing on IE browser The web console on IE doesn't have 'Artemis' showed up because it doesn't support javascripts => function. You can merge this

[GitHub] activemq-artemis pull request #2376: [ARTEMIS-2130]Web console display blank...

2018-10-17 Thread shailendra14k
GitHub user shailendra14k opened a pull request: https://github.com/apache/activemq-artemis/pull/2376 [ARTEMIS-2130]Web console display blank ClientID for the core client JIRA:- https://issues.apache.org/jira/browse/ARTEMIS-2130 While using core client.

[GitHub] activemq-artemis pull request #2373: ARTEMIS-2125 Tabs preference changes to...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2373 ---

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-16 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r225769985 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,18 @@

[GitHub] activemq-artemis pull request #2370: ARTEMIS-2125 Queue preference changes t...

2018-10-16 Thread tadayosi
Github user tadayosi closed the pull request at: https://github.com/apache/activemq-artemis/pull/2370 ---

[GitHub] activemq-artemis pull request #2375: NO-JIRA small fix to avoid re-distribut...

2018-10-16 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2375 NO-JIRA small fix to avoid re-distributor being assigned a group You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2362: ARTEMIS-2117 Add custom LVQ Key and Non...

2018-10-16 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2362#discussion_r225695887 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java --- @@ -186,10 +186,12 @@ default

[GitHub] activemq-artemis pull request #2362: ARTEMIS-2117 Add custom LVQ Key and Non...

2018-10-16 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2362#discussion_r225585632 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java --- @@ -186,10 +186,12 @@ default

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

2018-10-16 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2374#discussion_r225561623 --- Diff: docs/user-manual/en/management.md --- @@ -735,8 +735,8 @@ un-formatted result of a call to `java.lang.System.currentTimeMillis()`.

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

2018-10-16 Thread sebthom
Github user sebthom commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2374#discussion_r225560766 --- Diff: docs/user-manual/en/management.md --- @@ -735,8 +735,8 @@ un-formatted result of a call to `java.lang.System.currentTimeMillis()`.

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

2018-10-16 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2374 ARTEMIS-2127 Add auth details to consumer created notification You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2362: ARTEMIS-2117 Add custom LVQ Key and Non...

2018-10-16 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2362#discussion_r225527717 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java --- @@ -186,10 +186,12 @@ default Message

[GitHub] activemq-artemis pull request #2345: ARTEMIS-2108 Potential StackOverflowErr...

2018-10-16 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2345#discussion_r225517433 --- Diff:

[GitHub] activemq-artemis pull request #2373: ARTEMIS-2125 Queue preference changes t...

2018-10-16 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2373 ARTEMIS-2125 Queue preference changes to display columns not persistent through page refresh You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-16 Thread gaohoward
Github user gaohoward closed the pull request at: https://github.com/apache/activemq-artemis/pull/2371 ---

[GitHub] activemq-artemis pull request #2345: ARTEMIS-2108 Potential StackOverflowErr...

2018-10-16 Thread michalxo
Github user michalxo commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2345#discussion_r225473981 --- Diff:

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-16 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r225419711 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,18

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225383942 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ public

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225357936 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225353248 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ public

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225353155 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@ public

[GitHub] activemq-artemis pull request #2372: ARTEMIS-2126 web server can leak

2018-10-15 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2372 ARTEMIS-2126 web server can leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2126

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225165274 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java --- @@ -1789,6 +1790,11 @@

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225164140 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java --- @@ -0,0 +1,24 @@

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225143852 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java --- @@ -0,0 +1,24 @@ +/*

[GitHub] activemq-artemis pull request #2347: ARTEMIS-2111 ManagementContext can leak

2018-10-15 Thread michalxo
Github user michalxo commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2347#discussion_r225120812 --- Diff: artemis-cli/src/test/java/org/apache/activemq/cli/test/ArtemisTest.java --- @@ -233,6 +237,21 @@ public void testWebConfig() throws

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2371#discussion_r225093373 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQAddressBlockedException.java --- @@ -0,0 +1,24 @@ +/*

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-15 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r225077165 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,29

[GitHub] activemq-artemis pull request #2371: ARTEMIS-2097 Pause and Block Producers

2018-10-15 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2371 ARTEMIS-2097 Pause and Block Producers Added new methods to AddressControl and ServerControl to allow users to block sending on addresses. Once blocked, any messages sending to

[GitHub] activemq-artemis pull request #2370: ARTEMIS-2125 Queue preference changes t...

2018-10-14 Thread tadayosi
GitHub user tadayosi opened a pull request: https://github.com/apache/activemq-artemis/pull/2370 ARTEMIS-2125 Queue preference changes to display columns not persiste… …nt through page refresh https://issues.apache.org/jira/browse/ARTEMIS-2125 Use

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-13 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r224977706 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,29 @@

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-13 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r224977450 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,29 @@

[GitHub] activemq-artemis pull request #2369: ARTEMIS-2123 Paging not stopped if ther...

2018-10-13 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2369#discussion_r224976508 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java --- @@ -599,6 +600,29 @@

<    1   2   3   4   5   6   7   8   9   10   >