Github user RaiSaurabh closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1793
---
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/2107
ARTEMIS-1887 Setting default-max-consumers in address-setting not working
When setting "default-max-consumers" in addressing setting in broker.xml
It has no effect o
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
@franz1981 @michaelandrepearce I have added the test case to check for
default 30 is used if not set or configured. I hope now it is okay.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
@franz1981 I have updated the code. Could you please review.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
retest this please
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
@franz1981 I have updated it. Refer the image
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
@franz1981 I have updated the code as per your suggestion and also updated
the commit message same as the PR. Could you please review.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
@franz1981 Thanks for the review further.
ReplicatedPolicyConfiguration::quorumVoteWait I did not change to final as the
value will remain the default value until not changed from
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/2091
ARTEMIS-1870:Missing documentation for parameter jdbc-journal-sync-period
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/2089
I have replied and added changes that you suggested and also updated the
documentation. Could you please review.
---
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589717
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ReplicatedPolicy.java
---
@@ -61,6 +61,8
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589506
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java
---
@@ -90,6
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589019
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java
---
@@ -297,7
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/2089
ARTEMIS-1866: Make wait time for reply configurable for quorum vote
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RaiSaurabh
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Ok @michaelandrepearce .
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce Yes, I did.
---
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1973
ARTEMIS-375:When use ./artemis data exp, the xml printed to stdout with
logging infomation
Now the logging information is not printed in the stdout.
You can merge this pull request
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1966
ARTEMIS-370: Make JDBC Journal Sync period configurable
Added parameter "jdbc-journal-sync-period " to keep the sync time period
configurable.
You can merge this pu
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce @clebertsuconic Apologies for delaying this and
dragging this long. I tried to fix the code to pass all the test cases of
OpenWire but still, I get 5 failed test
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1864
@franz1981 Updated the PR/JIRA.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce I have implemented the changes asked and also checked
that this persists to disk and is recoverable on restart of the broker without
converting to the core message
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r168675067
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r168675085
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r168675045
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessage.java
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Seems some issue with Travis and Jenkins for this project is disabled.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@franz1981 I have implemented the changes @michaelandrepearce requested.
@michaelandrepearce could you please review it.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce Looks like another issue with GIT repo. Could you
please check.
---
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1864
ARTEMIS-1677:On Linux machine AIO journal type not supports NFS
Updated the document to include NFSV4 in the supported file system for AIO
journal type.
You can merge this pull
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Thanks, @michaelandrepearce @franz1981 for the review. I have implemented
the changes.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce Seems there is some problem with the Git due to which
this build failed. Could you please check and let me know.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce updated the code as per your comments.
---
Github user RaiSaurabh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1793#discussion_r165302018
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConverter.java
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Thanks, @michaelandrepearce @clebertsuconic and @franz1981 for the review
comments. I have tried to fix it. Could you please review the changes now.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
Ok, @franz1981 I will wait for the merging.
---
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1793
ARTEMIS-1498: Openwire internal headers should not be part of message
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RaiSaurabh
Github user RaiSaurabh closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1684
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1684
@michaelandrepearce I have taken your suggestion and implemented it.
Currently, I am testing it will push it in a day or two. I am ensuring that all
the headers are retained
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1696
Thanks, @michaelandrepearce @pgfox for the details provided I will keep
this in mind for future.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1696
@pgfox
For Sorting to work the JSON field name change was necessary as per me. If
you look closely you will notice that these field name as actually used to call
the individual
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1684
@michaelandrepearce @clebertsuconic
Please correct me if my understanding is wrong. I checked the code of
OpenwireMesageConverter when we send a message using client if comes
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1684
ARTEMIS-1498: Openwire internal headers should not be part of messageâ¦
⦠properties
You can merge this pull request into a Git repository by running:
$ git pull https
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
@mtaylor @michaelandrepearce Could you please merge the PR.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1670
@clebertsuconic Could you update the status of the JIRA as the pull request
is closed now.
---
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1670
ARTEMIS-1505: NPE prevents browsing queue with large messages
This fixes ARTEMIS-1505.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
@mtaylor I have updated the code and squashed it into one commit. The build
was successful.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
Got the CheckStyle validations. Will fix them and then commit and then
squash.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
@mtaylor This is strange the Checkstyle is not failing on my end but it is
on the Jenkins.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
Will fix and commit the indentation issue.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
Added the code to support sorting on the server side. Request @mtaylor to
please review.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
@mtaylor Ok. Thanks, I will start working on doing it in broker end. Will
update once done.
---
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
@mtaylor @michaelandrepearce The current implementation we set the sort
column and option in the filter and pass it along to the Artemis server for the
operation. But looking
Github user RaiSaurabh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1628
For sorting purpose AngularJS grid internal sorting should be enough for
sorting columns. I checked it was not sorting on other tabs as well
(Connections, Sessions, Consumers
GitHub user RaiSaurabh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1628
ARTEMIS-1364: Enable internal sorting in Hawtio web console
Enabled default sorting on the Hawtio web console.
You can merge this pull request into a Git repository by running
53 matches
Mail list logo
