Re: [VOTE] Release Apache NMS AMQP 1.8.1-rc1
Built binaries and run tests on windows 10 using visual studio 2017, all passed. Ran non transaction interop tests against a solace broker all passed. Built binaries on linux. Tried using a failover provider is a test application with 10 connections with repeated forced connection disconnects against a solace broker, application reconnected and resumed messaging. Looks good to me. +1 (non-binding) - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [VOTE] Release Apache NMS AMQP 1.8.1-rc1
The link to grab the files points to 1.8.0-rc2, not 1.8.1-rc1. Here is the correct link, if I'm not mistaken, https://dist.apache.org/repos/dist/dev/activemq/a= ctivemq-nms-amqp/1.8.1-rc1/ - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [VOTE] Release Apache NMS AMQP 1.8.0 - RC2
+1 (non-binding) Build the package on linux and windows Ran the unit tests, passed Ran the interop tests, passed (against two brokers) Thanks for all the work put into this. Chris Morgan - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [VOTE] Release Apache NMS 1.8.0 - Release Candidate 6
+1 (non-binding) Looks good to to me. Adding support for netstandard 2.0 is great! - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [DISCUSS] Rework NMS.AMQP
Hi everyone, Tim's post about not having a platform to run Visual Studio 2017 recently sparked a discussion between Duane, Ragnar and I about adding project and solution files for older versions of visual studio to the NMS AMQP Provider and were looking for guidance. Currently, the project only contains visual studio 2017 project and solution files. This was chosen among other things to, 1) reduce the number of of project files by using the new csproj format multi-target framework capabilities, and 2) leverage the nuget package integration in the new csproj format. Other providers seem to contain whatever visual studio files they need to build. There were two points of discussion that we are looking guidance in. 1) Is visual studio 2017 too new to expected a wide variety of developers to be able to pickup and look at this project? Does anyone have any insight into this? 2) Is there an automated system that depends on building tools that predate visual studio 2017 equivalent build tools? Would it easier for CI builds if there were project/solution files that can be built with tools the predate vs2017? If this is not the right place to ask this, then where should I ask this? Based on the feedback from the above two points we'd like to come to a decision on adding project/solution files for previous Visual Studio versions for initial release of the new AMQP Provider. If anyone has any question about this please let me know. Chris Morgan - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [DISCUSS] Rework NMS.AMQP
I have updated the README.md file in the fork, see https://github.com/cjwmorgan-sol-sys/nms-amqp, for the project to show the features supported by the amqp provider. Let me know if there are any questions. I have also been working on adding SSL/TLS configuration with client certificate authentication (as well as improving/adding transport configuration). I plan to make the amqp provider configure transport/SSL properties in similar way to ActiveMQ and Stomp providers, using the URI Query parameters. I think it would be a good to match the property names with ActiveMQ and Stomp property names as they seem to be similar to each other as well. Unless there is good reason not to. I noticed the ActiveMQ and Stomp have provider URI configuration pages, as well as build notes. Where and how are those created? I would think I will need to update those for the amqp provider pages, perhaps make a Jira Task? Although I can update the project README.md in the meantime if that's not good place to edit yet. Chris Morgan - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [DISCUSS] Rework NMS.AMQP
I have created Jira issue AMQNET-575, https://issues.apache.org/jira/browse/AMQNET-575, with a few sub tasks. I plan to add more when/if needed. Duane and are working on documenting features of the API NMS will be implemented. The current repo is not feature complete although it is close to feature complete. I plan to add some more features like Durable Consumers and SSL configuration soon but not in my next commit. Once, Duane and I are finish the feature list I can post it in this discussion thread or perhaps it should go into the Root Jira issue? Or Both? Also, Tim the project can be built using the dotnet core sdk command line tool so long as you have the Framework Target installed. I was able to build it using the dotnet core sdk version 2.1.2, if you wish to build it without vs2017. Chris Morgan - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [DISCUSS] Rework NMS.AMQP
Hi Everyone, Happy New Year. I have a progress update about the NMS AMQP API Rework. The work done in the fork, https://github.com/cjwmorgan-sol-sys/nms-amqp, is close to being finished. Duane and I have also signed the ICLA. I will follow what Tim suggested by creating an NMS JIRA under the AMQNET project (if I'm mistaken about the project please let me know). I will also be creating subtasks for some task as Tim suggested, eg cleaning out code tree, update building system, get automated unit tests running, commit new code base, etc. Although some input or guidance for other subtasks to migrate to an apache repository would be appreciated. I will create the JIRA tasks tomorrow unless there is reason not to. Let me know if there are any questions or concern. Chris Morgan - Chris Morgan -- Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
Re: [DISCUSS] Rework NMS.AMQP
Thanks Tim, I will transition my development work to the Apache repo. The project is currently unstable so, once it has become (at least more) stable I will begin the transition. Would a pull request through the github mirror be sufficient? tabish...@gmail.com wrote > I created a branch for the previous work and named it deprecated-impl > (for want of a better name) and pushed it upstream. Should be clear now > to start on any new development of this client as folks see fit. > > -- > Tim Bish > twitter: @tabish121 > blog: http://timbish.blogspot.com/ Chris Morgan - Chris Morgan -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-Rework-NMS-AMQP-tp4721986p4723793.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: [VOTE] Migrate the NMS Projects from SVN to Git
+1 (non-binding) - Chris Morgan -- View this message in context: http://activemq.2283324.n4.nabble.com/VOTE-Migrate-the-NMS-Projects-from-SVN-to-Git-tp4722345p4722400.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: [DISCUSS] Rework NMS.AMQP
Hello, I'll be working with Duane on the API rework. clebertsuconic wrote > This is actually the list you should follow up with the question: > > http://www.apache.org/foundation/mailinglists.html#foundation-legal > > > but I think just the JIRA should be enough. > > > Other guys here will have more experience on that.. they may provide > more information, but that's what I would do.. open the LEGAL JIRA. As a start, I have created Legal JIRA for the dependency on AMQP .Net Lite Library, https://issues.apache.org/jira/browse/LEGAL-292. Chris Morgan -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-Rework-NMS-AMQP-tp4721986p4722171.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
