Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2193
Yes, I commented in Jira that either via core protocol (Artemis) and
ActiveMQ are returning XA_OK. Actually all events only get prepared and
therefor data loss. My test case (simple
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2193
@clebertsuconic : Friendly reminder :-)
---
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/2193
ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare
transaction via OpenWire
@clebertsuconic : Feedback for possible test cases needed
(https://issues.apache.org
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2141
@clebertsuconic : Will this patch be cherry picked to 2.6.x branch?
---
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/2141
ARTEMIS-1935: Close of connection closes all open sessions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2073
This one looks better. I also added a comment to the internal set for
clarification what happens.
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2073
Still feels a bit odd to have so many internal sessions created and "saved"
at connection start. Maybe its better to only save the internal id of the
openwire session and later g
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/2073
ARTEMIS-1768: Update to fix handling of internalSession for
OpenWireConnection
@clebertsuconic , @jbertram
New hopefully to fix #2060 . Plz have a deep look before merge.
You
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2060
@clebertsuconic , @jbertram
I committed a new version on the original branch. Actually both security
test files and also my new testcase does work. Plz have a look on it!
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2060
Maybe it needs a better solution for the second part of the fix considering
adding internal amqsessions. let me have a look.
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2060
@clebertsuconic can you also close ARTEMIS-1768? I unfortunately have no
rights on this project to do it myself.
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2060
I mean the openwire-protocol module is actually untested. I know the
integration testsuite. Where do you prefer test case?
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/2060
Well, the whole module is untested at the moment. Let me look if I can find
a proper test case.
---
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/2060
ARTEMIS-1768: Fix handling of internalSession for OpenWireConnection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/1978
ARTEMIS-1775: Replace wrong env variable ARTEMIS_ETC_INSTANCE with
ARTEMIS_INSTANCE_ETC
You can merge this pull request into a Git repository by running:
$ git pull https
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1866
@mtaylor: Any feedback on this?
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1863
Any further objection to not merge this?
---
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1866
Well, I'm actually not able to test against oracle 12 only have a oracle 11
express instance. But a it is obvious that the autoincrement of id is wrong,
since it is 1st managed
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1866
@franz1981 : sorry I don't understand what you would like to tell? Do you
think the title is wrong? Do you think my patch is wrong?
---
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/1866
ARTEMIS-1660: Remove oracle12 autoincrement from column id for journaâ¦
â¦l tables
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1863
Well, actually the broker.xml is build from several templates and snippets.
OSGi needs a complete file to trigger broker deployment. Therefore a a file
need to be constructed during build
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488780
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -196,5 +194,20 @@ under the License.
+
+
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488599
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488412
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/1863
NO-JIRA: Sync OSGi broker config with latest changes from ARTEMIS-1628
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164266537
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164181992
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164173035
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1820#discussion_r164166706
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -698,8 +699,17 @@ private
GitHub user graben opened a pull request:
https://github.com/apache/activemq/pull/258
AMQ-6805: Add new implementation based on OSGi Declarative Services tâ¦
â¦o make OSGi services available for broker configuration
You can merge this pull request into a Git repository by running
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1216
Well, 20s in impl is different to 30s in doc. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/1121
NO JIRA Small lexical typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis master
Alternatively you can
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/1101
ARTEMIS-1038: Upgrade qpid-jms-client to 0.21.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis master
Github user graben closed the pull request at:
https://github.com/apache/activemq/pull/216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user graben opened a pull request:
https://github.com/apache/activemq/pull/216
AMQ-5344: Replace bundles with feature
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq AMQ-5344
Alternatively you can review
Github user graben closed the pull request at:
https://github.com/apache/activemq/pull/211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user graben closed the pull request at:
https://github.com/apache/activemq/pull/212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user graben closed the pull request at:
https://github.com/apache/activemq/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user graben closed the pull request at:
https://github.com/apache/activemq/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user graben opened a pull request:
https://github.com/apache/activemq/pull/213
AMQ-5247: Make jmxUseLocal global settable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq AMQ-5247
Alternatively you can
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/891
NO-JIRA: ignore of IDE configurations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis master
Alternatively
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/889
to be honest, array idea is taken from ActiveMQ :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user graben opened a pull request:
https://github.com/apache/activemq/pull/212
AMQ-6506: Increase OSGi version range for package import javax.jms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq AMQ-6506
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/889
ARTEMIS-852: Add PK and index to create journal table DDL script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq
Github user graben closed the pull request at:
https://github.com/apache/activemq-artemis/pull/875
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user graben opened a pull request:
https://github.com/apache/activemq/pull/211
AMQ-6057: Add performance patch to JDBC statements definition
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq AMQ-6057
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/875
@andytaylor: Have a look into
http://activemq.apache.org/how-do-i-use-jms-efficiently.html
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/875
@andytaylor: I mean the usage of one single pool which is used to
send/receive concurrently to multiple topics and virtual topic consumers. Such
are often used in integration
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/875
@andytaylor: One big advantage of queue semantics vs topic subscriptions is
the usage of shared pooling. No need for clientId@JMSComnection. Every single
pool connection can be used
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/875
Well, I'm not sure at all but IMHO the actual implementation of PostOffice
is transacted by default no way to deactivate. Concurrency seems a bit
difficult to me to implement in this PR
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/875
@mattrpav: I'm not sure these options can be implemented the way the
virtual topic solution is integrated. Artemis works a bit different than
ActiveMQ. But maybe someone with a deeper view
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/875
Add some initial tests for better review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/875
ARTEMIS-550 Add virtual topic support
First preview for discussion, still lacking junit tests
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/874
NO-JIRA: Fix checkstyle false friend
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis master
Alternatively you
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
Looks good. I give it a try this evening when back home.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
@clebertsuconic That's fine with me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
I love checkstyle. :) I thought about the actual implementation and did
some small refactorings. Now I think it fits best. But we may think about
synchronizing in callback
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
Have to fix a bug introduced by refactoring. I think inner classes are
looking better than an anonymous one. It might be better to add components to
ProtocolTrackerCallBackImpl too make
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
A bit more this way? IMO I did not see why to change the method to
addDataSource. It could be only one and this one is a dependency which is
mandatory for broker startup.
---
If your
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
Rebase is done :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/839
Well, I think it must be the same callback to avoid the protocol tracker to
start the broker if the datasource is not bounded yet. It's just another
"mandatory" dependency. I mi
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/839
ARTEMIS-793 Improvement to OSGi integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis master
Github user graben commented on the pull request:
https://github.com/apache/activemq-artemis/commit/d61c13ed77ecad432576442da31398ce77c87eb0#commitcomment-19304638
tcp://0.0.0.0:61616?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=
Should artemis really
63 matches
Mail list logo
