[GitHub] [ant] jaikiran commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
jaikiran commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477867207 While you are here, a quick suggestion/question - given that these changes are related to Java modules in general and there probably will be m

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477866471 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/115/ -

[GitHub] [ant] asfgit commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
asfgit commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477865927 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/121/

[GitHub] [ant] jaikiran commented on issue #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
jaikiran commented on issue #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#issuecomment-477864675 Thanks @craigpell, this is a very good enhancement and the code looks very good too. I do have some suggestions/questions about some of the ne

[GitHub] [ant] jaikiran commented on a change in pull request #89: Added version and mainClass attributes to task.

2019-03-28 Thread GitBox
jaikiran commented on a change in pull request #89: Added version and mainClass attributes to task. URL: https://github.com/apache/ant/pull/89#discussion_r270277284 ## File path: manual/Tasks/jar.html ## @@ -217,6 +217,23 @@ Parameters include META-INF unless expli

Re: Need inputs before starting a new RC for 1.10.6

2019-03-28 Thread Gintautas Grigelionis
On Thu, 28 Mar 2019 at 15:36, Stefan Bodewig wrote: > On 2019-03-28, Jaikiran Pai wrote: > > > As far as I understand the pom files that we maintain and publish to > > Maven central are basic minimal. However, a bunch of relatively recent > > commits have introduced certain changes to those poms.

Re: Need inputs before starting a new RC for 1.10.6

2019-03-28 Thread Stefan Bodewig
On 2019-03-28, Jaikiran Pai wrote: > As far as I understand the pom files that we maintain and publish to > Maven central are basic minimal. However, a bunch of relatively recent > commits have introduced certain changes to those poms. I have gone > through the mail discussion/commit logs to under

Need inputs before starting a new RC for 1.10.6

2019-03-28 Thread Jaikiran Pai
After releasing the (now aborted) RC1 of 1.10.6 last week, I went back to see how I managed to mess up that RC. While looking into that, I uncovered an unrelated issue which I think now needs attention and decision before I start a new RC release for 1.10.6. As far as I understand the pom files th