[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 I don't have enough knowledge about the thread safety aspects of the `Project` class. Stefan (@bodewig) would know more. However, having look at its code, I see similar locks and thread safety

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/81 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant pull request #81: Fix rare ConcurrentModificationException when running ...

2018-12-11 Thread mharmer
GitHub user mharmer opened a pull request: https://github.com/apache/ant/pull/81 Fix rare ConcurrentModificationException when running with Parallel-Ant executor. This resolves a rare race condition when running with the [Parallel-Ant](https://github.com/codeaholics/parallel-ant)

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/81 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/81 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/96/ ---

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/81 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/102/ ---

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread mharmer
Github user mharmer commented on the issue: https://github.com/apache/ant/pull/81 I have a test case I wrote as well, however I was hesitant on adding it since it dealt with non-deterministic behavior of trying to reproduce the race condition. If it's desired I can add it, it's

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 @mharmer, what name would you like us to add to our contributors list (https://github.com/apache/ant/blob/master/CONTRIBUTORS) for your contribution? ---

[GitHub] ant pull request #81: Fix rare ConcurrentModificationException when running ...

2018-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/81 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 > @jaikiran I think the test does exhibit the multithreaded scenario, I ran it prior to the Project changes to ensure it did fail. My Java is a bit rusty, but I believe the 2 separate ExecutorService's

[GitHub] ant pull request #80: Added tasks for JDK's jmod and jlink tools.

2018-12-11 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/80#discussion_r240889855 --- Diff: src/main/org/apache/tools/ant/taskdefs/modules/Jmod.java --- @@ -0,0 +1,1282 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread mharmer
Github user mharmer commented on the issue: https://github.com/apache/ant/pull/81 @jaikiran I think the test does exhibit the multithreaded scenario, I ran it prior to the `Project` changes to ensure it did fail. My Java is a bit rusty, but I believe the 2 separate

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread mharmer
Github user mharmer commented on the issue: https://github.com/apache/ant/pull/81 @jaikiran: "Mark Harmer" will work, thanks. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands,

[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-11 Thread craigpell
Github user craigpell commented on the issue: https://github.com/apache/ant/pull/80 All done, except that I’m finding there aren’t many man pages on my Linux system which aren’t GPL. I’ve found a few which are under a BSD license; is that acceptable? ---

Re: [VOTE] move over to gitbox.apache.org

2018-12-11 Thread Antoine Levy Lambert
+1 Antoine > On Dec 10, 2018, at 7:23 AM, Jan Matèrne (jhm) wrote: > > +1 We are neither the first nor the only project which should migrate, so it > should work smoothly. ;-) TODOs: change local remote urls, update Jenkins > jobs, update homepage > > Jan > > >> -Ursprüngliche