Re: local
On Fri, 31 Oct 2003, Steve Loughran [EMAIL PROTECTED] wrote: Stefan Bodewig wrote: MSBuild uses $() for its properties and @() for something else - probably Item references at first glance. -where is the docs for that? Follow the official information link in http://stefanbodewig.blogger.de/stories/9155/. Judging from you blog, you've found it by now. The nant-dev list is very interesting right now. 8-) I've had a closer look into the docs last weekend and will talk about the Item and task input/output stuff later. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24344] New: - NPE in JDependTask if forked
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24344. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24344 NPE in JDependTask if forked Summary: NPE in JDependTask if forked Product: Ant Version: 1.6Beta Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Optional Tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When forked, the jdepend task produces an NPE if either classespath or sourcespath are not specfied, i.e. always :-) executeAsForked should check for null in lines 519 and 532: // This is deprecated - use classespath in the future String[] sourcesPath = getSourcespath().list(); // This is the new way - use classespath - code is the same for now String[] classesPath = getClassespath().list(); BUILD FAILED java.lang.NullPointerException at org.apache.tools.ant.taskdefs.optional.jdepend.JDependTask.executeAsForked(JDependTask.java:519) at org.apache.tools.ant.taskdefs.optional.jdepend.JDependTask.execute(JDependTask.java:350) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:302) at org.apache.tools.ant.Task.perform(Task.java:401) at org.apache.tools.ant.Target.execute(Target.java:338) at org.apache.tools.ant.Target.performTasks(Target.java:365) at org.apache.tools.ant.Project.executeTarget(Project.java:1237) at org.apache.tools.ant.Project.executeTargets(Project.java:1094) at org.apache.tools.ant.Main.runBuild(Main.java:669) at org.apache.tools.ant.Main.startAnt(Main.java:220) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:215) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:90) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: overriding references
On Fri, 31 Oct 2003, Matt Benson [EMAIL PROTECTED] wrote: What's the rationale for why references can be overridden? This seems to contrast sharply with the treatment of properties. I'm not sure I'll get all historical details right without browsing through my archives, but let me try: (1) properties haven't been immutable from the start, they became immutable more or less by accident sometime before the release of Ant 1.1 and it caused a lot of grief with people who used the version of Ant that was released with Tomcat 3.0. antcall was invented as syntactic sugar over ant to solve some problems. In retrospect macros would have been better, but Ant's core was nowhere near the shape to allow them. (2) By the same time, references have already been there but not in widespread use as we didn't have any data-types in Ant 1.1. The key use was script, it's probably fair to say that almost nobody looked at references or even used them. The accident that made properties immutable never happened to references. (3) With path, patternset and fileset in Ant 1.2, references became widely used. By then, people learned that they had to use conditionals on target to set properties depending on environmental conditions (it took two more releases to get to condition). They used the target name=set-foo-1 if=a property name=foo value=a is set/ /target target name=set-foo-2 unless=a property name=foo value=a is not set/ /target target name=set-foo depends=set-foo-1,set-foo-2/ style. Of course, they wanted to be able to do the same for path. And there was the problem, references in Ant get set at parser time in lexical order. So in a construct like the above, say target name=set-foo-1 if=a path id=foo path=a is set/ /target target name=set-foo-2 unless=a path id=foo path=a is not set/ /target target name=set-foo depends=set-foo-1,set-foo-2/ Ant sets the project reference foo to the path instance created in set-foo-1 and triwa to reset it to the instance created in set-foo-2 before running a single target. When the targets finally get executed, the reference is set once again. The only way to allow references to be set conditionally is to keep them mutable because of the way Ant works. In Ant 1.6 you can replace instance created with UnknownElement and the element itself is going to get resolved when the reference is used, but the reference setting logic is still in place - and has to remain so for backwards compatibility of some script use cases. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
new external task
hello this mail is to add a new external ant task: kanaputsExternalTask.xml Description: Kanaputs is a parser for java based scripting. It is an interpreter for Java. With Kanaputs you can use Java as an interpreted language: no more compilation, each instruction is executed when you write it. It is a small programmation language to make script files above Java. Kanaputs Ant Task provides a way to add any kind of programmatic features in your Ant script. The code you insert stays OS independent (because Kanaputs uses Java) and is completely integrated with Ant as you can give Ant properties to the Kanaputs code and get back the results in other properties. Moreover, as you can invoke any kind of Java code with Kanaputs, you can popup windows from your Ant file to ask the user to do a choice. Compatibility: Ant 1.4 and above URL: http://www.kanaputs.org http://www.kanaputs.org/ant.html Contact: [EMAIL PROTECTED] best regards Patrick Duverger subsection name=Kanaputs pKanaputs is a parser for java based scripting. It is an interpreter for Java. With Kanaputs you can use Java as an interpreted language: no more compilation, each instruction is executed when you write it. It is a small programmation language to make script files above Java./p pKanaputs Ant Task provides a way to add any kind of programmatic features in your Ant script. The code you insert stays OS independent (because Kanaputs uses Java) and is completely integrated with Ant as you can give Ant properties to the Kanaputs code and get back the results in other properties./p pMoreover, as you can invoke any kind of Java code with Kanaputs, you can popup windows from your Ant file to ask the user to do a choice./p table class=externals tr thCompatibility:/th tdAnt 1.2 and above/td /tr tr thURL:/th td a href=http://www.kanaputs.org;http://www.kanaputs.org/a a href=http://www.kanaputs.org/ant.html;http://www.kanaputs.org/ant.html/a /td /tr tr thContact:/th td a href=mailto:[EMAIL PROTECTED][EMAIL PROTECTED]/a /td /tr tr thLicense:/th tdFreeware/td /tr /table /subsection - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs ImportTask.java
peterreilly2003/11/03 02:16:38
Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
ImportTask.java
Log:
sync with head
Revision ChangesPath
No revision
No revision
1.16.2.3 +3 -1
ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java
Index: ImportTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java,v
retrieving revision 1.16.2.2
retrieving revision 1.16.2.3
diff -u -r1.16.2.2 -r1.16.2.3
--- ImportTask.java 31 Oct 2003 16:09:22 - 1.16.2.2
+++ ImportTask.java 3 Nov 2003 10:16:38 - 1.16.2.3
@@ -154,7 +154,9 @@
// Paths are relative to the build file they're imported from,
// *not* the current directory (same as entity includes).
-File importedFile = FILE_UTILS.resolveFile(buildFile, file);
+
+File buildFileParent = new File(buildFile.getParent());
+File importedFile = FILE_UTILS.resolveFile(buildFileParent, file);
if (!importedFile.exists()) {
String message =
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24348] New: - soslabel task doesn't have the soshome attribute
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24348. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24348 soslabel task doesn't have the soshome attribute Summary: soslabel task doesn't have the soshome attribute Product: Ant Version: 1.5.4 Platform: All OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The SourceOffSite soslabel task doesn't have the soshome attribute like sosget, soscheckin and soscheckout tasks. And without this attribute the tasks fails. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs ImportTask.java
On 3 Nov 2003, [EMAIL PROTECTED] wrote: Opps, last change broke relative import Hmm, missing unit test? ;-) Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24103] - edit the Windows registry
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24103. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24103 edit the Windows registry --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 10:31 --- Much easier would it be using one of the many java libraries for accessing the Windows registry. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs ImportTask.java
Blush! No I did not run them correctly Peter On Monday 03 November 2003 10:30, Stefan Bodewig wrote: On 3 Nov 2003, [EMAIL PROTECTED] wrote: Opps, last change broke relative import Hmm, missing unit test? ;-) Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24223] - Task Available should fill the property with concrete filename
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24223. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24223 Task Available should fill the property with concrete filename --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 10:38 --- While writing a tutorial I created a find task which store the absolute pathname of a file as a property or as a list (if multiple are found). Tutorial http://cvs.apache.org/viewcvs.cgi/ant/docs/manual/tutorial-tasks-filesets- properties.html Sources http://cvs.apache.org/viewcvs.cgi/ant/docs/manual/tutorial-tasks-filesets- properties.zip Because I have to do some renaming things (whichfile according to the existing whichresource task) I haven´t committed that yet. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24354] New: - tar task does not include empty dirs
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24354. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24354 tar task does not include empty dirs Summary: tar task does not include empty dirs Product: Ant Version: 1.5.4 Platform: All OS/Version: Other Status: UNCONFIRMED Severity: Major Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Empty directories are not included in the tar file. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: macrodef attributes as properties or as textual substitutions [was local]
On Fri, 31 Oct 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
wrote:
What are the advantages of leaving macrodef with attributes
implemented as textual substitutions ?
attributes don't hide properties.
If we implement attributes as properties, we have to decide whether
they are allowed to override existing (user-)properties of the same
name as well. I don't think it would be problematic, as long as we
state the rules clear enough.
If they are only textual substitutions, they get confusing when we use
the property expansion syntax.
Otherwise, of course, if we leave macrodef as it is with just a new
notation for the attributes, then we can release 1.6 sooner.
I'd rather get this right as in community supported and unlikely to
break bc in Ant 1.7 now.
If we choose a notation $() for macro attributes (for instance), can
we implement macrodef with local/ in 1.7 ?
You mean we make them textual replacements now and set (local)
properties in 1.7? This would imply that attributes that didn't hide
properties in 1.6 would do so now. And should we decide that
attributes must not override existing properties, this suddenly would
have to apply to $() instead of ${} as well.
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/xdocs external.xml
bodewig 2003/11/03 06:14:03 Modified:docs external.html xdocsexternal.xml Log: Add pointer to kanaputs, Submitted by Patrick Duverger Revision ChangesPath 1.144 +65 -0 ant/docs/external.html Index: external.html === RCS file: /home/cvs/ant/docs/external.html,v retrieving revision 1.143 retrieving revision 1.144 diff -u -r1.143 -r1.144 --- external.html 23 Oct 2003 09:01:30 - 1.143 +++ external.html 3 Nov 2003 14:14:02 - 1.144 @@ -2475,6 +2475,71 @@ /tr /table h4 class=subsection +a name=Kanaputs/a +Kanaputs + /h4 +pKanaputs is a parser for java based scripting. It is an +interpreter for Java. With Kanaputs you can use Java as an +interpreted language: no more compilation, each instruction is +executed when you write it. It is a small programmation +language to make script files above Java./p +pKanaputs Ant Task provides a way to add any kind of +programmatic features in your Ant script. The code you insert +stays OS independent (because Kanaputs uses Java) and is +completely integrated with Ant as you can give Ant properties +to the Kanaputs code and get back the results in other +properties./p +pMoreover, as you can invoke any kind of Java code with +Kanaputs, you can popup windows from your Ant file to ask the +user to do a choice./p + table class=externals cellspacing=1 cellpadding=4 + tr + th colspan=1 rowspan=1 + valign=top align=left + Compatibility: + /th + td colspan=1 rowspan=1 + valign=top align=left + Ant 1.2 and above + /td + /tr + tr + th colspan=1 rowspan=1 + valign=top align=left + URL: + /th + td colspan=1 rowspan=1 + valign=top align=left + + a href=http://www.kanaputs.org/;http://www.kanaputs.org//a + a href=http://www.kanaputs.org/ant.html;http://www.kanaputs.org/ant.html/a + + /td + /tr + tr + th colspan=1 rowspan=1 + valign=top align=left + Contact: + /th + td colspan=1 rowspan=1 + valign=top align=left + + a href=mailto:[EMAIL PROTECTED][EMAIL PROTECTED]/a + + /td + /tr + tr + th colspan=1 rowspan=1 + valign=top align=left + License: + /th + td colspan=1 rowspan=1 + valign=top align=left + Freeware + /td + /tr +/table +h4 class=subsection a name=Macker/a Macker /h4 1.106 +43 -0 ant/xdocs/external.xml Index: external.xml === RCS file: /home/cvs/ant/xdocs/external.xml,v retrieving revision 1.105 retrieving revision 1.106 diff -u -r1.105 -r1.106 --- external.xml 23 Oct 2003 09:01:30 - 1.105 +++ external.xml 3 Nov 2003 14:14:02 - 1.106 @@ -1302,6 +1302,49 @@ /table /subsection + subsection name=Kanaputs + +pKanaputs is a parser for java based scripting. It is an +interpreter for Java. With Kanaputs you can use Java as an +interpreted language: no more compilation, each instruction is +executed when you write it. It is a small programmation +language to make script files above Java./p + +pKanaputs Ant Task provides a way to add any kind of +programmatic features in your Ant script. The code you insert +stays OS independent (because Kanaputs uses Java) and is +completely integrated with Ant as you can give Ant properties +to the Kanaputs code and get back the results in other +properties./p + +pMoreover, as you can invoke any kind of Java code with +Kanaputs, you can popup windows from your Ant file to ask the +user to do a choice./p +table class=externals + tr +thCompatibility:/th +tdAnt 1.2 and above/td + /tr + tr +thURL:/th +td + a href=http://www.kanaputs.org/;http://www.kanaputs.org//a +
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend JDependTask.java
peterreilly2003/11/03 07:01:41
Modified:src/main/org/apache/tools/ant/taskdefs/optional/jdepend
JDependTask.java
Log:
checkstyle
Revision ChangesPath
1.23 +93 -48
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
Index: JDependTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- JDependTask.java 19 Jul 2003 11:20:18 - 1.22
+++ JDependTask.java 3 Nov 2003 15:01:41 - 1.23
@@ -90,18 +90,18 @@
//private CommandlineJava commandline = new CommandlineJava();
// required attributes
-private Path _sourcesPath; // Deprecated!
-private Path _classesPath; // Use this going forward
+private Path sourcesPath; // Deprecated!
+private Path classesPath; // Use this going forward
// optional attributes
-private File _outputFile;
-private File _dir;
-private Path _compileClasspath;
-private boolean _haltonerror = false;
-private boolean _fork = false;
+private File outputFile;
+private File dir;
+private Path compileClasspath;
+private boolean haltonerror = false;
+private boolean fork = false;
//private Integer _timeout = null;
-private String _jvm = null;
+private String jvm = null;
private String format = text;
private PatternSet defaultPatterns = new PatternSet();
@@ -124,9 +124,6 @@
}
}
-public JDependTask() {
-}
-
/*
public void setTimeout(Integer value) {
_timeout = value;
@@ -140,38 +137,49 @@
/**
* The output file name.
*
- * @param outputFile
+ * @param outputFile the output file name
*/
public void setOutputFile(File outputFile) {
-_outputFile = outputFile;
+this.outputFile = outputFile;
}
+/**
+ * @return the output file name
+ */
public File getOutputFile() {
-return _outputFile;
+return outputFile;
}
/**
* Whether or not to halt on failure. Default: false.
+ * @param haltonerror the value to set
*/
-public void setHaltonerror(boolean value) {
-_haltonerror = value;
+public void setHaltonerror(boolean haltonerror) {
+this.haltonerror = haltonerror;
}
+/**
+ * @return the value of the haltonerror attribute
+ */
public boolean getHaltonerror() {
-return _haltonerror;
+return haltonerror;
}
/**
* If true, forks into a new JVM. Default: false.
*
- * @param value tttrue/tt if a JVM should be forked, otherwise
ttfalsett
+ * @param value tttrue/tt if a JVM should be forked,
+ * otherwise ttfalsett
*/
public void setFork(boolean value) {
-_fork = value;
+fork = value;
}
+/**
+ * @return the value of the fork attribute
+ */
public boolean getFork() {
-return _fork;
+return fork;
}
/**
@@ -182,47 +190,49 @@
* @see #setFork(boolean)
*/
public void setJvm(String value) {
-_jvm = value;
+jvm = value;
}
/**
* Adds a path to source code to analyze.
+ * @return a source path
* @deprecated
*/
public Path createSourcespath() {
-if (_sourcesPath == null) {
-_sourcesPath = new Path(getProject());
+if (sourcesPath == null) {
+sourcesPath = new Path(getProject());
}
-return _sourcesPath.createPath();
+return sourcesPath.createPath();
}
/**
* Gets the sourcepath.
- *
+ * @return the sources path
* @deprecated
*
*/
public Path getSourcespath() {
-return _sourcesPath;
+return sourcesPath;
}
/**
* Adds a path to class code to analyze.
+ * @return a classes path
*/
public Path createClassespath() {
-if (_classesPath == null) {
-_classesPath = new Path(getProject());
+if (classesPath == null) {
+classesPath = new Path(getProject());
}
-return _classesPath.createPath();
+return classesPath.createPath();
}
/**
* Gets the classespath.
- *
+ * @return the classes path
*/
public Path getClassespath() {
-return _classesPath;
+return classesPath;
}
/**
@@ -231,42 +241,52 @@
* @see
RE: MARC - spam enabler
All right, Stefan, I'll stop worrying about it. I hadn't thought that spammers would subscribe to these lists just to harvest addresses, but that's obviously possible too. -Original Message- From: Stefan Bodewig Sent: Monday, November 03, 2003 2:17 AM To: [EMAIL PROTECTED] Subject: Re: MARC - spam enabler On Fri, 31 Oct 2003, Steve Cohen wrote: Can't MARC be fixed to munge email addresses? Even if it could, it wouldn't help you. but whenever I am replied to, my full unmunged email address gets published in MARC. I've just removed your email address from the attribution my MUA generates. 8-) Marc is by far not the only way a spammer can get at your address you use for posting here. Eyebrowse is another option, as are our mbox archives. It's even quite easy to subscribe an address collecting bot to the list. I am sick of seeing my postings to these lists turn into spam cannons pointed back at myself. There is no way to avoid that, all you can do is to use smart spam detection software on your side, sorry. Spammers will get your address if you use it on public lists and no address munging will stop them from doing so. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24260] - unzip seem extracting all files all the time.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24260. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24260 unzip seem extracting all files all the time. [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24280] - Empty value attribute for arg behaves differently on Windows and Unix
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24280. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24280 Empty value attribute for arg behaves differently on Windows and Unix --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 15:07 --- It's probably due to the JDK and/or the underlying OS - Ant uses the same JDK method with the same arguments in both cases. If you use exec instead of java and set vmlauncher to false, is there any difference? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24282] - CVS tagdiff bug: date string can contain spaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24282. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24282 CVS tagdiff bug: date string can contain spaces [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE Target Milestone|--- |1.6 --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 15:11 --- Seee also Bug 21481 *** This bug has been marked as a duplicate of 15995 *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 15995] - [PATCH] cvstagdiff does not correctly handle the cvs comand with time formatted as dd-MM-yy hh:mm:ss
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15995. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15995 [PATCH] cvstagdiff does not correctly handle the cvs comand with time formatted as dd-MM-yy hh:mm:ss [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 15:11 --- *** Bug 24282 has been marked as a duplicate of this bug. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend JDependTask.java
bodewig 2003/11/03 07:19:50
Modified:src/main/org/apache/tools/ant/taskdefs/optional/jdepend
JDependTask.java
Log:
Fix NPE, PR: 24344
Revision ChangesPath
1.24 +4 -0
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
Index: JDependTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- JDependTask.java 3 Nov 2003 15:01:41 - 1.23
+++ JDependTask.java 3 Nov 2003 15:19:50 - 1.24
@@ -559,6 +559,7 @@
// we have to find a cleaner way to put this output
}
+if (getSourcespath() != null) {
// This is deprecated - use classespath in the future
String[] sourcesPath = getSourcespath().list();
for (int i = 0; i sourcesPath.length; i++) {
@@ -571,7 +572,9 @@
}
commandline.createArgument().setValue(f.getPath());
}
+}
+if (getClassespath() != null) {
// This is the new way - use classespath - code is the same for now
String[] classesPath = getClassespath().list();
for (int i = 0; i classesPath.length; i++) {
@@ -582,6 +585,7 @@
+ represent a valid directory.
JDepend would fail.);
}
commandline.createArgument().setValue(f.getPath());
+}
}
Execute execute = new Execute(new LogStreamHandler(this,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/etc/testcases/taskdefs/optional/jdepend - New directory
peterreilly2003/11/03 07:21:09 ant/src/etc/testcases/taskdefs/optional/jdepend - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/jdepend - New directory
peterreilly2003/11/03 07:21:35 ant/src/testcases/org/apache/tools/ant/taskdefs/optional/jdepend - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend JDependTask.java
bodewig 2003/11/03 07:22:28
Modified:src/main/org/apache/tools/ant/taskdefs/optional/jdepend
JDependTask.java
Log:
Indentation changes
Revision ChangesPath
1.25 +27 -20
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
Index: JDependTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- JDependTask.java 3 Nov 2003 15:19:50 - 1.24
+++ JDependTask.java 3 Nov 2003 15:22:28 - 1.25
@@ -560,32 +560,39 @@
}
if (getSourcespath() != null) {
-// This is deprecated - use classespath in the future
-String[] sourcesPath = getSourcespath().list();
-for (int i = 0; i sourcesPath.length; i++) {
-File f = new File(sourcesPath[i]);
+// This is deprecated - use classespath in the future
+String[] sourcesPath = getSourcespath().list();
+for (int i = 0; i sourcesPath.length; i++) {
+File f = new File(sourcesPath[i]);
-// not necessary as JDepend would fail, but why loose some time?
-if (!f.exists() || !f.isDirectory()) {
-throw new BuildException(\ + f.getPath() + \ does not
- + represent a valid directory.
JDepend would fail.);
+// not necessary as JDepend would fail, but why loose
+// some time?
+if (!f.exists() || !f.isDirectory()) {
+throw new BuildException(\ + f.getPath()
+ + \ does not represent a
valid
+ + directory. JDepend would
+ + fail.);
+}
+commandline.createArgument().setValue(f.getPath());
}
-commandline.createArgument().setValue(f.getPath());
-}
}
if (getClassespath() != null) {
-// This is the new way - use classespath - code is the same for now
-String[] classesPath = getClassespath().list();
-for (int i = 0; i classesPath.length; i++) {
-File f = new File(classesPath[i]);
-// not necessary as JDepend would fail, but why loose some time?
-if (!f.exists() || !f.isDirectory()) {
-throw new BuildException(\ + f.getPath() + \ does not
- + represent a valid directory.
JDepend would fail.);
+// This is the new way - use classespath - code is the
+// same for now
+String[] classesPath = getClassespath().list();
+for (int i = 0; i classesPath.length; i++) {
+File f = new File(classesPath[i]);
+// not necessary as JDepend would fail, but why loose
+// some time?
+if (!f.exists() || !f.isDirectory()) {
+throw new BuildException(\ + f.getPath()
+ + \ does not represent a
valid
+ + directory. JDepend would
+ + fail.);
+}
+commandline.createArgument().setValue(f.getPath());
}
-commandline.createArgument().setValue(f.getPath());
-}
}
Execute execute = new Execute(new LogStreamHandler(this,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24344] - NPE in JDependTask if forked
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24344. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24344 NPE in JDependTask if forked [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.6 --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 15:22 --- will be fixed with the next beta/1.6 final. Thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend JDependTask.java
bodewig 2003/11/03 07:23:57
Modified:src/main/org/apache/tools/ant/taskdefs/optional/jdepend Tag:
ANT_16_BRANCH JDependTask.java
Log:
Merge from HEAD
Revision ChangesPath
No revision
No revision
1.22.2.1 +29 -18
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
Index: JDependTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
retrieving revision 1.22
retrieving revision 1.22.2.1
diff -u -r1.22 -r1.22.2.1
--- JDependTask.java 19 Jul 2003 11:20:18 - 1.22
+++ JDependTask.java 3 Nov 2003 15:23:57 - 1.22.2.1
@@ -515,29 +515,40 @@
// we have to find a cleaner way to put this output
}
-// This is deprecated - use classespath in the future
-String[] sourcesPath = getSourcespath().list();
-for (int i = 0; i sourcesPath.length; i++) {
-File f = new File(sourcesPath[i]);
+if (getSourcespath() != null) {
+// This is deprecated - use classespath in the future
+String[] sourcesPath = getSourcespath().list();
+for (int i = 0; i sourcesPath.length; i++) {
+File f = new File(sourcesPath[i]);
-// not necessary as JDepend would fail, but why loose some time?
-if (!f.exists() || !f.isDirectory()) {
-throw new BuildException(\ + f.getPath() + \ does not
- + represent a valid directory.
JDepend would fail.);
+// not necessary as JDepend would fail, but why loose
+// some time?
+if (!f.exists() || !f.isDirectory()) {
+throw new BuildException(\ + f.getPath()
+ + \ does not represent a
valid
+ + directory. JDepend would
+ + fail.);
+}
+commandline.createArgument().setValue(f.getPath());
}
-commandline.createArgument().setValue(f.getPath());
}
-// This is the new way - use classespath - code is the same for now
-String[] classesPath = getClassespath().list();
-for (int i = 0; i classesPath.length; i++) {
-File f = new File(classesPath[i]);
-// not necessary as JDepend would fail, but why loose some time?
-if (!f.exists() || !f.isDirectory()) {
-throw new BuildException(\ + f.getPath() + \ does not
- + represent a valid directory.
JDepend would fail.);
+if (getClassespath() != null) {
+// This is the new way - use classespath - code is the
+// same for now
+String[] classesPath = getClassespath().list();
+for (int i = 0; i classesPath.length; i++) {
+File f = new File(classesPath[i]);
+// not necessary as JDepend would fail, but why loose
+// some time?
+if (!f.exists() || !f.isDirectory()) {
+throw new BuildException(\ + f.getPath()
+ + \ does not represent a
valid
+ + directory. JDepend would
+ + fail.);
+}
+commandline.createArgument().setValue(f.getPath());
}
-commandline.createArgument().setValue(f.getPath());
}
Execute execute = new Execute(new LogStreamHandler(this,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/jdepend JDependTest.java
peterreilly2003/11/03 07:34:13
Modified:docs/manual/OptionalTasks jdepend.html
src/main/org/apache/tools/ant/taskdefs/optional/jdepend
JDependTask.java
Added: src/etc/testcases/taskdefs/optional/jdepend jdepend.xml
src/testcases/org/apache/tools/ant/taskdefs/optional/jdepend
JDependTest.java
Log:
fix timeout attribute of jdepend
add unit tests
add includeruntime to allow unittests to run
Revision ChangesPath
1.11 +6 -0 ant/docs/manual/OptionalTasks/jdepend.html
Index: jdepend.html
===
RCS file: /home/cvs/ant/docs/manual/OptionalTasks/jdepend.html,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- jdepend.html 3 Apr 2003 15:49:47 - 1.10
+++ jdepend.html 3 Nov 2003 15:34:13 - 1.11
@@ -72,6 +72,12 @@
td ALIGN=CENTER VALIGN=TOPNo/td
/tr
tr
+td VALIGN=TOPincluderuntime/td
+td VALIGN=TOPImplicitly add the classes required to run jdepend
+in forked mode. (Ignored if fork is disabled). Since ant 1.6./td
+td ALIGN=CENTER VALIGN=TOPNo, default is no./td
+ /tr
+ tr
td VALIGN=TOPclasspathref/td
td VALIGN=TOPthe classpath to use, given as reference to a PATH
defined elsewhere./td
td ALIGN=CENTER VALIGN=TOPNo/td
1.1
ant/src/etc/testcases/taskdefs/optional/jdepend/jdepend.xml
Index: jdepend.xml
===
project
property name=testclasses location=../../../../../../build/testcases/
path id=all-test-classes.id
pathelement location=../../../../build/testcases /
pathelement path=${java.class.path} /
/path
path id=example-classes.id
pathelement location=${testclasses}/org/apache/tools/ant/util/facade /
/path
path id=test-classes.id
pathelement location=${testclasses} /
/path
target name=simple
jdepend
classespath refid=example-classes.id/
/jdepend
/target
target name=xml
jdepend format=xml
classespath refid=example-classes.id/
/jdepend
/target
target name=fork
jdepend fork=yes includeruntime=yes
classespath refid=example-classes.id/
/jdepend
/target
target name=fork-xml
jdepend fork=yes format=xml includeruntime=yes
classespath refid=example-classes.id/
/jdepend
/target
target name=fork-timeout
jdepend fork=yes timeout=10 includeruntime=yes
classespath refid=test-classes.id/
/jdepend
/target
target name=fork-timeout-not
jdepend fork=yes timeout=10 includeruntime=yes
classespath refid=example-classes.id/
/jdepend
/target
/project
1.26 +106 -25
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
Index: JDependTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- JDependTask.java 3 Nov 2003 15:22:28 - 1.25
+++ JDependTask.java 3 Nov 2003 15:34:13 - 1.26
@@ -61,6 +61,7 @@
import java.lang.reflect.Constructor;
import java.lang.reflect.Method;
import java.util.Vector;
+import java.util.Enumeration;
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.Task;
@@ -73,6 +74,7 @@
import org.apache.tools.ant.types.Path;
import org.apache.tools.ant.types.PatternSet;
import org.apache.tools.ant.types.Reference;
+import org.apache.tools.ant.util.LoaderUtils;
/**
* Runs JDepend tests.
@@ -99,7 +101,7 @@
private Path compileClasspath;
private boolean haltonerror = false;
private boolean fork = false;
-//private Integer _timeout = null;
+private Long timeout = null;
private String jvm = null;
private String format = text;
@@ -108,6 +110,9 @@
private static Constructor packageFilterC;
private static Method setFilter;
+private boolean includeRuntime = false;
+private Path runtimeClasses = null;
+
static {
try {
Class packageFilter =
@@ -124,15 +129,36 @@
}
}
-/*
- public void setTimeout(Integer value) {
- _timeout = value;
- }
-
- public Integer getTimeout() {
- return _timeout;
- }
-*/
+/**
+ * If true,
+ * include jdepend.jar in the forked VM.
+ *
+ * @param b include ant run time yes or no
+ * @since Ant 1.6
+ */
+public void
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/jdepend JDependTest.java
peterreilly2003/11/03 07:45:11
Modified:docs/manual/OptionalTasks Tag: ANT_16_BRANCH jdepend.html
src/main/org/apache/tools/ant/taskdefs/optional/jdepend Tag:
ANT_16_BRANCH JDependTask.java
Added: src/etc/testcases/taskdefs/optional/jdepend Tag:
ANT_16_BRANCH jdepend.xml
src/testcases/org/apache/tools/ant/taskdefs/optional/jdepend
Tag: ANT_16_BRANCH JDependTest.java
Log:
sync with HEAD
Revision ChangesPath
No revision
No revision
1.10.2.2 +6 -0 ant/docs/manual/OptionalTasks/jdepend.html
Index: jdepend.html
===
RCS file: /home/cvs/ant/docs/manual/OptionalTasks/jdepend.html,v
retrieving revision 1.10.2.1
retrieving revision 1.10.2.2
diff -u -r1.10.2.1 -r1.10.2.2
--- jdepend.html 9 Oct 2003 21:01:12 - 1.10.2.1
+++ jdepend.html 3 Nov 2003 15:45:10 - 1.10.2.2
@@ -73,6 +73,12 @@
td ALIGN=CENTER VALIGN=TOPNo/td
/tr
tr
+td VALIGN=TOPincluderuntime/td
+td VALIGN=TOPImplicitly add the classes required to run jdepend
+in forked mode. (Ignored if fork is disabled). Since ant 1.6./td
+td ALIGN=CENTER VALIGN=TOPNo, default is no./td
+ /tr
+ tr
td VALIGN=TOPclasspathref/td
td VALIGN=TOPthe classpath to use, given as reference to a PATH
defined elsewhere./td
td ALIGN=CENTER VALIGN=TOPNo/td
No revision
No revision
1.1.2.1 +0 -0
ant/src/etc/testcases/taskdefs/optional/jdepend/jdepend.xml
Index: jdepend.xml
===
RCS file:
/home/cvs/ant/src/etc/testcases/taskdefs/optional/jdepend/jdepend.xml,v
retrieving revision 1.1
retrieving revision 1.1.2.1
diff -u -r1.1 -r1.1.2.1
No revision
No revision
1.22.2.2 +197 -71
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
Index: JDependTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
retrieving revision 1.22.2.1
retrieving revision 1.22.2.2
diff -u -r1.22.2.1 -r1.22.2.2
--- JDependTask.java 3 Nov 2003 15:23:57 - 1.22.2.1
+++ JDependTask.java 3 Nov 2003 15:45:11 - 1.22.2.2
@@ -61,6 +61,7 @@
import java.lang.reflect.Constructor;
import java.lang.reflect.Method;
import java.util.Vector;
+import java.util.Enumeration;
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.Task;
@@ -73,6 +74,7 @@
import org.apache.tools.ant.types.Path;
import org.apache.tools.ant.types.PatternSet;
import org.apache.tools.ant.types.Reference;
+import org.apache.tools.ant.util.LoaderUtils;
/**
* Runs JDepend tests.
@@ -90,24 +92,27 @@
//private CommandlineJava commandline = new CommandlineJava();
// required attributes
-private Path _sourcesPath; // Deprecated!
-private Path _classesPath; // Use this going forward
+private Path sourcesPath; // Deprecated!
+private Path classesPath; // Use this going forward
// optional attributes
-private File _outputFile;
-private File _dir;
-private Path _compileClasspath;
-private boolean _haltonerror = false;
-private boolean _fork = false;
-//private Integer _timeout = null;
+private File outputFile;
+private File dir;
+private Path compileClasspath;
+private boolean haltonerror = false;
+private boolean fork = false;
+private Long timeout = null;
-private String _jvm = null;
+private String jvm = null;
private String format = text;
private PatternSet defaultPatterns = new PatternSet();
private static Constructor packageFilterC;
private static Method setFilter;
+private boolean includeRuntime = false;
+private Path runtimeClasses = null;
+
static {
try {
Class packageFilter =
@@ -124,54 +129,83 @@
}
}
-public JDependTask() {
+/**
+ * If true,
+ * include jdepend.jar in the forked VM.
+ *
+ * @param b include ant run time yes or no
+ * @since Ant 1.6
+ */
+public void setIncluderuntime(boolean b) {
+includeRuntime = b;
+}
+
+/**
+ * Set the timeout value (in milliseconds).
+ *
+ * pIf the operation is running for more than this value, the jdepend
+ * will be canceled. (works only when in 'fork' mode)./p
+ * @param value the maximum time (in milliseconds) allowed before
+ *
cvs commit: ant/src/main/org/apache/tools/ant/helper ProjectHelper2.java
bodewig 2003/11/03 07:47:30
Modified:src/main/org/apache/tools/ant/helper ProjectHelper2.java
Log:
Improve error message
Revision ChangesPath
1.35 +6 -4
ant/src/main/org/apache/tools/ant/helper/ProjectHelper2.java
Index: ProjectHelper2.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/helper/ProjectHelper2.java,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -r1.34 -r1.35
--- ProjectHelper2.java 20 Oct 2003 14:13:40 - 1.34
+++ ProjectHelper2.java 3 Nov 2003 15:47:30 - 1.35
@@ -268,11 +268,13 @@
} catch (FileNotFoundException exc) {
throw new BuildException(exc);
} catch (UnsupportedEncodingException exc) {
- throw new BuildException(Encoding of project file is
invalid.,
-exc);
+ throw new BuildException(Encoding of project file
+ + buildFileName + is invalid.,
+ exc);
} catch (IOException exc) {
-throw new BuildException(Error reading project file:
-+ exc.getMessage(), exc);
+throw new BuildException(Error reading project file
+ + buildFileName + : +
exc.getMessage(),
+ exc);
} finally {
if (inputStream != null) {
try {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24344] - NPE in JDependTask if forked
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24344. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24344 NPE in JDependTask if forked --- Additional Comments From [EMAIL PROTECTED] 2003-11-03 15:47 --- Also fixed is the timeout attribute which was previously ignored. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/helper ProjectHelper2.java
bodewig 2003/11/03 07:48:24
Modified:src/main/org/apache/tools/ant/helper Tag: ANT_16_BRANCH
ProjectHelper2.java
Log:
Merge from HEAD
Revision ChangesPath
No revision
No revision
1.33.2.2 +6 -4
ant/src/main/org/apache/tools/ant/helper/ProjectHelper2.java
Index: ProjectHelper2.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/helper/ProjectHelper2.java,v
retrieving revision 1.33.2.1
retrieving revision 1.33.2.2
diff -u -r1.33.2.1 -r1.33.2.2
--- ProjectHelper2.java 20 Oct 2003 14:18:35 - 1.33.2.1
+++ ProjectHelper2.java 3 Nov 2003 15:48:24 - 1.33.2.2
@@ -268,11 +268,13 @@
} catch (FileNotFoundException exc) {
throw new BuildException(exc);
} catch (UnsupportedEncodingException exc) {
- throw new BuildException(Encoding of project file is
invalid.,
-exc);
+ throw new BuildException(Encoding of project file
+ + buildFileName + is invalid.,
+ exc);
} catch (IOException exc) {
-throw new BuildException(Error reading project file:
-+ exc.getMessage(), exc);
+throw new BuildException(Error reading project file
+ + buildFileName + : +
exc.getMessage(),
+ exc);
} finally {
if (inputStream != null) {
try {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Misleading error reporting with imports
On Tue, 21 Oct 2003, Dominique Devienne [EMAIL PROTECTED] wrote: The error message doesn't specify which build file failed to parse correctly, I think it did, as the message must have come from an IOException, so the error actually is in recurse.xml not in the file it is trying to import. At least I think so. It will now tell you which file/URL caused the exception, though. and furthermore, the error is reported to occur in recurse.xml, never mentioning that recurse.xml was in fact imported from build.xml or at which line. This is a bit harder to track down and put into the error message, I'm afraid. Currently we don't keep track of that at all AFAICS, we only record that a file has been imported, but not from where. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Misleading error reporting with imports
From: Stefan Bodewig [mailto:[EMAIL PROTECTED] On Tue, 21 Oct 2003, Dominique Devienne [EMAIL PROTECTED] wrote: The error message doesn't specify which build file failed to parse correctly, I think it did, as the message must have come from an IOException, so the error actually is in recurse.xml not in the file it is trying to import. At least I think so. No, really Stefan! recurse.xml was doing a subant on rescue.xml, and it's rescue.xml which failed to parse (like I said, because rescue.xml was doing an entity include of a URI using a custom URL protocol not enabled during this run. FTR, I was replacing entity include using that protocol with import). So Filters.xml was importing recurse.xml recurse.xml was subant'ing rescue.xml rescue.xml failed to parse because of the entity include (see above) And *still* the error messages never mentioned that *rescue.xml* failed to parse, and simply reported on IOException in recurse.xml, never mentioning as well that recurse.xml was itself imported by Filters.xml. I don't know what layer is at fault here, but the proper error should have reported that rescue.xml failed to parse, from subant at line XYZ in recurse.xml, imported from Filters.xml at line ABC. Without this kind of clear and detailed error report, import and [sub]ant will not mix happily! and furthermore, the error is reported to occur in recurse.xml, never mentioning that recurse.xml was in fact imported from build.xml or at which line. This is a bit harder to track down and put into the error message, I'm afraid. Currently we don't keep track of that at all AFAICS, we only record that a file has been imported, but not from where. As I said above, I think it's absolutely necessary Ant does this! --DD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs ImportTest.java
peterreilly2003/11/03 08:36:19
Modified:src/main/org/apache/tools/ant/taskdefs ImportTask.java
src/testcases/org/apache/tools/ant/taskdefs ImportTest.java
Added: src/etc/testcases/taskdefs/import bad.xml
import_bad_import.xml
Log:
make error message for bad imports a little better
When an buildexception is reported in the imported xml, add the importer
xml file to the build exception
Revision ChangesPath
1.1 ant/src/etc/testcases/taskdefs/import/bad.xml
Index: bad.xml
===
project
/project
1.1
ant/src/etc/testcases/taskdefs/import/import_bad_import.xml
Index: import_bad_import.xml
===
project
import file=bad.xml/
/project
1.20 +14 -1
ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java
Index: ImportTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- ImportTask.java 3 Nov 2003 10:14:49 - 1.19
+++ ImportTask.java 3 Nov 2003 16:36:19 - 1.20
@@ -55,6 +55,7 @@
package org.apache.tools.ant.taskdefs;
import org.apache.tools.ant.BuildException;
+import org.apache.tools.ant.Location;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.ProjectHelper;
import org.apache.tools.ant.Task;
@@ -179,7 +180,19 @@
return;
}
-helper.parse(getProject(), importedFile);
+try {
+helper.parse(getProject(), importedFile);
+} catch (BuildException ex) {
+Location exLocation = ex.getLocation();
+if (exLocation == null) {
+throw ex;
+}
+throw new BuildException(
+Error executing import file
++ System.getProperty(line.separator)
++ exLocation.toString()
++ + ex.getMessage());
+}
}
private static String getPath(File file) {
1.7 +24 -0
ant/src/testcases/org/apache/tools/ant/taskdefs/ImportTest.java
Index: ImportTest.java
===
RCS file:
/home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/ImportTest.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ImportTest.java 19 Sep 2003 09:36:22 - 1.6
+++ ImportTest.java 3 Nov 2003 16:36:19 - 1.7
@@ -54,7 +54,9 @@
package org.apache.tools.ant.taskdefs;
+import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.BuildFileTest;
+import org.apache.tools.ant.Location;
import org.apache.tools.ant.Project;
/**
@@ -118,6 +120,28 @@
src/etc/testcases/taskdefs/import/subdir/importinsequential.xml);
expectPropertySet(within-imported, foo, bar);
assertNotNull(getProject().getReference(baz));
+}
+
+public void testImportError() {
+try {
+configureProject(
+src/etc/testcases/taskdefs/import/import_bad_import.xml);
+} catch (BuildException ex) {
+Location lo = ex.getLocation();
+assertTrue(
+expected location of build exception to be set,
+(lo != null));
+assertTrue(
+expected location to contain calling file,
+lo.getFileName().indexOf(import_bad_import.xml) != -1);
+assertTrue(
+expected message of ex to contain called file,
+ex.getMessage().indexOf(bad.xml) != -1);
+return;
+}
+assertTrue(
+Did not see build exception,
+false);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs ImportTest.java
peterreilly2003/11/03 08:39:34
Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
ImportTask.java
src/testcases/org/apache/tools/ant/taskdefs Tag:
ANT_16_BRANCH ImportTest.java
Added: src/etc/testcases/taskdefs/import Tag: ANT_16_BRANCH bad.xml
import_bad_import.xml
Log:
Sync with HEAD
Revision ChangesPath
No revision
No revision
1.1.2.1 +0 -0 ant/src/etc/testcases/taskdefs/import/bad.xml
Index: bad.xml
===
RCS file: /home/cvs/ant/src/etc/testcases/taskdefs/import/bad.xml,v
retrieving revision 1.1
retrieving revision 1.1.2.1
diff -u -r1.1 -r1.1.2.1
1.1.2.1 +0 -0
ant/src/etc/testcases/taskdefs/import/import_bad_import.xml
Index: import_bad_import.xml
===
RCS file:
/home/cvs/ant/src/etc/testcases/taskdefs/import/import_bad_import.xml,v
retrieving revision 1.1
retrieving revision 1.1.2.1
diff -u -r1.1 -r1.1.2.1
No revision
No revision
1.16.2.4 +14 -1
ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java
Index: ImportTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java,v
retrieving revision 1.16.2.3
retrieving revision 1.16.2.4
diff -u -r1.16.2.3 -r1.16.2.4
--- ImportTask.java 3 Nov 2003 10:16:38 - 1.16.2.3
+++ ImportTask.java 3 Nov 2003 16:39:34 - 1.16.2.4
@@ -55,6 +55,7 @@
package org.apache.tools.ant.taskdefs;
import org.apache.tools.ant.BuildException;
+import org.apache.tools.ant.Location;
import org.apache.tools.ant.Project;
import org.apache.tools.ant.ProjectHelper;
import org.apache.tools.ant.Task;
@@ -179,7 +180,19 @@
return;
}
-helper.parse(getProject(), importedFile);
+try {
+helper.parse(getProject(), importedFile);
+} catch (BuildException ex) {
+Location exLocation = ex.getLocation();
+if (exLocation == null) {
+throw ex;
+}
+throw new BuildException(
+Error executing import file
++ System.getProperty(line.separator)
++ exLocation.toString()
++ + ex.getMessage());
+}
}
private static String getPath(File file) {
No revision
No revision
1.6.2.1 +24 -0
ant/src/testcases/org/apache/tools/ant/taskdefs/ImportTest.java
Index: ImportTest.java
===
RCS file:
/home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/ImportTest.java,v
retrieving revision 1.6
retrieving revision 1.6.2.1
diff -u -r1.6 -r1.6.2.1
--- ImportTest.java 19 Sep 2003 09:36:22 - 1.6
+++ ImportTest.java 3 Nov 2003 16:39:34 - 1.6.2.1
@@ -54,7 +54,9 @@
package org.apache.tools.ant.taskdefs;
+import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.BuildFileTest;
+import org.apache.tools.ant.Location;
import org.apache.tools.ant.Project;
/**
@@ -118,6 +120,28 @@
src/etc/testcases/taskdefs/import/subdir/importinsequential.xml);
expectPropertySet(within-imported, foo, bar);
assertNotNull(getProject().getReference(baz));
+}
+
+public void testImportError() {
+try {
+configureProject(
+src/etc/testcases/taskdefs/import/import_bad_import.xml);
+} catch (BuildException ex) {
+Location lo = ex.getLocation();
+assertTrue(
+expected location of build exception to be set,
+(lo != null));
+assertTrue(
+expected location to contain calling file,
+lo.getFileName().indexOf(import_bad_import.xml) != -1);
+assertTrue(
+expected message of ex to contain called file,
+ex.getMessage().indexOf(bad.xml) != -1);
+return;
+}
+assertTrue(
+Did not see build exception,
+false);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Misleading error reporting with imports
I had the same problem with antlib. I have now copied the logic from antlib to import, so build exceptions during import parsing should now report the imported and importing files in an emacs friendly form. BUILD FAILED /home/preilly/cvs/ant/src/etc/testcases/taskdefs/import/import_bad_import.xml:2: Error executing import file /home/preilly/cvs/ant/src/etc/testcases/taskdefs/import/bad.xml:2: The content of elements must consist of well-formed character data or markup. Where import_bad_import.xml is: project import file=bad.xml/ /project and bad.xml is: project /project Peter On Monday 03 November 2003 16:06, Dominique Devienne wrote: From: Stefan Bodewig [mailto:[EMAIL PROTECTED] On Tue, 21 Oct 2003, Dominique Devienne [EMAIL PROTECTED] wrote: The error message doesn't specify which build file failed to parse correctly, I think it did, as the message must have come from an IOException, so the error actually is in recurse.xml not in the file it is trying to import. At least I think so. No, really Stefan! recurse.xml was doing a subant on rescue.xml, and it's rescue.xml which failed to parse (like I said, because rescue.xml was doing an entity include of a URI using a custom URL protocol not enabled during this run. FTR, I was replacing entity include using that protocol with import). So Filters.xml was importing recurse.xml recurse.xml was subant'ing rescue.xml rescue.xml failed to parse because of the entity include (see above) And *still* the error messages never mentioned that *rescue.xml* failed to parse, and simply reported on IOException in recurse.xml, never mentioning as well that recurse.xml was itself imported by Filters.xml. I don't know what layer is at fault here, but the proper error should have reported that rescue.xml failed to parse, from subant at line XYZ in recurse.xml, imported from Filters.xml at line ABC. Without this kind of clear and detailed error report, import and [sub]ant will not mix happily! and furthermore, the error is reported to occur in recurse.xml, never mentioning that recurse.xml was in fact imported from build.xml or at which line. This is a bit harder to track down and put into the error message, I'm afraid. Currently we don't keep track of that at all AFAICS, we only record that a file has been imported, but not from where. As I said above, I think it's absolutely necessary Ant does this! --DD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Misleading error reporting with imports
[EMAIL PROTECTED] tmp]$ ant -f import_import_import_bad_import.xml Buildfile: import_import_import_bad_import.xml BUILD FAILED /tmp/import_import_import_bad_import.xml:2: Error executing import file /tmp/import_import_bad_import.xml:2: Error executing import file /tmp/import_bad_import.xml:2: Error executing import file /tmp/bad.xml:2: The content of elements must consist of well-formed character data or markup. Total time: 0 seconds ;-) Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Misleading error reporting with imports
On Mon, 3 Nov 2003, Dominique Devienne [EMAIL PROTECTED] wrote: From: Stefan Bodewig [mailto:[EMAIL PROTECTED] On Tue, 21 Oct 2003, Dominique Devienne [EMAIL PROTECTED] wrote: The error message doesn't specify which build file failed to parse correctly, I think it did, as the message must have come from an IOException, so the error actually is in recurse.xml not in the file it is trying to import. At least I think so. No, really Stefan! recurse.xml was doing a subant on rescue.xml, and it's rescue.xml which failed to parse (like I said, because rescue.xml was doing an entity include of a URI using a custom URL protocol not enabled during this run. Well, as it was an IOException, I expected it to be a problem with the importing file. I would expect a SAX exception if it was in the imported one. But an invalid URL may result in IOExceptions, of course. Sorry Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Misleading error reporting with imports
This is the way antlib works I suppose it would be better to do /tmp/bad.xml:2: The content of elements must consist of well-formed character data or markup. Imported by /tmp/import_bad_import.xml:2: Imported by /tmp/import_import_bad_import.xml:2: Putting the filename at the start of the line allows emacs next-error (and other error detection ides using emacs style errors) to locate the file (s). Peter On Monday 03 November 2003 16:51, Stefan Bodewig wrote: [EMAIL PROTECTED] tmp]$ ant -f import_import_import_bad_import.xml Buildfile: import_import_import_bad_import.xml BUILD FAILED /tmp/import_import_import_bad_import.xml:2: Error executing import file /tmp/import_import_bad_import.xml:2: Error executing import file /tmp/import_bad_import.xml:2: Error executing import file /tmp/bad.xml:2: The content of elements must consist of well-formed character data or markup. Total time: 0 seconds ;-) Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Misleading error reporting with imports
On Monday 03 November 2003 16:51, Stefan Bodewig wrote: [EMAIL PROTECTED] tmp]$ ant -f import_import_import_bad_import.xml Buildfile: import_import_import_bad_import.xml BUILD FAILED /tmp/import_import_import_bad_import.xml:2: Error executing import file /tmp/import_import_bad_import.xml:2: Error executing import file /tmp/import_bad_import.xml:2: Error executing import file /tmp/bad.xml:2: The content of elements must consist of well-formed character data or markup. Total time: 0 seconds ;-) Is this ok? Also should I do this for [sub]ant[call] ? Peter Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Misleading error reporting with imports
From: peter reilly [mailto:[EMAIL PROTECTED] On Monday 03 November 2003 16:51, Stefan Bodewig wrote: [EMAIL PROTECTED] tmp]$ ant -f import_import_import_bad_import.xml Buildfile: import_import_import_bad_import.xml BUILD FAILED /tmp/import_import_import_bad_import.xml:2: Error executing import file /tmp/import_import_bad_import.xml:2: Error executing import file /tmp/import_bad_import.xml:2: Error executing import file /tmp/bad.xml:2: The content of elements must consist of well-formed character data or markup. Total time: 0 seconds ;-) Is this ok? Also should I do this for [sub]ant[call] ? It's like to see it for ant and subant. antcall, I'm not sure. --DD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24359] New: - add listfiles to rmic
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24359. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24359 add listfiles to rmic Summary: add listfiles to rmic Product: Ant Version: 1.6Beta Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] add listfiles attribute (like javac has) to rmic task - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Msbuild
Stefan Bodewig wrote: On Fri, 31 Oct 2003, Steve Loughran [EMAIL PROTECTED] wrote: Stefan Bodewig wrote: MSBuild uses $() for its properties and @() for something else - probably Item references at first glance. -where is the docs for that? Follow the official information link in http://stefanbodewig.blogger.de/stories/9155/. Judging from you blog, you've found it by now. The nant-dev list is very interesting right now. 8-) I've had a closer look into the docs last weekend and will talk about the Item and task input/output stuff later. yes, I even have the PDC DVD set a few metres away, should I chose to dedicate some time to bringing it up in a vmware installation. I must say it is the first time any project I've worked on has been cloned by microsoft to become a strategic offering of theirs. I also think they may have a better list/set model than Ant's, which doesn't really have anything consistent at all, just FileList, FileSet, and many other task-specific lists. I do think a bit of credit to the ant and nant teams would have been polite -from a colleague who was at the MSBuild session, we didnt merit a mention. Sigh. -Steve - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24364] New: - Javadoc task link attribute should be relative to basedir
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24364. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24364 Javadoc task link attribute should be relative to basedir Summary: Javadoc task link attribute should be relative to basedir Product: Ant Version: 1.5.4 Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The Javadoc task should take the value of its link attribute relative to the base directory rather than the Javadoc destination directory. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24366] New: - Project tag basedir attribute should be relative to ${user.dir} (the user's current working directory)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366
Project tag basedir attribute should be relative to ${user.dir} (the user's
current working directory)
Summary: Project tag basedir attribute should be relative to
${user.dir} (the user's current working directory)
Product: Ant
Version: 1.5.4
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: Other
Component: Core
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
I don't understand why the basedir is taken relative to the location of the
build script. Who cares where the build script is?
The work around, of course, is to set a property ${base} to ${user.dir} and
prefix all directory references with ${base}/ but it kinda defeats the purpose
of basedir.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24366] - Project tag basedir attribute should be relative to ${user.dir} (the user's current working directory)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366
Project tag basedir attribute should be relative to ${user.dir} (the user's
current working directory)
--- Additional Comments From [EMAIL PROTECTED] 2003-11-03 22:11 ---
Most projects using Ant put the build file at the top of the project, and refer
relatively to basedir for find project-related things, like the src directory.
This makes the build free of any absolute path, and thus location independent.
If you want to use ${user.dir}, then prefix all your properties with it.
basedir will always point to the directory the build script is in, because it's
very convenient, and because it's what all Ant users expect. --DD
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24367] New: - Fileset exclude in zip task does not exclude ./*
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24367. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24367 Fileset exclude in zip task does not exclude ./* Summary: Fileset exclude in zip task does not exclude ./* Product: Ant Version: 1.5.4 Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I'm trying to use exclude name=./*.zip/ to prevent the zip task from trying to zip up the target file. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24366] - Project tag basedir attribute should be relative to ${user.dir} (the user's current working directory)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366
Project tag basedir attribute should be relative to ${user.dir} (the user's
current working directory)
--- Additional Comments From [EMAIL PROTECTED] 2003-11-03 22:28 ---
On the contrary, this behaviour makes the build script location *dependent*, as
you cannot use -buildfile to choose an arbitary location for the build script.
The build script location must always be in the same location relative to the
project (e.g. the project root). In using shell commands, it is customary to
specify everything relative to the user's current working directory, but ant
makes up its own rules in this regard.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24366] - Project tag basedir attribute should be relative to ${user.dir} (the user's current working directory)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366
Project tag basedir attribute should be relative to ${user.dir} (the user's
current working directory)
--- Additional Comments From [EMAIL PROTECTED] 2003-11-03 22:33 ---
Sounds like you have this all figured out, and the Ant community at large has
been wrong all along then... Oh well, I can live with that ;-)
Arbitrary location for a build file??? Hmmm, do you work with source control?
Once under source control, files are not in an arbitrary location.
Anyways, that's the way Ant works, and it's likely that will stay this way. We
should all accept the fact, and move on. --DD
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24366] - Project tag basedir attribute should be relative to ${user.dir} (the user's current working directory)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24366
Project tag basedir attribute should be relative to ${user.dir} (the user's
current working directory)
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution||WONTFIX
--- Additional Comments From [EMAIL PROTECTED] 2003-11-03 23:49 ---
I think I see what you are trying to do -make a reusable build file that you can
invoke from anywhere. If that is what you want, you are going to have to prefix
all your paths, or look at (2) below.
Now, here is why the current policy generally makes sense.
1. using ant to invoke an existing project in a subdir; you dont want it to
work on the parent dir, but on its sub directory -without editing the build file
at all.
2. using ant for reusable code, just set the dir attr on the task and you can
direct it anywhere.
3. ant -f will find a build file up the tree. This is useful if you are deep in
the source tree; ant -f build.xml will find the containing build file and exec
it from its base dir.
4. IDE invocation - the current dir is often where the IDE started, not where
the project.
Marking as Wontfix as (a) I dont believe the arguments make sense apart from one
specialised case, and (b) I dont want to break every single build file on the
planet.
On the issue of ant being incompatible with shell scripts, well, ant is not a
scripting language. It is a means of declaring what needs to be done to build a
software project. The more you stray from its core functionality, the more its
design decisions make less sense. But by and large, they have some rationality
behind them, apart from the odd exception.
One thing that may make sense would be a new way of invoking build files, one
that sets the base dir to the current dir. That would just be another command
line option and would break nothing. Please, feel free to implement this if you
think your needs are broad enough to merit it.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
