date:20170529

[GitHub] ant-ivy issue #34: Fix IVY-1528

2017-05-29 Thread jaikiran

Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/34
  
>> we dont use @author

Fixed - removed that tag. I will setup my IDE accordingly.

>> TestXmlHelper
-- if xPathExpression would be a String and the method compiles that for 
itself,
reuse would be easier

Done

>> -- XmlHelper would be a better name, because does not work only on tests.

For now I wanted that class to stay just for the tests usage, since it's 
currently not used/required in other places. I can move it to the non-test 
source package if you prefer and rename it to XmlHelper.

>> -- result could be inlined

Done

>> IvyMakePomTest#testClassifier()
-- you dont use expectedPomArtifactIds for assertions. Do you want to check
emptyness after the loop?

Good catch. Fixed.

The PR has been updated with these changes. Let me know if there's any 
other changes that you recommend.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #36: Replace emma with jacoco

2017-05-29 Thread twogee

GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/36

Replace emma with jacoco

This modernises the reporting of code coverage.
Please try it out.
NB! On macOS, it tickles https://bugs.openjdk.java.net/browse/JDK-8022291
which is harmless, currently slated for fix in JDK9

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit cf6bbf5f9b1351a9a8ac08b12c44b4fad4659f50
Author: twogee 
Date:   2017-05-29T19:08:43Z

Replace emma with jacoco




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Replace emma with jacoco?

2017-05-29 Thread Gintautas Grigelionis

Both Jacoco and Clover fit that bill. Are you comfortable with eventul
change in test and test-report targets?

Gintas

2017-05-29 17:40 GMT+02:00 Nicolas Lalevée :

> FYI, here are the post build actions available on the Jenkins at the ASF:
> https://www.dropbox.com/s/zwpersrv4ydzdp5/Capture%20d%
> 27%C3%A9cran%202017-05-29%2017.36.49.png?dl=0  zwpersrv4ydzdp5/Capture%20d'%C3%A9cran%202017-05-29%2017.36.49.png?dl=0>
>
> It would be nice if the tool we choose is integrated in our CI.
>
> Nicolas
>
> > Le 29 mai 2017 à 17:29, Matt Sicker  a écrit :
> >
> > I've used pitest  before which is a bit more useful
> > than typical code coverage plugins.
> >
> > On 29 May 2017 at 08:55, Martin Gainty  wrote:
> >
> >>
> >>
> >>
> >> 
> >> From: Gintautas Grigelionis 
> >> Sent: Monday, May 29, 2017 9:50 AM
> >> To: Ant Developers List
> >> Subject: Re: Replace emma with jacoco?
> >>
> >> Talk about timing, again :-) -- Clover has been open source since April.
> >> BTW, the documentation has moved to https://atlassian-docs.
> bitbucket.io/,
> >> Atlassian documentation
> >> atlassian-docs.bitbucket.io
> >> The documentation in this repository is for products that are no longer
> >> supported by Atlassian. This documentation is not maintained by
> Atlassian,
> >> but is open source ...
> >>
> >>
> >>
> >> so confluence.atlassian.com links do not work any more.
> >>
> >> I can try adding both Jacoco and Clover and make instrumentation
> selectable
> >> through a property.
> >> I am inclined to start with Jacoco due to personal experience and keep
> it a
> >> default choice.
> >>
> >> The bigger change would be that "ant test" would run both
> instrumentation
> >> and unit tests, and likewise "ant test-report" would produce both
> reports.
> >> MG>an excellent idea..my personal request is which code-coverage tool
> >> detects orphaned class ?
> >> MG>a second request is which code coverage detects orphaned
> inner-classes?
> >> MG>i look forward to receiving your analysis
> >>
> >> Gintas
> >>
> >> 2017-05-29 0:58 GMT+02:00 Martin Gainty :
> >>
> >>> Hi Gintautas
> >>>
> >>>
> >>> clover code-coverage has been around for 15 years..atlassian just
> >>> contributed clover to Open Source this year
> >>>
> >>> https://www.atlassian.com/blog/announcements/atlassian-
> >> clover-open-source
> >> Atlassian Clover is now open source - Atlassian Blog<
> >> https://www.atlassian.com/blog/announcements/atlassian-
> clover-open-source>
> >> www.atlassian.com
> >> All of this has lead to our decision to open source Clover, what we
> >> believe is the best way to give Clover the focus and attention it
> deserves.
> >>
> >>
> >>
> >>>
> >>> Atlassian Clover is now open source - Atlassian Blog<
> >>> https://www.atlassian.com/blog/announcements/atlassian-
> >> clover-open-source>
> >> Atlassian Clover is now open source - Atlassian Blog<
> >> https://www.atlassian.com/blog/announcements/atlassian-
> clover-open-source>
> >> www.atlassian.com
> >> All of this has lead to our decision to open source Clover, what we
> >> believe is the best way to give Clover the focus and attention it
> deserves.
> >>
> >>
> >>
> >>> www.atlassian.com
> >> [https://wac-cdn-a.atlassian.com/dam/jcr:c20cf6d1-9568-
> >> 4aba-9a16-dba24e1495de/atlassian-software.png] /www.atlassian.com/>
> >>
> >> Atlassian | Software Development and Collaboration Tools<
> >> http://www.atlassian.com/>
> >> www.atlassian.com
> >> Millions of users globally rely on Atlassian products every day for
> >> improving software development, project management, collaboration, and
> code
> >> quality.
> >>
> >>
> >>
> >>> All of this has lead to our decision to open source Clover, what we
> >>> believe is the best way to give Clover the focus and attention it
> >> deserves.
> >>>
> >>> Atlassian published an ant taskdef here
> >>>
> >>> https://confluence.atlassian.com/clover/6-ant-task-
> >> reference-71600066.html
> >> 6. Ant Task Reference - Atlassian Documentation >> confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> >> confluence.atlassian.com
> >> Can I create a Clover Report on Server A if I have the clover.db which I
> >> generated on Server B? Does Clover depend on JUnit? Does Clover
> integrate
> >> with Maven?
> >>
> >>
> >>
> >>>
> >>> 6. Ant Task Reference - Atlassian Documentation >>> confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> >>> confluence.atlassian.com
> >>> Can I create a Clover Report on Server A if I have the clover.db which
> I
> >>> generated on Server B? Does Clover depend on JUnit? Does Clover
> integrate
> >>> with Maven?
> >>>
> >>> emma hasnt been touched in 12 years so it seems to be retired?
> >>>
> >>>

Re: Replace emma with jacoco?

2017-05-29 Thread Gintautas Grigelionis

There's definitely space for improvement, but currently I'm content with an
equivalent of what no longer works, in this case, a code coverage tool.

Gintas

2017-05-29 17:29 GMT+02:00 Matt Sicker :

> I've used pitest  before which is a bit more useful
> than typical code coverage plugins.
>
> On 29 May 2017 at 08:55, Martin Gainty  wrote:
>
> >
> >
> >
> > 
> > From: Gintautas Grigelionis 
> > Sent: Monday, May 29, 2017 9:50 AM
> > To: Ant Developers List
> > Subject: Re: Replace emma with jacoco?
> >
> > Talk about timing, again :-) -- Clover has been open source since April.
> > BTW, the documentation has moved to https://atlassian-docs.bitbucket.io/
> ,
> > Atlassian documentation
> > atlassian-docs.bitbucket.io
> > The documentation in this repository is for products that are no longer
> > supported by Atlassian. This documentation is not maintained by
> Atlassian,
> > but is open source ...
> >
> >
> >
> > so confluence.atlassian.com links do not work any more.
> >
> > I can try adding both Jacoco and Clover and make instrumentation
> selectable
> > through a property.
> > I am inclined to start with Jacoco due to personal experience and keep
> it a
> > default choice.
> >
> > The bigger change would be that "ant test" would run both instrumentation
> > and unit tests, and likewise "ant test-report" would produce both
> reports.
> > MG>an excellent idea..my personal request is which code-coverage tool
> > detects orphaned class ?
> > MG>a second request is which code coverage detects orphaned
> inner-classes?
> > MG>i look forward to receiving your analysis
> >
> > Gintas
> >
> > 2017-05-29 0:58 GMT+02:00 Martin Gainty :
> >
> > > Hi Gintautas
> > >
> > >
> > > clover code-coverage has been around for 15 years..atlassian just
> > > contributed clover to Open Source this year
> > >
> > > https://www.atlassian.com/blog/announcements/atlassian-
> > clover-open-source
> > Atlassian Clover is now open source - Atlassian Blog<
> > https://www.atlassian.com/blog/announcements/atlassian-
> clover-open-source>
> > www.atlassian.com
> > All of this has lead to our decision to open source Clover, what we
> > believe is the best way to give Clover the focus and attention it
> deserves.
> >
> >
> >
> > >
> > > Atlassian Clover is now open source - Atlassian Blog<
> > > https://www.atlassian.com/blog/announcements/atlassian-
> > clover-open-source>
> > Atlassian Clover is now open source - Atlassian Blog<
> > https://www.atlassian.com/blog/announcements/atlassian-
> clover-open-source>
> > www.atlassian.com
> > All of this has lead to our decision to open source Clover, what we
> > believe is the best way to give Clover the focus and attention it
> deserves.
> >
> >
> >
> > > www.atlassian.com
> > [https://wac-cdn-a.atlassian.com/dam/jcr:c20cf6d1-9568-
> > 4aba-9a16-dba24e1495de/atlassian-software.png] >
> >
> > Atlassian | Software Development and Collaboration Tools<
> > http://www.atlassian.com/>
> > www.atlassian.com
> > Millions of users globally rely on Atlassian products every day for
> > improving software development, project management, collaboration, and
> code
> > quality.
> >
> >
> >
> > > All of this has lead to our decision to open source Clover, what we
> > > believe is the best way to give Clover the focus and attention it
> > deserves.
> > >
> > > Atlassian published an ant taskdef here
> > >
> > > https://confluence.atlassian.com/clover/6-ant-task-
> > reference-71600066.html
> > 6. Ant Task Reference - Atlassian Documentation > confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> > confluence.atlassian.com
> > Can I create a Clover Report on Server A if I have the clover.db which I
> > generated on Server B? Does Clover depend on JUnit? Does Clover integrate
> > with Maven?
> >
> >
> >
> > >
> > > 6. Ant Task Reference - Atlassian Documentation > > confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> > > confluence.atlassian.com
> > > Can I create a Clover Report on Server A if I have the clover.db which
> I
> > > generated on Server B? Does Clover depend on JUnit? Does Clover
> integrate
> > > with Maven?
> > >
> > > emma hasnt been touched in 12 years so it seems to be retired?
> > >
> > > http://emma.sourceforge.net/
> > EMMA: a free Java code coverage tool
> > emma.sourceforge.net
> > EMMA can instrument classes for coverage either offline (before they are
> > loaded) or on the fly (using an instrumenting application classloader).
> >
> >
> >
> > >
> > > EMMA: a free Java code coverage tool
> > EMMA: a free Java code coverage tool
> > emma.sourceforge.net
> > EMMA can instrument classes for coverage either offline (before

Re: Replace emma with jacoco?

2017-05-29 Thread Nicolas Lalevée

FYI, here are the post build actions available on the Jenkins at the ASF:
https://www.dropbox.com/s/zwpersrv4ydzdp5/Capture%20d%27%C3%A9cran%202017-05-29%2017.36.49.png?dl=0
 


It would be nice if the tool we choose is integrated in our CI.

Nicolas

> Le 29 mai 2017 à 17:29, Matt Sicker  a écrit :
> 
> I've used pitest  before which is a bit more useful
> than typical code coverage plugins.
> 
> On 29 May 2017 at 08:55, Martin Gainty  wrote:
> 
>> 
>> 
>> 
>> 
>> From: Gintautas Grigelionis 
>> Sent: Monday, May 29, 2017 9:50 AM
>> To: Ant Developers List
>> Subject: Re: Replace emma with jacoco?
>> 
>> Talk about timing, again :-) -- Clover has been open source since April.
>> BTW, the documentation has moved to https://atlassian-docs.bitbucket.io/,
>> Atlassian documentation
>> atlassian-docs.bitbucket.io
>> The documentation in this repository is for products that are no longer
>> supported by Atlassian. This documentation is not maintained by Atlassian,
>> but is open source ...
>> 
>> 
>> 
>> so confluence.atlassian.com links do not work any more.
>> 
>> I can try adding both Jacoco and Clover and make instrumentation selectable
>> through a property.
>> I am inclined to start with Jacoco due to personal experience and keep it a
>> default choice.
>> 
>> The bigger change would be that "ant test" would run both instrumentation
>> and unit tests, and likewise "ant test-report" would produce both reports.
>> MG>an excellent idea..my personal request is which code-coverage tool
>> detects orphaned class ?
>> MG>a second request is which code coverage detects orphaned inner-classes?
>> MG>i look forward to receiving your analysis
>> 
>> Gintas
>> 
>> 2017-05-29 0:58 GMT+02:00 Martin Gainty :
>> 
>>> Hi Gintautas
>>> 
>>> 
>>> clover code-coverage has been around for 15 years..atlassian just
>>> contributed clover to Open Source this year
>>> 
>>> https://www.atlassian.com/blog/announcements/atlassian-
>> clover-open-source
>> Atlassian Clover is now open source - Atlassian Blog<
>> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source>
>> www.atlassian.com
>> All of this has lead to our decision to open source Clover, what we
>> believe is the best way to give Clover the focus and attention it deserves.
>> 
>> 
>> 
>>> 
>>> Atlassian Clover is now open source - Atlassian Blog<
>>> https://www.atlassian.com/blog/announcements/atlassian-
>> clover-open-source>
>> Atlassian Clover is now open source - Atlassian Blog<
>> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source>
>> www.atlassian.com
>> All of this has lead to our decision to open source Clover, what we
>> believe is the best way to give Clover the focus and attention it deserves.
>> 
>> 
>> 
>>> www.atlassian.com
>> [https://wac-cdn-a.atlassian.com/dam/jcr:c20cf6d1-9568-
>> 4aba-9a16-dba24e1495de/atlassian-software.png]
>> 
>> Atlassian | Software Development and Collaboration Tools<
>> http://www.atlassian.com/>
>> www.atlassian.com
>> Millions of users globally rely on Atlassian products every day for
>> improving software development, project management, collaboration, and code
>> quality.
>> 
>> 
>> 
>>> All of this has lead to our decision to open source Clover, what we
>>> believe is the best way to give Clover the focus and attention it
>> deserves.
>>> 
>>> Atlassian published an ant taskdef here
>>> 
>>> https://confluence.atlassian.com/clover/6-ant-task-
>> reference-71600066.html
>> 6. Ant Task Reference - Atlassian Documentation> confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
>> confluence.atlassian.com
>> Can I create a Clover Report on Server A if I have the clover.db which I
>> generated on Server B? Does Clover depend on JUnit? Does Clover integrate
>> with Maven?
>> 
>> 
>> 
>>> 
>>> 6. Ant Task Reference - Atlassian Documentation>> confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
>>> confluence.atlassian.com
>>> Can I create a Clover Report on Server A if I have the clover.db which I
>>> generated on Server B? Does Clover depend on JUnit? Does Clover integrate
>>> with Maven?
>>> 
>>> emma hasnt been touched in 12 years so it seems to be retired?
>>> 
>>> http://emma.sourceforge.net/
>> EMMA: a free Java code coverage tool
>> emma.sourceforge.net
>> EMMA can instrument classes for coverage either offline (before they are
>> loaded) or on the fly (using an instrumenting application classloader).
>> 
>> 
>> 
>>> 
>>> EMMA: a free Java code coverage tool
>> EMMA: a free Java code coverage tool
>> emma.sourceforge.net
>>

Re: Replace emma with jacoco?

2017-05-29 Thread Matt Sicker

I've used pitest  before which is a bit more useful
than typical code coverage plugins.

On 29 May 2017 at 08:55, Martin Gainty  wrote:

>
>
>
> 
> From: Gintautas Grigelionis 
> Sent: Monday, May 29, 2017 9:50 AM
> To: Ant Developers List
> Subject: Re: Replace emma with jacoco?
>
> Talk about timing, again :-) -- Clover has been open source since April.
> BTW, the documentation has moved to https://atlassian-docs.bitbucket.io/,
> Atlassian documentation
> atlassian-docs.bitbucket.io
> The documentation in this repository is for products that are no longer
> supported by Atlassian. This documentation is not maintained by Atlassian,
> but is open source ...
>
>
>
> so confluence.atlassian.com links do not work any more.
>
> I can try adding both Jacoco and Clover and make instrumentation selectable
> through a property.
> I am inclined to start with Jacoco due to personal experience and keep it a
> default choice.
>
> The bigger change would be that "ant test" would run both instrumentation
> and unit tests, and likewise "ant test-report" would produce both reports.
> MG>an excellent idea..my personal request is which code-coverage tool
> detects orphaned class ?
> MG>a second request is which code coverage detects orphaned inner-classes?
> MG>i look forward to receiving your analysis
>
> Gintas
>
> 2017-05-29 0:58 GMT+02:00 Martin Gainty :
>
> > Hi Gintautas
> >
> >
> > clover code-coverage has been around for 15 years..atlassian just
> > contributed clover to Open Source this year
> >
> > https://www.atlassian.com/blog/announcements/atlassian-
> clover-open-source
> Atlassian Clover is now open source - Atlassian Blog<
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source>
> www.atlassian.com
> All of this has lead to our decision to open source Clover, what we
> believe is the best way to give Clover the focus and attention it deserves.
>
>
>
> >
> > Atlassian Clover is now open source - Atlassian Blog<
> > https://www.atlassian.com/blog/announcements/atlassian-
> clover-open-source>
> Atlassian Clover is now open source - Atlassian Blog<
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source>
> www.atlassian.com
> All of this has lead to our decision to open source Clover, what we
> believe is the best way to give Clover the focus and attention it deserves.
>
>
>
> > www.atlassian.com
> [https://wac-cdn-a.atlassian.com/dam/jcr:c20cf6d1-9568-
> 4aba-9a16-dba24e1495de/atlassian-software.png]
>
> Atlassian | Software Development and Collaboration Tools<
> http://www.atlassian.com/>
> www.atlassian.com
> Millions of users globally rely on Atlassian products every day for
> improving software development, project management, collaboration, and code
> quality.
>
>
>
> > All of this has lead to our decision to open source Clover, what we
> > believe is the best way to give Clover the focus and attention it
> deserves.
> >
> > Atlassian published an ant taskdef here
> >
> > https://confluence.atlassian.com/clover/6-ant-task-
> reference-71600066.html
> 6. Ant Task Reference - Atlassian Documentation confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> confluence.atlassian.com
> Can I create a Clover Report on Server A if I have the clover.db which I
> generated on Server B? Does Clover depend on JUnit? Does Clover integrate
> with Maven?
>
>
>
> >
> > 6. Ant Task Reference - Atlassian Documentation > confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> > confluence.atlassian.com
> > Can I create a Clover Report on Server A if I have the clover.db which I
> > generated on Server B? Does Clover depend on JUnit? Does Clover integrate
> > with Maven?
> >
> > emma hasnt been touched in 12 years so it seems to be retired?
> >
> > http://emma.sourceforge.net/
> EMMA: a free Java code coverage tool
> emma.sourceforge.net
> EMMA can instrument classes for coverage either offline (before they are
> loaded) or on the fly (using an instrumenting application classloader).
>
>
>
> >
> > EMMA: a free Java code coverage tool
> EMMA: a free Java code coverage tool
> emma.sourceforge.net
> EMMA can instrument classes for coverage either offline (before they are
> loaded) or on the fly (using an instrumenting application classloader).
>
>
>
> > emma.sourceforge.net
> > EMMA can instrument classes for coverage either offline (before they are
> > loaded) or on the fly (using an instrumenting application classloader).
> >
> > Emmas feature requests number 103 which nobody has addressed
> >
> > https://sourceforge.net/p/emma/feature-requests/
> EMMA code coverage / Feature Requests - sourceforge.net

Re: PR-33: problems

2017-05-29 Thread Matt Sicker

Removing a checked exception can affect source compatibility, for example,
if that particular exception is caught in a try block and nothing else in
the try block can throw the exception. Or at least that's how I remember it
I think.

On 29 May 2017 at 06:05, Nicolas Lalevée  wrote:

>
> > Le 29 mai 2017 à 11:46, Jan Matèrne (jhm)  a écrit :
> >
> > Sounds like I would do ;)
> > I'll merge the PR locally and insert the delegates.
> >
> > Open is
> > "src/java/org/apache/ivy/osgi/util/Version.java:
> >  the constructor removes the (IMO unneccessary) ParseException.
> >  But because it is a checked Exception we break BC."
> >
> > https://wiki.eclipse.org/Evolving_Java-based_APIs_2 defines the removal
> of a checked exception:
> > "Breaks compatibility"
> > "Adding and deleting checked exceptions declared as thrown by an API
> method
> >  does not break binary compatibility; however,
> >  it breaks contract compatibility (and source code compatibility)."
> >
> > What do we want?
>
> Thanks for the link, I’ll bookmark it.
>
> Then I am OK with that. The Ivy jar can still be a upgraded without
> worries, and if somebody compile against it, then he has the source so he
> can modify them.
>
> I am OK with that also because having stricter compatibility rules will be
> painful considering the wide API Ivy is exposing.
>
> Nicolas
>
> >
> >
> >
> > Jan
> >
> >> -Ursprüngliche Nachricht-
> >> Von: J Pai [mailto:jai.forums2...@gmail.com]
> >> Gesendet: Montag, 29. Mai 2017 10:26
> >> An: Ant Developers List
> >> Betreff: Re: PR-33: problems
> >>
> >> IMO, for each of these public classes/methods/fields that we are fixing
> >> for typos, we should mark them @Deprecated (and add a @deprecated
> >> javadoc too and point to the new field/method/class) and introduce the
> >> rightly named class/method/field. For methods it’s straightforward, the
> >> deprecated method internally calls the new method. For fields too it’s
> >> straightforward. The deprecated field uses the value of the new field.
> >> For classes, I think we can copy over the existing class into the new
> >> one and leave around the existing one just for possible external
> >> references (that we can’t control off) and migrate all internal
> >> references to the new one.
> >>
> >> At some point, in some future version of Ivy, we remove/delete these
> >> deprecated method/field/class.
> >>
> >>
> >> -Jaikiran
> >>
> >>
> >> On 29-May-2017, at 1:43 PM, Jan Matèrne  wrote:
> >>
> >> I did a review of  
> >> https://github.com/apache/ant-ivy/pull/33
> >>
> >> Here are the points I have problems with, so I want to discuss them
> >> here.
> >>
> >> Basically it's about breaking BC. So how to deal with that?
> >>
> >>
> >>
> >>
> >>
> >> Jan
> >>
> >>
> >>
> >>
> >>
> >> Fixing the spell error in DelegateHandler$ChildElementHandler
> >> (s/childHanlded/childHandled/) means breaking beakward compatiblity.
> >>
> >> We could introduce a delegetate for that:
> >>
> >> /** for BC */
> >>
> >> @Deprecated
> >>
> >> public void childHanlded(DH child) throws SAXParseException {
> >>
> >>   childHandled(DH child);
> >>
> >> }
> >>
> >> While refactoring you have renamed all occurences in the Ivy codebase.
> >>
> >> On the other hand I don't know the impact (maybe outside of Ivy). I'll
> >> bring that to the dev-list.
> >>
> >>
> >>
> >>
> >>
> >> src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
> >> public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
> >>
> >>
> >>
> >>
> >>
> >> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes
> >> the (IMO unneccessary) ParseException. But because it is a checked
> >> Exception we break BC.
> >>
> >>
> >>
> >>
> >>
> >> renaming EncrytedProperties to EncryptedProperties means breaking BC.
> >> If required we could introduce a delegating class or a subclass.
> >>
> >>
> >>
> >>
> >>
> >> ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
> >> required we could introduce a delegating method.
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> >> commands, e-mail: dev-h...@ant.apache.org
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


-- 
Matt Sicker

Re: Replace emma with jacoco?

2017-05-29 Thread Martin Gainty

From: Gintautas Grigelionis 
Sent: Monday, May 29, 2017 9:50 AM
To: Ant Developers List
Subject: Re: Replace emma with jacoco?

Talk about timing, again :-) -- Clover has been open source since April.
BTW, the documentation has moved to https://atlassian-docs.bitbucket.io/,
Atlassian documentation
atlassian-docs.bitbucket.io
The documentation in this repository is for products that are no longer 
supported by Atlassian. This documentation is not maintained by Atlassian, but 
is open source ...

so confluence.atlassian.com links do not work any more.

I can try adding both Jacoco and Clover and make instrumentation selectable
through a property.
I am inclined to start with Jacoco due to personal experience and keep it a
default choice.

The bigger change would be that "ant test" would run both instrumentation
and unit tests, and likewise "ant test-report" would produce both reports.
MG>an excellent idea..my personal request is which code-coverage tool detects 
orphaned class ?
MG>a second request is which code coverage detects orphaned inner-classes?
MG>i look forward to receiving your analysis

Gintas

2017-05-29 0:58 GMT+02:00 Martin Gainty :

> Hi Gintautas
>
>
> clover code-coverage has been around for 15 years..atlassian just
> contributed clover to Open Source this year
>
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source
Atlassian Clover is now open source - Atlassian 
Blog
www.atlassian.com
All of this has lead to our decision to open source Clover, what we believe is 
the best way to give Clover the focus and attention it deserves.

>
> Atlassian Clover is now open source - Atlassian Blog<
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source>
Atlassian Clover is now open source - Atlassian 
Blog
www.atlassian.com
All of this has lead to our decision to open source Clover, what we believe is 
the best way to give Clover the focus and attention it deserves.

> www.atlassian.com
[https://wac-cdn-a.atlassian.com/dam/jcr:c20cf6d1-9568-4aba-9a16-dba24e1495de/atlassian-software.png]

Atlassian | Software Development and Collaboration 
Tools
www.atlassian.com
Millions of users globally rely on Atlassian products every day for improving 
software development, project management, collaboration, and code quality.

> All of this has lead to our decision to open source Clover, what we
> believe is the best way to give Clover the focus and attention it deserves.
>
> Atlassian published an ant taskdef here
>
> https://confluence.atlassian.com/clover/6-ant-task-reference-71600066.html
6. Ant Task Reference - Atlassian 
Documentation
confluence.atlassian.com
Can I create a Clover Report on Server A if I have the clover.db which I 
generated on Server B? Does Clover depend on JUnit? Does Clover integrate with 
Maven?

>
> 6. Ant Task Reference - Atlassian Documentation confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> confluence.atlassian.com
> Can I create a Clover Report on Server A if I have the clover.db which I
> generated on Server B? Does Clover depend on JUnit? Does Clover integrate
> with Maven?
>
> emma hasnt been touched in 12 years so it seems to be retired?
>
> http://emma.sourceforge.net/
EMMA: a free Java code coverage tool
emma.sourceforge.net
EMMA can instrument classes for coverage either offline (before they are 
loaded) or on the fly (using an instrumenting application classloader).

>
> EMMA: a free Java code coverage tool
EMMA: a free Java code coverage tool
emma.sourceforge.net
EMMA can instrument classes for coverage either offline (before they are 
loaded) or on the fly (using an instrumenting application classloader).

> emma.sourceforge.net
> EMMA can instrument classes for coverage either offline (before they are
> loaded) or on the fly (using an instrumenting application classloader).
>
> Emmas feature requests number 103 which nobody has addressed
>
> https://sourceforge.net/p/emma/feature-requests/
EMMA code coverage / Feature Requests - 
sourceforge.net
sourceforge.net
I agree to receive quotes, newsletters and other information from 
sourceforge.net and its partners regarding IT services and products. I 
understand that I can ...

>
> EMMA code coverage / Feature Requests - sourceforge.net sourceforge.net/p/emma/feature-requests/>
> sourceforge.net
> I agree to receive quotes, newsletters and other information from
>

Re: Replace emma with jacoco?

2017-05-29 Thread Gintautas Grigelionis

Talk about timing, again :-) -- Clover has been open source since April.
BTW, the documentation has moved to https://atlassian-docs.bitbucket.io/,
so confluence.atlassian.com links do not work any more.

I can try adding both Jacoco and Clover and make instrumentation selectable
through a property.
I am inclined to start with Jacoco due to personal experience and keep it a
default choice.

The bigger change would be that "ant test" would run both instrumentation
and unit tests, and likewise "ant test-report" would produce both reports.

Gintas

2017-05-29 0:58 GMT+02:00 Martin Gainty :

> Hi Gintautas
>
>
> clover code-coverage has been around for 15 years..atlassian just
> contributed clover to Open Source this year
>
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source
>
> Atlassian Clover is now open source - Atlassian Blog<
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-source>
> www.atlassian.com
> All of this has lead to our decision to open source Clover, what we
> believe is the best way to give Clover the focus and attention it deserves.
>
> Atlassian published an ant taskdef here
>
> https://confluence.atlassian.com/clover/6-ant-task-reference-71600066.html
>
> 6. Ant Task Reference - Atlassian Documentation confluence.atlassian.com/clover/6-ant-task-reference-71600066.html>
> confluence.atlassian.com
> Can I create a Clover Report on Server A if I have the clover.db which I
> generated on Server B? Does Clover depend on JUnit? Does Clover integrate
> with Maven?
>
> emma hasnt been touched in 12 years so it seems to be retired?
>
> http://emma.sourceforge.net/
>
> EMMA: a free Java code coverage tool
> emma.sourceforge.net
> EMMA can instrument classes for coverage either offline (before they are
> loaded) or on the fly (using an instrumenting application classloader).
>
> Emmas feature requests number 103 which nobody has addressed
>
> https://sourceforge.net/p/emma/feature-requests/
>
> EMMA code coverage / Feature Requests - sourceforge.net sourceforge.net/p/emma/feature-requests/>
> sourceforge.net
> I agree to receive quotes, newsletters and other information from
> sourceforge.net and its partners regarding IT services and products. I
> understand that I can ...
>
>
> WDYT of Clover?
>
> Martin
> __
>
>
>
> 
> From: Gintautas Grigelionis 
> Sent: Sunday, May 28, 2017 9:59 AM
> To: Ant Developers List
> Subject: Replace emma with jacoco?
>
> As you could understand by now, I set a goal of getting all targets in
> build.xml to do what they are supposed to do. Which brings us to emma,
> which appears no longer being developed. Do we need a vote about a
> replacement?
>
> Gintas
>

Ivy buildjobs

2017-05-29 Thread jhm

I changed the Ivy build jobs to use Java7 instead of Java6.

 

Jan

[GitHub] ant-ivy issue #34: Fix IVY-1528

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/34
  
- we dont use @author
- TestXmlHelper
  -- if xPathExpression would be a String and the method compiles that for 
itself,
 reuse would be easier
  -- XmlHelper would be a better name, because does not work only on tests.
  -- result could be inlined
- IvyMakePomTest#testClassifier()
  -- you dont use expectedPomArtifactIds for assertions. Do you want to 
check
 emptyness after the loop?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #35: Use Java 7 as the minimum required Java version

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/35
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

2017-05-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/33
  
You're right. I looked at a dictionary. I'll change that, so haven't to 
think about that in the future. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread nlalevee

Github user nlalevee commented on the issue:

https://github.com/apache/ant-ivy/pull/33
  
In french we have "ssi" which is a contraction of "si et seulement si" 
which has a mathematical meaning about absolute equivalence between two 
propositions.
I bet that in english "iff" means then "if and only if".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Increase minimum Java version for Ivy to Java7

2017-05-29 Thread J Pai

+1

-Jaikiran
On 29-May-2017, at 4:59 PM, Nicolas Lalevée  wrote:

+1

Nicolas


> Le 29 mai 2017 à 13:15, Jan Matèrne  a écrit :
> 
> Ivy uses Java7 from Ivy-2.5.x, so let us increase the minimum Java version
> for IvyDE from 1.4 [2] to Java7, too.
> 
> According to Eclipse Wiki [2] this will result in requiring Eclipse 4.4
> (from 2014) or newer.
> 
> 
> 
> According to the bylaws [3] this vote is open for one week (until
> 05.06.2017).
> 
> 
> 
> 
> 
> I'll start with +1.
> 
> 
> 
> 
> 
> Jan
> 
> 
> 
> [1]
> http://ant.apache.org/ivy/ivyde/history/latest-milestone/compatibility.html
> 
> [2] https://wiki.eclipse.org/Eclipse/Installation
> 
> [3]   http://ant.apache.org/bylaws.html
> 
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Increase minimum Java version for Ivy to Java7

2017-05-29 Thread Nicolas Lalevée

+1

Nicolas


> Le 29 mai 2017 à 13:15, Jan Matèrne  a écrit :
> 
> Ivy uses Java7 from Ivy-2.5.x, so let us increase the minimum Java version
> for IvyDE from 1.4 [2] to Java7, too.
> 
> According to Eclipse Wiki [2] this will result in requiring Eclipse 4.4
> (from 2014) or newer.
> 
> 
> 
> According to the bylaws [3] this vote is open for one week (until
> 05.06.2017).
> 
> 
> 
> 
> 
> I'll start with +1.
> 
> 
> 
> 
> 
> Jan
> 
> 
> 
> [1]
> http://ant.apache.org/ivy/ivyde/history/latest-milestone/compatibility.html
> 
> [2] https://wiki.eclipse.org/Eclipse/Installation
> 
> [3]   http://ant.apache.org/bylaws.html
> 
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

2017-05-29 Thread jaikiran

GitHub user jaikiran opened a pull request:

https://github.com/apache/ant-ivy/pull/35

Use Java 7 as the minimum required Java version

Now that the vote to upgrade the minimal required Java version has been 
passed[1], the commit here upgrades the version to Java 7.

[1]  https://www.mail-archive.com/dev@ant.apache.org/msg45557.html

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy java-7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 9ca03288e40e8a2230756de2aa7883cabd09652a
Author: Jaikiran Pai 
Date:   2017-05-29T11:22:32Z

Use Java 7 as the minimum required Java version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/33
  
merged, thanks for the huge work.
What about the "iff"? I am not a native speaker and dont want to judge ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #33: More code cleanup

2017-05-29 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[VOTE] Increase minimum Java version for Ivy to Java7

2017-05-29 Thread Jan Matèrne

Ivy uses Java7 from Ivy-2.5.x, so let us increase the minimum Java version
for IvyDE from 1.4 [2] to Java7, too.

According to Eclipse Wiki [2] this will result in requiring Eclipse 4.4
(from 2014) or newer.

 

According to the bylaws [3] this vote is open for one week (until
05.06.2017).

 

 

I'll start with +1.

 

 

Jan

 

[1]
http://ant.apache.org/ivy/ivyde/history/latest-milestone/compatibility.html

[2] https://wiki.eclipse.org/Eclipse/Installation

[3]   http://ant.apache.org/bylaws.html

[RESULT] [VOTE] Increase minimum Java version for Ivy to Java7

2017-05-29 Thread jhm

[RESULT] [VOTE] Increase minimum Java version for Ivy to Java7

Here is the result of the vote to increase the minimum Java
version from current (Ivy-2.4.0) Java5 to Java 7 (Ivy-2.5.0):

+1:
  Jan (binding)
  Jaikiran (non-binding)
  Gintautas (non-binding)
  Nicolas (binding)
  Dominique (binding)

-0:
  Maarten (binding)


So the vote passed and we can use Java7 from now.


Jan


> As discussed on this mailing list [1] we should increase the minimum
> Java version [2] from current (Ivy-2.4.0) Java5 to Java 7 (Ivy-2.5.0).
> Decisions whether to increase to Java8 after that release should be
> make after that release.
> According to the bylaws [3] this vote is open for one week (until
> 26.05.2017).
> 
> 
> [1]
http://mail-archives.apache.org/mod_mbox/ant-dev/201705.mbox/ajax/%3C87415C1
F-5EFF-4C81-8078-0276CC21A8ED%40gmail.com%3E 
> [2] http://ant.apache.org/ivy/history/latest-milestone/compatibility.html
> [3] http://ant.apache.org/bylaws.html 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: PR-33: problems

2017-05-29 Thread Nicolas Lalevée


> Le 29 mai 2017 à 11:46, Jan Matèrne (jhm)  a écrit :
> 
> Sounds like I would do ;)
> I'll merge the PR locally and insert the delegates.
> 
> Open is
> "src/java/org/apache/ivy/osgi/util/Version.java: 
>  the constructor removes the (IMO unneccessary) ParseException. 
>  But because it is a checked Exception we break BC."
> 
> https://wiki.eclipse.org/Evolving_Java-based_APIs_2 defines the removal of a 
> checked exception:
> "Breaks compatibility"
> "Adding and deleting checked exceptions declared as thrown by an API method 
>  does not break binary compatibility; however, 
>  it breaks contract compatibility (and source code compatibility)."
> 
> What do we want?

Thanks for the link, I’ll bookmark it.

Then I am OK with that. The Ivy jar can still be a upgraded without worries, 
and if somebody compile against it, then he has the source so he can modify 
them.

I am OK with that also because having stricter compatibility rules will be 
painful considering the wide API Ivy is exposing.

Nicolas

> 
> 
> 
> Jan
> 
>> -Ursprüngliche Nachricht-
>> Von: J Pai [mailto:jai.forums2...@gmail.com]
>> Gesendet: Montag, 29. Mai 2017 10:26
>> An: Ant Developers List
>> Betreff: Re: PR-33: problems
>> 
>> IMO, for each of these public classes/methods/fields that we are fixing
>> for typos, we should mark them @Deprecated (and add a @deprecated
>> javadoc too and point to the new field/method/class) and introduce the
>> rightly named class/method/field. For methods it’s straightforward, the
>> deprecated method internally calls the new method. For fields too it’s
>> straightforward. The deprecated field uses the value of the new field.
>> For classes, I think we can copy over the existing class into the new
>> one and leave around the existing one just for possible external
>> references (that we can’t control off) and migrate all internal
>> references to the new one.
>> 
>> At some point, in some future version of Ivy, we remove/delete these
>> deprecated method/field/class.
>> 
>> 
>> -Jaikiran
>> 
>> 
>> On 29-May-2017, at 1:43 PM, Jan Matèrne  wrote:
>> 
>> I did a review of  
>> https://github.com/apache/ant-ivy/pull/33
>> 
>> Here are the points I have problems with, so I want to discuss them
>> here.
>> 
>> Basically it's about breaking BC. So how to deal with that?
>> 
>> 
>> 
>> 
>> 
>> Jan
>> 
>> 
>> 
>> 
>> 
>> Fixing the spell error in DelegateHandler$ChildElementHandler
>> (s/childHanlded/childHandled/) means breaking beakward compatiblity.
>> 
>> We could introduce a delegetate for that:
>> 
>> /** for BC */
>> 
>> @Deprecated
>> 
>> public void childHanlded(DH child) throws SAXParseException {
>> 
>>   childHandled(DH child);
>> 
>> }
>> 
>> While refactoring you have renamed all occurences in the Ivy codebase.
>> 
>> On the other hand I don't know the impact (maybe outside of Ivy). I'll
>> bring that to the dev-list.
>> 
>> 
>> 
>> 
>> 
>> src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
>> public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
>> 
>> 
>> 
>> 
>> 
>> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes
>> the (IMO unneccessary) ParseException. But because it is a checked
>> Exception we break BC.
>> 
>> 
>> 
>> 
>> 
>> renaming EncrytedProperties to EncryptedProperties means breaking BC.
>> If required we could introduce a delegating class or a subclass.
>> 
>> 
>> 
>> 
>> 
>> ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
>> required we could introduce a delegating method.
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
>> commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: AW: PR-33: problems

2017-05-29 Thread Gintautas Grigelionis

Sorry for slow response, I'm on a trip. It does make sense to leave the
exception in place only if ivy becomes opinionated about versions. I am not
sure if compatibility break requires a change of major version. There are
semver tools out there; maybe it's worth integrating them (redemption
driven development :-)

Gintas

Den 29 maj 2017 11:47 skrev "Jan Matèrne (jhm)" :

Sounds like I would do ;)
I'll merge the PR locally and insert the delegates.

Open is
"src/java/org/apache/ivy/osgi/util/Version.java:
  the constructor removes the (IMO unneccessary) ParseException.
  But because it is a checked Exception we break BC."

https://wiki.eclipse.org/Evolving_Java-based_APIs_2 defines the removal of
a checked exception:
"Breaks compatibility"
"Adding and deleting checked exceptions declared as thrown by an API method
  does not break binary compatibility; however,
  it breaks contract compatibility (and source code compatibility)."

What do we want?



Jan

> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Montag, 29. Mai 2017 10:26
> An: Ant Developers List
> Betreff: Re: PR-33: problems
>
> IMO, for each of these public classes/methods/fields that we are fixing
> for typos, we should mark them @Deprecated (and add a @deprecated
> javadoc too and point to the new field/method/class) and introduce the
> rightly named class/method/field. For methods it’s straightforward, the
> deprecated method internally calls the new method. For fields too it’s
> straightforward. The deprecated field uses the value of the new field.
> For classes, I think we can copy over the existing class into the new
> one and leave around the existing one just for possible external
> references (that we can’t control off) and migrate all internal
> references to the new one.
>
> At some point, in some future version of Ivy, we remove/delete these
> deprecated method/field/class.
>
>
> -Jaikiran
>
>
> On 29-May-2017, at 1:43 PM, Jan Matèrne  wrote:
>
> I did a review of  
> https://github.com/apache/ant-ivy/pull/33
>
> Here are the points I have problems with, so I want to discuss them
> here.
>
> Basically it's about breaking BC. So how to deal with that?
>
>
>
>
>
> Jan
>
>
>
>
>
> Fixing the spell error in DelegateHandler$ChildElementHandler
> (s/childHanlded/childHandled/) means breaking beakward compatiblity.
>
> We could introduce a delegetate for that:
>
>  /** for BC */
>
>  @Deprecated
>
>  public void childHanlded(DH child) throws SAXParseException {
>
>childHandled(DH child);
>
>  }
>
> While refactoring you have renamed all occurences in the Ivy codebase.
>
> On the other hand I don't know the impact (maybe outside of Ivy). I'll
> bring that to the dev-list.
>
>
>
>
>
> src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
> public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
>
>
>
>
>
> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes
> the (IMO unneccessary) ParseException. But because it is a checked
> Exception we break BC.
>
>
>
>
>
> renaming EncrytedProperties to EncryptedProperties means breaking BC.
> If required we could introduce a delegating class or a subclass.
>
>
>
>
>
> ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
> required we could introduce a delegating method.
>
>
>
>
>
>
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: PR-33: problems

2017-05-29 Thread jhm

Sounds like I would do ;)
I'll merge the PR locally and insert the delegates.

Open is
"src/java/org/apache/ivy/osgi/util/Version.java: 
  the constructor removes the (IMO unneccessary) ParseException. 
  But because it is a checked Exception we break BC."

https://wiki.eclipse.org/Evolving_Java-based_APIs_2 defines the removal of a 
checked exception:
"Breaks compatibility"
"Adding and deleting checked exceptions declared as thrown by an API method 
  does not break binary compatibility; however, 
  it breaks contract compatibility (and source code compatibility)."

What do we want?



Jan

> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Montag, 29. Mai 2017 10:26
> An: Ant Developers List
> Betreff: Re: PR-33: problems
> 
> IMO, for each of these public classes/methods/fields that we are fixing
> for typos, we should mark them @Deprecated (and add a @deprecated
> javadoc too and point to the new field/method/class) and introduce the
> rightly named class/method/field. For methods it’s straightforward, the
> deprecated method internally calls the new method. For fields too it’s
> straightforward. The deprecated field uses the value of the new field.
> For classes, I think we can copy over the existing class into the new
> one and leave around the existing one just for possible external
> references (that we can’t control off) and migrate all internal
> references to the new one.
> 
> At some point, in some future version of Ivy, we remove/delete these
> deprecated method/field/class.
> 
> 
> -Jaikiran
> 
> 
> On 29-May-2017, at 1:43 PM, Jan Matèrne  wrote:
> 
> I did a review of  
> https://github.com/apache/ant-ivy/pull/33
> 
> Here are the points I have problems with, so I want to discuss them
> here.
> 
> Basically it's about breaking BC. So how to deal with that?
> 
> 
> 
> 
> 
> Jan
> 
> 
> 
> 
> 
> Fixing the spell error in DelegateHandler$ChildElementHandler
> (s/childHanlded/childHandled/) means breaking beakward compatiblity.
> 
> We could introduce a delegetate for that:
> 
>  /** for BC */
> 
>  @Deprecated
> 
>  public void childHanlded(DH child) throws SAXParseException {
> 
>childHandled(DH child);
> 
>  }
> 
> While refactoring you have renamed all occurences in the Ivy codebase.
> 
> On the other hand I don't know the impact (maybe outside of Ivy). I'll
> bring that to the dev-list.
> 
> 
> 
> 
> 
> src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
> public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
> 
> 
> 
> 
> 
> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes
> the (IMO unneccessary) ParseException. But because it is a checked
> Exception we break BC.
> 
> 
> 
> 
> 
> renaming EncrytedProperties to EncryptedProperties means breaking BC.
> If required we could introduce a delegating class or a subclass.
> 
> 
> 
> 
> 
> ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
> required we could introduce a delegating method.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: PR-33: problems

2017-05-29 Thread Nicolas Lalevée


> Le 29 mai 2017 à 11:35, Jan Matèrne (jhm)  a écrit :
> 
> Thanks, but I already have it done ;)
> 
> But one point is open:
> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the 
> (IMO unneccessary) ParseException. But because it is a checked Exception we 
> break BC.

It breaks compile time BC but the not binary one, isn’t it ? If it is the case, 
I have no objection to break it there.

Nicolas


> 
> 
> Jan
> 
>> -Ursprüngliche Nachricht-
>> Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com]
>> Gesendet: Montag, 29. Mai 2017 11:00
>> An: Ant Developers List
>> Betreff: Re: PR-33: problems
>> 
>> If it's acceptable I'll complement the PR addressing all the points.
>> 
>> Gintas
>> 
>> Den 29 maj 2017 10:13 skrev "Jan Matèrne" :
>> 
>> I did a review of  
>> https://github.com/apache/ant-ivy/pull/33
>> 
>> Here are the points I have problems with, so I want to discuss them
>> here.
>> 
>> Basically it's about breaking BC. So how to deal with that?
>> 
>> 
>> 
>> 
>> 
>> Jan
>> 
>> 
>> 
>> 
>> 
>> Fixing the spell error in DelegateHandler$ChildElementHandler
>> (s/childHanlded/childHandled/) means breaking beakward compatiblity.
>> 
>> We could introduce a delegetate for that:
>> 
>>  /** for BC */
>> 
>>  @Deprecated
>> 
>>  public void childHanlded(DH child) throws SAXParseException {
>> 
>>childHandled(DH child);
>> 
>>  }
>> 
>> While refactoring you have renamed all occurences in the Ivy codebase.
>> 
>> On the other hand I don't know the impact (maybe outside of Ivy). I'll
>> bring that to the dev-list.
>> 
>> 
>> 
>> 
>> 
>> src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
>> public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
>> 
>> 
>> 
>> 
>> 
>> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes
>> the (IMO unneccessary) ParseException. But because it is a checked
>> Exception we break BC.
>> 
>> 
>> 
>> 
>> 
>> renaming EncrytedProperties to EncryptedProperties means breaking BC.
>> If required we could introduce a delegating class or a subclass.
>> 
>> 
>> 
>> 
>> 
>> ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
>> required we could introduce a delegating method.
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: PR-33: problems

2017-05-29 Thread jhm

Thanks, but I already have it done ;)

But one point is open:
src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the 
(IMO unneccessary) ParseException. But because it is a checked Exception we 
break BC.


Jan

> -Ursprüngliche Nachricht-
> Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com]
> Gesendet: Montag, 29. Mai 2017 11:00
> An: Ant Developers List
> Betreff: Re: PR-33: problems
> 
> If it's acceptable I'll complement the PR addressing all the points.
> 
> Gintas
> 
> Den 29 maj 2017 10:13 skrev "Jan Matèrne" :
> 
> I did a review of  
> https://github.com/apache/ant-ivy/pull/33
> 
> Here are the points I have problems with, so I want to discuss them
> here.
> 
> Basically it's about breaking BC. So how to deal with that?
> 
> 
> 
> 
> 
> Jan
> 
> 
> 
> 
> 
> Fixing the spell error in DelegateHandler$ChildElementHandler
> (s/childHanlded/childHandled/) means breaking beakward compatiblity.
> 
> We could introduce a delegetate for that:
> 
>   /** for BC */
> 
>   @Deprecated
> 
>   public void childHanlded(DH child) throws SAXParseException {
> 
> childHandled(DH child);
> 
>   }
> 
> While refactoring you have renamed all occurences in the Ivy codebase.
> 
> On the other hand I don't know the impact (maybe outside of Ivy). I'll
> bring that to the dev-list.
> 
> 
> 
> 
> 
> src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
> public constant DEFAULT_BUNLDE_FILTER also means breaking BC.
> 
> 
> 
> 
> 
> src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes
> the (IMO unneccessary) ParseException. But because it is a checked
> Exception we break BC.
> 
> 
> 
> 
> 
> renaming EncrytedProperties to EncryptedProperties means breaking BC.
> If required we could introduce a delegating class or a subclass.
> 
> 
> 
> 
> 
> ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
> required we could introduce a delegating method.


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: PR-33: problems

2017-05-29 Thread Gintautas Grigelionis

If it's acceptable I'll complement the PR addressing all the points.

Gintas

Den 29 maj 2017 10:13 skrev "Jan Matèrne" :

I did a review of  
https://github.com/apache/ant-ivy/pull/33

Here are the points I have problems with, so I want to discuss them here.

Basically it's about breaking BC. So how to deal with that?





Jan





Fixing the spell error in DelegateHandler$ChildElementHandler
(s/childHanlded/childHandled/) means breaking beakward compatiblity.

We could introduce a delegetate for that:

  /** for BC */

  @Deprecated

  public void childHanlded(DH child) throws SAXParseException {

childHandled(DH child);

  }

While refactoring you have renamed all occurences in the Ivy codebase.

On the other hand I don't know the impact (maybe outside of Ivy). I'll bring
that to the dev-list.





src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
public constant DEFAULT_BUNLDE_FILTER also means breaking BC.





src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the
(IMO unneccessary) ParseException. But because it is a checked Exception we
break BC.





renaming EncrytedProperties to EncryptedProperties means breaking BC. If
required we could introduce a delegating class or a subclass.





ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
required we could introduce a delegating method.

Re: PR-33: problems

2017-05-29 Thread J Pai

IMO, for each of these public classes/methods/fields that we are fixing for 
typos, we should mark them @Deprecated (and add a @deprecated javadoc too and 
point to the new field/method/class) and introduce the rightly named 
class/method/field. For methods it’s straightforward, the deprecated method 
internally calls the new method. For fields too it’s straightforward. The 
deprecated field uses the value of the new field. For classes, I think we can 
copy over the existing class into the new one and leave around the existing one 
just for possible external references (that we can’t control off) and migrate 
all internal references to the new one.

At some point, in some future version of Ivy, we remove/delete these deprecated 
method/field/class.


-Jaikiran


On 29-May-2017, at 1:43 PM, Jan Matèrne  wrote:

I did a review of  
https://github.com/apache/ant-ivy/pull/33

Here are the points I have problems with, so I want to discuss them here.

Basically it's about breaking BC. So how to deal with that?





Jan





Fixing the spell error in DelegateHandler$ChildElementHandler
(s/childHanlded/childHandled/) means breaking beakward compatiblity. 

We could introduce a delegetate for that:

 /** for BC */

 @Deprecated

 public void childHanlded(DH child) throws SAXParseException {

   childHandled(DH child);

 }

While refactoring you have renamed all occurences in the Ivy codebase. 

On the other hand I don't know the impact (maybe outside of Ivy). I'll bring
that to the dev-list.





src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
public constant DEFAULT_BUNLDE_FILTER also means breaking BC.





src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the
(IMO unneccessary) ParseException. But because it is a checked Exception we
break BC.





renaming EncrytedProperties to EncryptedProperties means breaking BC. If
required we could introduce a delegating class or a subclass.





ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
required we could introduce a delegating method.











-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: Replace emma with jacoco?

2017-05-29 Thread jhm

The task is having a code coverage.
The chosen tool should:
- do that ;)
- be free for OSS
- maintained
- useable by the project community (we have to use that ;)
- runnable in a CI environment

If a chosen tool (EMMA) does its job, you dont have to change this until
you'll get problems not to solve with that.
Then start an 'evaluation' ...

https://en.wikipedia.org/wiki/Java_Code_Coverage_Tools lists some tools.
EclEmma uses JaCoCo (as a replacement for EMMA). I think that some
developers are using that so using JaCoCo would be a fit to their toolset.


Jan

> -Ursprüngliche Nachricht-
> Von: Martin Gainty [mailto:mgai...@hotmail.com]
> Gesendet: Montag, 29. Mai 2017 00:58
> An: Ant Developers List
> Betreff: Re: Replace emma with jacoco?
> 
> Hi Gintautas
> 
> 
> clover code-coverage has been around for 15 years..atlassian just
> contributed clover to Open Source this year
> 
> https://www.atlassian.com/blog/announcements/atlassian-clover-open-
> source
> 
> Atlassian Clover is now open source - Atlassian
> Blog open-source>
> www.atlassian.com
> All of this has lead to our decision to open source Clover, what we
> believe is the best way to give Clover the focus and attention it
> deserves.
> 
> Atlassian published an ant taskdef here
> 
> https://confluence.atlassian.com/clover/6-ant-task-reference-
> 71600066.html
> 
> 6. Ant Task Reference - Atlassian
> Documentation reference-71600066.html>
> confluence.atlassian.com
> Can I create a Clover Report on Server A if I have the clover.db which
> I generated on Server B? Does Clover depend on JUnit? Does Clover
> integrate with Maven?
> 
> emma hasnt been touched in 12 years so it seems to be retired?
> 
> http://emma.sourceforge.net/
> 
> EMMA: a free Java code coverage tool
> emma.sourceforge.net
> EMMA can instrument classes for coverage either offline (before they
> are loaded) or on the fly (using an instrumenting application
> classloader).
> 
> Emmas feature requests number 103 which nobody has addressed
> 
> https://sourceforge.net/p/emma/feature-requests/
> 
> EMMA code coverage / Feature Requests -
> sourceforge.net
> sourceforge.net
> I agree to receive quotes, newsletters and other information from
> sourceforge.net and its partners regarding IT services and products. I
> understand that I can ...
> 
> 
> WDYT of Clover?
> 
> Martin
> __
> 
> 
> 
> 
> From: Gintautas Grigelionis 
> Sent: Sunday, May 28, 2017 9:59 AM
> To: Ant Developers List
> Subject: Replace emma with jacoco?
> 
> As you could understand by now, I set a goal of getting all targets in
> build.xml to do what they are supposed to do. Which brings us to emma,
> which appears no longer being developed. Do we need a vote about a
> replacement?
> 
> Gintas


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

PR-33: problems

2017-05-29 Thread Jan Matèrne

I did a review of  
https://github.com/apache/ant-ivy/pull/33

Here are the points I have problems with, so I want to discuss them here.

Basically it's about breaking BC. So how to deal with that?

 

 

Jan

 

 

Fixing the spell error in DelegateHandler$ChildElementHandler
(s/childHanlded/childHandled/) means breaking beakward compatiblity. 

We could introduce a delegetate for that:

  /** for BC */

  @Deprecated

  public void childHanlded(DH child) throws SAXParseException {

childHandled(DH child);

  }

While refactoring you have renamed all occurences in the Ivy codebase. 

On the other hand I don't know the impact (maybe outside of Ivy). I'll bring
that to the dev-list.

 

 

src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the
public constant DEFAULT_BUNLDE_FILTER also means breaking BC.

 

 

src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the
(IMO unneccessary) ParseException. But because it is a checked Exception we
break BC.

 

 

renaming EncrytedProperties to EncryptedProperties means breaking BC. If
required we could introduce a delegating class or a subclass.

 

 

ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If
required we could introduce a delegating method.

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/33
  
Because of the problems I dont merge this ATM. We should discuss them on 
the dev list before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/33
  
build.xml
- Nice idea with the copyright statement in Javadoc ( (c)${years} ; 
years=tstamp("2007-") ).

You found a lot of spell errors ;)

MatcherLookup.java#get(Map): new Javadoc is:
  '@return a list of matchers that can apply to module withs specified 
attributes'
I am not sure about 'withs' or 'with' ...

Nice rewrites of 
  "myBoolean == null : false = myBoolean.booleanValue()" (and opposite) to
  "myBoolean != null && myBoolean"



For Discussion:
---
ModuleInSort.java, class javadoc, "is sorted": I think the 'iff' has a 'f' 
too much.



Problems:
-
Fixing the spell error in DelegateHandler$ChildElementHandler 
(s/childHanlded/childHandled/) means breaking beakward compatiblity. 
We could introduce a delegetate for that:
  /** for BC */
  @Deprecated
  public void childHanlded(DH child) throws SAXParseException {
childHandled(DH child);
  }
While refactoring you have renamed all occurences in the Ivy codebase. 
On the other hand I don't know the impact (maybe outside of Ivy). I'll 
bring that to the dev-list.

src/java/org/apache/ivy/osgi/repo/FSManifestIterable.java: renaming the 
public constant DEFAULT_BUNLDE_FILTER also means breaking BC.

src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the 
(IMO unneccessary) ParseException. But because it is a checked Exception we 
break BC.

renaming EncrytedProperties to EncryptedProperties means breaking BC. If 
required we could introduce a delegating class or a subclass.

ArtifactOrigin: renaming unkwnown() to unknown() means breaking BC. If 
required we could introduce a delegating method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #33: More code cleanup

2017-05-29 Thread janmaterne

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/33
  
start reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #34: Fix IVY-1528

[GitHub] ant-ivy pull request #36: Replace emma with jacoco

Re: Replace emma with jacoco?

Re: Replace emma with jacoco?

Re: Replace emma with jacoco?

Re: Replace emma with jacoco?

Re: PR-33: problems

Re: Replace emma with jacoco?

Re: Replace emma with jacoco?

Ivy buildjobs

[GitHub] ant-ivy issue #34: Fix IVY-1528

[GitHub] ant-ivy issue #35: Use Java 7 as the minimum required Java version

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

[GitHub] ant-ivy issue #33: More code cleanup

[GitHub] ant-ivy issue #33: More code cleanup

Re: [VOTE] Increase minimum Java version for Ivy to Java7

Re: [VOTE] Increase minimum Java version for Ivy to Java7

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

[GitHub] ant-ivy issue #33: More code cleanup

[GitHub] ant-ivy pull request #33: More code cleanup

[VOTE] Increase minimum Java version for Ivy to Java7

[RESULT] [VOTE] Increase minimum Java version for Ivy to Java7

Re: PR-33: problems

Re: AW: PR-33: problems

AW: PR-33: problems

Re: PR-33: problems

AW: PR-33: problems

Re: PR-33: problems

Re: PR-33: problems

AW: Replace emma with jacoco?

PR-33: problems

[GitHub] ant-ivy issue #33: More code cleanup

[GitHub] ant-ivy issue #33: More code cleanup

[GitHub] ant-ivy issue #33: More code cleanup

34 matches

Site Navigation

Mail list logo

Footer information