[GitHub] ant-ivy pull request #:
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286798 Sure, I'll do a find/replace in one of my upcoming doc fixes commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286714 In fact, there's a bunch of places where [Mm]aven2 is used... [asciidoc-maven.zip](https://github.com/apache/ant-ivy/files/1172996/asciidoc-maven.zip) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286444 In asciidoc/tutorial/multiple.adoc, please replace Maven2 with Maven 2 for consistency ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #53: Suppressed warnings
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 Sorry for additions to PR. I figured out a way to remove the last inconsistencies with generics without breaking the API. This PR will not change any more. I rebased my commits; you're welcome to cherrypick. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Ivy - No more support for commons-httpclient 2.x in runtime classpath?
This turned out to be a relatively smaller task than what I had previously thought it would be. That's mainly thanks to the way this whole interaction with the library, in Ivy, has been designed and kept isolated from majority of the code. So as of late yesterday, the master branch now uses 4.5.3 of HttpComponents HttpClient library. Relevant documentation has been updated to reflect the same. Additional tests have been added to test/verify the semantics and also verify some of the issues that were reported in Ivy due to our usage of the older commons-httpclient. An upstream master build on Jenkins after these commits has gone fine too. I'm waiting for at least another round of Jenkins job to finish (for unrelated reasons our jobs haven't triggered given unavailability of some Jenkins agents/nodes), before I request some of our users on ivy-user mailing list to give the latest snapshot a try to see if there are any unforeseen regressions. -Jaikiran On 25/07/17 12:37 AM, Nicolas Lalevée wrote: Le 24 juil. 2017 à 08:19, Jaikiran Pai a écrit : That's a a big enough reason to move to HttpComponents Client 4.x version! I'll have that done in this release of Ivy then. +1 Nicolas -Jaikiran On 24/07/17 11:43 AM, Stefan Bodewig wrote: On 2017-07-24, Jaikiran Pai wrote: Ivy currently uses commons-httpclient for dealing with HTTP repositories. This is an internal implementation detail of Ivy. The way it's implemented, it allows the user to use a version of their choice, of this library, by placing them in the runtime classpath (similar to some other libraries we use). The implementation internally checks for the presence of 2.x as well as 3.x version of library to decide which version to use at _runtime_ . Let me point out that even 3.x has long reached end of life. It's successor fixed CVE-2012-5783[1] with 4.2.3 but there hasn't been any 3.x release that has fixed it AFAIK. Stefan [1] http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5783 - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #53: Suppressed warnings
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Hi Gintas, Given the amount of commits and the changes involved in this PR, it's a bit difficult to review it. I think this PR even includes some of the changes that have already been included in upstream master from one of your other PR. What I have instead now done is - reviewed individual smaller commits from this PR which were isolated enough to be easily reviewed/merged. I have `cherry-pick`ed the following commits from this PR, squashed them in one commit and merged it upstream: - https://github.com/apache/ant-ivy/pull/53/commits/cceb05ebfce3d481a97e46f384afbcd2eca66005 - https://github.com/apache/ant-ivy/pull/53/commits/cce7276a93e50c7ed608987697ec08d3b0d2f2af - https://github.com/apache/ant-ivy/pull/53/commits/381991072529d832fcdfb422d2e99599d037d30e The merged commit upstream is this one https://github.com/apache/ant-ivy/commit/d4c3cbccaf05beeb11712294ef4dd0af25d9d0f4 Furthermore, since the same PR keeps getting updated regularly with changes and new commits, it becomes difficult to keep track of what to review and what's pending. For the rest of the commits that I haven't been able to review yet (given their size and nature), could you please create isolated individual PRs (on separate personal branches), all rebased against latest master branch? That will make it a bit more easier to review them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
