[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/54
  
Re password input: isn't there a 
[task](https://ant.apache.org/manual/Tasks/input.html) with SecureInputHandler 
for that?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/54
  
`buildosxpackage` was peanuts compared to getting rid of `root` system 
property kludge for surefire in tests.

BTW, Ivy `signer` saves you work with

1. signing in advance
2. having to declare all signatures in `ivy.xml`
3. publishing extraneous checksums for signatures

I'd rather add another ivy.xml for distributions that would use filesystem 
resolver to publish signed distributions into the svn repo... [svn 
resolver](https://github.com/massdosage/ivysvn) for Ivy seems a bit of an 
overkill.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/54
  
I didn't suggest to remove the `buildosxpackage` feature, just that you are 
putting quite a bit of effort into an area that is probably never used - at 
least not much.

As I said, I don't use `signit` at all and I do not want to give the 
passphrase to my PGP key on the command line. As long as I can keep using the 
gpg command line and Ivy will then upload the signatures I've created, I'm fine 
with it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2017-12-27 Thread bodewig
Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26506626
  
You're welcome.

That's why I try to make changes that are target for both branches just to 
the 1.9.x branch and merge it to master.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2017-12-27 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26504265
  
Thanks for catching this one up, a slip of attention while backporting 
changes in master.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/54
  
I would like to point out one distinction: I would like to replace the 
stuff that works (sort of) with **less** stuff that does the same job, and 
hopefully more. Besides, my beef with Maven Ant tasks was that they morphed 
into Aether Ant tasks, and then Maven Resolver Ant tasks and changed syntax 
along the way, and I couldn't add Bintray using Maven Ant tasks (at least in a 
nontrivial way).

`buildoxspackage` is a requested feature, and it does no harm to keep it, 
albeit in a simple native implementation.

The point with `signit.xml` is that Ivy does it all in one go with 
`upload.xml` and with less stuff in `ivy.xml`

I can change `fetch.xml` so that release conf goes into a separate place, 
and so Ivy + BouncyCastle are kept out of sight (unlike Maven Ant tasks).


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #53: Optional libraries for Ant 1.10

2017-12-27 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/53
  
I see `dest` as a useful functionality of fetch.xml (why else should it be 
a part of the distribution?); and that is basically the crux of the matter.

I will update the documentation, thanks for the pointer.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: ant git commit: refactored build.xml - made dump-info a dependency of test-init; - removed extraneous dependencies of distribution targets; - turned camelcase and snakecase into kebabcase for cons

2017-12-27 Thread Stefan Bodewig
Please, please, please, please don't mix formatting changes with real
changes. This commit contains more that 300 changed lines and it is
extremely difficult to see the real changes.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/54
  
I don't have any problem with you replacing stuff that works with other 
stuff that works as well. But before you put too much effort into it, maybe you 
should look through 
https://github.com/apache/ant/blob/master/ReleaseInstructions to see what is 
and what is not used during a release at all.

As I've preformed a few releases myself let me start by telling you that I 
have run `fetch.xml` when we upgraded BCEL but usually don't use it at all as 
my workspace already contains everything I need to build a release.

I have never used `build-osx-pkg.py` (and am not aware of anybody ever 
using it, `buildosxpackage` has never been true for me and there is no `pkg` 
file in http://archive.apache.org/dist/ant/binaries/) or `signit.xml` (as I 
prefer to use the command line for that, I think Antoine has used it in the 
past).

As I usually am not an Ivy user I'd prefer my everyday build of Ant to not 
require me to place Ivy on the CLASSPATH, I'm totally content with not 
integrating upload with the normal build process as uploading is a very rare 
exceptional use case only ever performed by a single person. But that's just my 
preference, YMMV.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #53: Optional libraries for Ant 1.10

2017-12-27 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/53
  
I see you've already merged this PR, I'll look st it later. I hope you 
didn't wait for me to respond during Christmas.

I'm not sure why `dest` is part of `fetch.xml`, we've always seen at as 
something for the Ant developers and it really only sets the baseline Ant is 
compiled against. No more.

I'm not sure which benefit you see with upgrading all those libraries as 
from my point of view you are only updating what the binary distributions get 
compiled against (and only if the release manager deletes the already existing 
local cache and re-runs `fetch.xml` which is rather unlikely to happen). Either 
the API of the upgraded version remains compatible with the older one so the 
update doesn't have any effect at all or it is not, in which case we introduce 
a backwards incompatibility with no real win I can see. But that's just my 
opinion.

There is a page inside of the manual - 
http://ant.apache.org/manual/install.html#librarydependencies - that may need 
to get updated as well.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org