Re: Tooling update

2018-06-12 Thread Gintautas Grigelionis
e.org/nightlies.html 2018-06-09 9:08 GMT+02:00 Gintautas Grigelionis : > Thanks, Stefan. Meanwhile, SpotBugs is reactivated in the nighlies now. > I noticed, however, that execution order is important: if SpotBugs runs > before Checkstyle, > the latter bails out because of ANTLR. > > G

Java modules as Ant resources (was: Generate manifest files and add automatic module names for JPMS)

2018-06-10 Thread Gintautas Grigelionis
2018-02-07 18:25 GMT+01:00 Stefan Bodewig : > >> Maybe it will be easier to digest if we start at a higher level of what >> needs to be changed. I don't think moving classes so we don't have any >> split packages anymore will be enough. >> >> I'd expect we'd need to replace all code that deals wit

Re: javadoc in Java 10+

2018-06-10 Thread Gintautas Grigelionis
2018-06-09 13:40 GMT+02:00 Gintautas Grigelionis : > 2018-06-09 12:54 GMT+02:00 Stefan Bodewig : > >> On 2018-06-09, Gintautas Grigelionis wrote: >> >> > ... needs a -html4 or -html5 option, otherwise the standard doclet >> emits a >> > warning. Som

Re: Bz 62324

2018-06-09 Thread Gintautas Grigelionis
2018-06-09 13:56 GMT+02:00 Jaikiran Pai : > > On 09/06/18 5:22 PM, Gintautas Grigelionis wrote: > >> >> Thanks for review, Jaikiran. You're correct, that is the proposed >> solution, >> adding a separator >> (a newline followed by an exception name

Re: Bz 62324

2018-06-09 Thread Gintautas Grigelionis
2018-06-09 13:31 GMT+02:00 Jaikiran Pai : > For easy reference, the bug in discussion is this one > https://bz.apache.org/bugzilla/show_bug.cgi?id=62324 > > > On 09/06/18 12:38 AM, Gintautas Grigelionis wrote: > >> Namely, a stack trace of the exception is logged (in deb

Re: javadoc in Java 10+

2018-06-09 Thread Gintautas Grigelionis
2018-06-09 12:54 GMT+02:00 Stefan Bodewig : > On 2018-06-09, Gintautas Grigelionis wrote: > > > ... needs a -html4 or -html5 option, otherwise the standard doclet emits > a > > warning. Something for Bugzilla? > > +1 > > Stefan > Please see https://bz.apac

javadoc in Java 10+

2018-06-09 Thread Gintautas Grigelionis
... needs a -html4 or -html5 option, otherwise the standard doclet emits a warning. Something for Bugzilla? Gintas

Re: Tooling update

2018-06-09 Thread Gintautas Grigelionis
Thanks, Stefan. Meanwhile, SpotBugs is reactivated in the nighlies now. I noticed, however, that execution order is important: if SpotBugs runs before Checkstyle, the latter bails out because of ANTLR. Gintas 2018-06-08 20:42 GMT+02:00 Stefan Bodewig : > On 2018-06-08, Gintautas Grigelio

Bz 62324

2018-06-08 Thread Gintautas Grigelionis
I was advised to solicit opinions regarding the change introduced as a fix for the abovementioned issue. It concerns how an event that has both a message and an exception is logged. Namely, a stack trace of the exception is logged (in debug mode only) without any separator from the preceding messa

Tooling update

2018-06-08 Thread Gintautas Grigelionis
I took the liberty to sync QA tools among Ant, Ivy and IvyDE. A couple of notes: Ant 1.10 having a Java 8 baseline permits migration from FindBugs to SpotBugs; I decided to it now rather than wait for dependency issues [1] to be resolved. Then I was surprised that Dependency Check indicates that th

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-06 Thread Gintautas Grigelionis
2018-06-06 14:31 GMT+02:00 Stefan Bodewig : > I guess here our API breaks down as we only ever deal with files or > directories (outside of the symlink task). > FileSet documentation should be more explicit about the matter, in particular explaining what "followsymlinks" really means. Would the

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-06 Thread Gintautas Grigelionis
2018-06-06 10:50 GMT+02:00 Stefan Bodewig : > On 2018-06-05, Gintautas Grigelionis wrote: > > > Stefan is right -- "followsymlinks" for the fileset should have been > called > > "skipsymlinks" or something like that. > > I'm afraid I don&#

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-04 Thread Gintautas Grigelionis
2018-06-04 8:26 GMT+02:00 Stefan Bodewig : > What happens when I do something like this > > > > > > I believe - but haven't tested it - that for symlinks is never > going to be invoked at all as DirectoryScanner will skip the symlink so > the attribute's value on ownedby is irrelevant. If I'

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-04 Thread Gintautas Grigelionis
2018-06-04 8:26 GMT+02:00 Stefan Bodewig : > What happens when I do something like this > > > > > > I believe - but haven't tested it - that for symlinks is never > going to be invoked at all as DirectoryScanner will skip the symlink so > the attribute's value on ownedby is irrelevant. If I'

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-01 Thread Gintautas Grigelionis
Hi Stefan, thanks for reviewing this. I missed the fact that filesets had a similar attribute. Hope everything is consistent now. Gintas 2018-05-28 17:00 GMT+02:00 Stefan Bodewig : > Hi Gintas > > you should probably check and document how the new followlinks attribute > interacts with fileset'

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-21 Thread Gintautas Grigelionis
2018-05-20 21:05 GMT+02:00 Gintautas Grigelionis : > 2018-05-18 16:11 GMT+02:00 Johan Corveleyn : > >> 2) There is clearly no consensus here on the merits / desirability of >> these bulk changes. Gintas, I understand your desire to move things >> along, and you clearly

Re: dependeset-test failures

2018-05-20 Thread Gintautas Grigelionis
2018-05-20 19:52 GMT+02:00 Stefan Bodewig : > > Hi all > > > while running all tests locally I saw dependeset-test is failing, they > > are also failing on Jenkins. > > Found it > > https://github.com/apache/ant/commit/11422630936848e82c7b13a > b3fa68a3003e10195#diff-d84918760549fe4c0e195ba6cbfef4

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-20 Thread Gintautas Grigelionis
2018-05-20 16:08 GMT+02:00 Stefan Bodewig : > I'm afraid you misunderstood my question. I didn't ask why streams may > be preferable over Enumerations when you write new code or change > existing code. I was asking how does this benefit the existing code > right now when there is no other change a

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-20 Thread Gintautas Grigelionis
2018-05-18 16:11 GMT+02:00 Johan Corveleyn : > 2) There is clearly no consensus here on the merits / desirability of > these bulk changes. Gintas, I understand your desire to move things > along, and you clearly have an opinion about it, but IMHO you really > need to stop doing any more bulk chang

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-20 Thread Gintautas Grigelionis
2018-05-18 16:51 GMT+02:00 Stefan Bodewig : > On 2018-05-18, Gintautas Grigelionis wrote: > > > I believe that Streams API can at least implement the logic run by an > > original Enumeration in a more concise way, or provide more powerful > idioms. > > That IMO

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-18 Thread Gintautas Grigelionis
1eb59eaf9f2b5d0b487aeb5e5022ccdL888 > [5] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624f > e50ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL1359 > > [6] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624f > e50ae82f0d11171b2#diff-b98a3d2097d6a9b5d7e0fc2e

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Gintautas Grigelionis
his to iterate over it and run some logic on it - all of > which was already possible with the enumeration that was already available. > > > -Jaikiran > > > > On 18/05/18 12:22 AM, Gintautas Grigelionis wrote: > >> Thanks for reviewing, I hope Spliterators will d

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Gintautas Grigelionis
Thanks for reviewing, I hope Spliterators will do a better job. Gintas 2018-05-17 8:37 GMT+02:00 Jaikiran Pai : > I agree. Especially when it's being done on something like for archive > entries which can betoo many depending on the archive that is being dealt > with. > > -Jaikiran > > > > On 17

Re: JdkObsolete

2018-05-16 Thread Gintautas Grigelionis
Nobody seems to be interested... Anyway, I commited a bunch of changes that deprecate CollectionUtils and Enumerations (in optional/junit) as well as reduce explicit use of Enumeration. 2018-05-09 9:08 GMT+02:00 Gintautas Grigelionis : > AFAICS, nobody has discussed [1] previously; do you th

Re: [GitHub] ant pull request #:

2018-05-13 Thread Gintautas Grigelionis
Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai : > I did plan to addit yesterday, but my local tests did not trigger the > package-info constant pool entry for some reason. So I decided to not rush > it in and spe

JdkObsolete

2018-05-09 Thread Gintautas Grigelionis
AFAICS, nobody has discussed [1] previously; do you think it's worth the while to do something about it? [1] http://errorprone.info/bugpattern/JdkObsolete

Re: Migrating Ivy and IvyDE site to asciidoc

2018-05-07 Thread Gintautas Grigelionis
2018-05-07 13:17 GMT+02:00 Nicolas Lalevée : > The issue isn’t about the format of the image but about the layout of the > page. If you have some proof of concept of how a home page can be done in > asciidoc, please share, in a gist of whatever. Which part of the front page is tricky? I guess it

Re: Migrating Ivy and IvyDE site to asciidoc

2018-05-06 Thread Gintautas Grigelionis
2018-04-23 15:25 GMT+02:00 Nicolas Lalevée : > One page I am worried about is the main page [2]. I am not sure there are > some sane asciidoc directives to render something similar. If you already > have ideas, please share. If I remember correctly there is directive to > blindly render content, w

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-06 Thread Gintautas Grigelionis
2018-05-04 8:32 GMT+02:00 Jan Matèrne (jhm) : > Changing Ants own test to use JUnit5 does not mean we have to change Ant > itself and don't have to cut a release. > > What do you want to move to "ant-legacy"? > You're right, JUnit 5 puts no new requirements on Ant. Should we continue a "legacy"

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-06 Thread Gintautas Grigelionis
2018-05-05 17:58 GMT+02:00 Stefan Bodewig : > What is the benefit of changing tests that currently pass when neither > the test itself nor the code under test is changed? > That would be avoiding repetitive code => lucidity. Eg, for every simple executeTarget("test") there are at least 3 more lin

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-03 Thread Gintautas Grigelionis
IMHO that would mean putting parts of Ant core into ant-legacy.jar Gintas 2018-05-03 19:03 GMT+02:00 Matt Sicker : > Yes, I'm definitely suggesting/hyping JUnit 5. :) >

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-03 Thread Gintautas Grigelionis
My focus was on maximising the use of JUnit 4 idioms. Are you suggesting a switch to JUnit 5 instead? Sounds like Ant 1.11 :-) Gintas 2018-05-03 17:12 GMT+02:00 Matt Sicker : > I've started using JUnit 5 in a personal project and found that it has a > lot more useful features for test parameters

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-03 Thread Gintautas Grigelionis
2018-05-03 11:06 GMT+02:00 Stefan Bodewig : > > I'm still not sure I understand which benefit you see by retrofitting > tests that have been written before @Parameterized was invented. They do > contain way too many asserts in a single test method, but all of them > pass, so this is somewhat moot a

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 13:13 GMT+00:00 Stefan Bodewig : > On 2018-04-30, Gintautas Grigelionis wrote: > > the overarching goal, however, is to reduce verbosity, because > > verbosity makes it easier to hide mistakes. > > This is your goal and we should have decided together whether we

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 11:20 GMT+00:00 Jan Matèrne (jhm) : > For that single point I think parametrization is 'good'. > If I count right, it impacted three test classes. > Why change all the others? > > Starting a discussion before such big changes would also be helpful. > Just to pick a nit, there are 9 par

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 10:45 GMT+00:00 Jan Matèrne (jhm) : > In my eyes most of the committers don't like these "code style" changes. > So please stop these changes and invest your energy more productive. > > I don't think it would be helpful if another committer starts reverting the > changes because of a di

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 10:43 GMT+00:00 Jaikiran Pai : > > On 30/04/18 12:52 PM, Gintautas Grigelionis wrote: > >> My apologies for offending anyone; just one last silly question: why >> uniformity is not a requirement? >> > I think it has already been explained in the other thr

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 10:35 GMT+00:00 Jaikiran Pai : > > On 30/04/18 3:52 PM, Gintautas Grigelionis wrote: > >> 2018-04-30 9:55 GMT+00:00 Stefan Bodewig : >> >> On 2018-04-30, Gintautas Grigelionis wrote: >>> >>> My apologies for offending anyone; just one last

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 9:55 GMT+00:00 Stefan Bodewig : > On 2018-04-30, Gintautas Grigelionis wrote: > > > My apologies for offending anyone; just one last silly question: why > > uniformity is not a requirement? > > Who's uniformity do you pick? There are so many choice

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? I believe that even one language that espoused TMTOWDI has moved to TIMTOWTDIBSCINABTE? Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai : > > On 30/04/18 11:12 AM, Gintautas Grigelionis

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Gintautas Grigelionis
Names of buildfiles used in tests can be found by "grep configureProject"? The point is that these names are used exactly once, and need not to be put in a field which is named inconsistently. Deviations from this rule of thumb indicate that tests are parameterized in a manner where each test has i

Re: Use of org.hamcrest.Matchers

2018-04-22 Thread Gintautas Grigelionis
2018-04-22 22:32 GMT+00:00 Martin Gainty : > MG>Hi Gintas please see question below > > I wish we could replace fetch.xml with an Ivy equivalent :-) > MG>lib/libraries.properties > MG>hamcrest-core.version=1.3 > MG>hamcrest-library.version=${hamcrest-core.version} > > MG>if fetch.xml is deprecated

Re: Use of org.hamcrest.Matchers

2018-04-22 Thread Gintautas Grigelionis
2018-04-22 13:56 GMT+00:00 Stefan Bodewig : On 2018-04-22, Gintautas Grigelionis wrote: > > > Hmm... are you sure that Gump has hamcrest-library? > > No, you are correct. I was under the impression it was using Hamcrest > 2.x while it was not - Hamcrest 2.x only contains a s

Re: Use of org.hamcrest.Matchers

2018-04-22 Thread Gintautas Grigelionis
Hmm... are you sure that Gump has hamcrest-library? By the looks of it, the classpath contains antlr 3 and bcel 5... Gintas 2018-04-22 8:45 GMT+00:00 Stefan Bodewig : > Hi > > when Apache Gump builds Ant it builds it against Hamcrest 2.x which used > to work fine as long as we didn't use many ma

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
2018-04-20 17:34 GMT+00:00 Nicolas Lalevée : > > > Le 20 avr. 2018 à 18:48, Gintautas Grigelionis > a écrit : > > > > 2018-04-20 15:26 GMT+00:00 Nicolas Lalevée <mailto:nicolas.lale...@hibnet.org>>: > > > >>> Le 20 avr. 2018 à 07:09, Gintaut

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
2018-04-20 15:26 GMT+00:00 Nicolas Lalevée : > > Le 20 avr. 2018 à 07:09, Gintautas Grigelionis > a écrit : > > > > I am refactoring Ant JUnit tests with a goal to make them more > > "IDE-friendly". I found several tests that are implictly dependent on >

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
what is the a suitable value of ant.home? Thanks, Gintas 2018-04-20 13:16 GMT+00:00 Jan Matèrne (jhm) : > Why not an assert with a meaningful message to test if the property is set? > > Jan > > > -Ursprüngliche Nachricht----- > > Von: Gintautas Grigelionis [m

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
; those assumptions? > > -Jaikiran > > > > On 20/04/18 10:39 AM, Gintautas Grigelionis wrote: > >> I am refactoring Ant JUnit tests with a goal to make them more >> "IDE-friendly". I found several tests that are implictly dependent on >> ant.home p

Ant JUnit tests

2018-04-19 Thread Gintautas Grigelionis
I am refactoring Ant JUnit tests with a goal to make them more "IDE-friendly". I found several tests that are implictly dependent on ant.home property being set. In these cases, the test should be prevented from execution by adding an assumption; however, perhaps there might be a suitable default,

Re: Include ANT_HOME location in "ant -version" ?

2018-04-19 Thread Gintautas Grigelionis
We ought to update the manual (in particular [1]) and make [2] (especially "ant -diagnostics") much more prominent. Gintas [1] https://ant.apache.org/manual/feedback.html [2] https://ant.apache.org/manual/install.html#Troubleshooting 2018-04-19 15:41 GMT+00:00 Jaikiran Pai : > In context of thi

Re: ant git commit: Yet more isEmpty()

2018-04-17 Thread Gintautas Grigelionis
2018-04-15 10:04 GMT+00:00 Stefan Bodewig : > On 2018-04-15, wrote: > > > @@ -275,10 +270,7 @@ public class DefaultLogger implements BuildLogger { > > new BufferedReader(new > StringReader(event.getMessage( { > > > message.append(r.lines().map(line ->

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Gintautas Grigelionis
2018-04-15 9:59 GMT+00:00 Stefan Bodewig : > On 2018-04-15, Gintautas Grigelionis wrote: > > > Could you please explain what alternative approach does the "root" > > property support > > It has been added with > https://github.com/apache/ant/commit/713331

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Gintautas Grigelionis
2018-04-14 16:23 GMT+00:00 Stefan Bodewig : > On 2018-04-13, Gintautas Grigelionis wrote: > > > 2018-04-13 5:33 GMT+00:00 Stefan Bodewig : > > >> Ant test cases are not designed to be run from an IDE, this has never > >> been a goal. I'm surprised this

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-13 Thread Gintautas Grigelionis
2018-04-13 5:33 GMT+00:00 Stefan Bodewig : > On 2018-04-12, Gintautas Grigelionis wrote: > > > 2018-04-12 15:18 GMT+00:00 Stefan Bodewig : > > >> On 2018-04-12, Gintautas Grigelionis wrote: > > >>> 2018-04-12 14:39 GMT+00:00 Stefan Bodewig : > > &g

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-12 Thread Gintautas Grigelionis
2018-04-12 15:18 GMT+00:00 Stefan Bodewig : > On 2018-04-12, Gintautas Grigelionis wrote: > > > 2018-04-12 14:39 GMT+00:00 Stefan Bodewig : > > >> On 2018-04-11, Gintautas Grigelionis wrote: > > >>> XMLCatalogTest is an example of unit tests complicated b

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-12 Thread Gintautas Grigelionis
2018-04-12 14:39 GMT+00:00 Stefan Bodewig : > On 2018-04-11, Gintautas Grigelionis wrote: > > > XMLCatalogTest is an example of unit tests complicated by root property. > > Actually, the test even passes if you remove the line using the property > as long as your current

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-12 Thread Gintautas Grigelionis
org/jira/browse/SUREFIRE-184> > issues.apache.org > I wanted to run the ant testcases using the maven-surefire-plugin (I > actually built all the ant jars using maven). The problem is that the > plugin sets a system property basedir that ant cannot override. > > ? > > Martin &g

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-11 Thread Gintautas Grigelionis
2018-04-11 6:25 GMT+00:00 Jaikiran Pai :´ > On 10/04/18 12:27 AM, Gintautas Grigelionis wrote: > >> I wrote earlier that I was about to review the unit tests. >> I was particularly unhappy about the root-property hack for an ancient >> deficiency in Surefire. >>

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-09 Thread Gintautas Grigelionis
2018-04-08 16:13 GMT+00:00 Stefan Bodewig : > On 2018-04-07, Gintautas Grigelionis wrote: > > > Java is a language with the syntax that changes and tries to accomodate > new > > patterns that make programming more efficient. > > Some of the patterns you've be

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-09 Thread Gintautas Grigelionis
2018-04-09 16:48 GMT+00:00 Nicolas Lalevée : > I have not been reading ant-dev lately, so I cannot comment much about the > last patches. For a while now I have not been involved much, but probably > the last reviews of patches bored me enough so I lost track of the dev > community entirely. > > N

Re: Ivy release

2018-04-09 Thread Gintautas Grigelionis
2018-04-09 17:20 GMT+00:00 Nicolas Lalevée : > The last thread about a release has been stuck in the discussion about > which PR, patch or Jira needed to be tackled before releasing. I suggest we > just move forward with the current master. I volunteer to build a 2.5.0-rc1. > > Nicolas > +1; mayb

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-07 Thread Gintautas Grigelionis
I sense a personal attack using broad, generalised accusations :-) Could we please stop the inflammatory comments and be more to the point? Yes, I did make a series of commits, but it's not endless. In fact, it is to end pretty soon. It is long merely because each commit is about a specific patter

Re: [2/4] ant git commit: Remove extraneous casts and (un)boxing, tersify logic

2018-04-06 Thread Gintautas Grigelionis
2018-04-06 16:09 GMT+00:00 Stefan Bodewig : > On 2018-04-01, wrote: > > > http://git-wip-us.apache.org/repos/asf/ant/blob/95495d57/src > /main/org/apache/tools/bzip2/BlockSort.java > > -- > > diff --git a/src/main/org/apache/tool

Re: ant git commit: Tidy up the code

2018-04-05 Thread Gintautas Grigelionis
2018-04-05 15:01 GMT+00:00 Matt Benson : By and large I approve of these changes, but I felt compelled to express > the opinion that I do not believe adding else after if/continue does > anything to simplify the code. IMO it does the opposite. > > Matt > The reasoning goes like this: the last con

Re: SBT branch in Ivy repo

2018-03-29 Thread Gintautas Grigelionis
question, sbt maintainers could either fork the original Ivy repo or become committers. Are there some political issues that I did not notice? Gintas 2018-03-29 14:49 GMT+02:00 Stefan Bodewig : > On 2018-03-25, Gintautas Grigelionis wrote: > > > I asked sbt developers [1] whether the

SBT branch in Ivy repo

2018-03-25 Thread Gintautas Grigelionis
I asked sbt developers [1] whether they would like to use the same Git repo. The consensus seems to be that sbt would like to have their own branch (or two). Would it be acceptable to graft sbt branch(es) to Ivy repo? Gintas [1] https://github.com/sbt/ivy/issues/28

Re: Snapshot access to regular users of Ant

2018-03-20 Thread Gintautas Grigelionis
2018-03-20 18:03 GMT+01:00 Stefan Bodewig : > On 2018-03-19, Gintautas Grigelionis wrote: > > > Maybe Ant Task Guidelines could be exposed under under "Contributing" > > as a landing page, and the relevant information could be moved into > > the manual? > &g

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Gintautas Grigelionis
2018-03-20 16:43 GMT+01:00 Stefan Bodewig : > On 2018-03-20, Gintautas Grigelionis wrote: > > > My understanding is that junitlauncher has a dependency on JUnit 4 > through > > vintage engine. I guess pom should provide profiles for engine choice. > See > > my

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Gintautas Grigelionis
My understanding is that junitlauncher has a dependency on JUnit 4 through vintage engine. I guess pom should provide profiles for engine choice. See my earlier questions re the task classpath. Gintas Den tis 20 mars 2018 16:28Stefan Bodewig skrev: > Hi > > I've just added a POM for ant-junitla

Re: ant git commit: Add dependency description

2018-03-19 Thread Gintautas Grigelionis
2018-03-17 16:09 GMT+01:00 Gintautas Grigelionis : > > > I was wondering why junitlauncher task depended on all jars being present > in Ant classpath with no possibility to set a separate classpath for the > task? > ... especially because ant -f fetch.xml seems to fetch both engines. Gintas

Re: Snapshot access to regular users of Ant

2018-03-19 Thread Gintautas Grigelionis
2018-03-19 9:20 GMT+01:00 Stefan Bodewig : > On 2018-03-19, Gintautas Grigelionis wrote: > > > Starting from > > > https://rawgit.com/apache/ant/master/manual/tutorial-tasks- > filesets-properties.html#contribute > > > to the end of document. Cf > > > ht

Re: Snapshot access to regular users of Ant

2018-03-19 Thread Gintautas Grigelionis
:00 Stefan Bodewig : > On 2018-03-17, Gintautas Grigelionis wrote: > > > On the other hand, I rewrote the manual (which was still talking about > > CVS), suggesting that the proper way to propose code changes would be > > a GitHub PR rather than an archive uploaded to Bugzill

Re: Snapshot access to regular users of Ant

2018-03-17 Thread Gintautas Grigelionis
Thanks for pointing this out. To me, it means one thing: release more often. The way I read it, publishing is not forbidden per se, but rather advertising. That's consistent with GitHub repo clones being available, but without "clone me at GitHub" ribbons. On the other hand, I rewrote the manual (

Re: ant git commit: Add dependency description

2018-03-17 Thread Gintautas Grigelionis
Thanks for correcting the omission. But, the task manual page states that junit.jar of JUnit 4 might still be necessary ... For junit-vintage engine: - junit-vintage-engine.jar - junit.jar (JUnit 4.x version) ... so perhaps it's worth a note anyway. I was wondering why junitlauncher tas

Re: Ivy old docs removed - documentation now resides under asciidoc

2018-03-14 Thread Gintautas Grigelionis
I made cross-document links work on GitHub for Ivy and IvyDE; for Ant, I added a link to rawgit. Gintas 2018-03-13 17:54 GMT+01:00 Gintautas Grigelionis : > I converted them, and they're dev-related. You can read them directly on > GitHub :-) > > Gintas > > 2018-03

Re: Ivy old docs removed - documentation now resides under asciidoc

2018-03-13 Thread Gintautas Grigelionis
gt; -Ursprüngliche Nachricht- > > Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com] > > Gesendet: Dienstag, 13. März 2018 10:14 > > An: Ant Developers List > > Betreff: Re: Ivy old docs removed - documentation now resides under > > asciidoc > > > &g

Re: Ivy old docs removed - documentation now resides under asciidoc

2018-03-13 Thread Gintautas Grigelionis
There is some documentation that has not been converted to asciidoc (eg ideas.txt or conflict-solving-algo.html). I will put them into dev, or does anyone have a better idea? Gintas 2018-03-07 11:49 GMT+01:00 Jaikiran Pai : > A while back we moved Ivy's documentation to Asciidoc. That automated

Re: Ant documentation

2018-03-11 Thread Gintautas Grigelionis
2018-03-02 13:13 GMT+01:00 Stefan Bodewig : > > All I wanted to say, keeping things visually consistent helps > > understanding. So, my simple set of rules is: > > >- is for attributes > >- is for values > >- is for shell variable names/property name/CLI options and > input > >

Re: Ant documentation

2018-03-05 Thread Gintautas Grigelionis
2018-03-02 13:13 GMT+01:00 Stefan Bodewig : > On 2018-03-02, Gintautas Grigelionis wrote: > > > 2018-03-02 9:54 GMT+01:00 Stefan Bodewig : > > >> On 2018-03-01, Stefan Bodewig wrote: > > >>>> On Thu, Mar 1, 2018 at 7:28 AM, Gintautas Grigelion

Re: Ant documentation

2018-03-02 Thread Gintautas Grigelionis
2018-03-02 9:54 GMT+01:00 Stefan Bodewig : > On 2018-03-01, Stefan Bodewig wrote: > > >> On Thu, Mar 1, 2018 at 7:28 AM, Gintautas Grigelionis < > >> g.grigelio...@gmail.com> wrote: > > >>> I tried then to use the replacement tags as consistently a

Re: Ant documentation

2018-03-01 Thread Gintautas Grigelionis
2018-03-02 7:44 GMT+01:00 Jan Matèrne (jhm) : > > > > > I made an attempt to convert the manual to HTML 5, the rationale > > > > being > > > > > that HTML 5 deprecates tt tag and recommends to replace it with > > > > > tags like code, kbd, samp and var, which could be used in a more > > > > consis

Re: Ant documentation

2018-03-01 Thread Gintautas Grigelionis
2018-03-01 10:43 GMT+01:00 Jan Matèrne (jhm) : > > > I made an attempt to convert the manual to HTML 5, the rationale > > being > > > that HTML 5 deprecates tt tag and recommends to replace it with tags > > > like code, kbd, samp and var, which could be used in a more > > consistent > > > way to a

Ant test failures on Java 9

2018-02-28 Thread Gintautas Grigelionis
I see following in my builds against master Build File: .../src/tests/antunit/taskdefs/copy-test.xml Tests run: 26, Failures: 0, Errors: 2, Time elapsed: 8,59 sec ... Target: test-with-some-resources-mapped-away caused an ERROR at line 471, column 29 Message: Can't copy a resource without

Ant documentation

2018-02-28 Thread Gintautas Grigelionis
I made an attempt to convert the manual to HTML 5, the rationale being that HTML 5 deprecates tt tag and recommends to replace it with tags like code, kbd, samp and var, which could be used in a more consistent way to achieve something closer to a semantic markup. I tried then to use the replaceme

Re: AW: committer += gintas

2018-02-28 Thread Gintautas Grigelionis
ry/git_based_websites_available > [2] https://svn.apache.org/viewvc/ant/ > > > > > > -Ursprüngliche Nachricht- > > Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com] > > Gesendet: Montag, 26. Februar 2018 09:46 > > An: Ant Developers List > > B

Re: Ivy release this month?

2018-02-27 Thread Gintautas Grigelionis
The ugly thing 2018-02-27 22:40 GMT+01:00 Gintautas Grigelionis : > 2018-02-18 20:30 GMT+01:00 Stefan Bodewig : > >> [Personally I prefer discussion by email over discussion in github >> issues.] >> > > The beauty is that GitHub comments are echoed in mail

Re: Ivy release this month?

2018-02-27 Thread Gintautas Grigelionis
2018-02-18 20:30 GMT+01:00 Stefan Bodewig : > [Personally I prefer discussion by email over discussion in github > issues.] > The beauty is that GitHub comments are echoed in mailing list, and, in case of PR mentioning JIRA issues, in JIRA as well. Gintas

Re: Ivy release this month?

2018-02-27 Thread Gintautas Grigelionis
2018-02-19 7:35 GMT+01:00 Stefan Bodewig : > On 2018-02-18, Gintautas Grigelionis wrote: > > > 2018-02-18 20:30 GMT+01:00 Stefan Bodewig : > > >> On 2018-02-18, Gintautas Grigelionis wrote: > > >>>- https://github.com/apache/ant-ivy/pull/63 (has to do w

Re: Ant 1.9.10 and Ivy

2018-02-27 Thread Gintautas Grigelionis
More specifically, that's Ant 1.10.2 thing... so, one more regression in master, I suppose. 1.10.1 and 1.9.10 work fine. Gintas 2018-02-27 20:23 GMT+01:00 Gintautas Grigelionis : > After Ant dependency in Ivy was updated to 1.9.10, I'm getting > > [javac] /Users/gintas/P

Ant 1.9.10 and Ivy

2018-02-27 Thread Gintautas Grigelionis
After Ant dependency in Ivy was updated to 1.9.10, I'm getting [javac] /Users/gintas/Projects/ant-ivy-asf/src/java/org/apache/ivy/ant/IvyCacheFileset.java:206: error: clone() in EmptyFileSet cannot override clone() in FileSet [javac] public Object clone() { [javac]

Re: Ivy release this month?

2018-02-27 Thread Gintautas Grigelionis
Frankly, I was doubtful about the classloader change. But, what use cases are there for java -jar ivy.jar -main ? As I understand it, it's about resolving an artifact and lauching whatever main class would be there in it. So, why not bootstrapping an Ivy build in a fancy way? But, the new classl

Re: committer += gintas

2018-02-26 Thread Gintautas Grigelionis
I was deferring that on purpose :-) see my previous e-mails regarding FishEye links or "Related Projects". Any chance of splitting of site sources to Git and using SVN for publication only? Gintas 2018-02-26 8:10 GMT+01:00 Jan Matèrne (jhm) : > I recognize that the contributor [1] page is not li

Re: Ivy release this month?

2018-02-18 Thread Gintautas Grigelionis
2018-02-18 20:30 GMT+01:00 Stefan Bodewig : > [Personally I prefer discussion by email over discussion in github > issues.] > > On 2018-02-18, Gintautas Grigelionis wrote: > > >- https://github.com/apache/ant-ivy/pull/63 (has to do with choice of > >generics, wi

Re: Ivy release this month?

2018-02-18 Thread Gintautas Grigelionis
I suggested previously how some of the contentious issues could be dealt with (no response AFAICS). In the meantime, I added the following PRs asking for some discussion - https://github.com/apache/ant-ivy/pull/63 (has to do with choice of generics, with are not set in stone yet); - http

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Gintautas Grigelionis
+1 Gintas 2018-02-09 21:16 GMT+01:00 Jan Matèrne (jhm) : > > What this specific test failure shows, though, is that we now no longer > > are able to distinguish between a resource that we could copy but can't > > because it doesn't provide a name and the case of "all resources have > > been stri

Re: [SECURITY] CVE-2017-5645: Apache Ant 1.9.9 and 1.10.1 - Apache Log4j 1.2.13 security vulnerability

2018-02-07 Thread Gintautas Grigelionis
use a different format like JSON > instead to avoid the vulnerability entirely. > > On 7 February 2018 at 12:03, Gintautas Grigelionis < > g.grigelio...@gmail.com> > wrote: > > > Exactly, what I meant is that it's worth pointing out that not even all > >

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-07 Thread Gintautas Grigelionis
2018-02-07 18:25 GMT+01:00 Stefan Bodewig : > > Maybe it will be easier to digest if we start at a higher level of what > needs to be changed. I don't think moving classes so we don't have any > split packages anymore will be enough. > > I'd expect we'd need to replace all code that deals with cla

Re: [SECURITY] CVE-2017-5645: Apache Ant 1.9.9 and 1.10.1 - Apache Log4j 1.2.13 security vulnerability

2018-02-07 Thread Gintautas Grigelionis
Exactly, what I meant is that it's worth pointing out that not even all versions of log4j 2.x are safe. Gintas 2018-02-07 18:18 GMT+01:00 Stefan Bodewig : > On 2018-02-07, Gintautas Grigelionis wrote: > > > The CVE says it affects SocketServer up to Log4j 2.8.2, so it's

Re: [SECURITY] CVE-2017-5645: Apache Ant 1.9.9 and 1.10.1 - Apache Log4j 1.2.13 security vulnerability

2018-02-07 Thread Gintautas Grigelionis
The CVE says it affects SocketServer up to Log4j 2.8.2, so it's not only Log4j 1.x issue. Did I miss something? Gintas 2018-02-07 8:11 GMT+01:00 Jan Matèrne (jhm) : > CVE-2017-5645: Apache Ant 1.9.9 and 1.10.1 - Apache Log4j 1.2.13 security > vulnerability > > > > Severity: low > > Vendor: The A

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-07 Thread Gintautas Grigelionis
2018-02-07 11:44 GMT+01:00 Stefan Bodewig : > On 2018-02-06, Gintautas Grigelionis wrote: > > > 2018-02-06 11:05 GMT+01:00 Stefan Bodewig : > > >> If the taskdef/typedef implementation classes are loaded via a module > >> path and a custom task lives on the

<    1   2   3   4   5   >