[GitHub] ant-ivy issue #53: suppressed warnings

2017-08-31 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Thanks! This is now merged to upstream. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 With all due respect, there are some refactorings worth attention IMHO. Besides, some deprecations need to be followed through 😉 --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Commit https://github.com/apache/ant-ivy/pull/53/commits/414651c8841a09a9d9d4b0365ee8e7227fba8429 in this PR has now been merged to upstream https://github.com/apache/ant-ivy/commit/1a283ab1be5b495

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 I'm sorry for not explaining the point with all the changes around foreach loops: they take anything that is iterable rather than an array (which Ivy is very fond of API-wise) and by doing so allow fo

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 D'uh... getExtends() must respect insertion order -- array straitjacket 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 This is strange, all tests still pass for me locally -- could someone elucidate what the problem is, please? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Commit https://github.com/apache/ant-ivy/pull/53/commits/432c42ad1ee54ab08ea8b8808086ba19d4880737 in this PR has now been merged upstream https://github.com/apache/ant-ivy/commit/080e96a6cdea2f5fe8

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 Sorry for additions to PR. I figured out a way to remove the last inconsistencies with generics without breaking the API. This PR will not change any more. I rebased my commits; you're welcome to cher

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Hi Gintas, Given the amount of commits and the changes involved in this PR, it's a bit difficult to review it. I think this PR even includes some of the changes that have already been inclu