[CANCELLED] [VOTE] Release Apache Ant 1.10.12 based on RC1
A couple of issues have been raised with the current RC1 release that is being voted upon: - Extra files in the source archive which weren't present in previous versions - Mismatch in the version numbers of BCEL and commons-net dependencies between the libraries.properties and the pom.xml files. As a result, I will cancel this vote and will initiate a new vote which should include these fixes, shortly. Thank you all for voting and testing the release artifacts. Sorry about the delay in my responses this week - it has been a busy week at work. -Jaikiran On 07/10/21 7:51 pm, Jaikiran Pai wrote: Hello Paul, On 05/10/21 2:27 pm, Paul King wrote: I was surprised to see binary jars in the src archives under lib/optional. I don't know the history, so perhaps it is fine. Thank you for testing this release. I had a look at our previous releases and they too contain the binary jars in the source archives. So it appears to be historical. Having said that, the current release appears to include a few more binary jars in the source archive's lib/optional as compared to a previous release. I'll spend time on this tomorrow to see if that's OK or if I have to regenerate the source archives. Thank you very much for bringing it to attention. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
On Sat, 2 Oct 2021 at 15:48, Gavin McDonald wrote: > > Please not that the ASF nor its projects release Binaries. > (They are provided to users as a convenience) > We also do not vote on releases based on Binaries. > > The vote should be based on whether or not the 'source' - that > is being released is good enough. > > Gav... > BCEL and commons-net dependency versions are not synced between libraries.properties and respective POMs. Gintas
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
On Thu, 7 Oct 2021 at 16:27, Jaikiran Pai wrote:
>
> On 07/10/21 11:27 am, Gintautas Grigelionis wrote:
> > If the goal of 1.10.12 is to be compilable on Java 17,
>
> This 1.10.12 release of Ant (like our previous releases) is a bug fix
> release. Ant 1.10.x require a Java 8+ runtime. This release changes
> nothing on that front. One of the bug fixes in this release is a javadoc
> task fix that is only applicable for Java 17 - that's the only
> "relevance" of Java 17 to this release. Like previous 1.10.x releases we
> have been making sure users and projects using Ant can use Ant to build
> their projects using latest Java versions of their choice.
>
Apologies, I used "compilable" when I meant "buildable".
More precisely, Ant core cannot run all its unit tests on Java 17 without
optional dependendencies.
> > shouldn't unit tests
> > for script-related tasks in Ant core be complemented with an assumption
> > that Rhino, Nashorn or Graal JS is around?
>
> I'm not sure what kind of assumption you mean. Is there any specific
> test case you have in mind? Our CI jobs run against various versions of
> Java, including early access releases and even the recently released
> Java 17. None of our tests have shown any relevant failures in these
> releases. If this is more of a general suggestion for our test cases in
> Ant and if this doesn't have an impact on the vote of this release,
> please create a separate thread to discuss that.
>
Maven (POM) builds should run against a set of JDKs as well to demonstrate
my point.
The assumption should be coded like
assumeNotNull("JavaScript not present", new
ScriptEngineManager().getEngineByName("javascript"));
Gintas
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
On 07/10/21 11:27 am, Gintautas Grigelionis wrote: If the goal of 1.10.12 is to be compilable on Java 17, This 1.10.12 release of Ant (like our previous releases) is a bug fix release. Ant 1.10.x require a Java 8+ runtime. This release changes nothing on that front. One of the bug fixes in this release is a javadoc task fix that is only applicable for Java 17 - that's the only "relevance" of Java 17 to this release. Like previous 1.10.x releases we have been making sure users and projects using Ant can use Ant to build their projects using latest Java versions of their choice. shouldn't unit tests for script-related tasks in Ant core be complemented with an assumption that Rhino, Nashorn or Graal JS is around? I'm not sure what kind of assumption you mean. Is there any specific test case you have in mind? Our CI jobs run against various versions of Java, including early access releases and even the recently released Java 17. None of our tests have shown any relevant failures in these releases. If this is more of a general suggestion for our test cases in Ant and if this doesn't have an impact on the vote of this release, please create a separate thread to discuss that. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
Hello Paul, On 05/10/21 2:27 pm, Paul King wrote: I was surprised to see binary jars in the src archives under lib/optional. I don't know the history, so perhaps it is fine. Thank you for testing this release. I had a look at our previous releases and they too contain the binary jars in the source archives. So it appears to be historical. Having said that, the current release appears to include a few more binary jars in the source archive's lib/optional as compared to a previous release. I'll spend time on this tomorrow to see if that's OK or if I have to regenerate the source archives. Thank you very much for bringing it to attention. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
If the goal of 1.10.12 is to be compilable on Java 17, shouldn't unit tests for script-related tasks in Ant core be complemented with an assumption that Rhino, Nashorn or Graal JS is around? Gintas On Tue, 5 Oct 2021 at 10:58, Paul King wrote: > +0 (non-binding) > > I checked: > * LICENSE & NOTICE seem okay > * HASH & SIG seem okay > * I ran against the Groovy test suite which has 100+ ant-related tests and > all continue to pass (using JDK16 and the upcoming Groovy 4) > > I was surprised to see binary jars in the src archives under lib/optional. > I don't know the history, so perhaps it is fine. > > Cheers, Paul. > > > > On Thu, Sep 30, 2021 at 12:58 PM Jaikiran Pai wrote: > > > I've created a release candidate for 1.10.12: > > > > git tag: ANT_1.10.12_RC1 > > on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 > > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > >revision: 50166 > > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant-1051/ > > Snapcraft Build > >Revision 21 in latest/candidate > > > > This release is mainly a bug fix release and the exact changes are noted > > in > > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. > > Of particular interest is the relatively minor bug fix in the javadoc > > task which is necessary for it to work properly in the recently released > > Java 17 version. > > > > This vote will be open at least for 72 hours and close no earlier than > > 4th October 2021 03:00 AM UTC (given that it's a weekend in the next > > couple of days, I decided to extend the voting period till Monday) > > > > > > -Jaikiran > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > > For additional commands, e-mail: dev-h...@ant.apache.org > > > > >
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
+0 (non-binding) I checked: * LICENSE & NOTICE seem okay * HASH & SIG seem okay * I ran against the Groovy test suite which has 100+ ant-related tests and all continue to pass (using JDK16 and the upcoming Groovy 4) I was surprised to see binary jars in the src archives under lib/optional. I don't know the history, so perhaps it is fine. Cheers, Paul. On Thu, Sep 30, 2021 at 12:58 PM Jaikiran Pai wrote: > I've created a release candidate for 1.10.12: > > git tag: ANT_1.10.12_RC1 > on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 > tarballs: https://dist.apache.org/repos/dist/dev/ant/ >revision: 50166 > Maven artifacts: > https://repository.apache.org/content/repositories/orgapacheant-1051/ > Snapcraft Build >Revision 21 in latest/candidate > > This release is mainly a bug fix release and the exact changes are noted > in > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. > Of particular interest is the relatively minor bug fix in the javadoc > task which is necessary for it to work properly in the recently released > Java 17 version. > > This vote will be open at least for 72 hours and close no earlier than > 4th October 2021 03:00 AM UTC (given that it's a weekend in the next > couple of days, I decided to extend the voting period till Monday) > > > -Jaikiran > > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
+1 Maarten Op donderdag 30 september 2021 04:58:56 CEST schreef Jaikiran Pai : I've created a release candidate for 1.10.12: git tag: ANT_1.10.12_RC1 on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 50166 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1051/ Snapcraft Build Revision 21 in latest/candidate This release is mainly a bug fix release and the exact changes are noted in https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of particular interest is the relatively minor bug fix in the javadoc task which is necessary for it to work properly in the recently released Java 17 version. This vote will be open at least for 72 hours and close no earlier than 4th October 2021 03:00 AM UTC (given that it's a weekend in the next couple of days, I decided to extend the voting period till Monday) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
I'll need one more PMC member's vote on this for me to move forward. Anyone have some time this week to test this? -Jaikiran On 03/10/21 3:23 pm, Stefan Bodewig wrote: On 2021-09-30, Jaikiran Pai wrote: This release is mainly a bug fix release and the exact changes are noted in https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of particular interest is the relatively minor bug fix in the javadoc task which is necessary for it to work properly in the recently released Java 17 version. +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
On 2021-09-30, Jaikiran Pai wrote: > This release is mainly a bug fix release and the exact changes are > noted in > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of > particular interest is the relatively minor bug fix in the javadoc > task which is necessary for it to work properly in the recently > released Java 17 version. +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
Hi. On Sat, Oct 2, 2021 at 2:28 PM Jaikiran Pai wrote: > +1 > > - Downloaded the .tar.gz binary > Please not that the ASF nor its projects release Binaries. (They are provided to users as a convenience) We also do not vote on releases based on Binaries. The vote should be based on whether or not the 'source' - that is being released is good enough. Gav... > - Checked the NOTICE file and some random manuals > > - Built internal projects using Java 8 and this version of Ant > > - Built some sample projects with Java 17 and this version Ant > > All looks fine. > > -Jaikiran > > On 30/09/21 8:28 am, Jaikiran Pai wrote: > > I've created a release candidate for 1.10.12: > > > > git tag: ANT_1.10.12_RC1 > > on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 > > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > > revision: 50166 > > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant-1051/ > > Snapcraft Build > > Revision 21 in latest/candidate > > > > This release is mainly a bug fix release and the exact changes are > > noted in > > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. > > Of particular interest is the relatively minor bug fix in the javadoc > > task which is necessary for it to work properly in the recently > > released Java 17 version. > > > > This vote will be open at least for 72 hours and close no earlier than > > 4th October 2021 03:00 AM UTC (given that it's a weekend in the next > > couple of days, I decided to extend the voting period till Monday) > > > > > > -Jaikiran > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > > -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
+1 - Downloaded the .tar.gz binary - Checked the NOTICE file and some random manuals - Built internal projects using Java 8 and this version of Ant - Built some sample projects with Java 17 and this version Ant All looks fine. -Jaikiran On 30/09/21 8:28 am, Jaikiran Pai wrote: I've created a release candidate for 1.10.12: git tag: ANT_1.10.12_RC1 on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 50166 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1051/ Snapcraft Build Revision 21 in latest/candidate This release is mainly a bug fix release and the exact changes are noted in https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of particular interest is the relatively minor bug fix in the javadoc task which is necessary for it to work properly in the recently released Java 17 version. This vote will be open at least for 72 hours and close no earlier than 4th October 2021 03:00 AM UTC (given that it's a weekend in the next couple of days, I decided to extend the voting period till Monday) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[VOTE] Release Apache Ant 1.10.12 based on RC1
I've created a release candidate for 1.10.12: git tag: ANT_1.10.12_RC1 on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 50166 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1051/ Snapcraft Build Revision 21 in latest/candidate This release is mainly a bug fix release and the exact changes are noted in https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of particular interest is the relatively minor bug fix in the javadoc task which is necessary for it to work properly in the recently released Java 17 version. This vote will be open at least for 72 hours and close no earlier than 4th October 2021 03:00 AM UTC (given that it's a weekend in the next couple of days, I decided to extend the voting period till Monday) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
