[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-10 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 Thanks Lewis. 1. I do see where extractJSONLDScript receives 'out' as a parameter, and within the for loop, passes out to another call to extractor.run(,out), (as somewhat recursive use,

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/60 1. Look at the call to [extractJSONLDScript](https://github.com/apache/any23/blob/master/core/src/main/java/org/apache/any23/extractor/html/EmbeddedJSONLDExtractor.java#L81-L82) we use it further

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 My Java skills may be quite rusty, hence the 3 year old JDK. Looking at implementation of method run(.., Document in, ExtractionResult out) in `EmbeddedJSONLDExtractor.java`, I see a couple things

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 Java version seems to have been the culprit. Thank you. ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/60 And mine is: ``` java version "1.8.0_162" Java(TM) SE Runtime Environment (build 1.8.0_162-b12) Java HotSpot(TM) 64-Bit Server VM (build 25.162-b12, mixed mode) ``` ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/60 ``` java version "1.8.0_131" Java(TM) SE Runtime Environment (build 1.8.0_131-b11) Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode) ``` ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 Which version are you running? I see the latest 1.8 u161 ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/60 No chance. Diff is empty. @ferrerod try updating your Java version. 1.8.51 is pretty old. ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 any chance your master isn't in sync with the one that's on github? ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 do you guys have a slack channel so I don't clutter a closed PR with noise? ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/60 @ferrerod I am unable to reproduce your error. Running `mvn clean install` on the master branch gives me: ``` [INFO] Apache Any23 ... SUCCESS [

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/60 Hi @ferrerod which Java version are you running? Master build is stable https://builds.apache.org/view/A/view/Any23/job/Any23-trunk/ ---

[GitHub] any23 issue #60: ANY23-291 Allow JSONLD scripts to be located anywhere in do...

2018-02-09 Thread ferrerod
Github user ferrerod commented on the issue: https://github.com/apache/any23/pull/60 @HansBrende @lewismc: Today, I cloned master and tried to build: mvn clean install and the core build is failing. I also saw code commented out in the run method that would have written out the