Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Greg Stein
Awesome. +1 On Wed, Feb 07, 2001 at 07:35:23PM -0500, Jeff Trawick wrote: There are some ideas here previously described by Mo DeJong. Additionally: . there is a way to avoid a warning for a certain platform: set apr_iconv_inbuf_const to 1 in hints.m4 for platforms where the parm is

Re: [PATCH] iconv tweak

2001-02-08 Thread Jeff Trawick
Sam TH [EMAIL PROTECTED] writes: The easiest way would probably be to use c++ to test this, since in c++ cast from a char ** to a const char ** is illegal, and generates and error. c++ is cool, but we can't require it so we'd have to see if it failed due to no c++, then back down to the c

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Roy T. Fielding
. we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the glibc version) Why not check for GCC and simply add -Werror to the compile? This should get RedHat 7.0 compiling cleanly, but I

Re: apr_ function prefixes

2001-02-08 Thread Doug MacEachern
On Tue, 6 Feb 2001, Roy T. Fielding wrote: +1 a.s.a.p. ok, i'm planning todo it later this evening.

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Jeff Trawick
Roy T. Fielding [EMAIL PROTECTED] writes: . we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the glibc version) Why not check for GCC and simply add -Werror to the compile?

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Sascha Schumann
On 7 Feb 2001, Jeff Trawick wrote: Jeff Trawick [EMAIL PROTECTED] writes: Roy T. Fielding [EMAIL PROTECTED] writes: . we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Jeff Trawick
Sascha Schumann [EMAIL PROTECTED] writes: On 7 Feb 2001, Jeff Trawick wrote: Jeff Trawick [EMAIL PROTECTED] writes: Roy T. Fielding [EMAIL PROTECTED] writes: . we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Roy T. Fielding
well, in practice it isn't so excellent :( the template for AC_TRY_COMPILE() doesn't even compile without warnings int main() { configure:4111: warning: function declaration isn't a prototype So we write our own macro that does compile without warnings. What was checked in doesn't work

Re: apr_ function prefixes

2001-02-08 Thread Doug MacEachern
to see the files that will change and the line number/name change: http://perl.apache.org/~dougm/apr_rename.txt feel free to shout if anything looks wrong, i won't commit for a few hours.

Re: apr_ function prefixes

2001-02-08 Thread Doug MacEachern
On Wed, 7 Feb 2001, B. W. Fitzpatrick wrote: +1. Wow that looks great. A toast to consistency! i'll drink to that :) Is there any way you could forward along the conversion script that you used (Or is that the one you sent last week)? This is going to break Subversion a bit, and maybe I

Re: FreeBSD 4.2 breakage (?)

2001-02-08 Thread Jeff Trawick
Jeff Trawick [EMAIL PROTECTED] writes: Regarding _POSIX_SOURCE: Trivia on _POSIX_SOURCE from Tru64... /* * If user defines _POSIX_SOURCE and if _POSIX_C_SOURCE is not defined, * define _POSIX_C_SOURCE to be 1. (_POSIX_SOURCE maps to the POSIX 1003.1 * standard from 1990). */

Re: apr_ function prefixes

2001-02-08 Thread Garrett Rooney
On Wed, Feb 07, 2001 at 10:59:47PM -0800, Doug MacEachern wrote: On Wed, 7 Feb 2001, B. W. Fitzpatrick wrote: +1. Wow that looks great. A toast to consistency! i'll drink to that :) Is there any way you could forward along the conversion script that you used (Or is that the one you

Re: apr_ function prefixes

2001-02-08 Thread B. W. Fitzpatrick
On Thursday, February 8, 2001, at 12:59 AM, Doug MacEachern wrote: On Wed, 7 Feb 2001, B. W. Fitzpatrick wrote: +1. Wow that looks great. A toast to consistency! i'll drink to that :) Is there any way you could forward along the conversion script that you used (Or is that the one you sent last

Re: apr_ function prefixes

2001-02-08 Thread Doug MacEachern
On Thu, 8 Feb 2001, Garrett Rooney wrote: on lines 278 and 283 you replace put with pupt for apr_os_exp_time_put and apr_os_thread_put. i assume that's wrong, since i can't for the life of me figure out what pupt would mean ;-) whoops! you're right, i'll fix that and pupt the changes back

Re: apr_ function prefixes

2001-02-08 Thread Jeff Trawick
Garrett Rooney [EMAIL PROTECTED] writes: on lines 278 and 283 you replace put with pupt for apr_os_exp_time_put and apr_os_thread_put. i assume that's wrong, since i can't for the life of me figure out what pupt would mean ;-) good for you if sleeping child cooperates I'll fix it up Real

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Jeff Trawick
Roy T. Fielding [EMAIL PROTECTED] writes: What was checked in doesn't work -- I now get warnings again on my platform, and mine is the one with the correct prototypes. Hmmm... I get no warnings on a system of each flavor (Tru64 and RedHat 6) and got no warnings. What warnings do