On Tue, May 20, 2008 at 01:49:45PM +1000, Bojan Smojver wrote:
Here is a patch I've been toying with. Essentially, it does these
things:
- cleans up PostgreSQL detection a bit more
- uses APRUTIL_PRIV_INCLUDES for all CPPFLAGS driver stuff (i.e. we
don't need to expose that to users of
On Tue, 2008-05-20 at 06:55 -0400, Bob Rossi wrote:
OK, I can try this, however, this patch still doesn't work on windows. I
get link errors on windows because the the libs aren't linked in.
$ ./pg_config --libs
-lpgport -lm -lSecur32 -lws2_32 -lshfolder
$ ./pg_config --libdir
On Wed, 2008-05-21 at 06:59 +1000, Bojan Smojver wrote:
OK, not a problem. We'll whack libs in there too.
Done. Hopefully that should be it.
--
Bojan
On Wed, May 21, 2008 at 07:14:44AM +1000, Bojan Smojver wrote:
On Wed, 2008-05-21 at 06:59 +1000, Bojan Smojver wrote:
OK, not a problem. We'll whack libs in there too.
Done. Hopefully that should be it.
Okay, this still doesn't work on windows, there are a couple changes I
would suggest,
On Tue, 2008-05-20 at 19:34 -0400, Bob Rossi wrote:
--- apr-util-1.3.x-2008-05-19-svn/build/dbd.m4 Tue May 20 17:15:38 2008
+++ apr-util-1.3.x-2008-05-19-svn.changed/build/dbd.m4 Tue May 20 19:18:23
2008
@@ -53,7 +53,8 @@
AC_PATH_PROG([PGSQL_CONFIG],[pg_config],,[$withval/bin])
On Wed, May 21, 2008 at 09:49:37AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 19:34 -0400, Bob Rossi wrote:
--- apr-util-1.3.x-2008-05-19-svn/build/dbd.m4 Tue May 20 17:15:38 2008
+++ apr-util-1.3.x-2008-05-19-svn.changed/build/dbd.m4 Tue May 20 19:18:23
2008
@@ -53,7 +53,8 @@
On Tue, 2008-05-20 at 20:04 -0400, Bob Rossi wrote:
I noticed you changed everything but the AC_CHECK_LIB, do you believe
that is unnecessary, or are you thinking about it?
Not required. We set LDFLAGS specifically for the test (hence the
APR_ADDTO(LDFLAGS, [$pgsql_LDFLAGS])) and then we
On Wed, May 21, 2008 at 10:07:25AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 20:04 -0400, Bob Rossi wrote:
I noticed you changed everything but the AC_CHECK_LIB, do you believe
that is unnecessary, or are you thinking about it?
Not required. We set LDFLAGS specifically for the
On Tue, 2008-05-20 at 20:26 -0400, Bob Rossi wrote:
That's because as you can see the -lpq went at the
end which is incorrect.
The real problem is that we're adding libraries to LDFLAGS. We should be
adding them to LIBS. I meant to fix that long time ago, but I always get
put off by the fact
On Wed, May 21, 2008 at 11:36:55AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 20:26 -0400, Bob Rossi wrote:
That's because as you can see the -lpq went at the
end which is incorrect.
The real problem is that we're adding libraries to LDFLAGS. We should be
adding them to LIBS. I
On Tue, 2008-05-20 at 21:47 -0400, Bob Rossi wrote:
That worked on windows! I don't have time to test linux now.
Thanks for testing. It works on Linux.
--
Bojan
On Sat, May 17, 2008 at 10:23:59AM +1000, Bojan Smojver wrote:
On Fri, 2008-05-16 at 06:26 -0400, Bob Rossi wrote:
configure:40279: gcc -o conftest -g -Wall -pthread -DLINUX=2
-D_REENTRANT -D_GNU_SOURCE conftest.c -lcrypt 5
configure:40285: $? = 0
configure:40313: result:
On Fri, May 16, 2008 at 11:21:46AM +1000, Bojan Smojver wrote:
On Thu, 2008-05-15 at 09:08 -0400, Bob Rossi wrote:
So,
I get a link error, because it needs to link against -lcrypt.
What kind of system do you have? Where does the -lcrypt live on your
system?
BTW, doing the pg_config
On Mon, 2008-05-19 at 15:54 -0400, Bob Rossi wrote:
So basically I need -lSecur32 and ws2_32. What can I do about this?
I don't have any Windows machines (nor development tools), so I cannot
do this. I'm sure someone else on the list that does will pick this up.
Sorry...
--
Bojan
On Tue, May 20, 2008 at 07:05:51AM +1000, Bojan Smojver wrote:
On Mon, 2008-05-19 at 15:54 -0400, Bob Rossi wrote:
So basically I need -lSecur32 and ws2_32. What can I do about this?
I don't have any Windows machines (nor development tools), so I cannot
do this. I'm sure someone else on
On Mon, 2008-05-19 at 16:07 -0400, Bob Rossi wrote:
You know, I really think you should be using the --libs there. What
could the downside be? It's not like you need to add all the --libs to
the apr libs. It's just setup temporarily to get the -lpq to link.
This returns libraries that were
Bojan Smojver wrote:
On Mon, 2008-05-19 at 16:07 -0400, Bob Rossi wrote:
You know, I really think you should be using the --libs there. What
could the downside be? It's not like you need to add all the --libs to
the apr libs. It's just setup temporarily to get the -lpq to link.
This returns
On Mon, May 19, 2008 at 04:22:18PM -0500, William A. Rowe, Jr. wrote:
Bojan Smojver wrote:
On Mon, 2008-05-19 at 16:07 -0400, Bob Rossi wrote:
You know, I really think you should be using the --libs there. What
could the downside be? It's not like you need to add all the --libs to
the apr
On Mon, 2008-05-19 at 16:22 -0500, William A. Rowe, Jr. wrote:
Well I'd rather it include more libraries than needed (which are not bound
on more sophisticated linkers) than an insufficient number.
OK, I'll do --libs then.
--
Bojan
On Tue, May 20, 2008 at 08:48:39AM +1000, Bojan Smojver wrote:
On Mon, 2008-05-19 at 16:22 -0500, William A. Rowe, Jr. wrote:
Well I'd rather it include more libraries than needed (which are not bound
on more sophisticated linkers) than an insufficient number.
OK, I'll do --libs then.
On Mon, 2008-05-19 at 20:05 -0400, Bob Rossi wrote:
If you make the change, I'll test out the latest snapshots and all your
fixes for me. Thanks so much Bojan!
Done. And you are welcome.
--
Bojan
On Tue, May 20, 2008 at 10:11:38AM +1000, Bojan Smojver wrote:
On Mon, 2008-05-19 at 20:05 -0400, Bob Rossi wrote:
If you make the change, I'll test out the latest snapshots and all your
fixes for me. Thanks so much Bojan!
Done. And you are welcome.
Hi Bojan,
This is almost correct.
On Mon, 2008-05-19 at 20:47 -0400, Bob Rossi wrote:
This is almost correct. It's simply missing the -L to the postgresql/lib
directory. My program failed to link because it couldn't find -lpgport
which lives there.
If fact, PostgreSQL manual
On Tue, 2008-05-20 at 11:21 +1000, Bojan Smojver wrote:
If fact, PostgreSQL manual
(http://www.postgresql.org/docs/8.3/static/libpq-build.html) confirms
that we should be using just --libdir.
BTW, if --libdir alone doesn't cut it for you for some reason, I'll add
--libs back too. But, if it
On Tue, May 20, 2008 at 11:24:03AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 11:21 +1000, Bojan Smojver wrote:
If fact, PostgreSQL manual
(http://www.postgresql.org/docs/8.3/static/libpq-build.html) confirms
that we should be using just --libdir.
BTW, if --libdir alone doesn't
Here is a patch I've been toying with. Essentially, it does these
things:
- cleans up PostgreSQL detection a bit more
- uses APRUTIL_PRIV_INCLUDES for all CPPFLAGS driver stuff (i.e. we
don't need to expose that to users of APU)
- is careful not to place LDFLAGS of drivers into APRUTIL_LDFLAGS
On Fri, May 16, 2008 at 01:34:29PM +1000, Bojan Smojver wrote:
On Thu, 2008-05-15 at 23:18 -0400, Bob Rossi wrote:
Ubuntu 7.04, /lib/libcrypt-2.5.so
OK.
OK, perhaps we should just add -lcrypt to the pg line? I could check to
see if this works on my system if you think this is a good
On Fri, 2008-05-16 at 06:26 -0400, Bob Rossi wrote:
configure:40279: gcc -o conftest -g -Wall -pthread -DLINUX=2 -D_REENTRANT
-D_GNU_SOURCE conftest.c -lcrypt 5
configure:40285: $? = 0
configure:40313: result: -lcrypt
So, the test for crypt actually succeeds. Maybe the whole thing
On Sat, May 17, 2008 at 10:23:59AM +1000, Bojan Smojver wrote:
On Fri, 2008-05-16 at 06:26 -0400, Bob Rossi wrote:
configure:40279: gcc -o conftest -g -Wall -pthread -DLINUX=2
-D_REENTRANT -D_GNU_SOURCE conftest.c -lcrypt 5
configure:40285: $? = 0
configure:40313: result:
Bob Rossi wrote:
Yes, that worked! I suggest putting a comment in the patch that says
that crypt must be done before postgresql, otherwise it will fail to
test link.
Actually that's half-assed. We have to back out the changes that the DBD
detection causes for LDFLAGS and LIBS, etc, in
On Fri, 2008-05-16 at 20:33 -0400, Bob Rossi wrote:
Yes, that worked!
Cool. Thanks for testing!
Do you think this will get into the 1.3 snapshot?
Well, I think it should go in, hence I'll commit to trunk and ask other
committers to comment on in before backporting to 1.3.x/1.2.x. We need
to
On Fri, 2008-05-16 at 19:42 -0500, William A. Rowe, Jr. wrote:
Actually that's half-assed. We have to back out the changes that the DBD
detection causes for LDFLAGS and LIBS, etc, in order to ensure that later
tests aren't bogus.
We already did that, no?
We do it like this in build/dbd.m4:
On Sat, 2008-05-17 at 10:43 +1000, Bojan Smojver wrote:
ask other committers to comment
Well, I didn't have to ask, did I? ;-)
--
Bojan
Bojan Smojver wrote:
On Sat, 2008-05-17 at 10:43 +1000, Bojan Smojver wrote:
ask other committers to comment
Well, I didn't have to ask, did I? ;-)
No but since you did, my +1.
On Fri, 2008-05-16 at 19:51 -0500, William A. Rowe, Jr. wrote:
No but since you did, my +1.
Thanks.
BTW, there is one place in PostgreSQL detection where we don't return
LDFLAGS and CPPFLAGS back to normal. I'll fix that too.
--
Bojan
On Sat, 2008-05-17 at 10:53 +1000, Bojan Smojver wrote:
BTW, there is one place in PostgreSQL detection where we don't return
LDFLAGS and CPPFLAGS back to normal. I'll fix that too.
Ignore this comment please - this is for the case we we don't fiddle
with CPPFLAGS/LDFLAGS.
--
Bojan
Hi,
I just downloaded and installed postgresql, and installed it into a
root. Then I used the apr-util option --with-pgsql. The apr-util
autotools machinary failed. That's because it tries to link a program
against -lpg, but doesn't use the other libs specified in pg_config. So,
I get a link
On Thu, 2008-05-15 at 09:08 -0400, Bob Rossi wrote:
Attached is the patch that fixes the problem, what do you think?
Yeah, we do this kind of thing for other databases already. I'll have a
look at it today.
--
Bojan
On Thu, 2008-05-15 at 09:08 -0400, Bob Rossi wrote:
So,
I get a link error, because it needs to link against -lcrypt.
What kind of system do you have? Where does the -lcrypt live on your
system?
BTW, doing the pg_config --libs will not give us the right thing here.
For instance, on my system,
On Fri, May 16, 2008 at 11:21:46AM +1000, Bojan Smojver wrote:
On Thu, 2008-05-15 at 09:08 -0400, Bob Rossi wrote:
So,
I get a link error, because it needs to link against -lcrypt.
What kind of system do you have? Where does the -lcrypt live on your
system?
Ubuntu 7.04,
On Thu, 2008-05-15 at 23:18 -0400, Bob Rossi wrote:
Ubuntu 7.04, /lib/libcrypt-2.5.so
OK.
OK, perhaps we should just add -lcrypt to the pg line? I could check to
see if this works on my system if you think this is a good idea.
Hmm, not sure if hardcoding here is the right thing to do. I
41 matches
Mail list logo
