Neil Conway wrote:
pollset_wakeup shouldn't exist imo, its place is in something like the
apr_events_* api that was proposed and never adopted at one point, but
it was added anyways because of a use case needed by tomcat nc (?)
I agree that a higher-level events API would be useful, but in
Neil Conway wrote:
Attached is a straightforward patch against svn trunk that fixes
various doxygen usage warnings and minor errors.
Committed to trunk, and backported to v1.4 and v1.3.
Regards,
Graham
--
-Original Message-
From: Bert Huijben [mailto:b...@qqmail.nl]
Sent: maandag 9 november 2009 10:05
To: 'William A. Rowe, Jr.'
Cc: 'Philip Martin'; 'Bert Huijben'; dev@apr.apache.org;
d...@subversion.tigris.org
Subject: RE: Windows drive letter check fails on lower case cwd
Neil Conway wrote:
Attached is a patch against trunk that updates the documentation for
apr_poll to describe this behavior. I also fixed a few minor doxygen
issues along the way.
Committed to trunk and v1.4.
Regards,
Graham
--
Another minor point on a related subject: the documentation for
pollcb_create() states that the size parameter controls The maximum
number of descriptors that a single _poll can return. This isn't true
for the poll(2) pollcb method, however: _add() returns APR_ENOMEM if
the number of active
apr_pollset_wakeup() is buggy when used with APR_POLLSET_NOCOPY,
because create_wakeup_pipe() passes a stack-allocated apr_pollfd_t to
apr_pollset_add(). This is unsafe if the user specified
APR_POLLSET_NOCOPY when creating the pollset.
The attached patch fixes this by adding an apr_pollfd_t for
Attached is a slightly revised version of this patch. Changes:
* Initialize the apr_pool_t field of the apr_pollfd_t we use for the
wakeup pipe. Not clear what this field is actually used for (candidate
for removal in APR2?), but we may as well be tidy.
* Fix a minor bug in one of the versions
