Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-29 Thread Yao Li
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote: > > jdbc/connectors/JDBCConnection.java > > Lines 10 (patched) > > > > > > OMRSConnection --> JDBCConnection yes fixed, and also change the class name to

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-29 Thread Yao Li
> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/README.md > > Lines 8 (patched) > > > > > > should be "... subclass of an OCF Connector"? yes, fixed, thanks > On Jan. 18, 2018, 12:13 p.m., Mandy

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195710 --- jdbc/connectors/JDBCConnection.java Lines 10 (patched)

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Mandy Chessell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195714 --- jdbc/README.md Lines 8 (patched)

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 18, 2018, 10:09 a.m.) Review request for atlas and Mandy