> On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/README.md > > Lines 8 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line8> > > > > should be "... subclass of an OCF Connector"?
yes, fixed, thanks > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/README.md > > Lines 9 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line9> > > > > databases yes, fixed, thanks > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/README.md > > Lines 11 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line11> > > > > Need to exmplain the relationship between this JDBC Connector and the > > standard JDBC Connector that people are familiar with. change the name to OCF Database Connector, it will be more clear for people to know it is an OCF and for database connection > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/README.md > > Lines 17 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941455#file1941455line17> > > > > Capitial letter at the start of a sentence. Also need more context. > > For example, what is Gaian? add introduction to Gaian and purpose for the GaianJDBCConnector > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/connectors/JDBCConnection.java > > Lines 8 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941456#file1941456line8> > > > > This class name is going to be confusing to people who are familiar > > with the JDBC standard. I think It should have a different name. Eg > > OCFDatabaseConnection yes, it was confusing when i wrote the code. and now the whole module called OCF Database Connector. this class will name as OCFDatabaseConnection > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/connectors/JDBCConnector.java > > Lines 10 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941457#file1941457line10> > > > > The name of this class is confusing because it is not a JDBCConnector. > > JDBC is a standard and this connector does not implement the standard. So > > I would suggest naming it something like OCFDatabaseConnector. yes, agree with you. now the whole module called OCF Database Connector. this class will name as OCFDatabaseConnector > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/ffdc/ConnectionCheckedException.java > > Lines 10 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941462#file1941462line10> > > > > This is confusing to create a new exception that has the same name as > > one of the OCF exceptions. It should have a different name. change it to DatabaseAccessCheckedException extends OCFDatabaseCheckedExceptionBase > On Jan. 18, 2018, 12:13 p.m., Mandy Chessell wrote: > > jdbc/ffdc/ExecutionCheckedException.java > > Lines 14 (patched) > > <https://reviews.apache.org/r/65123/diff/2/?file=1941463#file1941463line14> > > > > Should this extend JDBCConnectorCheckedExceptionBase? deleted this one and directly use ConnectorCheckedException from ocf module - Yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195714 ----------------------------------------------------------- On Jan. 18, 2018, 10:09 a.m., Yao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65123/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 10:09 a.m.) > > > Review request for atlas and Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > this is the JDBC Connector code for Connector to Gaian. It is related to Open > Connector Framework. The JIRA can be found > https://issues.apache.org/jira/browse/ATLAS-2298 > > > Diffs > ----- > > jdbc/README.md PRE-CREATION > jdbc/connectors/JDBCConnection.java PRE-CREATION > jdbc/connectors/JDBCConnector.java PRE-CREATION > jdbc/connectors/JDBCConnectorBase.java PRE-CREATION > jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION > jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION > jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION > jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION > jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION > jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION > jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION > jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION > jdbc/pom.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/65123/diff/2/ > > > Testing > ------- > > create an instance of the Connector and use getData() function. Gaian has to > be set up in advance. > > > Thanks, > > Yao Li > >
