----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/#review195714 -----------------------------------------------------------
jdbc/README.md Lines 8 (patched) <https://reviews.apache.org/r/65123/#comment274993> should be "... subclass of an OCF Connector"? jdbc/README.md Lines 9 (patched) <https://reviews.apache.org/r/65123/#comment274995> databases jdbc/README.md Lines 11 (patched) <https://reviews.apache.org/r/65123/#comment274996> Need to exmplain the relationship between this JDBC Connector and the standard JDBC Connector that people are familiar with. jdbc/README.md Lines 17 (patched) <https://reviews.apache.org/r/65123/#comment274994> Capitial letter at the start of a sentence. Also need more context. For example, what is Gaian? jdbc/connectors/JDBCConnection.java Lines 8 (patched) <https://reviews.apache.org/r/65123/#comment274997> This class name is going to be confusing to people who are familiar with the JDBC standard. I think It should have a different name. Eg OCFDatabaseConnection jdbc/connectors/JDBCConnector.java Lines 10 (patched) <https://reviews.apache.org/r/65123/#comment274998> The name of this class is confusing because it is not a JDBCConnector. JDBC is a standard and this connector does not implement the standard. So I would suggest naming it something like OCFDatabaseConnector. jdbc/ffdc/ConnectionCheckedException.java Lines 10 (patched) <https://reviews.apache.org/r/65123/#comment274999> This is confusing to create a new exception that has the same name as one of the OCF exceptions. It should have a different name. jdbc/ffdc/ExecutionCheckedException.java Lines 14 (patched) <https://reviews.apache.org/r/65123/#comment275001> Should this extend JDBCConnectorCheckedExceptionBase? - Mandy Chessell On Jan. 18, 2018, 10:09 a.m., Yao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65123/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 10:09 a.m.) > > > Review request for atlas and Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > this is the JDBC Connector code for Connector to Gaian. It is related to Open > Connector Framework. The JIRA can be found > https://issues.apache.org/jira/browse/ATLAS-2298 > > > Diffs > ----- > > jdbc/README.md PRE-CREATION > jdbc/connectors/JDBCConnection.java PRE-CREATION > jdbc/connectors/JDBCConnector.java PRE-CREATION > jdbc/connectors/JDBCConnectorBase.java PRE-CREATION > jdbc/connectors/JDBCConnectorProviderBase.java PRE-CREATION > jdbc/connectors/gaian/GaianJDBCConnector.java PRE-CREATION > jdbc/connectors/gaian/GaianJDBCConnectorProvider.java PRE-CREATION > jdbc/ffdc/ConnectionCheckedException.java PRE-CREATION > jdbc/ffdc/ExecutionCheckedException.java PRE-CREATION > jdbc/ffdc/JDBCConnectorCheckedExceptionBase.java PRE-CREATION > jdbc/ffdc/JDBCConnectorErrorCode.java PRE-CREATION > jdbc/ffdc/JDBCConnectorRuntimeException.java PRE-CREATION > jdbc/pom.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/65123/diff/2/ > > > Testing > ------- > > create an instance of the Connector and use getData() function. Gaian has to > be set up in advance. > > > Thanks, > > Yao Li > >
