Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/ --- (Updated May 29, 2019, 3:29 p.m.) Review request for atlas, Aadarsh Jajodia,

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/#review215585 --- Ship it! Ship It! - Sarath Subramanian On May 29, 2019,

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 28, 2019, 10:58 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > > Line 114 (original), 114 (patched) > > > > > >

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/ --- (Updated May 28, 2019, 9:19 p.m.) Review request for atlas, Aadarsh Jajodia,

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > > Lines 201-205 (patched) > > > > > > Can we also add a unit test which

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 23 (patched) > > > > > > nit: unused imports, consider

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/#review215546 --- Fix it, then Ship it!

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 561-562 (patched) > > > > > > Maybe use long for both?

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/#review215511 --- Fix it, then Ship it! Overall looks good to me. Some minor

Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/ --- Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath