Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218374 --- addons/models/4000-MachineLearning/4010-ml_model.json Line 328

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 23, 2019, 10:20 p.m., Karthik Manamcheri wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Line 328 (original), 328 (patched) > > > > > > Why do we need this relationship? We can

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218372 --- Ship it! I deployed these models on an Atlas server and

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218371 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 23, 2019, 9:22

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 23, 2019, 9:22 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 23, 2019, 6:29 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 22, 2019, 9:58 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 9:08 p.m., Sridhar K wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 203 (patched) > > > > > > Instead of modifying addons/models/-Area0/0010-base_model.json, can > > you

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 6:31 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 123 (patched) > > > > > > I am not the right person for this comment. But, this name looks > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 9:08 p.m., Sridhar K wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 203 (patched) > > > > > > Instead of modifying addons/models/-Area0/0010-base_model.json, can > > you

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 9:08 p.m., Sridhar K wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 203 (patched) > > > > > > Instead of modifying addons/models/-Area0/0010-base_model.json, can > > you

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218339 --- addons/models/-Area0/0010-base_model.json Lines 203

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 6:31 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 269 (patched) > > > > > > I am wondering if we should have a first class entity called "User" > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 22, 2019, 8:04 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 6:31 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 123 (patched) > > > > > > I am not the right person for this comment. But, this name looks > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218332 --- addons/models/4000-MachineLearning/4010-ml_model.json Lines 123

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 5:43 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 46 (patched) > > > > > > is it different from Name? > > Sridhar K wrote: > We have name

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218328 --- Minor comments. all related to attribute names. Please submit

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 3:27 p.m., Karthik Manamcheri wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 293 (patched) > > > > > > Should this also be an enum? What types are we envisioning?

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218322 --- addons/models/4000-MachineLearning/4010-ml_model.json Lines 293

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 21, 2019, 6:51 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 21, 2019, 6:11 p.m., Sarath Subramanian wrote: > > Move the ml model to a new directory in addons/models => > > 4000-MachineLearning > > > > -ml_model.json => 4010-ml_model.json done. Thanks! - Na --- This is an

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218305 --- Move the ml model to a new directory in addons/models =>

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218304 --- Ship it! Ship It! - Anand Patil On Oct. 21, 2019, 4:13

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 21, 2019, 4:13 a.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 18, 2019, 11:07 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 27 (patched) > > > > > > Suggest aligning with the CML model deployment statuses for now: > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 18, 2019, 11:07 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 27 (patched) > > > > > > Suggest aligning with the CML model deployment statuses for now: > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218292 --- addons/models/1000-Hadoop/-ml_model.json Lines 27 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 18, 2019, 2 a.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 336 (patched) > > > > > > Like model builds, recommend adding an attribute for number of GPU's. done >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:45 p.m., Karthik Manamcheri wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 286 (patched) > > > > > > What is the purpose of "updatedAt"? I removed it. if user wants it, can

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 51 (patched) > > > > > > Those fields are optional. So if some projects cannot provide those > > fields, that is

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 165 (patched) > > > > > > Same comment about metadata: gitCommitId, hyperParameters, > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 10 (patched) > > > > > > Why make project a subtype of dataset? Atlas server has a lot of code that build

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 18 (patched) > > > > > > Can this really be optional? I will drop this attribute, and user

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 10 (patched) > > > > > > "DataSet" in Atlas has different meaning from the meaning in ML. > > > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 10 (patched) > > > > > > "DataSet" in Atlas has different meaning from the meaning in ML. > > > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 8:10 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 175 (patched) > > > > > > do you want to define types that can be used for hyperparameters? > > > > Can

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218238 --- addons/models/1000-Hadoop/-ml_model.json Lines 135 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218237 --- addons/models/1000-Hadoop/-ml_model.json Lines 10 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218235 --- addons/models/1000-Hadoop/-ml_model.json Lines 286 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218231 --- addons/models/1000-Hadoop/-ml_model.json Lines 10 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 15, 2019, 9:47 p.m.) Review request for atlas, Ashutosh Mestry,

Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and