Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

> On Dec. 2, 2019, 5:06 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java > > Lines 126 (patched) > > > > > > Having AtlasNamespaceAttribute extend from

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218870 --- intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218867 ---

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218869 ---

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218868 --- Patch fails to apply, can you please rebase. - Sarath

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 22, 2019, 2:03 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218727 --- I don't see namespace attribuites indexed. This should be

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 21, 2019, 3:03 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 20, 2019, 2:24 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 19, 2019, 11:07 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

> On Nov. 15, 2019, 1:03 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java > > Lines 264 (patched) > > > > > > this is not valid.

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218640 --- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 14, 2019, 12:08 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218589 ---

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 8, 2019, 9:42 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218462 --- Ship it! Ship It! - Sarath Subramanian On Oct. 24, 2019,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218418 --- Aadarsh - the patch looks good. Thanks! - Madhan Neethiraj On

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

> On Oct. 23, 2019, 8:20 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java > > Lines 155 (patched) > > > > > > displayName is nto used; consider removing

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Oct. 24, 2019, 11:32 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

> On Oct. 22, 2019, 9:38 p.m., Le Ma wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java > > Lines 106 (patched) > > > > > > instead of using a variable i, Why not using for (int i =

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

> On Oct. 23, 2019, 12:30 a.m., Madhan Neethiraj wrote: > > - please update AtlasTypesDef to add attribute: private > > List namespaceDefs; Will be adding this in the next update of this patch - Aadarsh --- This is an automatically

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218367 ---

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218358 ---

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218345 --- - please update AtlasTypesDef to add attribute: private List

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/#review218343 ---

Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan Neethiraj,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Oct. 22, 2019, 9:08 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Oct. 22, 2019, 8:58 p.m.) Review request for atlas, Ashutosh Mestry,