Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/
---

(Updated June 8, 2018, 9:36 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Nixon Rodrigues.


Changes
---

addressed review comments.


Bugs: ATLAS-2751
https://issues.apache.org/jira/browse/ATLAS-2751


Repository: atlas


Description
---

Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
zookeeper connection timeout.


Diffs (updated)
-

  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
00e56e33f 


Diff: https://reviews.apache.org/r/67514/diff/2/

Changes: https://reviews.apache.org/r/67514/diff/1-2/


Testing
---

Manually tested in HA cluster toggling active and passive state. consumers 
process hook messages.

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console


Thanks,

Sarath Subramanian

Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/#review204516
---



Would it help to update stop() to set consumer=null and producer=null?


notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
Line 226 (original), 226 (patched)


"consumer != null" doesn't seem necessary here.



notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
Lines 298 (patched)


Consider reading this string from a configuration - like:
  atlas.kafka.error.message.consumer_closed=This consumer has already been 
closed."
  
This can handling of Kafka message changes easier.


- Madhan Neethiraj


On June 8, 2018, 10:50 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67514/
> ---
> 
> (Updated June 8, 2018, 10:50 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2751
> https://issues.apache.org/jira/browse/ATLAS-2751
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
> zookeeper connection timeout.
> 
> 
> Diffs
> -
> 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 00e56e33f 
> 
> 
> Diff: https://reviews.apache.org/r/67514/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested in HA cluster toggling active and passive state. consumers 
> process hook messages.
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

[Ashutosh Mestry]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/#review204508
---


Ship it!




Ship It!

- Ashutosh Mestry


On June 8, 2018, 10:50 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67514/
> ---
> 
> (Updated June 8, 2018, 10:50 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2751
> https://issues.apache.org/jira/browse/ATLAS-2751
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
> zookeeper connection timeout.
> 
> 
> Diffs
> -
> 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 00e56e33f 
> 
> 
> Diff: https://reviews.apache.org/r/67514/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested in HA cluster toggling active and passive state. consumers 
> process hook messages.
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

[jira] [Commented] (ATLAS-2750) Migration Import: Classification with Maps of Primitive Type are Not Processed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506684#comment-16506684
 ] 

ASF subversion and git services commented on ATLAS-2750:


Commit 7174257bf131f531a5f86ccb574ddb512af69623 in atlas's branch 
refs/heads/master from [~ashutoshm]
[ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=7174257 ]

ATLAS-2748, ATLAS-2849, ATLAS-2750: Edges' state preserved during import. 
Classification dissociation fails on imported entities with classifications. 
Processing classifications with attributes containing maps and arrays.


> Migration Import: Classification with Maps of Primitive Type are Not Processed
> --
>
> Key: ATLAS-2750
> URL: https://issues.apache.org/jira/browse/ATLAS-2750
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0, trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-2750-Processing-classifications-with-attribute.patch
>
>
> *Pre-requisites*
> Atlas v0.8 with types like the one attached (_tag_with_map_of_map_). Create 
> entities and associate the tag with these entities.
> *Steps to Reproduce*
>  * Use Atlas v1.0 and perform migration import.
>  * From _Classification_ tab select _tag_with_map_of_map._
> *Expected behavior*: Associated entity should be displayed.
> *Actual behavior*: Entity is not displayed. Server logs shows cast exception, 
> '_cannot cast list to map_'.
> *Root cause*
> The migration import process maintains an inventory of types that use maps of 
> primitive and non-primitive type. __The _TypesWithCollectionsFinder_ 
> populates this. This class was not processing classification types. Hence, 
> during import the classification instance vertices were left unprocessed for 
> maps and arrays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2748) Migration Import: Deleted Edges Marked as ACTIVE after Import

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506683#comment-16506683
 ] 

ASF subversion and git services commented on ATLAS-2748:


Commit 7174257bf131f531a5f86ccb574ddb512af69623 in atlas's branch 
refs/heads/master from [~ashutoshm]
[ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=7174257 ]

ATLAS-2748, ATLAS-2849, ATLAS-2750: Edges' state preserved during import. 
Classification dissociation fails on imported entities with classifications. 
Processing classifications with attributes containing maps and arrays.


> Migration Import: Deleted Edges Marked as ACTIVE after Import
> -
>
> Key: ATLAS-2748
> URL: https://issues.apache.org/jira/browse/ATLAS-2748
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 1.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-2748-Edges-state-preserved-during-import.patch
>
>
> *Pre-requisites*
> On Atlas v0.8, from Hive (Beeline):
>  * Create a _hive_db,_ say _stocks_, with couple of tables with few columns 
> say _daily_ and _weekly_.
>  * Drop _weekly_.
> Perform migration export.
> Steps to duplicate:
>  * Perform migration import.
> *Expected results*: Relationship edges between _stocks_ and weekly should 
> continue to preserve its ___state_ to _DELETED._
> *Actual result*:  Relationship edges between _stocks_ and weekly is has 
> ___state_ set to ACTIVE_._
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ATLAS-2751) Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

[Sarath Subramanian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian reassigned ATLAS-2751:
-

Assignee: Sarath Subramanian

Code Review: https://reviews.apache.org/r/67514/

> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
> zookeeper connection timeout.
> -
>
> Key: ATLAS-2751
> URL: https://issues.apache.org/jira/browse/ATLAS-2751
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.1.0
>
>
> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
> zookeeper connection timeout.
> * Below snapshot showing, atlas going into passive state with notification 
> consumer thread shutdown
> {noformat}
> 2018-05-21 18:45:42,156 INFO - 
> [org.apache.ranger.audit.queue.AuditBatchQueue1:] ~ Audit Status Log: 
> name=atlas.async.multi_dest.batch, 
> finalDestination=atlas.async.multi_dest.batch.solr, interval=01:00.002 
> minutes, events=4, succcessCount=2, totalEvents=2960, totalSuccessCount=112 
> (BaseAuditHandler:312)
> 2018-05-21 20:33:32,604 INFO - 
> [main-SendThread(ctr-e138-1518143905142-323545-01-05.hwx.site:2181):] ~ 
> Client session timed out, have not heard from server in 13339ms for sessionid 
> 0x1637d8f847f002c, closing socket connection and attempting reconnect 
> (ClientCnxn:1140)
> 2018-05-21 20:33:32,705 INFO - [main-EventThread:] ~ State change: SUSPENDED 
> (ConnectionStateManager:228)
> 2018-05-21 20:33:32,708 WARN - [Curator-ConnectionStateManager-0:] ~ Server 
> instance with server id id1 is removed as leader 
> (ActiveInstanceElectorService:191)
> 2018-05-21 20:33:32,708 WARN - [Curator-ConnectionStateManager-0:] ~ Instance 
> becoming passive from ACTIVE (ServiceState:92)
> 2018-05-21 20:33:32,709 INFO - [Curator-ConnectionStateManager-0:] ~ Reacting 
> to passive state: shutting down Kafka consumers. 
> (NotificationHookConsumer:227)
> 2018-05-21 20:33:32,709 INFO - [Curator-ConnectionStateManager-0:] ~ ==> 
> stopConsumerThreads() (NotificationHookConsumer:193)
> 2018-05-21 20:33:32,709 INFO - [Curator-ConnectionStateManager-0:] ~ ==> 
> HookConsumer shutdown() (NotificationHookConsumer:610)
> 2018-05-21 20:33:32,710 INFO - [Curator-ConnectionStateManager-0:] ~ 
> [atlas-hook-consumer-thread]: Shutting down 
> (NotificationHookConsumer$HookConsumer:72)
> 2018-05-21 20:33:32,710 INFO - [NotificationHookConsumer thread-0:] ~ closing 
> NotificationConsumer (NotificationHookConsumer:343)
> 2018-05-21 20:33:34,550 INFO - 
> [main-SendThread(ctr-e138-1518143905142-323545-01-05.hwx.site:2181):] ~ 
> Client will use GSSAPI as SASL mechanism. (ZooKeeperSaslClient:285)
> 2018-05-21 20:33:34,551 INFO - 
> [main-SendThread(ctr-e138-1518143905142-323545-01-05.hwx.site:2181):] ~ 
> Opening socket connection to server 
> ctr-e138-1518143905142-323545-01-05.hwx.site/172.27.15.200:2181. Will 
> attempt to SASL-authenticate using Login Context section 'Client' 
> (ClientCnxn:1019)
> 2018-05-21 20:33:47,715 ERROR - [Curator-Framework-0:] ~ Connection timed out 
> for connection string (ctr-e138-1518143905142-323545-01-05.hwx.site:2181) 
> and timeout (15000) / elapsed (15006) (ConnectionState:200)
> org.apache.curator.CuratorConnectionLossException: KeeperErrorCode = 
> ConnectionLoss
>  at org.apache.curator.ConnectionState.checkTimeouts(ConnectionState.java:197)
>  at org.apache.curator.ConnectionState.getZooKeeper(ConnectionState.java:88)
>  at 
> org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:116)
>  at 
> org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:835)
>  at 
> org.apache.curator.framework.imps.CuratorFrameworkImpl.backgroundOperationsLoop(CuratorFrameworkImpl.java:809)
>  at 
> org.apache.curator.framework.imps.CuratorFrameworkImpl.access$300(CuratorFrameworkImpl.java:64)
>  at 
> org.apache.curator.framework.imps.CuratorFrameworkImpl$4.call(CuratorFrameworkImpl.java:267)
>  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
> {noformat}
>  
>  
> * Below snapshot showing, atlas recovering from zookeepe

Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Nixon Rodrigues.


Bugs: ATLAS-2751
https://issues.apache.org/jira/browse/ATLAS-2751


Repository: atlas


Description
---

Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
zookeeper connection timeout.


Diffs
-

  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
00e56e33f 


Diff: https://reviews.apache.org/r/67514/diff/1/


Testing
---

Manually tested in HA cluster toggling active and passive state. consumers 
process hook messages.

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console


Thanks,

Sarath Subramanian

[jira] [Created] (ATLAS-2751) Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

[Sarath Subramanian (JIRA)]

Sarath Subramanian created ATLAS-2751:
-

 Summary: Atlas is not consuming messages from ATLAS_HOOK topic 
after recovering from zookeeper connection timeout.
 Key: ATLAS-2751
 URL: https://issues.apache.org/jira/browse/ATLAS-2751
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 1.1.0
Reporter: Sarath Subramanian
 Fix For: 1.1.0


Atlas is not consuming messages from ATLAS_HOOK topic after recovering from 
zookeeper connection timeout.

* Below snapshot showing, atlas going into passive state with notification 
consumer thread shutdown
{noformat}
2018-05-21 18:45:42,156 INFO - 
[org.apache.ranger.audit.queue.AuditBatchQueue1:] ~ Audit Status Log: 
name=atlas.async.multi_dest.batch, 
finalDestination=atlas.async.multi_dest.batch.solr, interval=01:00.002 minutes, 
events=4, succcessCount=2, totalEvents=2960, totalSuccessCount=112 
(BaseAuditHandler:312)
2018-05-21 20:33:32,604 INFO - 
[main-SendThread(ctr-e138-1518143905142-323545-01-05.hwx.site:2181):] ~ 
Client session timed out, have not heard from server in 13339ms for sessionid 
0x1637d8f847f002c, closing socket connection and attempting reconnect 
(ClientCnxn:1140)
2018-05-21 20:33:32,705 INFO - [main-EventThread:] ~ State change: SUSPENDED 
(ConnectionStateManager:228)
2018-05-21 20:33:32,708 WARN - [Curator-ConnectionStateManager-0:] ~ Server 
instance with server id id1 is removed as leader 
(ActiveInstanceElectorService:191)
2018-05-21 20:33:32,708 WARN - [Curator-ConnectionStateManager-0:] ~ Instance 
becoming passive from ACTIVE (ServiceState:92)
2018-05-21 20:33:32,709 INFO - [Curator-ConnectionStateManager-0:] ~ Reacting 
to passive state: shutting down Kafka consumers. (NotificationHookConsumer:227)
2018-05-21 20:33:32,709 INFO - [Curator-ConnectionStateManager-0:] ~ ==> 
stopConsumerThreads() (NotificationHookConsumer:193)
2018-05-21 20:33:32,709 INFO - [Curator-ConnectionStateManager-0:] ~ ==> 
HookConsumer shutdown() (NotificationHookConsumer:610)
2018-05-21 20:33:32,710 INFO - [Curator-ConnectionStateManager-0:] ~ 
[atlas-hook-consumer-thread]: Shutting down 
(NotificationHookConsumer$HookConsumer:72)
2018-05-21 20:33:32,710 INFO - [NotificationHookConsumer thread-0:] ~ closing 
NotificationConsumer (NotificationHookConsumer:343)
2018-05-21 20:33:34,550 INFO - 
[main-SendThread(ctr-e138-1518143905142-323545-01-05.hwx.site:2181):] ~ 
Client will use GSSAPI as SASL mechanism. (ZooKeeperSaslClient:285)
2018-05-21 20:33:34,551 INFO - 
[main-SendThread(ctr-e138-1518143905142-323545-01-05.hwx.site:2181):] ~ 
Opening socket connection to server 
ctr-e138-1518143905142-323545-01-05.hwx.site/172.27.15.200:2181. Will 
attempt to SASL-authenticate using Login Context section 'Client' 
(ClientCnxn:1019)
2018-05-21 20:33:47,715 ERROR - [Curator-Framework-0:] ~ Connection timed out 
for connection string (ctr-e138-1518143905142-323545-01-05.hwx.site:2181) 
and timeout (15000) / elapsed (15006) (ConnectionState:200)
org.apache.curator.CuratorConnectionLossException: KeeperErrorCode = 
ConnectionLoss
 at org.apache.curator.ConnectionState.checkTimeouts(ConnectionState.java:197)
 at org.apache.curator.ConnectionState.getZooKeeper(ConnectionState.java:88)
 at 
org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:116)
 at 
org.apache.curator.framework.imps.CuratorFrameworkImpl.performBackgroundOperation(CuratorFrameworkImpl.java:835)
 at 
org.apache.curator.framework.imps.CuratorFrameworkImpl.backgroundOperationsLoop(CuratorFrameworkImpl.java:809)
 at 
org.apache.curator.framework.imps.CuratorFrameworkImpl.access$300(CuratorFrameworkImpl.java:64)
 at 
org.apache.curator.framework.imps.CuratorFrameworkImpl$4.call(CuratorFrameworkImpl.java:267)
 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
 at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
 at java.lang.Thread.run(Thread.java:748)
{noformat}
 
 
* Below snapshot showing, atlas recovering from zookeeper timeout and assuming 
to active instance with consumer thread initialized to read kafka events.
{noformat}
2018-05-21 20:34:13,358 INFO - [Curator-Framework-0-EventThread:] ~ State 
change: RECONNECTED (ConnectionStateManager:228)
2018-05-21 20:34:13,366 WARN - [Curator-Framework-0-EventThread:] ~ Server 
instance with server id id1 is elected as leader 
(ActiveInstanceElectorService:145)
2018-05-21 20:34:13,366 WARN - [Curator-Framework-0-EventThread:] ~ Instance 
becoming active from PASSIVE (ServiceState:76)
2018-05-21 20:34:13,

[jira] [Commented] (ATLAS-2750) Migration Import: Classification with Maps of Primitive Type are Not Processed

[Sarath Subramanian (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506611#comment-16506611
 ] 

Sarath Subramanian commented on ATLAS-2750:
---

+1

> Migration Import: Classification with Maps of Primitive Type are Not Processed
> --
>
> Key: ATLAS-2750
> URL: https://issues.apache.org/jira/browse/ATLAS-2750
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0, trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-2750-Processing-classifications-with-attribute.patch
>
>
> *Pre-requisites*
> Atlas v0.8 with types like the one attached (_tag_with_map_of_map_). Create 
> entities and associate the tag with these entities.
> *Steps to Reproduce*
>  * Use Atlas v1.0 and perform migration import.
>  * From _Classification_ tab select _tag_with_map_of_map._
> *Expected behavior*: Associated entity should be displayed.
> *Actual behavior*: Entity is not displayed. Server logs shows cast exception, 
> '_cannot cast list to map_'.
> *Root cause*
> The migration import process maintains an inventory of types that use maps of 
> primitive and non-primitive type. __The _TypesWithCollectionsFinder_ 
> populates this. This class was not processing classification types. Hence, 
> during import the classification instance vertices were left unprocessed for 
> maps and arrays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2749) Migration Import: Associated Classifications Cannot Be Deleted

[Sarath Subramanian (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506610#comment-16506610
 ] 

Sarath Subramanian commented on ATLAS-2749:
---

+1

> Migration Import: Associated Classifications Cannot Be Deleted
> --
>
> Key: ATLAS-2749
> URL: https://issues.apache.org/jira/browse/ATLAS-2749
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-2749-Classification-dissociation-fails-on-impo.patch
>
>
> *Pre-requisite*
> On Atlas v0.8: Create few entities say _entity1_ and classifications say 
> _tag1_. Associate _tag1_ to _entity1_.
> *Steps to duplicate on Atlas v1.0*
>  * Perform _migration import_.
>  * From the web ui select _tag1_, notice that _entity1_ is displayed. 
>  * Attempt to remove _tag1_ from _entity1_.
> *Expected result*: _tag1_ should be removed from _entity1_.
> *Actual result*: _tag1_ is not removed. Server logs show _'No classifications 
> associated with entity.'_
> *Root cause:* Imported edges that associate vertex with classification vertex 
> do not have ___isPropagate_ property set. The 
> _EntityGraphMapper_._deleteClassification_ calls _getTraitNames_ with 
> _isPropagate_ set to false. This makes the call return with no entities. The 
> deletion thus fails.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2748) Migration Import: Deleted Edges Marked as ACTIVE after Import

[Sarath Subramanian (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506608#comment-16506608
 ] 

Sarath Subramanian commented on ATLAS-2748:
---

+1

> Migration Import: Deleted Edges Marked as ACTIVE after Import
> -
>
> Key: ATLAS-2748
> URL: https://issues.apache.org/jira/browse/ATLAS-2748
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 1.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-2748-Edges-state-preserved-during-import.patch
>
>
> *Pre-requisites*
> On Atlas v0.8, from Hive (Beeline):
>  * Create a _hive_db,_ say _stocks_, with couple of tables with few columns 
> say _daily_ and _weekly_.
>  * Drop _weekly_.
> Perform migration export.
> Steps to duplicate:
>  * Perform migration import.
> *Expected results*: Relationship edges between _stocks_ and weekly should 
> continue to preserve its ___state_ to _DELETED._
> *Actual result*:  Relationship edges between _stocks_ and weekly is has 
> ___state_ set to ACTIVE_._
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2750) Migration Import: Classification with Maps of Primitive Type are Not Processed

[Ashutosh Mestry (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-2750:
---
Attachment: ATLAS-2750-Processing-classifications-with-attribute.patch

> Migration Import: Classification with Maps of Primitive Type are Not Processed
> --
>
> Key: ATLAS-2750
> URL: https://issues.apache.org/jira/browse/ATLAS-2750
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0, trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-2750-Processing-classifications-with-attribute.patch
>
>
> *Pre-requisites*
> Atlas v0.8 with types like the one attached (_tag_with_map_of_map_). Create 
> entities and associate the tag with these entities.
> *Steps to Reproduce*
>  * Use Atlas v1.0 and perform migration import.
>  * From _Classification_ tab select _tag_with_map_of_map._
> *Expected behavior*: Associated entity should be displayed.
> *Actual behavior*: Entity is not displayed. Server logs shows cast exception, 
> '_cannot cast list to map_'.
> *Root cause*
> The migration import process maintains an inventory of types that use maps of 
> primitive and non-primitive type. __The _TypesWithCollectionsFinder_ 
> populates this. This class was not processing classification types. Hence, 
> during import the classification instance vertices were left unprocessed for 
> maps and arrays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-2750) Migration Import: Classification with Maps of Primitive Type are Not Processed

[Ashutosh Mestry (JIRA)]

Ashutosh Mestry created ATLAS-2750:
--

 Summary: Migration Import: Classification with Maps of Primitive 
Type are Not Processed
 Key: ATLAS-2750
 URL: https://issues.apache.org/jira/browse/ATLAS-2750
 Project: Atlas
  Issue Type: Bug
Affects Versions: 1.0.0, trunk
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
 Fix For: trunk


*Pre-requisites*

Atlas v0.8 with types like the one attached (_tag_with_map_of_map_). Create 
entities and associate the tag with these entities.

*Steps to Reproduce*
 * Use Atlas v1.0 and perform migration import.
 * From _Classification_ tab select _tag_with_map_of_map._

*Expected behavior*: Associated entity should be displayed.

*Actual behavior*: Entity is not displayed. Server logs shows cast exception, 
'_cannot cast list to map_'.

*Root cause*

The migration import process maintains an inventory of types that use maps of 
primitive and non-primitive type. __The _TypesWithCollectionsFinder_ populates 
this. This class was not processing classification types. Hence, during import 
the classification instance vertices were left unprocessed for maps and arrays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2749) Migration Import: Associated Classifications Cannot Be Deleted

[Ashutosh Mestry (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506468#comment-16506468
 ] 

Ashutosh Mestry commented on ATLAS-2749:


Fix is a single line change and updated unit tests.

> Migration Import: Associated Classifications Cannot Be Deleted
> --
>
> Key: ATLAS-2749
> URL: https://issues.apache.org/jira/browse/ATLAS-2749
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-2749-Classification-dissociation-fails-on-impo.patch
>
>
> *Pre-requisite*
> On Atlas v0.8: Create few entities say _entity1_ and classifications say 
> _tag1_. Associate _tag1_ to _entity1_.
> *Steps to duplicate on Atlas v1.0*
>  * Perform _migration import_.
>  * From the web ui select _tag1_, notice that _entity1_ is displayed. 
>  * Attempt to remove _tag1_ from _entity1_.
> *Expected result*: _tag1_ should be removed from _entity1_.
> *Actual result*: _tag1_ is not removed. Server logs show _'No classifications 
> associated with entity.'_
> *Root cause:* Imported edges that associate vertex with classification vertex 
> do not have ___isPropagate_ property set. The 
> _EntityGraphMapper_._deleteClassification_ calls _getTraitNames_ with 
> _isPropagate_ set to false. This makes the call return with no entities. The 
> deletion thus fails.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2749) Migration Import: Associated Classifications Cannot Be Deleted

[Ashutosh Mestry (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-2749:
---
Attachment: ATLAS-2749-Classification-dissociation-fails-on-impo.patch

> Migration Import: Associated Classifications Cannot Be Deleted
> --
>
> Key: ATLAS-2749
> URL: https://issues.apache.org/jira/browse/ATLAS-2749
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-2749-Classification-dissociation-fails-on-impo.patch
>
>
> *Pre-requisite*
> On Atlas v0.8: Create few entities say _entity1_ and classifications say 
> _tag1_. Associate _tag1_ to _entity1_.
> *Steps to duplicate on Atlas v1.0*
>  * Perform _migration import_.
>  * From the web ui select _tag1_, notice that _entity1_ is displayed. 
>  * Attempt to remove _tag1_ from _entity1_.
> *Expected result*: _tag1_ should be removed from _entity1_.
> *Actual result*: _tag1_ is not removed. Server logs show _'No classifications 
> associated with entity.'_
> *Root cause:* Imported edges that associate vertex with classification vertex 
> do not have ___isPropagate_ property set. The 
> _EntityGraphMapper_._deleteClassification_ calls _getTraitNames_ with 
> _isPropagate_ set to false. This makes the call return with no entities. The 
> deletion thus fails.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-2749) Migration Import: Associated Classifications Cannot Be Deleted

[Ashutosh Mestry (JIRA)]

Ashutosh Mestry created ATLAS-2749:
--

 Summary: Migration Import: Associated Classifications Cannot Be 
Deleted
 Key: ATLAS-2749
 URL: https://issues.apache.org/jira/browse/ATLAS-2749
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
 Fix For: trunk


*Pre-requisite*

On Atlas v0.8: Create few entities say _entity1_ and classifications say 
_tag1_. Associate _tag1_ to _entity1_.

*Steps to duplicate on Atlas v1.0*
 * Perform _migration import_.
 * From the web ui select _tag1_, notice that _entity1_ is displayed. 
 * Attempt to remove _tag1_ from _entity1_.

*Expected result*: _tag1_ should be removed from _entity1_.

*Actual result*: _tag1_ is not removed. Server logs show _'No classifications 
associated with entity.'_

*Root cause:* Imported edges that associate vertex with classification vertex 
do not have ___isPropagate_ property set. The 
_EntityGraphMapper_._deleteClassification_ calls _getTraitNames_ with 
_isPropagate_ set to false. This makes the call return with no entities. The 
deletion thus fails.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ATLAS-2730) Invalid timezone / start time / end time is accepted by classification API

[Sarath Subramanian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian resolved ATLAS-2730.
---
Resolution: Fixed

Thanks for the path [~nixonrodrigues].

Committed to master: 
[http://git-wip-us.apache.org/repos/asf/atlas/commit/9e762c09]

> Invalid timezone / start time / end time is accepted by classification API
> --
>
> Key: ATLAS-2730
> URL: https://issues.apache.org/jira/browse/ATLAS-2730
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.1.0, 2.0.0
>
> Attachments: ATLAS-2730-2.patch, ATLAS-2730-3.patch, ATLAS-2730.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2730) Invalid timezone / start time / end time is accepted by classification API

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506313#comment-16506313
 ] 

ASF subversion and git services commented on ATLAS-2730:


Commit 9e762c095f00e0d281ebc6f47b951856f3c097b8 in atlas's branch 
refs/heads/master from nixonrodrigues
[ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=9e762c0 ]

ATLAS-2730: Invalid timezone/start time/end time is accepted by classification 
API #2

Signed-off-by: Sarath Subramanian 


> Invalid timezone / start time / end time is accepted by classification API
> --
>
> Key: ATLAS-2730
> URL: https://issues.apache.org/jira/browse/ATLAS-2730
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.1.0, 2.0.0
>
> Attachments: ATLAS-2730-2.patch, ATLAS-2730-3.patch, ATLAS-2730.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2748) Migration Import: Deleted Edges Marked as ACTIVE after Import

[Ashutosh Mestry (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-2748:
---
Attachment: ATLAS-2748-Edges-state-preserved-during-import.patch

> Migration Import: Deleted Edges Marked as ACTIVE after Import
> -
>
> Key: ATLAS-2748
> URL: https://issues.apache.org/jira/browse/ATLAS-2748
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 1.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-2748-Edges-state-preserved-during-import.patch
>
>
> *Pre-requisites*
> On Atlas v0.8, from Hive (Beeline):
>  * Create a _hive_db,_ say _stocks_, with couple of tables with few columns 
> say _daily_ and _weekly_.
>  * Drop _weekly_.
> Perform migration export.
> Steps to duplicate:
>  * Perform migration import.
> *Expected results*: Relationship edges between _stocks_ and weekly should 
> continue to preserve its ___state_ to _DELETED._
> *Actual result*:  Relationship edges between _stocks_ and weekly is has 
> ___state_ set to ACTIVE_._
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-2748) Migration Import: Deleted Edges Marked as ACTIVE after Import

[Ashutosh Mestry (JIRA)]

Ashutosh Mestry created ATLAS-2748:
--

 Summary: Migration Import: Deleted Edges Marked as ACTIVE after 
Import
 Key: ATLAS-2748
 URL: https://issues.apache.org/jira/browse/ATLAS-2748
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: trunk, 1.1.0
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
 Fix For: trunk


*Pre-requisites*

On Atlas v0.8, from Hive (Beeline):
 * Create a _hive_db,_ say _stocks_, with couple of tables with few columns say 
_daily_ and _weekly_.
 * Drop _weekly_.

Perform migration export.

Steps to duplicate:
 * Perform migration import.

*Expected results*: Relationship edges between _stocks_ and weekly should 
continue to preserve its ___state_ to _DELETED._

*Actual result*:  Relationship edges between _stocks_ and weekly is has 
___state_ set to ACTIVE_._

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67499: ATLAS-2730 - Added validation for Timezone in TimeBoundry values in classifications

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67499/#review204493
---


Ship it!




Ship It!

- Sarath Subramanian


On June 8, 2018, 3:31 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67499/
> ---
> 
> (Updated June 8, 2018, 3:31 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2730
> https://issues.apache.org/jira/browse/ATLAS-2730
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently, timezone which is not null and not valid was treated as default 
> system timezone.
> 
> This patch (ATLAS-2730-4.patch) adds validation for timezone to accept 
> timezone in valid format.
> 
> eg:-
> 
> JST,IND,UTC
> GMT+0
> GMT+10:30
> GMT-13
> America/Los_Angeles
> Asia/Singapore
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0585ebe1 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 1adb362dd 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
> 1ade5f704 
> 
> 
> Diff: https://reviews.apache.org/r/67499/diff/1/
> 
> 
> Testing
> ---
> 
> Performed manual testing by adding valid and invalid timezone in 
> classification
> Added test unittestcases
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Jenkins build is back to normal : Atlas-1.0-AllTests #208

[Apache Jenkins Server]

See 

[jira] [Commented] (ATLAS-2746) [Glossary] Simple Term/Category creation should work with CREATE privilege

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506194#comment-16506194
 ] 

ASF subversion and git services commented on ATLAS-2746:


Commit 703457d8ef056bc2ef34bf0c08966df4748e98ee in atlas's branch 
refs/heads/branch-1.0 from apoorvnaik
[ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=703457d ]

ATLAS-2746: Term/Category create shouldn't require UPDATE privilege for simple 
cases.

Change-Id: I914d81dab968c28b1684953d3b077bfa046c96bb
(cherry picked from commit 7a1d3dc5e315d5c82a58bdc67533e7deb324db07)


> [Glossary] Simple Term/Category creation should work with CREATE privilege
> --
>
> Key: ATLAS-2746
> URL: https://issues.apache.org/jira/browse/ATLAS-2746
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0, trunk
>
> Attachments: 
> 0001-ATLAS-2746-Term-Category-create-shouldn-t-require-UP.patch
>
>
> Currently this operation needs following privileges
>  
> Entity.READ, Entity.CREATE, Entity.UPDATE
>  
> with the change simple term/category creation without any other relations 
> e.g. children, parent, categorized terms etc. can work with
>  
> Entity.READ and Entity.CREATE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2746) [Glossary] Simple Term/Category creation should work with CREATE privilege

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506186#comment-16506186
 ] 

ASF subversion and git services commented on ATLAS-2746:


Commit 7a1d3dc5e315d5c82a58bdc67533e7deb324db07 in atlas's branch 
refs/heads/master from apoorvnaik
[ https://git-wip-us.apache.org/repos/asf?p=atlas.git;h=7a1d3dc ]

ATLAS-2746: Term/Category create shouldn't require UPDATE privilege for simple 
cases.

Change-Id: I914d81dab968c28b1684953d3b077bfa046c96bb


> [Glossary] Simple Term/Category creation should work with CREATE privilege
> --
>
> Key: ATLAS-2746
> URL: https://issues.apache.org/jira/browse/ATLAS-2746
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0, trunk
>
> Attachments: 
> 0001-ATLAS-2746-Term-Category-create-shouldn-t-require-UP.patch
>
>
> Currently this operation needs following privileges
>  
> Entity.READ, Entity.CREATE, Entity.UPDATE
>  
> with the change simple term/category creation without any other relations 
> e.g. children, parent, categorized terms etc. can work with
>  
> Entity.READ and Entity.CREATE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67508: ATLAS-2747: UI : Tag attributes of type array are displayed with an extra ">" character.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67508/#review204489
---


Ship it!




Ship It!

- Nixon Rodrigues


On June 8, 2018, 2:05 p.m., Abhishek Kadam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67508/
> ---
> 
> (Updated June 8, 2018, 2:05 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2747
> https://issues.apache.org/jira/browse/ATLAS-2747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes fix to render objects of non-primitive data-type.
> 
> #On edit popup only primitive datatypes objects are shown to edit.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/Overrides.js a96fc2c 
>   dashboardv2/public/js/views/tag/AddTagModalView.js e442f57 
>   dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 35e0f87 
> 
> 
> Diff: https://reviews.apache.org/r/67508/diff/1/
> 
> 
> Testing
> ---
> 
> Performed sanity test on UI
> 
> 
> Thanks,
> 
> Abhishek Kadam
> 
>

Review Request 67508: ATLAS-2747: UI : Tag attributes of type array are displayed with an extra ">" character.

[Abhishek Kadam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67508/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2747
https://issues.apache.org/jira/browse/ATLAS-2747


Repository: atlas


Description
---

This patch includes fix to render objects of non-primitive data-type.

#On edit popup only primitive datatypes objects are shown to edit.


Diffs
-

  dashboardv2/public/js/utils/Overrides.js a96fc2c 
  dashboardv2/public/js/views/tag/AddTagModalView.js e442f57 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 35e0f87 


Diff: https://reviews.apache.org/r/67508/diff/1/


Testing
---

Performed sanity test on UI


Thanks,

Abhishek Kadam

[jira] [Updated] (ATLAS-2747) UI : Tag attributes of type array are displayed with an extra ">" character.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2747:
--
Attachment: ATLAS-2747.patch

> UI : Tag attributes of type array are displayed with an extra ">" character.
> 
>
> Key: ATLAS-2747
> URL: https://issues.apache.org/jira/browse/ATLAS-2747
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: ATLAS-2747.patch
>
>
> !Tag attribute of data type array.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67486: ATLAS-2745 EnumDefStore manages defaultValue

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67486/#review204487
---


Ship it!




Ship It!

- David Radley


On June 7, 2018, 1:57 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67486/
> ---
> 
> (Updated June 7, 2018, 1:57 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2745 - AtlasEnumDefStore should remember default value
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEnumDefStoreV2.java
>  7d7233fe8c6e9b8449df7798afdc7216e30d538b 
> 
> 
> Diff: https://reviews.apache.org/r/67486/diff/1/
> 
> 
> Testing
> ---
> 
> Bring-up testing loading Open Metadata types including EnumDefs with default 
> values.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

[jira] [Created] (ATLAS-2747) UI : Tag attributes of type array are displayed with an extra ">" character.

[Abhishek Kadam (JIRA)]

Abhishek Kadam created ATLAS-2747:
-

 Summary: UI : Tag attributes of type array are displayed with an 
extra ">" character.
 Key: ATLAS-2747
 URL: https://issues.apache.org/jira/browse/ATLAS-2747
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Abhishek Kadam
Assignee: Abhishek Kadam
 Fix For: 2.0.0


!Tag attribute of data type array.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Build failed in Jenkins: Atlas-1.0-AllTests #207

[Apache Jenkins Server]

See 

--
[...truncated 97.42 KB...]
[INFO] Working directory: 

[INFO] Storing buildNumber: 6c7d8e26868c4ee16d38f9cd28fe8ad09ef961e4 at 
timestamp: 1528461726537
[WARNING] Cannot get the branch information from the git repository: 
Detecting the current branch failed: fatal: ref HEAD is not a symbolic ref

[INFO] Executing: /bin/sh -c cd 
' && 'git' 
'rev-parse' '--verify' 'HEAD'
[INFO] Working directory: 

[INFO] Storing buildScmBranch: UNKNOWN
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (rat-check) @ atlas-notification ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: **/antlr4/**
[INFO] Exclude: **/dependency-reduced-pom.xml
[INFO] Exclude: **/javax.script.ScriptEngineFactory
[INFO] Exclude: .reviewboardrc
[INFO] Exclude: 3party-licenses/**
[INFO] Exclude: **/.cache
[INFO] Exclude: **/.cache-main
[INFO] Exclude: **/.cache-tests
[INFO] Exclude: **/.checkstyle
[INFO] Exclude: **/*.txt
[INFO] Exclude: **/*.json
[INFO] Exclude: .pc/**
[INFO] Exclude: debian/**
[INFO] Exclude: .svn/**
[INFO] Exclude: .git/**
[INFO] Exclude: .gitignore
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.twiki
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.log
[INFO] Exclude: **/target/**
[INFO] Exclude: **/target*/**
[INFO] Exclude: **/build/**
[INFO] Exclude: **/*.patch
[INFO] Exclude: derby.log
[INFO] Exclude: **/logs/**
[INFO] Exclude: **/.classpath
[INFO] Exclude: **/.project
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/test-output/**
[INFO] Exclude: **/mock/**
[INFO] Exclude: **/data/**
[INFO] Exclude: **/maven-eclipse.xml
[INFO] Exclude: **/.externalToolBuilders/**
[INFO] Exclude: **/build.log
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: *.json
[INFO] Exclude: **/overlays/**
[INFO] Exclude: dev-support/**
[INFO] Exclude: **/users-credentials.properties
[INFO] Exclude: **/public/css/animate.min.css
[INFO] Exclude: **/public/css/bootstrap-sidebar.css
[INFO] Exclude: **/public/js/external_lib/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/public/js/libs/**
[INFO] Exclude: **/atlas.data/**
[INFO] Exclude: **/${sys:atlas.data}/**
[INFO] Exclude: **/policy-store.txt
[INFO] Exclude: **/*rebel*.xml
[INFO] Exclude: **/*rebel*.xml.bak
[INFO] Exclude: **/test/resources/**
[INFO] 36 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 36 licenses.
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
atlas-notification ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-notification ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
atlas-notification ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 21 source files to 

[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ 
atlas-notification ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ 
atlas-notification ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 14 source files to 

[INFO] 
:
 Some input files use unchecked or unsafe operations.
[INFO] 
:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO]

[jira] [Commented] (ATLAS-2730) Invalid timezone / start time / end time is accepted by classification API

[Nixon Rodrigues (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505903#comment-16505903
 ] 

Nixon Rodrigues commented on ATLAS-2730:


I have added patch to add validation on timezone.

Review Request.
https://reviews.apache.org/r/67499/

> Invalid timezone / start time / end time is accepted by classification API
> --
>
> Key: ATLAS-2730
> URL: https://issues.apache.org/jira/browse/ATLAS-2730
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.1.0, 2.0.0
>
> Attachments: ATLAS-2730-2.patch, ATLAS-2730-3.patch, ATLAS-2730.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 67499: ATLAS-2730 - Added validation for Timezone in TimeBoundry values in classifications

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67499/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

Currently, timezone which is not null and not valid was treated as default 
system timezone.

This patch (ATLAS-2730-4.patch) adds validation for timezone to accept timezone 
in valid format.

eg:-

JST,IND,UTC
GMT+0
GMT+10:30
GMT-13
America/Los_Angeles
Asia/Singapore


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0585ebe1 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
1adb362dd 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
1ade5f704 


Diff: https://reviews.apache.org/r/67499/diff/1/


Testing
---

Performed manual testing by adding valid and invalid timezone in classification
Added test unittestcases


Thanks,

Nixon Rodrigues

[jira] [Reopened] (ATLAS-2730) Invalid timezone / start time / end time is accepted by classification API

[Nixon Rodrigues (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reopened ATLAS-2730:


Currently, timezone which is not null and not valid was treated as default 
system timezone.
 So reopening the issue.

> Invalid timezone / start time / end time is accepted by classification API
> --
>
> Key: ATLAS-2730
> URL: https://issues.apache.org/jira/browse/ATLAS-2730
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.1.0, 2.0.0
>
> Attachments: ATLAS-2730-2.patch, ATLAS-2730-3.patch, ATLAS-2730.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)