Re: Review Request 71056: ATLAS-3325 Update hive-bridge to use relationship attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71056/ --- (Updated July 11, 2019, 1:24 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3325 https://issues.apache.org/jira/browse/ATLAS-3325 Repository: atlas Description --- ATLAS-3325 Update hive-bridge to use relationship attributes Diffs - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 5f8f846 Diff: https://reviews.apache.org/r/71056/diff/1/ Testing (updated) --- Steps done for updating 1. Disable hive-hook from Ambari. 2. Create table in hive. 3. Check whether table entity is created in Atlas side or not.(It should not be created) 4. Run script import-hbase.sh 5. Check again in Atlas side, hive table and DB entities are created with relationship. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1255/console Thanks, Mandar Ambawane
Re: Review Request 71056: ATLAS-3325 Update hive-bridge to use relationship attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71056/ --- (Updated July 12, 2019, 10:55 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Changes done according to review comments Bugs: ATLAS-3325 https://issues.apache.org/jira/browse/ATLAS-3325 Repository: atlas Description --- ATLAS-3325 Update hive-bridge to use relationship attributes Diffs (updated) - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 5f8f846 addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java b3663da Diff: https://reviews.apache.org/r/71056/diff/2/ Changes: https://reviews.apache.org/r/71056/diff/1-2/ Testing --- Steps done for updating 1. Disable hive-hook from Ambari. 2. Create table in hive. 3. Check whether table entity is created in Atlas side or not.(It should not be created) 4. Run script import-hive.sh 5. Check again in Atlas side, hive table and DB entities are created with relationship. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1255/console Thanks, Mandar Ambawane
Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use relationship attribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71064/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Repository: atlas Description --- ATLAS-3326 Update Hbase hook/bridge to use relationship attribute Diffs - addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 1825cd2 addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java 1765c18 Diff: https://reviews.apache.org/r/71064/diff/1/ Testing --- Steps done for updating 1. Disable hbsae-hook from Ambari. 2. Create table in hive. 3. Check whether table entity is created in Atlas side or not.(It should not be created) 4. Run script import-hbsae.sh 5. Check again in Atlas side, hive table and namespace entities are created with relationship. Thanks, Mandar Ambawane
Re: Review Request 71056: ATLAS-3325 Update hive-bridge to use relationship attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71056/ --- (Updated July 13, 2019, 6:16 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Rebase the patch and did changes as per review comments Bugs: ATLAS-3325 https://issues.apache.org/jira/browse/ATLAS-3325 Repository: atlas Description --- ATLAS-3325 Update hive-bridge to use relationship attributes Diffs (updated) - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 049112b addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 98b4d4f addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 91e063e Diff: https://reviews.apache.org/r/71056/diff/3/ Changes: https://reviews.apache.org/r/71056/diff/2-3/ Testing --- Steps done for updating 1. Disable hive-hook from Ambari. 2. Create table in hive. 3. Check whether table entity is created in Atlas side or not.(It should not be created) 4. Run script import-hive.sh 5. Check again in Atlas side, hive table and DB entities are created with relationship. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1255/console Thanks, Mandar Ambawane
Re: Review Request 71056: ATLAS-3325 Update hive-bridge to use relationship attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71056/ --- (Updated July 13, 2019, 9:32 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- renamed method toStroageDescEntity => toStorageDescEntity Bugs: ATLAS-3325 https://issues.apache.org/jira/browse/ATLAS-3325 Repository: atlas Description --- ATLAS-3325 Update hive-bridge to use relationship attributes Diffs (updated) - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 049112b addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 98b4d4f addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 91e063e Diff: https://reviews.apache.org/r/71056/diff/4/ Changes: https://reviews.apache.org/r/71056/diff/3-4/ Testing --- Steps done for updating 1. Disable hive-hook from Ambari. 2. Create table in hive. 3. Check whether table entity is created in Atlas side or not.(It should not be created) 4. Run script import-hive.sh 5. Check again in Atlas side, hive table and DB entities are created with relationship. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1255/console Thanks, Mandar Ambawane
Re: Review Request 71064: ATLAS-3326 Update Hbase hook/bridge to use relationship attribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71064/ --- (Updated July 15, 2019, 11:17 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- ATLAS-3326 Update Hbase hook/bridge to use relationship attribute and move conversion methods to class AtlasTypeUtil Repository: atlas Description --- ATLAS-3326 Update Hbase hook/bridge to use relationship attribute Diffs (updated) - addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java 6d062e2 addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java 4a4b4d9 addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java a61a3e6 addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java a74273a addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java 6b050d4 addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java 4403aaf intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6ac176d Diff: https://reviews.apache.org/r/71064/diff/2/ Changes: https://reviews.apache.org/r/71064/diff/1-2/ Testing --- Steps done for updating 1. Disable hbase-hook from Ambari. 2. Create table in hbase. 3. Check whether table entity is created in Atlas side or not.(It should not be created) 4. Run script import-hbsae.sh 5. Check again in Atlas side, hbase table and namespace entities are created with relationship. Thanks, Mandar Ambawane
Add me as a Contributor for Atlas
Atlas community, I would like to be a contributor for Apache Atlas. My jira id is *mandar_va* -- Thanks and Regards, Mandar V. Ambawane.
Re: Review Request 71373: ATLAS-3411 - Relationships : Having multiple relationships on the same attribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71373/ --- (Updated Sept. 13, 2019, 7:01 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3411 https://issues.apache.org/jira/browse/ATLAS-3411 Repository: atlas Description (updated) --- This patch restricts creation of Relationship typedef with same attribute name for same end entityType. Diffs - intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c Diff: https://reviews.apache.org/r/71373/diff/1/ Testing --- UTs and ITs are passing. Thanks, Mandar Ambawane
Re: Review Request 71373: ATLAS-3411 - Relationships : Having multiple relationships on the same attribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71373/ --- (Updated Sept. 13, 2019, 6:08 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3411 https://issues.apache.org/jira/browse/ATLAS-3411 Repository: atlas Description --- Relationships : Having multiple relationships on the same attribute Diffs - intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 8b4fd1c Diff: https://reviews.apache.org/r/71373/diff/1/ Testing --- UTs and ITs are passing. Thanks, Mandar Ambawane
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/ --- (Updated July 28, 2019, 6:22 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments and handled test-cases for boolean datatype. Bugs: ATLAS-3347 https://issues.apache.org/jira/browse/ATLAS-3347 Repository: atlas Description --- This patch handles data type value exceeding and throws proper exception when we create Relationship entity. Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b Diff: https://reviews.apache.org/r/71160/diff/4/ Changes: https://reviews.apache.org/r/71160/diff/3-4/ Testing (updated) --- Testing done Lower limit and Upper limit of primitive datatypes. Here, I have made changes for lower and upper limit for float and double. Also for boolean datatype I have handled scenarios mentioned in jira. In case of boolean, we need to compare here actual content of the input string, because Boolean constructor with string as an argument considers everything false other than argument case in-sensitive "true". Also here for input as null to the method getNormalizedValue() we cannnot return value true, It will break test-case testBooleanTypeGetNormalizedValue() Thanks, Mandar Ambawane
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
> On July 28, 2019, 8:43 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java > > Lines 408 (patched) > > <https://reviews.apache.org/r/71160/diff/4/?file=2158029#file2158029line411> > > > > Can 'float' value be outside the range of (-Float.MAX_VALUE .. > > Float.MAX_VALUE)? If 'num' is of BigInteger or BigDecimal, you should > > convert to a BigDecimal and perform range check. When float value is beyond the lower limit, num.floatValue() returns -Infinity. and when float value is beyond the upper limit, num.floatValue() returns +Infinity. Thats why I think we dont need to use BigDecimal over here. > On July 28, 2019, 8:43 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java > > Lines 494 (patched) > > <https://reviews.apache.org/r/71160/diff/4/?file=2158029#file2158029line497> > > > > Can 'double' value be outside the range of (-Double.MAX_VALUE .. > > Double.MAX_VALUE)? If 'num' is of BigInteger or BigDecimal, you should > > convert to a BigDecimal and perform range check. When double value is beyond the lower limit, num.doubleValue() returns -Infinity. and when double value is beyond the upper limit, num.doubleValue() returns +Infinity. Thats why I think we dont need to use BigDecimal over here. - Mandar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/#review216902 --- On July 28, 2019, 6:22 p.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71160/ > --- > > (Updated July 28, 2019, 6:22 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3347 > https://issues.apache.org/jira/browse/ATLAS-3347 > > > Repository: atlas > > > Description > --- > > This patch handles data type value exceeding and throws proper exception when > we create Relationship entity. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b > > > Diff: https://reviews.apache.org/r/71160/diff/4/ > > > Testing > --- > > Testing done Lower limit and Upper limit of primitive datatypes. > > Here, I have made changes for lower and upper limit for float and double. > > Also for boolean datatype I have handled scenarios mentioned in jira. > > In case of boolean, we need to compare here actual content of the input > string, because Boolean constructor with string as an argument considers > everything false other than argument case in-sensitive "true". > > Also here for input as null to the method getNormalizedValue() we cannnot > return value true, It will break test-case > testBooleanTypeGetNormalizedValue() > > > Thanks, > > Mandar Ambawane > >
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
> On July 27, 2019, 8:43 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java > > Lines 63 (patched) > > <https://reviews.apache.org/r/71160/diff/3/?file=2157980#file2157980line63> > > > > Given getNormalizedValue() returns null only when obj is null, it will > > be efficient to replace this method body to return true - just as the > > earlier implementation. input as null to the method getNormalizedValue() we cannnot return value true, It will break test-case testBooleanTypeGetNormalizedValue() - Mandar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/#review216892 --- On July 28, 2019, 6:22 p.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71160/ > --- > > (Updated July 28, 2019, 6:22 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3347 > https://issues.apache.org/jira/browse/ATLAS-3347 > > > Repository: atlas > > > Description > --- > > This patch handles data type value exceeding and throws proper exception when > we create Relationship entity. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b > > > Diff: https://reviews.apache.org/r/71160/diff/4/ > > > Testing > --- > > Testing done Lower limit and Upper limit of primitive datatypes. > > Here, I have made changes for lower and upper limit for float and double. > > Also for boolean datatype I have handled scenarios mentioned in jira. > > In case of boolean, we need to compare here actual content of the input > string, because Boolean constructor with string as an argument considers > everything false other than argument case in-sensitive "true". > > Also here for input as null to the method getNormalizedValue() we cannnot > return value true, It will break test-case > testBooleanTypeGetNormalizedValue() > > > Thanks, > > Mandar Ambawane > >
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/ --- (Updated July 31, 2019, 12:36 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- This patch addresses review comments from Madhan. Also added test cases to validate boundary cases for primitive types, with their MIN/MAX values. Precommit build started: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1321/console Bugs: ATLAS-3347 https://issues.apache.org/jira/browse/ATLAS-3347 Repository: atlas Description --- This patch handles data type value exceeding and throws proper exception when we create Relationship entity. Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java ec5f75a intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java a7ada38 intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java b3cbe72 intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java 64fc3e3 intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java c2b5eb4 intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java 7eefcc2 intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java 2b15ba0 Diff: https://reviews.apache.org/r/71160/diff/5/ Changes: https://reviews.apache.org/r/71160/diff/4-5/ Testing --- Testing done Lower limit and Upper limit of primitive datatypes. Here, I have made changes for lower and upper limit for float and double. Also for boolean datatype I have handled scenarios mentioned in jira. In case of boolean, we need to compare here actual content of the input string, because Boolean constructor with string as an argument considers everything false other than argument case in-sensitive "true". Also here for input as null to the method getNormalizedValue() we cannnot return value true, It will break test-case testBooleanTypeGetNormalizedValue() Thanks, Mandar Ambawane
Review Request 71115: ATLAS-3335 Update Sqoop/Storm hook to use relationship attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71115/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3335 https://issues.apache.org/jira/browse/ATLAS-3335 Repository: atlas Description --- ATLAS-3335 Update Sqoop/Storm hook to use relationship attributes Diffs - addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 3ccd426 addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 517a3c3 Diff: https://reviews.apache.org/r/71115/diff/1/ Testing --- Executed sqoop import with mysql to hive. pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1285/console Thanks, Mandar Ambawane
Review Request 71160: CDPD-882 CDPD-885
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: CDPD-882 and CDPD-885 https://issues.apache.org/jira/browse/CDPD-882 https://issues.apache.org/jira/browse/CDPD-885 Repository: atlas Description --- CDPD-882 and CDPD-885 This patch handles data type value exceeding and throws proper exception when we create Relationship entity. Diffs - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b Diff: https://reviews.apache.org/r/71160/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/ --- (Updated July 25, 2019, 5:52 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type. Summary (updated) - ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type. Bugs: ATLAS-3347 https://issues.apache.org/jira/browse/ATLAS-3347 Repository: atlas Description (updated) --- This patch handles data type value exceeding and throws proper exception when we create Relationship entity. Diffs - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b Diff: https://reviews.apache.org/r/71160/diff/1/ Testing (updated) --- Testing done Lower limit and Upper limit of primitive datatypes. Thanks, Mandar Ambawane
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/ --- (Updated July 25, 2019, 1:26 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type. Bugs: ATLAS-3347 https://issues.apache.org/jira/browse/ATLAS-3347 Repository: atlas Description --- This patch handles data type value exceeding and throws proper exception when we create Relationship entity. Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b Diff: https://reviews.apache.org/r/71160/diff/2/ Changes: https://reviews.apache.org/r/71160/diff/1-2/ Testing (updated) --- Testing done Lower limit and Upper limit of primitive datatypes. Work in progress as some test cases are failing. Thanks, Mandar Ambawane
Re: Review Request 71160: ATLAS-3347 :- Relationships instance attributes validation for primitive inbuilt type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71160/ --- (Updated July 26, 2019, 11:19 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- ATLAS-3347 : Addressing review comments Bugs: ATLAS-3347 https://issues.apache.org/jira/browse/ATLAS-3347 Repository: atlas Description --- This patch handles data type value exceeding and throws proper exception when we create Relationship entity. Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ce14b5b Diff: https://reviews.apache.org/r/71160/diff/3/ Changes: https://reviews.apache.org/r/71160/diff/2-3/ Testing --- Testing done Lower limit and Upper limit of primitive datatypes. Work in progress as some test cases are failing. Thanks, Mandar Ambawane
Re: Review Request 71670: Added headers in atlas api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71670/ --- (Updated Nov. 4, 2019, 2:37 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Added HeaderUtil to read headers from a single file. Bugs: ATLAS-3490 https://issues.apache.org/jira/browse/ATLAS-3490 Repository: atlas Description --- Added headers in atlas api by using AtlasHeaderFilter Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java f56aeb4 webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 277ac22 webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 8bac8c6 webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 0b1bbd8 webapp/src/main/webapp/WEB-INF/web.xml 8f3f175 Diff: https://reviews.apache.org/r/71670/diff/2/ Changes: https://reviews.apache.org/r/71670/diff/1-2/ Testing (updated) --- Tested headers for following apis GET: atlas/api/atlas/admin/metrics GET: atlas/api/atlas/admin/status Basic testing done for headers. Thanks, Mandar Ambawane
Review Request 71883: ATLAS-3549: Add a new REST endpoint to get EntityHeader using unique attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71883/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3549 https://issues.apache.org/jira/browse/ATLAS-3549 Repository: atlas Description --- This patch address requirement to add new api to get AtlasEntityHeader by unique attributes. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 49dd5c5 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java c8e65ef webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 33f4828 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java b747124 Diff: https://reviews.apache.org/r/71883/diff/1/ Testing --- Basic testing done. Test cases added in TestEntityREST Thanks, Mandar Ambawane
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71623/ --- (Updated Oct. 18, 2019, 10:31 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Handled review comments, Added Base class "AtlasHTTPServlet" to incorporate changes without using "if" clause. Bugs: ATLAS-3472 https://issues.apache.org/jira/browse/ATLAS-3472 Repository: atlas Description --- This patch uses Servlets instead of JSP files to render login and error page. Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION webapp/src/main/resources/spring-security.xml 1295244 webapp/src/main/webapp/WEB-INF/web.xml 23dc063 webapp/src/main/webapp/error.html.template PRE-CREATION webapp/src/main/webapp/error.jsp 29ef640 webapp/src/main/webapp/login.html.template PRE-CREATION webapp/src/main/webapp/login.jsp 70ec06d Diff: https://reviews.apache.org/r/71623/diff/3/ Changes: https://reviews.apache.org/r/71623/diff/2-3/ Testing --- https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console Tested in browser with simple mode. Tested in browser with Knox proxy on kerberos mode. Thanks, Mandar Ambawane
Review Request 71623: ATLAS-3472 Port jsp's to Servlet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71623/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3472 https://issues.apache.org/jira/browse/ATLAS-3472 Repository: atlas Description --- This patch uses Servlets instead of JSP files to render login and error page. Diffs - webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java PRE-CREATION webapp/src/main/resources/spring-security.xml 1295244 webapp/src/main/webapp/WEB-INF/web.xml 23dc063 webapp/src/main/webapp/error.html.template PRE-CREATION webapp/src/main/webapp/error.jsp 29ef640 webapp/src/main/webapp/login.html.template PRE-CREATION webapp/src/main/webapp/login.jsp 70ec06d Diff: https://reviews.apache.org/r/71623/diff/1/ Testing --- https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console Thanks, Mandar Ambawane
Review Request 71670: Added headers in atlas api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71670/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3490 https://issues.apache.org/jira/browse/ATLAS-3490 Repository: atlas Description --- Added headers in atlas api by using AtlasHeaderFilter Diffs - webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml 8f3f175 Diff: https://reviews.apache.org/r/71670/diff/1/ Testing --- Tested headers for following apis GET: atlas/api/atlas/admin/metrics GET: atlas/api/atlas/admin/status Thanks, Mandar Ambawane
Re: Review Request 71623: ATLAS-3472 Port jsp's to Servlet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71623/ --- (Updated Oct. 19, 2019, 3:10 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments. Moved constants to respective classes. Bugs: ATLAS-3472 https://issues.apache.org/jira/browse/ATLAS-3472 Repository: atlas Description --- This patch uses Servlets instead of JSP files to render login and error page. Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/servlets/AtlasErrorServlet.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/servlets/AtlasHttpServlet.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/servlets/AtlasLoginServlet.java PRE-CREATION webapp/src/main/resources/spring-security.xml 1295244 webapp/src/main/webapp/WEB-INF/web.xml 23dc063 webapp/src/main/webapp/error.html.template PRE-CREATION webapp/src/main/webapp/error.jsp 29ef640 webapp/src/main/webapp/login.html.template PRE-CREATION webapp/src/main/webapp/login.jsp 70ec06d Diff: https://reviews.apache.org/r/71623/diff/4/ Changes: https://reviews.apache.org/r/71623/diff/3-4/ Testing --- https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console Tested in browser with simple mode. Tested in browser with Knox proxy on kerberos mode. Thanks, Mandar Ambawane
Review Request 71794: ATLAS-3233 Relationships, Export & Import : Issue with ACTIVE and DELETED relationship-def instances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71794/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3233 https://issues.apache.org/jira/browse/ATLAS-3233 Repository: atlas Description --- Here I have handled deletion part of relationship in case of import. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25 Diff: https://reviews.apache.org/r/71794/diff/1/ Testing --- Basic testing is done. UT/ITs pending. Thanks, Mandar Ambawane
Re: Review Request 71831: ATLAS-3539 :- Difference between hive_db information sent to ATLAS_HOOK created by beeline vs spark-shell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71831/ --- (Updated Nov. 27, 2019, 11:08 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Summary (updated) - ATLAS-3539 :- Difference between hive_db information sent to ATLAS_HOOK created by beeline vs spark-shell Bugs: ATLAS-3539 https://issues.apache.org/jira/browse/ATLAS-3539 Repository: atlas Description (updated) --- Issue:- Difference in information sent to ATLAS_HOOK while database creation from Beeline and Spark. Observation:- When we fetch database entity by MetastoreEvent object, we don't get ownerType attribute. But when we fetch database entity by MetastoreHandler object, we get ownerType attribute for the database. Fix:- At the time of Table creation from the Spark-Client, our code fetches Database object by using MetastoreHandler, there we can get ownerType in Database. Therefore here I have used MetastoreHandler object to fetch Database object. Also handled the description attribute null and empty case. Diffs - addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 851582c addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java 7bea779 Diff: https://reviews.apache.org/r/71831/diff/1/ Testing --- Manual testing done as follwos 1. Database created from beeling client. 2. Cheked for the json sent to ATLAS-HOOK, here attribute ownerType was present. 3. Database create from Spark client. 4. Checked for the json sent to ATLAS-HOOK, here attribute ownerType was present. PreCommit build is successful. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1565/console Thanks, Mandar Ambawane
Re: Review Request 71831: ATLAS-3539 :- Difference between hive_db information sent to ATLAS_HOOK created by beeline vs spark-shell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71831/ --- (Updated Nov. 28, 2019, 8:56 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments, getHiveMetastoreEntities() method gets called from 2 places, 1. AlterDatabase.getNotificationMessages() and 2. CreateDatabase.getNotificationMessages() In both the cases only when context.isMetastoreHook() == true. Therefore we don't need to check context.isMetastoreHook() in method getHiveMetastoreEntities() Bugs: ATLAS-3539 https://issues.apache.org/jira/browse/ATLAS-3539 Repository: atlas Description --- Issue:- Difference in information sent to ATLAS_HOOK while database creation from Beeline and Spark. Observation:- When we fetch database entity by MetastoreEvent object, we don't get ownerType attribute. But when we fetch database entity by MetastoreHandler object, we get ownerType attribute for the database. Fix:- At the time of Table creation from the Spark-Client, our code fetches Database object by using MetastoreHandler, there we can get ownerType in Database. Therefore here I have used MetastoreHandler object to fetch Database object. Also handled the description attribute null and empty case. Diffs (updated) - addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 851582c addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java 7bea779 Diff: https://reviews.apache.org/r/71831/diff/2/ Changes: https://reviews.apache.org/r/71831/diff/1-2/ Testing --- Manual testing done as follwos 1. Database created from beeling client. 2. Cheked for the json sent to ATLAS-HOOK, here attribute ownerType was present. 3. Database create from Spark client. 4. Checked for the json sent to ATLAS-HOOK, here attribute ownerType was present. PreCommit build is successful. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1565/console Thanks, Mandar Ambawane
Re: Review Request 71831: ATLAS-3539 :- Difference between hive_db information sent to ATLAS_HOOK created by beeline vs spark-shell
> On Nov. 27, 2019, 5:22 p.m., Ashutosh Mestry wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java > > Lines 63 (patched) > > <https://reviews.apache.org/r/71831/diff/1/?file=2179542#file2179542line63> > > > > Comment: Is _getMetastoreHandler_ guaranteed to be present? > > > > I am not entirely sure if this line can be: > > > > _db = context.getMetastoreHandler() != null ? > > context.getMetastoreHandler().get_database(db.getName()) : null; > > _ getHiveMetastoreEntities() method gets called from 2 places, 1. AlterDatabase.getNotificationMessages() and 2. CreateDatabase.getNotificationMessages() In both the cases only when context.isMetastoreHook() == true. Therefore we don't need to check context.isMetastoreHook() in method getHiveMetastoreEntities() - Mandar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71831/#review218827 ------- On Nov. 27, 2019, 11:08 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71831/ > --- > > (Updated Nov. 27, 2019, 11:08 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3539 > https://issues.apache.org/jira/browse/ATLAS-3539 > > > Repository: atlas > > > Description > --- > > Issue:- Difference in information sent to ATLAS_HOOK while database creation > from Beeline and Spark. > > Observation:- > When we fetch database entity by MetastoreEvent object, we don't get > ownerType attribute. > But when we fetch database entity by MetastoreHandler object, we get > ownerType attribute for the database. > > Fix:- > At the time of Table creation from the Spark-Client, our code fetches > Database object by using MetastoreHandler, there we can get ownerType in > Database. > Therefore here I have used MetastoreHandler object to fetch Database object. > > Also handled the description attribute null and empty case. > > > Diffs > - > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java > 851582c > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java > 7bea779 > > > Diff: https://reviews.apache.org/r/71831/diff/1/ > > > Testing > --- > > Manual testing done as follwos > 1. Database created from beeling client. > 2. Cheked for the json sent to ATLAS-HOOK, here attribute ownerType was > present. > 3. Database create from Spark client. > 4. Checked for the json sent to ATLAS-HOOK, here attribute ownerType was > present. > > PreCommit build is successful. > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1565/console > > > Thanks, > > Mandar Ambawane > >
Re: Review Request 71794: ATLAS-3233 Relationships, Export & Import : Issue with ACTIVE and DELETED relationship-def instances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71794/ --- (Updated Nov. 22, 2019, 12:04 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Handled NPE. Bugs: ATLAS-3233 https://issues.apache.org/jira/browse/ATLAS-3233 Repository: atlas Description --- Here I have handled deletion part of relationship in case of import. Diffs (updated) - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25 Diff: https://reviews.apache.org/r/71794/diff/2/ Changes: https://reviews.apache.org/r/71794/diff/1-2/ Testing --- Basic testing is done. UT/ITs pending. Thanks, Mandar Ambawane
Re: Review Request 71794: ATLAS-3233 Relationships, Export & Import : Issue with ACTIVE and DELETED relationship-def instances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71794/ --- (Updated Nov. 22, 2019, 12:53 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3233 https://issues.apache.org/jira/browse/ATLAS-3233 Repository: atlas Description (updated) --- While importing, if we have 2 edges between two entities, one ACTIVE edge and one DELETED edge. While creating such entities via import, Existing code only checkes for the guids of the corresponding Vertices. If they are not matched then the relationship gets updated. Otherwise there was not updation of relationship. Because of this, while importing entity, In import-json the status of relationship is changed from ACTIVE to DELETED still Relationship was not getting updated. (As its IN vertex and OUT vertex are unchanged.) Now after this changes, In importing process, relationshipStatus of incoming relationship is checked. and if its DELETED then we send relationship for deletion.(which is a soft deletion.) This updation of relationshipStatus is used further in case of new relationship creation (whose status is ACTIVE in importing process) Therefore only by deleting existing relationship, we can handle this issue. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25 Diff: https://reviews.apache.org/r/71794/diff/2/ Testing --- Basic testing is done. UT/ITs pending. Thanks, Mandar Ambawane
Review Request 71831: ATLAS-3539 Difference between hive_db information sent to ATLAS_HOOK created by beeline vs spark-shell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71831/ --- Review request for atlas and Nixon Rodrigues. Bugs: ATLAS-3539 https://issues.apache.org/jira/browse/ATLAS-3539 Repository: atlas Description --- When we fetch database entity by MetastoreEvent object, we do'nt get ownerType attribute. But when we fetch database entity by MetastoreHandler object, we get ownerType attribute for the database. At the time of Table creation from the Spark-Client, our code fetches Database object by using MetastoreHandler, there we can get ownerType in Database. Therefore here I have used MetastoreHandler object to fetch Database object. Also handled the description attribute null and empty case. Diffs - addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 851582c addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java 7bea779 Diff: https://reviews.apache.org/r/71831/diff/1/ Testing --- Manual testing done as follwos 1. Database created from beeling client. 2. Cheked for the json sent to ATLAS-HOOK, here attribute ownerType was present. 3. Database create from Spark client. 4. Checked for the json sent to ATLAS-HOOK, here attribute ownerType was present. PreCommit build is successful. https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1565/console Thanks, Mandar Ambawane
Review Request 71924: ATLAS-3562: Hive metadata has the same classification multiple times
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71924/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3562 https://issues.apache.org/jira/browse/ATLAS-3562 Repository: atlas Description --- Put Lock on entity before its gets cached. Moved GraphTransactionInterceptor.lockObjectAndReleasePostCommit(guid); before code gets AtlasVertex for the entity guid. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java ea5e6ab Diff: https://reviews.apache.org/r/71924/diff/1/ Testing --- TESTING: Testing done by sending 2 simultaneous curl resquests to associate same Classification to the same entity. RESULT: Classification gets associted with the entity only once. Application throws exception for the other simultaneous curl request: org.apache.atlas.exception.AtlasBaseException: invalid parameters: entity: , already associated with classification: Thanks, Mandar Ambawane
Review Request 72131: ATLAS-3619 Allow to create a namespace typedef without specifying any applicableEntityTypes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72131/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues. Bugs: ATLAS-3619 https://issues.apache.org/jira/browse/ATLAS-3619 Repository: atlas Description --- Removed throw Exception statement Diffs - intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1 Diff: https://reviews.apache.org/r/72131/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72172: ATLAS-3632Â (Namespace) String attribute length limit does not work during association
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72172/ --- (Updated March 4, 2020, 12:29 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments. Manual testing is done for both String and Multivalued-String namespace attributes Pre-commit build: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1704/console Bugs: ATLAS-3632 https://issues.apache.org/jira/browse/ATLAS-3632 Repository: atlas Description --- Added check for length limit of String value Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede8443 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 30f5e5a repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java e2f5c16 Diff: https://reviews.apache.org/r/72172/diff/3/ Changes: https://reviews.apache.org/r/72172/diff/2-3/ Testing --- Pre-commit build: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1698/console Manul testing done by adding values beyong maximum length for String namespace attributes. Done same for String multi-valued namespace attributes. Thanks, Mandar Ambawane
Review Request 72184: ATLAS-3645 Update default entity permission for labels and namespace resource in atlas-simple-authz-policy.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72184/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3645 https://issues.apache.org/jira/browse/ATLAS-3645 Repository: atlas Description --- Added namespaces, labels and attributes in entityPermissions atlas-simple-authz-policy.json Also updated setter of labels in AtlasSimpleAuthzPolicy.java Diffs - authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java 899e386 distro/src/conf/atlas-simple-authz-policy.json 9c81fa1 Diff: https://reviews.apache.org/r/72184/diff/1/ Testing --- Manually tested Namespace-Entity association, Labeling of entities and custom attributes PC build - https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1692/ Thanks, Mandar Ambawane
Re: Review Request 72172: ATLAS-3632Â (Namespace) String attribute length limit does not work during association
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72172/ --- (Updated March 3, 2020, 3:04 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Moved isValidLength() in AtlasNamespaceAttribute. Added Max length check for Multi-valued String Namespace attributes. Changes in AtlasNamespaceDefStoreV2Test to handle mandatory field maxStrLength empty/null value Bugs: ATLAS-3632 https://issues.apache.org/jira/browse/ATLAS-3632 Repository: atlas Description --- Added check for length limit of String value Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede8443 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 30f5e5a repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java e2f5c16 Diff: https://reviews.apache.org/r/72172/diff/2/ Changes: https://reviews.apache.org/r/72172/diff/1-2/ Testing (updated) --- Pre-commit build: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1698/console Manul testing done by adding values beyong maximum length for String namespace attributes. Done same for String multi-valued namespace attributes. Thanks, Mandar Ambawane
Review Request 72171: ATLAS-3625Â Add Test cases for Namespace type creation and Namespace-Entity association.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72171/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3625 https://issues.apache.org/jira/browse/ATLAS-3625 Repository: atlas Description --- Given is the patch for "Namespace type creation and Namespace-Entity association" handling various scenarios Diffs - intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 5b115b5 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 6fe5063 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java cbac18c webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 9584f99 Diff: https://reviews.apache.org/r/72171/diff/1/ Testing --- Thanks, Mandar Ambawane
Review Request 72172: ATLAS-3632Â (Namespace) String attribute length limit does not work during association
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72172/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3632 https://issues.apache.org/jira/browse/ATLAS-3632 Repository: atlas Description --- Added check for length limit of String value Diffs - intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java ed1e5de intg/src/main/java/org/apache/atlas/type/AtlasType.java b30b483 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 30f5e5a Diff: https://reviews.apache.org/r/72172/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
wheels",
"typeName": "int",
"options": {
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Review Request 72050: ATLAS-3597 Incorrect error message when attempting to update Namespacedef
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72050/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3597 https://issues.apache.org/jira/browse/ATLAS-3597 Repository: atlas Description --- Added new constant in AtlasErrorCode Diffs - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2054513 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java eaaf6bb Diff: https://reviews.apache.org/r/72050/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
eInNotification": true,
"isUnique": false
},
{
"name": "no_of_wheels",
"typeName": "int",
"options": {
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
> On Jan. 29, 2020, 12:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
> > Lines 773 (patched)
> > <https://reviews.apache.org/r/72046/diff/5/?file=2209867#file2209867line773>
> >
> > Instead of iterating through all vertex attributes, consider the
> > following approach:
> >
> > AtlasEntityTypeentityType =
> > typeRegistry.getEntityType(entity.getTypeName());
> > Map> entityNamespaces =
> > entityType.getNamespaceAttributes();
> >
> > if (MapUtils.isNotEmpty(entityNamespaces)) {
> > for (Map.Entry> nsEntry :
> > entityNamespaces.entrySet()) {
> > StringnsName = nsEntry.getKey();
> > List nsAttributes = nsEntry.getValue();
> >
> > for (AtlasNamespaceAttribute nsAttribute : nsAttributes) {
> > Object attrValue = mapVertexToAttribute(entityVertex,
> > nsAttribute, null, false, false);
> >
> > entity.setNamespaceAttribute(nsName, nsAttribute.getName(),
> > attrValue);
> > }
> > }
> > }
> >
> > Also update EntityGraphMapper to use above approach (of using
> > entityType.getNamespaceAttributes() and AtlasNamespaceAttribute) to
> > save/update/delete namespace attributes in vertex.
In AtlasEntityStoreV2.addNamespaceAttributes(),
AtlasEntityStoreV2.updateNamespaceAttributes() and
AtlasEntityStoreV2.removeNamespaceAttributes()
There is call for method validateNamespaceAttributes(). This method will handle
the namespace attributes validation.
Please let me know if I am missing something here.
- Mandar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72046/#review219415
---
On Jan. 30, 2020, 1:15 p.m., Mandar Ambawane wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72046/
> ---
>
> (Updated Jan. 30, 2020, 1:15 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
> and Sarath Subramanian.
>
>
> Bugs: ATLAS-3534
> https://issues.apache.org/jira/browse/ATLAS-3534
>
>
> Repository: atlas
>
>
> Description
> ---
>
> Created separate endpoints to associate Namespace attributes to entity
>
>
> Diffs
> -
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 0b28243
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2054513
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 1b033b9
> intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java a141d4a
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
> 928c70d
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
> 25284e9
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
> e427a59
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
> dc4c399
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6845121
>
>
> Diff: https://reviews.apache.org/r/72046/diff/7/
>
>
> Testing
> ---
>
> Basic testing is done.
>
> Create NamespaceDef sports:
>
> curl --location --request POST
> 'http://localhost:21000/api/atlas/v2/types/typedefs' \
> --header 'Content-Type: application/json' \
> --header 'Authorization: Basic YWRtaW46YWRtaW4=' \
> --data-raw '{
> "namespaceDefs": [
> {
> "name": "sports",
> "description": "Sample sports",
> "serviceType": "NAMESPACES",
> "typeVersion": "1.0",
> "attributeDefs": [
> {
> "name": "sports_name",
> "typeName": "string",
> "options": {
> "applicableEntityTypes": "[\"hdfs_path\",
> \"hive_table\"]",
> "maxStrLength": "50"
>
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request PUT
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
"typeName": "int",
"options": {
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request PUT
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
"options": {
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request PUT
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request PUT
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
{
"name": "no_of_wheels",
"typeName": "int",
"options": {
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request PUT
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
},
{
"name": "no_of_wheels",
"typeName": "int",
"options": {
"applicableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespace'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72046: ATLAS-3534 EntityREST changes to allow namespace attributes to be added, updated and deleted to an entity instance
licableEntityTypes": "[\"hdfs_path\",
\"hive_column\"]"
},
"cardinality": "SINGLE",
"isIndexable": true,
"isOptional": true,
"includeInNotification": true,
"isUnique": false
}
]
}
]
}'
Create hdfs_path entity:
curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"entity": {
"guid": "-1",
"typeName": "hdfs_path",
"attributes": {
"clusterName": "cm",
"description": "desc",
"location": "localhost",
"name": "hdfs_path_entity1",
"owner": "admin",
"ownerType": "USER",
"qualifiedName": "hdfs_path_entity1@cm",
"path": "local_path"
}
}
}'
Associate namespace attributes with the created entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name":"cricket",
"no_of_players":11
},
"vehicle":{
"vehicle_name": "Car"
}
}'
Add one more namespace attribute in the entity
curl --location --request POST
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"no_of_wheels": 4
}
}'
Update sports_name attribute with new value as Hockey
curl --location --request PUT
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"sports":{
"sports_name": "Hockey"
}
}'
Delete vehicle.vehicle_name namespace attribute
curl --location --request DELETE
'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces'
\
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--data-raw '{
"vehicle":{
"vehicle_name": "Car"
}
}'
Thanks,
Mandar Ambawane
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace typedef without specifying any applicableEntityTypes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72131/ --- (Updated Feb. 15, 2020, 3:13 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues. Changes --- Removed unused Error codes Bugs: ATLAS-3619 https://issues.apache.org/jira/browse/ATLAS-3619 Repository: atlas Description --- Removed throw Exception statement Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 1670bda intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1 Diff: https://reviews.apache.org/r/72131/diff/3/ Changes: https://reviews.apache.org/r/72131/diff/2-3/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72131: ATLAS-3619 Allow to create a namespace typedef without specifying any applicableEntityTypes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72131/ --- (Updated Feb. 14, 2020, 7:35 a.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues. Changes --- Changes to allow namespace to have mandatory as well as unique attributes Bugs: ATLAS-3619 https://issues.apache.org/jira/browse/ATLAS-3619 Repository: atlas Description --- Removed throw Exception statement Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java cfbf2b1 Diff: https://reviews.apache.org/r/72131/diff/2/ Changes: https://reviews.apache.org/r/72131/diff/1-2/ Testing --- Thanks, Mandar Ambawane
Review Request 72128: ATLAS-3614 Add a configuration to specify default classification-propagation flag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72128/ --- Review request for atlas, Madhan Neethiraj and Nixon Rodrigues. Bugs: ATLAS-3614 https://issues.apache.org/jira/browse/ATLAS-3614 Repository: atlas Description --- Read classification-propagation value from property file Diffs - distro/src/conf/atlas-application.properties 7846452 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 113325d Diff: https://reviews.apache.org/r/72128/diff/1/ Testing --- Thanks, Mandar Ambawane
Review Request 72009: ATLAS-3589 Unable to search typeDefs of category "Namespace"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72009/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3589 https://issues.apache.org/jira/browse/ATLAS-3589 Repository: atlas Description --- ATLAS-3589 Unable to search typeDefs of category "Namespace" Diffs - repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 5b16dda Diff: https://reviews.apache.org/r/72009/diff/1/ Testing --- Thanks, Mandar Ambawane
Review Request 72226: ATLAS-3645 Update default entity permission for business-metadata in atlas-simple-authz-policy.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72226/ --- Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3645 https://issues.apache.org/jira/browse/ATLAS-3645 Repository: atlas Description --- ATLAS-3645 Update default entity permission for business-metadata in atlas-simple-authz-policy.json Diffs - authorization/src/main/resources/atlas-simple-authz-policy.json bd08a6f distro/src/conf/atlas-simple-authz-policy.json 6d72ab3 Diff: https://reviews.apache.org/r/72226/diff/1/ Testing --- Thanks, Mandar Ambawane
Review Request 72232: ATLAS-3632 Max length check for business-metadata string attributes and Test cases which cover 1.business-metadata typedef creation 2.entity-BM association 3.Max length check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72232/ --- Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3632 https://issues.apache.org/jira/browse/ATLAS-3632 Repository: atlas Description --- Max length check for business-metadata string attributes Test cases: 1.business-metadata typedef creation 2.entity-BM association 3.Max length check for business-metadata string attributes Diffs - intg/src/main/java/org/apache/atlas/type/AtlasBusinessMetadataType.java 0f4725f intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java e9d8683 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 6fe5063 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 1e40f48 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2Test.java b990b83 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java 51d55b9 webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 9584f99 Diff: https://reviews.apache.org/r/72232/diff/1/ Testing --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1733/consoleFull Thanks, Mandar Ambawane
Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/ --- (Updated April 8, 2020, 2:15 p.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Bugs: ATLAS-3709 https://issues.apache.org/jira/browse/ATLAS-3709 Repository: atlas Description --- Resolved issues in conjunction with Business Metadata attributes. Also handled index populate for Business Metadata attributes at the time of start up. Diffs (updated) - intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 647e304 Diff: https://reviews.apache.org/r/72317/diff/2/ Changes: https://reviews.apache.org/r/72317/diff/1-2/ Testing --- Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console Manual testing done. CASE:1 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. add another attribute "attr2" in "BM1" (search weight 9) 7. associate "attr2" to "hdfsentity1" 8. check in quick search and suggestions CASE:2 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. add another attribute "attr2" in "BM1" (search weight 10) 7. associate "attr2" to "hdfsentity1" 8. check in quick search and suggestions for "attr1" and "attr2" values CASE:3 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. create another Busines meatadata "BM2" 7. add attribute "attr2" in "BM2" (search weight 9) 8. associate "attr2" to "hdfsentity1" 9. check in quick search and suggestions for "attr1" and "attr2" values Thanks, Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- (Updated April 8, 2020, 2:30 p.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs (updated) - intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java 590f7a0 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 0d5b631 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/3/ Changes: https://reviews.apache.org/r/72270/diff/2-3/ Testing --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Basic testing is done. Thanks, Mandar Ambawane
Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/ --- (Updated April 9, 2020, 8:32 p.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3709 https://issues.apache.org/jira/browse/ATLAS-3709 Repository: atlas Description --- Resolved issues in conjunction with Business Metadata attributes. Also handled index populate for Business Metadata attributes at the time of start up. Diffs - intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 647e304 Diff: https://reviews.apache.org/r/72317/diff/2/ Testing (updated) --- Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1793/console Manual testing done. CASE:1 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. add another attribute "attr2" in "BM1" (search weight 9) 7. associate "attr2" to "hdfsentity1" 8. check in quick search and suggestions CASE:2 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. add another attribute "attr2" in "BM1" (search weight 10) 7. associate "attr2" to "hdfsentity1" 8. check in quick search and suggestions for "attr1" and "attr2" values CASE:3 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. create another Busines meatadata "BM2" 7. add attribute "attr2" in "BM2" (search weight 9) 8. associate "attr2" to "hdfsentity1" 9. check in quick search and suggestions for "attr1" and "attr2" values Thanks, Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- (Updated April 9, 2020, 8:22 p.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Resolved test case failures and some code refactoring Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs (updated) - intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 0d5b631 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/4/ Changes: https://reviews.apache.org/r/72270/diff/3-4/ Testing (updated) --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console Basic testing is done. Thanks, Mandar Ambawane
Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/ --- (Updated April 10, 2020, 9:24 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Some code refactoring Bugs: ATLAS-3709 https://issues.apache.org/jira/browse/ATLAS-3709 Repository: atlas Description --- Resolved issues in conjunction with Business Metadata attributes. Also handled index populate for Business Metadata attributes at the time of start up. Diffs (updated) - intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 647e304 repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 814b9f5 Diff: https://reviews.apache.org/r/72317/diff/3/ Changes: https://reviews.apache.org/r/72317/diff/2-3/ Testing --- Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1793/console Manual testing done. CASE:1 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. add another attribute "attr2" in "BM1" (search weight 9) 7. associate "attr2" to "hdfsentity1" 8. check in quick search and suggestions CASE:2 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. add another attribute "attr2" in "BM1" (search weight 10) 7. associate "attr2" to "hdfsentity1" 8. check in quick search and suggestions for "attr1" and "attr2" values CASE:3 1. create Busines meatadata "BM1" 2. add one attribute "attr1" in "BM1" (search weight 9) 3. create one entity "hdfsentity1" 4. associate "attr1" to "hdfsentity1" 5. check in quick search and suggestions for "attr1" value 6. create another Busines meatadata "BM2" 7. add attribute "attr2" in "BM2" (search weight 9) 8. associate "attr2" to "hdfsentity1" 9. check in quick search and suggestions for "attr1" and "attr2" values Thanks, Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- (Updated April 11, 2020, 11:57 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs (updated) - intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 8819688 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/5/ Changes: https://reviews.apache.org/r/72270/diff/4-5/ Testing --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console Basic testing is done. Thanks, Mandar Ambawane
Re: Review Request 72372: ATLAS-3695 [Business Metadata] Special characters are being allowed in Attribute Name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72372/ --- (Updated April 16, 2020, 5:27 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3695 https://issues.apache.org/jira/browse/ATLAS-3695 Repository: atlas Description --- ATLAS-3695 [Business Metadata] Special characters are being allowed in Attribute Name Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 16947ec repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java 5f4136f Diff: https://reviews.apache.org/r/72372/diff/2/ Changes: https://reviews.apache.org/r/72372/diff/1-2/ Testing (updated) --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1815/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1817/console Basic testing is done. Thanks, Mandar Ambawane
Review Request 72372: ATLAS-3695 [Business Metadata] Special characters are being allowed in Attribute Name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72372/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3695 https://issues.apache.org/jira/browse/ATLAS-3695 Repository: atlas Description --- ATLAS-3695 [Business Metadata] Special characters are being allowed in Attribute Name Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java 5f4136f Diff: https://reviews.apache.org/r/72372/diff/1/ Testing --- Basic testing is done. Thanks, Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- (Updated April 12, 2020, 8:04 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs (updated) - dashboardv2/public/js/utils/Enums.js e2d8cd2 dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 8819688 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/6/ Changes: https://reviews.apache.org/r/72270/diff/5-6/ Testing (updated) --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console Basic testing is done. Thanks, Mandar Ambawane
Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs - intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java 590f7a0 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 75b016c repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/1/ Testing --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Basic testing is done. Thanks, Mandar Ambawane
Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3709 https://issues.apache.org/jira/browse/ATLAS-3709 Repository: atlas Description --- Resolved issues in conjunction with Business Metadata attributes. Also handled index populate for Business Metadata attributes at the time of start up. Diffs - intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 647e304 Diff: https://reviews.apache.org/r/72317/diff/1/ Testing --- Manual testing done. Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console Thanks, Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- (Updated March 31, 2020, 7:28 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs (updated) - intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java 590f7a0 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 75b016c repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/2/ Changes: https://reviews.apache.org/r/72270/diff/1-2/ Testing --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Basic testing is done. Thanks, Mandar Ambawane
Review Request 72450: ATLAS-3763 Add "serviceType" in AtlasEntityHeader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72450/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3763 https://issues.apache.org/jira/browse/ATLAS-3763 Repository: atlas Description --- Added "serviceType" in AtlasEntityHeader, so from UI https://issues.apache.org/jira/browse/ATLAS-3366 this can be handled Diffs - intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 7d2476a repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 757fcb1 Diff: https://reviews.apache.org/r/72450/diff/1/ Testing --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1856/console Thanks, Mandar Ambawane
Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- (Updated May 13, 2020, 9:13 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs (updated) - addons/models/-Area0/0010-base_model.json 9777b7a intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 9120062 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 79f5270 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 repository/src/test/java/org/apache/atlas/TestModules.java a298934 webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java PRE-CREATION Diff: https://reviews.apache.org/r/72477/diff/3/ Changes: https://reviews.apache.org/r/72477/diff/2-3/ Testing (updated) --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console Thanks, Mandar Ambawane
Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- (Updated May 13, 2020, 3:02 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Changes to store entire TypeDef json in AuditEntry. Added Test cases. Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs (updated) - addons/models/-Area0/0010-base_model.json 9777b7a intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 9120062 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 79f5270 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 repository/src/test/java/org/apache/atlas/TestModules.java a298934 webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java PRE-CREATION Diff: https://reviews.apache.org/r/72477/diff/2/ Changes: https://reviews.apache.org/r/72477/diff/1-2/ Testing (updated) --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console Thanks, Mandar Ambawane
Review Request 72257: ATLAS-3583 Use Audit framework to generate audit entries for Classification CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72257/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- Added listener to listen create/update/delete operations of all type defs. Diffs - addons/models/-Area0/0010-base_model.json 351e07b intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java f2a8b3e repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 79f5270 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AuditChangeListener.java PRE-CREATION Diff: https://reviews.apache.org/r/72257/diff/1/ Testing --- Pre-commit build: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1747/console Manual testing is done. Thanks, Mandar Ambawane
Review Request 72259: ATLAS-3675 Enable quick search and suggestions for business metadata attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72259/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3675 https://issues.apache.org/jira/browse/ATLAS-3675 Repository: atlas Description --- Added solr index for business metadata attributes. >From UI, need to add searchWeight with metadata attributes to support >suggestions. Diffs - intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java af00f6c repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 7c55130 repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 4ec0086 Diff: https://reviews.apache.org/r/72259/diff/1/ Testing --- Pre-commit build: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1746/console Basic testing is done. Thanks, Mandar Ambawane
Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs - addons/models/-Area0/0010-base_model.json 9777b7a intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 Diff: https://reviews.apache.org/r/72477/diff/1/ Testing --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Thanks, Mandar Ambawane
Re: Review Request 72821: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72821/ --- (Updated Sept. 9, 2020, 10:04 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3935 https://issues.apache.org/jira/browse/ATLAS-3935 Repository: atlas Description --- By using Audit Framework, capture audit entries for Import/Export operations. These audit entries can be seen under the "Audits" tab of Admin section. Add Import and Export specific information in Audit entry Total no. of entities imported/ exported Total no. of entities imported/ exported of specific TypeDef Export operation Fetch Type Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a5ae5c Diff: https://reviews.apache.org/r/72821/diff/2/ Changes: https://reviews.apache.org/r/72821/diff/1-2/ Testing --- Thanks, Mandar Ambawane
Review Request 72849: ATLAS-3937 Add Test Cases for Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72849/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3937 https://issues.apache.org/jira/browse/ATLAS-3937 Repository: atlas Description --- This patch addresses Test cases for newly added funtionality ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs - intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 9120062 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 0b1317a repository/src/test/java/org/apache/atlas/TestModules.java a298934 webapp/src/test/java/org/apache/atlas/web/adapters/TypeDefsRESTTest.java PRE-CREATION Diff: https://reviews.apache.org/r/72849/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72821: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72821/ --- (Updated Sept. 8, 2020, 2:18 p.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3935 https://issues.apache.org/jira/browse/ATLAS-3935 Repository: atlas Description --- By using Audit Framework, capture audit entries for Import/Export operations. These audit entries can be seen under the "Audits" tab of Admin section. Add Import and Export specific information in Audit entry Total no. of entities imported/ exported Total no. of entities imported/ exported of specific TypeDef Export operation Fetch Type Diffs - webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a5ae5c Diff: https://reviews.apache.org/r/72821/diff/1/ Testing --- Thanks, Mandar Ambawane
Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72938/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3984 https://issues.apache.org/jira/browse/ATLAS-3984 Repository: atlas Description --- Add UI Date Timezone and UI Date Format in Session api. Provide a way to user to read these "UI Date Timezone" and "UI Date Format" values from property file. Diffs - webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a6139f Diff: https://reviews.apache.org/r/72938/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72908/ --- (Updated Oct. 7, 2020, 8:39 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- 1. Added Host name and Host address. 2. Changed Server start time. Bugs: ATLAS-3957 https://issues.apache.org/jira/browse/ATLAS-3957 Repository: atlas Description --- By using Audit Framework, capture audit entries for "Server Start" and "Server In Active mode" (HA) These audit entries can be seen under the "Audits" tab of Admin section. Diffs (updated) - addons/models/-Area0/0010-base_model.json 1de9e57 addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json a27525e intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 Diff: https://reviews.apache.org/r/72908/diff/2/ Changes: https://reviews.apache.org/r/72908/diff/1-2/ Testing --- https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console Thanks, Mandar Ambawane
Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72938/ --- (Updated Oct. 9, 2020, 6:21 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- UI date format changed from "MM/dd/ hh:mm:ss tt" to "MM/DD/ hh:mm:ss A" Bugs: ATLAS-3984 https://issues.apache.org/jira/browse/ATLAS-3984 Repository: atlas Description --- Add UI Date Timezone and UI Date Format in Session api. Provide a way to user to read these "UI Date Timezone" and "UI Date Format" values from property file. Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a6139f Diff: https://reviews.apache.org/r/72938/diff/2/ Changes: https://reviews.apache.org/r/72938/diff/1-2/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72908/ --- (Updated Oct. 9, 2020, 2:46 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3957 https://issues.apache.org/jira/browse/ATLAS-3957 Repository: atlas Description --- By using Audit Framework, capture audit entries for "Server Start" and "Server In Active mode" (HA) These audit entries can be seen under the "Audits" tab of Admin section. Diffs (updated) - addons/models/-Area0/0010-base_model.json 1de9e57 addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json a27525e intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 Diff: https://reviews.apache.org/r/72908/diff/3/ Changes: https://reviews.apache.org/r/72908/diff/2-3/ Testing --- https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull Thanks, Mandar Ambawane
Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- (Updated Aug. 14, 2020, 4:34 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs (updated) - addons/models/-Area0/0010-base_model.json 9777b7a addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json PRE-CREATION intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 8e7c1b3 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff Diff: https://reviews.apache.org/r/72477/diff/9/ Changes: https://reviews.apache.org/r/72477/diff/8-9/ Testing --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console Thanks, Mandar Ambawane
Review Request 72903: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations. Remove Import Audit params.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72903/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3935 https://issues.apache.org/jira/browse/ATLAS-3935 Repository: atlas Description --- Remove list of guids which are stored in the params atrribute of AtlasAuditEntry in case of Import operation. Diffs - webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a6139f Diff: https://reviews.apache.org/r/72903/diff/1/ Testing --- https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/32/console Thanks, Mandar Ambawane
Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72908/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3957 https://issues.apache.org/jira/browse/ATLAS-3957 Repository: atlas Description --- By using Audit Framework, capture audit entries for "Server Start" and "Server In Active mode" (HA) These audit entries can be seen under the "Audits" tab of Admin section. Diffs - addons/models/-Area0/0010-base_model.json 1de9e57 addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json a27525e intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 Diff: https://reviews.apache.org/r/72908/diff/1/ Testing --- https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console Thanks, Mandar Ambawane
Re: Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72546/ --- (Updated June 1, 2020, 6:35 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3813 https://issues.apache.org/jira/browse/ATLAS-3813 Repository: atlas Description --- While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!" While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!" Diffs (updated) - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee Diff: https://reviews.apache.org/r/72546/diff/3/ Changes: https://reviews.apache.org/r/72546/diff/2-3/ Testing --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console Thanks, Mandar Ambawane
Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72546/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3813 https://issues.apache.org/jira/browse/ATLAS-3813 Repository: atlas Description --- While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!" While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!" Diffs - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc addons/kafka-bridge/pom.xml 7b95aa3 addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee Diff: https://reviews.apache.org/r/72546/diff/1/ Testing --- Thanks, Mandar Ambawane
Re: Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72546/ --- (Updated June 2, 2020, 1:35 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Changes done for: If atleast one metadata out of listed metadatas in the file is imported, then show message as Successful. Bugs: ATLAS-3813 https://issues.apache.org/jira/browse/ATLAS-3813 Repository: atlas Description --- While importing Hive-data from the file, if file has db names and table names which are not in the Hive. Application still shows message as "Hive Meta Data imported successfully!!!" While importing Kafka-Topic data from the file, if file has Topic names which are not present in Kafka. Application still shows message as "Kafka Data Model imported successfully!!!" Diffs (updated) - addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java eb691dc addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java 40b1fee Diff: https://reviews.apache.org/r/72546/diff/4/ Changes: https://reviews.apache.org/r/72546/diff/3-4/ Testing --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1940/console Thanks, Mandar Ambawane
Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72938/ --- (Updated Oct. 22, 2020, 5:34 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3984 https://issues.apache.org/jira/browse/ATLAS-3984 Repository: atlas Description --- Add UI Date Timezone and UI Date Format in Session api. Provide a way to user to read these "UI Date Timezone" and "UI Date Format" values from property file. Diffs (updated) - webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 3a6139f Diff: https://reviews.apache.org/r/72938/diff/4/ Changes: https://reviews.apache.org/r/72938/diff/3-4/ Testing --- PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console Thanks, Mandar Ambawane
Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72908/ --- (Updated Oct. 22, 2020, 9:01 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Some formatting changes. Bugs: ATLAS-3957 https://issues.apache.org/jira/browse/ATLAS-3957 Repository: atlas Description --- By using Audit Framework, capture audit entries for "Server Start" and "Server In Active mode" (HA) These audit entries can be seen under the "Audits" tab of Admin section. Diffs (updated) - addons/models/-Area0/0010-base_model.json 1de9e57 addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json a27525e intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 Diff: https://reviews.apache.org/r/72908/diff/5/ Changes: https://reviews.apache.org/r/72908/diff/4-5/ Testing --- https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console Thanks, Mandar Ambawane
Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72644/ --- (Updated Aug. 4, 2020, 6:14 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3872 https://issues.apache.org/jira/browse/ATLAS-3872 Repository: atlas Description --- Cause of the problem: Type-def Column is created by quick-start script. Here in this case, Type-def Column has the attribute "name". And it has property isOptional = true Type-def Column is a child of Type-def Asset which also has the attribute "name". And it has property isOptional = false Now while creating Entity of Type-def Column from UI, it does not show attribute "name" in the mandatory fields because for Type-def Column its property isOptional = true But while validating the attributes from server side we iterate through all the attributes of Entity type (Including Parent's attributes) In this case, while validating Type-def Asset's attribute "name" (which has property isOptional = false) we get an error because its value is sent as "null" from UI side. Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 repository/src/test/resources/sales-v1-full.zip 07afbf6ecae312a840b54cae5ab01335c513d180 webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 6db6b58 webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 7c820e7 Diff: https://reviews.apache.org/r/72644/diff/5/ Changes: https://reviews.apache.org/r/72644/diff/4-5/ Testing --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console Thanks, Mandar Ambawane
Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name
> On Aug. 5, 2020, 8:04 a.m., Madhan Neethiraj wrote: > > Ship It! Hi Madhan, With current changes some test cases are failing. I have resolved this issue. Currently Pre-commit build is going on for the same. Once this pre-commit build is successful I will update the review board. - Mandar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72644/#review221474 --- On Aug. 4, 2020, 6:14 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72644/ > --- > > (Updated Aug. 4, 2020, 6:14 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3872 > https://issues.apache.org/jira/browse/ATLAS-3872 > > > Repository: atlas > > > Description > --- > > Cause of the problem: > Type-def Column is created by quick-start script. > > Here in this case, Type-def Column has the attribute "name". And it has > property isOptional = true > > Type-def Column is a child of Type-def Asset which also has the attribute > "name". And it has property isOptional = false > > Now while creating Entity of Type-def Column from UI, it does not show > attribute "name" in the mandatory fields because for Type-def Column its > property isOptional = true > > But while validating the attributes from server side we iterate through all > the attributes of Entity type (Including Parent's attributes) > In this case, while validating Type-def Asset's attribute "name" (which has > property isOptional = false) we get an error because its value is sent as > "null" from UI side. > > > Diffs > - > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > e0843cb > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 > repository/src/test/resources/sales-v1-full.zip > 07afbf6ecae312a840b54cae5ab01335c513d180 > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 6db6b58 > > webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java > 7c820e7 > > > Diff: https://reviews.apache.org/r/72644/diff/5/ > > > Testing > --- > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console > > > Thanks, > > Mandar Ambawane > >
Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- (Updated Aug. 8, 2020, 2:42 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Test cases failing issue resolved. Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs (updated) - addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json PRE-CREATION intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 9120062 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 8e7c1b3 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 79f5270 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 repository/src/test/java/org/apache/atlas/TestModules.java a298934 webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java PRE-CREATION Diff: https://reviews.apache.org/r/72477/diff/6/ Changes: https://reviews.apache.org/r/72477/diff/5-6/ Testing --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console Thanks, Mandar Ambawane
Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- (Updated July 31, 2020, 12:01 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Changes to create single audit entry when multiple typedefs of different categories are created in a single request Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs (updated) - addons/models/-Area0/0010-base_model.json 9777b7a addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json PRE-CREATION intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 9120062 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 8e7c1b3 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 79f5270 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 repository/src/test/java/org/apache/atlas/TestModules.java a298934 webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java PRE-CREATION Diff: https://reviews.apache.org/r/72477/diff/5/ Changes: https://reviews.apache.org/r/72477/diff/4-5/ Testing --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console Thanks, Mandar Ambawane
Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72644/ --- (Updated July 31, 2020, 11:56 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3872 https://issues.apache.org/jira/browse/ATLAS-3872 Repository: atlas Description --- Cause of the problem: Type-def Column is created by quick-start script. Here in this case, Type-def Column has the attribute "name". And it has property isOptional = true Type-def Column is a child of Type-def Asset which also has the attribute "name". And it has property isOptional = false Now while creating Entity of Type-def Column from UI, it does not show attribute "name" in the mandatory fields because for Type-def Column its property isOptional = true But while validating the attributes from server side we iterate through all the attributes of Entity type (Including Parent's attributes) In this case, while validating Type-def Asset's attribute "name" (which has property isOptional = false) we get an error because its value is sent as "null" from UI side. Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 repository/src/test/resources/sales-v1-full.zip 07afbf6ecae312a840b54cae5ab01335c513d180 webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 6db6b58 webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 7c820e7 Diff: https://reviews.apache.org/r/72644/diff/4/ Changes: https://reviews.apache.org/r/72644/diff/3-4/ Testing --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console Thanks, Mandar Ambawane
Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72644/ --- (Updated Aug. 5, 2020, 5:37 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Test cases failing issue resolved. Bugs: ATLAS-3872 https://issues.apache.org/jira/browse/ATLAS-3872 Repository: atlas Description --- Cause of the problem: Type-def Column is created by quick-start script. Here in this case, Type-def Column has the attribute "name". And it has property isOptional = true Type-def Column is a child of Type-def Asset which also has the attribute "name". And it has property isOptional = false Now while creating Entity of Type-def Column from UI, it does not show attribute "name" in the mandatory fields because for Type-def Column its property isOptional = true But while validating the attributes from server side we iterate through all the attributes of Entity type (Including Parent's attributes) In this case, while validating Type-def Asset's attribute "name" (which has property isOptional = false) we get an error because its value is sent as "null" from UI side. Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc intg/src/main/java/org/apache/atlas/type/AtlasStructType.java b0d88fc intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df9525 repository/src/test/resources/logging-v1-full.zip 69c54eec000964a1f6f3fef96b26cca188a28ba1 repository/src/test/resources/sales-v1-full.zip 07afbf6ecae312a840b54cae5ab01335c513d180 repository/src/test/resources/salesNewTypeAttrs-next.zip e4c8505be1587fb7cc8b6354bdda701e9557da99 repository/src/test/resources/salesNewTypeAttrs.zip a4467e641fffb10189288fb2f26dc4fbc06bbd42 webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 6db6b58 webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java 0cd707f webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 7c820e7 Diff: https://reviews.apache.org/r/72644/diff/6/ Changes: https://reviews.apache.org/r/72644/diff/5-6/ Testing (updated) --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2088/console Thanks, Mandar Ambawane
Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72477/ --- (Updated Aug. 11, 2020, 5:25 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Updated below index field names for FreetextSearchProcessor to resolve Test case failures. "Referenceable.qualifiedName" -> "3k05_t" "Asset.__s_name" -> "3r45_s" "Asset.description" -> "3u9x_t" Bugs: ATLAS-3583 https://issues.apache.org/jira/browse/ATLAS-3583 Repository: atlas Description --- ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE Diffs (updated) - addons/models/-Area0/0010-base_model.json 9777b7a addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json PRE-CREATION intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 9120062 intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java a0dc816 repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 8e7c1b3 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 0dc3193 repository/src/test/java/org/apache/atlas/TestModules.java a298934 test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java PRE-CREATION Diff: https://reviews.apache.org/r/72477/diff/7/ Changes: https://reviews.apache.org/r/72477/diff/6-7/ Testing (updated) --- Basic testing is done. Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console Thanks, Mandar Ambawane
Re: Review Request 72648: ATLAS-3841 Response Headers: Code refactoring
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72648/ --- (Updated July 8, 2020, 7:07 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Addressed review comments Bugs: ATLAS-3841 https://issues.apache.org/jira/browse/ATLAS-3841 Repository: atlas Description --- Currently headers setting code is scattered at different places. In this patch, code refactoring is done to set response headers from AtlasHeaderFilter.java Currently js/ html files come under the unauthorized urls. Therefore, these files do not have headers which are applied by default by spring security. To overcome this problem, In this patch we are applying all the spring security headers to these unauthorized urls explicitly. We are doing this by mapping all the urls (authorized + unauthorized) to go through one servlet filter which is AtlasHeaderFilter. In case of authorized urls, spring by default set some of the headers. To avoid overwriting of these headers in authorized urls, those headers are skipped in the AtlasHeaderFilter. Also this patch provides flexibility to select file formats to be excluded from applying response headers. Diffs (updated) - distro/src/conf/atlas-application.properties e06e74a intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java d9b1c82 webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java df3fce6 webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java c629a7e webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java fa7218c webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 1944a9f webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java a117df6 webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java e7a5d66 webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e9 webapp/src/main/webapp/WEB-INF/web.xml 2595a15 Diff: https://reviews.apache.org/r/72648/diff/2/ Changes: https://reviews.apache.org/r/72648/diff/1-2/ Testing --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2015/console Basic testing done for authorized as well as unauthorized urls, checked whether all the response headers are setting or not. Similar testing done on the knox sso cluster. Also tested from Curl calls. Thanks, Mandar Ambawane
Re: Review Request 72648: ATLAS-3841 Response Headers: Code refactoring
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72648/ --- (Updated July 7, 2020, 9:30 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3841 https://issues.apache.org/jira/browse/ATLAS-3841 Repository: atlas Description --- Currently headers setting code is scattered at different places. In this patch, code refactoring is done to set response headers from AtlasHeaderFilter.java This patch provides flexibility to select response headers to be excluded. Also this patch provides flexibility to select file formats to be excluded from applying response headers. Diffs - distro/src/conf/atlas-application.properties e06e74a intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java d9b1c82 webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java df3fce6 webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java c629a7e webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java fa7218c webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 1944a9f webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java a117df6 webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java e7a5d66 webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java e74a9e9 webapp/src/main/webapp/WEB-INF/web.xml 2595a15 Diff: https://reviews.apache.org/r/72648/diff/1/ Testing --- PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2015/console Thanks, Mandar Ambawane
Re: [VOTE] Release Apache Atlas version 2.1.0 - rc2
+1 for Apache Atlas 2.1.0 RC2 release Validated the following: 1. Verified the source SHA512 and MD5 checksum 2. Verified the build with -Pdist,embedded-hbase-solr 3. Started Atlas server successfully 4. Verified quick_start.py, all entities and tag get created successfully 5. Created Business metadata and associated with an entity. 6. Checked Basic and advanced search Thanks, Mandar On Tue, Jul 7, 2020 at 12:37 PM vishal suvagia wrote: > Thank-you Madhan for putting Apache Atlas 2.1.0 release candidate #2.+1 > for Apache Atlas 2.1.0 RC#2.Verified clean compilation and > rat-checks.Validated the source checksums and hash. > > RegardsVishal Suvagia. > > > On Tuesday, 7 July, 2020, 11:56:50 AM IST, Sameer Shaikh < > sameer.sha...@freestoneinfotech.com> wrote: > > +1 for Apache Atlas 2.1.0 RC2 release > > Validated the following: > 1. Verified the source SHA512, MD5, and Signature. > 2. Able to build Atlas successfully. > 3. Started the Atlas server successfully. > 4. Done sanitary tests like creating and update the entities, > classification. > 5. Test Basic and advanced search. > > Thanks & Regards > Sameer Shaikh > > On Tue, Jul 7, 2020 at 10:58 AM Jayendra Parab > wrote: > > > +1 for Apache Atlas 2.1.0 RC2 release > > > > Validated the following: > > 1. Verified the source SHA512 and MD5 checksum > > 2. Verified the build with -Pdist,embedded-hbase-solr > > 3. Started Atlas server successfully > > 4. Verified quick_start.py, all entities and tag get created successfully > > 5. Created entities, applied tags from UI > > 6. Checked Basic and advanced search > > > > Regards, > > Jayendra. > > > > On Tue, Jul 7, 2020 at 9:44 AM Nikhil Bonte < > > nikhil.bo...@freestoneinfotech.com> wrote: > > > > > +1 for Apache Atlas 2.1.0 - rc2 release > > > > > > Validated the following items. > > > > > >- Verified PGP signature. > > >- Verified md5 and SHA512 digests. > > >- Packaged with embedded-hbase-solr > > >- Verified entity creation & tag associations using quick_start.py > > >- Tested basic, quick & advanced search. > > >- Tested tag dissociation > > > > > > Thanks > > > Nikhil P. Bonte > > > > > > On Mon, Jul 6, 2020 at 12:11 PM Ramesh Mani wrote: > > > > > > > +1 for Apache Atlas 2.1.0 rc2 release. > > > > > > > > - Build successfully with the source > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz > > > > - Verified PGP signature. > > > > - Verified md5 and SHA512 digests. > > > > > > > > Thanks. > > > > Ramesh > > > > > > > > On Sat, Jul 4, 2020 at 11:50 PM Madhan Neethiraj > > > > wrote: > > > > > > > > > Atlas team, > > > > > > > > > > Apache Atlas 2.1.0 rc2 is now available for vote within dev > > community. > > > > > > > > > > Links to the release artifacts are given below. Please review and > > vote. > > > > > > > > > > The vote will be open for at least 72 hours or until necessary > votes > > > are > > > > > reached. > > > > > [ ] +1 Approve > > > > > [ ] +0 No opinion > > > > > [ ] -1 Disapprove (and reason why) > > > > > > > > > > Thanks, > > > > > Madhan > > > > > > > > > > > > > > > List of all issues addressed in this release: > > > > > https://issues.apache.org/jira/issues/?jql=project=ATLAS AND > > > > > status=Resolved AND fixVersion=2.1.0 ORDER BY key DESC > > > > > > > > > > Git tag for the release: > > > > > https://github.com/apache/atlas/tree/release-2.1.0-rc2 > > > > > Sources for the release: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz > > > > > > > > > > Source release verification: > > > > > PGP Signature: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz.asc > > > > > SHA512 Hash: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz.sha512 > > > > > MD5 Hash: > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz.md5 > > > > > > > > > > Keys to verify the signature of the release artifacts are available > > at: > > > > > https://dist.apache.org/repos/dist/release/atlas/KEYS > > > > > > > > > > New features/enhancements: > > > > > - Quick Search: provides a simpler search experience with > > type-ahead > > > > > suggestions > > > > > - Business Metadata: enables augmenting entity-types with > > additional > > > > > attributes, search entities using these attributes > > > > > - Labels: ability to add/remove labels on entities, and search > > > entities > > > > > using labels > > > > > - Custom Attributes: ability to add entity instance specific > custom > > > > > attributes i.e. attributes not defined in entity-def or business > > > metadata > > > > > - Entity Purge: added REST APIs to purge deleted entities > > > > > > > > > > Enhancements: > > > > > - Search: ability to find entities by more than one
