eviews.apache.org/r/63503/#review195564
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
ps://reviews.apache.org/r/63503/#review195564
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail.
eviews.apache.org/r/63503/#review195564
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
eviews.apache.org/r/63503/#review195588
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To re
eviews.apache.org/r/63503/#review195588
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
deConnections is null?
It is not necessary because null is a valid value.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195588
-------
rated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195564
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatical
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195603
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195605
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> -
------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195608
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> --
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195590
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
eviews.apache.org/r/63503/#review195590
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To re
n sse -> who can see
:) thanks - fixed
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195590
---
On Jan.
reply, visit:
https://reviews.apache.org/r/63503/#review195590
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically
. To reply, visit:
https://reviews.apache.org/r/63503/#review195590
---
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195590
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> -
ED' ? This is an explicit rating so wouldn't ZERO_STARS be
> > appropriate? Do we even need a ZERO?
>
> Mandy Chessell wrote:
> UNRATED means not recommended - it is less than one star - zero stars
> does not display well so X is used. This is why we need i
ements at this
stage. May need to be a Jira - will look at it.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195590
-----
of permanent=false are and
> > when the caller should use each setting.
Yes - this documentation belongs in the config guide.
> On Jan. 17, 2018, 11:38 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java
&g
get a null pointer exception.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195698
---
On Jan. 12
t be coming from a
repository and so fields such as the element type may be null.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195698
-------
rated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195697
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatical
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review195700
-------
On Jan. 12, 2018, 1:13 p.m., Mandy Chessell wrote:
>
>
jdbc/ffdc/ExecutionCheckedException.java
Lines 14 (patched)
<https://reviews.apache.org/r/65123/#comment275001>
Should this extend JDBCConnectorCheckedExceptionBase?
- Mandy Chessell
On Jan. 18, 2018, 10:09 a.m., Yao Li wrote:
>
> ---
=name put into a else{}? after we check the name!=null
> > or name!=""
>
> Mandy Chessell wrote:
> This suggested change will introduce a bug since we would not set name if
> it is set to "".
>
> Yao Li wrote:
> but if the name is ""
-1095-initial-code-drop-for-OCF-with-fixes-from.patch
Thanks,
Mandy Chessell
il. To reply, visit:
https://reviews.apache.org/r/63502/#review195794
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automat
--------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
ps://reviews.apache.org/r/63502/#review195728
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail.
eviews.apache.org/r/63502/#review195728
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To re
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195728
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195709
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> --
ail. To reply, visit:
https://reviews.apache.org/r/63502/#review195417
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-
onder whether it would be better to set the status as initialising
> > here. So if any of the listeners we register receive anything then they do
> > not incorrectly see the state as error. I suggest setting the state as
> > error in a catch when there is an actual error.
&g
; I am wondering whether the cohort managers need to be ordered. If not
> > this should be a Set.
>
> Mandy Chessell wrote:
> they need to be ordered.
The reason they need to be ordered is so that the server startup is predicable
------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> -
t; >
> > is it possible to change the code as
> >
> > OMRSConnection omrsConnection = new OMRSConnection(connection);
> >
> > so we dont need a OMRSConnection seperately and still can use the
> > Connection in the parent class
>
>
> > why do we also need below
> >
> > public OMRSConnection(OMRSConnection connectionTemplate)
> > {
> > super(connectionTemplate);
> > }
> >
> > two constructors which use Connection as a parameter
>
> >
> > Do we need Character?
>
> Mandy Chessell wrote:
> I could add character but Apache Atlas does not support character.
I have added character and the Local Apache Atlas connector will throw the
"NotSupported" exception when the character type is added.
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195822
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
erface used by internal components so it is not
so defensive.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195822
--
>
> > can you add java doc for options?
>
> Mandy Chessell wrote:
> Yes - just working on the TypeDefs at the moment - quite a few problems -
> eg needed to remove ClassificationDefs and RelationshipDefs from EntityDef -
> so should be cleaner in the next patch.
visit:
https://reviews.apache.org/r/63502/#review195822
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generat
ons have been picked up here.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195822
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
gt;
> > based on the comments for OCF, clone/copy consturctor we should check
> > whether options, externalStandardMappings and validInstanceStatusList are
> > null
>
> Mandy Chessell wrote:
> This interface is not designed in the same way as OCF - the copyin
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195986
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
flat object.
We can add more constructors as and when we need them.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195998
-------
be removed in the next patch.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195997
---
On Jan. 12
mplements the
processor interface.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
-------
On J
------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This
) throws ConnectorCheckedException;
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> -
eviews.apache.org/r/63502/#review195986
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
TION
>
> omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/MemberRegistration.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTMetadataCollection.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnectorProvider.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
> PRE-CREATION
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopic.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicListener.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicProvider.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63502/diff/4/
>
>
> Testing
> ---
>
> There are samples of OMRS Connectors (without the metadata collection
> implementations).
>
>
> File Attachments
>
>
> 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
>
> https://reviews.apache.org/media/uploaded/files/2017/11/10/f6618d2e-681e-4f04-bc06-35324a341474__0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
> 0002-ATLAS-2246-code-review-version.patch
>
> https://reviews.apache.org/media/uploaded/files/2018/01/12/44ae6cd8-260d-4687-8563-a46e6b120fc6__0002-ATLAS-2246-code-review-version.patch
>
>
> Thanks,
>
> Mandy Chessell
>
>
gt;
> > based on the comments for OCF, clone/copy consturctor we should check
> > whether options, externalStandardMappings and validInstanceStatusList are
> > null
>
> Mandy Chessell wrote:
> This interface is not designed in the same way as OCF - the copyin
------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
t:
https://reviews.apache.org/r/63502/#review195903
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e
may want to use it, so I have switched it to a protected method in
ConnectorProviderBase and removed it from EnterpriseOMRConnectorProvider.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195986
-
e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195998
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an aut
--------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> -
ated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195896
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is a
t;
> >
> > I suggest we use string compares to check that the class / primitive
> > type is valid rather than loading a class - which is much more expensive
> > and the loaded class is then not used.
>
> Mandy Chessell wrote:
> It is not loading the class -
> >
> > I wonder if you could give an example of how an OMAS might call the
> > OMRS - is it this class that is involved?
>
> Mandy Chessell wrote:
> It is not appropiate to describe the broader design in the header of a
> class. The header should describe th
I am not sure what this description means. I am not sure what messages
> > the components of the cohort need to exchange with the cohort.
>
> Mandy Chessell wrote:
> Could change it to be "The local components for this cohort are
> initialized by they have not exchang
>
> > in ConnectorBase we already have Connection as a property, why do we
> > need OMRSConnection in here again a special OMRSConnection?
>
> Mandy Chessell wrote:
> The secure properties are protected in the OCF class. We need an object
> to inherit from the
> > is it possible to change the function name to
> > setRegisteredLocalConnector? I was confused with the setLocalConnector in
> > OMRSConnectorConsumer
>
> Mandy Chessell wrote:
> I am not in favour of the name change because it suggests that the local
>
ly, visit:
https://reviews.apache.org/r/63502/#review195989
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically gen
t;
> > looks like we can also need
> >
> > Classfication getNewClassfication()
> >
> > function here
>
> Mandy Chessell wrote:
> I am not sure - there is not much it can do beyond the behaviour of the
> getSkelClassification. Th
ce concern. But that is
just a style question :)
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
-------
t; >
> > is it possible to change the code as
> >
> > OMRSConnection omrsConnection = new OMRSConnection(connection);
> >
> > so we dont need a OMRSConnection seperately and still can use the
> > Connection in the parent class
>
>
woindering if -the dtate is initialised to NEW - is uninitialised
> > never used / not necessary.
>
> Mandy Chessell wrote:
> I can remove it
Actually when I remove it I get a compile error so have left it in.
- Mandy
-
------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
>
>
> omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/MemberRegistration.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTMetadataCollection.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnectorProvider.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
> PRE-CREATION
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopic.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicListener.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicProvider.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63502/diff/4/
>
>
> Testing
> ---
>
> There are samples of OMRS Connectors (without the metadata collection
> implementations).
>
>
> File Attachments
>
>
> 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
>
> https://reviews.apache.org/media/uploaded/files/2017/11/10/f6618d2e-681e-4f04-bc06-35324a341474__0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
> 0002-ATLAS-2246-code-review-version.patch
>
> https://reviews.apache.org/media/uploaded/files/2018/01/12/44ae6cd8-260d-4687-8563-a46e6b120fc6__0002-ATLAS-2246-code-review-version.patch
>
>
> Thanks,
>
> Mandy Chessell
>
>
etrieve the list based on the "severity"
Yes - fixed
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196310
----
ava
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/properties/MemberRegistration.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTMetadataCollection.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/repositoryconnector/OMRSRESTRepositoryConnectorProvider.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
> PRE-CREATION
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopic.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/OMRSTopicListener.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicConnector.java
> PRE-CREATION
>
> omrs/src/main/java/org/apache/atlas/omrs/topicconnectors/kafka/KafkaOMRSTopicProvider.java
> PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63502/diff/4/
>
>
> Testing
> ---
>
> There are samples of OMRS Connectors (without the metadata collection
> implementations).
>
>
> File Attachments
>
>
> 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
>
> https://reviews.apache.org/media/uploaded/files/2017/11/10/f6618d2e-681e-4f04-bc06-35324a341474__0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch
> 0002-ATLAS-2246-code-review-version.patch
>
> https://reviews.apache.org/media/uploaded/files/2018/01/12/44ae6cd8-260d-4687-8563-a46e6b120fc6__0002-ATLAS-2246-code-review-version.patch
>
>
> Thanks,
>
> Mandy Chessell
>
>
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196310
-------
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is a
t:
https://reviews.apache.org/r/63502/#review196316
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196316
---
On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
>
> ---
> This is an a
-code-review-version.patch
0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch
https://reviews.apache.org/media/uploaded/files/2018/01/26/55450755-e990-48bc-bb96-d9b844c0ad0a__0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch
Thanks,
Mandy Chessell
eviews.apache.org/r/63502/#review196334
---
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
eviews.apache.org/r/63502/#review196334
---
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
eviews.apache.org/r/63502/#review196334
---
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
https://reviews.apache.org/r/63502/#review196318
-------
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-m
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196318
---
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://r
erated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196350
-------
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is
//reviews.apache.org/r/63502/#review196350
---
On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To
; >
> > I suggest changing structure to entity here. Structure has echos of the
> > Atlas structure - which could be misleading.
>
> Mandy Chessell wrote:
> ok - but structs are no longer part of the model and it seems a bit
> strange to remove the word from our
ository
connector is in use.
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196353
---
On Jan. 26
t; >
> > why do we need to dissconnect here?
>
> Mandy Chessell wrote:
> The remote connector may be holding network resources that it acquired
> during its initialization. The implementation is pluggable so we need to
> offer the opportunity for it to release anything it
equested metadata is assembled.
*
*/
- Mandy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195808
-------
-bb96-d9b844c0ad0a__0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch
Thanks,
Mandy Chessell
eviews.apache.org/r/63502/#review196892
---
On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---
On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
>
> -
>
> > What is the purpose of this attribute?
>
> Mandy Chessell wrote:
> It defines how many primitives there are
This line does not exist in the current version
- Mandy
---
This is an automa
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196900
---
On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
>
>
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197399
-------
On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
>
> ---
> This is an
ed)
> > <https://reviews.apache.org/r/63502/diff/4/?file=1939611#file1939611line1393>
> >
> > is it correct the name of this method?
yes - what do you think it should be?
- Mandy
---
This is an automatically
--------
On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> -
101 - 200 of 466 matches
Mail list logo
