[jira] [Comment Edited] (ATLAS-2974) Docker build: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin...
[
https://issues.apache.org/jira/browse/ATLAS-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109042#comment-17109042
]
Nigel Jones edited comment on ATLAS-2974 at 5/16/20, 12:42 PM:
---
I do think that for anyone consuming Atlas it would be pretty nice for the
atlas project to create/maintain docker images - we really don't want to do
that and so would be happy to aid in that discussion if there's interest?
was (Author: jonesn):
I do think that for anyone consuming Atlas it would be pretty nice for the
atlas project to create/maintain docker images - we really don't want to do
that but would be happy to aid in that discussion if there's interest?
> Docker build: Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin...
> --
>
> Key: ATLAS-2974
> URL: https://issues.apache.org/jira/browse/ATLAS-2974
> Project: Atlas
> Issue Type: Bug
>Reporter: Dmitry Goryunov
>Assignee: Xinran Tinney
>Priority: Major
> Attachments: tmp
>
>
> Version: commit 945de013f5466ffcf71d16c6ec1772fdee83e2f6 (Also reproducable
> with 1.1.0-rc2)
>
> Runnign command:
> {code:java}
> docker build -t atlas_docker .
> {code}
> Breaks at some point with:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
> (enforce-versions) on project apache-atlas: Some Enforcer rules have failed.
> Look above for specific messages explaining why the rule failed. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :apache-atlas
> The command '/bin/sh -c mvn clean install -DskipTests
> -Pdist,embedded-hbase-solr -f ./atlas/pom.xml' returned a non-zero code: 1
> {code}
> The complete logs are attached.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-2974) Docker build: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin...
[
https://issues.apache.org/jira/browse/ATLAS-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109042#comment-17109042
]
Nigel Jones commented on ATLAS-2974:
I do think that for anyone consuming Atlas it would be pretty nice for the
atlas project to create/maintain docker images - we really don't want to do
that but would be happy to aid in that discussion if there's interest?
> Docker build: Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin...
> --
>
> Key: ATLAS-2974
> URL: https://issues.apache.org/jira/browse/ATLAS-2974
> Project: Atlas
> Issue Type: Bug
>Reporter: Dmitry Goryunov
>Assignee: Xinran Tinney
>Priority: Major
> Attachments: tmp
>
>
> Version: commit 945de013f5466ffcf71d16c6ec1772fdee83e2f6 (Also reproducable
> with 1.1.0-rc2)
>
> Runnign command:
> {code:java}
> docker build -t atlas_docker .
> {code}
> Breaks at some point with:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
> (enforce-versions) on project apache-atlas: Some Enforcer rules have failed.
> Look above for specific messages explaining why the rule failed. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :apache-atlas
> The command '/bin/sh -c mvn clean install -DskipTests
> -Pdist,embedded-hbase-solr -f ./atlas/pom.xml' returned a non-zero code: 1
> {code}
> The complete logs are attached.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-2974) Docker build: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin...
[
https://issues.apache.org/jira/browse/ATLAS-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109041#comment-17109041
]
Nigel Jones commented on ATLAS-2974:
Hi [~sonnyhcl] . I'm not actively working on any atlas specific work right now,
but we do build atlas images in our Egeria project. We have a helm chart (for
k8s) that sets up an environment to test/demo/develop interop between Egeria
and atlas
That image build can be found at
[https://github.com/odpi/egeria/tree/master/open-metadata-resources/open-metadata-deployment/docker/build-images/apache/atlas]
. That is building Atlas 2.0 rather than master. We used to build, but since
we've not done anything atlas related for a while the build got dropped when we
moved infrastructure. The last build is from 8 months ago at
[https://hub.docker.com/repository/docker/odpi/apache-atlas?ref=login] . I do
built it manually occasionally, and we are moving it's repo in the next few
weeks so I may revisit it then.
We use this as a base image, then also build
[https://github.com/odpi/egeria/blob/master/open-metadata-resources/open-metadata-deployment/docker/apache-atlas/Dockerfile]
for a few specific configuration steps. This is part of our build pipelines at
[https://dev.azure.com/ODPi/Egeria/_build?definitionId=13&_a=summary]
Hope that background helps.
But for your specific question on port 2181 - that's zookeeper – I haven't run
a 'normal' atlas build for well over a year, and I can't remember that aspect
of setup sorry, but we do slightly modify the normal atlas config for kafka
(which uses zookeeper) in the second image - so we don't clash with the
zookeeper/kafka configuration we use with our code. So I would look at whether
zookeeper is starting up correctly, and which port it is using.
You could also try the image above to see if it works - I've not tested
recently. I'll take a quick look to see if it works if I get a chance in the
next few days.
> Docker build: Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin...
> --
>
> Key: ATLAS-2974
> URL: https://issues.apache.org/jira/browse/ATLAS-2974
> Project: Atlas
> Issue Type: Bug
>Reporter: Dmitry Goryunov
>Assignee: Xinran Tinney
>Priority: Major
> Attachments: tmp
>
>
> Version: commit 945de013f5466ffcf71d16c6ec1772fdee83e2f6 (Also reproducable
> with 1.1.0-rc2)
>
> Runnign command:
> {code:java}
> docker build -t atlas_docker .
> {code}
> Breaks at some point with:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
> (enforce-versions) on project apache-atlas: Some Enforcer rules have failed.
> Look above for specific messages explaining why the rule failed. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :apache-atlas
> The command '/bin/sh -c mvn clean install -DskipTests
> -Pdist,embedded-hbase-solr -f ./atlas/pom.xml' returned a non-zero code: 1
> {code}
> The complete logs are attached.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-2974) Docker build: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin...
[
https://issues.apache.org/jira/browse/ATLAS-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850157#comment-16850157
]
Nigel Jones commented on ATLAS-2974:
Just as a FYI I was able to build the docker image ok off master.
The maven enforcer plugin checks various conditions for the build. If you look
further up the log from that ERROR there should be a message with more info.
Perhaps worth posting the log as a gist or similar?
Typical checks would be for maven version & java version (the atlas top level
pom checks for maven > 3.5 & java > 1.8.0-151, - but since this docker build
runs the atlas build within a container that should be pretty fixed (though
updates are applied), so I'm not sure why you see different results? Did you
change anything in the Dockerfile? Switch the compiler version for example (it
was failing with some versions of the J9 jvm)
> Docker build: Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin...
> --
>
> Key: ATLAS-2974
> URL: https://issues.apache.org/jira/browse/ATLAS-2974
> Project: Atlas
> Issue Type: Bug
>Reporter: Dmitry Goryunov
>Assignee: Xinran Tinney
>Priority: Major
> Attachments: tmp
>
>
> Version: commit 945de013f5466ffcf71d16c6ec1772fdee83e2f6 (Also reproducable
> with 1.1.0-rc2)
>
> Runnign command:
> {code:java}
> docker build -t atlas_docker .
> {code}
> Breaks at some point with:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce
> (enforce-versions) on project apache-atlas: Some Enforcer rules have failed.
> Look above for specific messages explaining why the rule failed. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn -rf :apache-atlas
> The command '/bin/sh -c mvn clean install -DskipTests
> -Pdist,embedded-hbase-solr -f ./atlas/pom.xml' returned a non-zero code: 1
> {code}
> The complete logs are attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [jira] [Updated] (ATLAS-2974) Docker build: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin...
witch to enable full debug logging.
> > [ERROR]
> > [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> > [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> > [ERROR]
> > [ERROR] After correcting the problems, you can resume the build with the
> command
> > [ERROR] mvn -rf :apache-atlas
> > The command '/bin/sh -c mvn clean install -DskipTests
> -Pdist,embedded-hbase-solr -f ./atlas/pom.xml' returned a non-zero code: 1
> > {code}
> > The complete logs are attached.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
--
Nigel Jones
[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598991#comment-16598991 ] Nigel Jones commented on ATLAS-1773: Fixup patch removed as no longer relevant given changes (omrs->egeria, latest 1773 patch) > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-08-31.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-1773: --- Attachment: (was: ATLAS-1799-nigel-fixup-20180718a,.patch) > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-08-31.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-1773: --- Attachment: ATLAS-1799-nigel-fixup-20180718a,.patch > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-07-12.patch, > ATLAS-1799-nigel-fixup-20180718a,.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547943#comment-16547943 ] Nigel Jones commented on ATLAS-1773: Updated with new patch to accomodate more Egeria changes. UT ok.. Needs review/comments from Graham, sharing to help anyone else trying to use the connector[^ATLAS-1799-nigel-fixup-20180718a,.patch] > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-07-12.patch, > ATLAS-1799-nigel-fixup-20180718a,.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-1773: --- Attachment: (was: ATLAS-1773-intellijfix_pom_spring_latestegeria.patch) > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-07-12.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-1773: --- Attachment: ATLAS-1773-intellijfix_pom_spring_latestegeria.patch > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-07-12.patch, > ATLAS-1773-intellijfix_pom_spring_latestegeria.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547790#comment-16547790 ] Nigel Jones commented on ATLAS-1773: There was a change to egeria yesterday which now requires a change in OpenMetadataRepositoryConnector.java in saveRelationshipReference in the fragment after 'create the RelationshipDef' modify the assignment of the metadataCollectionId to: metadataCollectionId = restAPI.getMetadataCollectionId().getMetadataCollectionId(); With those patches (plus a webapp/pom.xml atlas dependency change I missed) the connector can be started Also in webapp/src/main/webapp/WEB-INFO/openMetadataContext.xml I *think* we need to inclde org.odpi.openmetadata in the spring component scan My additions so far are attached (intellij patch)[^ATLAS-1773-intellijfix_pom_spring_latestegeria.patch] > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-07-12.patch, > ATLAS-1773-intellijfix_pom_spring_latestegeria.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545149#comment-16545149 ] Nigel Jones commented on ATLAS-1773: with the 20180712 patch I found I had to update the openmetadata pom.xml to change atlas dependency versions from 1.0.0-SNAPSHOT to 2.0.0-SNAPSHOT for apache-atlas & atlas-repository > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-07-12.patch > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-1696) Governance Engine OMAS
[ https://issues.apache.org/jira/browse/ATLAS-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-1696. Resolution: Won't Do Moved to odpi egeria - see https://github.com/odpi/egeria/tree/master/open-metadata-implementation/access-services/governance-engine > Governance Engine OMAS > -- > > Key: ATLAS-1696 > URL: https://issues.apache.org/jira/browse/ATLAS-1696 > Project: Atlas > Issue Type: New Feature >Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Labels: VirtualDataConnector > > Governance Engine OMAS is one of multiple consumer-centric based interfaces > that will be added to Apache Atlas, & provides the API (REST and messaging) > to support policy enforcement frameworks such as Apache Ranger. Detailed > knowledge of the Atlas data models and structure can then be hidden from > these consumers. > The functionality of gaf includes > - ability to retrieve classifications associated to assets > - restricted to "interesting" classifications > - restricted to interesting assets being managed by the requesting endpoint > - to retrieve a list of interesting roles that relate to enforcement > - to retrieve any template rule definitions/lookup tables that might be used > to construct executable rules > The scoping constructs supported in the API will include > - Only get classifications that are relevant for security enforcement (ie: > only those inheriting from a specified supertype? Verify in ATLAS-1839) > - only get information about assets (resources) in a certain part of the > datalake (Q: HOW. By zone? How to specify? by asset type? By associated > endpoint?) > - pagination > > See ATLAS-1839 for more information on the model and classifications > In the Atlas data model classifications propagate - for example > * An database column DOB has no explicit classification > * It's containing table CDB is classified as "customer personal details" > * The "SPI" classification is attached to this table with the value > "sensitive" > At enforcement time all that an engine such as ranger cares about is that the > column "DOB" is sensitive, how we got there isn't important. In the example > above the propogation occurs > * Along the assigned term relationship > * along the structural containment relationship (table->column) > Therefore gaf omas will "flatten" the structure - so in this case we'll see > table/CDB - SPI:sensitive > column/DOB - SPI:sensitive > There will be cases where multiple classifications (of the same type) can be > navigated to from an asset like DOB. This may not make logical sense, > however, Until precedence is resolved in ATLAS-1839 & related Jiras, OMAS > will pass through multiple classifications > This interface will also support message notifications of changes to managed > resources such as a new role, classification. A single kafka topic will be > used. > > A first pass swagger can be found at > https://app.swaggerhub.com/apis/planetf1/GovernanceActionOMAS/0.1 > NOTE: Updated 23 Aug with new name of GOVERNANCE ENGINE OMAS -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-1694) Sample assets to support Virtual Connector Project
[ https://issues.apache.org/jira/browse/ATLAS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-1694. Resolution: Won't Do This work has now moved to https://github.com/odpi/egeria > Sample assets to support Virtual Connector Project > -- > > Key: ATLAS-1694 > URL: https://issues.apache.org/jira/browse/ATLAS-1694 > Project: Atlas > Issue Type: New Feature >Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Labels: VirtualDataConnector > > Assets to support the virtual data connector project as samples > for example > - sample data > - sample rules/policies/classifications > - tools > - integration for GaianDB (open source virtualization engine) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
[ https://issues.apache.org/jira/browse/ATLAS-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-2593. Resolution: Won't Do This work has now moved to the odpi egeria project at [https://github.com/odpi/egeria] & in particular https://github.com/odpi/egeria/tree/master/open-metadata-implementation/access-services/governance-engine > Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework > -- > > Key: ATLAS-2593 > URL: https://issues.apache.org/jira/browse/ATLAS-2593 > Project: Atlas > Issue Type: Sub-task >Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2593.patch, ATLAS-2593b.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2464) Information View OMAS Listener
[ https://issues.apache.org/jira/browse/ATLAS-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493277#comment-16493277 ] Nigel Jones commented on ATLAS-2464: I wasn't able to apply the 2464_24_05 patch on top of current master using git am: 09:57 $ git am < ~/src/patches/omasMay29/ATLAS-2464_24_05.patch Applying: ATLAS-2464 - omas information view and small omrs changes error: patch failed: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java:32 error: omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java: patch does not apply .git/rebase-apply/patch:1116: new blank line at EOF. + .git/rebase-apply/patch:2860: new blank line at EOF. + Patch failed at 0001 ATLAS-2464 - omas information view and small omrs changes Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". However, the patch did apply using the native intellij patcher > Information View OMAS Listener > -- > > Key: ATLAS-2464 > URL: https://issues.apache.org/jira/browse/ATLAS-2464 > Project: Atlas > Issue Type: Sub-task >Reporter: Maryna Strelchuk >Assignee: Ruxandra Rosu >Priority: Major > Attachments: 0001-IV-OMAS-initial-patch-08.05.patch, > ATLAS-2464_24_05.patch, initial_patch_iv.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2665) Add OMAG API and OMAS APIs in Atlas
[
https://issues.apache.org/jira/browse/ATLAS-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493192#comment-16493192
]
Nigel Jones commented on ATLAS-2665:
Patch does not apply on top of master+2523+1773
8:36 $ git am < ~/src/patches/ATLAS-2665-Add-OMAG-API-in-Atlas-v7.patch
Applying: ATLAS-2665 Add OMAG-API in Atlas
error: patch failed: omrs/pom.xml:39
error: omrs/pom.xml: patch does not apply
Patch failed at 0001 ATLAS-2665 Add OMAG-API in Atlas
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Applying with intellij just shows the errant patch hunk is
org.springframework
spring-web
com.fasterxml.jackson.core
jackson-databind
${jackson.version}
It just looks as if the patch can't find the right place to slot it in,
probably due to other pom changes. Easy to merge manually, so could be useful
to rebase the patch in the context of 2523+1773 (as base before applying any
other patches?)
> Add OMAG API and OMAS APIs in Atlas
> ---
>
> Key: ATLAS-2665
> URL: https://issues.apache.org/jira/browse/ATLAS-2665
> Project: Atlas
> Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bogdan Sava
>Assignee: Bogdan Sava
>Priority: Major
> Attachments: 0001-ATLAS-2665-Add-OMAG-API-in-Atlas.patch,
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch,
> ATLAS-2665-Add-OMAG-API-in-Atlas-v3.patch,
> ATLAS-2665-Add-OMAG-API-in-Atlas-v4.patch,
> ATLAS-2665-Add-OMAG-API-in-Atlas-v5.patch,
> ATLAS-2665-Add-OMAG-API-in-Atlas-v6.patch,
> ATLAS-2665-Add-OMAG-API-in-Atlas-v7.patch
>
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher
> servlet.
> Change base URL for the API to "/open-metadata"
>
> Add Spring mvc Dispatcher servlet to Atlas API in order to initialize rest
> resources annotated with.
> Spring mvc has contextConfigLocation init param pointing to
> /WEB-INF/openMetadataContext.xml which scans the packages:
> {code:java}
>
> {code}
> The base URIs will be:
> - for OMAS: /open-metadata/access-services/
> - for OMAG: /open-metadata/admin/
> The omag server spring boot application will have /open-metadata as context
> path also
>
> As result:
> /api/* paths will be handled bu jersey-servlet (
> com.sun.jersey.spi.spring.container.servlet.SpringServlet )
> /openmetadata/* will be handled by openmetadata-servlet (
> org.springframework.web.servlet.DispatcherServlet )
>
> {code:java}
>
> jersey-servlet
>
> com.sun.jersey.spi.spring.container.servlet.SpringServlet
>
>
> com.sun.jersey.api.json.POJOMappingFeature
> true
>
> 1
>
>
> jersey-servlet
> /api/atlas/*
>
>
> open-metadata
>
> org.springframework.web.servlet.DispatcherServlet
>
>
> contextConfigLocation
> /WEB-INF/openMetadataContext.xml
>
> 2
>
>
> open-metadata
> /open-metadata/*
>
> {code}
>
> The review board is: [https://reviews.apache.org/r/67083/]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493188#comment-16493188 ] Nigel Jones commented on ATLAS-1773: Patch applied ok on master+2523, but has some whitespace errors that could be cleaned up for final patch 08:35 $ git am < ~/src/patches/ATLAS-1773-2018-05-25\ \(1\).patch Applying: ATLAS-1773: Atlas connector .git/rebase-apply/patch:2087: new blank line at EOF. + .git/rebase-apply/patch:2461: new blank line at EOF. + .git/rebase-apply/patch:16630: new blank line at EOF. + .git/rebase-apply/patch:17018: new blank line at EOF. + warning: 4 lines add whitespace errors. > Create the OMRS Connector for Atlas > --- > > Key: ATLAS-1773 > URL: https://issues.apache.org/jira/browse/ATLAS-1773 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 1.0.0 >Reporter: Mandy Chessell >Assignee: Graham Wallis >Priority: Major > Attachments: ATLAS-1773-2018-05-25.patch, Notes on running the OMRS > stack including the Atlas OMRS connector.txt > > > This JIRA provides the definition of the OMRS Connector API and an > implementation of this API for a local Apache Atlas metadata repository and > for the OMRS REST API. > The OMRS Connector has 3 API groups > * The types API - this is the metadata API for a metadata repository > * The entity and relationships APIs that provide the type-agnostic interfaces > that can access any type - even those added dynamically > * The fine-grained type-safe APIs that are generated from the addons models > in the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
[ https://issues.apache.org/jira/browse/ATLAS-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482708#comment-16482708 ] Nigel Jones commented on ATLAS-2593: Added current patch. Intermediate WIP. Based on older-style OMRS/omas templates, needs refactoring to accomodate recent changes in rest etc. > Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework > -- > > Key: ATLAS-2593 > URL: https://issues.apache.org/jira/browse/ATLAS-2593 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2593.patch, ATLAS-2593b.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
[ https://issues.apache.org/jira/browse/ATLAS-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2593: --- Attachment: ATLAS-2593b.patch > Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework > -- > > Key: ATLAS-2593 > URL: https://issues.apache.org/jira/browse/ATLAS-2593 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2593.patch, ATLAS-2593b.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2693) Revert ATLAS-2668 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478086#comment-16478086 ] Nigel Jones commented on ATLAS-2693: NOTE: Apply patch ONLY to 1.0 branch. (not master) > Revert ATLAS-2668 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2693.patch > > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Review Request 67161: ATLAS-2693 Revert ATLAS-2668 for 1.0 branch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67161/ --- Review request for atlas, David Radley and Madhan Neethiraj. Bugs: ATLAS-2693 https://issues.apache.org/jira/browse/ATLAS-2693 Repository: atlas Description --- revert distro/pom.xml addition of omag server (for 1.0 branch only). See https://reviews.apache.org/r/67060/ Do not apply to master branch. Diffs - distro/pom.xml b315cabe1 Diff: https://reviews.apache.org/r/67161/diff/1/ Testing --- removed omag server from pom.xml created patch applied patch to clean branch-1.0 rebuilt checked no omag server .gz started atlas (embedded hbase/solr) Looks fine Thanks, Nigel Jones
[jira] [Updated] (ATLAS-2693) Revert ATLAS-2668 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2693: --- Attachment: (was: ATLAS-2699.patch) > Revert ATLAS-2668 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2693.patch > > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2693) Revert ATLAS-2668 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2693: --- Attachment: ATLAS-2693.patch > Revert ATLAS-2668 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2693.patch > > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2693) Revert ATLAS-2668 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2693: --- Summary: Revert ATLAS-2668 for 1.0 branch (was: Revert ATLAS-2699 for 1.0 branch) > Revert ATLAS-2668 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2699.patch > > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2693) Revert ATLAS-2699 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2693: --- Attachment: ATLAS-2699.patch > Revert ATLAS-2699 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2699.patch > > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2693) Revert ATLAS-2699 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478069#comment-16478069 ] Nigel Jones commented on ATLAS-2693: added patch. testing build. > Revert ATLAS-2699 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2699.patch > > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ATLAS-2693) Revert ATLAS-2699 for 1.0 branch
[ https://issues.apache.org/jira/browse/ATLAS-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones reassigned ATLAS-2693: -- Assignee: Nigel Jones > Revert ATLAS-2699 for 1.0 branch > > > Key: ATLAS-2693 > URL: https://issues.apache.org/jira/browse/ATLAS-2693 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > > Revert ATLAS-2668 for the 1.0 branch as per review > [https://reviews.apache.org/r/67060/#comment285318] > > We could revert the entire fix, however the simplest minimum change is to > remove the reference to the assembly from the distro pom. This means that the > binary is not placed into the distro directory, though the jar with > dependencies is still built in the component directory, and the assembly xml > file will still exist in distro. > If we need to revert the entire fix please comment here and I'll update with > a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ATLAS-2693) Revert ATLAS-2699 for 1.0 branch
Nigel Jones created ATLAS-2693: -- Summary: Revert ATLAS-2699 for 1.0 branch Key: ATLAS-2693 URL: https://issues.apache.org/jira/browse/ATLAS-2693 Project: Atlas Issue Type: Improvement Reporter: Nigel Jones Revert ATLAS-2668 for the 1.0 branch as per review [https://reviews.apache.org/r/67060/#comment285318] We could revert the entire fix, however the simplest minimum change is to remove the reference to the assembly from the distro pom. This means that the binary is not placed into the distro directory, though the jar with dependencies is still built in the component directory, and the assembly xml file will still exist in distro. If we need to revert the entire fix please comment here and I'll update with a new patch :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 16, 2018, 3:55 p.m., Madhan Neethiraj wrote: > > distro/pom.xml > > Lines 123 (patched) > > <https://reviews.apache.org/r/67060/diff/6/?file=2021118#file2021118line123> > > > > This results in omag-server binaries to be includes in Atlas packaging. > > Unless the implementation is hardened with sufficient testing, I would > > strongly recommend to not package this module. This change has already been committed into master & since it was prior to the branch, into 1.0. The binary (and dependencies) are indeed included in a distinct archive along with the other archives as part of the distribution. The OMAG application however runs independently of atlas. It's a standalone process that cannot access Atlas data, as the atlas local connector has not yet been checked in (nor that of any other repository). It runs on a separate port. It cannot interact with hbase, It facilitates development of repository connectors. As such we felt the risk was very low. However if we want to remove it for 1.0 we can, we could either directly reverse the patch, or I can build a new one for 1.0 with some or all of the changes undone. I presume we would leave in master. Happy for you to raise a JIRA or just reply here & I can arrange for that. - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review203230 ------- On May 13, 2018, 9:54 a.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 13, 2018, 9:54 a.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/6/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
> On May 14, 2018, 11:25 a.m., Nigel Jones wrote: > > omag-api/pom.xml > > Line 46 (original) > > <https://reviews.apache.org/r/67083/diff/1/?file=2019867#file2019867line46> > > > > I wonder why we went with 1.5.7 of springboot? I know we want to match > > up SPRING versions (which maps to 4.x) > > > > Using the same version as atlas seems a good move, and this is 4.3.8 as > > defined in the top level pom.xml > > > > However 1.5.7 (used in this patch) of springbook maps to spring 4.3.11, > > whilst 1.5.3 maps to 4.3.8 (used in Atlas). > > > > I wonder if to eliminate issues we should match more closely - for > > example go with 1.5.3 of springboot. Alternatively bring Atlas up to the > > most current 1.5/4.x versions initially, maybe even 2.x/5.2 in the next > > release? > > Bogdan Sava wrote: > Springboot is now a dependency only on omag-server. It is not needed in > Atlas (I have removed all unused springboot dependencies). > As omag-server is independent of Atlas, I plan to upgrade to psringboot > 2.x > > omag-api, omases and omrs are using spring-web which is inherited from > atlas parent pom. Ok, thanks, will check in next patch - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67083/#review203003 --- On May 14, 2018, 8 p.m., Bogdan Sava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67083/ > --- > > (Updated May 14, 2018, 8 p.m.) > > > Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy > Chessell, and Ruxandra Rosu. > > > Repository: atlas > > > Description > --- > > Create configuration for OMAG API in Atlas > > > Diffs > - > > om-fwk-ocf/pom.xml 8b1cefd > omag-api/pom.xml 2338286 > > omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java > dd19018 > omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java > PRE-CREATION > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java > PRE-CREATION > > omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java > ebc9f2a > > omag-api/src/main/java/org/apache/atlas/omag/api/OMAGServerAdminResource.java > PRE-CREATION > omag-server/pom.xml 527c5c3 > > omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java > 88397de > omag-server/src/main/resources/application.properties PRE-CREATION > omas-assetconsumer/pom.xml 29935e7 > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/api/AssetConsumerOMASResource.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java > 80a98f5 > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java > > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java > 967be5a > omas-connectedasset/README.md 2f431df > omas-connectedasset/pom.xml 219c972 > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/api/ConnectedAssetOMASResource.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java > 8ae6c37 > omrs/pom.xml 50b9898 > > omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java > 7ae87c6 > omrs/src/main/java/org/apache/atlas/omrs/api/OMRSRepositoryResource.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java > 5948482 > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java > 3f85317 > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java > ccf0de6 > webapp/pom.xml 03b8408 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1 > webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml 23dc063 > > > Diff: https://reviews.apache.org/r/67083/diff/2/ > > > Testing > --- > > Create configuration for OMAG API in Atlas using
Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67114/#review203027 --- docs/src/site/twiki/Atlas-Authorization-Model.twiki Lines 173 (patched) <https://reviews.apache.org/r/67114/#comment285087> type: authorizor -> authorizer docs/src/site/twiki/Configure-simple-authorizor.twiki Lines 1 (patched) <https://reviews.apache.org/r/67114/#comment285088> Typo in filename - authorizer ? docs/src/site/twiki/index.twiki Lines 60 (patched) <https://reviews.apache.org/r/67114/#comment285089> If we rename the files this will need updating - Nigel Jones On May 14, 2018, 2:44 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67114/ > --- > > (Updated May 14, 2018, 2:44 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2463 > https://issues.apache.org/jira/browse/ATLAS-2463 > > > Repository: atlas > > > Description > --- > > This patch adds documentation to Atlas authorization at entity level for > simple authorizer. > > > Diffs > - > > docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION > docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 > docs/src/site/twiki/Configure-simple-authorizor.twiki PRE-CREATION > docs/src/site/twiki/index.twiki 258dfbb7f > > > Diff: https://reviews.apache.org/r/67114/diff/1/ > > > Testing > --- > > Tested the documentation after running mvn site > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67114/#review203025 --- docs/src/site/twiki/Atlas-Authorization-Model.twiki Lines 140 (patched) <https://reviews.apache.org/r/67114/#comment285084> Should there be permissions on who can add a specific classification - for example would organizations want to control who can mark info as PII? If so a control may be needed around who can apply certain classifications to any entity? docs/src/site/twiki/Atlas-Authorization-Model.twiki Lines 157 (patched) <https://reviews.apache.org/r/67114/#comment285086> WHilst this is a reasonable role to have - I wonder if we should have in the example explicitly, rather than reusing DATA_SCIENTIST? - Nigel Jones On May 14, 2018, 2:44 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67114/ > --- > > (Updated May 14, 2018, 2:44 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2463 > https://issues.apache.org/jira/browse/ATLAS-2463 > > > Repository: atlas > > > Description > --- > > This patch adds documentation to Atlas authorization at entity level for > simple authorizer. > > > Diffs > - > > docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION > docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 > docs/src/site/twiki/Configure-simple-authorizor.twiki PRE-CREATION > docs/src/site/twiki/index.twiki 258dfbb7f > > > Diff: https://reviews.apache.org/r/67114/diff/1/ > > > Testing > --- > > Tested the documentation after running mvn site > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 67114: ATLAS-2463 Documentation for Atlas Authorization model and simple authorizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67114/#review203024 --- docs/src/site/twiki/Configure-simple-authorizor.twiki Lines 163 (patched) <https://reviews.apache.org/r/67114/#comment285083> Can I define a parent type and have it apply to all subtypes? docs/src/site/twiki/Configure-simple-authorizor.twiki Lines 171 (patched) <https://reviews.apache.org/r/67114/#comment285082> I believe we need the ability to control access based on hierarchical types. So can I add the supertype here and it will apply to all sub types ? docs/src/site/twiki/Configure-simple-authorizor.twiki Lines 208 (patched) <https://reviews.apache.org/r/67114/#comment285081> What precedence applies to the rules? As an example if the data scientist creates a new type, who else will be able to access this? Will an owner always have access? It appears the creator will not be able to specify permissions as that is a job for the policy author (say in ranger). So Could a 'default' permission be set for all new types by including a wildcard * in the policies - will this get applied first or last? - Nigel Jones On May 14, 2018, 2:44 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67114/ > --- > > (Updated May 14, 2018, 2:44 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2463 > https://issues.apache.org/jira/browse/ATLAS-2463 > > > Repository: atlas > > > Description > --- > > This patch adds documentation to Atlas authorization at entity level for > simple authorizer. > > > Diffs > - > > docs/src/site/twiki/Atlas-Authorization-Model.twiki PRE-CREATION > docs/src/site/twiki/Authentication-Authorization.twiki 9832a92e8 > docs/src/site/twiki/Configure-simple-authorizor.twiki PRE-CREATION > docs/src/site/twiki/index.twiki 258dfbb7f > > > Diff: https://reviews.apache.org/r/67114/diff/1/ > > > Testing > --- > > Tested the documentation after running mvn site > > > Thanks, > > Nixon Rodrigues > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/ --- (Updated May 13, 2018, 9:54 a.m.) Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Changes --- Updated patch to match jira (only a minor whitespace change from editor) Repository: atlas Description --- Added OMAG Server to distribution with an easy to launch jar (See JIRA for more information) Diffs (updated) - distro/pom.xml 6431fd86d distro/src/main/assemblies/omag-server.xml PRE-CREATION omag-server/README.md PRE-CREATION omag-server/pom.xml 4c1c98aa3 Diff: https://reviews.apache.org/r/67060/diff/6/ Changes: https://reviews.apache.org/r/67060/diff/5-6/ Testing --- Built atlas Checked correct files in distribution archive Checked OMAG server launches with default config Thanks, Nigel Jones
[jira] [Updated] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2668: --- Attachment: (was: ATLAS-2668.patch) > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2668e.patch > > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2668: --- Attachment: ATLAS-2668e.patch > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2668e.patch > > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473412#comment-16473412 ] Nigel Jones commented on ATLAS-2668: Updated patch to match review board > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2668e.patch > > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/ --- (Updated May 11, 2018, 12:58 p.m.) Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Changes --- removed *.patch files erroneously added when recreating to remove whitespace. SHould be good now. Tested build, launch. All clean. Repository: atlas Description --- Added OMAG Server to distribution with an easy to launch jar (See JIRA for more information) Diffs (updated) - distro/pom.xml 6431fd86d distro/src/main/assemblies/omag-server.xml PRE-CREATION omag-server/README.md PRE-CREATION omag-server/pom.xml 4c1c98aa3 Diff: https://reviews.apache.org/r/67060/diff/5/ Changes: https://reviews.apache.org/r/67060/diff/4-5/ Testing --- Built atlas Checked correct files in distribution archive Checked OMAG server launches with default config Thanks, Nigel Jones
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 11, 2018, 12:30 p.m., Nigel Jones wrote: > > ATLAS-2668a.patch > > Lines 1 (patched) > > <https://reviews.apache.org/r/67060/diff/4/?file=2019935#file2019935line1> > > > > !! Patch is still in the diff. inadvertently must have added when > > trying to fix whitespace. Original patch was otherwise good. > > > > Now will update to remove file from patch > > > > Hold off from test/ship for now resolved - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202926 ------- On May 11, 2018, 12:58 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 11, 2018, 12:58 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/5/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202926 --- ATLAS-2668a.patch Lines 1 (patched) <https://reviews.apache.org/r/67060/#comment284984> !! Patch is still in the diff. inadvertently must have added when trying to fix whitespace. Original patch was otherwise good. Now will update to remove file from patch Hold off from test/ship for now - Nigel Jones On May 11, 2018, 12:26 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 11, 2018, 12:26 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > ATLAS-2668a.patch PRE-CREATION > ATLAS-2668b.patch PRE-CREATION > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/4/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/ --- (Updated May 11, 2018, 12:26 p.m.) Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Changes --- updated without patch file Repository: atlas Description --- Added OMAG Server to distribution with an easy to launch jar (See JIRA for more information) Diffs (updated) - ATLAS-2668a.patch PRE-CREATION ATLAS-2668b.patch PRE-CREATION distro/pom.xml 6431fd86d distro/src/main/assemblies/omag-server.xml PRE-CREATION omag-server/README.md PRE-CREATION omag-server/pom.xml 4c1c98aa3 Diff: https://reviews.apache.org/r/67060/diff/4/ Changes: https://reviews.apache.org/r/67060/diff/3-4/ Testing --- Built atlas Checked correct files in distribution archive Checked OMAG server launches with default config Thanks, Nigel Jones
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/README.md > > Lines 25 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019397#file2019397line25> > > > > If you lose this whitespace - then we will not get thew white space > > warning on patch apply > > Nigel Jones wrote: > Odd. hadn't noticed that. I still need to understand how it gets there. > Will do. Difficult to eliminate completely especially in README.md as intellij likes adding space indentation to match prior line even at end of file - in my case indentation was to get block quoting. Trying to fix this has led to other errors so I propose we leave this as-is for now (at least as per current patch). Perhaps there are some intellij settings we can tweak to reduce the likelihood of whitespace - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 ------- On May 11, 2018, 12:26 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 11, 2018, 12:26 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > ATLAS-2668a.patch PRE-CREATION > ATLAS-2668b.patch PRE-CREATION > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/4/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 11, 2018, 12:20 p.m., David Radley wrote: > > ATLAS-2668a.patch > > Lines 1 (patched) > > <https://reviews.apache.org/r/67060/diff/3/?file=2019930#file2019930line1> > > > > looks like a patch has got into the diff Yes. My bad. I forgot to delete the patch when making the followon diff (it's not in the local git commit, so git-wise I look ok). Realised before the comment but you were too quick :-) Removed now. It's quite easy to make little mistakes like this with the tool but practice should help ... - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202921 ------- On May 11, 2018, 12:18 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 11, 2018, 12:18 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > ATLAS-2668a.patch PRE-CREATION > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/3/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/ --- (Updated May 11, 2018, 12:18 p.m.) Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Changes --- updated again as I noticed rogue whitespace in readme Repository: atlas Description --- Added OMAG Server to distribution with an easy to launch jar (See JIRA for more information) Diffs (updated) - ATLAS-2668a.patch PRE-CREATION distro/pom.xml 6431fd86d distro/src/main/assemblies/omag-server.xml PRE-CREATION omag-server/README.md PRE-CREATION omag-server/pom.xml 4c1c98aa3 Diff: https://reviews.apache.org/r/67060/diff/3/ Changes: https://reviews.apache.org/r/67060/diff/2-3/ Testing --- Built atlas Checked correct files in distribution archive Checked OMAG server launches with default config Thanks, Nigel Jones
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/ --- (Updated May 11, 2018, 12:15 p.m.) Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Changes --- Updated as per comments Repository: atlas Description --- Added OMAG Server to distribution with an easy to launch jar (See JIRA for more information) Diffs (updated) - distro/pom.xml 6431fd86d distro/src/main/assemblies/omag-server.xml PRE-CREATION omag-server/README.md PRE-CREATION omag-server/pom.xml 4c1c98aa3 Diff: https://reviews.apache.org/r/67060/diff/2/ Changes: https://reviews.apache.org/r/67060/diff/1-2/ Testing --- Built atlas Checked correct files in distribution archive Checked OMAG server launches with default config Thanks, Nigel Jones
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/README.md > > Lines 22 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019397#file2019397line22> > > > > I suggest changing this to be launching the standalone Open Metadata > > And Governance (OMAG) Server. > > Nigel Jones wrote: > Fair comment, though as there's no regression here could do in another > jira for expediency? Can remake patch once we are happy with other issues? On reflection I propose leaving as is for the following reasons * The title of the readme already uses the full name 'Open Metadata and Governance Server' * OMAG is already referred to in the readme as the abbreviation * The launching ... is only a sub heading within the tiny document * This is a placeholder for a more complete readme we should add about how to use the omag server - so consider it a bootstrap to get started (and an improvement on not having anything) * We should ultimately likely have full start/stop scripts, which should use the wording you describe. However we need to talk a little more on a jira/lists about what that might entail, so I decided to omit for expediency - and I think what we have here offers value now - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 ------- On May 10, 2018, 5:23 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 10, 2018, 5:23 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/1/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 11, 2018, 10:39 a.m., David Radley wrote: > > distro/src/main/assemblies/omag-server.xml > > Lines 29 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019396#file2019396line29> > > > > I am wondering if you should add and > > like KafkaHook does. We should ensure that the jar and > > sh files are executable and the readme is not. > > > > I see > > -rw-r--r-- 1 david staff 1080 11 May 09:48 README.md > > -rw-r--r-- 1 david staff 8022 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT-sources.jar > > -rw-r--r-- 1 david staff 6561 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT-test-sources.jar > > -rw-r--r-- 1 david staff 17222951 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT.jar > > > > > > It doesn to look like the jar is executable. > > Also why have we got the sources and test sources jar files? > > David Radley wrote: > As it works - I guess we do not need to make it executable. Please could > you review deleting the otehr jars > > Nigel Jones wrote: > Intriguingly when I build it I do not see those jars in the distribution > which only contains the files as per the jira ie > ? > ~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT > [master ?·3?·1|…1? 3] > 10:49 $ ls > README.md omag-server-1.0.0-SNAPSHOT.jar > > I did check this beforehand.. I'll do a clean build again to double check > > Note I am referring here to what goes in the distribution (under > distro/target)... I think I'd leave what's in the component build > (omag-server/target) On the permissions, I can add those, as it makes sense, but the jar was tested and does work - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 --- On May 10, 2018, 5:23 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 10, 2018, 5:23 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > - > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/1/ > > > Testing > --- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
Re: Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
> On May 11, 2018, 10:39 a.m., David Radley wrote: > > distro/src/main/assemblies/omag-server.xml > > Lines 29 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019396#file2019396line29> > > > > I am wondering if you should add and > > like KafkaHook does. We should ensure that the jar and > > sh files are executable and the readme is not. > > > > I see > > -rw-r--r-- 1 david staff 1080 11 May 09:48 README.md > > -rw-r--r-- 1 david staff 8022 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT-sources.jar > > -rw-r--r-- 1 david staff 6561 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT-test-sources.jar > > -rw-r--r-- 1 david staff 17222951 11 May 09:55 > > omag-server-1.0.0-SNAPSHOT.jar > > > > > > It doesn to look like the jar is executable. > > Also why have we got the sources and test sources jar files? > > David Radley wrote: > As it works - I guess we do not need to make it executable. Please could > you review deleting the otehr jars Intriguingly when I build it I do not see those jars in the distribution which only contains the files as per the jira ie ? ~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT [master ?·3?·1|…1? 3] 10:49 $ ls README.md omag-server-1.0.0-SNAPSHOT.jar I did check this beforehand.. I'll do a clean build again to double check Note I am referring here to what goes in the distribution (under distro/target)... I think I'd leave what's in the component build (omag-server/target) > On May 11, 2018, 10:39 a.m., David Radley wrote: > > distro/src/main/assemblies/omag-server.xml > > Lines 38 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019396#file2019396line38> > > > > I see none of the other assemblies use ../ I am not sure why we need to? This is the link to the location of the artifacts we want to pull into the distibution . Others do use it such as atlas-storm-hook-bridge.xml, so does hbase. Ok? > On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/README.md > > Lines 22 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019397#file2019397line22> > > > > I suggest changing this to be launching the standalone Open Metadata > > And Governance (OMAG) Server. Fair comment, though as there's no regression here could do in another jira for expediency? Can remake patch once we are happy with other issues? > On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/README.md > > Lines 25 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019397#file2019397line25> > > > > If you lose this whitespace - then we will not get thew white space > > warning on patch apply Odd. hadn't noticed that. I still need to understand how it gets there. Will do. > On May 11, 2018, 10:39 a.m., David Radley wrote: > > omag-server/pom.xml > > Line 124 (original), 124 (patched) > > <https://reviews.apache.org/r/67060/diff/1/?file=2019398#file2019398line124> > > > > I do not understand this change. How does this effect the Atlas build? It's to do with making an executable jar. Previously the maven-jar-plugin was being used, but would not build a jar you could run - nor did it include dependencies. To do that you can normally use the maven-shade-plugin instead (as we see elsewhere in atlas, and as I used for the gaian ranger plugin). Here you can built a composite jar with dependencies, and can also set the main class in the manifest. However in a spring environment this fails as additional configuration data is needed. This is where the spring maven plugin comes to the rescue and builds a correct jar so you can just now run the omag server as per the readme. The JIRA has a little more explanation - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review202903 --- On May 10, 2018, 5:23 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > --- > > (Updated May 10, 2018, 5:23 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Added OMAG Server to distribution with an easy to
Review Request 67060: ATLAS-2668: Add OMAG Server to distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/ --- Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and Mandy Chessell. Repository: atlas Description --- Added OMAG Server to distribution with an easy to launch jar (See JIRA for more information) Diffs - distro/pom.xml 6431fd86d distro/src/main/assemblies/omag-server.xml PRE-CREATION omag-server/README.md PRE-CREATION omag-server/pom.xml 4c1c98aa3 Diff: https://reviews.apache.org/r/67060/diff/1/ Testing --- Built atlas Checked correct files in distribution archive Checked OMAG server launches with default config Thanks, Nigel Jones
[jira] [Commented] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470631#comment-16470631 ] Nigel Jones commented on ATLAS-2668: Now added to distribution assemblies. Assembly includes main jar file & a new README.md which just documents how to launch OMAG Server After patch installed new files are created: ie 17:18 $ ls README.md omag-server-1.0.0-SNAPSHOT.jar ✔ ~/src/atlas/distro/target/apache-atlas-1.0.0-SNAPSHOT-omag-server/omag-server-1.0.0-SNAPSHOT [master ↑·1|…1⚑ 3] This mirrors the scheme used for other packages A subsequent Jira could consider adding specific launch/terminate scripts for the omag server. Looking at the atlas scripts these make use of some common python libs which manages atlas config - in python (easier for platform independence) so suggest defer for now to consider what the requirements are. This Jira does make it easier to launch OMAG server with default settings. > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2668.patch > > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2668: --- Attachment: ATLAS-2668.patch > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2668.patch > > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470379#comment-16470379 ] Nigel Jones commented on ATLAS-2668: Originally used the following pom.xml fragment which has worked before... but for other standalone apps. It doesn't work for spring, so I will use the spring framework version, but adding here as a useful note on making a standalone app with dependencies and main class identified org.apache.maven.plugins maven-shade-plugin 3.1.1 false package shade org.apache.atlas.omag.application.OMAGApplication In this case I'll use org.springframework.boot spring-boot-maven-plugin 1.5.10.RELEASE repackage This fragment will build a standalone jar, so we can now do: ✔ ~/src/atlas/omag-server/target [master|✚ 1⚑ 3] 14:07 $ ls classes maven-shared-archive-resources original-omag-server-1.0.0-SNAPSHOT.jar generated-sources maven-status rat.txt maven-archiver omag-server-1.0.0-SNAPSHOT.jar test-classes ✔ ~/src/atlas/omag-server/target [master|✚ 1⚑ 3] 14:07 $ java -jar ./omag-server-1.0.0-SNAPSHOT.jar . _ __ _ _ /\\ / ___'_ __ _ _(_)_ __ __ _ \ \ \ \ ( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \ \\/ ___)| |_)| | | | | || (_| | ) ) ) ) ' || .__|_| |_|_| |_\__, | / / / / =|_|==|___/=/_/_/_/ :: Spring Boot :: (v1.0.0-SNAPSHOT) 2018-05-10 14:07:12.047 INFO 36215 --- [ main] o.a.a.omag.application.OMAGApplication : Starting OMAGApplication v1.0.0-SNAPSHOT on nigels-mbp.hursley.uk.ibm.com with PID 36215 (/Users/jonesn/IdeaProjects/atlas/omag-server/target/omag-server-1.0.0-SNAPSHOT.jar started by jonesn in /Users/jonesn/IdeaProjects/atlas/omag-server/target) 2018-05-10 14:07:12.050 INFO 36215 --- [ main] o.a.a.omag.application.OMAGApplication : No active profile set, falling back to default profiles: default etc ... That's build done. Next part - place somewhere in distribution... > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement >Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Major > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ATLAS-2668) Add OMAG Server to distribution
[ https://issues.apache.org/jira/browse/ATLAS-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones reassigned ATLAS-2668: -- Assignee: Nigel Jones > Add OMAG Server to distribution > --- > > Key: ATLAS-2668 > URL: https://issues.apache.org/jira/browse/ATLAS-2668 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > > The standalone Open Metadata server is built under omag-server. > However it is not incorporated into the distribution files (*.gz), and needs > careful attention to the classpath to work (ie launch from within IntelliJ) > The intent of this Jira is > * have OMAG server available 'out of the box' in a binary distribution so > that users can easily launch it without having to check classpaths or run in > an odd environment > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ATLAS-2668) Add OMAG Server to distribution
Nigel Jones created ATLAS-2668: -- Summary: Add OMAG Server to distribution Key: ATLAS-2668 URL: https://issues.apache.org/jira/browse/ATLAS-2668 Project: Atlas Issue Type: Improvement Reporter: Nigel Jones The standalone Open Metadata server is built under omag-server. However it is not incorporated into the distribution files (*.gz), and needs careful attention to the classpath to work (ie launch from within IntelliJ) The intent of this Jira is * have OMAG server available 'out of the box' in a binary distribution so that users can easily launch it without having to check classpaths or run in an odd environment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2569) maven dependency plugin back level - issues with dependency tree check
[ https://issues.apache.org/jira/browse/ATLAS-2569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2569. -- > maven dependency plugin back level - issues with dependency tree check > -- > > Key: ATLAS-2569 > URL: https://issues.apache.org/jira/browse/ATLAS-2569 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Fix For: 1.0.0 > > Attachments: ATLAS-2569.patch > > > The maven dependency plugin is at v2, yet we are using maven v3. This can > lead to incorrect results when checking the dependency tree. > The error producted from 'mvn dependency:tree' includes: > [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ atlas-client-v1 > --- > [WARNING] Using Maven 2 dependency tree to get verbose output, which may be > inconsistent with actual Maven 3 resolution > The fix is to update the plugin to a later version. Patch to be added. No > warnings are then produced, and we should be more sure of getting proper > dependency tree reporting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2571) Maven: duplicate declarations
[
https://issues.apache.org/jira/browse/ATLAS-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones closed ATLAS-2571.
--
> Maven: duplicate declarations
> -
>
> Key: ATLAS-2571
> URL: https://issues.apache.org/jira/browse/ATLAS-2571
> Project: Atlas
> Issue Type: Improvement
> Reporter: Nigel Jones
> Assignee: Nigel Jones
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: ATLAS-2571.patch, ATLAS-2571.patch
>
>
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:atlas-graphdb-titan0:jar:1.0.0-SNAPSHOT
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.apache.solr:solr-solrj:jar -> version (?) vs ${solr.version} @
> org.apache.atlas:atlas-graphdb-titan0:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/graphdb/titan0/pom.xml, line 194, column 21
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.apache.solr:solr-core:jar -> version (?) vs ${solr.version} @
> org.apache.atlas:atlas-graphdb-titan0:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/graphdb/titan0/pom.xml, line 200, column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:hive-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:hive-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/hive-bridge/pom.xml, line 484, column
> 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:falcon-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:falcon-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/falcon-bridge/pom.xml, line 370,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:sqoop-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:sqoop-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/sqoop-bridge/pom.xml, line 433,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:storm-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:storm-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/storm-bridge/pom.xml, line 536,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:hbase-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:hbase-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/hbase-bridge/pom.xml, line 508,
> column 21
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> [WARNING] The project org.apache.atlas:apache-atlas:pom:1.0.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> [https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html]
> [INFO]
>
>
>
> These are generally caused by duplicates - for example taking the first:
>
>
> org.apache.solr
> solr-solrj
>
>
> org.apache.solr
> solr-solrj
> ${solr.version}
>
>
> So we have it declared twice, once pulling in solr.version - defined in the
> top level pom, and the other blank. In the case of this plugin, the version
> is not declared in any DependencyManagement section (the common way of
> defining default plugin versions which can then be overriden in child poms)
> Cleaning this up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
[ https://issues.apache.org/jira/browse/ATLAS-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464024#comment-16464024 ] Nigel Jones commented on ATLAS-2593: Added first patch. - Based on outline provided in omas-connectedasset & omas-assetconsumer - Provides framework for two initial API calls - Not executed/tested/no unit tests so far - No implementation to retrieve actual tags/classifications from metadata store - lots of todos/further reading through/checks will post on review board once API calls work (even returning dummys) > Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework > -- > > Key: ATLAS-2593 > URL: https://issues.apache.org/jira/browse/ATLAS-2593 > Project: Atlas > Issue Type: Sub-task >Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2593.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
[ https://issues.apache.org/jira/browse/ATLAS-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones updated ATLAS-2593: --- Attachment: ATLAS-2593.patch > Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework > -- > > Key: ATLAS-2593 > URL: https://issues.apache.org/jira/browse/ATLAS-2593 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2593.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: ATLAS-2569 ATLAS-2571 - commit?
On 2018/04/27 08:27:09, David Radley wrote: > I do not see the link to the review board in the other Jira. I can have a > look - if you put the link in, APologies - missed that. now added. thanks
Re: Dependent component versions for 1.0 release
On 2018/04/26 13:04:15, Graham Wallis wrote: > So I would recommend trying 4.3.16 and 1.5.12. I concur based on prereqs from the maven repo. I do think it's worth considering moving to 5x/2x *AFTER* the 1.0 release. We would gain full java 8 spring support, compatability with java 9+ & some more reactive UI capabilities. More generally we should probably review other dependencies too though on a case by case basis
Re: Review Request 66784: ATLAS2604 Minor fixups to open metadata archive types
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66784/#review202056 --- Ship it! Ship It! - Nigel Jones On April 26, 2018, 3:37 p.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66784/ > --- > > (Updated April 26, 2018, 3:37 p.m.) > > > Review request for atlas, Madhan Neethiraj and Mandy Chessell. > > > Bugs: ATLAS2604 > https://issues.apache.org/jira/browse/ATLAS2604 > > > Repository: atlas > > > Description > --- > > ATLAS2604 Minor fixups to open metadata archive types to avoid duplicate > attributes due to relationship end names. > > > Diffs > - > > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java > 5902c4202 > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveHelper.java > 42d2d8746 > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java > faab96cac > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java 351c910e3 > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java > PRE-CREATION > > omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66784/diff/3/ > > > Testing > --- > > Ran junit that failed without the patch applied. I ran this in Intellij using > the Maven view to run the test phase on the OMRS module. This successfully > ran the test. > > > Thanks, > > David Radley > >
ATLAS-2569 ATLAS-2571 - commit?
FAO committers: Both of these now have a patch available. One +1 on the submission so far, but both are minor cleanups it would be good to get committed especially as our poms are regularly changing :-)
Re: Cassandra support for Atlas v1.0
On 2018/04/26 16:14:06, David Radley wrote: > 3) Document it in the same way as the embedded solr and hbase build. That +1 for this option #3 If in future someone has a need for production support I'm sure they will get engaged and help in testing etc :-)
[jira] [Commented] (ATLAS-2601) OMAG server Swagger
[ https://issues.apache.org/jira/browse/ATLAS-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452025#comment-16452025 ] Nigel Jones commented on ATLAS-2601: It does seem as if enunciate and swagger are broadly comparable. In terms of build there are some advantages I think to the current enunciate approach if [https://stackoverflow.com/questions/43249895/generating-swagger-json-for-spring-mvc-springfox-or-enunciate] is correct, especially as it seems less annotations are needed? Overall I agree it's better to have one mechanism unless there are very clear advantages in having two - or moving to springfox for the base atlas code. > OMAG server Swagger > > > Key: ATLAS-2601 > URL: https://issues.apache.org/jira/browse/ATLAS-2601 > Project: Atlas > Issue Type: Improvement >Reporter: Maryna Strelchuk >Assignee: Maryna Strelchuk >Priority: Major > Attachments: 0001-Atlas-2601-OMAG-server-Swagger.patch > > > This Jira addresses the addition of the Swagger for the OMAG server. > Currently Swagger was added as a dependency for > * omag-server > * omag-api > * omas-connectedasset -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Dependent component versions for 1.0 release
On 2018/04/24 13:04:59, Graham Wallis wrote: > Do we need to include anything about development versions including Maven, > Java, etc? I think it would be worth mentioning in readme/ wiki build, though now we have the maven-enforcer in place we know the min prereq java is java 8 update 151 & maven 3.5.0 which aren't far off (latest 172 - jdk 11/18.10 is next lts and could be 'interesting', and maven 3.5.3) Post-release I think there's a few other questions about specific component versions (and pom standardization where it makes sense), but I wouldn't change anything close to release
[jira] [Assigned] (ATLAS-2595) Improve version consistency in POMs (omas, omrs...)
[ https://issues.apache.org/jira/browse/ATLAS-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones reassigned ATLAS-2595: -- Assignee: Nigel Jones > Improve version consistency in POMs (omas, omrs...) > --- > > Key: ATLAS-2595 > URL: https://issues.apache.org/jira/browse/ATLAS-2595 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > > In maven projects generally, the or > tags can be used to provide some generic attributes for plugins, versions of > dependencies etc in a top level pom, and then child poms no longer need to > specify, unless they wish to override. > Some components in atlas take a different approach, by setting an explicit > version in a property in the top level pom, and then using this variable in > the child pom. > The current omrs, omas poms tend to explicitly refer to version, which can > lead to more inconsistency by mistake (they can override if essential for > function), so this Jira is being opened to consolidate -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ATLAS-2595) Improve version consistency in POMs (omas, omrs...)
Nigel Jones created ATLAS-2595: -- Summary: Improve version consistency in POMs (omas, omrs...) Key: ATLAS-2595 URL: https://issues.apache.org/jira/browse/ATLAS-2595 Project: Atlas Issue Type: Improvement Reporter: Nigel Jones In maven projects generally, the or tags can be used to provide some generic attributes for plugins, versions of dependencies etc in a top level pom, and then child poms no longer need to specify, unless they wish to override. Some components in atlas take a different approach, by setting an explicit version in a property in the top level pom, and then using this variable in the child pom. The current omrs, omas poms tend to explicitly refer to version, which can lead to more inconsistency by mistake (they can override if essential for function), so this Jira is being opened to consolidate -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-1973) gaf omas : high level swagger API + supporting doc
[ https://issues.apache.org/jira/browse/ATLAS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-1973. -- > gaf omas : high level swagger API + supporting doc > -- > > Key: ATLAS-1973 > URL: https://issues.apache.org/jira/browse/ATLAS-1973 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones >Priority: Major > > Complete/update swagger.io high level definition of api (yaml) > Add supporting notes as documentation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-1974) goveng omas : create skeleton implementation + generated swagger
[ https://issues.apache.org/jira/browse/ATLAS-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-1974. -- > goveng omas : create skeleton implementation + generated swagger > > > Key: ATLAS-1974 > URL: https://issues.apache.org/jira/browse/ATLAS-1974 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > > In this task I'll take the previously generated definition in yaml & take the > first step to making it closer to implementation by creating the appropriate > directory structure, maven projects & java classes which would generate the > interface & generate swagger output -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2234) Unit test failures in NotificationHookConsumerTest.java
[ https://issues.apache.org/jira/browse/ATLAS-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2234. -- > Unit test failures in NotificationHookConsumerTest.java > --- > > Key: ATLAS-2234 > URL: https://issues.apache.org/jira/browse/ATLAS-2234 > Project: Atlas > Issue Type: Bug > Reporter: Nigel Jones >Priority: Major > > Have been seeing this unit test failure for a while on my local MacOS builds > off master. > Running org.apache.atlas.notification.NotificationHookConsumerTest > Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.46 sec <<< > FAILURE! - in org.apache.atlas.notification.NotificationHookConsumerTest > consumersThrowsIllegalStateExceptionPauseRetryLogicIsInterrupted(org.apache.atlas.notification.NotificationHookConsumerTest) > Time elapsed: 2.52 sec <<< FAILURE! > java.lang.AssertionError: expected [false] but found [true] > at org.testng.Assert.fail(Assert.java:94) > at org.testng.Assert.failNotEquals(Assert.java:496) > at org.testng.Assert.assertFalse(Assert.java:63) > at org.testng.Assert.assertFalse(Assert.java:73) > at > org.apache.atlas.notification.NotificationHookConsumerTest.consumersThrowsIllegalStateExceptionPauseRetryLogicIsInterrupted(NotificationHookConsumerTest.java:290) > > Results : > Failed tests: > > NotificationHookConsumerTest.consumersThrowsIllegalStateExceptionPauseRetryLogicIsInterrupted:290 > expected [false] but found [true] > Tests run: 79, Failures: 1, Errors: 0, Skipped: 0 > > [INFO] Apache Atlas UI SUCCESS [ 57.722 > s] > [INFO] Apache Atlas Web Application ... FAILURE [ 51.658 > s] > [INFO] Apache Atlas Documentation . SKIPPED > this came up again whilst verifying another fix. Opening, will return after > completing the other changes. > It appears this is likely a timing issue probably due to 2500ms vs 500ms.. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-637) Build fails (jenkins, local)
[ https://issues.apache.org/jira/browse/ATLAS-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-637. - > Build fails (jenkins, local) > > > Key: ATLAS-637 > URL: https://issues.apache.org/jira/browse/ATLAS-637 > Project: Atlas > Issue Type: Bug >Affects Versions: trunk > Reporter: Nigel Jones >Priority: Blocker > > I am seeing the Atlas build fail when building the Web UI on 2 local (linux) > systems of mine. Whilst about to debug I noticed that Apache jenkins is also > reporting a build failure on the mailing list as reported at > news://news.gmane.org:119/579606293.2657.1459820983173.JavaMail.jenkins@crius > The jenkins report seems very similar to mine, so I paste that below, and > will add further info from my local install attempt: > See <https://builds.apache.org/job/apache-atlas-nightly/232/changes> > Changes: > [sumasai.shivaprasad] ATLAS-571 Modify Atlas client for necessary changes in > context of HA > [sumasai.shivaprasad] ATLAS-607 Add Support for delete entity through a > qualifiedName (sumasai > -- > [...truncated 5060 lines...] > [ERROR] npm http 200 https://registry.npmjs.org/serve-static > [ERROR] npm http 200 > https://registry.npmjs.org/merge-descriptors/-/merge-descriptors-1.0.0.tgz > [ERROR] npm http 200 https://registry.npmjs.org/finalhandler/0.3.6 > [ERROR] npm http 304 https://registry.npmjs.org/escape-html/1.0.1 > [ERROR] npm http 304 https://registry.npmjs.org/etag > [ERROR] npm http 200 https://registry.npmjs.org/content-disposition/0.5.0 > [ERROR] npm http GET https://registry.npmjs.org/ansi-regex > [ERROR] npm http GET https://registry.npmjs.org/ansi-regex > [ERROR] npm http GET https://registry.npmjs.org/get-stdin > [ERROR] npm http 304 https://registry.npmjs.org/on-finished > [ERROR] npm http GET > https://registry.npmjs.org/finalhandler/-/finalhandler-0.3.6.tgz > [ERROR] npm http GET > https://registry.npmjs.org/serve-static/-/serve-static-1.9.3.tgz > [ERROR] npm http GET > https://registry.npmjs.org/content-disposition/-/content-disposition-0.5.0.tgz > [ERROR] npm http 304 https://registry.npmjs.org/parseurl > [ERROR] npm http GET https://registry.npmjs.org/etag/-/etag-1.6.0.tgz > [ERROR] npm http 200 https://registry.npmjs.org/qs/-/qs-2.4.2.tgz > [ERROR] npm http 304 https://registry.npmjs.org/type-is > [ERROR] npm http 304 https://registry.npmjs.org/vary > [ERROR] npm http GET > https://registry.npmjs.org/on-finished/-/on-finished-2.2.1.tgz > [ERROR] npm http 200 https://registry.npmjs.org/send/0.12.3 > [ERROR] npm http 304 https://registry.npmjs.org/utils-merge/1.0.0 > [ERROR] npm http 200 > https://registry.npmjs.org/path-to-regexp/-/path-to-regexp-0.1.3.tgz > [ERROR] npm http 304 https://registry.npmjs.org/accepts > [ERROR] npm http 200 https://registry.npmjs.org/depd/-/depd-1.0.1.tgz > [ERROR] npm http GET https://registry.npmjs.org/send/-/send-0.12.3.tgz > [ERROR] npm http 200 > https://registry.npmjs.org/content-disposition/-/content-disposition-0.5.0.tgz > [ERROR] npm http 304 https://registry.npmjs.org/ansi-regex > [ERROR] npm http 304 https://registry.npmjs.org/ansi-regex > [ERROR] npm http 304 https://registry.npmjs.org/get-stdin > [ERROR] npm http 200 https://registry.npmjs.org/etag/-/etag-1.6.0.tgz > [ERROR] npm http 200 > https://registry.npmjs.org/on-finished/-/on-finished-2.2.1.tgz > [ERROR] npm http 200 https://registry.npmjs.org/send/-/send-0.12.3.tgz > [ERROR] npm http 200 > https://registry.npmjs.org/finalhandler/-/finalhandler-0.3.6.tgz > [ERROR] npm http 200 > https://registry.npmjs.org/serve-static/-/serve-static-1.9.3.tgz > [ERROR] npm http GET https://registry.npmjs.org/crc32-stream > [ERROR] npm http GET https://registry.npmjs.org/node-int64 > [ERROR] npm http 200 https://registry.npmjs.org/node-int64 > [ERROR] npm http 200 https://registry.npmjs.org/crc32-stream > [ERROR] npm http GET > https://registry.npmjs.org/node-int64/-/node-int64-0.3.3.tgz > [ERROR] npm http GET > https://registry.npmjs.org/crc32-stream/-/crc32-stream-0.3.4.tgz > [ERROR] npm http 200 > https://registry.npmjs.org/crc32-stream/-/crc32-stream-0.3.4.tgz > [ERROR] npm http 200 > https://registry.npmjs.org/node-int64/-/node-int64-0.3.3.tgz > [ERROR] npm http GET https://registry.npmjs.org/crc/3.2.1 > [ERROR] npm http GET https://registry.npmjs.org/ee-first/1.1.0 > [ERROR] npm http GET https://registry.npmjs.org/forwarded > [ERROR] npm http GET https://registry.npmjs.org/ipaddr.js/1.0.5 > [ERROR] npm http GET https://registry.npmjs.org/negotiator/0.5.3 > [ERROR] npm h
[jira] [Closed] (ATLAS-1356) ATLAS4091E in webapp Unit Tests
[
https://issues.apache.org/jira/browse/ATLAS-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones closed ATLAS-1356.
--
> ATLAS4091E in webapp Unit Tests
>
>
> Key: ATLAS-1356
> URL: https://issues.apache.org/jira/browse/ATLAS-1356
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
> Environment: Ubuntu 16.10, Open JDK 1.8.0_111
> Reporter: Nigel Jones
>Priority: Major
> Attachments: atlas20161207e.log
>
>
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 2.74 sec <<<
> FAI LURE! - in
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT
> testCreate(org.apache.atlas.web.resources.TypedefsJerseyResourceIT) Time
> elapse d: 0.262 sec <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API
> org.apache.atlas.At
> lasBaseClient$APIInfo@2474f125 failed with status 409 (Conflict) Response
> Body (
> {"errorCode":"ATLAS4091E","errorMessage":"Given type fetl already exists"})
> at
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT.testCreate(Ty
> pedefsJerseyResourceIT.java:87)
> This happens with a clean clone. Full log to be attached
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ATLAS-1356) ATLAS4091E in webapp Unit Tests
[
https://issues.apache.org/jira/browse/ATLAS-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones resolved ATLAS-1356.
Resolution: Cannot Reproduce
> ATLAS4091E in webapp Unit Tests
>
>
> Key: ATLAS-1356
> URL: https://issues.apache.org/jira/browse/ATLAS-1356
> Project: Atlas
> Issue Type: Bug
>Affects Versions: trunk
> Environment: Ubuntu 16.10, Open JDK 1.8.0_111
> Reporter: Nigel Jones
>Priority: Major
> Attachments: atlas20161207e.log
>
>
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 2.74 sec <<<
> FAI LURE! - in
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT
> testCreate(org.apache.atlas.web.resources.TypedefsJerseyResourceIT) Time
> elapse d: 0.262 sec <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API
> org.apache.atlas.At
> lasBaseClient$APIInfo@2474f125 failed with status 409 (Conflict) Response
> Body (
> {"errorCode":"ATLAS4091E","errorMessage":"Given type fetl already exists"})
> at
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT.testCreate(Ty
> pedefsJerseyResourceIT.java:87)
> This happens with a clean clone. Full log to be attached
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (ATLAS-1158) Build ATLAS using Docker
[ https://issues.apache.org/jira/browse/ATLAS-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-1158. -- > Build ATLAS using Docker > > > Key: ATLAS-1158 > URL: https://issues.apache.org/jira/browse/ATLAS-1158 > Project: Atlas > Issue Type: New Feature >Affects Versions: 0.8-incubating > Reporter: Nigel Jones >Assignee: Qiang Zhang >Priority: Major > Labels: VirtualDataConnector > Attachments: build_atlas_using_docker.sh > > > In RANGER-1137 ( https://issues.apache.org/jira/browse/RANGER-1137 ) there is > a proposal to build ranger using docker in order to avoid environment issues. > (though note it's a unix based shell script) > Some new users to Atlas have had difficulties building the code, so it could > be a cool idea to do something similar for Atlas? > Happy to give it a go though I suspect some of the unit test issues with > timeouts may still be hit. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-1849) Atlas should prereq Java 8
[ https://issues.apache.org/jira/browse/ATLAS-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-1849. Resolution: Fixed > Atlas should prereq Java 8 > -- > > Key: ATLAS-1849 > URL: https://issues.apache.org/jira/browse/ATLAS-1849 > Project: Atlas > Issue Type: New Feature > Reporter: Nigel Jones >Priority: Major > > Atlas should move to assume Java 8 in order to remain current > Java 7's last official release was in April 2015 > Java 8 was released in March 2014 and is the current release > Java 9 is currently targetted for release in July 2017 > Various new components we wish to integrate, such as Janus Graph now quite > sensibly depend on, and can take advantage of, Java 8. Whilst Atlas does > build cleanly under java 8, the new capabilities cannot be used and more > crucially any components requiring it can't be so easily integrated into the > source. With Java 7 way out of focus there are more likely to be security > exposures too. > One of the current main environments Atlas is supported in is Hadoop. Hadoop > 2.x is build with Java 7, though the very latest releases do at least support > build with Java 8. Hadoop 3 which prereqs java 8 is due for release in August > 2017 > However other environments in the enterprise need not be constrained by this > dependency > We need to decide how we will tackle this dependency change & mitigate the > impacts - for example > * we stay as-is until hadoop 3 is current/into 2018 (in my view too long) > * we go all out on java 8 in the current trunk, and branches are cut for > java 7 approach (I worry this is too much work to dual-fix) > * we create multiple build profiles and carefully allow java8 code in as > needed, but in such a way as a java7 version can still be built, albeit > missing out on selective functionality - this could still be tricky, and has > run-time dependency differences > * if profiles we decide on default (once working I'd suggest 8...) > Thoughts welcome :-) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-1849) Atlas should prereq Java 8
[ https://issues.apache.org/jira/browse/ATLAS-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-1849. -- > Atlas should prereq Java 8 > -- > > Key: ATLAS-1849 > URL: https://issues.apache.org/jira/browse/ATLAS-1849 > Project: Atlas > Issue Type: New Feature > Reporter: Nigel Jones >Priority: Major > > Atlas should move to assume Java 8 in order to remain current > Java 7's last official release was in April 2015 > Java 8 was released in March 2014 and is the current release > Java 9 is currently targetted for release in July 2017 > Various new components we wish to integrate, such as Janus Graph now quite > sensibly depend on, and can take advantage of, Java 8. Whilst Atlas does > build cleanly under java 8, the new capabilities cannot be used and more > crucially any components requiring it can't be so easily integrated into the > source. With Java 7 way out of focus there are more likely to be security > exposures too. > One of the current main environments Atlas is supported in is Hadoop. Hadoop > 2.x is build with Java 7, though the very latest releases do at least support > build with Java 8. Hadoop 3 which prereqs java 8 is due for release in August > 2017 > However other environments in the enterprise need not be constrained by this > dependency > We need to decide how we will tackle this dependency change & mitigate the > impacts - for example > * we stay as-is until hadoop 3 is current/into 2018 (in my view too long) > * we go all out on java 8 in the current trunk, and branches are cut for > java 7 approach (I worry this is too much work to dual-fix) > * we create multiple build profiles and carefully allow java8 code in as > needed, but in such a way as a java7 version can still be built, albeit > missing out on selective functionality - this could still be tricky, and has > run-time dependency differences > * if profiles we decide on default (once working I'd suggest 8...) > Thoughts welcome :-) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2084) Make berkeley DB backed Atlas available without external download
[ https://issues.apache.org/jira/browse/ATLAS-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2084. -- > Make berkeley DB backed Atlas available without external download > - > > Key: ATLAS-2084 > URL: https://issues.apache.org/jira/browse/ATLAS-2084 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS_2084_Add_BerkeleyDB_libraries.patch > > > In https://issues.apache.org/jira/browse/ATLAS-2012 I proposed providing a > dockerized version of Atlas to aid people getting up to speed with the > technology. During the review it was noted that we had used Hbase for storage > rather than the more lightweight, simpler, BerkeleyDB. My concern had been > around licensing. > Today when we build Atlas following the instructions at > http://atlas.apache.org/InstallationSteps.html the user is directed to > download the berkeleyDB jar from oracle. In ATLAS-2012 David/Graham pointed > out that this DB appears to be Apache 2.0 licensed, which means we could > incorporate it into our build legitimately. > Given the necessity to get licensing correct I've opened up this new JIRA to > focus on that change. We would need to > * Validate we are indeed correct about the license > * Add the DB file into the build > * Update the web instructions > * And optionally as per the original JIRA, consider making B-DB the default > for our docker image (most lightweight). > Please add your thoughts. I'm happy to get and do this change . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2049) Document common standards for OMAS interfaces
[ https://issues.apache.org/jira/browse/ATLAS-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2049. -- > Document common standards for OMAS interfaces > - > > Key: ATLAS-2049 > URL: https://issues.apache.org/jira/browse/ATLAS-2049 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2049.patch > > > Document (and review) common standards for OMAS interfaces, so as to ensure > some consistency between the multiple OMASs being developed. > As per phone discussion with some of team on 15 Aug will create this list in > a text-like format (perhaps twiki) and review using review board tool. > Since this will then form documentation for ATlas (internal) developers it > may make sense to create as a permanent part of the twiki docs, though if so > we may wish to consider adding other related information there such as > architectural explanations of omrs, omas etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2226) ATLAS build fails (20171025) - macos
[ https://issues.apache.org/jira/browse/ATLAS-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2226. -- > ATLAS build fails (20171025) - macos > > > Key: ATLAS-2226 > URL: https://issues.apache.org/jira/browse/ATLAS-2226 > Project: Atlas > Issue Type: Bug > Reporter: Nigel Jones >Priority: Major > > I refreshed my build environment today, and noted that atlas fails to build > (for embedded hbase/solr). I took a fresh git clone to confirm. JDK was > updated to the 152 fix level (java 8) a few days ago. Maven is at 3.5 for me > and may need to be updated. > 11:51 $ git clone git://git.apache.org/atlas.git atlas2 > Cloning into 'atlas2'... > remote: Counting objects: 55084, done. > remote: Compressing objects: 100% (18742/18742), done. > remote: Total 55084 (delta 24065), reused 49458 (delta 21532) > Receiving objects: 100% (55084/55084), 33.37 MiB | 7.29 MiB/s, done. > Resolving deltas: 100% (24065/24065), done. > ✔ ~/src > 11:51 $ cd atlas2 > ✔ ~/src/atlas2 [master|✔] > 11:51 $ mvn clean package -Pdist,external-hbase-solr 2>&1 ~ tee > ../20171025a.log > [INFO] Scanning for projects... > [WARNING] The project org.apache.atlas:apache-atlas:pom:1.0.0-SNAPSHOT uses > prerequisites which is only intended for maven-plugin projects but not for > non maven-plugin projects. For such purposes you should use the > maven-enforcer-plugin. See > https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html > [INFO] > > [INFO] Reactor Build Order: > [INFO] > [INFO] Apache Atlas Server Build Tools > [INFO] apache-atlas > [INFO] Apache Atlas Integration > [INFO] Apache Atlas Common > [INFO] Apache Atlas Typesystem > [INFO] Apache Atlas Client > [INFO] atlas-client-common > [INFO] atlas-client-v1 > [INFO] Apache Atlas Server API > [INFO] Apache Atlas Notification > [INFO] atlas-client-v2 > [INFO] Apache Atlas Graph Database Projects > [INFO] Apache Atlas Graph Database API > [INFO] Graph Database Common Code > [INFO] Apache Atlas Titan 1.0.0 GraphDB Impl > [INFO] Shaded version of Apache hbase client > [INFO] Apache Atlas Titan 0.5.4 Graph DB Impl > [INFO] Apache Atlas Graph Database Implementation Dependencies > [INFO] Shaded version of Apache hbase server > [INFO] Apache Atlas Repository > [INFO] Apache Atlas Authorization > [INFO] Apache Atlas UI > [INFO] Apache Atlas Web Application > [INFO] Apache Atlas Documentation > [INFO] Apache Atlas FileSystem Model > [INFO] Apache Atlas Plugin Classloader > [INFO] Apache Atlas Hive Bridge Shim > [INFO] Apache Atlas Hive Bridge > [INFO] Apache Atlas Falcon Bridge Shim > [INFO] Apache Atlas Falcon Bridge > [INFO] Apache Atlas Sqoop Bridge Shim > [INFO] Apache Atlas Sqoop Bridge > [INFO] Apache Atlas Storm Bridge Shim > [INFO] Apache Atlas Storm Bridge > [INFO] Apache Atlas Hbase Bridge Shim > [INFO] Apache Atlas Hbase Bridge > [INFO] Apache Atlas Distribution > [INFO] > [INFO] > > [INFO] Building Apache Atlas Server Build Tools 1.0 > [INFO] > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Apache Atlas Server Build Tools FAILURE [ 0.002 > s] > [INFO] apache-atlas ... SKIPPED > [INFO] Apache Atlas Integration ... SKIPPED > [INFO] Apache Atlas Common SKIPPED > [INFO] Apache Atlas Typesystem SKIPPED > [INFO] Apache Atlas Client SKIPPED > [INFO] atlas-client-common SKIPPED > [INFO] atlas-client-v1 SKIPPED > [INFO] Apache Atlas Server API SKIPPED > [INFO] Apache Atlas Notification .. SKIPPED > [INFO] atlas-client-v2 SKIPPED > [INFO] Apache Atlas Graph Database Projects ... SKIPPED > [INFO] Apache Atlas Graph Database API SKIPPED > [INFO] Graph Database Common Code . SKIPPED > [INFO] Apache Atlas Titan 1.0.0 GraphDB Impl .. SKIPPED > [INFO] Shaded version of Apache hbase client .. SKIPPED > [INFO] Apache Atlas Titan 0.5.4 Graph DB Impl ..
[jira] [Resolved] (ATLAS-2096) Integration Test fails: Given Type Dimension already exists
[
https://issues.apache.org/jira/browse/ATLAS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones resolved ATLAS-2096.
Resolution: Cannot Reproduce
> Integration Test fails: Given Type Dimension already exists
> ---
>
> Key: ATLAS-2096
> URL: https://issues.apache.org/jira/browse/ATLAS-2096
> Project: Atlas
> Issue Type: Bug
> Reporter: Nigel Jones
>Priority: Major
>
> When building Atlas for hbase/embedded solo I hit a UT failure during the web
> app tests:
> 127.0.0.1 - - [29/Aug/2017:17:33:22 +] "GET
> /api/atlas/entities/6cb20ab1-00c2-4e80-a2dc-dfb7a20c90e3 HTTP/1.1" 200 - "-"
> "Java/1.8.0_144"
> 127.0.0.1 - - [29/Aug/2017:17:33:22 +] "POST
> /api/atlas/entities/6cb20ab1-00c2-4e80-a2dc-dfb7a20c90e3?property=invalid_property
> HTTP/1.1" 400 - "-" "Java/1.8.0_144"
> 127.0.0.1 - - [29/Aug/2017:17:33:22 +] "GET
> /api/atlas/entities/6cb20ab1-00c2-4e80-a2dc-dfb7a20c90e3 HTTP/1.1" 200 - "-"
> "Java/1.8.0_144"
> 127.0.0.1 - - [29/Aug/2017:17:33:23 +] "POST
> /api/atlas/v2/types/typedefs/ HTTP/1.1" 409 - "-" "Java/1.8.0_144"
> Tests run: 134, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 80.922 sec
> <<< FAILURE! - in TestSuite
> runQuickStart(org.apache.atlas.examples.QuickStartV2IT) Time elapsed: 0.387
> sec <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API
> org.apache.atlas.AtlasBaseClient$APIInfo@1bd893c7 failed with status 409
> (Conflict) Response Body
> ({"errorCode":"ATLAS-409-00-001","errorMessage":"Given type Dimension already
> exists"})
> at
> org.apache.atlas.examples.QuickStartV2IT.runQuickStart(QuickStartV2IT.java:49)
> Results :
> Failed tests:
> QuickStartV2IT.runQuickStart:49 » AtlasService Metadata service API
> org.apache...
> Tests run: 134, Failures: 1, Errors: 0, Skipped: 5
> [INFO]
> [INFO] --- jetty-maven-plugin:9.2.12.v20150709:stop (stop-jetty) @
> atlas-webapp ---
> This was reported in the mailing list at
> https://lists.apache.org/thread.html/9db9d8668f22a2cdd58dd42fb582e026e07703c7ec6e9ae0e7d53f69@%3Cdev.atlas.apache.org%3E
> Subsequently noticed this is failing (intermittently) on the Jenkins build
> too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (ATLAS-2096) Integration Test fails: Given Type Dimension already exists
[
https://issues.apache.org/jira/browse/ATLAS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones closed ATLAS-2096.
--
> Integration Test fails: Given Type Dimension already exists
> ---
>
> Key: ATLAS-2096
> URL: https://issues.apache.org/jira/browse/ATLAS-2096
> Project: Atlas
> Issue Type: Bug
> Reporter: Nigel Jones
>Priority: Major
>
> When building Atlas for hbase/embedded solo I hit a UT failure during the web
> app tests:
> 127.0.0.1 - - [29/Aug/2017:17:33:22 +] "GET
> /api/atlas/entities/6cb20ab1-00c2-4e80-a2dc-dfb7a20c90e3 HTTP/1.1" 200 - "-"
> "Java/1.8.0_144"
> 127.0.0.1 - - [29/Aug/2017:17:33:22 +] "POST
> /api/atlas/entities/6cb20ab1-00c2-4e80-a2dc-dfb7a20c90e3?property=invalid_property
> HTTP/1.1" 400 - "-" "Java/1.8.0_144"
> 127.0.0.1 - - [29/Aug/2017:17:33:22 +] "GET
> /api/atlas/entities/6cb20ab1-00c2-4e80-a2dc-dfb7a20c90e3 HTTP/1.1" 200 - "-"
> "Java/1.8.0_144"
> 127.0.0.1 - - [29/Aug/2017:17:33:23 +] "POST
> /api/atlas/v2/types/typedefs/ HTTP/1.1" 409 - "-" "Java/1.8.0_144"
> Tests run: 134, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 80.922 sec
> <<< FAILURE! - in TestSuite
> runQuickStart(org.apache.atlas.examples.QuickStartV2IT) Time elapsed: 0.387
> sec <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API
> org.apache.atlas.AtlasBaseClient$APIInfo@1bd893c7 failed with status 409
> (Conflict) Response Body
> ({"errorCode":"ATLAS-409-00-001","errorMessage":"Given type Dimension already
> exists"})
> at
> org.apache.atlas.examples.QuickStartV2IT.runQuickStart(QuickStartV2IT.java:49)
> Results :
> Failed tests:
> QuickStartV2IT.runQuickStart:49 » AtlasService Metadata service API
> org.apache...
> Tests run: 134, Failures: 1, Errors: 0, Skipped: 5
> [INFO]
> [INFO] --- jetty-maven-plugin:9.2.12.v20150709:stop (stop-jetty) @
> atlas-webapp ---
> This was reported in the mailing list at
> https://lists.apache.org/thread.html/9db9d8668f22a2cdd58dd42fb582e026e07703c7ec6e9ae0e7d53f69@%3Cdev.atlas.apache.org%3E
> Subsequently noticed this is failing (intermittently) on the Jenkins build
> too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (ATLAS-2233) Java 8 no longer supports MaxPermSize -- noise in logs
[ https://issues.apache.org/jira/browse/ATLAS-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2233. -- > Java 8 no longer supports MaxPermSize -- noise in logs > -- > > Key: ATLAS-2233 > URL: https://issues.apache.org/jira/browse/ATLAS-2233 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2233.patch, Screen Shot 2017-10-26 at 12.56.54.png > > > Now that we only support Java 8 we should remove references to > -XX:MaxPermSize in the poms, scripts, documents, wiki. > The build log is littered with > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; > support was removed in 8.0 > The included image gives the results of a quick search -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-2234) Unit test failures in NotificationHookConsumerTest.java
[ https://issues.apache.org/jira/browse/ATLAS-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-2234. Resolution: Cannot Reproduce > Unit test failures in NotificationHookConsumerTest.java > --- > > Key: ATLAS-2234 > URL: https://issues.apache.org/jira/browse/ATLAS-2234 > Project: Atlas > Issue Type: Bug > Reporter: Nigel Jones >Priority: Major > > Have been seeing this unit test failure for a while on my local MacOS builds > off master. > Running org.apache.atlas.notification.NotificationHookConsumerTest > Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.46 sec <<< > FAILURE! - in org.apache.atlas.notification.NotificationHookConsumerTest > consumersThrowsIllegalStateExceptionPauseRetryLogicIsInterrupted(org.apache.atlas.notification.NotificationHookConsumerTest) > Time elapsed: 2.52 sec <<< FAILURE! > java.lang.AssertionError: expected [false] but found [true] > at org.testng.Assert.fail(Assert.java:94) > at org.testng.Assert.failNotEquals(Assert.java:496) > at org.testng.Assert.assertFalse(Assert.java:63) > at org.testng.Assert.assertFalse(Assert.java:73) > at > org.apache.atlas.notification.NotificationHookConsumerTest.consumersThrowsIllegalStateExceptionPauseRetryLogicIsInterrupted(NotificationHookConsumerTest.java:290) > > Results : > Failed tests: > > NotificationHookConsumerTest.consumersThrowsIllegalStateExceptionPauseRetryLogicIsInterrupted:290 > expected [false] but found [true] > Tests run: 79, Failures: 1, Errors: 0, Skipped: 0 > > [INFO] Apache Atlas UI SUCCESS [ 57.722 > s] > [INFO] Apache Atlas Web Application ... FAILURE [ 51.658 > s] > [INFO] Apache Atlas Documentation . SKIPPED > this came up again whilst verifying another fix. Opening, will return after > completing the other changes. > It appears this is likely a timing issue probably due to 2500ms vs 500ms.. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2570) OMRSRepositoryValidator refers to sun.* class
[ https://issues.apache.org/jira/browse/ATLAS-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2570. -- > OMRSRepositoryValidator refers to sun.* class > - > > Key: ATLAS-2570 > URL: https://issues.apache.org/jira/browse/ATLAS-2570 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Trivial > Attachments: ATLAS-2570.patch > > > I noticed that this class was referring to old deprecated sun packages. > import sun.misc.Regexp; > Fortunately this package was not used, so it is a very minor fixup, but good > not to accidentally start using any private/deprecated packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2488) AtlasClientV2 should support create of relationship
[ https://issues.apache.org/jira/browse/ATLAS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2488. -- > AtlasClientV2 should support create of relationship > --- > > Key: ATLAS-2488 > URL: https://issues.apache.org/jira/browse/ATLAS-2488 > Project: Atlas > Issue Type: New Feature > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Fix For: 1.0.0 > > Attachments: ATLAS-2488-1.patch, ATLAS-2488-2.patch > > > RelationshipREST allows one to create, delete & get relationships > However the AtlasClientV2 API only has support for get & delete, not create > This is an omission (bug arguably?) , since the client should reflect what is > available via the rest API in a more java-usable form > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ATLAS-2245) Update Maven dependency in build to 3.5.0
[ https://issues.apache.org/jira/browse/ATLAS-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones closed ATLAS-2245. -- > Update Maven dependency in build to 3.5.0 > - > > Key: ATLAS-2245 > URL: https://issues.apache.org/jira/browse/ATLAS-2245 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Trivial > Attachments: ATLAS-2245-4.patch > > > The version of maven on the jenkins build was recently updated to address > some build issues. > It seems a few people have hit maven issues so I now propose we update the > main build dependency to 3.5.0 as this is currently in the top level pom as > > 3.0.4 > > and change to 3.5.0 > The very latest is 3.5.2, but since jenkins is now at 3.5.0 and is known > working, plus homebrew (mac) at least only goes as far as 3.5.0, I suggest we > go with that as a prereq. 3.5.2 will work as well > A search through the source tree shows this is the only occurance, so this is > a one file change > NOTE: There is an impact to users, who need to upgrade to maven 3.5. I will > shortly check the wiki docs and would propose an email to the mailing list > remining developers to pull the latest maven -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
[ https://issues.apache.org/jira/browse/ATLAS-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones reassigned ATLAS-2593: -- Assignee: Nigel Jones > Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework > -- > > Key: ATLAS-2593 > URL: https://issues.apache.org/jira/browse/ATLAS-2593 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-1974) goveng omas : create skeleton implementation + generated swagger
[ https://issues.apache.org/jira/browse/ATLAS-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-1974. Resolution: Fixed closing this - was based on old code patterns > goveng omas : create skeleton implementation + generated swagger > > > Key: ATLAS-1974 > URL: https://issues.apache.org/jira/browse/ATLAS-1974 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > > In this task I'll take the previously generated definition in yaml & take the > first step to making it closer to implementation by creating the appropriate > directory structure, maven projects & java classes which would generate the > interface & generate swagger output -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ATLAS-2593) Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework
Nigel Jones created ATLAS-2593: -- Summary: Governance Engine OMAS - skeleton based on new omrs/omas patterns/ & framework Key: ATLAS-2593 URL: https://issues.apache.org/jira/browse/ATLAS-2593 Project: Atlas Issue Type: Sub-task Reporter: Nigel Jones -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-1694) Sample assets to support Virtual Connector Project
[ https://issues.apache.org/jira/browse/ATLAS-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447796#comment-16447796 ] Nigel Jones commented on ATLAS-1694: Some sample data has been posted into [https://github.com/GaianRangerPlugin/ranger-gaian-plugin/tree/master/SampleData] as part of supporting the vdc work. This includes spreadsheets, csv files for data, and scripts to create for db2 & mariadb/mysql. If anyone is interested in this I could add to atlas, but not sure if it's useful at this point. For now the update/link may help anyone looking for vdc info/data/examples > Sample assets to support Virtual Connector Project > -- > > Key: ATLAS-1694 > URL: https://issues.apache.org/jira/browse/ATLAS-1694 > Project: Atlas > Issue Type: New Feature >Reporter: Nigel Jones >Assignee: Nigel Jones >Priority: Major > Labels: VirtualDataConnector > > Assets to support the virtual data connector project as samples > for example > - sample data > - sample rules/policies/classifications > - tools > - integration for GaianDB (open source virtualization engine) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-2049) Document common standards for OMAS interfaces
[ https://issues.apache.org/jira/browse/ATLAS-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-2049. Resolution: Not A Problem > Document common standards for OMAS interfaces > - > > Key: ATLAS-2049 > URL: https://issues.apache.org/jira/browse/ATLAS-2049 > Project: Atlas > Issue Type: Sub-task > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS-2049.patch > > > Document (and review) common standards for OMAS interfaces, so as to ensure > some consistency between the multiple OMASs being developed. > As per phone discussion with some of team on 15 Aug will create this list in > a text-like format (perhaps twiki) and review using review board tool. > Since this will then form documentation for ATlas (internal) developers it > may make sense to create as a permanent part of the twiki docs, though if so > we may wish to consider adding other related information there such as > architectural explanations of omrs, omas etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ATLAS-2084) Make berkeley DB backed Atlas available without external download
[ https://issues.apache.org/jira/browse/ATLAS-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-2084. Resolution: Won't Fix Will close this for now as we have since moved forward with Janus > Make berkeley DB backed Atlas available without external download > - > > Key: ATLAS-2084 > URL: https://issues.apache.org/jira/browse/ATLAS-2084 > Project: Atlas > Issue Type: Improvement >Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Major > Attachments: ATLAS_2084_Add_BerkeleyDB_libraries.patch > > > In https://issues.apache.org/jira/browse/ATLAS-2012 I proposed providing a > dockerized version of Atlas to aid people getting up to speed with the > technology. During the review it was noted that we had used Hbase for storage > rather than the more lightweight, simpler, BerkeleyDB. My concern had been > around licensing. > Today when we build Atlas following the instructions at > http://atlas.apache.org/InstallationSteps.html the user is directed to > download the berkeleyDB jar from oracle. In ATLAS-2012 David/Graham pointed > out that this DB appears to be Apache 2.0 licensed, which means we could > incorporate it into our build legitimately. > Given the necessity to get licensing correct I've opened up this new JIRA to > focus on that change. We would need to > * Validate we are indeed correct about the license > * Add the DB file into the build > * Update the web instructions > * And optionally as per the original JIRA, consider making B-DB the default > for our docker image (most lightweight). > Please add your thoughts. I'm happy to get and do this change . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Minor maven improvements
I have two patches currently posted for review (jira+rb) ATLAS-2571 - removal of duplicate declarations, removal of obsolete prereq (superceeded by my previous maven-enforcer patch) ATLAS-2569 - moving the maven dependency plugin to current versions - it was using v2 approach to report on dependencies needed for debugging It would be super if someone could take a look :-). Both are pretty small/simple but good to get other eyes on the change, and if ok get updated before a new patch build is needed Thanks Nigel.
[jira] [Resolved] (ATLAS-2570) OMRSRepositoryValidator refers to sun.* class
[ https://issues.apache.org/jira/browse/ATLAS-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Jones resolved ATLAS-2570. Resolution: Fixed > OMRSRepositoryValidator refers to sun.* class > - > > Key: ATLAS-2570 > URL: https://issues.apache.org/jira/browse/ATLAS-2570 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Trivial > Attachments: ATLAS-2570.patch > > > I noticed that this class was referring to old deprecated sun packages. > import sun.misc.Regexp; > Fortunately this package was not used, so it is a very minor fixup, but good > not to accidentally start using any private/deprecated packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ATLAS-2570) OMRSRepositoryValidator refers to sun.* class
[ https://issues.apache.org/jira/browse/ATLAS-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439348#comment-16439348 ] Nigel Jones commented on ATLAS-2570: Patch for ATLAS-1775 also contains this change, so closing > OMRSRepositoryValidator refers to sun.* class > - > > Key: ATLAS-2570 > URL: https://issues.apache.org/jira/browse/ATLAS-2570 > Project: Atlas > Issue Type: Improvement > Reporter: Nigel Jones > Assignee: Nigel Jones >Priority: Trivial > Attachments: ATLAS-2570.patch > > > I noticed that this class was referring to old deprecated sun packages. > import sun.misc.Regexp; > Fortunately this package was not used, so it is a very minor fixup, but good > not to accidentally start using any private/deprecated packages. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 66631: ATLAS-2570 remove reference to sun.* class
> On April 16, 2018, 12:13 p.m., Mandy Chessell wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryValidator.java > > Line 26 (original) > > <https://reviews.apache.org/r/66631/diff/1/?file=2002308#file2002308line26> > > > > This fix is added to ATLAS-1775. I toticed it while adding new methods > > to the validator. thanks. I can see it in that patch. will close review/jira - Nigel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66631/#review201194 --- On April 16, 2018, 12:02 p.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66631/ > --- > > (Updated April 16, 2018, 12:02 p.m.) > > > Review request for atlas, David Radley, Graham Wallis, and Mandy Chessell. > > > Repository: atlas > > > Description > --- > > Removing deprecated import > import sun.misc.Regexp; > > > Diffs > - > > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSRepositoryValidator.java > d012cc924 > > > Diff: https://reviews.apache.org/r/66631/diff/1/ > > > Testing > --- > > Fortunately not used, so no impact or other code changes needed. > > > Thanks, > > Nigel Jones > >
[jira] [Updated] (ATLAS-2571) Maven: duplicate declarations
[
https://issues.apache.org/jira/browse/ATLAS-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones updated ATLAS-2571:
---
Attachment: ATLAS-2571.patch
> Maven: duplicate declarations
> -
>
> Key: ATLAS-2571
> URL: https://issues.apache.org/jira/browse/ATLAS-2571
> Project: Atlas
> Issue Type: Improvement
> Reporter: Nigel Jones
> Assignee: Nigel Jones
>Priority: Minor
> Attachments: ATLAS-2571.patch
>
>
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:atlas-graphdb-titan0:jar:1.0.0-SNAPSHOT
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.apache.solr:solr-solrj:jar -> version (?) vs ${solr.version} @
> org.apache.atlas:atlas-graphdb-titan0:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/graphdb/titan0/pom.xml, line 194, column 21
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.apache.solr:solr-core:jar -> version (?) vs ${solr.version} @
> org.apache.atlas:atlas-graphdb-titan0:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/graphdb/titan0/pom.xml, line 200, column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:hive-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:hive-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/hive-bridge/pom.xml, line 484, column
> 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:falcon-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:falcon-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/falcon-bridge/pom.xml, line 370,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:sqoop-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:sqoop-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/sqoop-bridge/pom.xml, line 433,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:storm-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:storm-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/storm-bridge/pom.xml, line 536,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:hbase-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:hbase-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/hbase-bridge/pom.xml, line 508,
> column 21
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> [WARNING] The project org.apache.atlas:apache-atlas:pom:1.0.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> [https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html]
> [INFO]
>
>
>
> These are generally caused by duplicates - for example taking the first:
>
>
> org.apache.solr
> solr-solrj
>
>
> org.apache.solr
> solr-solrj
> ${solr.version}
>
>
> So we have it declared twice, once pulling in solr.version - defined in the
> top level pom, and the other blank. In the case of this plugin, the version
> is not declared in any DependencyManagement section (the common way of
> defining default plugin versions which can then be overriden in child poms)
> Cleaning this up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ATLAS-2571) Maven: duplicate declarations
[
https://issues.apache.org/jira/browse/ATLAS-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nigel Jones updated ATLAS-2571:
---
Attachment: ATLAS-2571.patch
> Maven: duplicate declarations
> -
>
> Key: ATLAS-2571
> URL: https://issues.apache.org/jira/browse/ATLAS-2571
> Project: Atlas
> Issue Type: Improvement
> Reporter: Nigel Jones
> Assignee: Nigel Jones
>Priority: Minor
> Attachments: ATLAS-2571.patch, ATLAS-2571.patch
>
>
> [INFO] Scanning for projects...
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:atlas-graphdb-titan0:jar:1.0.0-SNAPSHOT
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.apache.solr:solr-solrj:jar -> version (?) vs ${solr.version} @
> org.apache.atlas:atlas-graphdb-titan0:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/graphdb/titan0/pom.xml, line 194, column 21
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.apache.solr:solr-core:jar -> version (?) vs ${solr.version} @
> org.apache.atlas:atlas-graphdb-titan0:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/graphdb/titan0/pom.xml, line 200, column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:hive-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:hive-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/hive-bridge/pom.xml, line 484, column
> 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:falcon-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:falcon-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/falcon-bridge/pom.xml, line 370,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:sqoop-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:sqoop-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/sqoop-bridge/pom.xml, line 433,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:storm-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:storm-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/storm-bridge/pom.xml, line 536,
> column 21
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.atlas:hbase-bridge:jar:1.0.0-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-resources-plugin @
> org.apache.atlas:hbase-bridge:[unknown-version],
> /Users/jonesn/IdeaProjects/atlas/addons/hbase-bridge/pom.xml, line 508,
> column 21
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> [WARNING] The project org.apache.atlas:apache-atlas:pom:1.0.0-SNAPSHOT uses
> prerequisites which is only intended for maven-plugin projects but not for
> non maven-plugin projects. For such purposes you should use the
> maven-enforcer-plugin. See
> [https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html]
> [INFO]
>
>
>
> These are generally caused by duplicates - for example taking the first:
>
>
> org.apache.solr
> solr-solrj
>
>
> org.apache.solr
> solr-solrj
> ${solr.version}
>
>
> So we have it declared twice, once pulling in solr.version - defined in the
> top level pom, and the other blank. In the case of this plugin, the version
> is not declared in any DependencyManagement section (the common way of
> defining default plugin versions which can then be overriden in child poms)
> Cleaning this up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
