[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2019-01-10 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739608#comment-16739608
 ] 

Graham Wallis commented on ATLAS-1773:
--

The RBT review for the patch associated with this JIRA is at 
[https://reviews.apache.org/r/68412/]

(The other patches have their own reviews pending where appropriate)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, 
> ATLAS-2810-2019-01-10.patch, ATLAS-2939-2018-12-21.patch, 
> ATLAS-2985-2019-01-10.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2019-01-10 Thread Graham Wallis
/68412/diff/3-4/


Testing (updated)
---

Unit Testing (approx 80 tests) and Functional Testing of major operations 
(creation of types, instances, reference copies and proxies).
Clean run through Egeria CTS test suite.


Thanks,

Graham Wallis



Re: Review Request 69392: ATLAS-2810 - Add notifications from RelationshipStore

2019-01-10 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69392/#review211828
---


Ship it!




Ship It!

- Graham Wallis


On Jan. 4, 2019, 1:21 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69392/
> ---
> 
> (Updated Jan. 4, 2019, 1:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2810
> https://issues.apache.org/jira/browse/ATLAS-2810
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Notifications for relationship mutations.
> 
> To enable notifications, set property 
> "atlas.notification.relationships.enabled" to true.
> If property is not specified, notifications will be disabled by default.
> 
> If enabled, this will add message to kafka topic when relationship is 
> added/updated/deleted.
> 
> Sample messages :
> 
> ADD
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787083448,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_ADD","eventTime":1544787072298}}
> 
> UPDATE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787404692,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_UPDATE","eventTime":1544787404679}}
> 
> DELETE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787460081,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"DELETED","label":"__hive_table.db","end1":{"guid":"6da63233-d449-42d5-8449-b6ad243f6af2","typeName":"hive_table","uniqueAttributes":{"qualifiedName":"tbl2@qn"}},"end2":{"guid":"cea76431-af27-43ae-ab11-98a2ef989bb8","typeName":"hive_db","uniqueAttributes":{"qualifiedName":"db2@qn"}}},"operationType":"RELATIONSHIP_DELETE","eventTime":1544787459708}}
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java c5357f5 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> cccf0d4 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationsh

[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2019-01-10 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739499#comment-16739499
 ] 

Graham Wallis commented on ATLAS-1773:
--

Have updated two of the above patches.

The ATLAS-2810 patch is the same as Nikhil's latest patch from the current 
review of ATLAS-2810; which will hopefully commit soon.

The updated ATLAS-2985 patch contains further updates to cater for the fact 
that hard/soft delete does not work correctly.

Suggest you continue to apply them in the order listed in the previous comment.

 

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, 
> ATLAS-2810-2019-01-10.patch, ATLAS-2939-2018-12-21.patch, 
> ATLAS-2985-2019-01-10.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2019-01-10 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-2985-2019-01-10.patch
ATLAS-2810-2019-01-10.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, 
> ATLAS-2810-2019-01-10.patch, ATLAS-2939-2018-12-21.patch, 
> ATLAS-2985-2019-01-10.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2019-01-10 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-2810-2018-12-21.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, ATLAS-2939-2018-12-21.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2019-01-10 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-2985-2018-12-21.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, ATLAS-2939-2018-12-21.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69336: ATLAS-2939: enable removal of optional attribute from an entity instance

2018-12-21 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69336/
---

(Updated Dec. 21, 2018, 3:02 p.m.)


Review request for atlas.


Changes
---

Patch rebased on latest master


Repository: atlas


Description (updated)
---

ATLAS-2939: Support clearing of optional attribute from entity. 

Please refer to JIRA for use case description.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 98734cc1de88b0089067be10424bae183874816e 


Diff: https://reviews.apache.org/r/69336/diff/2/

Changes: https://reviews.apache.org/r/69336/diff/1-2/


Testing (updated)
---

Tested with full run of Egeria Compliance Test Suite


Thanks,

Graham Wallis



[jira] [Updated] (ATLAS-2939) Enable EntityGraphMapper to unset optional attribute

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2939:
-
Attachment: ATLAS-2939-2018-12-21.patch

> Enable EntityGraphMapper to unset optional attribute
> 
>
> Key: ATLAS-2939
> URL: https://issues.apache.org/jira/browse/ATLAS-2939
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2939-2018-12-21.patch
>
>
> Use Case:
> Pre-condition: There exists an entity instance that has some combination of 
> mandatory attributes and non-mandatory attributes. All of the mandatory 
> attributes have values (otherwise the entity could not have been created) and 
> (for this example) at least some of the non-mandatory attributes have values.
> A caller (an application for example) tries to update the entity's 
> attributes, providing a new set of attribute values. The revised set of 
> values contains values for all the mandatory attributes (otherwise the update 
> will be rejected) and contains values for a subset of the non-mandatory 
> attributes, such that a non-mandatory that was set (in the pre-condition 
> above) should be not set as a result of the update. In other words, at least 
> one of the non-mandatory attributes should be cleared.
> Post-condition: I think the expected outcome is that the entity has attribute 
> values for all mandatory attributes and has attribute values for the 
> non-mandatory attributes that were were set by the update or that were 
> already set (in the pre-condition) and were not cleared by the update. It 
> should not have values for non-mandatory attributes that were either not 
> already set or that were set and were cleared by the update.
> I think what currently happens is that attribute values are not actually 
> cleared as described above - i.e. they remain in the graph and will continue 
> to be seen on a subsequent retrieval of the entity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-21 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726798#comment-16726798
 ] 

Graham Wallis commented on ATLAS-1773:
--

To run the OMRS stack (connector and event mapper), apply the following patches 
from the set attached above (order is important):
 # ATLAS-2810-2018-12-21.patch - this is a delta on top of Nikhil's forthcoming 
changes - when his ATLAS-2810 patch commits to master this delta patch will no 
longer be needed
 # ATLAS-2939-2018-12-21.patch - this patch is currently under review
 # ATLAS-2985-2018-12-21.patch - provides support for hard and soft deletes but 
is not a complete solution (does not address duplication of delete 
notifications) so should only be used for development/demo purposes
 # ATLAS-1773-2018-12-21.patch - this is the connector and event mapper

Then start Atlas and configure and activate the OMRS stack.

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, 
> ATLAS-2810-2018-12-21.patch, ATLAS-2939-2018-12-21.patch, 
> ATLAS-2985-2018-12-21.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-2985-2018-12-21.patch
ATLAS-2939-2018-12-21.patch
ATLAS-2810-2018-12-21.patch
ATLAS-1773-2018-12-21.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-21.patch, 
> ATLAS-2810-2018-12-21.patch, ATLAS-2939-2018-12-21.patch, 
> ATLAS-2985-2018-12-21.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-2985-2018-12-05.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-12-05.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-2939-2018-11-14.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-3003) Hard Delete in Apache Atlas

2018-12-21 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726758#comment-16726758
 ] 

Graham Wallis commented on ATLAS-3003:
--

ATLAS-2774 alone does not support soft delete followed by hard delete.

If you combine with with ATLAS-2985 it will perform the hard delete.

But even with the above combination there is a latent problem that duplicate 
notifications will be sent - a new notification event type is needed for the 
hard delete.

> Hard Delete in Apache Atlas
> ---
>
> Key: ATLAS-3003
> URL: https://issues.apache.org/jira/browse/ATLAS-3003
> Project: Atlas
>  Issue Type: Bug
>Reporter: Abhishek Sharma
>Priority: Blocker
>
> Hello,
> I have tried to delete an entity in atlas but it turns out that Atlas only 
> soft deletes an entity and never hard deletes them. Is there a way in which I 
> can hard delete an entity so that it is entirely removed from Atlas.
> Thanks in advance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2939) Enable EntityGraphMapper to unset optional attribute

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2939:
-
Description: 
Use Case:

Pre-condition: There exists an entity instance that has some combination of 
mandatory attributes and non-mandatory attributes. All of the mandatory 
attributes have values (otherwise the entity could not have been created) and 
(for this example) at least some of the non-mandatory attributes have values.

A caller (an application for example) tries to update the entity's attributes, 
providing a new set of attribute values. The revised set of values contains 
values for all the mandatory attributes (otherwise the update will be rejected) 
and contains values for a subset of the non-mandatory attributes, such that a 
non-mandatory that was set (in the pre-condition above) should be not set as a 
result of the update. In other words, at least one of the non-mandatory 
attributes should be cleared.

Post-condition: I think the expected outcome is that the entity has attribute 
values for all mandatory attributes and has attribute values for the 
non-mandatory attributes that were were set by the update or that were already 
set (in the pre-condition) and were not cleared by the update. It should not 
have values for non-mandatory attributes that were either not already set or 
that were set and were cleared by the update.

I think what currently happens is that attribute values are not actually 
cleared as described above - i.e. they remain in the graph and will continue to 
be seen on a subsequent retrieval of the entity.

> Enable EntityGraphMapper to unset optional attribute
> 
>
> Key: ATLAS-2939
> URL: https://issues.apache.org/jira/browse/ATLAS-2939
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
>
> Use Case:
> Pre-condition: There exists an entity instance that has some combination of 
> mandatory attributes and non-mandatory attributes. All of the mandatory 
> attributes have values (otherwise the entity could not have been created) and 
> (for this example) at least some of the non-mandatory attributes have values.
> A caller (an application for example) tries to update the entity's 
> attributes, providing a new set of attribute values. The revised set of 
> values contains values for all the mandatory attributes (otherwise the update 
> will be rejected) and contains values for a subset of the non-mandatory 
> attributes, such that a non-mandatory that was set (in the pre-condition 
> above) should be not set as a result of the update. In other words, at least 
> one of the non-mandatory attributes should be cleared.
> Post-condition: I think the expected outcome is that the entity has attribute 
> values for all mandatory attributes and has attribute values for the 
> non-mandatory attributes that were were set by the update or that were 
> already set (in the pre-condition) and were not cleared by the update. It 
> should not have values for non-mandatory attributes that were either not 
> already set or that were set and were cleared by the update.
> I think what currently happens is that attribute values are not actually 
> cleared as described above - i.e. they remain in the graph and will continue 
> to be seen on a subsequent retrieval of the entity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2939) Enable EntityGraphMapper to unset optional attribute

2018-12-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2939:
-
Attachment: (was: ATLAS-2939-2018-11-14.patch)

> Enable EntityGraphMapper to unset optional attribute
> 
>
> Key: ATLAS-2939
> URL: https://issues.apache.org/jira/browse/ATLAS-2939
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
>
> Use Case:
> Pre-condition: There exists an entity instance that has some combination of 
> mandatory attributes and non-mandatory attributes. All of the mandatory 
> attributes have values (otherwise the entity could not have been created) and 
> (for this example) at least some of the non-mandatory attributes have values.
> A caller (an application for example) tries to update the entity's 
> attributes, providing a new set of attribute values. The revised set of 
> values contains values for all the mandatory attributes (otherwise the update 
> will be rejected) and contains values for a subset of the non-mandatory 
> attributes, such that a non-mandatory that was set (in the pre-condition 
> above) should be not set as a result of the update. In other words, at least 
> one of the non-mandatory attributes should be cleared.
> Post-condition: I think the expected outcome is that the entity has attribute 
> values for all mandatory attributes and has attribute values for the 
> non-mandatory attributes that were were set by the update or that were 
> already set (in the pre-condition) and were not cleared by the update. It 
> should not have values for non-mandatory attributes that were either not 
> already set or that were set and were cleared by the update.
> I think what currently happens is that attribute values are not actually 
> cleared as described above - i.e. they remain in the graph and will continue 
> to be seen on a subsequent retrieval of the entity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69392: ATLAS-2810 - Add notifications from RelationshipStore

2018-12-18 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69392/#review211403
---



Hi Nikhil

I downloaded this and tested it and it works pretty well.

I'm not sure whether you intended it or not, but when a relationship is added 
it fires two notifications. I think this is because both the relationship 
store's createRelationship() and create() methods invoke sendNotifications(). 
You maybe only wanted one of them. I also tested the update and delete 
operations and they each generate one notification.


You may want to add a full implementation of toString() so that it provides 
more information in a log. For example, I temporarily modified it like this:

@Override
public StringBuilder toString(StringBuilder sb) {
if (sb == null) {
sb = new StringBuilder();
}

sb.append("AtlasRelationshipHeader{");
sb.append("guid='").append(guid).append('\'');
sb.append(", status=").append(status);
sb.append(", label=").append(label);
sb.append(", propagateTags=").append(propagateTags);
sb.append(", end1=").append(end1);
sb.append(", end2=").append(end2);
super.toString(sb);
sb.append('}');

return sb;
}

- Graham Wallis


On Dec. 17, 2018, 5:13 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69392/
> ---
> 
> (Updated Dec. 17, 2018, 5:13 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2810
> https://issues.apache.org/jira/browse/ATLAS-2810
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Notifications for relationship mutations.
> This will add message to kafka topic when relationship is 
> added/updated/deleted.
> 
> Sample messages :
> 
> ADD
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787083448,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"c8792b2f-b550-47c2-baf9-1ddc0f25bac1","typeName":"hive_table"},"end2":{"guid":"414b7277-06f5-4a50-869c-3af62655e799","typeName":"hive_db"}},"operationType":"RELATIONSHIP_ADD","eventTime":1544787072298}}
> 
> UPDATE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787404692,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"ACTIVE","label":"__hive_table.db","end1":{"guid":"c8792b2f-b550-47c2-baf9-1ddc0f25bac1","typeName":"hive_table"},"end2":{"guid":"414b7277-06f5-4a50-869c-3af62655e799","typeName":"hive_db"}},"operationType":"RELATIONSHIP_UPDATE","eventTime":1544787404679}}
> 
> DELETE
> {"version":{"version":"1.0.0","versionParts":[1]},"msgCompressionKind":"NONE","msgSplitIdx":1,"msgSplitCount":1,"msgSourceIP":"127.0.1.1","msgCreatedBy":"","msgCreationTime":1544787460081,"message":{"type":"ENTITY_NOTIFICATION_V2","relationship":{"typeName":"hive_table_db","guid":"e4949325-562a-43bf-a980-c0c562c8759e","status":"DELETED","label":"__hive_table.db","end1":{"guid":"c8792b2f-b550-47c2-baf9-1ddc0f25bac1","typeName":"hive_table"},"

ATLAS-1773 posted for review

2018-12-05 Thread Graham Wallis
Hi,

I've posted the ATLAS-1773 patch for review (RBT #69511) and am hoping to 
get it committed by Monday of next week, dependent on review feedback
Please take a look and provide any review feedback as soon as possible.

Best regards,
  Graham

Graham Wallis
IBM Analytics
Internet: graham_wal...@uk.ibm.com 
IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
Tel: +44 7741 379735

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU


[jira] [Comment Edited] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-05 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707044#comment-16707044
 ] 

Graham Wallis edited comment on ATLAS-1773 at 12/5/18 3:46 PM:
---

Latest ATLAS-1773 patch (5th Dec) relies on ATLAS-2939 for correct property 
handling and ATLAS-2985 for full delete function.


was (Author: grahamwallis):
Latest ATLAS-1773 patch (4th Dec) relies on ATLAS-2939 for correct property 
handling and ATLAS-2985 for full delete function.

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-05.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-12-05.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 69511: Atlas OMRS Connector and Event Mapper

2018-12-05 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69511/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-1773: Atlas OMRS conenctor and event mapper


Diffs
-

  open-metadata/README.md PRE-CREATION 
  open-metadata/pom.xml PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java
 PRE-CREATION 
  pom.xml 49fe7de14bf52f9a1de7153eab0484f42e25e37a 
  webapp/pom.xml e1988c34863053489c3331a994b328adc92347b0 
  webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 
23dc0637a8b521ab89a16ec8b03895cdaf8bc7d8 


Diff: https://reviews.apache.org/r/69511/diff/1/


Testing
---

Full testing with Egeria Compliance Test Suite - passes provided ATLAS-2939 and 
ATLAS-2985 patches are present.


Thanks,

Graham Wallis



[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-05 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-12-05.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-05.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-12-05.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-05 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-12-04.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-05.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-12-05.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69494: ATLAS-2985 fixes for delete handlers and relationship store

2018-12-05 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69494/
---

(Updated Dec. 5, 2018, 3:43 p.m.)


Review request for atlas.


Changes
---

Addressed issues from first review - did not change event generation 
considerations as Atlas already produces multiple notifications per delete, and 
a notification is needed on a soft delete and on a hard delete. I would suggest 
that event duplication is addressed in a separate JIRA that would suggest that 
a dedicated event type is introduced for a HARD delete - as this is a different 
operation to a SOFT delete.


Repository: atlas


Description
---

ATLAS-2985: critical fixes for delete handlers and relationship dtore


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 c57e30ab5cdb34aee1cb13c463b1b0af827d2a2e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 edf1eed4c3efdd41f77155e51c8f2908b3dbbab2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 86cc98cda61d85954fd227501d691e3a3b542611 


Diff: https://reviews.apache.org/r/69494/diff/2/

Changes: https://reviews.apache.org/r/69494/diff/1-2/


Testing
---

Tested with full run of Egeria CTS suite.


Thanks,

Graham Wallis



[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-05 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-2985-2018-12-05.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-04.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-12-05.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-05 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-2985-2018-11-30.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-04.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-12-05.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-04 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707044#comment-16707044
 ] 

Graham Wallis edited comment on ATLAS-1773 at 12/4/18 1:34 PM:
---

Latest ATLAS-1773 patch (4th Dec) relies on ATLAS-2939 for correct property 
handling and ATLAS-2985 for full delete function.


was (Author: grahamwallis):
Latest ATLAS-1773 patch (3rd Dec) relies on ATLAS-2939 for correct property 
handling and ATLAS-2985 for full delete function.

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-04.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-04 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-12-04.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-04.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-04 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-12-03.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-04.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-03 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-11-14.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-03 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707044#comment-16707044
 ] 

Graham Wallis commented on ATLAS-1773:
--

Latest ATLAS-1773 patch (3rd Dec) relies on ATLAS-2939 for correct property 
handling and ATLAS-2985 for full delete function.

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-03.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-12-03 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-12-03.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-12-03.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2985) Fix delete handlers and relationship store

2018-12-03 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2985:
-
Description: 
The problems this fixes are as follows:
 * following a soft delete, a hard delete is not possible because the entity or 
relationship will have status DELETED, and prior to this Jira and patch the 
abstract delete handler skips the delete. 
 * during a soft delete the modified-time, modified-by and version number 
attributes on the entity or relationship should be updated, but 
updateRelationship does not update system attributes - this Jira and patch 
updates the system attributes that will need to be updated during a delete or 
other update operations.
 * also fixes a minor copy-paste debug logging error.

> Fix delete handlers and relationship store
> --
>
> Key: ATLAS-2985
> URL: https://issues.apache.org/jira/browse/ATLAS-2985
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Critical
> Attachments: ATLAS-2985-2018-11-30.patch
>
>
> The problems this fixes are as follows:
>  * following a soft delete, a hard delete is not possible because the entity 
> or relationship will have status DELETED, and prior to this Jira and patch 
> the abstract delete handler skips the delete. 
>  * during a soft delete the modified-time, modified-by and version number 
> attributes on the entity or relationship should be updated, but 
> updateRelationship does not update system attributes - this Jira and patch 
> updates the system attributes that will need to be updated during a delete or 
> other update operations.
>  * also fixes a minor copy-paste debug logging error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2985) Fix delete handlers and relationship store

2018-11-30 Thread Graham Wallis (JIRA)
Graham Wallis created ATLAS-2985:


 Summary: Fix delete handlers and relationship store
 Key: ATLAS-2985
 URL: https://issues.apache.org/jira/browse/ATLAS-2985
 Project: Atlas
  Issue Type: Bug
Reporter: Graham Wallis
Assignee: Graham Wallis






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2985) Fix delete handlers and relationship store

2018-11-30 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704999#comment-16704999
 ] 

Graham Wallis commented on ATLAS-2985:
--

Review is here: https://reviews.apache.org/r/69494/

> Fix delete handlers and relationship store
> --
>
> Key: ATLAS-2985
> URL: https://issues.apache.org/jira/browse/ATLAS-2985
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Critical
> Attachments: ATLAS-2985-2018-11-30.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 69494: ATLAS-2985 fixes for delete handlers and relationship store

2018-11-30 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69494/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2985: critical fixes for delete handlers and relationship dtore


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 c57e30ab5cdb34aee1cb13c463b1b0af827d2a2e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 edf1eed4c3efdd41f77155e51c8f2908b3dbbab2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 86cc98cda61d85954fd227501d691e3a3b542611 


Diff: https://reviews.apache.org/r/69494/diff/1/


Testing
---

Tested with full run of Egeria CTS suite.


Thanks,

Graham Wallis



[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-30 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-2985-2018-11-30.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2985-2018-11-30.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-20 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692943#comment-16692943
 ] 

Graham Wallis commented on ATLAS-1773:
--

Hi Bogdan - yes that was expected once the ATLAS-2774 changes went in to the 
relationship store. I rebased the patch for ATLAS-2967 yesterday and committed 
it to Atlas master. 

It should now be possible to build with just Atlas master and the ATLAS-2939 
patch. The other Atlas dependencies (ATLAS-2936, ATLAS-2938 and ATLAS-2967) are 
now committed.

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2967-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-20 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-2967-2018-11-14.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, ATLAS-2939-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-19 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis resolved ATLAS-2967.
--
Resolution: Fixed
  Assignee: Graham Wallis

> Save and restore homeId into AtlasRelationship instances
> 
>
> Key: ATLAS-2967
> URL: https://issues.apache.org/jira/browse/ATLAS-2967
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: ATLAS-2967-2018-11-19.patch
>
>
> In order to save homeId system attribute into a saved AtlasRelationship and 
> retrieve it when reading the relationship, need to update 
> EntityGraphRetriever and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-19 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2967:
-
Attachment: ATLAS-2967-2018-11-19.patch

> Save and restore homeId into AtlasRelationship instances
> 
>
> Key: ATLAS-2967
> URL: https://issues.apache.org/jira/browse/ATLAS-2967
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: ATLAS-2967-2018-11-19.patch
>
>
> In order to save homeId system attribute into a saved AtlasRelationship and 
> retrieve it when reading the relationship, need to update 
> EntityGraphRetriever and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-19 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2967:
-
Attachment: (was: ATLAS-2967-2018-11-14.patch)

> Save and restore homeId into AtlasRelationship instances
> 
>
> Key: ATLAS-2967
> URL: https://issues.apache.org/jira/browse/ATLAS-2967
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
>
> In order to save homeId system attribute into a saved AtlasRelationship and 
> retrieve it when reading the relationship, need to update 
> EntityGraphRetriever and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-15 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687745#comment-16687745
 ] 

Graham Wallis commented on ATLAS-1773:
--

Added 14th November patch - this level of connector code passes the mandatory 
level of the CTS (with mods to the CTS for authentication and a few other 
things).

It pre-reqs the patches for ATLAS-2939 and ATLAS-2967 (which contain changes to 
base Atlas for clearing of properties and save and restore of relationship 
homeId). I have attached both those patches to this Jira for your convenience. 
You can apply the patches in any order to Atlas master.

Good luck - let me know if you run into any problems. 

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2967-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-15 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-09-04.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2967-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-15 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-10-01.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2967-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-15 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-2967-2018-11-14.patch
ATLAS-2939-2018-11-14.patch
ATLAS-1773-2018-11-14.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2967-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-11-15 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-08-31.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-11-14.patch, 
> ATLAS-2939-2018-11-14.patch, ATLAS-2967-2018-11-14.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69334: ATLAS-2774: enhancement to support delete-type specification (hard or soft) per API call

2018-11-15 Thread Graham Wallis


> On Nov. 14, 2018, 1:53 p.m., Graham Wallis wrote:
> > I don't think that this change satisfies the original problem, because even 
> > with the change Atlas will only perform either a hard or soft delete of an 
> > entity, subject to configuration of the delete handler.
> > 
> > The requirement in the JIRA is that Atlas should always provide the ability 
> > to hard delete, regardless of configuration.
> > As an optional addition to that, if Atlas is configured for soft delete 
> > then it will be possible perform a soft delete (optionally followed by 
> > either a restore or a hard delete).
> > 
> > The purpose of the JIRA is to provide optional soft delete whilst 
> > continuing to support the mandatory hard delete function.
> > 
> > For the entity store: the way the patch is written, to satisfy the first 
> > part of the requirement (for provision of hard delete), Atlas would always 
> > have to be configured for hard delete. It would therefore never be possible 
> > to soft delete an entity. Technically that meets the requirements, but that 
> > was the case before the change - provided Atlas was configured for hard 
> > delete.
> > 
> > I think the change for the relationship store meets the above requirements 
> > - I think it is possible to call deleteById() and set the forceDelete 
> > parameter to true. Could we have a similar facility for the entity store?
> 
> Madhan Neethiraj wrote:
> Graham - irrespective of the delete-handler specified in the 
> configuration, a REST API caller can specify the delete-type to use with 
> query parameter 'deleteType'. For example, to hard-delete an entity the API 
> call will be like: DELETE 
> api/atlas/v2/entity/guid/?deleteType=HARD. Possible values are: 
> SOFT, HARD and DEFAULT. When this parameter is not specified, the 
> delete-handler specified in the configuration will be used.
> 
> There is no change to store APIs with this patch. Users of store APIs 
> should set the desired delete-type by calling 
> RequestContext.get().setDeleteType(DeleteType) before calling the store APIs.
> 
> Hope this helps.
> 
> Graham Wallis wrote:
> OK - thanks Madhan - I am doing this directly from Java so not using the 
> REST APIs. I will try the RequestContext setter approach. Is there a reason 
> why the entity store and relationship store appear to handle this very 
> differently - one having an explicit parameter and the other need the caller 
> to set the RequestContext first?
> 
> Madhan Neethiraj wrote:
> Graham - both entity-store and relationship-store have the same interface 
> wrt delete-handler. Perhaps you are referring to another patch for this JIRA, 
> https://reviews.apache.org/r/69305/, where delete-type is taken as parameter 
> to store APIs.

I don't agree. It is confusing that there appear to be multiple patches and 
reviews relating to this one JIRA, but ignoring the patches and looking at the 
latest master, the stores have different interfaces:

EntityStore: does not offer the caller a force parameter...

  public EntityMutationResponse deleteById(final String guid) throws 
AtlasBaseException 


RelationshipStore: provides the guid-only deleteById method which delegates to 
the additional method that accepts the boolean forceDelete...

  public void deleteById(String guid) throws AtlasBaseException {  
deleteById(guid, false);  }

  public void deleteById(String guid, boolean forceDelete) throws 
AtlasBaseException 
  
  
It's not clear what we are recommending to a non-REST caller - should it set 
the RequestContext for both stores? Or just for the entity store, and instead 
use the explicit forceDelete parameter when deleting a relationship?


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69334/#review210539
---


On Nov. 14, 2018, 10:50 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69334/
> ---
> 
> (Updated Nov. 14, 2018, 10:50 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Mehul 
> Parikh, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2774
> https://issues.apache.org/jira/browse/ATLAS-2774
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> support "deleteType" query-parameter for REST API calls
> 
> 
> Diffs
> -
> 
>   intg/src/main/j

[jira] [Commented] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-14 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686364#comment-16686364
 ] 

Graham Wallis commented on ATLAS-2967:
--

Review is here: [https://reviews.apache.org/r/69335/]

 

> Save and restore homeId into AtlasRelationship instances
> 
>
> Key: ATLAS-2967
> URL: https://issues.apache.org/jira/browse/ATLAS-2967
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: ATLAS-2967-2018-11-14.patch
>
>
> In order to save homeId system attribute into a saved AtlasRelationship and 
> retrieve it when reading the relationship, need to update 
> EntityGraphRetriever and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2939) Enable EntityGraphMapper to unset optional attribute

2018-11-14 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686362#comment-16686362
 ] 

Graham Wallis commented on ATLAS-2939:
--

Review is here: [https://reviews.apache.org/r/69336/]

 

> Enable EntityGraphMapper to unset optional attribute
> 
>
> Key: ATLAS-2939
> URL: https://issues.apache.org/jira/browse/ATLAS-2939
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2939-2018-11-14.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 69336: ATLAS-2939: enable removal of optional attribute from an entity instance

2018-11-14 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69336/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2939: Support clearing of optional attribute from entity


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 e8c8c0c8b54088ae64de0059e6fc6f1e421c8047 


Diff: https://reviews.apache.org/r/69336/diff/1/


Testing
---

Tested with full run of Egeria Compliance Test Suite


NB This patch will need to be re-based when ATLAS-2774 (Ashutosh) is committed


Thanks,

Graham Wallis



[jira] [Updated] (ATLAS-2939) Enable EntityGraphMapper to unset optional attribute

2018-11-14 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2939:
-
Attachment: ATLAS-2939-2018-11-14.patch

> Enable EntityGraphMapper to unset optional attribute
> 
>
> Key: ATLAS-2939
> URL: https://issues.apache.org/jira/browse/ATLAS-2939
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2939-2018-11-14.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 69335: ATLAS-2967 set and read homeId in AtlasRelationship

2018-11-14 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69335/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2967: Save and restore homeId in an AtlasRelationship instance


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 21617dcc3f979095687d112b48c41074cf7c9d17 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 c8a760b4ea9af9c5fd9a197d7a1623db7043f296 


Diff: https://reviews.apache.org/r/69335/diff/1/


Testing
---

Tested with full run of Egeria Compliance Test Suite


NB This patch will need to be re-based when ATLAS-2774 (from Ashutosh) is 
committed


Thanks,

Graham Wallis



[jira] [Updated] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-14 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2967:
-
Fix Version/s: 2.0.0

> Save and restore homeId into AtlasRelationship instances
> 
>
> Key: ATLAS-2967
> URL: https://issues.apache.org/jira/browse/ATLAS-2967
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: ATLAS-2967-2018-11-14.patch
>
>
> In order to save homeId system attribute into a saved AtlasRelationship and 
> retrieve it when reading the relationship, need to update 
> EntityGraphRetriever and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-14 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2967:
-
Attachment: ATLAS-2967-2018-11-14.patch

> Save and restore homeId into AtlasRelationship instances
> 
>
> Key: ATLAS-2967
> URL: https://issues.apache.org/jira/browse/ATLAS-2967
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2967-2018-11-14.patch
>
>
> In order to save homeId system attribute into a saved AtlasRelationship and 
> retrieve it when reading the relationship, need to update 
> EntityGraphRetriever and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2967) Save and restore homeId into AtlasRelationship instances

2018-11-14 Thread Graham Wallis (JIRA)
Graham Wallis created ATLAS-2967:


 Summary: Save and restore homeId into AtlasRelationship instances
 Key: ATLAS-2967
 URL: https://issues.apache.org/jira/browse/ATLAS-2967
 Project: Atlas
  Issue Type: Improvement
Reporter: Graham Wallis


In order to save homeId system attribute into a saved AtlasRelationship and 
retrieve it when reading the relationship, need to update EntityGraphRetriever 
and AtlasRelationshipStoreV2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2938) Enable EntityGraphMapper to update entity version

2018-11-01 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis resolved ATLAS-2938.
--
Resolution: Fixed

> Enable EntityGraphMapper to update entity version 
> --
>
> Key: ATLAS-2938
> URL: https://issues.apache.org/jira/browse/ATLAS-2938
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2938) Enable EntityGraphMapper to update entity version

2018-11-01 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis reassigned ATLAS-2938:


 Assignee: Graham Wallis
Fix Version/s: 2.0.0

> Enable EntityGraphMapper to update entity version 
> --
>
> Key: ATLAS-2938
> URL: https://issues.apache.org/jira/browse/ATLAS-2938
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2936) Enable Atlas to store provenance type information

2018-11-01 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis reassigned ATLAS-2936:


 Assignee: Graham Wallis
Fix Version/s: 2.0.0

> Enable Atlas to store provenance type information
> -
>
> Key: ATLAS-2936
> URL: https://issues.apache.org/jira/browse/ATLAS-2936
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2936) Enable Atlas to store provenance type information

2018-11-01 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis resolved ATLAS-2936.
--
Resolution: Fixed

> Enable Atlas to store provenance type information
> -
>
> Key: ATLAS-2936
> URL: https://issues.apache.org/jira/browse/ATLAS-2936
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>    Assignee: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-31 Thread Graham Wallis


> On Oct. 30, 2018, 10:11 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
> > Line 73 (original), 73 (patched)
> > <https://reviews.apache.org/r/69190/diff/1/?file=2102819#file2102819line73>
> >
> > Please revert to individual imports.

Will do - sorry about that - I think IntelliJ aggregates them automatically, 
although there is probably a configuration option somewhere to disable it.


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/#review210195
---


On Oct. 30, 2018, 3:22 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69190/
> ---
> 
> (Updated Oct. 30, 2018, 3:22 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2936: Add provenanceType system attribute
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 066b0d0f424b27220ab102d3d2a04b7568790c8a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> bc79dadc75ceb927747fa94f8189a540cd145bf2 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> b4189d2d1e7359b7a3c4c210438a385d124c3d74 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  512fff470d04bc09f4b3d52aaefcecc7816c25f1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c08f4c471b0a37276f2af99a32c4fc673f3811c5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  f03262faae5889dad05bb1c635a0b17d2bdfb6f4 
> 
> 
> Diff: https://reviews.apache.org/r/69190/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with ODPi Compliance Test Suite.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>



Review Request 69190: ATLAS-2936: store and retrieve provenance type

2018-10-30 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69190/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2936: Add provenanceType system attribute


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 
ed2ca4ce784405cdc489c951b1be5b1fc51bbd34 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
066b0d0f424b27220ab102d3d2a04b7568790c8a 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
bc79dadc75ceb927747fa94f8189a540cd145bf2 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
b4189d2d1e7359b7a3c4c210438a385d124c3d74 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 512fff470d04bc09f4b3d52aaefcecc7816c25f1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c08f4c471b0a37276f2af99a32c4fc673f3811c5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 f03262faae5889dad05bb1c635a0b17d2bdfb6f4 


Diff: https://reviews.apache.org/r/69190/diff/1/


Testing
---

Tested with ODPi Compliance Test Suite.


Thanks,

Graham Wallis



Review Request 69191: ATLAS-2938: update version number in EntityGraphMapper

2018-10-30 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69191/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2938: EntityGraphMapper stores updated version number


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c08f4c471b0a37276f2af99a32c4fc673f3811c5 


Diff: https://reviews.apache.org/r/69191/diff/1/


Testing
---

Tested with ODPi Compliance Test Suite.


Thanks,

Graham Wallis



[jira] [Created] (ATLAS-2939) Enable EntityGraphMapper to unset optional attribute

2018-10-26 Thread Graham Wallis (JIRA)
Graham Wallis created ATLAS-2939:


 Summary: Enable EntityGraphMapper to unset optional attribute
 Key: ATLAS-2939
 URL: https://issues.apache.org/jira/browse/ATLAS-2939
 Project: Atlas
  Issue Type: Improvement
Reporter: Graham Wallis






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2938) Enable EntityGraphMapper to update entity version

2018-10-26 Thread Graham Wallis (JIRA)
Graham Wallis created ATLAS-2938:


 Summary: Enable EntityGraphMapper to update entity version 
 Key: ATLAS-2938
 URL: https://issues.apache.org/jira/browse/ATLAS-2938
 Project: Atlas
  Issue Type: Improvement
Reporter: Graham Wallis






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2936) Enable Atlas to store provenance type information

2018-10-26 Thread Graham Wallis (JIRA)
Graham Wallis created ATLAS-2936:


 Summary: Enable Atlas to store provenance type information
 Key: ATLAS-2936
 URL: https://issues.apache.org/jira/browse/ATLAS-2936
 Project: Atlas
  Issue Type: Improvement
Reporter: Graham Wallis






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68998: ATLAS-29018: Update JanusGraph version to 0.3.1

2018-10-12 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68998/#review209480
---



Hi Sarath - Looks fine - just wondering why you moved the janus.version up to 
the root POM - I think I put in the janus module POM and kept it with the 
tinkerpop.version. Would it be worth moving both/neither?
All the best
  Graham

- Graham Wallis


On Oct. 11, 2018, 7:56 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68998/
> ---
> 
> (Updated Oct. 11, 2018, 7:56 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2918
> https://issues.apache.org/jira/browse/ATLAS-2918
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Janusgraph community has released their latest version:
> 
> https://github.com/JanusGraph/janusgraph/releases/tag/v0.3.1
> 
> This JIRA will update janus version to 0.3.1 in atlas source.
> 
> 
> Diffs
> -
> 
>   graphdb/janus/pom.xml cd5c82ee2 
>   intg/src/test/resources/atlas-application.properties 7e74d5107 
>   pom.xml 92b3218ed 
> 
> 
> Diff: https://reviews.apache.org/r/68998/diff/1/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/754/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-10-01 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-10-01.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-31.patch, 
> ATLAS-1773-2018-09-04.patch, ATLAS-1773-2018-10-01.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-09-04 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-09-04.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-31.patch, ATLAS-1773-2018-09-04.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-09-04 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-08-31.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-31.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-09-04 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-08-31.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-04.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-09-04 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603187#comment-16603187
 ] 

Graham Wallis commented on ATLAS-1773:
--

4th September patch includes:
 * support for learning mode for entity refreshes (not relationships yet),
 * offset and pageSize handling,
 * improved exception handling around use of registry,
 * acceptance of null guid on saveRelationshipReferenceCopy

Leaving the 31st August patch attached in case of problems with latest patch in 
the next few weeks.

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-04.patch, ATLAS-1773-2018-08-31.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-09-04 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-08-04.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-04.patch, ATLAS-1773-2018-08-31.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-09-04 Thread Graham Wallis
 operations 
(creation of types, instances, reference copies and proxies).


Thanks,

Graham Wallis



Re: Review Request 68584: ATLAS-2853: updated to send entity-notifications after successful graph transaction commit

2018-08-31 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68584/#review208161
---


Ship it!




Elegant fix - thanks Madhan. Once this is committed I will modify the OMRS 
event mapper.

- Graham Wallis


On Aug. 31, 2018, 4:12 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68584/
> ---
> 
> (Updated Aug. 31, 2018, 4:12 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Graham Wallis, keval 
> bhatt, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2853
> https://issues.apache.org/jira/browse/ATLAS-2853
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated to send entity notifications only after graph transaction is committed
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  783d62fb3 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  c70011f24 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationSender.java
>  PRE-CREATION 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java
>  1eeecefc1 
> 
> 
> Diff: https://reviews.apache.org/r/68584/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the notifications are sent post transaction commit.
> 
> Pre-commit test run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/645
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-31 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-08-31.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-31.patch, 
> ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-31 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-08-17.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-31 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-08-23.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-31 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-08-22.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-31 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68412/
---

(Updated Aug. 31, 2018, 3:44 p.m.)


Review request for atlas.


Changes
---

Updated diff with changes from first round of review comments plus enhancements 
from the last week


Repository: atlas


Description
---

ATLAS-1773: Atlas OMRS Repository Connector


Diffs (updated)
-

  open-metadata/pom.xml PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java
 PRE-CREATION 
  pom.xml c60a53b0e 
  webapp/pom.xml 78aa81e80 
  webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 23dc0637a 


Diff: https://reviews.apache.org/r/68412/diff/2/

Changes: https://reviews.apache.org/r/68412/diff/1-2/


Testing
---

Unit Testing (approx 80 tests) and Functional Testing of major operations 
(creation of types, instances, reference copies and proxies).


Thanks,

Graham Wallis



[jira] [Commented] (ATLAS-2853) Entity notifications to be sent after transaction commit

2018-08-31 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598463#comment-16598463
 ] 

Graham Wallis commented on ATLAS-2853:
--

In addition to the problem of what happens on a rollback, the problem also 
affects commit - but I think your patch addresses it. The additional aspect to 
the problem is that if the notification is sent prior to commit then the 
subscribers can pick it up and query the graph before the graph has had a 
chance to commit - so the subscribers see the old (stale) state. The most 
obvious example of this was on an entity create - the subscriber then queried 
the graph and the graph denied any knowledge of the new entity. Doing the 
commit before send is better in both the commit and rollback cases.

> Entity notifications to be sent after transaction commit
> 
>
> Key: ATLAS-2853
> URL: https://issues.apache.org/jira/browse/ATLAS-2853
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Critical
> Fix For: 0.8.3, 1.1.0, 2.0.0
>
> Attachments: ATLAS-2853.patch
>
>
> Currently, notification on entity changes (create/update/delete entities, 
> add/update/remove classifications on entities) are sent before the changes 
> are committed in the database. If commit fails, the entity state seen by 
> notification receivers would be different from Atlas. To avoid this, Atlas 
> server should entity notifications only after the transaction is committed to 
> the database.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-30 Thread Graham Wallis
ers/repositoryconnector/AtlasAttributeDefMapper.java
> > Lines 190 (patched)
> > <https://reviews.apache.org/r/68412/diff/1/?file=2074624#file2074624line190>
> >
> > This is comment for 'cardinality' definition in openmetada: "UNORDERED" 
> > doesn't capture the uniqueness of the elements in a SET.
> > 
> >   - SET:  unordered, unique elements
> >   - LIST: ordered, can contain duplicate elements

OK - I need to look into this and talk to the Egeria community about it. Will 
leave this issue open and address it asap.


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68412/#review207941
---


On Aug. 17, 2018, 2:38 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68412/
> ---
> 
> (Updated Aug. 17, 2018, 2:38 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1773: Atlas OMRS Repository Connector
> 
> 
> Diffs
> -
> 
>   open-metadata/pom.xml PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java
>  PRE-CREATION 
>   
> open-metadata/src

Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-30 Thread Graham Wallis


> On Aug. 17, 2018, 3:58 p.m., David Radley wrote:
> >

Thanks David - all fixed.


> On Aug. 17, 2018, 3:58 p.m., David Radley wrote:
> > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java
> > Lines 346 (patched)
> > <https://reviews.apache.org/r/68412/diff/1/?file=2074622#file2074622line346>
> >
> > What is the implication of leaving htis TODO in the code? I suggest at 
> > least there should be a Jira numebr here to track ths issue.

This was a temporary solution prior to the local user id being available in the 
connector. This is now implemented.


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68412/#review207494
-------


On Aug. 17, 2018, 2:38 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68412/
> ---
> 
> (Updated Aug. 17, 2018, 2:38 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1773: Atlas OMRS Repository Connector
> 
> 
> Diffs
> -
> 
>   open-metadata/pom.xml PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java
>  PRE-CREATION 
>   
> open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/reposit

[jira] [Created] (ATLAS-2844) Add timestamp in EntityNotification

2018-08-28 Thread Graham Wallis (JIRA)
Graham Wallis created ATLAS-2844:


 Summary: Add timestamp in EntityNotification
 Key: ATLAS-2844
 URL: https://issues.apache.org/jira/browse/ATLAS-2844
 Project: Atlas
  Issue Type: Improvement
Reporter: Graham Wallis


If we add a timestamp to the EntityNotification it will allow a consumer of the 
notification to accurately specify the time that the event occurred, even after 
publication and subsequent consume through Kafka topic. This would improve 
precision.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-28 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis reopened ATLAS-1773:
--

Resolved prematurely - reopening

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-17.patch, 
> ATLAS-1773-2018-08-22.patch, ATLAS-1773-2018-08-23.patch, 
> ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-23 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-08-23.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-17.patch, 
> ATLAS-1773-2018-08-22.patch, ATLAS-1773-2018-08-23.patch, 
> ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-21 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-08-22.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-17.patch, 
> ATLAS-1773-2018-08-22.patch, ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2808) Enable Atlas to store entity proxies

2018-08-17 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis resolved ATLAS-2808.
--
   Resolution: Fixed
Fix Version/s: 2.0.0

> Enable Atlas to store entity proxies
> 
>
> Key: ATLAS-2808
> URL: https://issues.apache.org/jira/browse/ATLAS-2808
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: ATLAS-2808-2018-08-16.patch
>
>
> This feature will enable Atlas to store proxies for entities supplied as 
> relationship ends, to enable Atlas to participate in distributed metadata 
> sharing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-17 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68412/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-1773: Atlas OMRS Repository Connector


Diffs
-

  open-metadata/pom.xml PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java
 PRE-CREATION 
  
open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java
 PRE-CREATION 
  
open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java
 PRE-CREATION 
  pom.xml c60a53b0e2e7038b6228e16ceba47a0080d58622 
  webapp/pom.xml 78aa81e8046b676f47d24eff0671225a3c960929 
  webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION 
  webapp/src/main/webapp/WEB-INF/web.xml 
23dc0637a8b521ab89a16ec8b03895cdaf8bc7d8 


Diff: https://reviews.apache.org/r/68412/diff/1/


Testing
---

Unit Testing (approx 80 tests) and Functional Testing of major operations 
(creation of types, instances, reference copies and proxies).


Thanks,

Graham Wallis



[jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-17 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584006#comment-16584006
 ] 

Graham Wallis commented on ATLAS-1773:
--

Patch replaced. 

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-17.patch, 
> ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-17 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: ATLAS-1773-2018-08-17.patch

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1773-2018-08-17.patch, 
> ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-08-17 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-1773:
-
Attachment: (was: ATLAS-1773-2018-08-02.patch)

> Create the OMRS Connector for Atlas
> ---
>
> Key: ATLAS-1773
> URL: https://issues.apache.org/jira/browse/ATLAS-1773
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Mandy Chessell
>    Assignee: Graham Wallis
>Priority: Major
> Attachments: ATLAS-1799-nigel-fixup-20180718a,.patch
>
>
> This JIRA provides the definition of the OMRS Connector API and an 
> implementation of this API for a local Apache Atlas metadata repository and 
> for the OMRS REST API.
> The OMRS Connector has 3 API groups
> * The types API - this is the metadata API for a metadata repository
> * The entity and relationships APIs that provide the type-agnostic interfaces 
> that can access any type - even those added dynamically
> * The fine-grained type-safe APIs that are generated from the addons models 
> in the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-17 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/
---

(Updated Aug. 17, 2018, 12:03 p.m.)


Review request for atlas.


Changes
---

Fixed typo in comment and rationalised use of Boolean


Repository: atlas


Description
---

ATLAS_2808: Support for entity proxies


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a892551f7 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java dc2be412b 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
9c4b9f232 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2153a5a9e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 52c374564 


Diff: https://reviews.apache.org/r/68188/diff/3/

Changes: https://reviews.apache.org/r/68188/diff/2-3/


Testing
---

Tested with saveRelationshipReferenceCopy between entities that do not exist in 
the Atlas repository.


Thanks,

Graham Wallis



[jira] [Commented] (ATLAS-2808) Enable Atlas to store entity proxies

2018-08-16 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582576#comment-16582576
 ] 

Graham Wallis commented on ATLAS-2808:
--

Refreshed patch to address review comments.


Review at https://reviews.apache.org/r/68188/

> Enable Atlas to store entity proxies
> 
>
> Key: ATLAS-2808
> URL: https://issues.apache.org/jira/browse/ATLAS-2808
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2808-2018-08-16.patch
>
>
> This feature will enable Atlas to store proxies for entities supplied as 
> relationship ends, to enable Atlas to participate in distributed metadata 
> sharing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2808) Enable Atlas to store entity proxies

2018-08-16 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2808:
-
Attachment: ATLAS-2808-2018-08-16.patch

> Enable Atlas to store entity proxies
> 
>
> Key: ATLAS-2808
> URL: https://issues.apache.org/jira/browse/ATLAS-2808
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
> Attachments: ATLAS-2808-2018-08-16.patch
>
>
> This feature will enable Atlas to store proxies for entities supplied as 
> relationship ends, to enable Atlas to participate in distributed metadata 
> sharing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2808) Enable Atlas to store entity proxies

2018-08-16 Thread Graham Wallis (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Graham Wallis updated ATLAS-2808:
-
Attachment: (was: ATLAS-2808-2012-08-03.patch)

> Enable Atlas to store entity proxies
> 
>
> Key: ATLAS-2808
> URL: https://issues.apache.org/jira/browse/ATLAS-2808
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Graham Wallis
>Priority: Major
>
> This feature will enable Atlas to store proxies for entities supplied as 
> relationship ends, to enable Atlas to participate in distributed metadata 
> sharing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-16 Thread Graham Wallis


> On Aug. 9, 2018, 10:51 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
> > Lines 174 (patched)
> > <https://reviews.apache.org/r/68188/diff/1/?file=2066993#file2066993line174>
> >
> > I am wondering what your thoughts are on validation in Atlas. 
> > Specifically for cases like:
> > - the entity is a proxy but has no homeid. 
> > - the entity is a proxy but has none manditory attributes set which 
> > should not be returned
> > - the entity is a proxy so should not be in search results
> > 
> > As coded the caller is responsible for this sort of validation.

Thanks David - good suggestions.
There is already validation (in addEntityProxy) that the metadataCollectionId 
is non null - this will prevent creation of a proxy with a null homeId.
I have added filtering out of proxy entities from search methods (using DSL or 
searchParameters).


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/#review207015
-------


On Aug. 16, 2018, 1:56 p.m., Graham Wallis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68188/
> ---
> 
> (Updated Aug. 16, 2018, 1:56 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS_2808: Support for entity proxies
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 
> a892551f789cb2a4b21a4f0124a4b6b94bfecd1c 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> dc2be412b9ec1b07d7c7befc722810273464cd3f 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9c4b9f2323cae76ed226b3980086c2b331d521d2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2153a5a9e62ecf3e4a4c847b64edc29c1fb8eafc 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  52c3745642f3eb2af00cb61e10d710c781b100b7 
> 
> 
> Diff: https://reviews.apache.org/r/68188/diff/2/
> 
> 
> Testing
> ---
> 
> Tested with saveRelationshipReferenceCopy between entities that do not exist 
> in the Atlas repository.
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>



Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-16 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68188/
---

(Updated Aug. 16, 2018, 1:56 p.m.)


Review request for atlas.


Repository: atlas


Description
---

ATLAS_2808: Support for entity proxies


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 
a892551f789cb2a4b21a4f0124a4b6b94bfecd1c 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
dc2be412b9ec1b07d7c7befc722810273464cd3f 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
9c4b9f2323cae76ed226b3980086c2b331d521d2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2153a5a9e62ecf3e4a4c847b64edc29c1fb8eafc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 52c3745642f3eb2af00cb61e10d710c781b100b7 


Diff: https://reviews.apache.org/r/68188/diff/2/

Changes: https://reviews.apache.org/r/68188/diff/1-2/


Testing
---

Tested with saveRelationshipReferenceCopy between entities that do not exist in 
the Atlas repository.


Thanks,

Graham Wallis



[jira] [Commented] (ATLAS-2807) Re-evaluate classification propagation during entity delete

2018-08-13 Thread Graham Wallis (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578306#comment-16578306
 ] 

Graham Wallis commented on ATLAS-2807:
--

I still think this change should not be applied to all types of relationship - 
it is appropriate for those relationships in which the propagated 
classifications are effectively inherited - e.g. if you create a table by 
running a process on a dataset, then delete the dataset - in that case the 
generated table should (indeed, must) continue to be tagged eg as PII. But in a 
relationship of a transient nature you might only want the classifications to 
persist whilst the source entity exists and is related to the target entity. It 
seems that this change only considers the former, not the latter. 

 

> Re-evaluate classification propagation during entity delete
> ---
>
> Key: ATLAS-2807
> URL: https://issues.apache.org/jira/browse/ATLAS-2807
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 1.0.0-alpha, 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> ATLAS-2807-Re-evaluate-classification-propagation-du-MASTER.patch, 
> Classification Propagation during entity delete1.pdf
>
>
> The current behavior - when we delete an entity *f1*, all tags associate to 
> *f1* which got propagated
> to downstream entities are removed – *PII* tag propagated to *process1* and 
> *t1* is removed
> *Proposed Change*
> _*Soft Delete:*_
> When entity *f1* is deleted, retain the propagated classification edges, so 
> the downstream entities
> – *process1* and *t1* continue to have *PII* classification associated to them
> _*Hard Delete:*_
> In cases of hard delete, the source entity (*f1*) is deleted from atlas, but 
> its classification vertex
> (*PII*) continue to exist and will continue propagating to *process1* and 
> *t1*.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread Graham Wallis

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68287/#review207065
---



Please look at the question I posted to the JIRA - I am not sure that you 
always want the specified behaviour.

- Graham Wallis


On Aug. 10, 2018, 2:36 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68287/
> ---
> 
> (Updated Aug. 10, 2018, 2:36 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2807
> https://issues.apache.org/jira/browse/ATLAS-2807
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> The current behavior - when we delete an entity f1, all tags associate to f1 
> which got propagated
> 
> 
> to downstream entities are removed – PII tag propagated to process1 and t1 is 
> removed
> 
> 
> Proposed Change
> 
> 
> Soft Delete:
> 
> 
> When entity f1 is deleted, retain the propagated classification edges, so the 
> downstream entities
> 
> 
> – process1 and t1 continue to have PII classification associated to them
> 
> 
> Hard Delete:
> 
> 
> In cases of hard delete, the source entity (f1) is deleted from atlas, but 
> its classification vertex
> 
> 
> (PII) continue to exist and will continue propagating to process1 and t1.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 7988d1d81 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 328b76734 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 
> 3132379b9 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> d328873f1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  c6be4061b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  4a0924bbe 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
>  a95e6898e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
>  41e65d4a3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  28a26ab4f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  f57ce99f7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  8f4faaff8 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  58005c458 
>   
> repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java
>  8ceeedb01 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> e01cba92d 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fd331faa0 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
> 78bd53ce7 
> 
> 
> Diff: https://reviews.apache.org/r/68287/diff/1/
> 
> 
> Testing
> ---
> 
> Validated basic cases using REST clirnt.
> 
> 
> PreCommit: In progress
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



  1   2   3   4   >