Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-06-03 Thread Le Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215661 --- Ship it! Ship It! - Le Ma On June 3, 2019, 7:08 p.m., Na Li

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-06-03 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215660 --- Ship it! Ship It! - Sarath Subramanian On June 3, 2019, 12:0

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-06-03 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated June 3, 2019, 7:08 p.m.) Review request for atlas, madhan and Sarath S

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-06-03 Thread Na Li via Review Board
> On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 633 (patched) > > > > > > impalaDDL => hiveDDL done

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215629 --- addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/e

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Le Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215628 --- addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/e

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated May 31, 2019, 11:24 p.m.) Review request for atlas, madhan and Sarath

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li via Review Board
> On May 31, 2019, 8:16 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1090-impala_model.json > > Lines 193 (patched) > > > > > > we don't need to define a new impala_db_ddl and impala_table_ddl, since

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li via Review Board
> On May 31, 2019, 5:50 p.m., Le Ma wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > > Lines 107 (patched) > > > > > > Hello Lina, thanks for doing this. Th

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215623 --- addons/models/1000-Hadoop/1090-impala_model.json Lines 193 (patch

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Le Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215618 --- addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/e

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215608 --- addons/models/1000-Hadoop/1030-hive_model.json Line 727 (original

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated May 31, 2019, 4:02 a.m.) Review request for atlas, madhan and Sarath S

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated May 30, 2019, 5:06 p.m.) Review request for atlas, madhan and Sarath S

Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-29 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- Review request for atlas, madhan and Sarath Subramanian. Repository: atlas De