Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

passing with the new onChange call 2. Tested via curl/postman, changes are reflected immediately Thanks, Apoorv Naik

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

: https://reviews.apache.org/r/53207/diff/ Testing --- 1. UnitTests passing with the new onChange call 2. Tested via curl/postman, changes are reflected immediately Thanks, Apoorv Naik

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

--- 1. UnitTests passing with the new onChange call 2. Tested via curl/postman, changes are reflected immediately Thanks, Apoorv Naik

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2. Tested via curl/postman, changes are reflected immediately Thanks, Apoorv Naik

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

passing with the new onChange call 2. Tested via curl/postman, changes are reflected immediately Thanks, Apoorv Naik

Review Request 53207: Adding Change listeners to react on changes in TypesDef

are reflected immediately Thanks, Apoorv Naik

Re: Review Request 53149: Adding Change listeners to react on changes in TypesDef

by UnitTests Restore not yet working on TypeSystem (getting TypeUpdateException) Thanks, Apoorv Naik

Re: Review Request 53149: Adding Change listeners to react on changes in TypesDef

webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorModule.java ee6035da62005accea354117423e5f249e39930b Diff: https://reviews.apache.org/r/53149/diff/ Testing (updated) --- HA activation tested by UnitTests Thanks, Apoorv Naik

Re: Review Request 53157: TypesResource API needs to use the new TypesREST API

56) <https://reviews.apache.org/r/53157/#comment223313> Since everything is statically accessed, make this private. - Apoorv Naik On Oct. 24, 2016, 11:54 p.m., Sarath Subramanian wrote: > > --- > This is an automatica

Re: Review Request 52995: Error Catalog enhancement

: https://reviews.apache.org/r/52995/diff/ Testing --- Tested will REST API calls. Unit Tests coverage will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Review Request 53149: Adding Change listeners to react on changes in TypesDef

--- Working on HA environment setup to verify the ActiveInstanceListener action Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1240) ChangeListeners for any changes to the new TypeRegistry

Apoorv Naik created ATLAS-1240: -- Summary: ChangeListeners for any changes to the new TypeRegistry Key: ATLAS-1240 URL: https://issues.apache.org/jira/browse/ATLAS-1240 Project: Atlas Issue Type

Re: Review Request 52995: Error Catalog enhancement

c5518142492dab0e343caf4cedbe8eb1a645364a Diff: https://reviews.apache.org/r/52995/diff/ Testing --- Tested will REST API calls. Unit Tests coverage will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1200) Enhance the Exception mechanism

[ https://issues.apache.org/jira/browse/ATLAS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1200: --- Attachment: (was: ATLAS-1200.patch) > Enhance the Exception mechan

[jira] [Updated] (ATLAS-1200) Enhance the Exception mechanism

[ https://issues.apache.org/jira/browse/ATLAS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1200: --- Attachment: ATLAS-1200.patch > Enhance the Exception mechan

Re: Review Request 52995: Error Catalog enhancement

://reviews.apache.org/r/52995/diff/ Testing --- Tested will REST API calls. Unit Tests coverage will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Re: Review Request 52995: Error Catalog enhancement

as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Re: Review Request 52995: Error Catalog enhancement

ra/browse/ATLAS-503 for more details Should I add a custom mapper for any titan exception ? Convert them to 500s ? - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52

Re: Review Request 52995: Error Catalog enhancement

Instead of replacing generic type E with AtlasBaseException, it might > > be better to handle AtlasBaseException type of exception inside > > toResponse(E excp) - similar to how WebApplicationException is handled. > > > > Woud that make this mapper to handle more

Re: Review Request 52995: Error Catalog enhancement

, Apoorv Naik

Re: Review Request 52995: Error Catalog enhancement

.apache.org/r/52995/#review153493 --- On Oct. 21, 2016, 2:50 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52995/ > -

Re: Review Request 52995: Error Catalog enhancement

xception. Should I still get rid of it ? - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52995/#review153493 -----

Re: Review Request 52995: Error Catalog enhancement

coverage will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Re: Review Request 52995: Error Catalog enhancement

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52995/#review153487 --- On Oct. 20, 2016, 5:29 p.m., Apoorv Naik wrote: > > --

Re: Review Request 52995: Error Catalog enhancement

coverage will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Review Request 53039: Initial UTs for the driver Store class

of typedefs 3. Update typedefs (todo) 4. Delete typedefs (todo) Thanks, Apoorv Naik

Re: Review Request 52995: Error Catalog enhancement

will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Re: Review Request 52995: Error Catalog enhancement

coverage will be added as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1233) UnitTests for the TypeDefStores

Apoorv Naik created ATLAS-1233: -- Summary: UnitTests for the TypeDefStores Key: ATLAS-1233 URL: https://issues.apache.org/jira/browse/ATLAS-1233 Project: Atlas Issue Type: Test Affects

[jira] [Updated] (ATLAS-1233) UnitTests for the TypeDefStores

[ https://issues.apache.org/jira/browse/ATLAS-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1233: --- Attachment: ATLAS-1233.patch > UnitTests for the TypeDefSto

[jira] [Commented] (ATLAS-1200) Enhance the Exception mechanism

[ https://issues.apache.org/jira/browse/ATLAS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586723#comment-15586723 ] Apoorv Naik commented on ATLAS-1200: [~davidrad] Please take a look at the review request

[jira] [Updated] (ATLAS-1200) Enhance the Exception mechanism

[ https://issues.apache.org/jira/browse/ATLAS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1200: --- Attachment: ATLAS-1200.patch > Enhance the Exception mechan

Re: Review Request 52995: Error Catalog enhancement

as a part of the UT review request for TypesREST stores. Thanks, Apoorv Naik

Review Request 52995: Error Catalog enhancement

for TypesREST stores. Thanks, Apoorv Naik

Re: Review Request 52895: ATLAS-1225: Optimize AtlasTypeDefGraphStore to use AtlasTypesRegistry, to reduce queries to Graph DB

/AtlasTypeDefGraphStore.java <https://reviews.apache.org/r/52895/#comment221846> I was referring to this one. - Apoorv Naik On Oct. 14, 2016, 7:40 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically g

Re: Review Request 52895: ATLAS-1225: Optimize AtlasTypeDefGraphStore to use AtlasTypesRegistry, to reduce queries to Graph DB

/AtlasTypeDefGraphStore.java <https://reviews.apache.org/r/52895/#comment221823> Did we move the sorting logic somewhere else ? - Apoorv Naik On Oct. 14, 2016, 7:40 p.m., Madhan Neethiraj wrote: > > --- > This is a

[jira] [Commented] (ATLAS-1223) Type REST API v2 implementation

[ https://issues.apache.org/jira/browse/ATLAS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570223#comment-15570223 ] Apoorv Naik commented on ATLAS-1223: Thank you Suma. > Type REST API v2 implementat

[jira] [Updated] (ATLAS-1223) New REST API v2

[ https://issues.apache.org/jira/browse/ATLAS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1223: --- Attachment: (was: ATLAS-1223.patch) > New REST API v2 > --- > >

[jira] [Created] (ATLAS-1223) New REST API v2

Apoorv Naik created ATLAS-1223: -- Summary: New REST API v2 Key: ATLAS-1223 URL: https://issues.apache.org/jira/browse/ATLAS-1223 Project: Atlas Issue Type: Improvement Affects Versions: 0.7

[jira] [Updated] (ATLAS-1223) New REST API v2

[ https://issues.apache.org/jira/browse/ATLAS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1223: --- Attachment: ATLAS-1223.patch > New REST API v2 > --- > > Key

Re: Review Request 52585: Implementation of the new TypesREST API

/module/RestModule.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

--- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

--- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

adocs for all the intg classes Will do. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review152369 --- On Oct.

Re: Review Request 52585: Implementation of the new TypesREST API

: https://reviews.apache.org/r/52585/diff/ Testing --- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

-------- On Oct. 12, 2016, 4:24 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52585/ > --

Re: Review Request 52585: Implementation of the new TypesREST API

/RestModule.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

ld suffice in all queries Will check this. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review152241 ------

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/RestModule.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review152230 ------- On Oct. 12, 2016, 12:09 a.m., Apoorv Naik wrote: > > --- > This is an au

Re: Review Request 52585: Implementation of the new TypesREST API

PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Review Request 52761: TypesREST implementation

. UT and IT in progress Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

08bb125241012b6a1c1852efc6443cc7a4ebecc3 Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/TestGuiceServletConfig.java 08bb125241012b6a1c1852efc6443cc7a4ebecc3 Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/rest/module/RestModule.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

--- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review152161 ------- On Oct. 8, 2016, 5:28 a.m., Apoorv Naik wrote: > > ---

Re: Review Request 52585: Implementation of the new TypesREST API

Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

f the behavior is not valid here. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151774 -------

Re: Review Request 52585: Implementation of the new TypesREST API

/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Onlt via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

ently iterate and modify the map to achieve this. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151774 --- On Oct

Re: Review Request 52585: Implementation of the new TypesREST API

on my list. > On Oct. 7, 2016, 10 a.m., Shwetha GS wrote: > > webapp/src/main/java/org/apache/atlas/web/util/TypeValidator.java, line 38 > > <https://reviews.apache.org/r/52585/diff/7/?file=1526214#file1526214line38> > > > > There is a lot of validation done in T

Re: Review Request 52585: Implementation of the new TypesREST API

ne33> > > > > These are defined in Constants as well Will change. - Apoorv ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151767 -

Re: Review Request 52585: Implementation of the new TypesREST API

e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/util/TypeValidator.java PRE-CREATION webapp/src/main/resources/errorMessages.properties PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/errorMessages.properties PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

/errorMessages.properties PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151761 --- On Oct. 6, 2016, 12:45 a.m., Apoorv Naik wrote: > > --- > This is an a

Re: Review Request 52585: Implementation of the new TypesREST API

g.io/spring-data/jpa/docs/1.11.0.M1/api/ - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151673 -----

Re: Review Request 52585: Implementation of the new TypesREST API

/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

Re: Review Request 52585: Implementation of the new TypesREST API

t; Need to revert this. repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java (line 35) <https://reviews.apache.org/r/52585/#comment220043> This needs to be fixed - Apoorv Naik On Oct. 6, 2016, 12:14 a.m.,

Review Request 52585: Implementation of the new TypesREST API

-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing --- Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1200) Enhance the Exception mechanism

[ https://issues.apache.org/jira/browse/ATLAS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1200: --- Description: Currently the error/exception messages are hand constructed all over the Atlas code

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 50) <https://reviews.apache.org/r/51896/#comment218934> e.get(0) on map ? Getting NPEs because of this. - Apoorv Naik On Sept. 29, 2016, 4:08 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically g

[jira] [Created] (ATLAS-1200) Enhance the Exception mechanism

Apoorv Naik created ATLAS-1200: -- Summary: Enhance the Exception mechanism Key: ATLAS-1200 URL: https://issues.apache.org/jira/browse/ATLAS-1200 Project: Atlas Issue Type: Improvement

[jira] [Assigned] (ATLAS-1198) Move from Guice + Spring to only Spring

[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1198: -- Assignee: Apoorv Naik > Move from Guice + Spring to only Spr

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 2:38 a.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 35 > > > > > > updateEntity() is for full-update of an entity. A new API would be > >

[jira] [Updated] (ATLAS-1198) Move from Guice + Spring to only Spring

[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1198: --- Description: Right now we're using both Guice and Spring and dependency injection which

[jira] [Created] (ATLAS-1198) Move from Guice + Spring to only Spring

Apoorv Naik created ATLAS-1198: -- Summary: Move from Guice + Spring to only Spring Key: ATLAS-1198 URL: https://issues.apache.org/jira/browse/ATLAS-1198 Project: Atlas Issue Type: Improvement

Gremlin console with underlying Titan DB

Has anyone ever attempted this ? I followed the titandb guides and was able to connect to the hbase storage backend with the table name “apache_atlas_titan” but the traversal is showing zero vertex. Here’s how I (supposedly) connected to the graph via the console graph =

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 21, 2016, 11:47 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 279 > > > > > > Instead of having multiple checks its better to abstract

[jira] [Comment Edited] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457367#comment-15457367 ] Apoorv Naik edited comment on ATLAS-1098 at 9/16/16 10:55 PM: -- Initial

[jira] [Updated] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1098: --- Attachment: ATLAS-1098.patch > Atlas allows creation of tag with name "isa" which caus

[jira] [Updated] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1098: --- Attachment: (was: ATLAS-1098.patch) > Atlas allows creation of tag with name "isa"

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

--- Tested with all possible keywords specified in the QueryParser, the UI loads up the trait definition. UnitTests create the traitDef and the dsl search gives results Thanks, Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

/DefaultMetadataServiceTest.java (line 202) <https://reviews.apache.org/r/51660/#comment216706> Need to delete this unwanted code. Doesn't correspond to the actual test Please ignore. - Apoorv Naik On Sept. 16, 2016, 5:40 a.m., Apoorv Naik

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

that the type being created is a keyword Thanks, Apoorv Naik

[jira] [Commented] (ATLAS-1098) Atlas allows creation of tag with name "isa" which causes exceptions during search

[ https://issues.apache.org/jira/browse/ATLAS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495442#comment-15495442 ] Apoorv Naik commented on ATLAS-1098: Attaching the new patch with unit tests. They seem to be failing

<    1   2   3   4   5   6   7   >