: https://reviews.apache.org/r/47107/diff/
Testing
---
Added UT - HiveAStREwriteTest and IT asserttions in HiveHookIT
Thanks,
Suma Shivaprasad
eviews.apache.org/r/47107/#review132845
-------
On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
>
> ---
> This is an automatically generated e-mail. To re
---------
On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47107/
>
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47107/#review132845
---
On May 12, 2016, 7:01 a.m., Suma Shivaprasad wrote:
>
> -
)
<https://reviews.apache.org/r/46731/#comment195990>
would be better to keep the result consistent for all CRUD operations and
standardize as EntityResult
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS
)
<https://reviews.apache.org/r/46731/#comment195992>
This will cause some users an UI to break rt?. would be better to send a
mail out to atlas-dev
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS
/EntityNotificationImpl.java
(line 95)
<https://reviews.apache.org/r/46731/#comment195996>
traits null check is missing . Could lead to NPE ? Also would be better to
split to make it more readable
- Suma Shivaprasad
On April 27, 2016, 1:05 p.m., Shwetha GS
ulting in maping the graph to
type twice. We could try Titan caching as well?
- Suma Shivaprasad
On May 4, 2016, 10:58 a.m., Hemanth Yamijala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On May 4, 2016, 3:33 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java,
> > line 56
> > <https://reviews.apache.org/r/46943/diff/2/?file=1370654#file1370654line56>
> >
> > Does it m
135/#comment196719>
can we take solr version from pom instead
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
135/#comment196721>
will this take care of a similiar fix that Shwetha did to not download if
it already exists. If not, can we add that here?
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower
135/#comment196723>
can we take hbase verion from pom instead of hardcoding pls
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/47135/#comment196724>
pls rename to create_solr_collection
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/47135/#comment196726>
what is the use of this config?
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/47135/#comment196725>
will these env vars be set by AMBARI configs?
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/47135/#comment196730>
shouldnt this be solr5
- Suma Shivaprasad
On May 9, 2016, 9:32 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
b0d4c5c
Diff: https://reviews.apache.org/r/46922/diff/
Testing
---
Added tests in HIveHookIT.testInsertIntoTempTable.
Thanks,
Suma Shivaprasad
> On April 15, 2016, 4:45 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 336
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line336>
> >
> > Can you pls follow sql
/GremlinQuery.scala (line 386)
<https://reviews.apache.org/r/45499/#comment192609>
we would also need to take care of limit and order by in withPath
expressions
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta
/Expressions.scala (line 336)
<https://reviews.apache.org/r/45499/#comment192605>
Can you pls follow sql syntax for [asc, desc] - similiar to
https://msdn.microsoft.com/en-us/library/ms188385.aspx . Would be familiar with
users. Also ASC could be made optional
- Suma Shivaprasad
On April 14, 2016
delete succeeding without
this?
- Suma Shivaprasad
On April 14, 2016, 10:29 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46011/#review129179
---
Ship it!
Ship It!
- Suma Shivaprasad
On April 15, 2016, 4
/GremlinQuery.scala (line 347)
<https://reviews.apache.org/r/45499/#comment192616>
this var could be renamed from count to something else since its a bit
confusing..since its the end offset if I am correct?
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta
/Expressions.scala (line 333)
<https://reviews.apache.org/r/45499/#comment192612>
pls add to documentaion in search.twiki
- Suma Shivaprasad
On April 14, 2016, 2:11 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically g
(line 59)
<https://reviews.apache.org/r/45929/#comment192631>
what is the expected behaviour in unclean shutdown case when lock is not
cleared? Is this an ephemeral node that will be cleared automatically?
- Suma Shivaprasad
On April 14, 2016, 3:24 p.m., Hemanth Yamijala
> On April 15, 2016, 5:24 p.m., Suma Shivaprasad wrote:
> > repository/src/main/scala/org/apache/atlas/query/Expressions.scala, line 333
> > <https://reviews.apache.org/r/45499/diff/7/?file=1344372#file1344372line333>
> >
> > pls add to documentaion in se
(line 92)
<https://reviews.apache.org/r/45929/#comment193157>
We need to add some documentation for this as part of Installation docs?.
- Suma Shivaprasad
On April 18, 2016, 6:31 p.m., Hemanth Yamijala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45929/#review129663
---
Ship it!
Ship It!
- Suma Shivaprasad
On April 18, 2016, 6
/GremlinEvaluator.scala (line
126)
<https://reviews.apache.org/r/45499/#comment193167>
instead of null, pls make the scala Option Some/None
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> ---
> This is a
/GremlinQuery.scala (line 128)
<https://reviews.apache.org/r/45499/#comment193166>
Code is duplicated . Can you pls consolidate in one class?
- Suma Shivaprasad
On April 19, 2016, 6:14 p.m., Neeru Gupta wrote:
>
> ---
> This is a
> On April 15, 2016, 6:31 p.m., Suma Shivaprasad wrote:
> > webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java, line 59
> > <https://reviews.apache.org/r/45929/diff/3/?file=1344552#file1344552line59>
> >
> > what is the expected behaviour i
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46409/#review129681
-------
On April 19, 2016, 9:29 p.m., Suma Shivaprasad wrote:
>
>
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
4c7ac70
client/src/main/java/org/apache/atlas/AtlasClient.java 22a1726
Diff: https://reviews.apache.org/r/46409/diff/
Testing
---
Added tests in HiveHookIT
Thanks,
Suma Shivaprasad
/diff/
Testing
---
Added tests in HiveHookIT
Thanks,
Suma Shivaprasad
Congrats Hemanth!
On Thu, Apr 14, 2016 at 7:05 AM, Erik Bergenholtz <
ebergenho...@hortonworks.com> wrote:
> That’s great news! Congrats & well deserved.
>
> Erik
>
> > On Apr 14, 2016, at 1:15 AM, Shwetha Shivalingamurthy <
> sshivalingamur...@hortonworks.com> wrote:
> >
> > Hi All,
> >
> > The
Thanks,
Suma Shivaprasad
/
Testing
---
Added tests in HiveHookIT
Thanks,
Suma Shivaprasad
Thanks,
Suma Shivaprasad
me.
> >
> > I am trying to understand why Step 1 is required. Is it to take care of
> > situations where the old table did not exist before in Atlas?
>
> Suma Shivaprasad wrote:
> Yes its required to create old table stat
/DeleteHandler.java
(line 67)
<https://reviews.apache.org/r/46011/#comment192210>
when is state being cleared?
- Suma Shivaprasad
On April 13, 2016, 4:12 p.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e
/GraphHelper.java
(line 184)
<https://reviews.apache.org/r/46011/#comment192233>
There could be a way to get the sorted edge list by {state, modification
time} from Titan itself by adding the edge index.
- Suma Shivaprasad
On April 13, 2016, 4:12 p.m., Shwetha GS
/SoftDeleteHandler.java
(line 42)
<https://reviews.apache.org/r/46011/#comment192240>
Should we keep timestamp same for the entire delete op?
- Suma Shivaprasad
On April 13, 2016, 4:12 p.m., Shwetha GS
tps://reviews.apache.org/r/45499/#comment193311>
Why is it necessary to use in backquote. Didnt understand that part?
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e
tps://reviews.apache.org/r/45499/#comment193321>
pls change ofset to offsetValue
- Suma Shivaprasad
On April 20, 2016, 1:46 p.m., Neeru Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45499/#review130975
---
Ship it!
Ship It!
- Suma Shivaprasad
On April 23, 2016, 12
typesystem/src/main/resources/atlas-application.properties a343a20
Diff: https://reviews.apache.org/r/46922/diff/
Testing
---
Added tests in HIveHookIT.testInsertIntoTempTable.
Thanks,
Suma Shivaprasad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46731/#review134619
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 24, 2016, 7:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47638/#review134618
---
Ship it!
Ship It!
- Suma Shivaprasad
On May 23, 2016, 6:52
/HiveHookIT.java
(line 742)
<https://reviews.apache.org/r/47638/#comment199461>
can you pls add a test with column position changed as well
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma
/HiveHook.java (line
381)
<https://reviews.apache.org/r/47638/#comment199460>
Can we overload this function instead of making it null?
- Suma Shivaprasad
On May 23, 2016, 6:52 a.m., Vimal Sharma wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50435/#review143577
---
Ship it!
Ship It!
- Suma Shivaprasad
On July 26, 2016, 3:05
/
Testing
---
Existing tests are passing
TODO : Need to add tests for TypeSerialization.
Thanks,
Suma Shivaprasad
/DefaultTypeCache.java
(line 184)
<https://reviews.apache.org/r/50397/#comment209192>
shudnt SUPERTYPE be if ( has(filterEntry.getValue()) ?
- Suma Shivaprasad
On July 25, 2016, 5:19 p.m., Shwetha GS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50397/#review143419
---
Ship it!
Ship It!
- Suma Shivaprasad
On July 25, 2016, 5:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144717
---
Ship it!
Ship It!
- Suma Shivaprasad
On Aug. 4, 2016, 4:29
typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala
f18151a
typesystem/src/main/scala/org/apache/atlas/typesystem/json/TypesSerialization.scala
5618938
Diff: https://reviews.apache.org/r/50760/diff/
Testing
---
Thanks,
Suma Shivaprasad
://reviews.apache.org/r/50760/diff/
Testing
---
Thanks,
Suma Shivaprasad
/BaseSSLAndKerberosTest.java
(line 101)
<https://reviews.apache.org/r/50747/#comment210673>
why is this commented? Dont we require kinit for zk?
- Suma Shivaprasad
On Aug. 3, 2016, 2:01 p.m., Nixon Rodrigues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50747/#review144648
---
Ship it!
Ship It!
- Suma Shivaprasad
On Aug. 3, 2016, 2:01
/BaseResourceIT.java (line
81)
<https://reviews.apache.org/r/51005/#comment211881>
use AtlasConstants for localhost:21000
- Suma Shivaprasad
On Aug. 11, 2016, 8:23 p.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50149/#review142603
---
Ship it!
Ship It!
- Suma Shivaprasad
On July 18, 2016, 5:41
/DefaultMetadataServiceTest.java
(line 257)
<https://reviews.apache.org/r/50146/#comment208234>
in the tests should we just take all reserved chars instead of a random
reserved char to ensure the test covers all characters?
- Suma Shivaprasad
On July 18, 2016, 5:10 p.m., Shwetha GS
/GraphHelper.java
(line 268)
<https://reviews.apache.org/r/50146/#comment208235>
Still see some references to outVertex.getProperty(propertyName) in
DeleteHandler. THat should be replaced?
- Suma Shivaprasad
On July 18, 2016, 5:10 p.m., Shwetha GS
tps://reviews.apache.org/r/50029/#comment208244>
should we add section for Traits as well as part of this?
- Suma Shivaprasad
On July 14, 2016, 12:58 p.m., Hemanth Yamijala wrote:
>
> ---
> This is an automatically generated e-mail.
166/#comment208308>
do we need to remove hadoop-client, hadoop-annotations as well
- Suma Shivaprasad
On July 18, 2016, 10:55 p.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50146/#review142668
---
Ship it!
Ship It!
- Suma Shivaprasad
On July 18, 2016, 5:10
> On July 19, 2016, 5:50 p.m., Suma Shivaprasad wrote:
> > client/src/main/java/org/apache/atlas/AtlasClient.java, line 1020
> > <https://reviews.apache.org/r/49625/diff/3/?file=1447349#file1447349line1020>
> >
> > Should we expose 2 APIs - one without
1019)
<https://reviews.apache.org/r/49625/#comment208401>
Should we expose 2 APIs - one without offset and limit?
- Suma Shivaprasad
On July 19, 2016, 4:45 p.m., Shwetha GS wrote:
>
> ---
> This is an automatically g
1159)
<https://reviews.apache.org/r/50209/#comment208547>
is this change needed? this should be i++ < getNumberOfretries() ? else the
retries done would be one lesser?
- Suma Shivaprasad
On July 20, 2016, 12:39 a.m., Madhan Neethi
/AtlasAuthenticationProvider.java
(line 90)
<https://reviews.apache.org/r/50209/#comment208548>
although not related to this patch...this if clause evaluating to true is
not possible since its already checked before in line 84, 85?
- Suma Shivaprasad
On July 20, 2016, 12:39 a.m., Madhan Neethiraj
://reviews.apache.org/r/49350/diff/
Testing
---
Thanks,
Suma Shivaprasad
8bbe2d7
Diff: https://reviews.apache.org/r/49350/diff/
Testing (updated)
---
Added tests for partitioned and unpartitioned export, import, load
Thanks,
Suma Shivaprasad
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java
e61e916
Diff: https://reviews.apache.org/r/50824/diff/
Testing
---
Thanks,
Suma Shivaprasad
/org/apache/atlas/typesystem/types/AttributeDefinition.java
29c3450
Diff: https://reviews.apache.org/r/50760/diff/
Testing
---
Thanks,
Suma Shivaprasad
021a8d2
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java
29c3450
Diff: https://reviews.apache.org/r/50760/diff/
Testing
---
Thanks,
Suma Shivaprasad
---
Thanks,
Suma Shivaprasad
tEdges(AtlasEdgeDirection dir, String edgeLabel)
- Suma Shivaprasad
On Aug. 8, 2016, 10:59 a.m., Shwetha GS wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
erable edges = inVertex.getEdges(Direction.IN, edgeLabel);
2. Titan0Vertex.getEdges(AtlasEdgeDirection dir, String edgeLabel)
- Suma Shivaprasad
On Aug. 8, 2016, 10:59 a.m., Shwetha GS wrote:
>
> ---
> This is an automatica
/StormTopologyUtil.java
(line 134)
<https://reviews.apache.org/r/50776/#comment210746>
should we use a HashSet instead?
- Suma Shivaprasad
On Aug. 4, 2016, 12:19 a.m., Madhan Neethiraj wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50776/#review144701
---
Ship it!
Ship It!
- Suma Shivaprasad
On Aug. 4, 2016, 12:19
/src/main/java/org/apache/atlas/hook/AtlasHook.java 8bbe2d7
Diff: https://reviews.apache.org/r/49350/diff/
Testing
---
Added tests for partitioned and unpartitioned export, import, load
Thanks,
Suma Shivaprasad
with the old edges being in DELETED state.
- Suma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49350/#review139964
-------
O
/resources/EntityResource.java
0713d30
Diff: https://reviews.apache.org/r/48939/diff/
Testing
---
Existing tests modified to query with new qualified name. Need to add tests for
INSERT INTO TABLE
Thanks,
Suma Shivaprasad
INTO TABLE
Thanks,
Suma Shivaprasad
for
INSERT INTO TABLE
Thanks,
Suma Shivaprasad
+1 for the release (binding)
Verified signatures, commit id and tag
Verified that all tests passed.
Verified quickstart and entities created in the UI
Sanity tests in UI for create, drop, alter table
Created business taxonomy and subterms and associated terms with assets
Verified DSL and
/diff/
Testing
---
Thanks,
Suma Shivaprasad
/apache/atlas/web/rest/EntityREST.java aa209f9
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java
cfe9909
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java
ee36fdf
Diff: https://reviews.apache.org/r/56206/diff/
Testing
---
Thanks,
Suma
/AtlasStructFormatConverter.java
8777510
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java
47e1fa3
Diff: https://reviews.apache.org/r/56113/diff/
Testing
---
Thanks,
Suma Shivaprasad
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
8777510
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java
47e1fa3
Diff: https://reviews.apache.org/r/56113/diff/
Testing
---
Thanks,
Suma Shivaprasad
failing . This is pending.
Thanks,
Suma Shivaprasad
/TestEntitiesREST.java
cfe9909
webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java
ee36fdf
webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
d9bffe9
Diff: https://reviews.apache.org/r/56206/diff/
Testing
---
Thanks,
Suma Shivaprasad
Diff: https://reviews.apache.org/r/56206/diff/
Testing
---
ENtityJerseyResourceIt tests failing . This is pending.
Thanks,
Suma Shivaprasad
yet another release-candidate. Only change in “release
> candidate 3” is the update to build instructions in README.txt. There are
> no other changes.
> >
> >
> >
> > We currently have 7 binding votes and 7 non-binding votes for the
> earlier release candidates. T
/DataSetLineageService.java
(line 97)
<https://reviews.apache.org/r/55813/#comment234109>
This shoudnt have superTypeNames check directly in the query since there is
no index on guid + typeName. I had removed it in ATLAS-1404
- Suma Shivaprasad
On Jan. 23, 2017, 11:17 p.m., Sarath Subramanian
: but was:
Thanks,
Suma Shivaprasad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56105/#review163626
---
Ship it!
Ship It!
- Suma Shivaprasad
On Jan. 31, 2017, 1:08
/r/56113/diff/
Testing
---
Thanks,
Suma Shivaprasad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56049/#review163409
---
Ship it!
Ship It!
- Suma Shivaprasad
On Jan. 28, 2017, 1:01
(line 769)
<https://reviews.apache.org/r/56049/#comment234868>
throw error when getISOktocommit is false
- Suma Shivaprasad
On Jan. 28, 2017, 1:01 a.m., Madhan Neethiraj wrote:
>
> ---
> This is an automatically g
101 - 200 of 1500 matches
Mail list logo
