Re: Review Request 56049: ATLAS-1472: updated type-registry to handle simultaneous updates from multiple threads

(line 747) <https://reviews.apache.org/r/56049/#comment234869> can be combined with prev if block - Suma Shivaprasad On Jan. 28, 2017, 1:01 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e

Re: Review Request 55912: Add UTS for Array, map, struct and entity updates

» AtlasBase expected type Map ... TestEntityREST.testGetEntityById:97 expected: but was: TestEntityREST.testUpdateGetDeleteEntityByUniqueAttribute:171 expected: but was: Thanks, Suma Shivaprasad

Re: Review Request 55813: Porting performance and stability changes made in 0.7 branch into master

s gets called GremlinQuery - Suma Shivaprasad On Jan. 21, 2017, 2:19 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 55912: Add UTS for Array, map, struct and entity updates

0ff33ba Diff: https://reviews.apache.org/r/55912/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes and add tests

/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174 Diff: https://reviews.apache.org/r/56535/diff/ Testing (updated) --- Added tests for hard delete and soft delete Thanks, Suma

Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes and add tests

/ Testing --- Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference Thanks, Suma Shivaprasad

Review Request 56910: Fix issues with owned map reference and add tests

repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77 Diff: https://reviews.apache.org/r/56910/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56900: ATLAS-1576: fix for NPE while handling unknown attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56900/#review166256 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 21, 2017, 10

Re: Review Request 56910: Fix issues with owned map reference and add tests

/repository/store/graph/v1/HardDeleteHandlerV1Test.java fd685c6 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77 Diff: https://reviews.apache.org/r/56910/diff/ Testing --- Thanks, Suma Shivaprasad

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

> On Feb. 23, 2017, 7:23 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java, > > line 330 > > <https://reviews.apache.org/r/56860/diff/1/?file=1644999#file1644999line330> > > > >

Re: Review Request 56206: ATLAS-1522 Entity V2 API changes to accept only AtlasObjectId for child references

> On Feb. 4, 2017, 6:39 p.m., Suma Shivaprasad wrote: > > Ship It! > > Jeff Hagelberg wrote: > How will this work for composite references? At least in V0 (I guess we > can call it that), objects referenced via a composite reference need to be > inlined.

Re: Review Request 57020: ATLAS-1593: fixed type-update handling to ensure that active type registry state is not updated while processing the changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57020/#review166787 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 24, 2017, 7:36

Re: Review Request 56860: ATLAS-1552 auto update of inverse references in V2 code path

/v1/EntityGraphMapper.java (line 330) <https://reviews.apache.org/r/56860/#comment238510> handle map case as well? - Suma Shivaprasad On Feb. 22, 2017, 11:48 p.m., David Kantor wrote: > > --- > This is an automatica

Re: Review Request 56963: DSL queries returns wrong object when filter traverses edges

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56963/#review166467 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 23, 2017, 1:51

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56585/#review165401 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 13, 2017, 11

Re: Review Request 56634: ATLAS-1522: entity typed attributes (like hive_table.sd, hive_table.columns) should use AtlasObjectId as value instead of entire entity contents

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56634/#review165453 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 14, 2017, 2:20

Re: Review Request 56535: Add tests for DeleteHandlerV1

in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference Thanks, Suma Shivaprasad

Re: Review Request 56535: Add tests for DeleteHandlerV1

in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference Thanks, Suma Shivaprasad

Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes and add tests

failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference Thanks, Suma Shivaprasad

Re: Review Request 56535: Add tests for DeleteHandlerV1

onfusing from the naming. Will take this refactoring up as part of another jira - Suma --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56535/#review165581 -

Re: Review Request 56535: Add tests for DeleteHandlerV1

ready in the last diff. Hence dropping the issue - Suma --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56535/#review165581 ---------

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

/v1/AtlasEntityGraphDiscoveryV1.java (line 111) <https://reviews.apache.org/r/56585/#comment237204> consider throwing error when entity is null - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

/v1/AtlasEntityGraphDiscoveryV1.java (line 92) <https://reviews.apache.org/r/56585/#comment237203> throw error when entity is null? - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj

Re: Review Request 56585: ATLAS-1544: implementation of v2 REST for entity create/update

/v1/EntityGraphMapper.java (line 611) <https://reviews.apache.org/r/56585/#comment237208> this is the current behaviour in case of soft delete to keep track of deleted elements - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj

Review Request 56535: Add tests for DeleteHandlerV1

a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference Thanks, Suma Shivaprasad

Re: Review Request 56553: ATLAS-1550: for unit test failure in TypeSystemTest.testDuplicateTypenames()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56553/#review165144 --- Ship it! Ship It! - Suma Shivaprasad On Feb. 10, 2017, 5:20

Re: [VOTE] Release Apache Atlas 0.7.1 (incubating) - release candidate 1 (dev group vote)

Verified * checksums * no binaries in release * build compile and tests * single node Atlas instance with HBase and Solr - came up fine. * Quickstart and ATLAS sanity tests - search, lineage +1(binding) for the release Thanks Suma On Wed, Jan 18, 2017 at 5:42 PM, Sarath Kumar Subramanian <

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55531/#review161668 --- On Jan. 19, 2017, 6:22 a.m., Suma Shivaprasad wrote: > > --- > This is an au

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

testing pending Error handling for unresolved references UTS for discovery Thanks, Suma Shivaprasad

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

/EntityDiscoveryJerseyResourceIT.java 2ade5b0 webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java d7702e2 Diff: https://reviews.apache.org/r/55531/diff/ Testing --- UTs for create TODO: Update testing pending Error handling for unresolved references UTS for discovery Thanks, Suma

Re: Review Request 55531: ATLAS-1467 Create/Full Update implementation

for discovery Thanks, Suma Shivaprasad

Re: Review Request 55753: ATLAS-1490: added methods to get sub-types of entity and classification types

ray can hold a manager or an employee. So subType check would work there - Suma Shivaprasad On Jan. 20, 2017, 10:30 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 55753: ATLAS-1490: added methods to get sub-types of entity and classification types

> On Jan. 20, 2017, 5:10 p.m., Suma Shivaprasad wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java, line > > 97 > > <https://reviews.apache.org/r/55753/diff/1/?file=1610433#file1610433line97> > > > > rename to resol

Re: Review Request 55753: ATLAS-1490: added methods to get sub-types of entity and classification types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55753/#review162455 --- Ship it! Ship It! - Suma Shivaprasad On Jan. 20, 2017, 10

Re: Review Request 57103: Implementation for classification in V2 API

Thanks, Suma Shivaprasad

Re: Review Request 57103: Implementation for classification in V2 API

Thanks, Suma Shivaprasad

Re: Review Request 57103: Implementation for classification in V2 API

/EntityMutationContext.java 23e825e webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java d7adb3a webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java d1bef78 Diff: https://reviews.apache.org/r/57103/diff/ Testing --- Tested through TestEntityREST Thanks, Suma

Re: Review Request 57227: ATLAS-1614: fixed v1 partial-update to perform attribute validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57227/#review167638 --- Ship it! Ship It! - Suma Shivaprasad On March 2, 2017, 2:18

Re: Review Request 57230: ATLAS-1613: fix for bigdecimal value handling to avoid casting to long

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57230/#review167645 --- Ship it! Ship It! - Suma Shivaprasad On March 2, 2017, 3:37

Review Request 57103: Implementation for classification in V2 API

through TestEntityREST Thanks, Suma Shivaprasad

Re: Current use cases for POST /entities

+1 On Mon, Sep 12, 2016 at 9:22 PM, Apoorv Naik wrote: > Is anyone relying on the definition object within the response of a create > entity call ? If not, let’s remove it from the response as it can be > inferred from the request body itself and the only useful piece

Re: Review Request 51829: ATLAS-1162: shutdown hooks to register with ShutdownHookManager, instead of System.Runtime

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51829/#review148638 --- Ship it! Ship It! - Suma Shivaprasad On Sept. 12, 2016, 11

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

On Sept. 22, 2016, 11:12 a.m., Jeff Hagelberg wrote: > > Enable checkstyle on new modules with this property in pom.xml - > > true > > > > With patch: > > Running org.apache.atlas.repository.graph.GraphRepoMapperScaleTest > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150982 --- Ship it! Ship It! - Suma Shivaprasad On Sept. 30, 2016, 12

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 30, 2016, 12:51 a.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 242 > > <https://reviews.apache.org/r/51896/diff/12/?file=1516536#file1516536line242> > > > > would prefer

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 48) <https://reviews.apache.org/r/51896/#comment218970> long here as well - Suma Shivaprasad On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 52077: Column level lineage in Hive

> On Sept. 21, 2016, 8:58 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java, > > line 97 > > <https://reviews.apache.org/r/52077/diff/2/?file=1505617#file1505617line97> > > > > why

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 40) <https://reviews.apache.org/r/51896/#comment218975> current APIs support batch deletion of entities by guids. If we support batch API with multiple CRUD operations , should get covered as part of that - Suma Shivaprasad On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 7:31 p.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 247 > > <https://reviews.apache.org/r/51896/diff/10/?file=1516299#file1516299line247> > > > > s

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

bunch of columns, rename storage descriptor, table etc. We should also support batch entity apis which allow for multiple CRUD operations to be batched in the same request which would all go through one transaction? - Suma Shivaprasad On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

on/set types? If thats the case, it may be more confusing with this split than with the earlier Multiplicity options. - Suma Shivaprasad On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically g

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

/AtlasStruct.java (line 49) <https://reviews.apache.org/r/51896/#comment218976> would be better to have REST APIs deal with Struct and entity interfaces instead of concrete implemenations and map them to concrete classes through JAXB annotations? - Suma Shivaprasad On Sept. 29, 2016, 6:

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

/AtlasTypeRegistry.java (line 258) <https://reviews.apache.org/r/51896/#comment218981> currently there is a in memory type cache and a storecackedtypecache and are implementations of the TypeCache interface. Where are we handling this? - Suma Shivaprasad On Sept. 29, 2016, 6:11 p.m., Madhan Neethiraj

Re: Review Request 52257: Return system attributes in get entity definition

/GraphBackedMetadataRepository.java (line 239) <https://reviews.apache.org/r/52257/#comment219692> Dont see any indexes created on these properties in GraphbackedSearchIndexer - Suma Shivaprasad On Oct. 4, 2016, 11:13 a.m., Vimal Sharma

Re: Review Request 52257: Return system attributes in get entity definition

/Id.java (line 54) <https://reviews.apache.org/r/52257/#comment219696> sorry didnt notice this earlier. Didnt get why these were added as part of the Id? They dont uniquely identify an entity and should not go into the Id IMO. - Suma Shivaprasad On Oct. 4, 2016, 11:13 a.m.,

Re: Review Request 52257: Return system attributes in get entity definition

/GraphBackedMetadataRepository.java (line 295) <https://reviews.apache.org/r/52257/#comment219698> can we add asserts in getEntityDefintion for these props? - Suma Shivaprasad On Oct. 4, 2016, 11:13 a.m., Vimal Sharma

Re: Review Request 52257: Return system attributes in get entity definition

/InstanceSerializationTest.scala (line 94) <https://reviews.apache.org/r/52257/#comment219694> can we add valid date data in the tests? Also can you add a test for these keys in GraphBackedDiscoveryServiceTest. - Suma Shivaprasad On Oct. 4, 2016, 11:13 a.m., Vimal Sharma

Re: Review Request 52478: ATLAS-1171: updated APIs that return list to use REST serialization friendly list classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52478/#review151369 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 3, 2016, 4:39

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/AtlasGraphManagement.java (line 111) <https://reviews.apache.org/r/47810/#comment219710> Does the index here refer to the edgeLabel we are trying to create an idex for? Do we have everything we need in this interface to index an edge label? - Suma Shivaprasad On Oct. 4, 2016, 1:

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/DefaultMetadataService.java (line 295) <https://reviews.apache.org/r/47810/#comment219716> why is this needed? We fixed this earlier by allowing keywords which are escaped by quotes `` - Suma Shivaprasad On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/AtlasGraphManagement.java (line 78) <https://reviews.apache.org/r/47810/#comment219713> can we change the vararg to a List everywhee to keep it consistent? - Suma Shivaprasad On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/GraphBackedSearchIndexer.java (line 356) <https://reviews.apache.org/r/47810/#comment219718> can remove propertyname and get it from PropertyKey everywhere? - Suma Shivaprasad On Oct. 4, 2016, 1:28 a.m., Jeff Hagelberg

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote: > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java, > > line 130 > > <https://reviews.apache.org/r/47810/diff/13-14/?file=150#file150line130> > >

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 23, 2016, 8:36 p.m., Suma Shivaprasad wrote: > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java, > > line 188 > > <https://reviews.apache.org/r/47810/diff/13/?file=1508908#file1508908line188> > > > &g

Re: Review Request 51939: Framework to apply updates to types in the type-system

g/r/51939/#comment217262> Log instead of PTS - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51939: Framework to apply updates to types in the type-system

/DefaultMetadataService.java (line 191) <https://reviews.apache.org/r/51939/#comment217263> it would make more sense to sort by date instead of file name? - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian

Re: Review Request 51939: Framework to apply updates to types in the type-system

/GraphBackedTypeStore.java (line 351) <https://reviews.apache.org/r/51939/#comment217189> Log type version change at info level - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian

Re: Review Request 51939: Framework to apply updates to types in the type-system

/GraphBackedTypeStore.java (line 68) <https://reviews.apache.org/r/51939/#comment217190> is this the default type version. If so, pls rename as DEFAULT_TYPE_VERSION - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/GremlinQuery.scala (line 489) <https://reviews.apache.org/r/47810/#comment218118> filter in Titan 0.5.4 doesnt use any index. Is it the same for Titan 1.0.0 ? Which types does this apply to - map, etc? - Suma Shivaprasad On Sept. 23, 2016, 3:29 a.m., Jeff Hagelberg

Re: Review Request 52077: Column level lineage in Hive

/ColumnLineageUtils.java (line 101) <https://reviews.apache.org/r/52077/#comment218104> should be replaced with HMSB.getTableQualifiedName - Suma Shivaprasad On Sept. 22, 2016, 11:53 a.m., Vimal Sharma

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

ations for Titan0, Titan1, any other property graph db . the API could be changed to something like indexFullText(indexname, Map<String, Object> params) and the implemenation for Titan0 would have the backing index in alongother required params cardinality etc. - Suma Shivaprasad On Se

Re: Review Request 52077: Column level lineage in Hive

> On Sept. 21, 2016, 8:58 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java, > > line 97 > > <https://reviews.apache.org/r/52077/diff/2/?file=1505617#file1505617line97> > > > > why

Re: Review Request 52166: Allow optional attributes to be removed when updating type

-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52166/ > --- > > (Updated Sept. 22, 2016, 6:22 p.m.) > > > Review request for atlas, Madhan

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/GremlinQuery.scala (line 324) <https://reviews.apache.org/r/47810/#comment218122> Can you pls raise a jira for this? - Suma Shivaprasad On Sept. 23, 2016, 3:29 a.m., Jeff Hagelberg wrote: > > --- > This is an automatically generated e

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

/GremlinQuery.scala (line 549) <https://reviews.apache.org/r/47810/#comment218123> Is this change, fixing a bug in current code? if so, can you pls explain? - Suma Shivaprasad On Sept. 23, 2016, 3:29 a.m., Jeff Hagelberg

Re: Review Request 51939: Framework to apply updates to types in the type-system

/DefaultMetadataService.java (line 234) <https://reviews.apache.org/r/51939/#comment217385> we should log how many patch files were suceesfully applied out of the total count - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian

Re: Review Request 51939: Framework to apply updates to types in the type-system

/DefaultMetadataService.java (line 231) <https://reviews.apache.org/r/51939/#comment217381> this should be ERROR level - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian wrote: > > --- > This is an automatica

Re: Review Request 51939: Framework to apply updates to types in the type-system

/HierarchicalType.java (line 62) <https://reviews.apache.org/r/51939/#comment217387> DEFAULT_TYPE_VERSION seems to be defined in multiple places. should be defined at a single place and could go to AtlasConstants - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subramanian

Re: Review Request 51939: Framework to apply updates to types in the type-system

/TypeSystem.java (line 314) <https://reviews.apache.org/r/51939/#comment217407> We would need to audit types as well to know what was the original type definition that was updated and the patch that was applied. - Suma Shivaprasad On Sept. 19, 2016, 6:10 p.m., Sarath Kumar Subra

Re: Review Request 52077: Column level lineage in Hive

(line 97) <https://reviews.apache.org/r/52077/#comment217663> why is column qualifiedName different from the convention we are using for hive_column instances which are referred to from the table. Why is clustername removed? - Suma Shivaprasad On Sept. 20, 2016, 9:07 a.

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 35) <https://reviews.apache.org/r/51896/#comment218846> why do we need GUIDs for types? - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 35) <https://reviews.apache.org/r/51896/#comment218836> Enums dont have a GUID. - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

/AtlasObjectId.java (line 40) <https://reviews.apache.org/r/51896/#comment218847> why is version removed? - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

49) <https://reviews.apache.org/r/51896/#comment218848> can use generics instead of Object - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

) <https://reviews.apache.org/r/51896/#comment218838> sortType can be an enum. - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

) <https://reviews.apache.org/r/51896/#comment218839> startIndex should be long - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

(line 35) <https://reviews.apache.org/r/51896/#comment218843> How are we differentiating between Partial updates vs fullupdates? - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

66) <https://reviews.apache.org/r/51896/#comment218845> could be moved to ArrayType - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 52257: Return system attributes in get entity definition

/GraphToTypedInstanceMapper.java (line 76) <https://reviews.apache.org/r/52257/#comment218689> this should be CREATTION_TIMESTAMP? - Suma Shivaprasad On Sept. 26, 2016, 10:03 a.m., Vimal Sharma wrote: > > --- > This is a

Re: Rename trait to classification

Thanks Mandy for the detailed explanation. To add to what David has already stated, We could expose two higher level ATLAS types/concepts which are based on current Traits. 1. Classification - that are locked down and that have a classification scheme to group together a set of classification

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

easily be missed by user while supplying values - Suma Shivaprasad On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 8:41 p.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 31 > > > > > > I agree, such API could be useful. Once we have concrete usecases > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 6:55 p.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 31 > > <https://reviews.apache.org/r/51896/diff/10/?file=1516287#file1516287line31> > > > > Current existing implementations

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

) <https://reviews.apache.org/r/51896/#comment218844> is resultSize = limit ? - Suma Shivaprasad On Sept. 28, 2016, 6:43 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review152059 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 7, 2016, 9:28

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote: > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java, > > line 130 > > <https://reviews.apache.org/r/47810/diff/13-14/?file=150#file150line130> > >

Re: Review Request 53073: Lineage REST API v2 implementation

/InstanceLineageService.java (line 61) <https://reviews.apache.org/r/53073/#comment223645> can you add tests for Service and REST API? - Suma Shivaprasad On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian wrote: > > --- > This is a

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

/GraphBackedSearchIndexer.java (line 281) <https://reviews.apache.org/r/53207/#comment223647> Do checks by TypeCategory rather another constant - Suma Shivaprasad On Oct. 28, 2016, 2:18 a.m., Apoorv Naik

Re: Review Request 53073: Lineage REST API v2 implementation

/InstanceLineageService.java (line 180) <https://reviews.apache.org/r/53073/#comment223659> looks like depth is not being pushed to the closure query? we should ideally push it to the query - Suma Shivaprasad On Oct. 22, 2016, 12:25 a.m., Sarath Subramanian

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

/GraphBackedSearchIndexer.java (line 631) <https://reviews.apache.org/r/53207/#comment223650> log exception if its not getting logged upstream - Suma Shivaprasad On Oct. 28, 2016, 2:18 a.m., Apoorv Naik

<    1   2   3   4   5   6   7   8   9   10   >