Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-16 Thread Apoorv Naik
gt; Can be changed to a HashSet too. repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java Lines 151 (patched) <https://reviews.apache.org/r/60159/#comment251928> No need of MapUtil check here as the map is already instantiated - Apoorv Naik On June 16, 2017, 6:05

Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-16 Thread Apoorv Naik
scovery/SolrSearchStep.java PRE-CREATION repository/src/test/java/org/apache/atlas/TestModules.java 095af417 repository/src/test/java/org/apache/atlas/discovery/GremlinSearchStepTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java 5d5b043e webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ea550211 Diff: https://reviews.apache.org/r/60159/diff/1/ Testing --- In progress 1. Tested Json marshalling and unmarshalling via REST Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1880) Search using entity and trait attributes

2017-06-16 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1880: --- Attachment: 0001-ATLAS-1880-Search-using-entity-and-trait-attributes.patch Sub-task 1 & 2 >

[jira] [Created] (ATLAS-1883) Gremlin search implementation

2017-06-16 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1883: -- Summary: Gremlin search implementation Key: ATLAS-1883 URL: https://issues.apache.org/jira/browse/ATLAS-1883 Project: Atlas Issue Type: Sub-task

[jira] [Created] (ATLAS-1884) Mixed-mode and intelligent querying

2017-06-16 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1884: -- Summary: Mixed-mode and intelligent querying Key: ATLAS-1884 URL: https://issues.apache.org/jira/browse/ATLAS-1884 Project: Atlas Issue Type: Sub-task

[jira] [Created] (ATLAS-1882) Solr (indexed) search implementation

2017-06-16 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1882: -- Summary: Solr (indexed) search implementation Key: ATLAS-1882 URL: https://issues.apache.org/jira/browse/ATLAS-1882 Project: Atlas Issue Type: Sub-task

[jira] [Created] (ATLAS-1881) Request structure design

2017-06-16 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1881: -- Summary: Request structure design Key: ATLAS-1881 URL: https://issues.apache.org/jira/browse/ATLAS-1881 Project: Atlas Issue Type: Sub-task Reporter

[jira] [Created] (ATLAS-1880) Search using entity and trait attributes

2017-06-16 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1880: -- Summary: Search using entity and trait attributes Key: ATLAS-1880 URL: https://issues.apache.org/jira/browse/ATLAS-1880 Project: Atlas Issue Type: Improvement

[jira] [Commented] (ATLAS-1878) NPE when a request without any query path lands on atlas

2017-06-16 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052060#comment-16052060 ] Apoorv Naik commented on ATLAS-1878: looks good. Will commit shortly > NPE when a request without

Re: Review Request 60059: rename endpoints

2017-06-14 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60059/#review177975 --- Ship it! Ship It! - Apoorv Naik On June 15, 2017, 1:23 a.m

Re: Review Request 60059: rename endpoints

2017-06-14 Thread Apoorv Naik
> On June 14, 2017, 6:50 p.m., Apoorv Naik wrote: > > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasRelationshipDef.java > > Line 33 (original), 33 (patched) > > <https://reviews.apache.org/r/60059/diff/1/?file=1751300#file1751300li

Re: Review Request 60059: rename endpoints

2017-06-14 Thread Apoorv Naik
> On June 14, 2017, 6:50 p.m., Apoorv Naik wrote: > > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > > Line 27 (original), 27 (patched) > > <https://reviews.apache.org/r/60059/diff/1/?file=1751301#file1751301line27> > > > >

Re: Review Request 60066: ATLAS-1865 - Cannot create trait/term in Chinese

2017-06-14 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60066/#review177912 --- Can you add test cases for this ? - Apoorv Naik On June 14

[jira] [Updated] (ATLAS-1872) Spring based bean ordering/configuration change

2017-06-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1872: --- Attachment: (was: 0001-ATLAS-1872-Spring-fix-for-Kerberos-and-bean-ordering.patch) > Spr

[jira] [Updated] (ATLAS-1872) Spring based bean ordering/configuration change

2017-06-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1872: --- Affects Version/s: (was: 0.6-incubating) 0.8-incubating > Spring ba

[jira] [Updated] (ATLAS-1872) Spring based bean ordering/configuration change

2017-06-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1872: --- Attachment: 0001-ATLAS-1872-Spring-fix-for-Kerberos-and-bean-ordering.patch > Spring based b

[jira] [Updated] (ATLAS-1872) Spring based bean ordering/configuration change

2017-06-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1872: --- Request participants: Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, Nixon Rodrigues

[jira] [Created] (ATLAS-1872) Spring based bean ordering/configuration change

2017-06-12 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1872: -- Summary: Spring based bean ordering/configuration change Key: ATLAS-1872 URL: https://issues.apache.org/jira/browse/ATLAS-1872 Project: Atlas Issue Type: Bug

Re: Review Request 59719: ATLAS-1852 Create RelationshipDef

2017-06-10 Thread Apoorv Naik
> On June 11, 2017, 4:50 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndPointDef.java > > Lines 140 (patched) > > > > > > I think it will be good to rename

[jira] [Created] (ATLAS-1870) Audit repository should be Hbase by default

2017-06-09 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1870: -- Summary: Audit repository should be Hbase by default Key: ATLAS-1870 URL: https://issues.apache.org/jira/browse/ATLAS-1870 Project: Atlas Issue Type: Bug

Re: Review Request 59799: ATLAS-1766 : Atlas with Kafka SASL_SSL protocol

2017-06-05 Thread Apoorv Naik
50480> StringUtils.isNotEmpty(groupId) notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java Lines 40 (patched) <https://reviews.apache.org/r/59799/#comment250481> Can you add Javadoc for this ? - Apoorv Naik

[jira] [Resolved] (ATLAS-1850) Deletion of type does not refresh view

2017-05-31 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1850. Resolution: Duplicate Assignee: Apoorv Naik This issue has been fixed and is available

[jira] [Commented] (ATLAS-1390) IBM Graph implementation of graph DB abstraction

2017-05-30 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029833#comment-16029833 ] Apoorv Naik commented on ATLAS-1390: [~grahamwallis] is validating this change. There's another JIRA

[jira] [Created] (ATLAS-1835) Unit tests not being run on Jenkins/mac

2017-05-26 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1835: -- Summary: Unit tests not being run on Jenkins/mac Key: ATLAS-1835 URL: https://issues.apache.org/jira/browse/ATLAS-1835 Project: Atlas Issue Type: Bug

[jira] [Updated] (ATLAS-1834) TestNG asserts across tests instead on JUnit

2017-05-26 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1834: --- Attachment: 0002-ATLAS-1834-TestNG-asserts-over-JUnit-for-consistency.patch > TestNG asserts acr

[jira] [Created] (ATLAS-1834) TestNG asserts across tests instead on JUnit

2017-05-26 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1834: -- Summary: TestNG asserts across tests instead on JUnit Key: ATLAS-1834 URL: https://issues.apache.org/jira/browse/ATLAS-1834 Project: Atlas Issue Type: Bug

Re: Review Request 59533: Test Sandbox fix

2017-05-25 Thread Apoorv Naik
/ Changes: https://reviews.apache.org/r/59533/diff/1-2/ Testing --- mvn clean package executes successfully mvn clean install executes successfully with one consitent failure related to notification processing. Thanks, Apoorv Naik

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-25 Thread Apoorv Naik
las is trying to use Tinkerpop 2 syntax > > with a Tinkerpop 3 graph; hence the confusion looking for an 'in' property > > for the class 'T'. In TP3, there are first-class predicates, such as > > within(), that I think should be used for this query. So it seems like the &

Re: Review Request 56959: Import API: Added Support for Transforming Entities During Import

2017-05-25 Thread Apoorv Naik
level. - Apoorv Naik On May 25, 2017, 5:16 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 56959: Import API: Added Support for Transforming Entities During Import

2017-05-24 Thread Apoorv Naik
/AtlasImportRequest.java Lines 45 (patched) <https://reviews.apache.org/r/56959/#comment249370> Is this used anymore ? intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java Lines 83 (patched) <https://reviews.apache.org/r/56959/#comment249371> Same here - Apoorv Naik

Review Request 59533: Test Sandbox fix

2017-05-24 Thread Apoorv Naik
/test/java/org/apache/atlas/graph/GraphSandboxUtil.java 44ad4fc0 Diff: https://reviews.apache.org/r/59533/diff/1/ Testing --- mvn clean package executes successfully mvn clean install executes successfully with one consitent failure related to notification processing. Thanks, Apoorv Naik

[jira] [Comment Edited] (ATLAS-1198) Move from Guice + Spring to only Spring

2017-05-23 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935810#comment-15935810 ] Apoorv Naik edited comment on ATLAS-1198 at 5/23/17 9:43 PM: - Patch ready

[jira] [Updated] (ATLAS-1198) Move from Guice + Spring to only Spring

2017-05-23 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1198: --- Attachment: 0001-ATLAS-1198-Spring-Framework-v4-with-Spring-security-.patch > Move from Gu

Re: Review Request 59378: Basic Search Performance Improvement

2017-05-18 Thread Apoorv Naik
/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java Lines 102 (patched) <https://reviews.apache.org/r/59378/#comment248894> Let's not use Whitebox in UT, ideally you never want to test the private methods directly only via a public method route. - Apoorv Naik On May 1

Re: Review Request 59321: [ATLAS-1807] : Enhance DSL query to support "like" operator for wildcard searches

2017-05-16 Thread Apoorv Naik
- > > (Updated May 16, 2017, 8:06 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1807 > https://issues.apache.org/jira/browse/ATLAS-1807 > > > Repository: atlas > &

Re: [QUESTION] Change Findbugs to fail a build on error

2017-05-16 Thread Apoorv Naik
I think Nixon has a good point. I think it’s possible to configure apache Jenkins instance to fail any builds that add new issues. Let’s follow up with a PMC or Infra to make necessary changes to the Jenkins build job. On 5/15/17, 11:27 PM, "Nixon Rodrigues"

Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls

2017-05-15 Thread Apoorv Naik
> On May 15, 2017, 4:12 p.m., Apoorv Naik wrote: > > Similarly here, would it be possible for you to go through all modules and > > check if any unused dependency declaration exists. > > Jan Hentschel wrote: > Thanks for the review. It seems that SLF4J is duplicat

Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

2017-05-15 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59262/#review174973 --- Ship it! Ship It! - Apoorv Naik On May 14, 2017, 12:20 p.m

Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

2017-05-15 Thread Apoorv Naik
> On May 15, 2017, 4:13 p.m., Apoorv Naik wrote: > > I think there are other modules too where there are quite a few findbugs > > errors. Could you check on that too ? > > Jan Hentschel wrote: > I already created a list, but it seems that there are too much errors

Re: Review Request 59261: ATLAS-1784: Use explicit imports instead of wildcards

2017-05-15 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59261/#review174964 --- Ship it! Ship It! - Apoorv Naik On May 14, 2017, 11:56 a.m

Re: Review Request 59262: ATLAS-1785: Fix Findbugs problems in falcon-bridge module

2017-05-15 Thread Apoorv Naik
findbugs errors. Could you check on that too ? - Apoorv Naik On May 14, 2017, 12:20 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59263: ATLAS-1786: Remove duplicate dependency for atlas-graphdb-impls

2017-05-15 Thread Apoorv Naik
modules and check if any unused dependency declaration exists. - Apoorv Naik On May 14, 2017, 3:57 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59264: ATLAS-1787: Replace explicit type with diamond operator

2017-05-15 Thread Apoorv Naik
for consistency ? - Apoorv Naik On May 14, 2017, 4:58 p.m., Jan Hentschel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Updated] (ATLAS-1780) Type deletion blocks ability to redefine same type with different attribute

2017-05-11 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1780: --- Description: This change supports the use-case where the user creates a type and deletes it sometime

[jira] [Created] (ATLAS-1780) Type deletion blocks ability to redefine same type with different attribute

2017-05-11 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1780: -- Summary: Type deletion blocks ability to redefine same type with different attribute Key: ATLAS-1780 URL: https://issues.apache.org/jira/browse/ATLAS-1780 Project: Atlas

Re: Review Request 58985: Type deletion should invalidate property key in titan

2017-05-11 Thread Apoorv Naik
84ad72c8 Diff: https://reviews.apache.org/r/58985/diff/2/ Testing --- mvn clean package and mvn clean install run successfully. Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1778) Incorrect error code returned in V2 APIs when updating an entity with invalid values using PUT/POST

2017-05-10 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1778: --- Attachment: 0001-ErrorCode-fixes-and-bad-request-when-invalid-attribu.patch > Incorrect error c

[jira] [Assigned] (ATLAS-1778) Incorrect error code returned in V2 APIs when updating an entity with invalid values using PUT/POST

2017-05-10 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1778: -- Assignee: Apoorv Naik > Incorrect error code returned in V2 APIs when updating an ent

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-10 Thread Apoorv Naik
et to the bottom of this > > problem yet. I will look into how AtlasGraphProvider is supposed to work. Good to know that you were able to get past the initial hurdles. The profile activation issue is a bit strange as on my system (mac os) I'm able to build titan1 and ibm-graph just by using

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

2017-05-09 Thread Apoorv Naik
/3-4/ Testing --- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1769) Spring session management

2017-05-07 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1769: --- Issue Type: Sub-task (was: Improvement) Parent: ATLAS-1198 > Spring session managem

Re: Review Request 58985: Type deletion should invalidate property key in titan

2017-05-05 Thread Apoorv Naik
lly generated e-mail. To reply, visit: https://reviews.apache.org/r/58985/#review174009 ------- On May 4, 2017, 10:07 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r

Re: Review Request 58985: Type deletion should invalidate property key in titan

2017-05-04 Thread Apoorv Naik
/ Changes: https://reviews.apache.org/r/58985/diff/1-2/ Testing --- mvn clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Re: Review Request 58985: Type deletion should invalidate property key in titan

2017-05-04 Thread Apoorv Naik
ray/entity. Let me check with Suma too. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58985/#review173954 -------

Re: Review Request 58985: Type deletion should invalidate property key in titan

2017-05-04 Thread Apoorv Naik
y bad, typo for the comparison. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58985/#review173954 --- On May 4, 2017, 4:26 p.m

Re: Review Request 56724: ATLAS-1390: Add IBM Graph Support

2017-05-04 Thread Apoorv Naik
> On May 4, 2017, 5:31 p.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java > > Line 84 (original) > > > > > > why was this removed? The executeGremlin call has

Re: Review Request 58803: ATLAS-1390: IBM graph implementation

2017-05-04 Thread Apoorv Naik
=== > > >>>>>>> theirs > > > > I also had other build problems - e.g. that (abstract class) > > GremlinExpressionFactory is not found. > > > > I hope this is helpful - if you need more information or if I've missed >

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

2017-05-04 Thread Apoorv Naik
o generate > > the names with incrementing numbers would be more determinisic. > > Apoorv Naik wrote: > Makes sense, will add some deterministic logic here. Updated the code David. - Apoorv --- This is an automatical

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

2017-05-04 Thread Apoorv Naik
/58945/diff/2-3/ Testing --- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Re: Review Request 58985: Type deletion should invalidate property key in titan

2017-05-04 Thread Apoorv Naik
--- mvn clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Review Request 58985: Type deletion should invalidate property key in titan

2017-05-04 Thread Apoorv Naik
clean package and mvn clean install run successfully. Thanks, Apoorv Naik

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

2017-05-03 Thread Apoorv Naik
reply, visit: https://reviews.apache.org/r/58945/#review173702 ------- On May 3, 2017, 6:04 a.m., Apoorv Naik wrote: > > --- > This is an automatically

Re: Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

2017-05-03 Thread Apoorv Naik
--- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Review Request 58945: ATLAS-1753: Sandbox graph instance for each test

2017-05-02 Thread Apoorv Naik
/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 3161a0da Diff: https://reviews.apache.org/r/58945/diff/1/ Testing --- mvn clean package was successful with a 5 min speedup on my local mac laptop. Thanks, Apoorv Naik

Re: Review Request 58746: Type validations with special character handling

2017-05-01 Thread Apoorv Naik
/diff/5/ Changes: https://reviews.apache.org/r/58746/diff/4-5/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58746: Type validations with special character handling

2017-05-01 Thread Apoorv Naik
/repository/typestore/GraphBackedTypeStore.java 7037d1eb Diff: https://reviews.apache.org/r/58746/diff/4/ Changes: https://reviews.apache.org/r/58746/diff/3-4/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58833: Typedef validations during create/update

2017-05-01 Thread Apoorv Naik
> > It does not seem right to change the eror code like this - wouldn't it > > be better to set the code correctly when it is originally created - rather > > than fix it up later. > > Apoorv Naik wrote: > As per my experience with REST APIs I never saw a 404 during a PUT

Re: Review Request 58833: Typedef validations during create/update

2017-05-01 Thread Apoorv Naik
Diff: https://reviews.apache.org/r/58833/diff/2/ Changes: https://reviews.apache.org/r/58833/diff/1-2/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1762) Specifying invalid types for superTypes , datatype throws 404 Not Found.

2017-05-01 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1762: -- Summary: Specifying invalid types for superTypes , datatype throws 404 Not Found. Key: ATLAS-1762 URL: https://issues.apache.org/jira/browse/ATLAS-1762 Project: Atlas

Re: Review Request 58746: Type validations with special character handling

2017-05-01 Thread Apoorv Naik
/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/3/ Changes: https://reviews.apache.org/r/58746/diff/2-3/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

[jira] [Assigned] (ATLAS-1747) Difference in result of POSTing Structs to V1 APIs and V2 APIs

2017-05-01 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1747: -- Assignee: Apoorv Naik > Difference in result of POSTing Structs to V1 APIs and V2 A

[jira] [Updated] (ATLAS-1736) Type registration becomes inconsistent after creating a type with attribute name having special characters.

2017-04-28 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1736: --- Fix Version/s: 0.9-incubating > Type registration becomes inconsistent after creating a t

[jira] [Updated] (ATLAS-1736) Type registration becomes inconsistent after creating a type with attribute name having special characters.

2017-04-28 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1736: --- Fix Version/s: 0.8-incubating trunk > Type registration becomes inconsistent af

[jira] [Assigned] (ATLAS-1736) Type registration becomes inconsistent after creating a type with attribute name having special characters.

2017-04-28 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1736: -- Assignee: Apoorv Naik > Type registration becomes inconsistent after creating a t

[jira] [Assigned] (ATLAS-1730) Error after updating attribute's data type of an Atlas type

2017-04-28 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1730: -- Assignee: Apoorv Naik > Error after updating attribute's data type of an Atlas t

Review Request 58803: ATLAS-1390: IBM graph implementation

2017-04-28 Thread Apoorv Naik
, Apoorv Naik

Review Request 58833: Typedef validations during create/update

2017-04-27 Thread Apoorv Naik
- repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 82465bfc Diff: https://reviews.apache.org/r/58833/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58746: ATLAS-1736: Type validations with special character handling

2017-04-27 Thread Apoorv Naik
/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/2/ Changes: https://reviews.apache.org/r/58746/diff/1-2/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 56724: ATLAS-1390: Add IBM Graph Support

2017-04-27 Thread Apoorv Naik
this change. - Apoorv Naik On March 2, 2017, 10:17 p.m., Jeff Hagelberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 58746: ATLAS-1736: Type validations with special character handling

2017-04-26 Thread Apoorv Naik
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 7037d1eb Diff: https://reviews.apache.org/r/58746/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1753) Sandbox each test's DB/data

2017-04-25 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1753: --- Summary: Sandbox each test's DB/data (was: Sandbox each test data to avoid ) > Sandbox each tes

[jira] [Created] (ATLAS-1753) Sandbox each test data to avoid

2017-04-25 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1753: -- Summary: Sandbox each test data to avoid Key: ATLAS-1753 URL: https://issues.apache.org/jira/browse/ATLAS-1753 Project: Atlas Issue Type: Improvement

[jira] [Created] (ATLAS-1746) Test refactor and cleanup

2017-04-21 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1746: -- Summary: Test refactor and cleanup Key: ATLAS-1746 URL: https://issues.apache.org/jira/browse/ATLAS-1746 Project: Atlas Issue Type: Bug Affects Versions

Re: Review Request 58588: [ATLAS-1742] : Provide option in server side to exclude deleted entities in basic and fulltext search

2017-04-21 Thread Apoorv Naik
/DiscoveryREST.java Lines 117 (patched) <https://reviews.apache.org/r/58588/#comment245687> Maybe just excludeDeleted - Apoorv Naik On April 20, 2017, 7:23 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e

Re: Review Request 58588: [ATLAS-1742] : Provide option in server side to exclude deleted entities in basic and fulltext search

2017-04-21 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58588/#review172592 --- Ship it! Ship It! - Apoorv Naik On April 20, 2017, 7:23 p.m

[jira] [Created] (ATLAS-1741) Runtime (NPE) Exception in StormTopologyUtils with secure Kafka

2017-04-20 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1741: -- Summary: Runtime (NPE) Exception in StormTopologyUtils with secure Kafka Key: ATLAS-1741 URL: https://issues.apache.org/jira/browse/ATLAS-1741 Project: Atlas

Re: Review Request 57655: Javadocs and comment changes for Enunciate/Swagger

2017-04-19 Thread Apoorv Naik
--- On April 19, 2017, 10:50 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57655/ >

[jira] [Commented] (ATLAS-1735) Coverity Scan Issues Detected on 4/13

2017-04-19 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974809#comment-15974809 ] Apoorv Naik commented on ATLAS-1735: Committed to master and 0.8 incubating master = https://git1-us

[jira] [Updated] (ATLAS-1735) Coverity Scan Issues Detected on 4/13

2017-04-19 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1735: --- Fix Version/s: 0.8-incubating > Coverity Scan Issues Detected on 4

[jira] [Commented] (ATLAS-1707) Atlas WUI on continues loading behind FireWall

2017-04-19 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974807#comment-15974807 ] Apoorv Naik commented on ATLAS-1707: Fix committed to master and 0.8-incubating master -> ht

Re: Review Request 58419: ATLAS-1707 : Atlas WUI on continues loading behind FireWall

2017-04-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58419/#review172343 --- Ship it! Ship It! - Apoorv Naik On April 13, 2017, 3:20 p.m

Re: Review Request 58333: TypesREST to support creation in an update call

2017-04-18 Thread Apoorv Naik
cially for types - so > > we can explicitly understand the intent of the operation as create or > > update for governance. > > Apoorv Naik wrote: > Yes that's correct. Let me revisit this and see if it makes more sense to > introduce a new endpoint for this fun

Re: Review Request 58333: TypesREST to support creation in an update call

2017-04-13 Thread Apoorv Naik
ypedefs/createOrUpdate - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58333/#review171862 --- On April 12, 2

[jira] [Commented] (ATLAS-1708) Incorrect error code while querying an entity for tag for which tag association is removed.

2017-04-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967128#comment-15967128 ] Apoorv Naik commented on ATLAS-1708: It's the same check just at a different location. :) > Incorr

[jira] [Commented] (ATLAS-1708) Incorrect error code while querying an entity for tag for which tag association is removed.

2017-04-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967127#comment-15967127 ] Apoorv Naik commented on ATLAS-1708: Can you add this condition to Line 302 in EntityGraphRetriever

Re: Review Request 58333: TypesREST to support creation in an update call

2017-04-12 Thread Apoorv Naik
, Apoorv Naik

[jira] [Commented] (ATLAS-1717) Export & Import API: Documentation

2017-04-12 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966406#comment-15966406 ] Apoorv Naik commented on ATLAS-1717: Committed to master and 0.8-incubating master = ceea868d 0.8

Re: Review Request 58189: Export & Import: Documentation Updated

2017-04-12 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58189/#review171774 --- Ship it! Ship It! - Apoorv Naik On April 4, 2017, 10:17 p.m

Re: Review Request 58333: TypesREST to support creation in an update call

2017-04-11 Thread Apoorv Naik
sTypeDefStore ? - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58333/#review171657 --- On April 11, 2017, 5:03 a.m., Apoorv Naik wr

Re: Review Request 58353: ATLAS-1727: Mask userdetails in quick Start utility

2017-04-11 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58353/#review171578 --- Ship it! Ship It! - Apoorv Naik On April 11, 2017, 1:22 p.m

  1   2   3   4   5   6   7   >